)]}'
{"id":"openstack%2Fpython-manilaclient~773448","triplet_id":"openstack%2Fpython-manilaclient~master~I5972f3df43f36b6a73f13a26d6748f05959433eb","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1912704","hashtags":[],"change_id":"I5972f3df43f36b6a73f13a26d6748f05959433eb","subject":"Don\u0027t display pagination links","status":"NEW","created":"2021-02-01 16:27:25.000000000","updated":"2021-02-17 17:28:20.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":false,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"09ffe8fe5ac908c2bbf4a9e511bb537a4ee0af52","_number":773448,"virtual_id_number":773448,"owner":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2021-02-09 23:53:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":-1,"date":"2021-02-17 17:28:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"CC":[{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"REVIEWER":[{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-02-01 17:13:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-02-01 17:55:19.000000000","updated_by":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"CC"},{"updated":"2021-02-01 22:00:57.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"}],"messages":[{"id":"f3769de51cc8e38e7ae481e374bc605e7cc3b7f2","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"date":"2021-02-01 16:27:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"566946755e7e28c153781b1f1441856b34523c52","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-01 17:13:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/5ef208348df946a08360550568753c85 : SUCCESS in 6m 55s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6f1fe02f3dc448b587e6f07b29a5f429 : SUCCESS in 4m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/29765feb98b54899962fabfa120e2a55 : SUCCESS in 4m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/399260cfe4f847b3bdc8afa0e3740458 : SUCCESS in 3m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9d9ffa89858b4bc2b19568d9cf7c39fb : SUCCESS in 4m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/859c4c848e5a44329d0af04b77cd1779 : SUCCESS in 4m 24s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/8ddeea4b1e4548259348865931259681 : SUCCESS in 4m 06s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/0f4c24158e0a4419be2861d46b7931c7 : SUCCESS in 40m 38s","accounts_in_message":[],"_revision_number":1},{"id":"f3716880144623c23c45a9f28d6397ccb1f6ad22","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-02-01 17:55:19.000000000","message":"Patch Set 1:\n\nNicole, thank you for working on this bug fix. Since you\u0027re touching the manila client shell, would you be kind to include a release note for this bug fix? \n\nRelease notes are explained here: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html\n\nYou needn\u0027t call out osc changes in your release note, Maari Tamm and I will be working on a combined release note for OSC soon.","accounts_in_message":[],"_revision_number":1},{"id":"c78d10bf3ea36470d16f81a21b8c8170b7126ac2","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-02-01 22:00:57.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good Nicole, good job! As Goutham suggested, adding a reno is a good practice, so will +2 after that is adressed. Thanks!","accounts_in_message":[],"_revision_number":1},{"id":"5fa3b7cce093f39f41706e07ed74d6eea6159703","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"date":"2021-02-09 22:43:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8f27b686b947eda56edc6569cc8f32663f1ebb27","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"date":"2021-02-09 22:51:19.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a225e6a0dfb845f3a4c938970fe95eae8eec974a","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-02-09 23:53:48.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/dd44335028984091bb42980edf2664ed : SUCCESS in 6m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/63bee9d4863144169b6b0753cda44e55 : SUCCESS in 4m 55s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/042d3087068743e695979d8474ed1fab : SUCCESS in 4m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/22838e8f93044123916e50316613bfe1 : SUCCESS in 4m 26s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/130dcabaa3c8424d8241da93ebc3aeda : SUCCESS in 5m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/965c7b1462b743ee85b507a4784d8c66 : SUCCESS in 4m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d17b8077a2ee413ca91f6acad9e19310 : SUCCESS in 4m 28s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/3c5ee9da3f3b486e99bced211a5b3f4c : SUCCESS in 52m 55s","accounts_in_message":[],"_revision_number":3},{"id":"09ffe8fe5ac908c2bbf4a9e511bb537a4ee0af52","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-02-17 17:28:20.000000000","message":"Patch Set 3: Code-Review-1\n\nOuch, it seems that the reno was removed in patch set 3. Add it back with git add releasenotes/notes/1912704-da2e9de615436e76.yaml. Or if it got deleted accidentally, please create a new one. Thanks!","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"83f2ae25096113c14ffac4739bc251f06adb9a30","revisions":{"621efbae9a5ffda96cac4af75e9e3077ea816169":{"kind":"REWORK","_number":1,"created":"2021-02-01 16:27:25.000000000","uploader":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"ref":"refs/changes/48/773448/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/48/773448/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/1"}}},"commit":{"parents":[{"commit":"68052cd26ba05baf72853280c6704dfd569ad3b6","subject":"Merge \"Tighten asserts in some wait tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/68052cd26ba05baf72853280c6704dfd569ad3b6"}]}],"author":{"name":"arkaruki","email":"nchen357@bu.edu","date":"2021-02-01 16:10:51.000000000","tz":0},"committer":{"name":"arkaruki","email":"nchen357@bu.edu","date":"2021-02-01 16:25:43.000000000","tz":0},"subject":"Don\u0027t display pagination links","message":"Don\u0027t display pagination links\n\nPagination links are not useful in command line outputs and they\nshouldn\u0027t be displayed.\nWith this patch we popped them out for share snapshot export_locations\nfor the following commands:\nopenstack share snapshots show\nmanila snapshot-show\nopenstack share snapshot export location show\nmanila snapshot-export-location-show\n\nCloses-Bug: #1912704\nChange-Id: I5972f3df43f36b6a73f13a26d6748f05959433eb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/621efbae9a5ffda96cac4af75e9e3077ea816169"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/621efbae9a5ffda96cac4af75e9e3077ea816169"}]},"branch":"refs/heads/master"},"4c50c8c7b418a458548f6a67d8927a92ed491a2e":{"kind":"REWORK","_number":2,"created":"2021-02-09 22:43:32.000000000","uploader":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"ref":"refs/changes/48/773448/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/48/773448/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/2"}}},"commit":{"parents":[{"commit":"68052cd26ba05baf72853280c6704dfd569ad3b6","subject":"Merge \"Tighten asserts in some wait tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/68052cd26ba05baf72853280c6704dfd569ad3b6"}]}],"author":{"name":"arkaruki","email":"nchen357@bu.edu","date":"2021-02-01 16:10:51.000000000","tz":0},"committer":{"name":"arkaruki","email":"nchen357@bu.edu","date":"2021-02-09 22:43:14.000000000","tz":0},"subject":"Don\u0027t display pagination links","message":"Don\u0027t display pagination links\n\nPagination links are not useful in command line outputs and they\nshouldn\u0027t be displayed.\nWith this patch we popped them out for share snapshot export_locations\nfor the following commands:\nopenstack share snapshots show\nmanila snapshot-show\nopenstack share snapshot export location show\nmanila snapshot-export-location-show\n\nCloses-Bug: #1912704\nChange-Id: I5972f3df43f36b6a73f13a26d6748f05959433eb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/4c50c8c7b418a458548f6a67d8927a92ed491a2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/4c50c8c7b418a458548f6a67d8927a92ed491a2e"}]},"branch":"refs/heads/master"},"83f2ae25096113c14ffac4739bc251f06adb9a30":{"kind":"REWORK","_number":3,"created":"2021-02-09 22:51:19.000000000","uploader":{"_account_id":32595,"name":"Nicole Chen","email":"nchen357@bu.edu","username":"arkaruki"},"ref":"refs/changes/48/773448/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/48/773448/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/48/773448/3"}}},"commit":{"parents":[{"commit":"68052cd26ba05baf72853280c6704dfd569ad3b6","subject":"Merge \"Tighten asserts in some wait tests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/68052cd26ba05baf72853280c6704dfd569ad3b6"}]}],"author":{"name":"arkaruki","email":"nchen357@bu.edu","date":"2021-02-01 16:10:51.000000000","tz":0},"committer":{"name":"arkaruki","email":"nchen357@bu.edu","date":"2021-02-09 22:50:55.000000000","tz":0},"subject":"Don\u0027t display pagination links","message":"Don\u0027t display pagination links\n\nPagination links are not useful in command line outputs and they\nshouldn\u0027t be displayed.\nWith this patch we popped them out for share snapshot export_locations\nfor the following commands:\nopenstack share snapshots show\nmanila snapshot-show\nopenstack share snapshot export location show\nmanila snapshot-export-location-show\n\nCloses-Bug: #1912704\nChange-Id: I5972f3df43f36b6a73f13a26d6748f05959433eb\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/83f2ae25096113c14ffac4739bc251f06adb9a30"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/83f2ae25096113c14ffac4739bc251f06adb9a30"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY","applied_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"}},{"label":"Workflow","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}