)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0e618c47eeac88b1ac9378da5f34a9525fbc9e0c","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Maari Tamm \u003cmaari.tamm@citynetwork.eu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-01-03 13:22:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OSC] Add missing waiters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We decided to start adding the optional \u0027--wait\u0027 argument to OSC"},{"line_number":10,"context_line":"commands after we had some commands already implemented."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c8a2d270_18f84123","line":7,"updated":"2022-01-13 16:49:43.000000000","message":"NIT We should indicate for which command we are adding waiters so in the event of missing a waiter for another command we can do a follow up patch in a clear way\n\nE.g seems waiters are missing for share types, we would need this patch to be renamed to something like \"Add waiters for snapshots and access rules\" and a follow up to be \"Add waiters to share types\"","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a082e65aa407e5ba0d5b38bdad69144841a7a500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b47372e3_973556b8","updated":"2021-12-23 15:50:06.000000000","message":"LGTM, formatting issue noted inline, thanks Maari!","commit_id":"51236244c78d3a6788d7efd0ee252d84ecadc294"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"de4ac317c9afbc9c7eec56e2f0c028336fac752c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"0a7fc078_9c2e74b5","updated":"2022-01-11 18:15:47.000000000","message":"Great job, Maari. Thank you!","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e4787b6f74a525753df9532269af627cb37f45c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f6111270_126fa628","updated":"2022-01-05 23:40:33.000000000","message":"LGTM, thanks Maari!","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"f3ef4f9a58e009ed021b1da2c98fa887ea0b21fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"79d8b159_14f1478f","updated":"2022-01-17 11:27:30.000000000","message":"Let\u0027s get this one in, doesn\u0027t make sense to hold this for those nits, thanks Maari!","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5d2872ef052e353d35c1d54fa66b3e5fe2b7c65d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6afed4f3_5cd521ed","updated":"2022-01-03 13:26:18.000000000","message":"Thanks Goutham! I\u0027ve updated the patch, please have another look :) ","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0e618c47eeac88b1ac9378da5f34a9525fbc9e0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6ab52825_43fc3654","updated":"2022-01-13 16:49:43.000000000","message":"Thanks Maari! Looks good, just minor nits.","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"}],"manilaclient/osc/v2/share_access_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a082e65aa407e5ba0d5b38bdad69144841a7a500","unresolved":true,"context_lines":[{"line_number":123,"context_line":"                share_access_rule \u003d oscutils.find_resource("},{"line_number":124,"context_line":"                    share_client.share_access_rules,"},{"line_number":125,"context_line":"                    share_access_rule[\u0027id\u0027])._info"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            return (ACCESS_RULE_ATTRIBUTES, oscutils.get_dict_properties("},{"line_number":128,"context_line":"                    share_access_rule,"},{"line_number":129,"context_line":"                    ACCESS_RULE_ATTRIBUTES))"}],"source_content_type":"text/x-python","patch_set":3,"id":"130895b1_fb9a9bf9","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":0},"updated":"2021-12-23 15:50:06.000000000","message":"isn\u0027t this required here as well:\n\n          share_access_rule.update(\n                {\n                    \u0027properties\u0027: utils.format_properties(\n                        share_access_rule.pop(\u0027metadata\u0027, {}))\n                }\n            )","commit_id":"51236244c78d3a6788d7efd0ee252d84ecadc294"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5d2872ef052e353d35c1d54fa66b3e5fe2b7c65d","unresolved":true,"context_lines":[{"line_number":123,"context_line":"                share_access_rule \u003d oscutils.find_resource("},{"line_number":124,"context_line":"                    share_client.share_access_rules,"},{"line_number":125,"context_line":"                    share_access_rule[\u0027id\u0027])._info"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"            return (ACCESS_RULE_ATTRIBUTES, oscutils.get_dict_properties("},{"line_number":128,"context_line":"                    share_access_rule,"},{"line_number":129,"context_line":"                    ACCESS_RULE_ATTRIBUTES))"}],"source_content_type":"text/x-python","patch_set":3,"id":"a3b6ab50_1acba0f1","line":126,"range":{"start_line":126,"start_character":0,"end_line":126,"end_character":0},"in_reply_to":"130895b1_fb9a9bf9","updated":"2022-01-03 13:26:18.000000000","message":"I think it is yes, thanks!","commit_id":"51236244c78d3a6788d7efd0ee252d84ecadc294"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0e618c47eeac88b1ac9378da5f34a9525fbc9e0c","unresolved":true,"context_lines":[{"line_number":168,"context_line":"                if not oscutils.wait_for_delete("},{"line_number":169,"context_line":"                        manager\u003dshare_client.share_access_rules,"},{"line_number":170,"context_line":"                        res_id\u003dparsed_args.id):"},{"line_number":171,"context_line":"                    error \u003d _(\"Failed to delete share access rule with ID: %s\""},{"line_number":172,"context_line":"                              % parsed_args.id)"},{"line_number":173,"context_line":"        except Exception as e:"},{"line_number":174,"context_line":"            error \u003d e"}],"source_content_type":"text/x-python","patch_set":5,"id":"7b33d1ea_4ffe2eda","line":171,"updated":"2022-01-13 16:49:43.000000000","message":"NIT You could do a raise Exception() here and avoid creating the error var and the if-clause below. The except should catch both when share.deny() fails and when you raise the exception in the waiter.","commit_id":"e5e815bf09f2254cff24e6925b6f399af859332a"}]}