)]}'
{"id":"openstack%2Fpython-manilaclient~789018","triplet_id":"openstack%2Fpython-manilaclient~master~Ic2d939d0dde278f3f0eed870df808da1344ae91a","project":"openstack/python-manilaclient","branch":"master","topic":"bug/1898318","hashtags":[],"change_id":"Ic2d939d0dde278f3f0eed870df808da1344ae91a","subject":"Add --wait flag to the delete share group operation","status":"MERGED","created":"2021-04-30 19:16:12.000000000","updated":"2021-07-14 12:01:42.000000000","submitted":"2021-07-14 12:00:32.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":39,"unresolved_comment_count":19,"has_review_started":true,"submission_id":"789018-bug/1898318","meta_rev_id":"f9dad1b9035a94e9a37b822ce77c217134853676","_number":789018,"virtual_id_number":789018,"owner":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-07-14 12:00:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":0,"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2021-07-14 09:45:22.000000000","_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":2,"date":"2021-07-14 09:49:38.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"value":1,"date":"2021-07-14 10:49:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"value":0,"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"}],"reviewers":{"REVIEWER":[{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-04-30 20:28:27.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-05-04 12:16:41.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"state":"REVIEWER"},{"updated":"2021-07-06 08:08:16.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"state":"REVIEWER"},{"updated":"2021-07-06 08:08:39.000000000","updated_by":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"reviewer":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"state":"REVIEWER"},{"updated":"2021-07-06 09:08:44.000000000","updated_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"CC"},{"updated":"2021-07-14 09:49:38.000000000","updated_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"reviewer":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"state":"REVIEWER"}],"messages":[{"id":"a8e71740c3eac2a1fa52fe8e8e88cd86ec487f07","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-04-30 19:16:12.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fe8b269614c0e76763771b275d2e415587270f55","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-04-30 20:28:27.000000000","message":"Patch Set 1: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/38743175d1fb459883e30ef19a856b18 : FAILURE in 5m 49s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/054781e1f6be436c89a22d55a3f890cd : FAILURE in 5m 09s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/485a1df53c114d67a3d2a85247917279 : FAILURE in 4m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/923a400979124b10aef6368466d35034 : FAILURE in 3m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/c11d85d6d357465b8d722ef178895739 : FAILURE in 4m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/6b99f4def4bc4e949bef87529ccbe929 : FAILURE in 4m 37s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7638925b68324e23b2618d0e1a3766d0 : FAILURE in 3m 48s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/b5c618415baa4be499dd1b6578b91712 : POST_FAILURE in 19m 53s","accounts_in_message":[],"_revision_number":1},{"id":"d281d1cfb93515240bd4efe8abcdf6f2a5ae7acc","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-05-04 12:16:41.000000000","message":"Patch Set 1: Code-Review-1\n\n(7 comments)\n\nThanks for your fix and congrats on your first contribution Archana! I left a few comments inline, we can start addressing those little by little. Another thing that we need to do here is to add a release note. More info on release notes here https://docs.openstack.org/reno/latest/.","accounts_in_message":[],"_revision_number":1},{"id":"b22aab3a3b0dd780b33e024c3220cdda253278eb","tag":"autogenerated:gerrit:setWorkInProgress","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-02 19:13:37.000000000","message":"Set Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"5a1d91f6fcaec1911056ca55309e34a70bb92f86","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-02 19:30:43.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nThis change is ready for review.","accounts_in_message":[],"_revision_number":1},{"id":"bb302355b0cc325ae7d614ef96ac201cb073d280","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-02 19:45:21.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2ab62969388baad59133cbf09b6787d57359a59d","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-02 20:39:13.000000000","message":"Patch Set 2: Verified-1\n\n(3 comments)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c5537b269e994bc5af930c11fbe6b155 : SUCCESS in 7m 13s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/cf24d3c626f043cf9d888aba6d70cb43 : FAILURE in 4m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e20202f25d0c4c7c8a981358d72e2c45 : FAILURE in 6m 11s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/32b6f02f2e3944ffb03223fd786c8991 : FAILURE in 4m 35s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2ad265ccbea040368988bc0a2dffabf3 : FAILURE in 4m 19s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f7397a04d21e477d97d4e61846c8e493 : FAILURE in 4m 58s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/802c0fcdfb7a475da0d76c6647b515b8 : FAILURE in 4m 47s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/6a2684446dad43d8b01c7b744875357e : SUCCESS in 47m 28s","accounts_in_message":[],"_revision_number":2},{"id":"19d6f8abe5bf2b4582b86888a7b51b431d8c4ea3","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-03 08:55:13.000000000","message":"Patch Set 2:\n\n(1 comment)\n\nI see some pep8 failures that the gate is picking up. We would need to fix that too! Thanks Archana!","accounts_in_message":[],"_revision_number":2},{"id":"e3a860e2f114c2109cecf96238eb3f44e763123a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-03 18:27:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"1f0390b33c779460eb4ac778915179ee4a201e46","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-03 19:12:31.000000000","message":"Patch Set 3: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/863bcbcc7d9b44af95c00a2ddd6ae427 : SUCCESS in 8m 03s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/865430d5d30e48279acd60d58ea89402 : FAILURE in 5m 26s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/e8e696c8a6f2445886690fc652e67fce : FAILURE in 6m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0221dd07b3e84beb8d8fd6d37ce70405 : SUCCESS in 3m 44s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/dad2f4503ac54ae282cd480c33e23553 : FAILURE in 6m 10s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f0c7be2456434a46996727f2eec2c996 : FAILURE in 5m 39s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/b2e66c9903c544f68a9e6361a79c836e : FAILURE in 5m 40s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/1757d65ce6704dc999c67740b9ed0904 : SUCCESS in 42m 49s","accounts_in_message":[],"_revision_number":3},{"id":"0ad424563795d7b26efdbeedf63313e6248d1c75","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-04 11:29:36.000000000","message":"Patch Set 3: Code-Review-1\n\n(2 comments)\n\nThanks Archu. Left a few comments inline. It\u0027s almost done!","accounts_in_message":[],"_revision_number":3},{"id":"e3939ba1a44cbda70977e2f910568de849e7792e","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-04 21:43:26.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"99f8e0a8fd6020517fbf59d674757169cc2acd0e","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-04 21:46:40.000000000","message":"Patch Set 4:\n\n\u003e Patch Set 3: Code-Review-1\n\u003e \n\u003e (2 comments)\n\u003e \n\u003e Thanks Archu. Left a few comments inline. It\u0027s almost done!\n\nThanks Vicky. I followed your review 😊\nSeems like I\u0027m facing issue with unit tests.","accounts_in_message":[],"_revision_number":4},{"id":"81acee759b14a9de5727c3d57a974f830c782cae","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-04 21:51:38.000000000","message":"Patch Set 4: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c712e5a2cb854948af410c1d50d7d01f : SUCCESS in 6m 26s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9fefede73306486aace158eea7a941d2 : FAILURE in 5m 15s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/abd5ca4697eb433eb0d700702c196717 : FAILURE in 5m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/698c2173fe6b43cc80fb4321ee1d0827 : SUCCESS in 4m 17s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8abcfe83b62d483db09f90c130a8100e : FAILURE in 5m 09s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/12a2d2ebe607499480bbf7f1235291d2 : FAILURE in 5m 11s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/14ae0936af9744c28804cea27f9be3fa : FAILURE in 4m 17s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"f6647a3122c54dc4bdfcd2d28fa559889566e1b4","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-07 11:26:01.000000000","message":"Patch Set 4:\n\n(2 comments)","accounts_in_message":[],"_revision_number":4},{"id":"fc98cf4669198192939005d0af4626e1cb322ecc","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-07 20:00:31.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"78c321dc190e4bbf77a08e72c7fed09f76f1808c","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-07 20:11:43.000000000","message":"Patch Set 5:\n\nHi Vicky, What I have done in this fix is to import the share_groups class and created a fake_share_group in which i pass the string share_group_to_delete.","accounts_in_message":[],"_revision_number":5},{"id":"196674303856ebb8fef636687e14720d7730fbd7","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-07 20:44:53.000000000","message":"Patch Set 5: Verified-1\n\n(1 comment)\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a8e012ef2ad84b39a3ba15f0712dfbf5 : SUCCESS in 6m 37s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f3a1cce0c8fa4deea68bb483a18ee3a3 : FAILURE in 4m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/494332bb4cb647f8af1a773154b2ee07 : FAILURE in 5m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/96fc174a1b074743a9b636cc7e8c0da1 : FAILURE in 4m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4e671de68b0e414f8e9d83e42931f6fc : FAILURE in 4m 14s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/aafad126b361458bb04e8ece4d165c61 : FAILURE in 4m 38s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/c737fb421d504ec9b7482f5ef8994ef8 : FAILURE in 5m 33s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/3d36f863929c4f0e81eb2ae39f3993d5 : SUCCESS in 43m 08s","accounts_in_message":[],"_revision_number":5},{"id":"2b62c5b7f20c69fdc54ba44e74ed07fffc8dc4fe","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-09 12:16:36.000000000","message":"Patch Set 5: Code-Review-1\n\n(8 comments)\n\nHi Archana, left a few suggestions inline. Let me know what you think. Thanks!","accounts_in_message":[],"_revision_number":5},{"id":"c6cec0d45460046a05584c42f1a10848937a9084","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-10 13:34:42.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"68aa721e304c4cbcf4992349af1aa6d1d36242a2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-10 14:28:59.000000000","message":"Patch Set 6: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0e9731570a5b4bcd9768a7749bf496fa : SUCCESS in 6m 45s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/32f31fcc01814cc59176551d29c72d29 : FAILURE in 5m 22s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/543eb0367994413089055c54a6807166 : FAILURE in 6m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/76b2783fef31421ea8ba4ed83b3da54c : SUCCESS in 4m 16s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/fafece7835814d3f81474cb4ad630ad6 : FAILURE in 4m 43s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/056c978bdd434cf7b62beb96b127e2d1 : SUCCESS in 5m 02s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/87c3c12885a54669aa0439b03ac38d14 : SUCCESS in 4m 46s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/5d968c91ff3d478aa005f8752434452a : SUCCESS in 51m 29s","accounts_in_message":[],"_revision_number":6},{"id":"40b700d55d1c844c8a617a7b04d71d9c7d907d28","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-14 13:00:49.000000000","message":"Patch Set 6:\n\nrecheck","accounts_in_message":[],"_revision_number":6},{"id":"ba27deeddc2a77fcac08b3477163bd45c8782b27","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 13:51:26.000000000","message":"Patch Set 6: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/396e187de86f46799fce0f9ae30f179c : SUCCESS in 9m 24s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9c1a003043bd4d95ac29a6f5253dec75 : SUCCESS in 6m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/caeb31b8ffcf474d8c833276e21b2987 : SUCCESS in 5m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/3a61550ade764780b5d008ba599b2214 : SUCCESS in 4m 08s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/deac02f3bb00431bb55620c3aaa66dc6 : SUCCESS in 4m 50s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/7ae0d8a499924368902a9e3ea135d0e8 : SUCCESS in 4m 13s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/375d5dd855e54eb780e8d41fa3360d69 : FAILURE in 4m 55s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/29e7788604254c369d25a1d208a5b6c2 : SUCCESS in 48m 44s","accounts_in_message":[],"_revision_number":6},{"id":"fcf5734a471633f4fb91f15f1b930ba49bf18683","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-14 14:56:16.000000000","message":"Patch Set 6: Code-Review+1\n\nGreat stuff! We are only missing the release note now and we are good to go. Thanks Archana!","accounts_in_message":[],"_revision_number":6},{"id":"b07c39bada389f6def2c1bb9397d53aed2702951","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-06-14 16:41:03.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"4f7e69381fa349d57c0ab1ce9b3c185f11f1c7ce","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-14 17:34:14.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/eacbc5575daa4cf1813f1148dc67cac4 : SUCCESS in 8m 54s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8af526e9b6ce43f99d04091959d04616 : SUCCESS in 8m 59s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a1f24f1aa0754e83931f550cca32a7ea : FAILURE in 5m 21s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/39db988aca9f4a6ab380487234807504 : FAILURE in 5m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cfe9295863a846aab96d525a592945eb : FAILURE in 8m 36s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ed2c3dd6d8a347449b618bb12aa4a42c : FAILURE in 5m 18s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/d77cfb05d93d40298aa5e867cdd0e383 : FAILURE in 4m 51s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2a94fe1419654be5bc4dfb08a5f25584 : SUCCESS in 7m 53s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/481e47a7497144c98508f9bed69d1813 : SUCCESS in 49m 10s","accounts_in_message":[],"_revision_number":7},{"id":"7949abbd96e8d58ea22d27762e3a308bf327d253","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-17 08:32:25.000000000","message":"Patch Set 7:\n\nrecheck","accounts_in_message":[],"_revision_number":7},{"id":"2dc919fc4b504ef763897c5a9af16cd013ccd525","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 09:23:31.000000000","message":"Patch Set 7:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ab3acf14745949d68114ec7d124ea028 : SUCCESS in 6m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/db52688cef074a948201e9581437da05 : FAILURE in 4m 52s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/52aafc2d79e54bcdacd91e1bacc0c39d : FAILURE in 5m 37s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e2899f8b310646a0a81b921c8eac463f : SUCCESS in 4m 19s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f9a623748a434dadb3b6ccba58956eca : SUCCESS in 5m 08s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/c5d62cee2395427bbaefa46ee95db654 : SUCCESS in 5m 44s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/56accdb9361b43248834c207f6bd7524 : FAILURE in 4m 44s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/20063715a544438a8eb2fa6d0525e13f : SUCCESS in 4m 49s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/0955550c102b422585aaf3cd69f96501 : SUCCESS in 47m 05s","accounts_in_message":[],"_revision_number":7},{"id":"833976a852fd1269d4d31c79fa7ed037ec047245","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-17 11:08:49.000000000","message":"Patch Set 8: Patch Set 7 was rebased","accounts_in_message":[],"_revision_number":8},{"id":"53de1195536d2b6589d806da01c3843a74ad2371","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-17 12:02:13.000000000","message":"Patch Set 8: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7abccfb8b8f943e39edcd5feae966bb2 : SUCCESS in 5m 56s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/8c8c7e56b2ec4248aa2c14ba6d47c195 : SUCCESS in 5m 13s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/98f3e310478b452ba543eb1bbfc1957e : FAILURE in 5m 51s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9174bc72de1e4618bbb895f4b713b446 : SUCCESS in 4m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/184aa832271d44cdb4841569c17bed7f : SUCCESS in 4m 32s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/76d81e5faad84e0e9b5ccd0baca494f8 : SUCCESS in 4m 40s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/6672cc9cee8444808e8080eb5387bc4a : FAILURE in 5m 10s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ac71d0badaf848f3aea1d8bc9da418dc : SUCCESS in 4m 17s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/3915649209254e64949995bd7a8f1b72 : SUCCESS in 50m 15s","accounts_in_message":[],"_revision_number":8},{"id":"150427b2361db1371fae29d9d0fb78543fbb9254","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-23 11:02:42.000000000","message":"Patch Set 8:\n\nrecheck","accounts_in_message":[],"_revision_number":8},{"id":"918f24226b5d12461b33eb508df46588b17453bd","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-23 12:02:24.000000000","message":"Patch Set 8:\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/2c63c0c92b384fcc8255cbffcb50efeb : SUCCESS in 7m 14s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6f924178b0f54617bea882888ee8187b : FAILURE in 6m 36s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/8c0ac087118545c8959b08f0be8024dc : SUCCESS in 6m 03s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c3da4cf90b274de2a11428ce54a1c499 : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/e86336347e3b4825aac97e938461eb28 : FAILURE in 5m 02s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/525a8458d3db4bb7b8d3b78f1a5d1834 : FAILURE in 4m 50s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/aa54d59fc3154e67ada05c59092b7c9c : SUCCESS in 4m 40s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/daf7804e035c4085a5665b79de042b02 : SUCCESS in 4m 13s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/46e68430f47942258917e95ffbc515e9 : SUCCESS in 55m 24s","accounts_in_message":[],"_revision_number":8},{"id":"f017b91a58659dac7ad0004e10358b02b9b84118","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-30 13:08:17.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"f44a0408f9431f15bffffa0820dcf345fec0174f","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-30 14:07:35.000000000","message":"Patch Set 9: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/00ba215bdf9948bd9b5c6e000f248b18 : SUCCESS in 7m 23s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d91e5750257d4daf9286cd81e2226f95 : SUCCESS in 6m 16s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/cda78b17d56a40f4b3e2a200e1b80ae1 : SUCCESS in 6m 45s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c284747f9bb043fc9f40118c603e6960 : SUCCESS in 6m 13s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d382abdfcad2450e8b0d483e351dc4a8 : SUCCESS in 6m 24s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d79e6530f54c4ce18b386b6c500ceaca : SUCCESS in 6m 04s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/ab5f2653692c4e11bc1a759c80f5d6f8 : SUCCESS in 6m 11s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/e736cb7a14764cf28f8fc8e12022f036 : SUCCESS in 5m 38s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/33432adf8b5442e7aa3dfe1bb3946212 : SUCCESS in 54m 38s","accounts_in_message":[],"_revision_number":9},{"id":"1c61c884f39ee36a7cc5ff463b10bdc1b4e9058d","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-06-30 14:29:33.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"1fb4c548eb8f30052a1daceca1e7a6da6cffd896","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-06-30 15:36:45.000000000","message":"Patch Set 10: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4c619752534244af8876056624a63a91 : SUCCESS in 9m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/f7ca25d5dee14eaf800636409c1f52e9 : SUCCESS in 6m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2efedcec790c45c4b1ed5ac657204aa2 : SUCCESS in 8m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c1b1020fad634335bc4a8eed526f5b38 : SUCCESS in 5m 23s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/90957b9186f641dba8f83d730fa292a1 : SUCCESS in 6m 13s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/11e28a5be0ab42adbaedc1d2e6bba0f9 : SUCCESS in 6m 30s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/2c6f93f1c377479a852f7dacf0bfce7d : SUCCESS in 6m 34s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1348eee541b64f7d802cc528c5fc0cae : SUCCESS in 5m 55s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/11588b24c1964930be03424bdc559d13 : SUCCESS in 1h 00m 55s","accounts_in_message":[],"_revision_number":10},{"id":"298d731fd774c6230495d8858d2700409947d5f0","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-07-06 09:08:44.000000000","message":"Patch Set 10:\n\n(1 comment)\n\nThanks for working on this change Archana! I\u0027ve tested this in my environment and everything worked as expected for me. The code looks great! I\u0027ve only left one minor suggestion inline, let me know what you think. Great job with this! 😊","accounts_in_message":[],"_revision_number":10},{"id":"31da5897e6e27721bee2b75e15460543976a1b63","author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"date":"2021-07-06 17:00:45.000000000","message":"Patch Set 10:\n\nRegarding the changes to test_share_group_update and test_share_group_show, should these be part of the release notes? Are these considered bug fixes?","accounts_in_message":[],"_revision_number":10},{"id":"415709d4f77a5b52fdca95bfe6d4f2ac1c327760","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-09 08:47:52.000000000","message":"Patch Set 10:\n\n\u003e Patch Set 10:\n\u003e \n\u003e (1 comment)\n\u003e \n\u003e Thanks for working on this change Archana! I\u0027ve tested this in my environment and everything worked as expected for me. The code looks great! I\u0027ve only left one minor suggestion inline, let me know what you think. Great job with this! 😊\n\nHi Maari, thanks for the review! Since we are calling with the flag force\u003dFalse in the test_shell.py file L2799(can\u0027t find link to add here), so we need to use this here as a \u0027False\u0027. Let me know if we can improve this in any other way :)","accounts_in_message":[],"_revision_number":10},{"id":"f6142afe79dcbb2c0617dd2d271b18257a783c9a","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-07-09 08:51:16.000000000","message":"Patch Set 10:\n\n(2 comments)","accounts_in_message":[],"_revision_number":10},{"id":"35f6e0548753bad1f006fc2868a43eec7a57fc98","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-09 08:55:30.000000000","message":"Patch Set 10:\n\n\u003e Patch Set 10:\n\u003e \n\u003e Regarding the changes to test_share_group_update and test_share_group_show, should these be part of the release notes? Are these considered bug fixes?\n\nHi Ashley, Thanks for your review! These are not the considered bug fixes, we have updated these both tests as per we created mocks. Let me know what you think, if we need to add this into reno or not :)","accounts_in_message":[],"_revision_number":10},{"id":"2964c4bfcd1efbe1a5041a68a7c0eb0fe6896bbd","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-07-09 08:56:03.000000000","message":"Patch Set 10:\n\n\u003e Patch Set 10:\n\u003e \n\u003e Regarding the changes to test_share_group_update and test_share_group_show, should these be part of the release notes? Are these considered bug fixes?\n\nI wouldn\u0027t add those on the release notes since it\u0027s something that won\u0027t impact the end user. Tests maintain the same behavior but, since we changed the way we are mocking things, we had to update other tests to comply. When working on this patch we noticed that some mocks were being reused, causing the secondary effects. In this way, we use the mocks we create for each test specifically and avoid that unexpected behavior. Hope this makes sense.","accounts_in_message":[],"_revision_number":10},{"id":"628ec8064b5784be4b30337e83f88f5256a9eaf7","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-07-09 09:37:30.000000000","message":"Patch Set 10:\n\n(1 comment)","accounts_in_message":[],"_revision_number":10},{"id":"c0a9be0d1f96540ae9d81eb6307ea14a75ffd5ac","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-12 06:18:24.000000000","message":"Uploaded patch set 11: Commit message was updated.","accounts_in_message":[],"_revision_number":11},{"id":"6c5e08a01bc140a7e5719d25b2d85ded17a7f591","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-12 06:25:47.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"76704a1bcb05b4cb2af4fdec32ccdafce24d0a8c","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-12 06:27:28.000000000","message":"Patch Set 12:\n\n(3 comments)","accounts_in_message":[],"_revision_number":12},{"id":"f6dadceda41899003d95bd04d6afd0795b61733c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-12 07:16:44.000000000","message":"Patch Set 12: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/15cb0e3e384047eba2cd38c081a36814 : SUCCESS in 8m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/086e3a76b3594f29ab6b84bc04e08f3c : SUCCESS in 6m 07s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/620efbb131f64666993ae9b534a1364f : SUCCESS in 7m 17s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/9fb25e2ba3a04676b699a127f7a6a067 : SUCCESS in 5m 59s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5032135a039443148a1dc0e6285a4723 : SUCCESS in 5m 33s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5838dcb9850f45ff8d15be83041aec27 : SUCCESS in 6m 27s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/cd638d7b296e4f43a3870788fd0a63b6 : SUCCESS in 6m 38s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/03b4803da8f1477b8013bb6a14684095 : SUCCESS in 5m 39s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/f0ee988d614c4524976974316609905f : SUCCESS in 49m 06s","accounts_in_message":[],"_revision_number":12},{"id":"3ea637df73e1e2d52888bf3502ea47c1f9172037","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2021-07-14 00:17:17.000000000","message":"Patch Set 12: Code-Review+2\n\nLGTM, thanks Archana","accounts_in_message":[],"_revision_number":12},{"id":"65382abb20f4c9b490b9c6b681c1bc50ba8adf3a","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-07-14 09:33:50.000000000","message":"Patch Set 12:\n\n(2 comments)\n\nThanks Archana, I just have one last suggestion, added notes inline.","accounts_in_message":[],"_revision_number":12},{"id":"7f5746c549da0c6a52d6264ac6a7cd1d6ece3c21","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-14 09:39:55.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"e764b49d470c8a4b6f874eccc35f1b94820ebb97","author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"date":"2021-07-14 09:41:54.000000000","message":"Patch Set 13:\n\n(2 comments)\n\nThanks Maari for the review :)","accounts_in_message":[],"_revision_number":13},{"id":"b493fa3fba6c01019f5b6ec9756d4d1f9ce57b44","author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"date":"2021-07-14 09:45:22.000000000","message":"Patch Set 13: Code-Review+2\n\nLooks great to me, thanks Archu, great job!","accounts_in_message":[],"_revision_number":13},{"id":"f630602afddc955b88c3ce360e98b93d065a73c2","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-07-14 09:49:38.000000000","message":"Patch Set 13: Code-Review+2\n\nThanks Archana! :)","accounts_in_message":[],"_revision_number":13},{"id":"c2d3e8d89439bdfae7c6a66afb5eaf4e6feb1f8c","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 10:29:11.000000000","message":"Patch Set 13: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6e495cdbf4354750ba7c22518747cf74 : SUCCESS in 6m 33s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1e0c29c8337748ecaf5b792024566184 : SUCCESS in 5m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/0b9ba58d54e643d780d479b1e0df31ca : SUCCESS in 5m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/2ac6422a032c4257a72cb7d6645f2204 : SUCCESS in 4m 07s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9df8f314676a4758a4ef81aaafedcecf : SUCCESS in 4m 48s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/78114d17c96c4c969a8b4f73b2b528db : SUCCESS in 6m 00s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/eb6451ff97ab450ba647cdfa42202f55 : SUCCESS in 4m 45s (non-voting)\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f41e16be89e84cb6812b4a2a1a894abf : SUCCESS in 4m 04s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/96347c51cc6e4e5cb2b9d9472a717969 : SUCCESS in 48m 05s","accounts_in_message":[],"_revision_number":13},{"id":"19bb519ee5e5db68dbb251eccc1cb05e2e9dacef","author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"date":"2021-07-14 10:49:55.000000000","message":"Patch Set 13: Workflow+1","accounts_in_message":[],"_revision_number":13},{"id":"bf206fcf40e5ab11290304d347178fc28ff5b55e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 10:50:21.000000000","message":"Patch Set 13: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":13},{"id":"2ce06c7846ba8c55105bed85b90f3f6c9044180e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 12:00:31.000000000","message":"Patch Set 13: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f2ccbe5c6fcd4fd0925c51e26980202c : SUCCESS in 7m 50s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/21c7e3857536405a8c4f7bb80347385c : SUCCESS in 6m 42s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/cc3738684eaa46b2aa94c9ad409c1833 : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/cd6d5d830ec24394b540291d89446e00 : SUCCESS in 5m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/bce52db96b384fc5b2c79bd1dd1fecd8 : SUCCESS in 5m 51s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/ec34f666a5b04f5aaa44d8dd83b74b8f : SUCCESS in 4m 41s\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/8350d954b2574e6092978e97966a9e08 : SUCCESS in 1h 10m 05s","accounts_in_message":[],"_revision_number":13},{"id":"fd2e139b3216d52c716ca4f1f72a0fc90edc0052","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 12:00:32.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":13},{"id":"f9dad1b9035a94e9a37b822ce77c217134853676","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-14 12:01:42.000000000","message":"Patch Set 13:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ecc4abbdde814c2a8daffb99fd70e6b3 : SUCCESS in 53s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/f87d585bcf2f44259e9a0e0889c2233f : SUCCESS in 53s","accounts_in_message":[],"_revision_number":13}],"current_revision_number":13,"current_revision":"f84f32e702edbbf2ca05434cdadbfa47af0cf0c0","revisions":{"170129a03b6cfc3ed7378178c1688f7ebad336a8":{"kind":"REWORK","_number":1,"created":"2021-04-30 19:16:12.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/1"}}},"commit":{"parents":[{"commit":"7ecc819d1985eab40fac9086d16ea23c9b106f26","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7ecc819d1985eab40fac9086d16ea23c9b106f26"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"subject":"a --wait option for deleting a share group","message":"a --wait option for deleting a share group\n\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/170129a03b6cfc3ed7378178c1688f7ebad336a8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/170129a03b6cfc3ed7378178c1688f7ebad336a8"}]},"branch":"refs/heads/master"},"b5d0943408ca6b227da85db4b0d626596dcb16bb":{"kind":"REWORK","_number":2,"created":"2021-06-02 19:45:21.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/2"}}},"commit":{"parents":[{"commit":"7ecc819d1985eab40fac9086d16ea23c9b106f26","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7ecc819d1985eab40fac9086d16ea23c9b106f26"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana","email":"ak31960466@gmail.com","date":"2021-06-02 19:45:21.000000000","tz":0},"subject":"Add mock the _find_share_group method in the shell_v2 lib Remove the self.mock_object(...) and added self.assert_called in _find_share_group method Resolve indentation issues","message":"Add mock the _find_share_group method in the shell_v2 lib\nRemove the self.mock_object(...) and added self.assert_called in _find_share_group method\nResolve indentation issues\n\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b5d0943408ca6b227da85db4b0d626596dcb16bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/b5d0943408ca6b227da85db4b0d626596dcb16bb"}]},"branch":"refs/heads/master"},"c18a209663da56981a40f27a1608d40583200978":{"kind":"REWORK","_number":3,"created":"2021-06-03 18:27:50.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/3"}}},"commit":{"parents":[{"commit":"7ecc819d1985eab40fac9086d16ea23c9b106f26","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7ecc819d1985eab40fac9086d16ea23c9b106f26"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana","email":"ak31960466@gmail.com","date":"2021-06-03 18:25:42.000000000","tz":0},"subject":"build fix on adding \"--wait\" option for deleting a share group","message":"build fix on adding \"--wait\" option for deleting a share group\n\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/c18a209663da56981a40f27a1608d40583200978"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/c18a209663da56981a40f27a1608d40583200978"}]},"branch":"refs/heads/master"},"c01fd770d1fb09fd462270550272d1c9c37d03fd":{"kind":"REWORK","_number":4,"created":"2021-06-04 21:43:26.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/4"}}},"commit":{"parents":[{"commit":"7ecc819d1985eab40fac9086d16ea23c9b106f26","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7ecc819d1985eab40fac9086d16ea23c9b106f26"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana","email":"ak31960466@gmail.com","date":"2021-06-04 21:40:23.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/c01fd770d1fb09fd462270550272d1c9c37d03fd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/c01fd770d1fb09fd462270550272d1c9c37d03fd"}]},"branch":"refs/heads/master"},"aaeafe6f77c4e374d445f7a283a03197bb197d42":{"kind":"REWORK","_number":5,"created":"2021-06-07 20:00:31.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/5"}}},"commit":{"parents":[{"commit":"7ecc819d1985eab40fac9086d16ea23c9b106f26","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7ecc819d1985eab40fac9086d16ea23c9b106f26"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana","email":"ak31960466@gmail.com","date":"2021-06-07 19:57:44.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group operation. This will make the CLI to wait for the operation to be completed before returning to the prompt.\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/aaeafe6f77c4e374d445f7a283a03197bb197d42"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/aaeafe6f77c4e374d445f7a283a03197bb197d42"}]},"branch":"refs/heads/master"},"711648c1c191bc2ae11c1ee9b1aeaa9594eb43cb":{"kind":"REWORK","_number":6,"created":"2021-06-10 13:34:42.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/6"}}},"commit":{"parents":[{"commit":"7ecc819d1985eab40fac9086d16ea23c9b106f26","subject":"setup.cfg: Replace dashes with underscores","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/7ecc819d1985eab40fac9086d16ea23c9b106f26"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana","email":"ak31960466@gmail.com","date":"2021-06-10 13:33:55.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group operation. This will make the CLI to wait for the operation to be completed before returning to the prompt.\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/711648c1c191bc2ae11c1ee9b1aeaa9594eb43cb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/711648c1c191bc2ae11c1ee9b1aeaa9594eb43cb"}]},"branch":"refs/heads/master"},"622172c07ec7ff6138feb0e1694918ca88e22cde":{"kind":"REWORK","_number":7,"created":"2021-06-14 16:41:03.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/7"}}},"commit":{"parents":[{"commit":"99ccf02d0b2c1c5cb28f58223637be8df5823163","subject":"[TrivialFix] Follow up per-share-gigabytes quota changes","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/99ccf02d0b2c1c5cb28f58223637be8df5823163"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Archana","email":"ak31960466@gmail.com","date":"2021-06-14 16:34:17.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/622172c07ec7ff6138feb0e1694918ca88e22cde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/622172c07ec7ff6138feb0e1694918ca88e22cde"}]},"branch":"refs/heads/master"},"0e93374bb39e531941ab1d723003ed5c6f0df0b1":{"kind":"TRIVIAL_REBASE","_number":8,"created":"2021-06-17 11:08:49.000000000","uploader":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"ref":"refs/changes/18/789018/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/8"}}},"commit":{"parents":[{"commit":"5220acf12ece04b620d9ae26c0321c7d300c4087","subject":"Changed minversion in tox to 3.18.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5220acf12ece04b620d9ae26c0321c7d300c4087"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-06-17 11:08:49.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/0e93374bb39e531941ab1d723003ed5c6f0df0b1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/0e93374bb39e531941ab1d723003ed5c6f0df0b1"}]},"branch":"refs/heads/master","description":"Rebase"},"a3f1455aebb42c90ca1992fcedcc962ba60a5757":{"kind":"REWORK","_number":9,"created":"2021-06-30 13:08:17.000000000","uploader":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"ref":"refs/changes/18/789018/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/9"}}},"commit":{"parents":[{"commit":"5220acf12ece04b620d9ae26c0321c7d300c4087","subject":"Changed minversion in tox to 3.18.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5220acf12ece04b620d9ae26c0321c7d300c4087"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-06-30 13:06:43.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nUpdated test_share_delete to be test_share_delete_wait\nand included the waiter flag.\n\nUpdated test_share_group_delete_force to test the\ncorrect calls.\n\nAlso, updated test_share_group_update and test_share_group_show\nsince they were randomnly failing depending on the test execution\norder. Mocks were being cleaned up and that was leading us to\nsome errors. Created mocks for required resources within those\ntests to make it more stable.\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/a3f1455aebb42c90ca1992fcedcc962ba60a5757"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/a3f1455aebb42c90ca1992fcedcc962ba60a5757"}]},"branch":"refs/heads/master"},"9a8106c561fa14dc104c7a39dfe97ca83d1b5fe4":{"kind":"REWORK","_number":10,"created":"2021-06-30 14:29:33.000000000","uploader":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"ref":"refs/changes/18/789018/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/10"}}},"commit":{"parents":[{"commit":"5220acf12ece04b620d9ae26c0321c7d300c4087","subject":"Changed minversion in tox to 3.18.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5220acf12ece04b620d9ae26c0321c7d300c4087"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","date":"2021-06-30 14:29:58.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nUpdated test_share_delete to be test_share_delete_wait\nand included the waiter flag.\n\nUpdated test_share_group_delete_force to test the\ncorrect calls.\n\nAlso, updated test_share_group_update and test_share_group_show\nsince they were randomnly failing depending on the test execution\norder. Mocks were being cleaned up and that was leading us to\nsome errors. Created mocks for required resources within those\ntests to make it more stable.\n\nCloses-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9a8106c561fa14dc104c7a39dfe97ca83d1b5fe4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/9a8106c561fa14dc104c7a39dfe97ca83d1b5fe4"}]},"branch":"refs/heads/master"},"f4f08b26fe93fbcf8fb84b49863dbfeaa75132c2":{"kind":"NO_CODE_CHANGE","_number":11,"created":"2021-07-12 06:18:24.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/11"}}},"commit":{"parents":[{"commit":"5220acf12ece04b620d9ae26c0321c7d300c4087","subject":"Changed minversion in tox to 3.18.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5220acf12ece04b620d9ae26c0321c7d300c4087"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"archanaserver","email":"ak31960466@gmail.com","date":"2021-07-12 06:17:57.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nUpdated test_share_delete to be test_share_delete_wait\nand included the waiter flag.\n\nUpdated test_share_group_delete_force to test the\ncorrect calls.\n\nAlso, updated test_share_group_update and test_share_group_show\nsince they were randomnly failing depending on the test execution\norder. Mocks were being cleaned up and that was leading us to\nsome errors. Created mocks for required resources within those\ntests to make it more stable.\n\nPartial-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f4f08b26fe93fbcf8fb84b49863dbfeaa75132c2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f4f08b26fe93fbcf8fb84b49863dbfeaa75132c2"}]},"branch":"refs/heads/master"},"173e036fd547b40e6e13538776008f63608cfd53":{"kind":"REWORK","_number":12,"created":"2021-07-12 06:25:47.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/12"}}},"commit":{"parents":[{"commit":"5220acf12ece04b620d9ae26c0321c7d300c4087","subject":"Changed minversion in tox to 3.18.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5220acf12ece04b620d9ae26c0321c7d300c4087"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"archanaserver","email":"ak31960466@gmail.com","date":"2021-07-12 06:25:37.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nUpdated test_share_delete to be test_share_delete_wait\nand included the waiter flag.\n\nUpdated test_share_group_delete_force to test the\ncorrect calls.\n\nAlso, updated test_share_group_update and test_share_group_show\nsince they were randomnly failing depending on the test execution\norder. Mocks were being cleaned up and that was leading us to\nsome errors. Created mocks for required resources within those\ntests to make it more stable.\n\nPartial-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/173e036fd547b40e6e13538776008f63608cfd53"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/173e036fd547b40e6e13538776008f63608cfd53"}]},"branch":"refs/heads/master"},"f84f32e702edbbf2ca05434cdadbfa47af0cf0c0":{"kind":"REWORK","_number":13,"created":"2021-07-14 09:39:55.000000000","uploader":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"ref":"refs/changes/18/789018/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/18/789018/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/18/789018/13"}}},"commit":{"parents":[{"commit":"5220acf12ece04b620d9ae26c0321c7d300c4087","subject":"Changed minversion in tox to 3.18.0","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/5220acf12ece04b620d9ae26c0321c7d300c4087"}]}],"author":{"name":"Archana Kumari","email":"ak31960466@gmail.com","date":"2021-04-30 19:15:26.000000000","tz":330},"committer":{"name":"archanaserver","email":"ak31960466@gmail.com","date":"2021-07-14 09:39:43.000000000","tz":0},"subject":"Add --wait flag to the delete share group operation","message":"Add --wait flag to the delete share group operation\n\nThis patch set adds the --wait flag to the share group\noperation. This will make the CLI to wait for the\noperation to be completed before returning to the prompt.\n\nUpdated test_share_delete to be test_share_delete_wait\nand included the waiter flag.\n\nUpdated test_share_group_delete_force to test the\ncorrect calls.\n\nAlso, updated test_share_group_update and test_share_group_show\nsince they were randomnly failing depending on the test execution\norder. Mocks were being cleaned up and that was leading us to\nsome errors. Created mocks for required resources within those\ntests to make it more stable.\n\nPartial-Bug: #1898318\nChange-Id: Ic2d939d0dde278f3f0eed870df808da1344ae91a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f84f32e702edbbf2ca05434cdadbfa47af0cf0c0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f84f32e702edbbf2ca05434cdadbfa47af0cf0c0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"}}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}