)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"525adc5d389a888c8d341e4ec6ce7946c1f47032","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Updated test_share_group_create to be test_share_group_create_wait"},{"line_number":14,"context_line":"and included the waiter flag"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id3e163de48bdd918ae55438d812187ba4d5461c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f587fe7d_57dfb21e","line":15,"updated":"2021-07-09 11:52:01.000000000","message":"Partial-Bug: #1898318","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"525adc5d389a888c8d341e4ec6ce7946c1f47032","unresolved":true,"context_lines":[{"line_number":36,"context_line":"from manilaclient.v2 import messages"},{"line_number":37,"context_line":"from manilaclient.v2 import security_services"},{"line_number":38,"context_line":"from manilaclient.v2 import share_groups"},{"line_number":39,"context_line":"from manilaclient.v2 import share_instances"},{"line_number":40,"context_line":"from manilaclient.v2 import share_network_subnets"},{"line_number":41,"context_line":"from manilaclient.v2 import share_networks"},{"line_number":42,"context_line":"from manilaclient.v2 import share_servers"}],"source_content_type":"text/x-python","patch_set":1,"id":"a5feee27_d43a5ea5","line":39,"updated":"2021-07-09 11:52:01.000000000","message":"from manilaclient.v2 import share_group_types\n\nhttps://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_group_types.py","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"59d31d2a283ddbcbeffc7a11ca859ef1374d075e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from manilaclient.v2 import messages"},{"line_number":37,"context_line":"from manilaclient.v2 import security_services"},{"line_number":38,"context_line":"from manilaclient.v2 import share_groups"},{"line_number":39,"context_line":"from manilaclient.v2 import share_instances"},{"line_number":40,"context_line":"from manilaclient.v2 import share_network_subnets"},{"line_number":41,"context_line":"from manilaclient.v2 import share_networks"},{"line_number":42,"context_line":"from manilaclient.v2 import share_servers"}],"source_content_type":"text/x-python","patch_set":1,"id":"699306d2_f34e0c4a","line":39,"in_reply_to":"a5feee27_d43a5ea5","updated":"2021-07-20 06:25:13.000000000","message":"Done","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"525adc5d389a888c8d341e4ec6ce7946c1f47032","unresolved":true,"context_lines":[{"line_number":2656,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/share-groups/1234\u0027)"},{"line_number":2657,"context_line":""},{"line_number":2658,"context_line":"    @ddt.data((\u0027share_group_xyz\u0027, ), (\u0027share_group_abc\u0027, \u0027share_group_xyz\u0027))"},{"line_number":2659,"context_line":"    def test_share_group_create_wait(self, share_types):"},{"line_number":2660,"context_line":"        fake_manager \u003d mock.Mock()"},{"line_number":2661,"context_line":"        fake_share_group \u003d ["},{"line_number":2662,"context_line":"            share_groups.ShareGroup(fake_manager, {\u0027id\u0027: share_group})"}],"source_content_type":"text/x-python","patch_set":1,"id":"66a02800_3bf0f612","line":2659,"updated":"2021-07-09 11:52:01.000000000","message":"Please check what the test should do an think on different resources and functions you need to mock out. Tests need to test what the function is doing. So you need to see what steps are being performed for the share_group_create operation and then simulate those calls.\n\n1. Create share_types mocks\n2. Mock _find_share_type\n3. Create share_group_type mocks\n4. Crete share_network mock\n5. Mock _find_share_network\n6. Run command\n7. Make assertions","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"93e1cee640fe19ff50dca1e2b056613b0e500679","unresolved":true,"context_lines":[{"line_number":2723,"context_line":""},{"line_number":2724,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls(["},{"line_number":2725,"context_line":"            mock.call(self.shell.cs, fake_share_type1,"},{"line_number":2726,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027),"},{"line_number":2727,"context_line":"            mock.call(self.shell.cs, fake_share_type2,"},{"line_number":2728,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027)"},{"line_number":2729,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":5,"id":"2660ea38_3b2e9c05","line":2726,"updated":"2021-08-10 09:43:19.000000000","message":"expected_status\u003d\u0027available\u0027","commit_id":"72b464c74c9bc180c5c05eecac367f2b262b4e42"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"5cc492ad7c8e86e39d50c19121d1daac14eed59f","unresolved":false,"context_lines":[{"line_number":2723,"context_line":""},{"line_number":2724,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls(["},{"line_number":2725,"context_line":"            mock.call(self.shell.cs, fake_share_type1,"},{"line_number":2726,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027),"},{"line_number":2727,"context_line":"            mock.call(self.shell.cs, fake_share_type2,"},{"line_number":2728,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027)"},{"line_number":2729,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ed8303f6_c4786d73","line":2726,"in_reply_to":"2660ea38_3b2e9c05","updated":"2021-08-10 17:09:47.000000000","message":"Done","commit_id":"72b464c74c9bc180c5c05eecac367f2b262b4e42"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"93e1cee640fe19ff50dca1e2b056613b0e500679","unresolved":true,"context_lines":[{"line_number":2725,"context_line":"            mock.call(self.shell.cs, fake_share_type1,"},{"line_number":2726,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027),"},{"line_number":2727,"context_line":"            mock.call(self.shell.cs, fake_share_type2,"},{"line_number":2728,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027)"},{"line_number":2729,"context_line":"        ])"},{"line_number":2730,"context_line":""},{"line_number":2731,"context_line":"    @ddt.data("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a0a95b5_3e79d3fa","line":2728,"updated":"2021-08-10 09:43:19.000000000","message":"expected_status\u003d\u0027available\u0027","commit_id":"72b464c74c9bc180c5c05eecac367f2b262b4e42"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"5cc492ad7c8e86e39d50c19121d1daac14eed59f","unresolved":false,"context_lines":[{"line_number":2725,"context_line":"            mock.call(self.shell.cs, fake_share_type1,"},{"line_number":2726,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027),"},{"line_number":2727,"context_line":"            mock.call(self.shell.cs, fake_share_type2,"},{"line_number":2728,"context_line":"                      resource_type\u003d\u0027share_group\u0027, expected_status\u003d\u0027created\u0027)"},{"line_number":2729,"context_line":"        ])"},{"line_number":2730,"context_line":""},{"line_number":2731,"context_line":"    @ddt.data("}],"source_content_type":"text/x-python","patch_set":5,"id":"e932fe7b_1bb9f7a8","line":2728,"in_reply_to":"5a0a95b5_3e79d3fa","updated":"2021-08-10 17:09:47.000000000","message":"Done","commit_id":"72b464c74c9bc180c5c05eecac367f2b262b4e42"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7fb1baca42835820fcd8be3a469b8cd7e75f619e","unresolved":true,"context_lines":[{"line_number":2674,"context_line":"            fake_manager, {\u0027name\u0027: \u0027fake_sg\u0027, \u0027uuid\u0027: \u00272345\u0027})"},{"line_number":2675,"context_line":"        fake_share_network \u003d share_networks.ShareNetwork("},{"line_number":2676,"context_line":"            fake_manager, {\u0027id\u0027: \u00273456\u0027, \u0027uuid\u0027: \u00273456\u0027})"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"        self.mock_object("},{"line_number":2679,"context_line":"            shell_v2, \u0027_find_share_type\u0027,"},{"line_number":2680,"context_line":"            mock.Mock(side_effect\u003d[fake_share_type1, fake_share_type2]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"97764599_599dabf9","line":2677,"updated":"2021-08-17 10:21:31.000000000","message":"Add\n\n        fake_share_group \u003d share_groups.ShareGroup(\n            fake_manager, {\u0027id\u0027: \u0027fake-sg-id\u0027, \u0027name\u0027: \u0027fake_sg\u0027})","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"351865f8523dff0a1fb5c8c8c05e568fb5af190c","unresolved":false,"context_lines":[{"line_number":2674,"context_line":"            fake_manager, {\u0027name\u0027: \u0027fake_sg\u0027, \u0027uuid\u0027: \u00272345\u0027})"},{"line_number":2675,"context_line":"        fake_share_network \u003d share_networks.ShareNetwork("},{"line_number":2676,"context_line":"            fake_manager, {\u0027id\u0027: \u00273456\u0027, \u0027uuid\u0027: \u00273456\u0027})"},{"line_number":2677,"context_line":""},{"line_number":2678,"context_line":"        self.mock_object("},{"line_number":2679,"context_line":"            shell_v2, \u0027_find_share_type\u0027,"},{"line_number":2680,"context_line":"            mock.Mock(side_effect\u003d[fake_share_type1, fake_share_type2]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"8226472f_b04b6de6","line":2677,"in_reply_to":"97764599_599dabf9","updated":"2021-08-17 11:18:00.000000000","message":"Done","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7fb1baca42835820fcd8be3a469b8cd7e75f619e","unresolved":true,"context_lines":[{"line_number":2686,"context_line":"            mock.Mock(side_effect\u003d[fake_share_network]))"},{"line_number":2687,"context_line":"        self.mock_object("},{"line_number":2688,"context_line":"            shell_v2, \u0027_wait_for_resource_status\u0027,"},{"line_number":2689,"context_line":"            mock.Mock()"},{"line_number":2690,"context_line":"        )"},{"line_number":2691,"context_line":""},{"line_number":2692,"context_line":"        self.run_command("}],"source_content_type":"text/x-python","patch_set":7,"id":"052fac5f_f1557de6","line":2689,"updated":"2021-08-17 10:21:31.000000000","message":"Change mock.Mock() for mock.Mock(side_effect\u003d[fake_share_group])","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"351865f8523dff0a1fb5c8c8c05e568fb5af190c","unresolved":false,"context_lines":[{"line_number":2686,"context_line":"            mock.Mock(side_effect\u003d[fake_share_network]))"},{"line_number":2687,"context_line":"        self.mock_object("},{"line_number":2688,"context_line":"            shell_v2, \u0027_wait_for_resource_status\u0027,"},{"line_number":2689,"context_line":"            mock.Mock()"},{"line_number":2690,"context_line":"        )"},{"line_number":2691,"context_line":""},{"line_number":2692,"context_line":"        self.run_command("}],"source_content_type":"text/x-python","patch_set":7,"id":"5fd16c72_412e5912","line":2689,"in_reply_to":"052fac5f_f1557de6","updated":"2021-08-17 11:18:00.000000000","message":"Ack","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7fb1baca42835820fcd8be3a469b8cd7e75f619e","unresolved":true,"context_lines":[{"line_number":2721,"context_line":"        }"},{"line_number":2722,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/share-groups\u0027, body\u003dexpected)"},{"line_number":2723,"context_line":""},{"line_number":2724,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls(["},{"line_number":2725,"context_line":"            mock.call(self.shell.cs, fake_share_type1,"},{"line_number":2726,"context_line":"                      resource_type\u003d\u0027share_group\u0027,"},{"line_number":2727,"context_line":"                      expected_status\u003d\u0027available\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"1d4cd2f0_668d389a","line":2724,"updated":"2021-08-17 10:21:31.000000000","message":"Change this for\n\n        shell_v2._wait_for_resource_status.assert_has_calls([\n            mock.call(self.shell.cs, fake_share_group,\n                      resource_type\u003d\u0027share_group\u0027,\n                      expected_status\u003d\u0027available\u0027)","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"351865f8523dff0a1fb5c8c8c05e568fb5af190c","unresolved":false,"context_lines":[{"line_number":2721,"context_line":"        }"},{"line_number":2722,"context_line":"        self.assert_called(\u0027POST\u0027, \u0027/share-groups\u0027, body\u003dexpected)"},{"line_number":2723,"context_line":""},{"line_number":2724,"context_line":"        shell_v2._wait_for_resource_status.assert_has_calls(["},{"line_number":2725,"context_line":"            mock.call(self.shell.cs, fake_share_type1,"},{"line_number":2726,"context_line":"                      resource_type\u003d\u0027share_group\u0027,"},{"line_number":2727,"context_line":"                      expected_status\u003d\u0027available\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a47a2f2_2a690373","line":2724,"in_reply_to":"1d4cd2f0_668d389a","updated":"2021-08-17 11:18:00.000000000","message":"Ack","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"525adc5d389a888c8d341e4ec6ce7946c1f47032","unresolved":true,"context_lines":[{"line_number":5253,"context_line":"@cliutils.arg("},{"line_number":5254,"context_line":"    \u0027--wait\u0027,"},{"line_number":5255,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":5256,"context_line":"    help\u003d\u0027Wait for share group to create\u0027)"},{"line_number":5257,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":5258,"context_line":"def do_share_group_create(cs, args):"},{"line_number":5259,"context_line":"    \"\"\"Creates a new share group.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2ba06d7b_88875f70","line":5256,"updated":"2021-07-09 11:52:01.000000000","message":"default\u003d\u0027False\u0027","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"59d31d2a283ddbcbeffc7a11ca859ef1374d075e","unresolved":false,"context_lines":[{"line_number":5253,"context_line":"@cliutils.arg("},{"line_number":5254,"context_line":"    \u0027--wait\u0027,"},{"line_number":5255,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":5256,"context_line":"    help\u003d\u0027Wait for share group to create\u0027)"},{"line_number":5257,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":5258,"context_line":"def do_share_group_create(cs, args):"},{"line_number":5259,"context_line":"    \"\"\"Creates a new share group.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2088efcb_e07cf163","line":5256,"in_reply_to":"2ba06d7b_88875f70","updated":"2021-07-20 06:25:13.000000000","message":"Done","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"525adc5d389a888c8d341e4ec6ce7946c1f47032","unresolved":true,"context_lines":[{"line_number":5296,"context_line":"                    expected_status\u003d\u0027created\u0027)"},{"line_number":5297,"context_line":"            except exceptions.CommandError as e:"},{"line_number":5298,"context_line":"                print(e, file\u003dsys.stderr)"},{"line_number":5299,"context_line":""},{"line_number":5300,"context_line":""},{"line_number":5301,"context_line":"@cliutils.arg("},{"line_number":5302,"context_line":"    \u0027--all-tenants\u0027, \u0027--all-projects\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fb997a98_2960a444","line":5299,"updated":"2021-07-09 11:52:01.000000000","message":"_print_share_group(cs, share_group)","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"59d31d2a283ddbcbeffc7a11ca859ef1374d075e","unresolved":false,"context_lines":[{"line_number":5296,"context_line":"                    expected_status\u003d\u0027created\u0027)"},{"line_number":5297,"context_line":"            except exceptions.CommandError as e:"},{"line_number":5298,"context_line":"                print(e, file\u003dsys.stderr)"},{"line_number":5299,"context_line":""},{"line_number":5300,"context_line":""},{"line_number":5301,"context_line":"@cliutils.arg("},{"line_number":5302,"context_line":"    \u0027--all-tenants\u0027, \u0027--all-projects\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab23878_e94c14c7","line":5299,"in_reply_to":"fb997a98_2960a444","updated":"2021-07-20 06:25:13.000000000","message":"Done","commit_id":"20745ea2ef9594a57cbe35fb26384af6e180b567"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"93e1cee640fe19ff50dca1e2b056613b0e500679","unresolved":true,"context_lines":[{"line_number":5330,"context_line":"            try:"},{"line_number":5331,"context_line":"                _wait_for_resource_status("},{"line_number":5332,"context_line":"                    cs, share_group, resource_type\u003d\u0027share_group\u0027,"},{"line_number":5333,"context_line":"                    expected_status\u003d\u0027created\u0027)"},{"line_number":5334,"context_line":"            except exceptions.CommandError as e:"},{"line_number":5335,"context_line":"                print(e, file\u003dsys.stderr)"},{"line_number":5336,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"10a15e1b_019b16fa","line":5333,"updated":"2021-08-10 09:43:19.000000000","message":"expected_status\u003d\u0027available\u0027","commit_id":"72b464c74c9bc180c5c05eecac367f2b262b4e42"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"5cc492ad7c8e86e39d50c19121d1daac14eed59f","unresolved":false,"context_lines":[{"line_number":5330,"context_line":"            try:"},{"line_number":5331,"context_line":"                _wait_for_resource_status("},{"line_number":5332,"context_line":"                    cs, share_group, resource_type\u003d\u0027share_group\u0027,"},{"line_number":5333,"context_line":"                    expected_status\u003d\u0027created\u0027)"},{"line_number":5334,"context_line":"            except exceptions.CommandError as e:"},{"line_number":5335,"context_line":"                print(e, file\u003dsys.stderr)"},{"line_number":5336,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bdd3dee4_70cd54ef","line":5333,"in_reply_to":"10a15e1b_019b16fa","updated":"2021-08-10 17:09:47.000000000","message":"Done","commit_id":"72b464c74c9bc180c5c05eecac367f2b262b4e42"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"70f985f75a13519a5a5609c43f9039447b331e10","unresolved":true,"context_lines":[{"line_number":5326,"context_line":""},{"line_number":5327,"context_line":"    share_group \u003d cs.share_groups.create(**kwargs)"},{"line_number":5328,"context_line":"    if args.wait:"},{"line_number":5329,"context_line":"        for share_group in share_types:"},{"line_number":5330,"context_line":"            try:"},{"line_number":5331,"context_line":"                _wait_for_resource_status("},{"line_number":5332,"context_line":"                    cs, share_group, resource_type\u003d\u0027share_group\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fbd2b6a0_c1ad59f7","line":5329,"updated":"2021-08-12 09:28:14.000000000","message":"Drop this for loop","commit_id":"c33552152370ed59669843b99650939ce2f65163"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"819c08491ebefc53a57402e69a853ac601b1d3d6","unresolved":true,"context_lines":[{"line_number":5328,"context_line":"    if args.wait:"},{"line_number":5329,"context_line":"        for share_group in share_types:"},{"line_number":5330,"context_line":"            try:"},{"line_number":5331,"context_line":"                _wait_for_resource_status("},{"line_number":5332,"context_line":"                    cs, share_group, resource_type\u003d\u0027share_group\u0027,"},{"line_number":5333,"context_line":"                    expected_status\u003d\u0027available\u0027)"},{"line_number":5334,"context_line":"            except exceptions.CommandError as e:"}],"source_content_type":"text/x-python","patch_set":6,"id":"0a77c63d_3476a193","line":5331,"updated":"2021-08-12 09:47:55.000000000","message":"Also, assign this to share_group","commit_id":"c33552152370ed59669843b99650939ce2f65163"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0f627146b548865099964f0c41bf44c1d16e36d7","unresolved":true,"context_lines":[{"line_number":5289,"context_line":"@cliutils.arg("},{"line_number":5290,"context_line":"    \u0027--wait\u0027,"},{"line_number":5291,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":5292,"context_line":"    default\u003d\u0027False\u0027,"},{"line_number":5293,"context_line":"    help\u003d\u0027Wait for share group to create\u0027)"},{"line_number":5294,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":5295,"context_line":"def do_share_group_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7e8a799c_25407b8c","line":5292,"updated":"2021-08-17 10:39:25.000000000","message":"Another issue here, this should be False, not \u0027False\u0027\n\nThe first one (the one we need) is a boolean. The second one, is a string.\n\nIn the conditional check we do below (if args.wait), if we pass the string, it will resolve to true and that is an incorrect behavior.","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"351865f8523dff0a1fb5c8c8c05e568fb5af190c","unresolved":false,"context_lines":[{"line_number":5289,"context_line":"@cliutils.arg("},{"line_number":5290,"context_line":"    \u0027--wait\u0027,"},{"line_number":5291,"context_line":"    action\u003d\u0027store_true\u0027,"},{"line_number":5292,"context_line":"    default\u003d\u0027False\u0027,"},{"line_number":5293,"context_line":"    help\u003d\u0027Wait for share group to create\u0027)"},{"line_number":5294,"context_line":"@cliutils.service_type(\u0027sharev2\u0027)"},{"line_number":5295,"context_line":"def do_share_group_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"924ebce6_2bfc1371","line":5292,"in_reply_to":"7e8a799c_25407b8c","updated":"2021-08-17 11:18:00.000000000","message":"Ack","commit_id":"8ddce67a7701bd4be23c51a9a781dac57acb4d0b"}]}