)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":13,"context_line":"share group show"},{"line_number":14,"context_line":"share group set"},{"line_number":15,"context_line":"share group unset"},{"line_number":16,"context_line":"share group set --status"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9eb31449fef4eae73f1db91f2bad133d0fe8df2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"e2ba0c50_e0c9e01f","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":24},"updated":"2021-08-10 06:18:20.000000000","message":"you can remove this line, the share group set command is already noted on line 14","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a39d843b478957ae359dac5e82cfa585b0f126a9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"share group show"},{"line_number":14,"context_line":"share group set"},{"line_number":15,"context_line":"share group unset"},{"line_number":16,"context_line":"share group set --status"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9eb31449fef4eae73f1db91f2bad133d0fe8df2e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"750d7daf_f66837e3","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":24},"in_reply_to":"e2ba0c50_e0c9e01f","updated":"2021-08-11 06:05:05.000000000","message":"Ack","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"}],"doc/source/cli/osc/v2/index.rst":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":48,"context_line":"    :command: share revert"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":51,"context_line":"    :command: share reset state"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":"share access rules"}],"source_content_type":"text/x-rst","patch_set":3,"id":"b038fcaa_5269237d","line":51,"updated":"2021-07-23 09:10:59.000000000","message":"Why are we adding this? This command is not in the spec: https://specs.openstack.org/openstack/manila-specs/specs/release_independent/manila-support-openstackclient.html#share-actions\nAlso, \u0027openstack share set --status\u0027 is already implemented","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    :command: share revert"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":51,"context_line":"    :command: share reset state"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":"share access rules"}],"source_content_type":"text/x-rst","patch_set":3,"id":"72878969_989a5e04","line":51,"in_reply_to":"b038fcaa_5269237d","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4402f7fad68c299b77f524bd891762eae75fd79a","unresolved":true,"context_lines":[{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":111,"context_line":"    :command: share pool list"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":"share groups"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":26,"id":"7e015296_1bd6fe2d","line":111,"updated":"2021-08-25 05:54:02.000000000","message":"I think you are missing a new line here?","commit_id":"0769ca066f5ce7fd580743a15c5afc6d4d557c2c"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3ab1a4f46901c1a584231c258c35f56d6dc21936","unresolved":false,"context_lines":[{"line_number":108,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":111,"context_line":"    :command: share pool list"},{"line_number":112,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":113,"context_line":"share groups"},{"line_number":114,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":26,"id":"0875f77a_823b4669","line":111,"in_reply_to":"7e015296_1bd6fe2d","updated":"2021-08-31 20:05:34.000000000","message":"Ack","commit_id":"0769ca066f5ce7fd580743a15c5afc6d4d557c2c"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":1097,"context_line":"                \"Failed to revert share to snapshot: %s\" % (e)))"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"class ResetStateShare(command.Command):"},{"line_number":1101,"context_line":"    \"\"\"Explicitly update the state of a share.\"\"\""},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    _description \u003d _(\"Revert a share to the specified snapshot.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"49e66f4b_a0f7ff04","line":1100,"updated":"2021-07-23 09:10:59.000000000","message":"Again, I am confused about having this addition here, this is not related to share groups and it looks like it is just looking up a share but not returning anything?\nExplicitly setting a share status is already implemented: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share.py#L619","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":1097,"context_line":"                \"Failed to revert share to snapshot: %s\" % (e)))"},{"line_number":1098,"context_line":""},{"line_number":1099,"context_line":""},{"line_number":1100,"context_line":"class ResetStateShare(command.Command):"},{"line_number":1101,"context_line":"    \"\"\"Explicitly update the state of a share.\"\"\""},{"line_number":1102,"context_line":""},{"line_number":1103,"context_line":"    _description \u003d _(\"Revert a share to the specified snapshot.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ac89b2f_e8eaced5","line":1100,"in_reply_to":"49e66f4b_a0f7ff04","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"}],"manilaclient/osc/v2/share_groups.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class CreateShareGroup(command.ShowOne):"},{"line_number":25,"context_line":"    \"\"\"Create new share type.\"\"\""},{"line_number":26,"context_line":"    _description \u003d _("},{"line_number":27,"context_line":"        \"Create new share type\")"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"073df3fd_f5dea5ae","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":28},"updated":"2021-07-23 09:10:59.000000000","message":"group","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class CreateShareGroup(command.ShowOne):"},{"line_number":25,"context_line":"    \"\"\"Create new share type.\"\"\""},{"line_number":26,"context_line":"    _description \u003d _("},{"line_number":27,"context_line":"        \"Create new share type\")"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"95476929_71fac2cf","line":25,"range":{"start_line":25,"start_character":24,"end_line":25,"end_character":28},"in_reply_to":"073df3fd_f5dea5ae","updated":"2021-07-26 07:19:09.000000000","message":"Done","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":24,"context_line":"class CreateShareGroup(command.ShowOne):"},{"line_number":25,"context_line":"    \"\"\"Create new share type.\"\"\""},{"line_number":26,"context_line":"    _description \u003d _("},{"line_number":27,"context_line":"        \"Create new share type\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateShareGroup\")"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5215b898_a9864f65","line":27,"range":{"start_line":27,"start_character":26,"end_line":27,"end_character":30},"updated":"2021-07-23 09:10:59.000000000","message":"group","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":24,"context_line":"class CreateShareGroup(command.ShowOne):"},{"line_number":25,"context_line":"    \"\"\"Create new share type.\"\"\""},{"line_number":26,"context_line":"    _description \u003d _("},{"line_number":27,"context_line":"        \"Create new share type\")"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateShareGroup\")"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"c4fda4be_8343a61c","line":27,"range":{"start_line":27,"start_character":26,"end_line":27,"end_character":30},"in_reply_to":"5215b898_a9864f65","updated":"2021-07-26 07:19:09.000000000","message":"Done","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":42,"context_line":"            default\u003dNone,"},{"line_number":43,"context_line":"            help\u003d_(\"Share group description. \""},{"line_number":44,"context_line":"                   \"Available only for microversion \u003e\u003d 2.41.\"),"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \"--share-types\","}],"source_content_type":"text/x-python","patch_set":3,"id":"49170f3b_2f69ea01","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":59},"updated":"2021-07-23 09:10:59.000000000","message":"I believe this is not true.","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            metavar\u003d\"\u003cdescription\u003e\","},{"line_number":42,"context_line":"            default\u003dNone,"},{"line_number":43,"context_line":"            help\u003d_(\"Share group description. \""},{"line_number":44,"context_line":"                   \"Available only for microversion \u003e\u003d 2.41.\"),"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \"--share-types\","}],"source_content_type":"text/x-python","patch_set":3,"id":"67a9c24b_1b92ef46","line":44,"range":{"start_line":44,"start_character":20,"end_line":44,"end_character":59},"in_reply_to":"49170f3b_2f69ea01","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \"--share-types\","},{"line_number":48,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d_(\"Comma-separated list of share types.\"),"},{"line_number":51,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"e3b0030e_2307b0e5","line":48,"updated":"2021-07-23 09:10:59.000000000","message":"Since it is a list, you\u0027ll need to add `nargs\u003d\"+\",` here","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \"--share-types\","},{"line_number":48,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d_(\"Comma-separated list of share types.\"),"},{"line_number":51,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"951e3e2a_b6494819","line":48,"in_reply_to":"e3b0030e_2307b0e5","updated":"2021-07-26 07:19:09.000000000","message":"Done","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            \"--share-types\","},{"line_number":48,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d_(\"Comma-separated list of share types.\"),"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \"--share-group-type\","}],"source_content_type":"text/x-python","patch_set":3,"id":"1d9b2f73_9ecad7a8","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":55},"updated":"2021-07-23 09:10:59.000000000","message":"\"Name or ID of share type(s).\"\nWe don\u0027t use a comma-separator in OSC commands, we separate by leaving a space.","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \"--share-types\","},{"line_number":48,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d_(\"Comma-separated list of share types.\"),"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \"--share-group-type\","}],"source_content_type":"text/x-python","patch_set":3,"id":"a00a0161_286cd783","line":50,"range":{"start_line":50,"start_character":20,"end_line":50,"end_character":55},"in_reply_to":"1d9b2f73_9ecad7a8","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \"--share-group-type\","},{"line_number":54,"context_line":"            metavar\u003d\"\u003cshare_group_type\u003e\","},{"line_number":55,"context_line":"            default\u003dNone,"},{"line_number":56,"context_line":"            help\u003d_(\"Share group type name or ID of the share \""},{"line_number":57,"context_line":"                   \"group to be created.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"a12518ba_ae6c7747","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":38},"updated":"2021-07-23 09:10:59.000000000","message":"\"\u003cshare-group-type\u003e\"\nmetavar should be with hyphens not underscores, apply this to the rest of the options as well please :)","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \"--share-group-type\","},{"line_number":54,"context_line":"            metavar\u003d\"\u003cshare_group_type\u003e\","},{"line_number":55,"context_line":"            default\u003dNone,"},{"line_number":56,"context_line":"            help\u003d_(\"Share group type name or ID of the share \""},{"line_number":57,"context_line":"                   \"group to be created.\"),"}],"source_content_type":"text/x-python","patch_set":3,"id":"e7706583_159fe9c6","line":54,"range":{"start_line":54,"start_character":22,"end_line":54,"end_character":38},"in_reply_to":"a12518ba_ae6c7747","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        share_type \u003d None"},{"line_number":85,"context_line":"        if parsed_args.share_type:"},{"line_number":86,"context_line":"            share_type \u003d apiutils.find_resource("},{"line_number":87,"context_line":"                share_client.share_types,"},{"line_number":88,"context_line":"                parsed_args.share_type).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"272cecae_f69ee055","line":85,"updated":"2021-07-23 09:10:59.000000000","message":"since this is a list, you\u0027ll need to loop over it.","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        share_type \u003d None"},{"line_number":85,"context_line":"        if parsed_args.share_type:"},{"line_number":86,"context_line":"            share_type \u003d apiutils.find_resource("},{"line_number":87,"context_line":"                share_client.share_types,"},{"line_number":88,"context_line":"                parsed_args.share_type).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"5ac18f98_274860e7","line":85,"in_reply_to":"272cecae_f69ee055","updated":"2021-07-26 07:19:09.000000000","message":"how can i loop over it? can you share your approach in details or any links/docs for the reference?","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        share_type \u003d None"},{"line_number":85,"context_line":"        if parsed_args.share_type:"},{"line_number":86,"context_line":"            share_type \u003d apiutils.find_resource("},{"line_number":87,"context_line":"                share_client.share_types,"},{"line_number":88,"context_line":"                parsed_args.share_type).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"b566196b_32aac196","line":85,"in_reply_to":"5ac18f98_274860e7","updated":"2021-07-26 17:11:27.000000000","message":"Sure :)\nSo this would be a for loop. You\u0027d need to first create an empty list:\nshare_types \u003d []\nthen, for each `share_type` in `parsed_args.share_types` you would find the `share_type` resource and append it to the `share_types` list.\nHere is a good example: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v3/volume_group.py#L129-L136","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        share_type \u003d None"},{"line_number":85,"context_line":"        if parsed_args.share_type:"},{"line_number":86,"context_line":"            share_type \u003d apiutils.find_resource("},{"line_number":87,"context_line":"                share_client.share_types,"},{"line_number":88,"context_line":"                parsed_args.share_type).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"c5c495ba_2b12fc62","line":85,"in_reply_to":"b566196b_32aac196","updated":"2021-07-28 06:42:48.000000000","message":"Thank you Maari :)","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":99,"context_line":"                parsed_args.share_network).id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        share_group \u003d None"},{"line_number":102,"context_line":"        if parsed_args.share_group:"},{"line_number":103,"context_line":"            share_group \u003d apiutils.find_resource("},{"line_number":104,"context_line":"                share_client.share_groups,"},{"line_number":105,"context_line":"                parsed_args.share_group).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"f8e33911_430985e3","line":102,"updated":"2021-07-23 09:10:59.000000000","message":"We don\u0027t have this argument for this command.","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                parsed_args.share_network).id"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        share_group \u003d None"},{"line_number":102,"context_line":"        if parsed_args.share_group:"},{"line_number":103,"context_line":"            share_group \u003d apiutils.find_resource("},{"line_number":104,"context_line":"                share_client.share_groups,"},{"line_number":105,"context_line":"                parsed_args.share_group).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"355b5d25_31e8f7f5","line":102,"in_reply_to":"f8e33911_430985e3","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":105,"context_line":"                parsed_args.share_group).id"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        share_group_snapshot \u003d None"},{"line_number":108,"context_line":"        if parsed_args.share_group_snapshot:"},{"line_number":109,"context_line":"            share_group_snapshot \u003d apiutils.find_resource("},{"line_number":110,"context_line":"                share_client.share_group_snapshots,"},{"line_number":111,"context_line":"                parsed_args.share_group_snapshot).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"25af8360_18b730d8","line":108,"updated":"2021-07-23 09:10:59.000000000","message":"the argument is `source_share_group_snapshot`","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                parsed_args.share_group).id"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        share_group_snapshot \u003d None"},{"line_number":108,"context_line":"        if parsed_args.share_group_snapshot:"},{"line_number":109,"context_line":"            share_group_snapshot \u003d apiutils.find_resource("},{"line_number":110,"context_line":"                share_client.share_group_snapshots,"},{"line_number":111,"context_line":"                parsed_args.share_group_snapshot).id"}],"source_content_type":"text/x-python","patch_set":3,"id":"a45effcb_e604fc89","line":108,"in_reply_to":"25af8360_18b730d8","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":115,"context_line":"            \u0027description\u0027: parsed_args.description,"},{"line_number":116,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":117,"context_line":"            \u0027share_group_type\u0027: share_group_type,"},{"line_number":118,"context_line":"            \u0027share_group\u0027: share_group,"},{"line_number":119,"context_line":"            \u0027share_network\u0027: share_network,"},{"line_number":120,"context_line":"            \u0027source_share_group_snapshot\u0027: share_group_snapshot,"},{"line_number":121,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"71e7affd_1cb846f5","line":118,"range":{"start_line":118,"start_character":12,"end_line":118,"end_character":38},"updated":"2021-07-23 09:10:59.000000000","message":"we don\u0027t have this option here.","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            \u0027description\u0027: parsed_args.description,"},{"line_number":116,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":117,"context_line":"            \u0027share_group_type\u0027: share_group_type,"},{"line_number":118,"context_line":"            \u0027share_group\u0027: share_group,"},{"line_number":119,"context_line":"            \u0027share_network\u0027: share_network,"},{"line_number":120,"context_line":"            \u0027source_share_group_snapshot\u0027: share_group_snapshot,"},{"line_number":121,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"314f2f9c_989f0bc6","line":118,"range":{"start_line":118,"start_character":12,"end_line":118,"end_character":38},"in_reply_to":"71e7affd_1cb846f5","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":121,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        share \u003d share_client.shares.create(**body)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if parsed_args.wait:"},{"line_number":127,"context_line":"            if not oscutils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":3,"id":"16313ee2_6d31254e","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":50},"updated":"2021-07-23 09:10:59.000000000","message":"we want to create share groups here not shares right? :)","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":122,"context_line":"        }"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        share \u003d share_client.shares.create(**body)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        if parsed_args.wait:"},{"line_number":127,"context_line":"            if not oscutils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":3,"id":"02ca500a_080bfcf6","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":50},"in_reply_to":"16313ee2_6d31254e","updated":"2021-07-26 07:19:09.000000000","message":"Ack","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":444,"context_line":"    _description \u003d _(\"Show details about a replica\")"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def get_parser(self, prog_name):"},{"line_number":447,"context_line":"        parser \u003d super(ShowShareReplica, self).get_parser(prog_name)"},{"line_number":448,"context_line":"        parser.add_argument("},{"line_number":449,"context_line":"            \"share_group\","},{"line_number":450,"context_line":"            metavar\u003d\"\u003cshare_group\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"e902d590_fff93ab4","line":447,"range":{"start_line":447,"start_character":23,"end_line":447,"end_character":39},"updated":"2021-07-23 09:10:59.000000000","message":"ShowShareGroup","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":444,"context_line":"    _description \u003d _(\"Show details about a replica\")"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"    def get_parser(self, prog_name):"},{"line_number":447,"context_line":"        parser \u003d super(ShowShareReplica, self).get_parser(prog_name)"},{"line_number":448,"context_line":"        parser.add_argument("},{"line_number":449,"context_line":"            \"share_group\","},{"line_number":450,"context_line":"            metavar\u003d\"\u003cshare_group\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"8bc0a493_8c435c8b","line":447,"range":{"start_line":447,"start_character":23,"end_line":447,"end_character":39},"in_reply_to":"e902d590_fff93ab4","updated":"2021-07-26 07:19:09.000000000","message":"Done","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":75,"context_line":"            default\u003dNone,"},{"line_number":76,"context_line":"            help\u003d_(\"Optional availability zone in which group \""},{"line_number":77,"context_line":"                   \"should be created\"),"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        return parser"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a20a0a14_cc64b6d8","line":78,"updated":"2021-07-26 17:11:27.000000000","message":"add the `--wait` option here as well.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":75,"context_line":"            default\u003dNone,"},{"line_number":76,"context_line":"            help\u003d_(\"Optional availability zone in which group \""},{"line_number":77,"context_line":"                   \"should be created\"),"},{"line_number":78,"context_line":"        )"},{"line_number":79,"context_line":"        return parser"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7a756c0_c6d5d3f7","line":78,"in_reply_to":"a20a0a14_cc64b6d8","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":114,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        share \u003d share_client.share_groups.create(**body)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if parsed_args.wait:"},{"line_number":120,"context_line":"            if not oscutils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"95d64011_7608e18e","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":13},"updated":"2021-07-26 17:11:27.000000000","message":"rename this to `share_group` and update the references to it.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":115,"context_line":"        }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        share \u003d share_client.share_groups.create(**body)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"        if parsed_args.wait:"},{"line_number":120,"context_line":"            if not oscutils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"cd5861d9_47bb9003","line":117,"range":{"start_line":117,"start_character":8,"end_line":117,"end_character":13},"in_reply_to":"95d64011_7608e18e","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":127,"context_line":"            share \u003d apiutils.find_resource(share_client.share_groups,"},{"line_number":128,"context_line":"                                           share.id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        printable_share \u003d share._info"},{"line_number":131,"context_line":"        printable_share.pop(\u0027links\u0027, None)"},{"line_number":132,"context_line":"        printable_share.pop(\u0027shares_type\u0027, None)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4e5b945c_b1e179df","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":23},"updated":"2021-07-26 17:11:27.000000000","message":"rename this to `printable_share_group` and update the references to it.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            share \u003d apiutils.find_resource(share_client.share_groups,"},{"line_number":128,"context_line":"                                           share.id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        printable_share \u003d share._info"},{"line_number":131,"context_line":"        printable_share.pop(\u0027links\u0027, None)"},{"line_number":132,"context_line":"        printable_share.pop(\u0027shares_type\u0027, None)"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"42588fc2_7e787afe","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":23},"in_reply_to":"4e5b945c_b1e179df","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f9c6ae95ca19948d42459209bfcf1ff101657269","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            \"--share-types\","},{"line_number":47,"context_line":"            metavar\u003d\"\u003cshare-types\u003e\","},{"line_number":48,"context_line":"            nargs\u003d\"+\","},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d_(\"Name or ID of share type(s).\"),"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"d6e12bbf_6dcf39ea","line":49,"updated":"2021-07-28 13:04:49.000000000","message":"default\u003d[]\nThis should be causing the error for you at the moment, see also: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v3/volume_group.py#L94","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"8d9fd1053187f8c3daf22911acfc2ee0f433cb8d","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \"--share-types\","},{"line_number":47,"context_line":"            metavar\u003d\"\u003cshare-types\u003e\","},{"line_number":48,"context_line":"            nargs\u003d\"+\","},{"line_number":49,"context_line":"            default\u003dNone,"},{"line_number":50,"context_line":"            help\u003d_(\"Name or ID of share type(s).\"),"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"aebfdd74_428aea15","line":49,"in_reply_to":"d6e12bbf_6dcf39ea","updated":"2021-07-29 07:22:33.000000000","message":"Ack","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f9c6ae95ca19948d42459209bfcf1ff101657269","unresolved":true,"context_lines":[{"line_number":90,"context_line":"        share_types \u003d []"},{"line_number":91,"context_line":"        for share_type in parsed_args.share_types:"},{"line_number":92,"context_line":"            share_types.append("},{"line_number":93,"context_line":"                utils.find_resource("},{"line_number":94,"context_line":"                    share_client.share_types,"},{"line_number":95,"context_line":"                    share_type,"},{"line_number":96,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":5,"id":"f8e0d099_ef59a3e6","line":93,"range":{"start_line":93,"start_character":16,"end_line":93,"end_character":21},"updated":"2021-07-28 13:04:49.000000000","message":"osc_utils\ncheck the imports in this file and compare to where you took this example from: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/volume/v3/volume_group.py#L18\ndouble check this in other places in the code where you are using the find_resource() method as well","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"8d9fd1053187f8c3daf22911acfc2ee0f433cb8d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        share_types \u003d []"},{"line_number":91,"context_line":"        for share_type in parsed_args.share_types:"},{"line_number":92,"context_line":"            share_types.append("},{"line_number":93,"context_line":"                utils.find_resource("},{"line_number":94,"context_line":"                    share_client.share_types,"},{"line_number":95,"context_line":"                    share_type,"},{"line_number":96,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":5,"id":"eac09284_cfd505fd","line":93,"range":{"start_line":93,"start_character":16,"end_line":93,"end_character":21},"in_reply_to":"f8e0d099_ef59a3e6","updated":"2021-07-29 07:22:33.000000000","message":"Done","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f9c6ae95ca19948d42459209bfcf1ff101657269","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        body \u003d {"},{"line_number":117,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":118,"context_line":"            \u0027description\u0027: parsed_args.description,"},{"line_number":119,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":120,"context_line":"            \u0027share_group_type\u0027: share_group_type,"},{"line_number":121,"context_line":"            \u0027share_network\u0027: share_network,"},{"line_number":122,"context_line":"            \u0027source_share_group_snapshot\u0027: source_share_group_snapshot,"}],"source_content_type":"text/x-python","patch_set":5,"id":"b4b77e81_4a95e41f","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":36},"updated":"2021-07-28 13:04:49.000000000","message":"\u0027share_types\u0027: share_types","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"8d9fd1053187f8c3daf22911acfc2ee0f433cb8d","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        body \u003d {"},{"line_number":117,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":118,"context_line":"            \u0027description\u0027: parsed_args.description,"},{"line_number":119,"context_line":"            \u0027share_type\u0027: share_type,"},{"line_number":120,"context_line":"            \u0027share_group_type\u0027: share_group_type,"},{"line_number":121,"context_line":"            \u0027share_network\u0027: share_network,"},{"line_number":122,"context_line":"            \u0027source_share_group_snapshot\u0027: source_share_group_snapshot,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9df61438_03b3c415","line":119,"range":{"start_line":119,"start_character":12,"end_line":119,"end_character":36},"in_reply_to":"b4b77e81_4a95e41f","updated":"2021-07-29 07:22:33.000000000","message":"Done","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f9c6ae95ca19948d42459209bfcf1ff101657269","unresolved":true,"context_lines":[{"line_number":123,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        share_group \u003d share_group_client.share_groups.create(**body)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if parsed_args.wait:"},{"line_number":129,"context_line":"            if not oscutils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":5,"id":"4a24fb2a_faea46c0","line":126,"range":{"start_line":126,"start_character":22,"end_line":126,"end_character":40},"updated":"2021-07-28 13:04:49.000000000","message":"share_client (as you define it in line 88)","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"8d9fd1053187f8c3daf22911acfc2ee0f433cb8d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":124,"context_line":"        }"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"        share_group \u003d share_group_client.share_groups.create(**body)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if parsed_args.wait:"},{"line_number":129,"context_line":"            if not oscutils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":5,"id":"fb7eebf2_557952e0","line":126,"range":{"start_line":126,"start_character":22,"end_line":126,"end_character":40},"in_reply_to":"4a24fb2a_faea46c0","updated":"2021-07-29 07:22:33.000000000","message":"Ack","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f9c6ae95ca19948d42459209bfcf1ff101657269","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if parsed_args.wait:"},{"line_number":129,"context_line":"            if not oscutils.wait_for_status("},{"line_number":130,"context_line":"                status_f\u003dshare_group_client.share_groups.get,"},{"line_number":131,"context_line":"                res_id\u003dshare.id,"},{"line_number":132,"context_line":"                success_status\u003d[\u0027available\u0027]"},{"line_number":133,"context_line":"            ):"}],"source_content_type":"text/x-python","patch_set":5,"id":"535659e6_1ba86b3a","line":130,"range":{"start_line":130,"start_character":25,"end_line":130,"end_character":43},"updated":"2021-07-28 13:04:49.000000000","message":"share_client","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"8d9fd1053187f8c3daf22911acfc2ee0f433cb8d","unresolved":false,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        if parsed_args.wait:"},{"line_number":129,"context_line":"            if not oscutils.wait_for_status("},{"line_number":130,"context_line":"                status_f\u003dshare_group_client.share_groups.get,"},{"line_number":131,"context_line":"                res_id\u003dshare.id,"},{"line_number":132,"context_line":"                success_status\u003d[\u0027available\u0027]"},{"line_number":133,"context_line":"            ):"}],"source_content_type":"text/x-python","patch_set":5,"id":"cf30ecb4_a92130bb","line":130,"range":{"start_line":130,"start_character":25,"end_line":130,"end_character":43},"in_reply_to":"535659e6_1ba86b3a","updated":"2021-07-29 07:22:33.000000000","message":"Ack","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f9c6ae95ca19948d42459209bfcf1ff101657269","unresolved":true,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":140,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":141,"context_line":"        printable_share_group.pop(\u0027shares_type\u0027, None)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        return self.dict2columns(printable_share_group)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"96ba83a3_d79dce10","line":141,"updated":"2021-07-28 13:04:49.000000000","message":"There is no attribute called \u0027shares_type\u0027, there is \u0027share_types\" but in any case we want to remove that from the output so you can just remove this line. We only want to remove \"links\".","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"8d9fd1053187f8c3daf22911acfc2ee0f433cb8d","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":140,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":141,"context_line":"        printable_share_group.pop(\u0027shares_type\u0027, None)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"        return self.dict2columns(printable_share_group)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"04b3da22_084ad982","line":141,"in_reply_to":"96ba83a3_d79dce10","updated":"2021-07-29 07:22:33.000000000","message":"Ack","commit_id":"1886e597ba396fb5bbe9e3cbab560c7e5fc7191f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":281,"context_line":"        )"},{"line_number":282,"context_line":"        parser.add_argument("},{"line_number":283,"context_line":"            \"--limit\","},{"line_number":284,"context_line":"            metavar\u003d\"\u003cnum-snapshots\u003e\","},{"line_number":285,"context_line":"            type\u003dint,"},{"line_number":286,"context_line":"            default\u003dNone,"},{"line_number":287,"context_line":"            action\u003dparseractions.NonNegativeAction,"}],"source_content_type":"text/x-python","patch_set":18,"id":"033a4dd6_acfa8fbb","line":284,"range":{"start_line":284,"start_character":22,"end_line":284,"end_character":35},"updated":"2021-08-07 17:05:34.000000000","message":"limit","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        )"},{"line_number":282,"context_line":"        parser.add_argument("},{"line_number":283,"context_line":"            \"--limit\","},{"line_number":284,"context_line":"            metavar\u003d\"\u003cnum-snapshots\u003e\","},{"line_number":285,"context_line":"            type\u003dint,"},{"line_number":286,"context_line":"            default\u003dNone,"},{"line_number":287,"context_line":"            action\u003dparseractions.NonNegativeAction,"}],"source_content_type":"text/x-python","patch_set":18,"id":"a69ea5d9_af9baef2","line":284,"range":{"start_line":284,"start_character":22,"end_line":284,"end_character":35},"in_reply_to":"033a4dd6_acfa8fbb","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":285,"context_line":"            type\u003dint,"},{"line_number":286,"context_line":"            default\u003dNone,"},{"line_number":287,"context_line":"            action\u003dparseractions.NonNegativeAction,"},{"line_number":288,"context_line":"            help\u003d_(\"Limit the number of snapshots returned\")"},{"line_number":289,"context_line":"        )"},{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--marker\","}],"source_content_type":"text/x-python","patch_set":18,"id":"09855bae_a8eb6b7f","line":288,"range":{"start_line":288,"start_character":40,"end_line":288,"end_character":49},"updated":"2021-08-07 17:05:34.000000000","message":"share groups","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            type\u003dint,"},{"line_number":286,"context_line":"            default\u003dNone,"},{"line_number":287,"context_line":"            action\u003dparseractions.NonNegativeAction,"},{"line_number":288,"context_line":"            help\u003d_(\"Limit the number of snapshots returned\")"},{"line_number":289,"context_line":"        )"},{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--marker\","}],"source_content_type":"text/x-python","patch_set":18,"id":"8a273ca2_02fc5f35","line":288,"range":{"start_line":288,"start_character":40,"end_line":288,"end_character":49},"in_reply_to":"09855bae_a8eb6b7f","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        )"},{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--marker\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003csnapshot\u003e\","},{"line_number":293,"context_line":"            help\u003d_(\"The last share ID of the previous page\")"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":18,"id":"dbee80ce_21a82c52","line":292,"range":{"start_line":292,"start_character":22,"end_line":292,"end_character":30},"updated":"2021-08-07 17:05:34.000000000","message":"marker","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        )"},{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--marker\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003csnapshot\u003e\","},{"line_number":293,"context_line":"            help\u003d_(\"The last share ID of the previous page\")"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":18,"id":"692e2e91_c099e5f1","line":292,"range":{"start_line":292,"start_character":22,"end_line":292,"end_character":30},"in_reply_to":"dbee80ce_21a82c52","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--marker\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003csnapshot\u003e\","},{"line_number":293,"context_line":"            help\u003d_(\"The last share ID of the previous page\")"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        parser.add_argument("},{"line_number":296,"context_line":"            \u0027--sort\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"c6c06a70_ba79a028","line":293,"range":{"start_line":293,"start_character":29,"end_line":293,"end_character":34},"updated":"2021-08-07 17:05:34.000000000","message":"share group","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":290,"context_line":"        parser.add_argument("},{"line_number":291,"context_line":"            \"--marker\","},{"line_number":292,"context_line":"            metavar\u003d\"\u003csnapshot\u003e\","},{"line_number":293,"context_line":"            help\u003d_(\"The last share ID of the previous page\")"},{"line_number":294,"context_line":"        )"},{"line_number":295,"context_line":"        parser.add_argument("},{"line_number":296,"context_line":"            \u0027--sort\u0027,"}],"source_content_type":"text/x-python","patch_set":18,"id":"dcd063d7_8a8c7768","line":293,"range":{"start_line":293,"start_character":29,"end_line":293,"end_character":34},"in_reply_to":"c6c06a70_ba79a028","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":378,"context_line":"                \" is only available with manila API version \u003e\u003d 2.36\")"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        if parsed_args.all_projects:"},{"line_number":381,"context_line":"            columns.append(\u0027Project ID\u0027)"},{"line_number":382,"context_line":"        share_groups \u003d share_client.share_groups.list(search_opts\u003dsearch_opts)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        columns \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"ab3ed31f_98d79c44","line":381,"updated":"2021-08-07 17:05:34.000000000","message":"You are referencing columns before assignment here and you\u0027ll have to append \u0027project_id\u0027 not \u0027Project ID\u0027.","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":378,"context_line":"                \" is only available with manila API version \u003e\u003d 2.36\")"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        if parsed_args.all_projects:"},{"line_number":381,"context_line":"            columns.append(\u0027Project ID\u0027)"},{"line_number":382,"context_line":"        share_groups \u003d share_client.share_groups.list(search_opts\u003dsearch_opts)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        columns \u003d ["}],"source_content_type":"text/x-python","patch_set":18,"id":"8bb06fcb_646d7792","line":381,"in_reply_to":"ab3ed31f_98d79c44","updated":"2021-08-09 08:06:51.000000000","message":"Ack","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":414,"context_line":"        share_group \u003d osc_utils.find_resource("},{"line_number":415,"context_line":"            share_client.share_groups,"},{"line_number":416,"context_line":"            parsed_args.share_group)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        return self.dict2columns(share_group._info)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"3ca5f712_a2eb980e","line":417,"updated":"2021-08-07 17:05:34.000000000","message":"Please remove \u0027links\u0027 here as well","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        share_group \u003d osc_utils.find_resource("},{"line_number":415,"context_line":"            share_client.share_groups,"},{"line_number":416,"context_line":"            parsed_args.share_group)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        return self.dict2columns(share_group._info)"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"4554ca38_a52bcece","line":417,"in_reply_to":"3ca5f712_a2eb980e","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":472,"context_line":"                    \"Failed to set status \u0027%(status)s\u0027: %(exception)s\"),"},{"line_number":473,"context_line":"                    {\u0027status\u0027: parsed_args.status, \u0027exception\u0027: e})"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        if not parsed_args.status:"},{"line_number":476,"context_line":"            raise exceptions.CommandError(_("},{"line_number":477,"context_line":"                \"Nothing to set. Please define \""},{"line_number":478,"context_line":"                \"\u0027--status\u0027.\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"ab9f9861_bfb4e128","line":475,"updated":"2021-08-07 17:05:34.000000000","message":"\u0027--status\u0027 is only one of the options to set and it\u0027s not mandatory so we shouldn\u0027t throw an error if it\u0027s not defined.","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                    \"Failed to set status \u0027%(status)s\u0027: %(exception)s\"),"},{"line_number":473,"context_line":"                    {\u0027status\u0027: parsed_args.status, \u0027exception\u0027: e})"},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"        if not parsed_args.status:"},{"line_number":476,"context_line":"            raise exceptions.CommandError(_("},{"line_number":477,"context_line":"                \"Nothing to set. Please define \""},{"line_number":478,"context_line":"                \"\u0027--status\u0027.\"))"}],"source_content_type":"text/x-python","patch_set":18,"id":"449be5ee_35adba09","line":475,"in_reply_to":"ab9f9861_bfb4e128","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":479,"context_line":"        if result \u003e 0:"},{"line_number":480,"context_line":"            raise exceptions.CommandError(_(\"One or more of the \""},{"line_number":481,"context_line":"                                          \"set operations failed\"))"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"class UnsetShareGroup(command.Command):"},{"line_number":485,"context_line":"    \"\"\"Unset a share group property.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"5c2d622b_bc8dcb20","line":482,"updated":"2021-08-07 17:05:34.000000000","message":"What about updating the name or description? Looks like we are missing that logic.","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":479,"context_line":"        if result \u003e 0:"},{"line_number":480,"context_line":"            raise exceptions.CommandError(_(\"One or more of the \""},{"line_number":481,"context_line":"                                          \"set operations failed\"))"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"class UnsetShareGroup(command.Command):"},{"line_number":485,"context_line":"    \"\"\"Unset a share group property.\"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"5dfedeec_e4f133da","line":482,"in_reply_to":"5c2d622b_bc8dcb20","updated":"2021-08-09 08:06:51.000000000","message":"Ack","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        kwargs \u003d {}"},{"line_number":516,"context_line":"        if parsed_args.name:"},{"line_number":517,"context_line":"            kwargs[\u0027display_name\u0027] \u003d None"},{"line_number":518,"context_line":"        if parsed_args.description:"},{"line_number":519,"context_line":"            kwargs[\u0027display_description\u0027] \u003d None"},{"line_number":520,"context_line":"        if kwargs:"}],"source_content_type":"text/x-python","patch_set":18,"id":"33d21d0b_885ce141","line":517,"range":{"start_line":517,"start_character":20,"end_line":517,"end_character":32},"updated":"2021-08-07 17:05:34.000000000","message":"name","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        kwargs \u003d {}"},{"line_number":516,"context_line":"        if parsed_args.name:"},{"line_number":517,"context_line":"            kwargs[\u0027display_name\u0027] \u003d None"},{"line_number":518,"context_line":"        if parsed_args.description:"},{"line_number":519,"context_line":"            kwargs[\u0027display_description\u0027] \u003d None"},{"line_number":520,"context_line":"        if kwargs:"}],"source_content_type":"text/x-python","patch_set":18,"id":"6bc31218_633f4e73","line":517,"range":{"start_line":517,"start_character":20,"end_line":517,"end_character":32},"in_reply_to":"33d21d0b_885ce141","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c737b98a3d3af0538fc577a669a75a0b78a6598f","unresolved":true,"context_lines":[{"line_number":516,"context_line":"        if parsed_args.name:"},{"line_number":517,"context_line":"            kwargs[\u0027display_name\u0027] \u003d None"},{"line_number":518,"context_line":"        if parsed_args.description:"},{"line_number":519,"context_line":"            kwargs[\u0027display_description\u0027] \u003d None"},{"line_number":520,"context_line":"        if kwargs:"},{"line_number":521,"context_line":"            try:"},{"line_number":522,"context_line":"                share_client.share_groups.update("}],"source_content_type":"text/x-python","patch_set":18,"id":"9bced5c2_7e60a0ee","line":519,"range":{"start_line":519,"start_character":20,"end_line":519,"end_character":39},"updated":"2021-08-07 17:05:34.000000000","message":"description","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"d600d555ed109774aafb06b26e8da5fad477c00a","unresolved":false,"context_lines":[{"line_number":516,"context_line":"        if parsed_args.name:"},{"line_number":517,"context_line":"            kwargs[\u0027display_name\u0027] \u003d None"},{"line_number":518,"context_line":"        if parsed_args.description:"},{"line_number":519,"context_line":"            kwargs[\u0027display_description\u0027] \u003d None"},{"line_number":520,"context_line":"        if kwargs:"},{"line_number":521,"context_line":"            try:"},{"line_number":522,"context_line":"                share_client.share_groups.update("}],"source_content_type":"text/x-python","patch_set":18,"id":"b51cc315_c3453faf","line":519,"range":{"start_line":519,"start_character":20,"end_line":519,"end_character":39},"in_reply_to":"9bced5c2_7e60a0ee","updated":"2021-08-09 08:06:51.000000000","message":"Done","commit_id":"0a46cd9802391042c5a04d19f34a877a32b74d65"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                share_group.id)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":143,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        return self.dict2columns(printable_share_group)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"d70217d8_b6862f69","line":143,"updated":"2021-08-10 06:18:20.000000000","message":"Let\u0027s also edit the \u0027share_types\u0027 list output here as we do in the manila command, here\u0027s an example: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L271","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"bb44557a3dcc73c4c00b4ae7bc7ae7f1b52efcc1","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                share_group.id)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":143,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        return self.dict2columns(printable_share_group)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1465a4c9_704483dc","line":143,"in_reply_to":"d70217d8_b6862f69","updated":"2021-08-11 08:06:25.000000000","message":"Thanks! I followed this and made some changes in both create and show share group but facing a new failure which is linked with this change.","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":381,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.36\"):"},{"line_number":382,"context_line":"            search_opts[\u0027name~\u0027] \u003d getattr(parsed_args, \u0027name~\u0027)"},{"line_number":383,"context_line":"            search_opts[\u0027description~\u0027] \u003d getattr(parsed_args, \u0027description~\u0027)"},{"line_number":384,"context_line":"            search_opts[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":385,"context_line":"        elif (parsed_args.description or getattr(parsed_args, \u0027name~\u0027) or"},{"line_number":386,"context_line":"              getattr(parsed_args, \u0027description~\u0027)):"},{"line_number":387,"context_line":"            raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":21,"id":"018a5d15_b1e82b9e","line":384,"updated":"2021-08-10 06:18:20.000000000","message":"these 3 options are not working at the moment, you fetch the share groups list on line 379, so these will never be added to the call. Please move things around so we can use these options too :)","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"bb44557a3dcc73c4c00b4ae7bc7ae7f1b52efcc1","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.36\"):"},{"line_number":382,"context_line":"            search_opts[\u0027name~\u0027] \u003d getattr(parsed_args, \u0027name~\u0027)"},{"line_number":383,"context_line":"            search_opts[\u0027description~\u0027] \u003d getattr(parsed_args, \u0027description~\u0027)"},{"line_number":384,"context_line":"            search_opts[\u0027description\u0027] \u003d parsed_args.description"},{"line_number":385,"context_line":"        elif (parsed_args.description or getattr(parsed_args, \u0027name~\u0027) or"},{"line_number":386,"context_line":"              getattr(parsed_args, \u0027description~\u0027)):"},{"line_number":387,"context_line":"            raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":21,"id":"cbe15309_dae7884f","line":384,"in_reply_to":"018a5d15_b1e82b9e","updated":"2021-08-11 08:06:25.000000000","message":"Ack","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":416,"context_line":"            parsed_args.share_group)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":419,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return self.dict2columns(printable_share_group)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9968f343_811cc39f","line":419,"updated":"2021-08-10 06:18:20.000000000","message":"same comment here as for the create command, let\u0027s edit the output for \u0027share_types\u0027 list.","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"bb44557a3dcc73c4c00b4ae7bc7ae7f1b52efcc1","unresolved":false,"context_lines":[{"line_number":416,"context_line":"            parsed_args.share_group)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":419,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        return self.dict2columns(printable_share_group)"},{"line_number":422,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"e4f714d0_d82cb6a7","line":419,"in_reply_to":"9968f343_811cc39f","updated":"2021-08-11 08:06:25.000000000","message":"Ack","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"1dac6f6e45b32cc756ffc92a4d32af7d099f48ee","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    _description \u003d _("},{"line_number":29,"context_line":"        \"Create new share group\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateShareGroup\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"},{"line_number":34,"context_line":"        parser \u003d super(CreateShareGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":28,"id":"9a455de3_90f3fbca","line":31,"updated":"2021-08-27 06:34:24.000000000","message":"Looks like this is not used so we can drop the log definition here.","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3ab1a4f46901c1a584231c258c35f56d6dc21936","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    _description \u003d _("},{"line_number":29,"context_line":"        \"Create new share group\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    log \u003d logging.getLogger(__name__ + \".CreateShareGroup\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"},{"line_number":34,"context_line":"        parser \u003d super(CreateShareGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":28,"id":"fbbc443a_58727ad8","line":31,"in_reply_to":"9a455de3_90f3fbca","updated":"2021-08-31 20:05:34.000000000","message":"Done","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"1dac6f6e45b32cc756ffc92a4d32af7d099f48ee","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":143,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if printable_share_group.get(\u0027share_types\u0027):"},{"line_number":146,"context_line":"            printable_share_group[\u0027share_types\u0027] \u003d ("},{"line_number":147,"context_line":"                \"\\n \".join(printable_share_group[\u0027share_types\u0027])"},{"line_number":148,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"9ae85b11_0e3251c4","line":145,"updated":"2021-08-27 06:34:24.000000000","message":"add one more condition here: if parsed_args.formatter \u003d\u003d \u0027table\u0027:\nBecause we don\u0027t want to do this formatting for share types for json and yaml","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3ab1a4f46901c1a584231c258c35f56d6dc21936","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":143,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if printable_share_group.get(\u0027share_types\u0027):"},{"line_number":146,"context_line":"            printable_share_group[\u0027share_types\u0027] \u003d ("},{"line_number":147,"context_line":"                \"\\n \".join(printable_share_group[\u0027share_types\u0027])"},{"line_number":148,"context_line":"            )"}],"source_content_type":"text/x-python","patch_set":28,"id":"53ab1c15_c1ae49d2","line":145,"in_reply_to":"9ae85b11_0e3251c4","updated":"2021-08-31 20:05:34.000000000","message":"Ack","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"1dac6f6e45b32cc756ffc92a4d32af7d099f48ee","unresolved":true,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if printable_share_group.get(\u0027share_types\u0027):"},{"line_number":146,"context_line":"            printable_share_group[\u0027share_types\u0027] \u003d ("},{"line_number":147,"context_line":"                \"\\n \".join(printable_share_group[\u0027share_types\u0027])"},{"line_number":148,"context_line":"            )"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return self.dict2columns(printable_share_group)"}],"source_content_type":"text/x-python","patch_set":28,"id":"c25b75b9_c5d8a9db","line":147,"range":{"start_line":147,"start_character":19,"end_line":147,"end_character":20},"updated":"2021-08-27 06:34:24.000000000","message":"remove space","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3ab1a4f46901c1a584231c258c35f56d6dc21936","unresolved":false,"context_lines":[{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        if printable_share_group.get(\u0027share_types\u0027):"},{"line_number":146,"context_line":"            printable_share_group[\u0027share_types\u0027] \u003d ("},{"line_number":147,"context_line":"                \"\\n \".join(printable_share_group[\u0027share_types\u0027])"},{"line_number":148,"context_line":"            )"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        return self.dict2columns(printable_share_group)"}],"source_content_type":"text/x-python","patch_set":28,"id":"6e77f586_95777810","line":147,"range":{"start_line":147,"start_character":19,"end_line":147,"end_character":20},"in_reply_to":"c25b75b9_c5d8a9db","updated":"2021-08-31 20:05:34.000000000","message":"Done","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"1dac6f6e45b32cc756ffc92a4d32af7d099f48ee","unresolved":true,"context_lines":[{"line_number":393,"context_line":"            columns.append(\u0027project_id\u0027)"},{"line_number":394,"context_line":"        share_groups \u003d share_client.share_groups.list(search_opts\u003dsearch_opts)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        column_headers \u003d utils.format_column_headers(columns)"},{"line_number":397,"context_line":"        data \u003d (osc_utils.get_dict_properties("},{"line_number":398,"context_line":"            share_group._info, columns) for share_group in share_groups)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"bc3bcd1b_53a86e77","line":396,"updated":"2021-08-27 06:34:24.000000000","message":"We can actually have the columns capitalised straight away and we can drop this extra step, because the get_dict_properties function will handle all the formatting nicely, see: https://github.com/openstack/osc-lib/blob/master/osc_lib/utils/__init__.py#L420","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3ab1a4f46901c1a584231c258c35f56d6dc21936","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            columns.append(\u0027project_id\u0027)"},{"line_number":394,"context_line":"        share_groups \u003d share_client.share_groups.list(search_opts\u003dsearch_opts)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        column_headers \u003d utils.format_column_headers(columns)"},{"line_number":397,"context_line":"        data \u003d (osc_utils.get_dict_properties("},{"line_number":398,"context_line":"            share_group._info, columns) for share_group in share_groups)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"0349157d_ef09c437","line":396,"in_reply_to":"bc3bcd1b_53a86e77","updated":"2021-08-31 20:05:34.000000000","message":"Done","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"1dac6f6e45b32cc756ffc92a4d32af7d099f48ee","unresolved":true,"context_lines":[{"line_number":423,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":424,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if printable_share_group.get(\u0027share_types\u0027):"},{"line_number":427,"context_line":"            printable_share_group[\u0027share_types\u0027] \u003d \"\\n\".join("},{"line_number":428,"context_line":"                printable_share_group[\u0027share_types\u0027])"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"0ad6f2b7_a7a3eae4","line":426,"updated":"2021-08-27 06:34:24.000000000","message":"Add the additional condition here too: if parsed_args.formatter \u003d\u003d \u0027table\u0027:","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3ab1a4f46901c1a584231c258c35f56d6dc21936","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        printable_share_group \u003d share_group._info"},{"line_number":424,"context_line":"        printable_share_group.pop(\u0027links\u0027, None)"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        if printable_share_group.get(\u0027share_types\u0027):"},{"line_number":427,"context_line":"            printable_share_group[\u0027share_types\u0027] \u003d \"\\n\".join("},{"line_number":428,"context_line":"                printable_share_group[\u0027share_types\u0027])"},{"line_number":429,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"3b4c18d5_7dfd33f3","line":426,"in_reply_to":"0ad6f2b7_a7a3eae4","updated":"2021-08-31 20:05:34.000000000","message":"Ack","commit_id":"8ab2f1157a34364b88d03a7cbc30d6e5e561927b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"def68179f12002449b207d8f28029d7501b2f732","unresolved":true,"context_lines":[{"line_number":219,"context_line":"            \"--all-projects\","},{"line_number":220,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":221,"context_line":"            default\u003dFalse,"},{"line_number":222,"context_line":"            help\u003d_(\"Display snapshots from all projects (Admin only).\")"},{"line_number":223,"context_line":"        )"},{"line_number":224,"context_line":"        parser.add_argument("},{"line_number":225,"context_line":"            \"--name\","}],"source_content_type":"text/x-python","patch_set":32,"id":"45589bf6_90eccc3e","line":222,"range":{"start_line":222,"start_character":28,"end_line":222,"end_character":37},"updated":"2021-09-02 20:32:16.000000000","message":"share groups","commit_id":"7c8aa8efd11de32927eed31df3fb153c351bb6be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"def68179f12002449b207d8f28029d7501b2f732","unresolved":true,"context_lines":[{"line_number":241,"context_line":"            help\u003d_(\"Filter results by status.\")"},{"line_number":242,"context_line":"        )"},{"line_number":243,"context_line":"        parser.add_argument("},{"line_number":244,"context_line":"            \"--share-server-id\","},{"line_number":245,"context_line":"            metavar\u003d\"\u003cshare-server-id\u003e\","},{"line_number":246,"context_line":"            default\u003dNone,"},{"line_number":247,"context_line":"            help\u003d_(\"Filter results by share server ID.\")"}],"source_content_type":"text/x-python","patch_set":32,"id":"3e668793_7a321a00","line":244,"range":{"start_line":244,"start_character":15,"end_line":244,"end_character":30},"updated":"2021-09-02 20:32:16.000000000","message":"share-server","commit_id":"7c8aa8efd11de32927eed31df3fb153c351bb6be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"def68179f12002449b207d8f28029d7501b2f732","unresolved":true,"context_lines":[{"line_number":276,"context_line":"                   \"ID. \")"},{"line_number":277,"context_line":"        )"},{"line_number":278,"context_line":"        parser.add_argument("},{"line_number":279,"context_line":"            \"--project-id\","},{"line_number":280,"context_line":"            metavar\u003d\"\u003cproject-id\u003e\","},{"line_number":281,"context_line":"            default\u003dNone,"},{"line_number":282,"context_line":"            help\u003d_(\"Filter results by project ID. Useful with \""}],"source_content_type":"text/x-python","patch_set":32,"id":"0fddf257_e5ff9e6d","line":279,"range":{"start_line":279,"start_character":15,"end_line":279,"end_character":25},"updated":"2021-09-02 20:32:16.000000000","message":"project","commit_id":"7c8aa8efd11de32927eed31df3fb153c351bb6be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"def68179f12002449b207d8f28029d7501b2f732","unresolved":true,"context_lines":[{"line_number":279,"context_line":"            \"--project-id\","},{"line_number":280,"context_line":"            metavar\u003d\"\u003cproject-id\u003e\","},{"line_number":281,"context_line":"            default\u003dNone,"},{"line_number":282,"context_line":"            help\u003d_(\"Filter results by project ID. Useful with \""},{"line_number":283,"context_line":"                   \"set key \u0027--all-projects\u0027. \")"},{"line_number":284,"context_line":"        )"},{"line_number":285,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":32,"id":"4fff4673_93376fce","line":282,"range":{"start_line":282,"start_character":46,"end_line":282,"end_character":48},"updated":"2021-09-02 20:32:16.000000000","message":"name or ID","commit_id":"7c8aa8efd11de32927eed31df3fb153c351bb6be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"def68179f12002449b207d8f28029d7501b2f732","unresolved":true,"context_lines":[{"line_number":316,"context_line":"            metavar\u003d\"\u003cdescription~\u003e\","},{"line_number":317,"context_line":"            default\u003dNone,"},{"line_number":318,"context_line":"            help\u003d_(\"Filter results matching a share group \""},{"line_number":319,"context_line":"                   \"name pattern. Available only for \""},{"line_number":320,"context_line":"                   \"microversion \u003e\u003d 2.36. \")"},{"line_number":321,"context_line":"        )"},{"line_number":322,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":32,"id":"99535713_9295aecb","line":319,"range":{"start_line":319,"start_character":20,"end_line":319,"end_character":24},"updated":"2021-09-02 20:32:16.000000000","message":"description","commit_id":"7c8aa8efd11de32927eed31df3fb153c351bb6be"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"def68179f12002449b207d8f28029d7501b2f732","unresolved":true,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"class ShowShareGroup(command.ShowOne):"},{"line_number":401,"context_line":"    \"\"\"Show share groups.\"\"\""},{"line_number":402,"context_line":"    _description \u003d _(\"Show details about a share groups\")"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def get_parser(self, prog_name):"},{"line_number":405,"context_line":"        parser \u003d super(ShowShareGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":32,"id":"e27b563e_b7bc95b5","line":402,"range":{"start_line":402,"start_character":49,"end_line":402,"end_character":55},"updated":"2021-09-02 20:32:16.000000000","message":"nit: group","commit_id":"7c8aa8efd11de32927eed31df3fb153c351bb6be"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":668,"context_line":"        attrs \u003d attrs or {}"},{"line_number":669,"context_line":"        methods \u003d methods or {}"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        share_group \u003d {"},{"line_number":672,"context_line":"            \u0027availability_zone\u0027: None,"},{"line_number":673,"context_line":"            \u0027name\u0027: None,"},{"line_number":674,"context_line":"            \u0027cast_rules_to_readonly\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e363d60_5984204a","line":671,"updated":"2021-07-26 17:11:27.000000000","message":"double check what attributes should be here, I believe `replica_state` and a few more are not supposed to be here. Also check what values you are adding, the `id` should not start with \"replica-id\".\nYou can use this as a reference of what to include (minus the \"links\"): https://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dcreate-share-group-detail#id582","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":668,"context_line":"        attrs \u003d attrs or {}"},{"line_number":669,"context_line":"        methods \u003d methods or {}"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        share_group \u003d {"},{"line_number":672,"context_line":"            \u0027availability_zone\u0027: None,"},{"line_number":673,"context_line":"            \u0027name\u0027: None,"},{"line_number":674,"context_line":"            \u0027cast_rules_to_readonly\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"25eddeda_d3deb835","line":671,"in_reply_to":"8e363d60_5984204a","updated":"2021-07-28 06:42:48.000000000","message":"Ack! Thanks, I was looking for this link :)","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"}],"manilaclient/tests/unit/osc/v2/test_share_groups.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestShareGroup, self).setUp()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.shares"},{"line_number":26,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.share_groups"},{"line_number":29,"context_line":"        self.shares_mock.reset_mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5c591583_31a201ca","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":37},"updated":"2021-07-26 17:11:27.000000000","message":"I believe you don\u0027t need this bit here, at least not yet, we don\u0027t need to create fake shares for testing \"share group create\" command.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def setUp(self):"},{"line_number":23,"context_line":"        super(TestShareGroup, self).setUp()"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.shares"},{"line_number":26,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.share_groups"},{"line_number":29,"context_line":"        self.shares_mock.reset_mock()"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a67277c_d02654da","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":37},"in_reply_to":"5c591583_31a201ca","updated":"2021-07-28 06:42:48.000000000","message":"Ack","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":25,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.shares"},{"line_number":26,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.share_groups"},{"line_number":29,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ee313e47_948434ea","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":24},"updated":"2021-07-26 17:11:27.000000000","message":"rename this to `groups_mock` or `share_groups_mock` and update the references to it.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.shares"},{"line_number":26,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.share_groups"},{"line_number":29,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"24cd30b6_2f1f46cb","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":24},"in_reply_to":"ee313e47_948434ea","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(TestShareGroupCreate, self).setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.share \u003d manila_fakes.FakeShare.create_one_share()"},{"line_number":38,"context_line":"        self.shares_mock.get.return_value \u003d self.share"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.shares_mock.get.return_value \u003d self.share"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.share_group \u003d ("},{"line_number":43,"context_line":"            manila_fakes.FakeShareGroup.create_one_share_group())"}],"source_content_type":"text/x-python","patch_set":4,"id":"fe53ac81_26fe1da9","line":40,"range":{"start_line":37,"start_character":8,"end_line":40,"end_character":54},"updated":"2021-07-26 17:11:27.000000000","message":"No need to create shares here.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(TestShareGroupCreate, self).setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.share \u003d manila_fakes.FakeShare.create_one_share()"},{"line_number":38,"context_line":"        self.shares_mock.get.return_value \u003d self.share"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.shares_mock.get.return_value \u003d self.share"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.share_group \u003d ("},{"line_number":43,"context_line":"            manila_fakes.FakeShareGroup.create_one_share_group())"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ab07ef2_ca35ce62","line":40,"range":{"start_line":37,"start_character":8,"end_line":40,"end_character":54},"in_reply_to":"fe53ac81_26fe1da9","updated":"2021-07-28 06:42:48.000000000","message":"Ack! I thought for every share group, snapshot, type etc we need to first create share. I\u0027ll keep this in mind for now.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        self.data \u003d tuple(self.share_group._info.values())"},{"line_number":49,"context_line":"        self.columns \u003d tuple(self.share_group._info.keys())"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_share_group_create_missing_args(self):"},{"line_number":52,"context_line":"        arglist \u003d []"},{"line_number":53,"context_line":"        verifylist \u003d []"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d221fb87_cd869a14","line":51,"updated":"2021-07-26 17:11:27.000000000","message":"So the \"openstack share group create\" command doesn\u0027t have any mandatory parameters so we can\u0027t test if something that is required is missing. You can drop this test :)","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.data \u003d tuple(self.share_group._info.values())"},{"line_number":49,"context_line":"        self.columns \u003d tuple(self.share_group._info.keys())"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_share_group_create_missing_args(self):"},{"line_number":52,"context_line":"        arglist \u003d []"},{"line_number":53,"context_line":"        verifylist \u003d []"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"be47db1b_059f5599","line":51,"in_reply_to":"d221fb87_cd869a14","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":55,"context_line":"        self.assertRaises(osc_utils.ParserException,"},{"line_number":56,"context_line":"                          self.check_parser, self.cmd, arglist, verifylist)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_share_group_create_required_args(self):"},{"line_number":59,"context_line":"        arglist \u003d ["},{"line_number":60,"context_line":"            self.share.id"},{"line_number":61,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7c6ff26a_79cc1e27","line":58,"updated":"2021-07-26 17:11:27.000000000","message":"since there are no required args we could make this test without any arguments and rename it accordingly, for example ending with \"_no_args\" or something like that.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        self.assertRaises(osc_utils.ParserException,"},{"line_number":56,"context_line":"                          self.check_parser, self.cmd, arglist, verifylist)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_share_group_create_required_args(self):"},{"line_number":59,"context_line":"        arglist \u003d ["},{"line_number":60,"context_line":"            self.share.id"},{"line_number":61,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"8976c4e5_b50c6375","line":58,"in_reply_to":"7c6ff26a_79cc1e27","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_share_group_create_required_args(self):"},{"line_number":59,"context_line":"        arglist \u003d ["},{"line_number":60,"context_line":"            self.share.id"},{"line_number":61,"context_line":"        ]"},{"line_number":62,"context_line":"        verifylist \u003d ["},{"line_number":63,"context_line":"            (\u0027share\u0027, self.share.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"b43ac0e7_5ce9be50","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":25},"updated":"2021-07-26 17:11:27.000000000","message":"just create an empty `arglist`","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_share_group_create_required_args(self):"},{"line_number":59,"context_line":"        arglist \u003d ["},{"line_number":60,"context_line":"            self.share.id"},{"line_number":61,"context_line":"        ]"},{"line_number":62,"context_line":"        verifylist \u003d ["},{"line_number":63,"context_line":"            (\u0027share\u0027, self.share.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"06759f1f_a3c387b9","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":25},"in_reply_to":"b43ac0e7_5ce9be50","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            self.share.id"},{"line_number":61,"context_line":"        ]"},{"line_number":62,"context_line":"        verifylist \u003d ["},{"line_number":63,"context_line":"            (\u0027share\u0027, self.share.id)"},{"line_number":64,"context_line":"        ]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":4,"id":"00be499b_1e357ff0","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":36},"updated":"2021-07-26 17:11:27.000000000","message":"also an empty `verifylist`","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            self.share.id"},{"line_number":61,"context_line":"        ]"},{"line_number":62,"context_line":"        verifylist \u003d ["},{"line_number":63,"context_line":"            (\u0027share\u0027, self.share.id)"},{"line_number":64,"context_line":"        ]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7313b96a_4b516bcb","line":63,"range":{"start_line":63,"start_character":12,"end_line":63,"end_character":36},"in_reply_to":"00be499b_1e357ff0","updated":"2021-07-28 06:42:48.000000000","message":"Done","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.groups_mock.create.assert_called_with("},{"line_number":71,"context_line":"            share\u003dself.share,"},{"line_number":72,"context_line":"            name\u003dNone,"},{"line_number":73,"context_line":"            description\u003dNone,"},{"line_number":74,"context_line":"            share_type\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3beea124_bddf5467","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":29},"updated":"2021-07-26 17:11:27.000000000","message":"there is no `share` option for this command","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        self.groups_mock.create.assert_called_with("},{"line_number":71,"context_line":"            share\u003dself.share,"},{"line_number":72,"context_line":"            name\u003dNone,"},{"line_number":73,"context_line":"            description\u003dNone,"},{"line_number":74,"context_line":"            share_type\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"06e94784_a059c093","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":29},"in_reply_to":"3beea124_bddf5467","updated":"2021-07-28 06:42:48.000000000","message":"Ack","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            share\u003dself.share,"},{"line_number":72,"context_line":"            name\u003dNone,"},{"line_number":73,"context_line":"            description\u003dNone,"},{"line_number":74,"context_line":"            share_type\u003dNone,"},{"line_number":75,"context_line":"            share_group_type\u003dNone,"},{"line_number":76,"context_line":"            share_network\u003dNone,"},{"line_number":77,"context_line":"            source_share_group_snapshot\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"fdc0a32f_5e8106d2","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":27},"updated":"2021-07-26 17:11:27.000000000","message":"share_types\u003d[],","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            share\u003dself.share,"},{"line_number":72,"context_line":"            name\u003dNone,"},{"line_number":73,"context_line":"            description\u003dNone,"},{"line_number":74,"context_line":"            share_type\u003dNone,"},{"line_number":75,"context_line":"            share_group_type\u003dNone,"},{"line_number":76,"context_line":"            share_network\u003dNone,"},{"line_number":77,"context_line":"            source_share_group_snapshot\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0a3e8deb_47809fa1","line":74,"range":{"start_line":74,"start_character":12,"end_line":74,"end_character":27},"in_reply_to":"fdc0a32f_5e8106d2","updated":"2021-07-28 06:42:48.000000000","message":"Ack","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"008f38aff9b1e4a244ad2d4b3995b36227a72979","unresolved":true,"context_lines":[{"line_number":81,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":82,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_share_group_create(self):"},{"line_number":85,"context_line":"        arglist \u003d ["},{"line_number":86,"context_line":"            self.share.id,"},{"line_number":87,"context_line":"            \u0027--name\u0027, self.share_group.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"62c01232_892f535f","line":84,"updated":"2021-07-26 17:11:27.000000000","message":"So, I suggest you split this test into 2 or 3 separate tests. It\u0027s a lot of arguments to test at once and many things failing at the same time here.\nFor example, start by writing a test that provides just the \"--name\" and \"--description\" arguments and try to get Zuul happy before adding more options.","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"7119481c69d4c7749f060d0dcbf57678aa710961","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":82,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_share_group_create(self):"},{"line_number":85,"context_line":"        arglist \u003d ["},{"line_number":86,"context_line":"            self.share.id,"},{"line_number":87,"context_line":"            \u0027--name\u0027, self.share_group.name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"abf58595_8d242518","line":84,"in_reply_to":"62c01232_892f535f","updated":"2021-07-28 06:42:48.000000000","message":"Ack","commit_id":"a88bab6dc117793cf819c7dc6d42d053946a04f9"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d315e7acf8c740b687ba220fa70c4408cc46bee8","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":12,"id":"53f21cf8_ffd70b01","line":176,"updated":"2021-08-02 07:49:02.000000000","message":"Planning to add tests for the rest of the operations for share group in this patch set? I\u0027m referring to delete, list, show, set and unset operations","commit_id":"f93ee66a39679f0b75a3d80382952eb86b4c7aaf"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"5b87f149a4b926e3a66989adf62a07a235cb8259","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"2fbde0e8_c3efb3c1","line":176,"in_reply_to":"53f21cf8_ffd70b01","updated":"2021-08-02 09:42:23.000000000","message":"Yes, I\u0027m working on it!","commit_id":"f93ee66a39679f0b75a3d80382952eb86b4c7aaf"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":189,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    # TODO(archanaserver): Add test cases for share-group-type,"},{"line_number":192,"context_line":"    # share-network and source-share-group-share_group when the"},{"line_number":193,"context_line":"    # options have OSC support."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"19308ccc_1d11f535","line":192,"range":{"start_line":192,"start_character":43,"end_line":192,"end_character":54},"updated":"2021-08-10 06:18:20.000000000","message":"snapshot","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a39d843b478957ae359dac5e82cfa585b0f126a9","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    # TODO(archanaserver): Add test cases for share-group-type,"},{"line_number":192,"context_line":"    # share-network and source-share-group-share_group when the"},{"line_number":193,"context_line":"    # options have OSC support."},{"line_number":194,"context_line":""},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"9d236460_1f38cb49","line":192,"range":{"start_line":192,"start_character":43,"end_line":192,"end_character":54},"in_reply_to":"19308ccc_1d11f535","updated":"2021-08-11 06:05:05.000000000","message":"Done","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":240,"context_line":"            force\u003dTrue)"},{"line_number":241,"context_line":"        self.assertIsNone(result)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_share_replica_delete_multiple(self):"},{"line_number":244,"context_line":"        share_groups \u003d ("},{"line_number":245,"context_line":"            manila_fakes.FakeShareGroup.create_share_groups("},{"line_number":246,"context_line":"                count\u003d2))"}],"source_content_type":"text/x-python","patch_set":21,"id":"7491026e_da6c8b6f","line":243,"range":{"start_line":243,"start_character":19,"end_line":243,"end_character":26},"updated":"2021-08-10 06:18:20.000000000","message":"group","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a39d843b478957ae359dac5e82cfa585b0f126a9","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            force\u003dTrue)"},{"line_number":241,"context_line":"        self.assertIsNone(result)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def test_share_replica_delete_multiple(self):"},{"line_number":244,"context_line":"        share_groups \u003d ("},{"line_number":245,"context_line":"            manila_fakes.FakeShareGroup.create_share_groups("},{"line_number":246,"context_line":"                count\u003d2))"}],"source_content_type":"text/x-python","patch_set":21,"id":"84d01596_c06bd8bc","line":243,"range":{"start_line":243,"start_character":19,"end_line":243,"end_character":26},"in_reply_to":"7491026e_da6c8b6f","updated":"2021-08-11 06:05:05.000000000","message":"Done","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":259,"context_line":"                         len(share_groups))"},{"line_number":260,"context_line":"        self.assertIsNone(result)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_share_snapshot_delete_exception(self):"},{"line_number":263,"context_line":"        arglist \u003d ["},{"line_number":264,"context_line":"            self.share_group.id"},{"line_number":265,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":21,"id":"eb569a69_3aaa85bd","line":262,"range":{"start_line":262,"start_character":19,"end_line":262,"end_character":27},"updated":"2021-08-10 06:18:20.000000000","message":"group","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a39d843b478957ae359dac5e82cfa585b0f126a9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"                         len(share_groups))"},{"line_number":260,"context_line":"        self.assertIsNone(result)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_share_snapshot_delete_exception(self):"},{"line_number":263,"context_line":"        arglist \u003d ["},{"line_number":264,"context_line":"            self.share_group.id"},{"line_number":265,"context_line":"        ]"}],"source_content_type":"text/x-python","patch_set":21,"id":"c8edc914_063e9daa","line":262,"range":{"start_line":262,"start_character":19,"end_line":262,"end_character":27},"in_reply_to":"eb569a69_3aaa85bd","updated":"2021-08-11 06:05:05.000000000","message":"Done","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b1db65990a4b006b68d64a3bb2d301cb2063c213","unresolved":true,"context_lines":[{"line_number":295,"context_line":"            self.groups_mock.get.assert_called_with(self.share_group.id)"},{"line_number":296,"context_line":"            self.assertIsNone(result)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_share_replica_delete_wait_exception(self):"},{"line_number":299,"context_line":"        arglist \u003d ["},{"line_number":300,"context_line":"            self.share_group.id,"},{"line_number":301,"context_line":"            \u0027--wait\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"fad792c0_4f8a27ef","line":298,"range":{"start_line":298,"start_character":19,"end_line":298,"end_character":26},"updated":"2021-08-10 06:18:20.000000000","message":"group","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a39d843b478957ae359dac5e82cfa585b0f126a9","unresolved":false,"context_lines":[{"line_number":295,"context_line":"            self.groups_mock.get.assert_called_with(self.share_group.id)"},{"line_number":296,"context_line":"            self.assertIsNone(result)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"    def test_share_replica_delete_wait_exception(self):"},{"line_number":299,"context_line":"        arglist \u003d ["},{"line_number":300,"context_line":"            self.share_group.id,"},{"line_number":301,"context_line":"            \u0027--wait\u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"8f136016_d7f57ffc","line":298,"range":{"start_line":298,"start_character":19,"end_line":298,"end_character":26},"in_reply_to":"fad792c0_4f8a27ef","updated":"2021-08-11 06:05:05.000000000","message":"Done","commit_id":"0d963139e32521834dc626e792e76b2b1f927937"}],"setup.cfg":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":41,"context_line":"    share_show \u003d manilaclient.osc.v2.share:ShowShare"},{"line_number":42,"context_line":"    share_set \u003d manilaclient.osc.v2.share:SetShare"},{"line_number":43,"context_line":"    share_unset \u003d manilaclient.osc.v2.share:UnsetShare"},{"line_number":44,"context_line":"    share_reset_state \u003d manilaclient.osc.v2.share:ResetStateShare"},{"line_number":45,"context_line":"    share_resize \u003d manilaclient.osc.v2.share:ResizeShare"},{"line_number":46,"context_line":"    share_adopt \u003d manilaclient.osc.v2.share:AdoptShare"},{"line_number":47,"context_line":"    share_abandon \u003d manilaclient.osc.v2.share:AbandonShare"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"46b43c87_9fde87fc","line":44,"updated":"2021-07-23 09:10:59.000000000","message":"Again, I am confused about why are we adding this?","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    share_show \u003d manilaclient.osc.v2.share:ShowShare"},{"line_number":42,"context_line":"    share_set \u003d manilaclient.osc.v2.share:SetShare"},{"line_number":43,"context_line":"    share_unset \u003d manilaclient.osc.v2.share:UnsetShare"},{"line_number":44,"context_line":"    share_reset_state \u003d manilaclient.osc.v2.share:ResetStateShare"},{"line_number":45,"context_line":"    share_resize \u003d manilaclient.osc.v2.share:ResizeShare"},{"line_number":46,"context_line":"    share_adopt \u003d manilaclient.osc.v2.share:AdoptShare"},{"line_number":47,"context_line":"    share_abandon \u003d manilaclient.osc.v2.share:AbandonShare"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9f83880c_6a2ff9c0","line":44,"in_reply_to":"46b43c87_9fde87fc","updated":"2021-07-26 07:19:09.000000000","message":"I messed this up a little but what I was thinking is this is another unique command that I need to implement for `share group` commands(like the rest create, delete, list etc). But when I didn\u0027t find any command like `share reset state` in index.rst. So I started implementing it separately.\n\nI wasn\u0027t familiar that here we need to add `--status` flag in the `openstack share group set` command instead of implementing it separately. Now I got it. Thanks Maari. I\u0027m on it!","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df4c0af1aec6fbe626484649f9a516264dbb2bdd","unresolved":true,"context_lines":[{"line_number":96,"context_line":"    share_group_show \u003d manilaclient.osc.v2.share_groups:ShowShareGroup"},{"line_number":97,"context_line":"    share_group_set \u003d manilaclient.osc.v2.share_groups:SetShareGroup"},{"line_number":98,"context_line":"    share_group_unset \u003d manilaclient.osc.v2.share_groups:UnsetShareGroup"},{"line_number":99,"context_line":"    share_group_reset_state \u003d manilaclient.osc.v2.share_groups:ResetStateShareGroup"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[coverage:run]"},{"line_number":102,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"285a989e_175a042f","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":27},"updated":"2021-07-23 09:10:59.000000000","message":"Setting a share group status should be implemented as \u0027--status\u0027 flag in \u0027openstack share group set\u0027 command: https://specs.openstack.org/openstack/manila-specs/specs/release_independent/manila-support-openstackclient.html#share-groups","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"94a42892d5a7e5bae1fd1bfaffa14dffcafbb8e3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    share_group_show \u003d manilaclient.osc.v2.share_groups:ShowShareGroup"},{"line_number":97,"context_line":"    share_group_set \u003d manilaclient.osc.v2.share_groups:SetShareGroup"},{"line_number":98,"context_line":"    share_group_unset \u003d manilaclient.osc.v2.share_groups:UnsetShareGroup"},{"line_number":99,"context_line":"    share_group_reset_state \u003d manilaclient.osc.v2.share_groups:ResetStateShareGroup"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"[coverage:run]"},{"line_number":102,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9e095c8f_0eca9718","line":99,"range":{"start_line":99,"start_character":4,"end_line":99,"end_character":27},"in_reply_to":"285a989e_175a042f","updated":"2021-07-26 07:19:09.000000000","message":"Yes, got it. Thanks. I\u0027m on it :)","commit_id":"85c2cdf936400e3b52a09b50a3c533df5dfe705f"}]}