)]}'
{"manilaclient/v2/shell.py":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3cbdea8e2c40c216a87adef22fe03b41361a3921","unresolved":true,"context_lines":[{"line_number":841,"context_line":"    type\u003dint,"},{"line_number":842,"context_line":"    help\u003d\u0027Share size in GiB.\u0027)"},{"line_number":843,"context_line":"@cliutils.arg("},{"line_number":844,"context_line":"    \u0027--snapshot-id\u0027,"},{"line_number":845,"context_line":"    \u0027--snapshot_id\u0027,"},{"line_number":846,"context_line":"    metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":847,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1116fcea_5de9491f","line":845,"range":{"start_line":844,"start_character":0,"end_line":845,"end_character":20},"updated":"2021-07-23 17:42:42.000000000","message":"hum, looks weird to accept snapshot name in \u0027--snapshot-id\u0027 parameter, no?\nwe could add \u0027--snapshot\u0027 here too, wdyt? maybe drop \u0027snapshot-id\u0027 or maintain both. Need more opinions here.","commit_id":"ed777cb0e040a8d84f85b4e528cd296bf280d31f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d88b11aa2def7285f158c6b909d9794316e4abc9","unresolved":true,"context_lines":[{"line_number":841,"context_line":"    type\u003dint,"},{"line_number":842,"context_line":"    help\u003d\u0027Share size in GiB.\u0027)"},{"line_number":843,"context_line":"@cliutils.arg("},{"line_number":844,"context_line":"    \u0027--snapshot-id\u0027,"},{"line_number":845,"context_line":"    \u0027--snapshot_id\u0027,"},{"line_number":846,"context_line":"    metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":847,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3301bbd2_377956db","line":845,"range":{"start_line":844,"start_character":0,"end_line":845,"end_character":20},"in_reply_to":"1116fcea_5de9491f","updated":"2021-07-23 17:46:57.000000000","message":"Makes sense to me to turn this as --snapshot, if we are to start accepting both snapshot id and snapshot name.\nI think we should have that mentioned in the release note as well...","commit_id":"ed777cb0e040a8d84f85b4e528cd296bf280d31f"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"3cbdea8e2c40c216a87adef22fe03b41361a3921","unresolved":true,"context_lines":[{"line_number":845,"context_line":"    \u0027--snapshot_id\u0027,"},{"line_number":846,"context_line":"    metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":847,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":848,"context_line":"    help\u003d\u0027Optional snapshot ID to create the share from. (Default\u003dNone)\u0027,"},{"line_number":849,"context_line":"    default\u003dNone)"},{"line_number":850,"context_line":"@cliutils.arg("},{"line_number":851,"context_line":"    \u0027--name\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"007f89ac_3de22f1b","line":848,"range":{"start_line":848,"start_character":19,"end_line":848,"end_character":30},"updated":"2021-07-23 17:42:42.000000000","message":"Optional snapshot name or ID ...\u0027","commit_id":"ed777cb0e040a8d84f85b4e528cd296bf280d31f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76673786efce8b9e2482c64817447fe4e12dfcd7","unresolved":true,"context_lines":[{"line_number":841,"context_line":"    type\u003dint,"},{"line_number":842,"context_line":"    help\u003d\u0027Share size in GiB.\u0027)"},{"line_number":843,"context_line":"@cliutils.arg("},{"line_number":844,"context_line":"    \u0027--snapshot\u0027,"},{"line_number":845,"context_line":"    metavar\u003d\u0027\u003csnapshot\u003e\u0027,"},{"line_number":846,"context_line":"    action\u003d\u0027single_alias\u0027,"},{"line_number":847,"context_line":"    help\u003d\"Optional snapshot ID or name to create the share from.\""}],"source_content_type":"text/x-python","patch_set":5,"id":"c1062432_c5c3ce3d","line":844,"range":{"start_line":844,"start_character":16,"end_line":844,"end_character":17},"updated":"2021-07-28 16:01:53.000000000","message":"We\u0027re dropping support for an existing option, so its worth calling this out via an upgrade release note: https://docs.openstack.org/manila/latest/contributor/adding_release_notes.html\n\nHowever, why not just maintain support for both (i.e., add \"snapshot-id\" as well). you have \"single_alias\" action specified below on line 846, which ensures that users only use one option alias when making the request - the \"single_alias\" action has no effect if there are no aliases defined. \n\nIf you decide to keep support for the existing option, no need to call this out via an upgrade release note - it is still worth writing a bug fix release note","commit_id":"4a574b972067eb83dc57462234c75354a30ace0c"}],"releasenotes/notes/bug-1798229-fix-create-share-from-snap-using-name-20ed376532359374.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7d09dd6b55e21022cdd64b4455abeb3279899fda","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the issue in which users were unable to create a share from a"},{"line_number":5,"context_line":"    snapshot, specifing the snapshot\u0027s name. For more details, please refer to"},{"line_number":6,"context_line":"    `launchpad bug 1798229 \u003chttps://bugs.launchpad.net/python-manilaclient/+bug/1798229\u003e`_    "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dfd0b709_8ec4b9c0","line":6,"range":{"start_line":6,"start_character":90,"end_line":6,"end_character":94},"updated":"2021-07-22 22:35:58.000000000","message":"trailing white space..","commit_id":"84ccb03c0748a054a5a23503f12cd58e1cefa19e"}]}