)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85e04d23b2959cb27a7f986c13d1cb62754c3e6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a152265f_d74b7ab1","updated":"2022-02-17 21:41:48.000000000","message":"Thanks for working on this change, Ashley\nI didn\u0027t give it a try yet, but I like the direction it is going... MetadataCapableResource is a smart way to quickly modify resources to start supporting metadata.\nI have more questions though:\n1. What if this change was split into two changes? One for the shares resource and another one for the metadata resource, as it\u0027s being done in Manila?\n2. Could you please add a release note for this?\n3. Is this still a wip? If not, could you please remove the mention from the commit message\u0027s summary line?","commit_id":"cb5324776011392492cedcfa5027d93c0683afe9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d55377dce50f8dfa9a4db14d090f97c73d8dd135","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a0fe6e9b_1b63b306","updated":"2022-03-04 21:03:02.000000000","message":"recheck","commit_id":"c6d873eae9e7c1a1b38dde11530cbf7708a2cb5c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"891c12eed453574b91b54a033bae7c3121279d58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3df1fa0b_dfa09a66","updated":"2022-04-07 16:47:35.000000000","message":"recheck\n\nlogs are gone","commit_id":"f415ebf66e8da2424306b32c06b48df6f77cfa39"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8744a15e22836256a77c4305de134868c90334e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5507be48_b6e77121","updated":"2022-04-21 18:07:34.000000000","message":"recheck depends-on patch changed during test run","commit_id":"84926d34619e9096dc0e3968c35eef5a4755b752"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"065175ac50fa56cc2fa808cd90070a93c30527cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"e6ac6400_cdb2f208","updated":"2022-05-05 18:25:51.000000000","message":"recheck depends-on patch changed during test run","commit_id":"f4f2c7b344e0d2989a4f404ce55e942d98e71f38"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e1bb582e191f7ce34914d5e0306eac1fa5f922b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0642e9e9_22ec5ecd","updated":"2022-08-18 08:23:14.000000000","message":"Thanks Ashley and Goutham! I\u0027ve yet to test it and I am only getting familiarised here but from what I gather so far the metadata support for shares is getting a refactor but for snapshots it is new since 2.72, right? If so, I believe the snapshot commands need microversion checks, added notes to help messages and probably some negative test cases for the checks.","commit_id":"f77197f1769bab0a5e799df7c5f4daee055b2b6b"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ae50d425d6c156ba0453e65ed463393a9daec2d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7f33a890_587bb96e","updated":"2022-08-03 19:48:56.000000000","message":"recheck refreshed depends-on patch","commit_id":"f77197f1769bab0a5e799df7c5f4daee055b2b6b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"896c9e0c9471903d564f8db4f21ad0f5e8999b2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"803d6b6f_175fab8e","updated":"2022-09-01 14:43:29.000000000","message":"As other changes merged, this will need a rebase. Could you please take a look on it? :)","commit_id":"643da639b4831f7b08fb5bc062d2a15668cea315"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"0bd1b7c5_c072728b","updated":"2022-10-04 21:40:43.000000000","message":"Looks good - Have some suggestions inline. Could you please take a look at them?","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"7c208b63_e06fc68e","updated":"2022-10-19 15:19:16.000000000","message":"Thanks Carlos for your reviews!","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"57c1bc8b_6fe1efe7","updated":"2022-11-16 05:29:51.000000000","message":"thanks for your change.","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"94b834b1_2d01f354","updated":"2022-12-15 18:42:52.000000000","message":"Thanks Haixin for your review!","commit_id":"d43694a05744c9e804a2f6be626242082f97e310"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"adf95708c2a566a735c80cfabf58d4659fcc016c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"68ecb61a_6ad9dc95","updated":"2022-12-16 09:03:49.000000000","message":"fyi: manilaclient.tests.functional.test_common.ManilaClientTestCommonReadOnly.test_help are failing due to https://docs.python.org/3.10/whatsnew/3.10.html#argparse","commit_id":"d43694a05744c9e804a2f6be626242082f97e310"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"1f30b509486d5b54edbbd11568ec9ce1903d68c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"d6fc257e_4078757d","in_reply_to":"68ecb61a_6ad9dc95","updated":"2022-12-22 17:03:52.000000000","message":"please rebase to get the fix (https://review.opendev.org/c/openstack/python-manilaclient/+/868128) for that","commit_id":"d43694a05744c9e804a2f6be626242082f97e310"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"44ac42e1c65896dfab605c830f170a588d68183b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"487b18ab_e1114c3b","updated":"2023-01-08 13:57:30.000000000","message":"Thanks Ashley, please, see my comments.","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"899ccebc1822de3ec0daf7b600911ac3ca13cff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"ab930c7f_6fd19971","updated":"2023-01-04 16:21:30.000000000","message":"recheck docs fail","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"28811909fc7874ef4f492e0eaac833d5be5ffca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"f223dfe9_d6d83123","updated":"2023-01-04 17:44:53.000000000","message":"recheck updated tox info","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"250d524d34f9a66257c7749d3dba48f62e21cda9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0cec474d_76fbfc90","updated":"2023-01-13 17:56:11.000000000","message":"Thank you Goutham, Felipe. Apologies for the late reply, please let me know if there\u0027s more I need to change.","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"91971f2cf2c8f56c576acf706edabd95d1ca38fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"830577d5_fd91305d","updated":"2023-02-08 21:36:02.000000000","message":"Thank you for the hard work on this change - Have a couple more of concerns inline. Could you please address these + Goutham\u0027s comments in a follow-up change?","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2044ead91249d30d046e9a63469896f90f75810f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"f7cafd5d_861abf25","updated":"2023-02-04 01:33:13.000000000","message":"Thanks; a few more comments inline. This has been around for long enough now; i\u0027m in favor of merging it and then following up if there are no more comments. This is lacking functional tests, would you please add some in a follow up patch?","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"}],"manilaclient/base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85e04d23b2959cb27a7f986c13d1cb62754c3e6a","unresolved":true,"context_lines":[{"line_number":258,"context_line":"                          for k in self.__dict__.keys()"},{"line_number":259,"context_line":"                          if k[0] !\u003d \u0027_\u0027 and k !\u003d \u0027manager\u0027)"},{"line_number":260,"context_line":"        info \u003d \", \".join(\"%s\u003d%s\" % (k, getattr(self, k)) for k in reprkeys)"},{"line_number":261,"context_line":"        return \"\u003c%s %s\u003e\" % (self.__class__.__name__, info)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    @property"},{"line_number":264,"context_line":"    def human_id(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"48753fb1_de9f1e14","line":261,"range":{"start_line":261,"start_character":15,"end_line":261,"end_character":58},"updated":"2022-02-17 21:41:48.000000000","message":"I think you could use f\u0027{var}\u0027 strings... It\u0027s being done below in the file :)","commit_id":"cb5324776011392492cedcfa5027d93c0683afe9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":true,"context_lines":[{"line_number":370,"context_line":"            by default"},{"line_number":371,"context_line":"        \"\"\""},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        resource \u003d self"},{"line_number":374,"context_line":"        subresource \u003d None"},{"line_number":375,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":376,"context_line":"        if superresource is not None:"},{"line_number":377,"context_line":"            resource \u003d superresource"},{"line_number":378,"context_line":"            subresource \u003d self"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        return self.manager.get_metadata(resource, subresource\u003dsubresource)"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"e65a6eb6_4bdee216","line":378,"range":{"start_line":373,"start_character":8,"end_line":378,"end_character":30},"updated":"2022-10-04 21:40:43.000000000","message":"this code bit is being repeated four times. you could replace this by an internal method, like:\n\n    def _get_subresource_and_resource(self, superresource):\n        resource \u003d self\n        subresource \u003d None\n        superresource \u003d superresource or self.superresource\n        if superresource is not None:\n            resource \u003d superresource\n            subresource \u003d self\n        return resource, subresource\n\nand then call it in the three places like:\nresource, subresource \u003d self._get_subresource_and_resource(\n            superresource)","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[{"line_number":370,"context_line":"            by default"},{"line_number":371,"context_line":"        \"\"\""},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        resource \u003d self"},{"line_number":374,"context_line":"        subresource \u003d None"},{"line_number":375,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":376,"context_line":"        if superresource is not None:"},{"line_number":377,"context_line":"            resource \u003d superresource"},{"line_number":378,"context_line":"            subresource \u003d self"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        return self.manager.get_metadata(resource, subresource\u003dsubresource)"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"059aff4b_da0a4e0a","line":378,"range":{"start_line":373,"start_character":8,"end_line":378,"end_character":30},"in_reply_to":"e65a6eb6_4bdee216","updated":"2022-10-19 15:19:16.000000000","message":"Done","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":true,"context_lines":[{"line_number":394,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":395,"context_line":"        if superresource is not None:"},{"line_number":396,"context_line":"            resource \u003d superresource"},{"line_number":397,"context_line":"            subresource \u003d self"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        return self.manager.set_metadata(resource, metadata,"},{"line_number":400,"context_line":"                                         subresource\u003dsubresource)"}],"source_content_type":"text/x-python","patch_set":20,"id":"faf536ec_5dbe464c","line":397,"updated":"2022-10-04 21:40:43.000000000","message":"please see l373 comment","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[{"line_number":394,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":395,"context_line":"        if superresource is not None:"},{"line_number":396,"context_line":"            resource \u003d superresource"},{"line_number":397,"context_line":"            subresource \u003d self"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        return self.manager.set_metadata(resource, metadata,"},{"line_number":400,"context_line":"                                         subresource\u003dsubresource)"}],"source_content_type":"text/x-python","patch_set":20,"id":"bca1d5a4_aa2d8bad","line":397,"in_reply_to":"faf536ec_5dbe464c","updated":"2022-10-19 15:19:16.000000000","message":"Done","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":true,"context_lines":[{"line_number":408,"context_line":"            locations which do not include a reference to the parent object"},{"line_number":409,"context_line":"            by default"},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        resource \u003d self"},{"line_number":412,"context_line":"        subresource \u003d None"},{"line_number":413,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":414,"context_line":"        if superresource is not None:"}],"source_content_type":"text/x-python","patch_set":20,"id":"0e864d2b_9bd9b63b","line":411,"updated":"2022-10-04 21:40:43.000000000","message":"please see l373 comment","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[{"line_number":408,"context_line":"            locations which do not include a reference to the parent object"},{"line_number":409,"context_line":"            by default"},{"line_number":410,"context_line":"        \"\"\""},{"line_number":411,"context_line":"        resource \u003d self"},{"line_number":412,"context_line":"        subresource \u003d None"},{"line_number":413,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":414,"context_line":"        if superresource is not None:"}],"source_content_type":"text/x-python","patch_set":20,"id":"a3cb0c70_7f224bc7","line":411,"in_reply_to":"0e864d2b_9bd9b63b","updated":"2022-10-19 15:19:16.000000000","message":"Done","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":true,"context_lines":[{"line_number":433,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":434,"context_line":"        if superresource is not None:"},{"line_number":435,"context_line":"            resource \u003d superresource"},{"line_number":436,"context_line":"            subresource \u003d self"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        return self.manager.update_all_metadata(resource,"},{"line_number":439,"context_line":"                                                metadata,"}],"source_content_type":"text/x-python","patch_set":20,"id":"2cadfcab_af9b15c5","line":436,"updated":"2022-10-04 21:40:43.000000000","message":"same","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[{"line_number":433,"context_line":"        superresource \u003d superresource or self.superresource"},{"line_number":434,"context_line":"        if superresource is not None:"},{"line_number":435,"context_line":"            resource \u003d superresource"},{"line_number":436,"context_line":"            subresource \u003d self"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"        return self.manager.update_all_metadata(resource,"},{"line_number":439,"context_line":"                                                metadata,"}],"source_content_type":"text/x-python","patch_set":20,"id":"045d7f6e_7e204cdb","line":436,"in_reply_to":"2cadfcab_af9b15c5","updated":"2022-10-19 15:19:16.000000000","message":"Done","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"}],"manilaclient/osc/v2/share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85e04d23b2959cb27a7f986c13d1cb62754c3e6a","unresolved":true,"context_lines":[{"line_number":456,"context_line":"            \u0027--property\u0027,"},{"line_number":457,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":458,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":459,"context_line":"            help\u003d_(\u0027Filter shares having a given metadata key\u003dvalue property \u0027"},{"line_number":460,"context_line":"                   \u0027(repeat option to filter by multiple properties)\u0027),"},{"line_number":461,"context_line":"        )"},{"line_number":462,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"78caee3f_c0344d17","line":459,"range":{"start_line":459,"start_character":76,"end_line":459,"end_character":77},"updated":"2022-02-17 21:41:48.000000000","message":"Period?","commit_id":"cb5324776011392492cedcfa5027d93c0683afe9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d55377dce50f8dfa9a4db14d090f97c73d8dd135","unresolved":false,"context_lines":[{"line_number":456,"context_line":"            \u0027--property\u0027,"},{"line_number":457,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":458,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":459,"context_line":"            help\u003d_(\u0027Filter shares having a given metadata key\u003dvalue property \u0027"},{"line_number":460,"context_line":"                   \u0027(repeat option to filter by multiple properties)\u0027),"},{"line_number":461,"context_line":"        )"},{"line_number":462,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"4c3a3fee_3c0ebf4b","line":459,"range":{"start_line":459,"start_character":76,"end_line":459,"end_character":77},"in_reply_to":"78caee3f_c0344d17","updated":"2022-03-04 21:03:02.000000000","message":"Done","commit_id":"cb5324776011392492cedcfa5027d93c0683afe9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":69,"context_line":"            default\u003d{},"},{"line_number":70,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":71,"context_line":"            help\u003d_(\"Set a property to this share \""},{"line_number":72,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"1356dc07_001b3693","line":71,"range":{"start_line":71,"start_character":43,"end_line":71,"end_character":48},"updated":"2022-11-16 05:29:51.000000000","message":"snapshot","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":69,"context_line":"            default\u003d{},"},{"line_number":70,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":71,"context_line":"            help\u003d_(\"Set a property to this share \""},{"line_number":72,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"943c6e77_45513b31","line":71,"range":{"start_line":71,"start_character":43,"end_line":71,"end_character":48},"in_reply_to":"1356dc07_001b3693","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":252,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":253,"context_line":"            default\u003d{},"},{"line_number":254,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":255,"context_line":"            help\u003d_(\"Set a property to this share \""},{"line_number":256,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":257,"context_line":"        )"},{"line_number":258,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"056e9bdf_bd5dd7e4","line":255,"range":{"start_line":255,"start_character":43,"end_line":255,"end_character":48},"updated":"2022-11-16 05:29:51.000000000","message":"snapshot","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":252,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":253,"context_line":"            default\u003d{},"},{"line_number":254,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":255,"context_line":"            help\u003d_(\"Set a property to this share \""},{"line_number":256,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":257,"context_line":"        )"},{"line_number":258,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"48e8e408_5ad4b1cd","line":255,"range":{"start_line":255,"start_character":43,"end_line":255,"end_character":48},"in_reply_to":"056e9bdf_bd5dd7e4","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":336,"context_line":"            \u0027--property\u0027,"},{"line_number":337,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":338,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":339,"context_line":"            help\u003d_(\u0027Remove a property from share \u0027"},{"line_number":340,"context_line":"                   \u0027(repeat option to remove multiple properties)\u0027),"},{"line_number":341,"context_line":"        )"},{"line_number":342,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"7c199477_1fd0bd7d","line":339,"range":{"start_line":339,"start_character":43,"end_line":339,"end_character":48},"updated":"2022-11-16 05:29:51.000000000","message":"snapshot","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            \u0027--property\u0027,"},{"line_number":337,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":338,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":339,"context_line":"            help\u003d_(\u0027Remove a property from share \u0027"},{"line_number":340,"context_line":"                   \u0027(repeat option to remove multiple properties)\u0027),"},{"line_number":341,"context_line":"        )"},{"line_number":342,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"dc75f83a_0eaa94c3","line":339,"range":{"start_line":339,"start_character":43,"end_line":339,"end_character":48},"in_reply_to":"7c199477_1fd0bd7d","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":369,"context_line":"                    share_snapshot.delete_metadata([key])"},{"line_number":370,"context_line":"                except Exception as e:"},{"line_number":371,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":372,"context_line":"                        \"Failed to unset share property \""},{"line_number":373,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":374,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"8d1b1e64_9a1d74e7","line":372,"range":{"start_line":372,"start_character":41,"end_line":372,"end_character":46},"updated":"2022-11-16 05:29:51.000000000","message":"snapshot","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":369,"context_line":"                    share_snapshot.delete_metadata([key])"},{"line_number":370,"context_line":"                except Exception as e:"},{"line_number":371,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":372,"context_line":"                        \"Failed to unset share property \""},{"line_number":373,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":374,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"88421397_2c7ecbb5","line":372,"range":{"start_line":372,"start_character":41,"end_line":372,"end_character":46},"in_reply_to":"8d1b1e64_9a1d74e7","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":463,"context_line":"            \u0027--property\u0027,"},{"line_number":464,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":465,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":466,"context_line":"            help\u003d_(\u0027Filter shares having a given metadata key\u003dvalue property.\u0027"},{"line_number":467,"context_line":"                   \u0027(repeat option to filter by multiple properties)\u0027),"},{"line_number":468,"context_line":"        )"},{"line_number":469,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"e38266b9_6f56affa","line":466,"range":{"start_line":466,"start_character":27,"end_line":466,"end_character":33},"updated":"2022-11-16 05:29:51.000000000","message":"snapshots","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":463,"context_line":"            \u0027--property\u0027,"},{"line_number":464,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":465,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":466,"context_line":"            help\u003d_(\u0027Filter shares having a given metadata key\u003dvalue property.\u0027"},{"line_number":467,"context_line":"                   \u0027(repeat option to filter by multiple properties)\u0027),"},{"line_number":468,"context_line":"        )"},{"line_number":469,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"23b3c8a5_a8b982fa","line":466,"range":{"start_line":466,"start_character":27,"end_line":466,"end_character":33},"in_reply_to":"e38266b9_6f56affa","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"44ac42e1c65896dfab605c830f170a588d68183b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":69,"context_line":"            default\u003d{},"},{"line_number":70,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":71,"context_line":"            help\u003d_(\"Set a property to this snapshot \""},{"line_number":72,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":23,"id":"86836e94_9004faed","line":71,"range":{"start_line":71,"start_character":43,"end_line":71,"end_character":52},"updated":"2023-01-08 13:57:30.000000000","message":"should it be documented that it is only available for 2.73 and greater ?","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"250d524d34f9a66257c7749d3dba48f62e21cda9","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":69,"context_line":"            default\u003d{},"},{"line_number":70,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":71,"context_line":"            help\u003d_(\"Set a property to this snapshot \""},{"line_number":72,"context_line":"                   \"(repeat option to set multiple properties)\"),"},{"line_number":73,"context_line":"        )"},{"line_number":74,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":23,"id":"3525b512_9a936821","line":71,"range":{"start_line":71,"start_character":43,"end_line":71,"end_character":52},"in_reply_to":"86836e94_9004faed","updated":"2023-01-13 17:56:11.000000000","message":"Done","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"44ac42e1c65896dfab605c830f170a588d68183b","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            force\u003dparsed_args.force,"},{"line_number":85,"context_line":"            name\u003dparsed_args.name or None,"},{"line_number":86,"context_line":"            description\u003dparsed_args.description or None,"},{"line_number":87,"context_line":"            metadata\u003dparsed_args.property"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":"        if parsed_args.wait:"},{"line_number":90,"context_line":"            if not utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":23,"id":"167ad759_00a9f1d1","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":41},"updated":"2023-01-08 13:57:30.000000000","message":"should it be only added for \u003e\u003d 2.73 ?","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"250d524d34f9a66257c7749d3dba48f62e21cda9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            force\u003dparsed_args.force,"},{"line_number":85,"context_line":"            name\u003dparsed_args.name or None,"},{"line_number":86,"context_line":"            description\u003dparsed_args.description or None,"},{"line_number":87,"context_line":"            metadata\u003dparsed_args.property"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":"        if parsed_args.wait:"},{"line_number":90,"context_line":"            if not utils.wait_for_status("}],"source_content_type":"text/x-python","patch_set":23,"id":"2c1316d8_3544fc22","line":87,"range":{"start_line":87,"start_character":12,"end_line":87,"end_character":41},"in_reply_to":"167ad759_00a9f1d1","updated":"2023-01-13 17:56:11.000000000","message":"Done","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e75213a8d176027870257d2d5ad7c387c7631a0","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            property \u003d parsed_args.property or {}"},{"line_number":85,"context_line":"        elif parsed_args.property:"},{"line_number":86,"context_line":"            raise exceptions.CommandError("},{"line_number":87,"context_line":"                \"Setting metadtaa is only available with manila API version \""},{"line_number":88,"context_line":"                \"\u003e\u003d 2.73\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        share_snapshot \u003d share_client.share_snapshots.create("}],"source_content_type":"text/x-python","patch_set":24,"id":"dca11e9d_bec98a28","line":87,"range":{"start_line":87,"start_character":25,"end_line":87,"end_character":33},"updated":"2023-01-16 18:44:51.000000000","message":"metadata","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0d6613f472f07ecbc645ec64dd3463e856cd0c10","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            property \u003d parsed_args.property or {}"},{"line_number":85,"context_line":"        elif parsed_args.property:"},{"line_number":86,"context_line":"            raise exceptions.CommandError("},{"line_number":87,"context_line":"                \"Setting metadtaa is only available with manila API version \""},{"line_number":88,"context_line":"                \"\u003e\u003d 2.73\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        share_snapshot \u003d share_client.share_snapshots.create("}],"source_content_type":"text/x-python","patch_set":24,"id":"4dde8bb3_ace060c3","line":87,"range":{"start_line":87,"start_character":25,"end_line":87,"end_character":33},"in_reply_to":"dca11e9d_bec98a28","updated":"2023-02-03 19:36:37.000000000","message":"Done","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b254ce06905074b8873a6177f7405e5f91087fd1","unresolved":true,"context_lines":[{"line_number":69,"context_line":"            default\u003d{},"},{"line_number":70,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":71,"context_line":"            help\u003d_(\"Set a property to this snapshot \""},{"line_number":72,"context_line":"                   \"(repeat option to set multiple properties).\""},{"line_number":73,"context_line":"                   \"Available only for microversion \u003e\u003d 2.73\"),"},{"line_number":74,"context_line":"        )"},{"line_number":75,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":25,"id":"93c68092_7b3e3acc","line":72,"range":{"start_line":72,"start_character":62,"end_line":72,"end_character":63},"updated":"2023-02-08 21:35:13.000000000","message":"please add a blank space after the dot","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2044ead91249d30d046e9a63469896f90f75810f","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            property \u003d parsed_args.property or {}"},{"line_number":85,"context_line":"        elif parsed_args.property:"},{"line_number":86,"context_line":"            raise exceptions.CommandError("},{"line_number":87,"context_line":"                \"Setting metadtaa is only available with manila API version \""},{"line_number":88,"context_line":"                \"\u003e\u003d 2.73\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        share_snapshot \u003d share_client.share_snapshots.create("}],"source_content_type":"text/x-python","patch_set":25,"id":"77985114_e8c7505c","line":87,"range":{"start_line":87,"start_character":25,"end_line":87,"end_character":33},"updated":"2023-02-04 01:33:13.000000000","message":"metadata","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b254ce06905074b8873a6177f7405e5f91087fd1","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            property \u003d parsed_args.property or {}"},{"line_number":85,"context_line":"        elif parsed_args.property:"},{"line_number":86,"context_line":"            raise exceptions.CommandError("},{"line_number":87,"context_line":"                \"Setting metadtaa is only available with manila API version \""},{"line_number":88,"context_line":"                \"\u003e\u003d 2.73\")"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        share_snapshot \u003d share_client.share_snapshots.create("}],"source_content_type":"text/x-python","patch_set":25,"id":"a31c0fe8_4a4c33cb","line":87,"range":{"start_line":87,"start_character":25,"end_line":87,"end_character":33},"in_reply_to":"77985114_e8c7505c","updated":"2023-02-08 21:35:13.000000000","message":"+1\nAnd this elif seems to be missing coverage too - could you please add a test to it? :)","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2044ead91249d30d046e9a63469896f90f75810f","unresolved":true,"context_lines":[{"line_number":371,"context_line":"                raise exceptions.CommandError(_("},{"line_number":372,"context_line":"                    \"Failed to unset snapshot display name \""},{"line_number":373,"context_line":"                    \"or display description : %s\" % e))"},{"line_number":374,"context_line":"        if parsed_args.property:"},{"line_number":375,"context_line":"            for key in parsed_args.property:"},{"line_number":376,"context_line":"                try:"},{"line_number":377,"context_line":"                    share_snapshot.delete_metadata([key])"},{"line_number":378,"context_line":"                except Exception as e:"},{"line_number":379,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":380,"context_line":"                        \"Failed to unset snapshot property \""},{"line_number":381,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":382,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"class ListShareSnapshot(command.Lister):"}],"source_content_type":"text/x-python","patch_set":25,"id":"dc69eb8c_1ef4e413","line":382,"range":{"start_line":374,"start_character":0,"end_line":382,"end_character":45},"updated":"2023-02-04 01:33:13.000000000","message":"It would be nice to delay errors until you process the entire list - erroring out on the first one that fails would be inconsistent. See any of the delete methods for an example","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b254ce06905074b8873a6177f7405e5f91087fd1","unresolved":true,"context_lines":[{"line_number":371,"context_line":"                raise exceptions.CommandError(_("},{"line_number":372,"context_line":"                    \"Failed to unset snapshot display name \""},{"line_number":373,"context_line":"                    \"or display description : %s\" % e))"},{"line_number":374,"context_line":"        if parsed_args.property:"},{"line_number":375,"context_line":"            for key in parsed_args.property:"},{"line_number":376,"context_line":"                try:"},{"line_number":377,"context_line":"                    share_snapshot.delete_metadata([key])"},{"line_number":378,"context_line":"                except Exception as e:"},{"line_number":379,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":380,"context_line":"                        \"Failed to unset snapshot property \""},{"line_number":381,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":382,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"class ListShareSnapshot(command.Lister):"}],"source_content_type":"text/x-python","patch_set":25,"id":"d780fe6f_9af8ec24","line":382,"range":{"start_line":374,"start_character":0,"end_line":382,"end_character":45},"in_reply_to":"dc69eb8c_1ef4e413","updated":"2023-02-08 21:35:13.000000000","message":"Also, the message is not getting the values it should, please see:\nhttps://paste.opendev.org/show/bJLMXAHnZr3xSeEj1XTt/\nI believe there might be something with the way we send the string and concatenate. Could you please take a look?","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"}],"manilaclient/tests/unit/osc/v2/test_share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":true,"context_lines":[{"line_number":21,"context_line":"from osc_lib import utils as oscutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manilaclient import api_versions"},{"line_number":24,"context_line":"from manilaclient.api_versions import MAX_VERSION"},{"line_number":25,"context_line":"from manilaclient.common import cliutils"},{"line_number":26,"context_line":"from manilaclient.osc.v2 import share_snapshots as osc_share_snapshots"},{"line_number":27,"context_line":"from manilaclient.tests.unit.osc import osc_utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"e16dd8b6_1a100e55","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":49},"updated":"2022-10-04 21:40:43.000000000","message":"unsure if this import is necessary... You could access the property directly, please see the suggestion below","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from osc_lib import utils as oscutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from manilaclient import api_versions"},{"line_number":24,"context_line":"from manilaclient.api_versions import MAX_VERSION"},{"line_number":25,"context_line":"from manilaclient.common import cliutils"},{"line_number":26,"context_line":"from manilaclient.osc.v2 import share_snapshots as osc_share_snapshots"},{"line_number":27,"context_line":"from manilaclient.tests.unit.osc import osc_utils"}],"source_content_type":"text/x-python","patch_set":20,"id":"24ba5815_e178c764","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":49},"in_reply_to":"e16dd8b6_1a100e55","updated":"2022-10-19 15:19:16.000000000","message":"Done","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d2b637fc2f8322d935c80604ff98971ad4336cd2","unresolved":true,"context_lines":[{"line_number":61,"context_line":"        self.export_locations_mock.reset_mock()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":64,"context_line":"            MAX_VERSION)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class TestShareSnapshotCreate(TestShareSnapshot):"}],"source_content_type":"text/x-python","patch_set":20,"id":"74f5f8e5_3e0d0719","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":23},"updated":"2022-10-04 21:40:43.000000000","message":"api_versions.MAX_VERSION\n\nthis is also being done above (L 57)","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"bddcf266299f271119b9dde43abcf27dc0d1dfc1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self.export_locations_mock.reset_mock()"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":64,"context_line":"            MAX_VERSION)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class TestShareSnapshotCreate(TestShareSnapshot):"}],"source_content_type":"text/x-python","patch_set":20,"id":"8f6c3777_2f848166","line":64,"range":{"start_line":64,"start_character":12,"end_line":64,"end_character":23},"in_reply_to":"74f5f8e5_3e0d0719","updated":"2022-10-19 15:19:16.000000000","message":"Done","commit_id":"4bdba8b4a913f26fab98c8f56f5182ccb5d2c7a9"}],"manilaclient/v2/share_snapshots.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85e04d23b2959cb27a7f986c13d1cb62754c3e6a","unresolved":true,"context_lines":[{"line_number":89,"context_line":"    def create(self, share, force\u003dFalse, name\u003dNone, description\u003dNone):"},{"line_number":90,"context_line":"        return self._do_create(share, force, name, description)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @api_versions.wraps(\"2.69\")"},{"line_number":93,"context_line":"    def create(self, share, force\u003dFalse, name\u003dNone, description\u003dNone,"},{"line_number":94,"context_line":"               metadata\u003dNone):"},{"line_number":95,"context_line":"        return self._do_create(share, force, name, description, metadata)"}],"source_content_type":"text/x-python","patch_set":8,"id":"eaf10a5d_899e2f49","line":92,"range":{"start_line":92,"start_character":4,"end_line":92,"end_character":31},"updated":"2022-02-17 21:41:48.000000000","message":"please add # noqa: F811 in front","commit_id":"cb5324776011392492cedcfa5027d93c0683afe9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d55377dce50f8dfa9a4db14d090f97c73d8dd135","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    def create(self, share, force\u003dFalse, name\u003dNone, description\u003dNone):"},{"line_number":90,"context_line":"        return self._do_create(share, force, name, description)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @api_versions.wraps(\"2.69\")"},{"line_number":93,"context_line":"    def create(self, share, force\u003dFalse, name\u003dNone, description\u003dNone,"},{"line_number":94,"context_line":"               metadata\u003dNone):"},{"line_number":95,"context_line":"        return self._do_create(share, force, name, description, metadata)"}],"source_content_type":"text/x-python","patch_set":8,"id":"aca2b3e9_3b9d268c","line":92,"range":{"start_line":92,"start_character":4,"end_line":92,"end_character":31},"in_reply_to":"eaf10a5d_899e2f49","updated":"2022-03-04 21:03:02.000000000","message":"Done","commit_id":"cb5324776011392492cedcfa5027d93c0683afe9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2044ead91249d30d046e9a63469896f90f75810f","unresolved":true,"context_lines":[{"line_number":84,"context_line":"                             \u0027metadata\u0027: metadata}}"},{"line_number":85,"context_line":"        return self._create(\u0027/snapshots\u0027, body, \u0027snapshot\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @api_versions.wraps(\"2.0\", \"2.72\")"},{"line_number":88,"context_line":"    def create(self, share, force\u003dFalse, name\u003dNone, description\u003dNone):"},{"line_number":89,"context_line":"        return self._do_create(share, force, name, description)"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"a9649da8_fb533b9e","line":87,"range":{"start_line":87,"start_character":24,"end_line":87,"end_character":29},"updated":"2023-02-04 01:33:13.000000000","message":"This has to be \"1.0\" - i would think low risk of someone using v1 API, but still it\u0027d be a bad way to break them if they are..","commit_id":"bbfd7d5468a61c7f99ac2b6e3dc5a1b3e4561c28"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":2826,"context_line":"    default\u003dNone,"},{"line_number":2827,"context_line":"    help\u003d\u0027Filter results matching a share snapshot description pattern. \u0027"},{"line_number":2828,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.36.\u0027)"},{"line_number":2829,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":2830,"context_line":"    \"\"\"List all the snapshots.\"\"\""},{"line_number":2831,"context_line":"    all_projects \u003d int("},{"line_number":2832,"context_line":"        os.environ.get(\"ALL_TENANTS\","}],"source_content_type":"text/x-python","patch_set":21,"id":"f219aa51_c8e50e9c","line":2829,"range":{"start_line":2829,"start_character":0,"end_line":2829,"end_character":20},"updated":"2022-11-16 05:29:51.000000000","message":"should add \u0027metadata\u0027 as filter. for example:\n@cliutils.arg(\n    \u0027--metadata\u0027,\n    type\u003dstr,\n    nargs\u003d\u0027*\u0027,\n    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,\n    help\u003d\u0027Filters results by a metadata key and value. OPTIONAL: \u0027\n         \u0027Default\u003dNone, Available only for microversion \u003e\u003d 2.73. \u0027,\n    default\u003dNone)","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":2826,"context_line":"    default\u003dNone,"},{"line_number":2827,"context_line":"    help\u003d\u0027Filter results matching a share snapshot description pattern. \u0027"},{"line_number":2828,"context_line":"         \u0027Available only for microversion \u003e\u003d 2.36.\u0027)"},{"line_number":2829,"context_line":"def do_snapshot_list(cs, args):"},{"line_number":2830,"context_line":"    \"\"\"List all the snapshots.\"\"\""},{"line_number":2831,"context_line":"    all_projects \u003d int("},{"line_number":2832,"context_line":"        os.environ.get(\"ALL_TENANTS\","}],"source_content_type":"text/x-python","patch_set":21,"id":"20e987c6_e0bc7e9c","line":2829,"range":{"start_line":2829,"start_character":0,"end_line":2829,"end_character":20},"in_reply_to":"f219aa51_c8e50e9c","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":2851,"context_line":"        \u0027name\u0027: args.name,"},{"line_number":2852,"context_line":"        \u0027status\u0027: args.status,"},{"line_number":2853,"context_line":"        \u0027share_id\u0027: share.id,"},{"line_number":2854,"context_line":"        \u0027usage\u0027: args.usage,"},{"line_number":2855,"context_line":"    }"},{"line_number":2856,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.36\"),"},{"line_number":2857,"context_line":"                              api_versions.APIVersion()):"}],"source_content_type":"text/x-python","patch_set":21,"id":"9b08fa33_50281a81","line":2854,"range":{"start_line":2854,"start_character":27,"end_line":2854,"end_character":28},"updated":"2022-11-16 05:29:51.000000000","message":"add\n\u0027metadata\u0027: _extract_metadata(args),","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":2851,"context_line":"        \u0027name\u0027: args.name,"},{"line_number":2852,"context_line":"        \u0027status\u0027: args.status,"},{"line_number":2853,"context_line":"        \u0027share_id\u0027: share.id,"},{"line_number":2854,"context_line":"        \u0027usage\u0027: args.usage,"},{"line_number":2855,"context_line":"    }"},{"line_number":2856,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.36\"),"},{"line_number":2857,"context_line":"                              api_versions.APIVersion()):"}],"source_content_type":"text/x-python","patch_set":21,"id":"ce9b9752_5a90c9d4","line":2854,"range":{"start_line":2854,"start_character":27,"end_line":2854,"end_character":28},"in_reply_to":"9b08fa33_50281a81","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":2999,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":3000,"context_line":"    default\u003dNone,"},{"line_number":3001,"context_line":"    help\u003d\u0027Optional snapshot description. (Default\u003dNone)\u0027)"},{"line_number":3002,"context_line":"def do_snapshot_create(cs, args):"},{"line_number":3003,"context_line":"    \"\"\"Add a new snapshot.\"\"\""},{"line_number":3004,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":3005,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1e627228_a3097103","line":3002,"range":{"start_line":3002,"start_character":4,"end_line":3002,"end_character":22},"updated":"2022-11-16 05:29:51.000000000","message":"supoort add metadata when snapshot create.\n@cliutils.arg(\n    \u0027--metadata\u0027,\n    type\u003dstr,\n    nargs\u003d\u0027*\u0027,\n    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,\n    help\u003d\u0027Metadata key\u003dvalue pairs (Optional, Default\u003dNone). only available micversion \u003e\u003d 2.73.\u0027,\n    default\u003dNone)","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":2999,"context_line":"    metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":3000,"context_line":"    default\u003dNone,"},{"line_number":3001,"context_line":"    help\u003d\u0027Optional snapshot description. (Default\u003dNone)\u0027)"},{"line_number":3002,"context_line":"def do_snapshot_create(cs, args):"},{"line_number":3003,"context_line":"    \"\"\"Add a new snapshot.\"\"\""},{"line_number":3004,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":3005,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"}],"source_content_type":"text/x-python","patch_set":21,"id":"4ab71978_1cc1addb","line":3002,"range":{"start_line":3002,"start_character":4,"end_line":3002,"end_character":22},"in_reply_to":"1e627228_a3097103","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3889cfd5dd7383556535f9bfc37ddffb872efec2","unresolved":true,"context_lines":[{"line_number":3005,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3006,"context_line":"                                         args.force,"},{"line_number":3007,"context_line":"                                         args.name,"},{"line_number":3008,"context_line":"                                         args.description)"},{"line_number":3009,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":3010,"context_line":""},{"line_number":3011,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1d05b584_e8665c42","line":3008,"range":{"start_line":3008,"start_character":41,"end_line":3008,"end_character":57},"updated":"2022-11-16 05:29:51.000000000","message":"args.metadata if micversion \u003e\u003d 2.73","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"74e20317255e4e23af0694623c829ad25a1ff0bc","unresolved":false,"context_lines":[{"line_number":3005,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3006,"context_line":"                                         args.force,"},{"line_number":3007,"context_line":"                                         args.name,"},{"line_number":3008,"context_line":"                                         args.description)"},{"line_number":3009,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":3010,"context_line":""},{"line_number":3011,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"cc005cbe_b95ed19f","line":3008,"range":{"start_line":3008,"start_character":41,"end_line":3008,"end_character":57},"in_reply_to":"1d05b584_e8665c42","updated":"2022-12-15 18:42:52.000000000","message":"Done","commit_id":"fbff64a2137e9b5fad1b24b55d56d8cee701fc56"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"44ac42e1c65896dfab605c830f170a588d68183b","unresolved":true,"context_lines":[{"line_number":3025,"context_line":"                                             args.force,"},{"line_number":3026,"context_line":"                                             args.name,"},{"line_number":3027,"context_line":"                                             args.description,"},{"line_number":3028,"context_line":"                                             args.metadata)"},{"line_number":3029,"context_line":"    elif args.metadata:"},{"line_number":3030,"context_line":"        raise exceptions.CommandError("},{"line_number":3031,"context_line":"            \"Snapshot metadata option is only available with \""}],"source_content_type":"text/x-python","patch_set":23,"id":"6c10c30f_96905bb4","line":3028,"range":{"start_line":3028,"start_character":44,"end_line":3028,"end_character":58},"updated":"2023-01-08 13:57:30.000000000","message":"should it be parsed with \"_extract_metadata\" ? I tested and it seems that the server is not accepting it.","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"250d524d34f9a66257c7749d3dba48f62e21cda9","unresolved":false,"context_lines":[{"line_number":3025,"context_line":"                                             args.force,"},{"line_number":3026,"context_line":"                                             args.name,"},{"line_number":3027,"context_line":"                                             args.description,"},{"line_number":3028,"context_line":"                                             args.metadata)"},{"line_number":3029,"context_line":"    elif args.metadata:"},{"line_number":3030,"context_line":"        raise exceptions.CommandError("},{"line_number":3031,"context_line":"            \"Snapshot metadata option is only available with \""}],"source_content_type":"text/x-python","patch_set":23,"id":"ebf1cdb5_64370b98","line":3028,"range":{"start_line":3028,"start_character":44,"end_line":3028,"end_character":58},"in_reply_to":"6c10c30f_96905bb4","updated":"2023-01-13 17:56:11.000000000","message":"Done","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"744c7bcdaa072626827e4ed93b3e3a9b59d7e77c","unresolved":true,"context_lines":[{"line_number":3030,"context_line":"        raise exceptions.CommandError("},{"line_number":3031,"context_line":"            \"Snapshot metadata option is only available with \""},{"line_number":3032,"context_line":"            \"manila API version \u003e\u003d 2.73\")"},{"line_number":3033,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3034,"context_line":"                                         args.force,"},{"line_number":3035,"context_line":"                                         args.name,"},{"line_number":3036,"context_line":"                                         args.description)"},{"line_number":3037,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":3038,"context_line":""},{"line_number":3039,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"d318a13a_3f2670bc","line":3036,"range":{"start_line":3033,"start_character":0,"end_line":3036,"end_character":58},"updated":"2023-01-04 21:37:41.000000000","message":"shouldn\u0027t this be in an else? \n\nprobably simplify the logic here by creating a list called args and adding metadata to the list only if args.metadata isn\u0027t empty; that way you avoid having two calls to cs.share_snapshots.create","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"250d524d34f9a66257c7749d3dba48f62e21cda9","unresolved":false,"context_lines":[{"line_number":3030,"context_line":"        raise exceptions.CommandError("},{"line_number":3031,"context_line":"            \"Snapshot metadata option is only available with \""},{"line_number":3032,"context_line":"            \"manila API version \u003e\u003d 2.73\")"},{"line_number":3033,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3034,"context_line":"                                         args.force,"},{"line_number":3035,"context_line":"                                         args.name,"},{"line_number":3036,"context_line":"                                         args.description)"},{"line_number":3037,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":3038,"context_line":""},{"line_number":3039,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"0b9183fa_00fb07a4","line":3036,"range":{"start_line":3033,"start_character":0,"end_line":3036,"end_character":58},"in_reply_to":"88bd6274_517737e7","updated":"2023-01-13 17:56:11.000000000","message":"Done","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"6a3931426c6f2a19ff8fe90f7f4c517204b3ab85","unresolved":true,"context_lines":[{"line_number":3030,"context_line":"        raise exceptions.CommandError("},{"line_number":3031,"context_line":"            \"Snapshot metadata option is only available with \""},{"line_number":3032,"context_line":"            \"manila API version \u003e\u003d 2.73\")"},{"line_number":3033,"context_line":"    snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3034,"context_line":"                                         args.force,"},{"line_number":3035,"context_line":"                                         args.name,"},{"line_number":3036,"context_line":"                                         args.description)"},{"line_number":3037,"context_line":"    _print_share_snapshot(cs, snapshot)"},{"line_number":3038,"context_line":""},{"line_number":3039,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"88bd6274_517737e7","line":3036,"range":{"start_line":3033,"start_character":0,"end_line":3036,"end_character":58},"in_reply_to":"d318a13a_3f2670bc","updated":"2023-01-08 14:07:18.000000000","message":"+1 goutham.. I tested and it is creating two snapshots when metadata is passed","commit_id":"18e42d464583cb58b540734a9676afe22fef6836"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e75213a8d176027870257d2d5ad7c387c7631a0","unresolved":true,"context_lines":[{"line_number":3021,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":3022,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.73\"),"},{"line_number":3023,"context_line":"                              api_versions.APIVersion()):"},{"line_number":3024,"context_line":"        arg \u003d [args.force, args.name, args.description]"},{"line_number":3025,"context_line":"        if args.metadata is not None:"},{"line_number":3026,"context_line":"            metadata \u003d _extract_metadata(args)"},{"line_number":3027,"context_line":"            arg \u003d [arg, metadata]"},{"line_number":3028,"context_line":"        snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3029,"context_line":"                                             arg)"},{"line_number":3030,"context_line":"    elif args.metadata:"}],"source_content_type":"text/x-python","patch_set":24,"id":"821ff78d_d28c948e","line":3027,"range":{"start_line":3024,"start_character":7,"end_line":3027,"end_character":33},"updated":"2023-01-16 18:44:51.000000000","message":"Please add tests to this logic. \n\nAlso; i really don\u0027t mind us not adding this in this shell client. Users will have the ability to create a snapshot with metadata with the \"manila\" shell client but cannot manipulate any of the metadata with it","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9e75213a8d176027870257d2d5ad7c387c7631a0","unresolved":true,"context_lines":[{"line_number":3024,"context_line":"        arg \u003d [args.force, args.name, args.description]"},{"line_number":3025,"context_line":"        if args.metadata is not None:"},{"line_number":3026,"context_line":"            metadata \u003d _extract_metadata(args)"},{"line_number":3027,"context_line":"            arg \u003d [arg, metadata]"},{"line_number":3028,"context_line":"        snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3029,"context_line":"                                             arg)"},{"line_number":3030,"context_line":"    elif args.metadata:"}],"source_content_type":"text/x-python","patch_set":24,"id":"8675d37f_b73cae36","line":3027,"range":{"start_line":3027,"start_character":19,"end_line":3027,"end_character":22},"updated":"2023-01-16 18:44:51.000000000","message":"you mean *arg","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0d6613f472f07ecbc645ec64dd3463e856cd0c10","unresolved":true,"context_lines":[{"line_number":3021,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":3022,"context_line":"    if cs.api_version.matches(api_versions.APIVersion(\"2.73\"),"},{"line_number":3023,"context_line":"                              api_versions.APIVersion()):"},{"line_number":3024,"context_line":"        arg \u003d [args.force, args.name, args.description]"},{"line_number":3025,"context_line":"        if args.metadata is not None:"},{"line_number":3026,"context_line":"            metadata \u003d _extract_metadata(args)"},{"line_number":3027,"context_line":"            arg \u003d [arg, metadata]"},{"line_number":3028,"context_line":"        snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3029,"context_line":"                                             arg)"},{"line_number":3030,"context_line":"    elif args.metadata:"}],"source_content_type":"text/x-python","patch_set":24,"id":"50eb5c92_4feb935e","line":3027,"range":{"start_line":3024,"start_character":7,"end_line":3027,"end_character":33},"in_reply_to":"821ff78d_d28c948e","updated":"2023-02-03 19:36:37.000000000","message":"agreed, creating snapshot with metadata is better implemented only in the osc, removing it from here.","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0d6613f472f07ecbc645ec64dd3463e856cd0c10","unresolved":false,"context_lines":[{"line_number":3024,"context_line":"        arg \u003d [args.force, args.name, args.description]"},{"line_number":3025,"context_line":"        if args.metadata is not None:"},{"line_number":3026,"context_line":"            metadata \u003d _extract_metadata(args)"},{"line_number":3027,"context_line":"            arg \u003d [arg, metadata]"},{"line_number":3028,"context_line":"        snapshot \u003d cs.share_snapshots.create(share,"},{"line_number":3029,"context_line":"                                             arg)"},{"line_number":3030,"context_line":"    elif args.metadata:"}],"source_content_type":"text/x-python","patch_set":24,"id":"d835c5b3_013a8e5d","line":3027,"range":{"start_line":3027,"start_character":19,"end_line":3027,"end_character":22},"in_reply_to":"8675d37f_b73cae36","updated":"2023-02-03 19:36:37.000000000","message":"Done","commit_id":"08ad94acc48d5fe6f9be050fed40e19499fa4ad2"}]}