)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c44c2f6f0d749f3600b3754362ce1ee3c98c217c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ebb19dc0_b950bb07","updated":"2021-12-15 20:39:14.000000000","message":"could you please rebase this change? :)","commit_id":"865a6eefd70e2f304b3d25db93779622299d0ae3"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"13a590c5037aa3f740b6e5f2205158acfdc987da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"73480a32_ba006be0","updated":"2022-03-23 07:40:42.000000000","message":"LGTM,thanks.","commit_id":"d7838e192188b0c840f2728e742ab60eba56cd53"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8f45d444f5f7f32400aa3e65739a492c82ce3151","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ca7455c8_685832d1","updated":"2022-06-15 13:08:42.000000000","message":"-1: i am not sure why we need this \u0027tags\u0027file. Thanks","commit_id":"1a359046d987209ff51b4593a60300f0fee99ba4"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"8fbe533be5220775b695984e967cd795159f160a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"e441cf22_085bde21","updated":"2022-06-28 01:51:57.000000000","message":"I have the same question, why need tags?","commit_id":"1a359046d987209ff51b4593a60300f0fee99ba4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"debfc0a32baff9091721778266eb11026402ae36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d88a3458_05aa6cfc","in_reply_to":"e441cf22_085bde21","updated":"2022-07-12 15:31:01.000000000","message":"removed, it was added by mistake","commit_id":"1a359046d987209ff51b4593a60300f0fee99ba4"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"1f8dc8a098ff8b36c25d990f85967193f9ca6c26","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"adce0547_953306cb","updated":"2022-07-15 02:06:52.000000000","message":"LGTM, thanks!","commit_id":"8dd3ae2858418106f5e63ff7ed8eb1086e398896"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"402788cd1e060b92fe6a4ff5ecac417b9fa30d8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"7c1b78b8_351b428c","updated":"2022-08-08 17:26:55.000000000","message":"Looks good to me, thanks Kiran!","commit_id":"8dd3ae2858418106f5e63ff7ed8eb1086e398896"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5f17067f8ed27873bba89fba3f253ce9d331ecb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"77faf6d4_41976394","updated":"2022-08-29 11:20:40.000000000","message":"Good work Kiran, the code looks code. Could you please add the functional tests here (OSC and manila clients) ?","commit_id":"c5b50e4ef3a7d6fa3607b5699c520ac95d136b1d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a310646a410ae719bb8bb44e70e123dfb7fdd17f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"b89cfe44_6d5107ef","updated":"2022-08-30 01:47:43.000000000","message":"Sry, assumed that the patch was just rebased; good to note that tests were added per Felipe\u0027s comment; i\u0027ll let him re-review","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"74969805605642838b3d1028e50876e8c4dd7ec7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"6f212162_82b5825f","updated":"2022-08-30 18:27:13.000000000","message":"Thanks Kira. The added functional base code is not used by any test. The idea of functional tests are to test the OSC/manila client parameters. Given that the replica operations are not been tested yet, I\u0027m okay of leaving the functional tests for this new parameter to the future. So, either remove the code from the base or implement a test using it.","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f4b0af51765499defcdfd32b0f24b1c65267ff6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"4300871a_9edfd1f0","updated":"2022-08-30 01:46:53.000000000","message":"Thanks, LGTM","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4ceafc6b51f32769f08e5693e7e4c3277cef4f50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"7dbf8429_aeab8b1e","updated":"2022-08-30 21:59:17.000000000","message":"Waiting feedback from Kiran, otherwise lgtm.","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7339cef9e838fc9f05400ce95f508e28ea45c19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"c9139f6b_868d554c","updated":"2022-08-31 15:52:11.000000000","message":"LGTM, thanks for the test coverage Kiran ","commit_id":"db1bba7cde2edb47cd47778bef9d171ca28029bd"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"8c2287cfce04fd36b945a3a2d9f9a8b19c4986c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"e90d9697_08814861","updated":"2022-08-31 19:43:10.000000000","message":"Nice, thanks kiran. Looks fine!","commit_id":"db1bba7cde2edb47cd47778bef9d171ca28029bd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e6352d86a0dc935dd1a3080dee868efac81c923f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"64611a9a_1e2c3135","updated":"2022-08-31 17:27:18.000000000","message":"Thank you, Kiran!","commit_id":"db1bba7cde2edb47cd47778bef9d171ca28029bd"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"57e202816c4c951b62dbe4996f6f850e79ace634","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"bbc31098_f0ae97e8","updated":"2022-08-31 19:16:20.000000000","message":"Thanks for adding more tests Kiran. LGTM, thanks","commit_id":"db1bba7cde2edb47cd47778bef9d171ca28029bd"}],"manilaclient/tests/functional/client.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"74969805605642838b3d1028e50876e8c4dd7ec7","unresolved":true,"context_lines":[{"line_number":1914,"context_line":"        :param share: str -- Name or ID of a share to create a replica of"},{"line_number":1915,"context_line":"        \"\"\""},{"line_number":1916,"context_line":"        cmd \u003d \"share-replica-create %s\" % share"},{"line_number":1917,"context_line":"        if availability_zone is not None:"},{"line_number":1918,"context_line":"            cmd +\u003d \" --availability_zone \" + availability_zone"},{"line_number":1919,"context_line":"        if share_network is not None:"},{"line_number":1920,"context_line":"            cmd +\u003d \" --share_network \" + share_network"},{"line_number":1921,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5c4c0654_f599954a","line":1918,"range":{"start_line":1917,"start_character":8,"end_line":1918,"end_character":62},"updated":"2022-08-30 18:27:13.000000000","message":"why are you also adding this field that is not related to this change  ?","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"574597a94e504fa8b59f00a3a99edc1322de4ddb","unresolved":false,"context_lines":[{"line_number":1914,"context_line":"        :param share: str -- Name or ID of a share to create a replica of"},{"line_number":1915,"context_line":"        \"\"\""},{"line_number":1916,"context_line":"        cmd \u003d \"share-replica-create %s\" % share"},{"line_number":1917,"context_line":"        if availability_zone is not None:"},{"line_number":1918,"context_line":"            cmd +\u003d \" --availability_zone \" + availability_zone"},{"line_number":1919,"context_line":"        if share_network is not None:"},{"line_number":1920,"context_line":"            cmd +\u003d \" --share_network \" + share_network"},{"line_number":1921,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"738aad10_5d4fd81c","line":1918,"range":{"start_line":1917,"start_character":8,"end_line":1918,"end_character":62},"in_reply_to":"1351e076_4f9033f4","updated":"2022-08-31 09:31:30.000000000","message":"yes, it was added because its missing earlier","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4ceafc6b51f32769f08e5693e7e4c3277cef4f50","unresolved":true,"context_lines":[{"line_number":1914,"context_line":"        :param share: str -- Name or ID of a share to create a replica of"},{"line_number":1915,"context_line":"        \"\"\""},{"line_number":1916,"context_line":"        cmd \u003d \"share-replica-create %s\" % share"},{"line_number":1917,"context_line":"        if availability_zone is not None:"},{"line_number":1918,"context_line":"            cmd +\u003d \" --availability_zone \" + availability_zone"},{"line_number":1919,"context_line":"        if share_network is not None:"},{"line_number":1920,"context_line":"            cmd +\u003d \" --share_network \" + share_network"},{"line_number":1921,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1351e076_4f9033f4","line":1918,"range":{"start_line":1917,"start_character":8,"end_line":1918,"end_character":62},"in_reply_to":"5c4c0654_f599954a","updated":"2022-08-30 21:59:17.000000000","message":"yeah, it was missing here, not used (because there is no tests). Since this is a just test method, I don\u0027t see any problem adding it here. But it will be great to have a test covering this.","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"74969805605642838b3d1028e50876e8c4dd7ec7","unresolved":true,"context_lines":[{"line_number":1916,"context_line":"        cmd \u003d \"share-replica-create %s\" % share"},{"line_number":1917,"context_line":"        if availability_zone is not None:"},{"line_number":1918,"context_line":"            cmd +\u003d \" --availability_zone \" + availability_zone"},{"line_number":1919,"context_line":"        if share_network is not None:"},{"line_number":1920,"context_line":"            cmd +\u003d \" --share_network \" + share_network"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"        replica \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":1923,"context_line":"        return output_parser.details(replica)"}],"source_content_type":"text/x-python","patch_set":20,"id":"e6583f0b_a57c8415","line":1920,"range":{"start_line":1919,"start_character":8,"end_line":1920,"end_character":54},"updated":"2022-08-30 18:27:13.000000000","message":"This field is not used by any functional test. You should have a test creating the replica with the new share-network parameter. Either implement a functional test that use this parameter or remove the code.","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"574597a94e504fa8b59f00a3a99edc1322de4ddb","unresolved":false,"context_lines":[{"line_number":1916,"context_line":"        cmd \u003d \"share-replica-create %s\" % share"},{"line_number":1917,"context_line":"        if availability_zone is not None:"},{"line_number":1918,"context_line":"            cmd +\u003d \" --availability_zone \" + availability_zone"},{"line_number":1919,"context_line":"        if share_network is not None:"},{"line_number":1920,"context_line":"            cmd +\u003d \" --share_network \" + share_network"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"        replica \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":1923,"context_line":"        return output_parser.details(replica)"}],"source_content_type":"text/x-python","patch_set":20,"id":"261a1ee0_2da1f59c","line":1920,"range":{"start_line":1919,"start_character":8,"end_line":1920,"end_character":54},"in_reply_to":"70605207_53b8e9a5","updated":"2022-08-31 09:31:30.000000000","message":"Done","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"4ceafc6b51f32769f08e5693e7e4c3277cef4f50","unresolved":true,"context_lines":[{"line_number":1916,"context_line":"        cmd \u003d \"share-replica-create %s\" % share"},{"line_number":1917,"context_line":"        if availability_zone is not None:"},{"line_number":1918,"context_line":"            cmd +\u003d \" --availability_zone \" + availability_zone"},{"line_number":1919,"context_line":"        if share_network is not None:"},{"line_number":1920,"context_line":"            cmd +\u003d \" --share_network \" + share_network"},{"line_number":1921,"context_line":""},{"line_number":1922,"context_line":"        replica \u003d self.manila(cmd, microversion\u003dmicroversion)"},{"line_number":1923,"context_line":"        return output_parser.details(replica)"}],"source_content_type":"text/x-python","patch_set":20,"id":"70605207_53b8e9a5","line":1920,"range":{"start_line":1919,"start_character":8,"end_line":1920,"end_character":54},"in_reply_to":"e6583f0b_a57c8415","updated":"2022-08-30 21:59:17.000000000","message":"+1. Since we have a hard deadline, we can consider adding new tests in a follow up change, lets see if Kiran can work on this until friday.","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"74969805605642838b3d1028e50876e8c4dd7ec7","unresolved":true,"context_lines":[{"line_number":334,"context_line":"            cmd \u003d cmd + f\u0027 --availability-zone {availability_zone}\u0027"},{"line_number":335,"context_line":"        if wait:"},{"line_number":336,"context_line":"            cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":337,"context_line":"        if share_network:"},{"line_number":338,"context_line":"            cmd \u003d cmd + \u0027 --share-network %s\u0027 % share_network"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        replica_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":341,"context_line":"        self._wait_for_object_status("},{"line_number":342,"context_line":"            \u0027share replica\u0027, replica_object[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"be29d861_a6230a34","line":339,"range":{"start_line":337,"start_character":8,"end_line":339,"end_character":0},"updated":"2022-08-30 18:27:13.000000000","message":"This field is not used by any functional test. You should have a test creating the replica with the new share-network parameter. Either implement a functional test that use this parameter or remove the code.","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"574597a94e504fa8b59f00a3a99edc1322de4ddb","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            cmd \u003d cmd + f\u0027 --availability-zone {availability_zone}\u0027"},{"line_number":335,"context_line":"        if wait:"},{"line_number":336,"context_line":"            cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":337,"context_line":"        if share_network:"},{"line_number":338,"context_line":"            cmd \u003d cmd + \u0027 --share-network %s\u0027 % share_network"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"        replica_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":341,"context_line":"        self._wait_for_object_status("},{"line_number":342,"context_line":"            \u0027share replica\u0027, replica_object[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"d3da01e3_e27e019e","line":339,"range":{"start_line":337,"start_character":8,"end_line":339,"end_character":0},"in_reply_to":"be29d861_a6230a34","updated":"2022-08-31 09:31:30.000000000","message":"Ack","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"}],"manilaclient/tests/unit/osc/v2/test_share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4f4b0af51765499defcdfd32b0f24b1c65267ff6","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.replicas_mock \u003d self.app.client_manager.share.share_replicas"},{"line_number":37,"context_line":"        self.replicas_mock.reset_mock()"},{"line_number":38,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":39,"context_line":"            api_versions.MAX_VERSION)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.replica_el_mock \u003d ("},{"line_number":42,"context_line":"            self.app.client_manager"}],"source_content_type":"text/x-python","patch_set":20,"id":"30ce04d6_9ba6bbf8","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":37},"updated":"2022-08-30 01:46:53.000000000","message":"thanks for fixing this!","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"574597a94e504fa8b59f00a3a99edc1322de4ddb","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.replicas_mock \u003d self.app.client_manager.share.share_replicas"},{"line_number":37,"context_line":"        self.replicas_mock.reset_mock()"},{"line_number":38,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":39,"context_line":"            api_versions.MAX_VERSION)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.replica_el_mock \u003d ("},{"line_number":42,"context_line":"            self.app.client_manager"}],"source_content_type":"text/x-python","patch_set":20,"id":"0bdccfed_06f46f97","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":37},"in_reply_to":"30ce04d6_9ba6bbf8","updated":"2022-08-31 09:31:30.000000000","message":"Ack","commit_id":"d0dd3cbd6b47ed7bb2fd108212c8a70a92f34775"}],"manilaclient/v2/share_replicas.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"183e80ca607e4d29dcc92fdfff6f7f25317153e9","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION)  # noqa"},{"line_number":120,"context_line":"    def create(self, share, availability_zone\u003dNone):  # noqa F811"},{"line_number":121,"context_line":"        return self._create_share_replica("},{"line_number":122,"context_line":"            share, availability_zone\u003davailability_zone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"31b66938_b9731fae","line":119,"range":{"start_line":119,"start_character":4,"end_line":119,"end_character":61},"updated":"2021-08-18 09:29:36.000000000","message":"we should give the max version here.\n@api_versions.wraps(constants.REPLICA_GRADUATION_VERSION, \"2.63\")  # noqa","commit_id":"e7b9d17688f550fd571b46e9e7f7461c3fdcb144"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"213f1cbf4994b5faefd7125b175824b242c42947","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION)  # noqa"},{"line_number":120,"context_line":"    def create(self, share, availability_zone\u003dNone):  # noqa F811"},{"line_number":121,"context_line":"        return self._create_share_replica("},{"line_number":122,"context_line":"            share, availability_zone\u003davailability_zone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f0a0b632_f6873093","line":119,"range":{"start_line":119,"start_character":4,"end_line":119,"end_character":61},"in_reply_to":"31b66938_b9731fae","updated":"2021-08-18 11:45:58.000000000","message":"Done","commit_id":"e7b9d17688f550fd571b46e9e7f7461c3fdcb144"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5405d46b088019fc85919f65c3f0e90d34790202","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION, \"2.63\")  # noqa"},{"line_number":120,"context_line":"    def create(self, share, availability_zone\u003dNone):  # noqa F811"},{"line_number":121,"context_line":"        return self._create_share_replica("},{"line_number":122,"context_line":"            share, availability_zone\u003davailability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"f887b62e_2037ef4d","line":119,"range":{"start_line":119,"start_character":63,"end_line":119,"end_character":67},"updated":"2021-09-06 07:04:19.000000000","message":"2.64","commit_id":"ce195ac196cb855f40ffc34b3a618738fd9411a1"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"1c9a994a25bae18a489cd6f342753b57babefd32","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION, \"2.63\")  # noqa"},{"line_number":120,"context_line":"    def create(self, share, availability_zone\u003dNone):  # noqa F811"},{"line_number":121,"context_line":"        return self._create_share_replica("},{"line_number":122,"context_line":"            share, availability_zone\u003davailability_zone)"}],"source_content_type":"text/x-python","patch_set":8,"id":"736d82c4_79d64b68","line":119,"range":{"start_line":119,"start_character":63,"end_line":119,"end_character":67},"in_reply_to":"f887b62e_2037ef4d","updated":"2021-09-21 10:39:14.000000000","message":"Done","commit_id":"ce195ac196cb855f40ffc34b3a618738fd9411a1"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"183e80ca607e4d29dcc92fdfff6f7f25317153e9","unresolved":true,"context_lines":[{"line_number":5939,"context_line":"    if args.share_network:"},{"line_number":5940,"context_line":"        share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":5941,"context_line":""},{"line_number":5942,"context_line":"    replica \u003d cs.share_replicas.create(share,"},{"line_number":5943,"context_line":"                                       args.availability_zone,"},{"line_number":5944,"context_line":"                                       share_network)"},{"line_number":5945,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":5946,"context_line":""},{"line_number":5947,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3bcc62d8_30df2849","line":5944,"range":{"start_line":5942,"start_character":39,"end_line":5944,"end_character":52},"updated":"2021-08-18 09:29:36.000000000","message":"if microversion less than 2.64, and args.share_network is None.\nwhen it invoke create(), you will got error: create() takes from 2 to 3 positional arguments but 4 were given.\nthat means if microversion \u003c 2.64, you can not add share_network argument.\nplease see below code:\nif share_network:    # the microversion must \u003e\u003d 2.64\n    replica \u003d cs.share_replicas.create(share,\n                                       args.availability_zone,\n                                       share_network)\nelse:\n    replica \u003d cs.share_replicas.create(share, args.availability_zone)","commit_id":"e7b9d17688f550fd571b46e9e7f7461c3fdcb144"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"213f1cbf4994b5faefd7125b175824b242c42947","unresolved":false,"context_lines":[{"line_number":5939,"context_line":"    if args.share_network:"},{"line_number":5940,"context_line":"        share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":5941,"context_line":""},{"line_number":5942,"context_line":"    replica \u003d cs.share_replicas.create(share,"},{"line_number":5943,"context_line":"                                       args.availability_zone,"},{"line_number":5944,"context_line":"                                       share_network)"},{"line_number":5945,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":5946,"context_line":""},{"line_number":5947,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ad5a8600_31d9dd5e","line":5944,"range":{"start_line":5942,"start_character":39,"end_line":5944,"end_character":52},"in_reply_to":"3bcc62d8_30df2849","updated":"2021-08-18 11:45:58.000000000","message":"Done","commit_id":"e7b9d17688f550fd571b46e9e7f7461c3fdcb144"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"5fa14316a2d65f0cca15acb073568e7385da8001","unresolved":true,"context_lines":[{"line_number":6042,"context_line":"                \"with \u00272.67\u0027 API microversion.\")"},{"line_number":6043,"context_line":"        share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":6044,"context_line":""},{"line_number":6045,"context_line":"    if share_network:    # the microversion must \u003e\u003d 2.67"},{"line_number":6046,"context_line":"        replica \u003d cs.share_replicas.create(share,"},{"line_number":6047,"context_line":"                                           args.availability_zone,"},{"line_number":6048,"context_line":"                                           share_network)"},{"line_number":6049,"context_line":"    else:"},{"line_number":6050,"context_line":"        replica \u003d cs.share_replicas.create(share, args.availability_zone)"},{"line_number":6051,"context_line":""},{"line_number":6052,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6053,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"02908cd4_b477edb8","line":6050,"range":{"start_line":6045,"start_character":4,"end_line":6050,"end_character":73},"updated":"2021-12-27 08:23:51.000000000","message":"i think here can update to what you have done in https://review.opendev.org/c/openstack/python-manilaclient/+/817739/comment/c59c894d_2c7dd110/\nthat would be better 😊","commit_id":"fa8c0fff22aa86165f86d9353440ce764a1aaae0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9e31f22956c4b0dbd7407b73871df482110c0cd1","unresolved":true,"context_lines":[{"line_number":6042,"context_line":"                \"with \u00272.67\u0027 API microversion.\")"},{"line_number":6043,"context_line":"        share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":6044,"context_line":""},{"line_number":6045,"context_line":"    if share_network:    # the microversion must \u003e\u003d 2.67"},{"line_number":6046,"context_line":"        replica \u003d cs.share_replicas.create(share,"},{"line_number":6047,"context_line":"                                           args.availability_zone,"},{"line_number":6048,"context_line":"                                           share_network)"},{"line_number":6049,"context_line":"    else:"},{"line_number":6050,"context_line":"        replica \u003d cs.share_replicas.create(share, args.availability_zone)"},{"line_number":6051,"context_line":""},{"line_number":6052,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6053,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"c1cf2460_11720a9c","line":6050,"range":{"start_line":6045,"start_character":4,"end_line":6050,"end_character":73},"in_reply_to":"02908cd4_b477edb8","updated":"2022-03-17 13:44:31.000000000","message":"Done","commit_id":"fa8c0fff22aa86165f86d9353440ce764a1aaae0"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"debfc0a32baff9091721778266eb11026402ae36","unresolved":false,"context_lines":[{"line_number":6042,"context_line":"                \"with \u00272.67\u0027 API microversion.\")"},{"line_number":6043,"context_line":"        share_network \u003d _find_share_network(cs, args.share_network)"},{"line_number":6044,"context_line":""},{"line_number":6045,"context_line":"    if share_network:    # the microversion must \u003e\u003d 2.67"},{"line_number":6046,"context_line":"        replica \u003d cs.share_replicas.create(share,"},{"line_number":6047,"context_line":"                                           args.availability_zone,"},{"line_number":6048,"context_line":"                                           share_network)"},{"line_number":6049,"context_line":"    else:"},{"line_number":6050,"context_line":"        replica \u003d cs.share_replicas.create(share, args.availability_zone)"},{"line_number":6051,"context_line":""},{"line_number":6052,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6053,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"c004e021_eb6bb115","line":6050,"range":{"start_line":6045,"start_character":4,"end_line":6050,"end_character":73},"in_reply_to":"c1cf2460_11720a9c","updated":"2022-07-12 15:31:01.000000000","message":"Done","commit_id":"fa8c0fff22aa86165f86d9353440ce764a1aaae0"}],"tags":[{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"8f45d444f5f7f32400aa3e65739a492c82ce3151","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":15,"id":"8f84a6c6_7b9ebe32","updated":"2022-06-15 13:08:42.000000000","message":"Why we need this file?","commit_id":"1a359046d987209ff51b4593a60300f0fee99ba4"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"debfc0a32baff9091721778266eb11026402ae36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b866109a_ad389d3d","in_reply_to":"8f84a6c6_7b9ebe32","updated":"2022-07-12 15:31:01.000000000","message":"Done","commit_id":"1a359046d987209ff51b4593a60300f0fee99ba4"}]}