)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3a5ffdd9308c70c971696518541c3e89649f9747","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-08-26 23:14:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSC Implementation for Share Networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partially-implements: bp openstack-client-support"},{"line_number":10,"context_line":"Change-Id: I6ddb2fec1d9421bfa8b11c82da5379ada80f610b"},{"line_number":11,"context_line":"Co-Authored-By: Vida Haririan \u003cvhariria@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"11c61e7c_5272a885","line":8,"updated":"2021-08-27 08:47:45.000000000","message":"NIT can you specify which commands are being implemented?","commit_id":"60b3bbc3de71da9ed1345e16a770591908b11ed4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d0ed71bf07384d8e0e6d44f619acf48347c8e725","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-08-26 23:14:10 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSC Implementation for Share Networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Partially-implements: bp openstack-client-support"},{"line_number":10,"context_line":"Change-Id: I6ddb2fec1d9421bfa8b11c82da5379ada80f610b"},{"line_number":11,"context_line":"Co-Authored-By: Vida Haririan \u003cvhariria@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9a0d7951_d2904f77","line":8,"in_reply_to":"11c61e7c_5272a885","updated":"2021-08-27 18:43:38.000000000","message":"Done","commit_id":"60b3bbc3de71da9ed1345e16a770591908b11ed4"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"43b1ff06d8ae2efa9d6d592e3bb8e066875d4bf7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSC Implementation for Share Networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the following OSP commands:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" share network create"},{"line_number":12,"context_line":" share network list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"f7310204_4817b6fb","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":21},"updated":"2021-09-02 06:21:21.000000000","message":"nit: OSC","commit_id":"dc7d9fffc7974cabedac19c40070ced491f71f73"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5e7f1b19ea54925431b8ead8d1e1cbbef03d5a50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSC Implementation for Share Networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the following OSP commands:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" share network create"},{"line_number":12,"context_line":" share network list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9be193d9_fb6f706e","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":21},"in_reply_to":"7c3fd68b_6466bad7","updated":"2021-09-02 07:07:49.000000000","message":"Done","commit_id":"dc7d9fffc7974cabedac19c40070ced491f71f73"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"64f1205dd44348972765022c84bb84488b040ce7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"OSC Implementation for Share Networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add the following OSP commands:"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":" share network create"},{"line_number":12,"context_line":" share network list"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"7c3fd68b_6466bad7","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":21},"in_reply_to":"f7310204_4817b6fb","updated":"2021-09-02 07:06:38.000000000","message":"grrr :|","commit_id":"dc7d9fffc7974cabedac19c40070ced491f71f73"}],"manilaclient/osc/v2/share_networks.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dc0d84b4904e8777f35cb5e985de916e21875e83","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                   \u0027either 4 or 6.\u0027)"},{"line_number":123,"context_line":"        )"},{"line_number":124,"context_line":"        parser.add_argument("},{"line_number":125,"context_line":"            \u0027--detail\u0027,"},{"line_number":126,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":127,"context_line":"            default\u003dFalse,"},{"line_number":128,"context_line":"            help\u003d_(\"List share networks with details\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"54043af8_2ad97dd4","line":125,"updated":"2021-08-25 06:44:41.000000000","message":"The manila command doesn\u0027t have this option, just curious because I noticed this will add a \u0027status\u0027 field which appears to be always empty?","commit_id":"4d0d6957d34b6f292dce3aba8dc18fa2f9bcdf5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":true,"context_lines":[{"line_number":122,"context_line":"                   \u0027either 4 or 6.\u0027)"},{"line_number":123,"context_line":"        )"},{"line_number":124,"context_line":"        parser.add_argument("},{"line_number":125,"context_line":"            \u0027--detail\u0027,"},{"line_number":126,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":127,"context_line":"            default\u003dFalse,"},{"line_number":128,"context_line":"            help\u003d_(\"List share networks with details\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"20f2a85a_818c7182","line":125,"in_reply_to":"54043af8_2ad97dd4","updated":"2021-08-26 14:46:01.000000000","message":"Yes, manila shell just provides Name, ID - however, it hits the /detail  API - kinda wastefully;\nbut thought we can have the same kind of consistency here with the resource list commands in the OSC.","commit_id":"4d0d6957d34b6f292dce3aba8dc18fa2f9bcdf5a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8c7ae17696092969703aff6dc378c82f9609d6e4","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        parser.add_argument("},{"line_number":100,"context_line":"            \u0027--network-type\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\u0027\u003cnetwork-type\u003e\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Filter share networks by the type of network. Examples \u0027"},{"line_number":103,"context_line":"                   \u0027include \"flat\", \"vlan\", \"vxlan\", \"geneve\", etc.\u0027)"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"b1179b5f_183d419c","line":101,"updated":"2021-08-26 12:39:30.000000000","message":"There could be a choices\u003d[\u0027flat\u0027, \u0027vlan\u0027...] kwarg here... So there would be no need to mention it in the help and the client would allow only the choices options :)","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5124d49d28d22883d9d3d93bfd16985c8c4c7ebd","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        parser.add_argument("},{"line_number":100,"context_line":"            \u0027--network-type\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\u0027\u003cnetwork-type\u003e\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Filter share networks by the type of network. Examples \u0027"},{"line_number":103,"context_line":"                   \u0027include \"flat\", \"vlan\", \"vxlan\", \"geneve\", etc.\u0027)"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"45c8ec6e_386eee83","line":101,"in_reply_to":"78ab332c_906bffbe","updated":"2021-08-27 06:15:40.000000000","message":"Ack","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        parser.add_argument("},{"line_number":100,"context_line":"            \u0027--network-type\u0027,"},{"line_number":101,"context_line":"            metavar\u003d\u0027\u003cnetwork-type\u003e\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Filter share networks by the type of network. Examples \u0027"},{"line_number":103,"context_line":"                   \u0027include \"flat\", \"vlan\", \"vxlan\", \"geneve\", etc.\u0027)"},{"line_number":104,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":8,"id":"78ab332c_906bffbe","line":101,"in_reply_to":"b1179b5f_183d419c","updated":"2021-08-26 14:46:01.000000000","message":"I thought of this, and then thought that this depends on neutron/networking setup in the cloud - not all networking choices we\u0027re calling out may be available or sufficient; and if there\u0027s a new/custom network protocol, our list may restrict the user. The share network list API allows anything to be used to this field :)","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8c7ae17696092969703aff6dc378c82f9609d6e4","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                   \"the network must be available across all availability \""},{"line_number":283,"context_line":"                   \"zones (\u0027default\u0027 share network subnet). Available \""},{"line_number":284,"context_line":"                   \"only for microversion \u003e\u003d 2.51.\")"},{"line_number":285,"context_line":"        )"},{"line_number":286,"context_line":"        return parser"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"247fd586_a6c42117","line":285,"updated":"2021-08-26 12:39:30.000000000","message":"What do you think about adding a --wait parameter here as well?","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                   \"the network must be available across all availability \""},{"line_number":283,"context_line":"                   \"zones (\u0027default\u0027 share network subnet). Available \""},{"line_number":284,"context_line":"                   \"only for microversion \u003e\u003d 2.51.\")"},{"line_number":285,"context_line":"        )"},{"line_number":286,"context_line":"        return parser"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"e1013983_3920f07c","line":285,"in_reply_to":"247fd586_a6c42117","updated":"2021-08-26 14:46:01.000000000","message":"share network creation is synchronous..","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5124d49d28d22883d9d3d93bfd16985c8c4c7ebd","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                   \"the network must be available across all availability \""},{"line_number":283,"context_line":"                   \"zones (\u0027default\u0027 share network subnet). Available \""},{"line_number":284,"context_line":"                   \"only for microversion \u003e\u003d 2.51.\")"},{"line_number":285,"context_line":"        )"},{"line_number":286,"context_line":"        return parser"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"853a324e_d0fdbb1f","line":285,"in_reply_to":"a5a028c8_a35940e1","updated":"2021-08-27 06:15:40.000000000","message":"Ack","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ea7ed3ca65899c5800a7f9c71be8b3fdb5e56dc5","unresolved":true,"context_lines":[{"line_number":282,"context_line":"                   \"the network must be available across all availability \""},{"line_number":283,"context_line":"                   \"zones (\u0027default\u0027 share network subnet). Available \""},{"line_number":284,"context_line":"                   \"only for microversion \u003e\u003d 2.51.\")"},{"line_number":285,"context_line":"        )"},{"line_number":286,"context_line":"        return parser"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":8,"id":"a5a028c8_a35940e1","line":285,"in_reply_to":"e1013983_3920f07c","updated":"2021-08-26 14:49:44.000000000","message":"oh, that\u0027s right... sorry :D","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8c7ae17696092969703aff6dc378c82f9609d6e4","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        availability_zone \u003d None"},{"line_number":292,"context_line":"        if parsed_args.availability_zone:"},{"line_number":293,"context_line":"            availability_zone \u003d oscutils.find_resource("},{"line_number":294,"context_line":"                share_client.availability_zones,"},{"line_number":295,"context_line":"                parsed_args.availability_zone).name"}],"source_content_type":"text/x-python","patch_set":8,"id":"ee7a1732_b62b6823","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":41},"updated":"2021-08-26 12:39:30.000000000","message":"If this parameter is specified, isn\u0027t there need to have a validation to check the client\u0027s API version?","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5124d49d28d22883d9d3d93bfd16985c8c4c7ebd","unresolved":false,"context_lines":[{"line_number":289,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        availability_zone \u003d None"},{"line_number":292,"context_line":"        if parsed_args.availability_zone:"},{"line_number":293,"context_line":"            availability_zone \u003d oscutils.find_resource("},{"line_number":294,"context_line":"                share_client.availability_zones,"},{"line_number":295,"context_line":"                parsed_args.availability_zone).name"}],"source_content_type":"text/x-python","patch_set":8,"id":"400e5047_e6fd8f6e","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":41},"in_reply_to":"d27c0cba_fad6c9df","updated":"2021-08-27 06:15:40.000000000","message":"Done","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":true,"context_lines":[{"line_number":289,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        availability_zone \u003d None"},{"line_number":292,"context_line":"        if parsed_args.availability_zone:"},{"line_number":293,"context_line":"            availability_zone \u003d oscutils.find_resource("},{"line_number":294,"context_line":"                share_client.availability_zones,"},{"line_number":295,"context_line":"                parsed_args.availability_zone).name"}],"source_content_type":"text/x-python","patch_set":8,"id":"d27c0cba_fad6c9df","line":292,"range":{"start_line":292,"start_character":8,"end_line":292,"end_character":41},"in_reply_to":"ee7a1732_b62b6823","updated":"2021-08-26 14:46:01.000000000","message":"Ack, will do","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8c7ae17696092969703aff6dc378c82f9609d6e4","unresolved":true,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        share_network \u003d share_client.share_networks.create("},{"line_number":298,"context_line":"            name\u003dparsed_args.name or None,"},{"line_number":299,"context_line":"            description\u003dparsed_args.description or None,"},{"line_number":300,"context_line":"            neutron_net_id\u003dparsed_args.neutron_net_id,"},{"line_number":301,"context_line":"            neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":302,"context_line":"            availability_zone\u003davailability_zone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"f940ff86_94132f9c","line":299,"range":{"start_line":299,"start_character":24,"end_line":299,"end_character":47},"updated":"2021-08-26 12:39:30.000000000","message":"I think this already defaults to None, so I\u0027d say there is no need to add the `or None` sentence :)","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        share_network \u003d share_client.share_networks.create("},{"line_number":298,"context_line":"            name\u003dparsed_args.name or None,"},{"line_number":299,"context_line":"            description\u003dparsed_args.description or None,"},{"line_number":300,"context_line":"            neutron_net_id\u003dparsed_args.neutron_net_id,"},{"line_number":301,"context_line":"            neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":302,"context_line":"            availability_zone\u003davailability_zone,"}],"source_content_type":"text/x-python","patch_set":8,"id":"15edc8b4_050a7c87","line":299,"range":{"start_line":299,"start_character":24,"end_line":299,"end_character":47},"in_reply_to":"f940ff86_94132f9c","updated":"2021-08-26 14:46:01.000000000","message":"Ack","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8c7ae17696092969703aff6dc378c82f9609d6e4","unresolved":true,"context_lines":[{"line_number":488,"context_line":"                          f\"{parsed_args.status}: {e}\")"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        new_security_service \u003d current_security_service \u003d None"},{"line_number":491,"context_line":"        if parsed_args.new_security_service:"},{"line_number":492,"context_line":"            new_security_service \u003d oscutils.find_resource("},{"line_number":493,"context_line":"                share_client.security_services,"},{"line_number":494,"context_line":"                parsed_args.new_security_service)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b5e4af77_099d03bd","line":491,"range":{"start_line":491,"start_character":8,"end_line":491,"end_character":44},"updated":"2021-08-26 12:39:30.000000000","message":"I think it might be useful to add the validation for the 2.63 microversion here and in the below if statements:)","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":false,"context_lines":[{"line_number":488,"context_line":"                          f\"{parsed_args.status}: {e}\")"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        new_security_service \u003d current_security_service \u003d None"},{"line_number":491,"context_line":"        if parsed_args.new_security_service:"},{"line_number":492,"context_line":"            new_security_service \u003d oscutils.find_resource("},{"line_number":493,"context_line":"                share_client.security_services,"},{"line_number":494,"context_line":"                parsed_args.new_security_service)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9c57d497_fdbf3f19","line":491,"range":{"start_line":491,"start_character":8,"end_line":491,"end_character":44},"in_reply_to":"b5e4af77_099d03bd","updated":"2021-08-26 14:46:01.000000000","message":"Ack","commit_id":"8c93e87faafe3e5bb6d9d913000c473960a0b06c"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3a5ffdd9308c70c971696518541c3e89649f9747","unresolved":true,"context_lines":[{"line_number":157,"context_line":"            columns.append(\u0027Project ID\u0027)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        search_opts \u003d {"},{"line_number":160,"context_line":"            \u0027all_tenants\u0027: all_tenants,"},{"line_number":161,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":162,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":163,"context_line":"            \u0027created_since\u0027: parsed_args.created_since,"}],"source_content_type":"text/x-python","patch_set":10,"id":"dab3dcc8_c9e39d47","line":160,"updated":"2021-08-27 08:47:45.000000000","message":"Still all_tenants instead of all_projects?","commit_id":"60b3bbc3de71da9ed1345e16a770591908b11ed4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d0ed71bf07384d8e0e6d44f619acf48347c8e725","unresolved":true,"context_lines":[{"line_number":157,"context_line":"            columns.append(\u0027Project ID\u0027)"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        search_opts \u003d {"},{"line_number":160,"context_line":"            \u0027all_tenants\u0027: all_tenants,"},{"line_number":161,"context_line":"            \u0027project_id\u0027: project_id,"},{"line_number":162,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":163,"context_line":"            \u0027created_since\u0027: parsed_args.created_since,"}],"source_content_type":"text/x-python","patch_set":10,"id":"f5d534e9_052becf4","line":160,"in_reply_to":"dab3dcc8_c9e39d47","updated":"2021-08-27 18:43:38.000000000","message":"yeah, the API needs to be fixed to accept \"all_projects\": https://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dlist-share-networks-with-details-detail#id257","commit_id":"60b3bbc3de71da9ed1345e16a770591908b11ed4"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"8d5343202cd7853188c44affc44e6ca2bc061cce","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--name~\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\"\u003cshare-network-name-pattern\u003e\","},{"line_number":43,"context_line":"            help\u003d_(\u0027Filter share networks by name-pattern]. Available only \u0027"},{"line_number":44,"context_line":"                   \u0027for microversion \u003e\u003d 2.36.\u0027)"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":11,"id":"c9a4d499_328c2233","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":58},"updated":"2021-08-30 13:29:27.000000000","message":"Little typo here :)","commit_id":"8345b09b2cecb16046bf3fc862e9e03b0433f737"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b539e3aa933d943be9a28cca2df5152bd139e495","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--name~\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\"\u003cshare-network-name-pattern\u003e\","},{"line_number":43,"context_line":"            help\u003d_(\u0027Filter share networks by name-pattern]. Available only \u0027"},{"line_number":44,"context_line":"                   \u0027for microversion \u003e\u003d 2.36.\u0027)"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":11,"id":"6921db4d_bb7683d5","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":58},"in_reply_to":"c9a4d499_328c2233","updated":"2021-08-30 22:20:00.000000000","message":"Thanks, fixed this up!","commit_id":"8345b09b2cecb16046bf3fc862e9e03b0433f737"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"43b1ff06d8ae2efa9d6d592e3bb8e066875d4bf7","unresolved":true,"context_lines":[{"line_number":649,"context_line":"        result \u003d 0"},{"line_number":650,"context_line":"        kwargs \u003d {}"},{"line_number":651,"context_line":"        if parsed_args.name:"},{"line_number":652,"context_line":"            kwargs[\u0027name\u0027] \u003d None"},{"line_number":653,"context_line":"        if parsed_args.description:"},{"line_number":654,"context_line":"            kwargs[\u0027description\u0027] \u003d None"},{"line_number":655,"context_line":"        if kwargs:"}],"source_content_type":"text/x-python","patch_set":13,"id":"c72d51b7_fb637416","line":652,"updated":"2021-09-02 06:21:21.000000000","message":"I am not able to unset a name or description, getting an error: \"Failed to unset share network properties {\u0027name\u0027: None}: Must specify fields to be updated\"\nI think we cannot set it to None here, an empty string should work: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_networks.py#L199-L205","commit_id":"dc7d9fffc7974cabedac19c40070ced491f71f73"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5e7f1b19ea54925431b8ead8d1e1cbbef03d5a50","unresolved":false,"context_lines":[{"line_number":649,"context_line":"        result \u003d 0"},{"line_number":650,"context_line":"        kwargs \u003d {}"},{"line_number":651,"context_line":"        if parsed_args.name:"},{"line_number":652,"context_line":"            kwargs[\u0027name\u0027] \u003d None"},{"line_number":653,"context_line":"        if parsed_args.description:"},{"line_number":654,"context_line":"            kwargs[\u0027description\u0027] \u003d None"},{"line_number":655,"context_line":"        if kwargs:"}],"source_content_type":"text/x-python","patch_set":13,"id":"6325c19c_102e0efe","line":652,"in_reply_to":"848e47f5_88ea3a26","updated":"2021-09-02 07:07:49.000000000","message":"Done","commit_id":"dc7d9fffc7974cabedac19c40070ced491f71f73"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"64f1205dd44348972765022c84bb84488b040ce7","unresolved":true,"context_lines":[{"line_number":649,"context_line":"        result \u003d 0"},{"line_number":650,"context_line":"        kwargs \u003d {}"},{"line_number":651,"context_line":"        if parsed_args.name:"},{"line_number":652,"context_line":"            kwargs[\u0027name\u0027] \u003d None"},{"line_number":653,"context_line":"        if parsed_args.description:"},{"line_number":654,"context_line":"            kwargs[\u0027description\u0027] \u003d None"},{"line_number":655,"context_line":"        if kwargs:"}],"source_content_type":"text/x-python","patch_set":13,"id":"848e47f5_88ea3a26","line":652,"in_reply_to":"c72d51b7_fb637416","updated":"2021-09-02 07:06:38.000000000","message":"Oh wow, good catch, thanks Maari - will fix this up","commit_id":"dc7d9fffc7974cabedac19c40070ced491f71f73"}],"manilaclient/osc/v2/share_snapshots.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"dc0d84b4904e8777f35cb5e985de916e21875e83","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        export_locations \u003d ("},{"line_number":149,"context_line":"            share_client.share_snapshot_export_locations.list("},{"line_number":150,"context_line":"                share_snapshot))"},{"line_number":151,"context_line":"        if parsed_args.formatter \u003d\u003d \u0027table\u0027:"},{"line_number":152,"context_line":"            export_locations \u003d cliutils.convert_dict_list_to_string("},{"line_number":153,"context_line":"                export_locations,"},{"line_number":154,"context_line":"                ignored_keys\u003d[\u0027replica_state\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f23c6ca2_a2a74bd6","line":151,"updated":"2021-08-25 06:44:41.000000000","message":"+1 to adding this here, however now we will break yaml and json, see: https://paste.opendev.org/show/808299/\nI\u0027ve been running into the same case with other patches as well:\nhttps://review.opendev.org/c/openstack/python-manilaclient/+/805259\nhttps://review.opendev.org/c/openstack/python-manilaclient/+/805250","commit_id":"4d0d6957d34b6f292dce3aba8dc18fa2f9bcdf5a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b182c9d270847b2377c2a8cb0eea16f7b05d28b","unresolved":true,"context_lines":[{"line_number":148,"context_line":"        export_locations \u003d ("},{"line_number":149,"context_line":"            share_client.share_snapshot_export_locations.list("},{"line_number":150,"context_line":"                share_snapshot))"},{"line_number":151,"context_line":"        if parsed_args.formatter \u003d\u003d \u0027table\u0027:"},{"line_number":152,"context_line":"            export_locations \u003d cliutils.convert_dict_list_to_string("},{"line_number":153,"context_line":"                export_locations,"},{"line_number":154,"context_line":"                ignored_keys\u003d[\u0027replica_state\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"c6f92ac5_68805587","line":151,"in_reply_to":"f23c6ca2_a2a74bd6","updated":"2021-08-26 14:46:01.000000000","message":"good catch, thanks Maari - i thought i tested this; for yaml and json, we\u0027ll need to convert this to a primitive. I\u0027ll do that in a follow up change.","commit_id":"4d0d6957d34b6f292dce3aba8dc18fa2f9bcdf5a"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3a5ffdd9308c70c971696518541c3e89649f9747","unresolved":true,"context_lines":[{"line_number":964,"context_line":"        :param Dictionary attrs:"},{"line_number":965,"context_line":"            A dictionary with all attributes"},{"line_number":966,"context_line":"        :param Integer count:"},{"line_number":967,"context_line":"            The number of share types to be faked"},{"line_number":968,"context_line":"        :return:"},{"line_number":969,"context_line":"            A list of FakeResource objects"},{"line_number":970,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"c789fd60_593bd2cd","line":967,"updated":"2021-08-27 08:47:45.000000000","message":"NIT s/share types/share networks/g","commit_id":"60b3bbc3de71da9ed1345e16a770591908b11ed4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d0ed71bf07384d8e0e6d44f619acf48347c8e725","unresolved":true,"context_lines":[{"line_number":964,"context_line":"        :param Dictionary attrs:"},{"line_number":965,"context_line":"            A dictionary with all attributes"},{"line_number":966,"context_line":"        :param Integer count:"},{"line_number":967,"context_line":"            The number of share types to be faked"},{"line_number":968,"context_line":"        :return:"},{"line_number":969,"context_line":"            A list of FakeResource objects"},{"line_number":970,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":10,"id":"6f4f0a3a_7fed855a","line":967,"in_reply_to":"c789fd60_593bd2cd","updated":"2021-08-27 18:43:38.000000000","message":"https://media.giphy.com/media/vX9WcCiWwUF7G/giphy.gif?cid\u003decf05e478i1eszchyrxyytnfzzqelk3d3i2a6yvgo4796dgv\u0026rid\u003dgiphy.gif\u0026ct\u003dg :(","commit_id":"60b3bbc3de71da9ed1345e16a770591908b11ed4"}]}