)]}'
{"manilaclient/osc/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd88bdd2480d1b628c7adb021b637d764634e4a9","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Enable/disable share service (Admin only).\"\"\""},{"line_number":26,"context_line":"    _description \u003d _(\"Enable/Disable share service (Admin only).\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetShareService\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(SetShareService, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"aba9f20b_6fa83b0a","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":58},"updated":"2021-08-20 00:22:05.000000000","message":"I was curious about this; not all command classes have this; is this done by convention or choice? Also, the logger setup on line 21 isn\u0027t necessary any more? And this one isn\u0027t used yet","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Enable/disable share service (Admin only).\"\"\""},{"line_number":26,"context_line":"    _description \u003d _(\"Enable/Disable share service (Admin only).\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetShareService\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(SetShareService, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e2f968fc_84538f59","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":58},"in_reply_to":"aba9f20b_6fa83b0a","updated":"2021-08-20 09:14:13.000000000","message":"Good catch, in here it\u0027s a matter of copy/paste. I believe we don\u0027t need to do any logging  here so I can drop both?\nLooking at the other patches, this is actually very inconsistent. Would you mind reporting a bug for this?","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05fb7b4a930f31b55918b98be733975cba09719","unresolved":true,"context_lines":[{"line_number":25,"context_line":"    \"\"\"Enable/disable share service (Admin only).\"\"\""},{"line_number":26,"context_line":"    _description \u003d _(\"Enable/Disable share service (Admin only).\")"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetShareService\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(SetShareService, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"08ef4efb_c9c5e79e","line":28,"range":{"start_line":28,"start_character":4,"end_line":28,"end_character":58},"in_reply_to":"e2f968fc_84538f59","updated":"2021-08-20 16:06:37.000000000","message":"Yep: https://bugs.launchpad.net/python-manilaclient/+bug/1940692 and https://tree.taiga.io/project/gouthampacha-openstack-manila-osc-integration-with-python-manilaclient/us/47","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6b70147a1ef0714951e2ed4c02857f00ed4529b4","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetShareService\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(SetShareService, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027host\u0027,"},{"line_number":34,"context_line":"            metavar\u003d\u0027\u003chost\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"83c09d3b_8b51b798","line":31,"updated":"2021-08-20 13:43:23.000000000","message":"This should be implemented using a mutually exclusive group (see https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#boolean-options)\n\nRight now, you can pass --enable and --disable, and --disable will take precedence.","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05fb7b4a930f31b55918b98be733975cba09719","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetShareService\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(SetShareService, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027host\u0027,"},{"line_number":34,"context_line":"            metavar\u003d\u0027\u003chost\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fed937f9_6711ddf2","line":31,"in_reply_to":"8008a209_16c458de","updated":"2021-08-20 16:06:37.000000000","message":"Nice!","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"302d8901b0f0f6cece87c25da77c2452104dbe78","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    log \u003d logging.getLogger(__name__ + \".SetShareService\")"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(SetShareService, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027host\u0027,"},{"line_number":34,"context_line":"            metavar\u003d\u0027\u003chost\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"8008a209_16c458de","line":31,"in_reply_to":"83c09d3b_8b51b798","updated":"2021-08-20 14:01:41.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd88bdd2480d1b628c7adb021b637d764634e4a9","unresolved":true,"context_lines":[{"line_number":38,"context_line":"            \u0027binary\u0027,"},{"line_number":39,"context_line":"            metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":40,"context_line":"            help\u003d_(\"Service binary, could be \u0027manila-share\u0027\""},{"line_number":41,"context_line":"                   \" or \u0027manila-scheduler\u0027.\")"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        parser.add_argument("},{"line_number":44,"context_line":"            \"--enable\","}],"source_content_type":"text/x-python","patch_set":2,"id":"cd4d45b1_1f7f824f","line":41,"range":{"start_line":41,"start_character":42,"end_line":41,"end_character":43},"updated":"2021-08-20 00:22:05.000000000","message":"or \u0027manila-data\u0027","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \u0027binary\u0027,"},{"line_number":39,"context_line":"            metavar\u003d\u0027\u003cbinary\u003e\u0027,"},{"line_number":40,"context_line":"            help\u003d_(\"Service binary, could be \u0027manila-share\u0027\""},{"line_number":41,"context_line":"                   \" or \u0027manila-scheduler\u0027.\")"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        parser.add_argument("},{"line_number":44,"context_line":"            \"--enable\","}],"source_content_type":"text/x-python","patch_set":2,"id":"2d0432e7_726a4567","line":41,"range":{"start_line":41,"start_character":42,"end_line":41,"end_character":43},"in_reply_to":"cd4d45b1_1f7f824f","updated":"2021-08-20 09:14:13.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd88bdd2480d1b628c7adb021b637d764634e4a9","unresolved":true,"context_lines":[{"line_number":84,"context_line":"            \"--host\","},{"line_number":85,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":86,"context_line":"            default\u003dNone,"},{"line_number":87,"context_line":"            help\u003d_(\"Name of host.\")"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \"--binary\","}],"source_content_type":"text/x-python","patch_set":2,"id":"00651db5_269818f8","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":32},"updated":"2021-08-20 00:22:05.000000000","message":"Filter services by name of the host","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            \"--host\","},{"line_number":85,"context_line":"            metavar\u003d\"\u003chost\u003e\","},{"line_number":86,"context_line":"            default\u003dNone,"},{"line_number":87,"context_line":"            help\u003d_(\"Name of host.\")"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \"--binary\","}],"source_content_type":"text/x-python","patch_set":2,"id":"89a36947_be26f45e","line":87,"range":{"start_line":87,"start_character":20,"end_line":87,"end_character":32},"in_reply_to":"00651db5_269818f8","updated":"2021-08-20 09:14:13.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd88bdd2480d1b628c7adb021b637d764634e4a9","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            \"--binary\","},{"line_number":91,"context_line":"            metavar\u003d\"\u003cbinary\u003e\","},{"line_number":92,"context_line":"            default\u003dNone,"},{"line_number":93,"context_line":"            help\u003d_(\"Service binary.\")"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \"--status\","}],"source_content_type":"text/x-python","patch_set":2,"id":"36ecfb77_bb52f97b","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":34},"updated":"2021-08-20 00:22:05.000000000","message":"Filter services by the name of the service","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \"--binary\","},{"line_number":91,"context_line":"            metavar\u003d\"\u003cbinary\u003e\","},{"line_number":92,"context_line":"            default\u003dNone,"},{"line_number":93,"context_line":"            help\u003d_(\"Service binary.\")"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("},{"line_number":96,"context_line":"            \"--status\","}],"source_content_type":"text/x-python","patch_set":2,"id":"2ba2406d_a38d9438","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":34},"in_reply_to":"36ecfb77_bb52f97b","updated":"2021-08-20 09:14:13.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd88bdd2480d1b628c7adb021b637d764634e4a9","unresolved":true,"context_lines":[{"line_number":102,"context_line":"            \"--state\","},{"line_number":103,"context_line":"            metavar\u003d\"\u003cstate\u003e\","},{"line_number":104,"context_line":"            default\u003dNone,"},{"line_number":105,"context_line":"            help\u003d_(\"Filter results by state.\")"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \"--zone\","}],"source_content_type":"text/x-python","patch_set":2,"id":"196fa6ee_31fab8f8","line":105,"range":{"start_line":105,"start_character":43,"end_line":105,"end_character":44},"updated":"2021-08-20 00:22:05.000000000","message":"worth adding choices here - there are two states: up and down","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            \"--state\","},{"line_number":103,"context_line":"            metavar\u003d\"\u003cstate\u003e\","},{"line_number":104,"context_line":"            default\u003dNone,"},{"line_number":105,"context_line":"            help\u003d_(\"Filter results by state.\")"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \"--zone\","}],"source_content_type":"text/x-python","patch_set":2,"id":"19b0db72_da1f2696","line":105,"range":{"start_line":105,"start_character":43,"end_line":105,"end_character":44},"in_reply_to":"196fa6ee_31fab8f8","updated":"2021-08-20 09:14:13.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bd88bdd2480d1b628c7adb021b637d764634e4a9","unresolved":true,"context_lines":[{"line_number":108,"context_line":"            \"--zone\","},{"line_number":109,"context_line":"            metavar\u003d\"\u003czone\u003e\","},{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\"Availability zone.\")"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        return parser"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7c698b11_f30ecbf3","line":111,"range":{"start_line":111,"start_character":20,"end_line":111,"end_character":37},"updated":"2021-08-20 00:22:05.000000000","message":"Filter services by their availability zone","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            \"--zone\","},{"line_number":109,"context_line":"            metavar\u003d\"\u003czone\u003e\","},{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\"Availability zone.\")"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        return parser"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f4ea6e3b_adc91c20","line":111,"range":{"start_line":111,"start_character":20,"end_line":111,"end_character":37},"in_reply_to":"7c698b11_f30ecbf3","updated":"2021-08-20 09:14:13.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b05fb7b4a930f31b55918b98be733975cba09719","unresolved":true,"context_lines":[{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \"--state\","},{"line_number":95,"context_line":"            metavar\u003d\"\u003cstate\u003e\","},{"line_number":96,"context_line":"            default\u003dNone,"},{"line_number":97,"context_line":"            choices\u003d[\u0027up\u0027, \u0027down\u0027],"},{"line_number":98,"context_line":"            help\u003d_(\"Filter results by state.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"b00bba9a_6c24e91c","line":95,"range":{"start_line":95,"start_character":22,"end_line":95,"end_character":27},"updated":"2021-08-20 16:06:37.000000000","message":"up/down","commit_id":"fcbcf7521fd1e323c4bc2f528c7654fd9fb02f78"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"6b70147a1ef0714951e2ed4c02857f00ed4529b4","unresolved":true,"context_lines":[{"line_number":690,"context_line":"        :param Dictionary attrs:"},{"line_number":691,"context_line":"            A dictionary with all attributes"},{"line_number":692,"context_line":"        :param Integer count:"},{"line_number":693,"context_line":"            The number of share types to be faked"},{"line_number":694,"context_line":"        :return:"},{"line_number":695,"context_line":"            A list of FakeResource objects"},{"line_number":696,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bc93996e_d9d5c9aa","line":693,"updated":"2021-08-20 13:43:23.000000000","message":"NIT s/share types/services/g","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"302d8901b0f0f6cece87c25da77c2452104dbe78","unresolved":true,"context_lines":[{"line_number":690,"context_line":"        :param Dictionary attrs:"},{"line_number":691,"context_line":"            A dictionary with all attributes"},{"line_number":692,"context_line":"        :param Integer count:"},{"line_number":693,"context_line":"            The number of share types to be faked"},{"line_number":694,"context_line":"        :return:"},{"line_number":695,"context_line":"            A list of FakeResource objects"},{"line_number":696,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"46b41611_f78ef0de","line":693,"in_reply_to":"bc93996e_d9d5c9aa","updated":"2021-08-20 14:01:41.000000000","message":"already fixed in patchset 3","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7e688f4a7b8cda3bdce7402149ca41e6ad744a9e","unresolved":true,"context_lines":[{"line_number":696,"context_line":"        \"\"\""},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        services \u003d []"},{"line_number":699,"context_line":"        for n in range(0, count):"},{"line_number":700,"context_line":"            services.append("},{"line_number":701,"context_line":"                FakeShareService.create_fake_service(attrs))"},{"line_number":702,"context_line":"        return services"}],"source_content_type":"text/x-python","patch_set":2,"id":"a6d5efea_3b76023a","line":699,"range":{"start_line":699,"start_character":23,"end_line":699,"end_character":26},"updated":"2021-08-19 23:59:01.000000000","message":"nit: I\u0027d say adding this 0 is not necessary...\nOnly adding the count would be enough. But the 0 is harmless though :)","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d77a62bceccb0d7ff76f0f85a74190631d4fe618","unresolved":false,"context_lines":[{"line_number":696,"context_line":"        \"\"\""},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"        services \u003d []"},{"line_number":699,"context_line":"        for n in range(0, count):"},{"line_number":700,"context_line":"            services.append("},{"line_number":701,"context_line":"                FakeShareService.create_fake_service(attrs))"},{"line_number":702,"context_line":"        return services"}],"source_content_type":"text/x-python","patch_set":2,"id":"61e30cd0_2ec0331f","line":699,"range":{"start_line":699,"start_character":23,"end_line":699,"end_character":26},"in_reply_to":"a6d5efea_3b76023a","updated":"2021-08-20 09:14:13.000000000","message":"Ack","commit_id":"6a9c936bf38d5f337c4c08e67c5eaaa23c2aabea"}]}