)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"e878ccf46b0a0e0c5dc6e3b418c53714b14a2f39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"fb8b328d_70372091","updated":"2021-10-14 12:55:19.000000000","message":"Updating my vote, I totally missed the doc index issue :)","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"9a8243ece58a8278a2068d85dca101445e0da4c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"e247b1ac_e1318077","updated":"2021-11-29 20:09:54.000000000","message":"LGTM. Thank you, Victoria!","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2a51dcc5fa44f7225b1781ad7151f2c135b23fea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"36e07093_39e3c820","updated":"2021-11-25 18:05:52.000000000","message":"Managed to perform some tests on this change.\nCode looks good to me and works as expected!\nThank you! :)","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"792cf60b50b98466df86e7ad2fbc07693a639249","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"b4aae43d_900c4f99","updated":"2021-11-23 19:29:45.000000000","message":"Thanks Victoria! I\u0027ve done another round of testing, it\u0027s working great! I do have 2 notes: \n1) Filtering the list with --group-specs did not really work for me\n2) We could do better with displaying the group specs in the create and show commands (json and yaml outputs are a bit borked)\nWith that said, I\u0027d be happy to merge this as is and report those two items as bugs!\nThanks again!","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"fd66e091_0c993ded","updated":"2021-12-07 21:23:03.000000000","message":"Victoria, Ashley - please see some comments inline - there are some deficiencies here - some of which could come in a different patch. I\u0027m happy to discuss. It\u0027d be nice to close on this soon so we can stop using the manilaclient in manila\u0027s devstack plugin altogether: https://review.opendev.org/c/openstack/manila/+/820259","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7dc40408ec584f2735f1b6c98ade361d3d8121a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"3c931b3e_29fd8692","in_reply_to":"07b30b0d_785da0c4","updated":"2021-11-30 10:21:03.000000000","message":"Thanks for the review Maari and Carlos, great catch 😊\n\nI should be able to submit a follow up patch with those enhancements.","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"43d85405_7d37fb72","in_reply_to":"3c931b3e_29fd8692","updated":"2021-12-08 11:49:43.000000000","message":"Last famous words, seems we didn\u0027t have group specs filtering on the server side. Submitted a bp [0] and a fix [1]. We will need to push the microversion in the client in order to see the changes. I\u0027ll propose a follow up patch with that if the change in the server side gets merged.\n\n[0] https://blueprints.launchpad.net/manila/+spec/support-group-spec-search-share-group-type-api\n[1] https://review.opendev.org/c/openstack/manila/+/821002","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d86cbe20c201d58c96940e3cfe5e9d923a340e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"07b30b0d_785da0c4","in_reply_to":"b4aae43d_900c4f99","updated":"2021-11-26 14:20:54.000000000","message":"++ :)","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f2f2955034cd97e0db2cf277d8d58093f757464","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"446a1f1d_198933d3","updated":"2021-12-08 20:57:14.000000000","message":"Thanks for the changes Victoria; ran into an error with this change ","commit_id":"9a588e71b6d41077691bbafd347539b9eb3ce732"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8adc0909ee23bd5d71c54eae8353256887c9c860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"f1c79c35_b134d2f8","updated":"2021-12-20 20:33:24.000000000","message":"Carlos just hit this issue and we need to fix this before we merge - again, pretty confused why pep8 isn\u0027t catching these missing imports:\n\n $ openstack share group type list --debug --group-specs fake\n \u003csnip\u003e\n Instantiating Shared File System (share) client: \u003cclass \u0027manilaclient.v2.client.Client\u0027\u003e\n Shared File System API version: API Version Major: 2, Minor: 65\n name \u0027_\u0027 is not defined\n Traceback (most recent call last):\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/utils.py\", line 73, in extract_extra_specs\n    (key, value) \u003d item.split(\u0027\u003d\u0027, 1)\n ValueError: not enough values to unpack (expected 2, got 1)\n\n During handling of the above exception, another exception occurred:\n\n Traceback (most recent call last):\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 402, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/display.py\", line 115, in run\n    column_names, data \u003d self.take_action(parsed_args)\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_types.py\", line 194, in take_action\n    \u0027group_specs\u0027: utils.extract_group_specs(\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/utils.py\", line 96, in extract_group_specs\n    return extract_extra_specs(extra_specs,\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/utils.py\", line 89, in extract_extra_specs\n    msg \u003d LOG.error(_(\nNameError: name \u0027_\u0027 is not defined\nclean_up ListShareGroupType: name \u0027_\u0027 is not defined\nEND return value: 1","commit_id":"836a83a0147c1ec8932c22e17ed4c83f31bf415d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eae954c02f27fef0b19e8e13ce41374bf788f548","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"a1827b8e_913351c8","updated":"2021-12-14 19:56:47.000000000","message":"recheck\n\nThanks for the changes; this CI failure is unrelated; i\u0027ve seen only some jobs failing though, and there\u0027re different packages that failed requirements check each time. ","commit_id":"836a83a0147c1ec8932c22e17ed4c83f31bf415d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f38dbe0b05e60af650b2bb42e91c5529f89f9296","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"868d9629_6c2d048a","in_reply_to":"f1c79c35_b134d2f8","updated":"2021-12-20 20:55:59.000000000","message":"Yep! This should be solved by adding an import to the beginning of the utils file, as mentioned in the comment I left :)","commit_id":"836a83a0147c1ec8932c22e17ed4c83f31bf415d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"9590ba06ec76f813a9663ae9578436c576320c4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"6448c6c4_be20fdf8","updated":"2021-12-21 21:17:41.000000000","message":"LGTM, thanks Victoria. ","commit_id":"fa8a4b03f806676968fccd467f21770cccb73968"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"59fe9433fe2fa3e0ea2de05f7504b3d63e6bfaff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"cecf851d_57f767dc","updated":"2021-12-21 22:55:15.000000000","message":"LGTM. Thank you Victoria and Ashley","commit_id":"fa8a4b03f806676968fccd467f21770cccb73968"}],"doc/source/cli/osc/v2/index.rst":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"8980e0f8096e61b8c53a3e40443fa4a61f6a3ac0","unresolved":true,"context_lines":[{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":160,"context_line":"    :command: share group *"}],"source_content_type":"text/x-rst","patch_set":20,"id":"29b999fe_299db842","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":27},"updated":"2021-10-02 08:52:34.000000000","message":"I believe the share group types will now be listed here as well, we could follow the examples for share snapshot and share instance here to prevent that.","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"e878ccf46b0a0e0c5dc6e3b418c53714b14a2f39","unresolved":true,"context_lines":[{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":160,"context_line":"    :command: share group *"}],"source_content_type":"text/x-rst","patch_set":20,"id":"6f3dd105_96acef91","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":27},"in_reply_to":"29b999fe_299db842","updated":"2021-10-14 12:55:19.000000000","message":"+1 the :command: tag accepts this pattern https://docs.python.org/3/library/fnmatch.html","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c3a8076250488e2da900db8ff4fa44fd58bf8e77","unresolved":false,"context_lines":[{"line_number":157,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":160,"context_line":"    :command: share group *"}],"source_content_type":"text/x-rst","patch_set":20,"id":"c47b3098_feb60a22","line":160,"range":{"start_line":160,"start_character":26,"end_line":160,"end_character":27},"in_reply_to":"6f3dd105_96acef91","updated":"2021-11-19 15:53:11.000000000","message":"Done","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"}],"manilaclient/osc/utils.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    printable_share_group_type.update("},{"line_number":107,"context_line":"        {"},{"line_number":108,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":109,"context_line":"            \u0027group_specs\u0027: format_properties(share_group_type.group_specs),"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"    )"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"be641970_7d4524cf","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":75},"updated":"2021-12-07 21:23:03.000000000","message":"This should only be done if the formatter is \"table\", it breaks the output for json and yaml:\n\n $ openstack share group type show testing  -f json\n{\n  \"id\": \"c995999a-f727-409b-9aa7-2d6a48933cbc\",\n  \"name\": \"testing\",\n  \"share_types\": [\n    \"7bd2526c-b08b-4bba-8e1a-4af6dd0dd2ff\"\n  ],\n  \"visibility\": \"public\",\n  \"is_default\": false,\n  \"group_specs\": \"foo : quuz\\nfoo2 : quuz2\\nbozeman : ohio\"\n}","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    printable_share_group_type.update("},{"line_number":107,"context_line":"        {"},{"line_number":108,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":109,"context_line":"            \u0027group_specs\u0027: format_properties(share_group_type.group_specs),"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"    )"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"e11bc0ad_ba162771","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":75},"in_reply_to":"be641970_7d4524cf","updated":"2021-12-08 11:49:43.000000000","message":"Done","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f2f2955034cd97e0db2cf277d8d58093f757464","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                extra_specs[key] \u003d value"},{"line_number":84,"context_line":"    except ValueError:"},{"line_number":85,"context_line":"        msg \u003d LOG.error(_("},{"line_number":86,"context_line":"            \"Wrong format: specs should be key\u003dvalue pairs.\"))"},{"line_number":87,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":88,"context_line":"    return extra_specs"}],"source_content_type":"text/x-python","patch_set":23,"id":"e2c98e63_958eeaf5","line":85,"range":{"start_line":85,"start_character":14,"end_line":85,"end_character":23},"updated":"2021-12-08 20:57:14.000000000","message":"the linter should have caught this; but LOG isn\u0027t defined in this file:\n\n\nTraceback (most recent call last):\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/utils.py\", line 69, in extract_extra_specs\n    (key, value) \u003d item.split(\u0027\u003d\u0027, 1)\nValueError: not enough values to unpack (expected 2, got 1)\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/opt/stack/python-manilaclient/.tox/py3/lib/python3.8/site-packages/cliff/app.py\", line 402, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/opt/stack/python-manilaclient/.tox/py3/lib/python3.8/site-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/opt/stack/python-manilaclient/.tox/py3/lib/python3.8/site-packages/cliff/display.py\", line 115, in run\n    column_names, data \u003d self.take_action(parsed_args)\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_types.py\", line 194, in take_action\n    \u0027group_specs\u0027: utils.extract_group_specs(\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/utils.py\", line 92, in extract_group_specs\n    return extract_extra_specs(extra_specs,\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/utils.py\", line 85, in extract_extra_specs\n    msg \u003d LOG.error(_(\nNameError: name \u0027LOG\u0027 is not defined\nclean_up ListShareGroupType: name \u0027LOG\u0027 is not defined\nEND return value: 1","commit_id":"9a588e71b6d41077691bbafd347539b9eb3ce732"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a6d984394762ee5723fa3095379bbc6fa1d77ac2","unresolved":true,"context_lines":[{"line_number":82,"context_line":"            else:"},{"line_number":83,"context_line":"                extra_specs[key] \u003d value"},{"line_number":84,"context_line":"    except ValueError:"},{"line_number":85,"context_line":"        msg \u003d LOG.error(_("},{"line_number":86,"context_line":"            \"Wrong format: specs should be key\u003dvalue pairs.\"))"},{"line_number":87,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":88,"context_line":"    return extra_specs"}],"source_content_type":"text/x-python","patch_set":23,"id":"45d24118_7f87aac1","line":85,"range":{"start_line":85,"start_character":14,"end_line":85,"end_character":23},"in_reply_to":"e2c98e63_958eeaf5","updated":"2021-12-13 11:51:25.000000000","message":"Good catch, wondering why the linter didn\u0027t catch this one","commit_id":"9a588e71b6d41077691bbafd347539b9eb3ce732"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f38dbe0b05e60af650b2bb42e91c5529f89f9296","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import logging"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from oslo_utils import strutils"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from manilaclient.common import constants"},{"line_number":20,"context_line":"from manilaclient import exceptions"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"6b359a6b_9f60e087","line":18,"updated":"2021-12-20 20:55:59.000000000","message":"from manilaclient.common._i18n import _","commit_id":"836a83a0147c1ec8932c22e17ed4c83f31bf415d"}],"manilaclient/osc/v2/share_group_type_access.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def take_action(self, parsed_args):"},{"line_number":45,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":48,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"db54324b_3857fdf1","line":46,"updated":"2021-08-26 23:29:45.000000000","message":"wdyt about adding a validation to the project id here as well?\nFor instance: https://review.opendev.org/c/openstack/python-manilaclient/+/805053/9/manilaclient/osc/v2/share_networks.py#70","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c5c163fe0b644d4334805ca8561b3c11bcdf20f9","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def take_action(self, parsed_args):"},{"line_number":45,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":48,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5ad1361f_57f8a186","line":46,"in_reply_to":"6f7d3c19_e14397a8","updated":"2021-09-01 01:07:30.000000000","message":"Yeah, I think that this is a good idea and would make lives easier :)","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf381df30739502bf35e564950837f028e797467","unresolved":true,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def take_action(self, parsed_args):"},{"line_number":45,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":48,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"6f7d3c19_e14397a8","line":46,"in_reply_to":"db54324b_3857fdf1","updated":"2021-08-31 19:14:58.000000000","message":"Sounds good, I\u0027ll add the validation to both access allow and access deny. Also, should we unify and call the option \"project\"? And the user pass the project ID or the project name. IMHO that would be better, but wanna hear your thoughts :)","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def take_action(self, parsed_args):"},{"line_number":110,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":113,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"f5a75342_a677a42c","line":111,"updated":"2021-08-26 23:29:45.000000000","message":"same about project_id validation :)","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf381df30739502bf35e564950837f028e797467","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def take_action(self, parsed_args):"},{"line_number":110,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":113,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"4ab462e1_896f32cc","line":111,"in_reply_to":"f5a75342_a677a42c","updated":"2021-08-31 19:14:58.000000000","message":"Ack","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            help\u003d_(\"Project Name or ID to add share group type access for.\")"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        return parser"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def take_action(self, parsed_args):"},{"line_number":46,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":47,"context_line":"        identity_client \u003d self.app.client_manager.identity"}],"source_content_type":"text/x-python","patch_set":16,"id":"af52e57a_c6845858","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":0},"updated":"2021-09-02 21:19:39.000000000","message":"identity_common.add_project_domain_option_to_parser(parser)","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"08237766faf2fa0c7e4df395e632221c03e3b767","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            help\u003d_(\"Project Name or ID to add share group type access for.\")"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        return parser"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def take_action(self, parsed_args):"},{"line_number":46,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":47,"context_line":"        identity_client \u003d self.app.client_manager.identity"}],"source_content_type":"text/x-python","patch_set":16,"id":"a1c00617_d184a381","line":44,"range":{"start_line":44,"start_character":0,"end_line":44,"end_character":0},"in_reply_to":"af52e57a_c6845858","updated":"2021-09-03 14:06:44.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":49,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":50,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        project_id \u003d identity_common.find_project(identity_client,"},{"line_number":53,"context_line":"                                                  parsed_args.project)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"e78b8d0e_5538d983","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":18},"updated":"2021-09-02 21:19:39.000000000","message":"nit: this is a project, not ID","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"08237766faf2fa0c7e4df395e632221c03e3b767","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":50,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        project_id \u003d identity_common.find_project(identity_client,"},{"line_number":53,"context_line":"                                                  parsed_args.project)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":16,"id":"b7a83727_33f21bdf","line":52,"range":{"start_line":52,"start_character":8,"end_line":52,"end_character":18},"in_reply_to":"e78b8d0e_5538d983","updated":"2021-09-03 14:06:44.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":53,"context_line":"                                                  parsed_args.project)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            share_client.share_group_type_access.add_project_access("},{"line_number":57,"context_line":"                share_group_type,"},{"line_number":58,"context_line":"                project_id)"},{"line_number":59,"context_line":"        except Exception as e:"},{"line_number":60,"context_line":"            raise exceptions.CommandError("},{"line_number":61,"context_line":"                \"Failed to add access to share group type : %s\" % e)"}],"source_content_type":"text/x-python","patch_set":16,"id":"07092b7c_0b77e8f8","line":58,"range":{"start_line":56,"start_character":12,"end_line":58,"end_character":27},"updated":"2021-09-02 21:19:39.000000000","message":"This blows up:\n\n\n  $ openstack --debug  share group type access create newgrouptype demo\n  START with options: --debug share group type access create newgrouptype demo\n  options: Namespace(access_key\u003d\u0027\u0027, access_secret\u003d\u0027***\u0027, access_token\u003d\u0027***\u0027, access_token_endpoint\u003d\u0027\u0027, access_token_type\u003d\u0027\u0027, application_credential_id\u003d\u0027\u0027, application_credential_name\u003d\u0027\u0027, application_credential_secret\u003d\u0027***\u0027, auth_methods\u003d\u0027\u0027, auth_type\u003d\u0027password\u0027, auth_url\u003d\u0027http://openstack.com/identity\u0027, cacert\u003dNone, cert\u003d\u0027\u0027, client_id\u003d\u0027\u0027, client_secret\u003d\u0027***\u0027, cloud\u003d\u0027\u0027, code\u003d\u0027\u0027, consumer_key\u003d\u0027\u0027, consumer_secret\u003d\u0027***\u0027, debug\u003dTrue, default_domain\u003d\u0027default\u0027, default_domain_id\u003d\u0027\u0027, default_domain_name\u003d\u0027\u0027, deferred_help\u003dFalse, discovery_endpoint\u003d\u0027\u0027, domain_id\u003d\u0027\u0027, domain_name\u003d\u0027\u0027, endpoint\u003d\u0027\u0027, identity_provider\u003d\u0027\u0027, identity_provider_url\u003d\u0027\u0027, insecure\u003dNone, interface\u003d\u0027public\u0027, key\u003d\u0027\u0027, log_file\u003dNone, openid_scope\u003d\u0027\u0027, os_beta_command\u003dFalse, os_compute_api_version\u003d\u0027\u0027, os_dns_api_version\u003d\u00272\u0027, os_identity_api_version\u003d\u00273\u0027, os_image_api_version\u003d\u0027\u0027, os_key_manager_api_version\u003d\u00271\u0027, os_network_api_version\u003d\u0027\u0027, os_object_api_version\u003d\u0027\u0027, os_placement_api_version\u003d\u00271\u0027, os_project_id\u003dNone, os_project_name\u003dNone, os_share_api_version\u003d\u00272.63\u0027, os_volume_api_version\u003d\u00273\u0027, passcode\u003d\u0027\u0027, password\u003d\u0027***\u0027, profile\u003d\u0027\u0027, project_domain_id\u003d\u0027default\u0027, project_domain_name\u003d\u0027\u0027, project_id\u003d\u0027\u0027, project_name\u003d\u0027demo\u0027, protocol\u003d\u0027\u0027, redirect_uri\u003d\u0027\u0027, region_name\u003d\u0027RegionOne\u0027, remote_project_domain_id\u003d\u0027\u0027, remote_project_domain_name\u003d\u0027\u0027, remote_project_id\u003d\u0027\u0027, remote_project_name\u003d\u0027\u0027, service_provider\u003d\u0027\u0027, service_provider_endpoint\u003d\u0027\u0027, service_provider_entity_id\u003d\u0027\u0027, system_scope\u003d\u0027\u0027, timing\u003dFalse, token\u003d\u0027***\u0027, trust_id\u003d\u0027\u0027, user_domain_id\u003d\u0027default\u0027, user_domain_name\u003d\u0027\u0027, user_id\u003d\u0027\u0027, username\u003d\u0027admin\u0027, verbose_level\u003d3, verify\u003dNone)\n  \n\u003ctruncated auth stuff\u003e\n\n  run(Namespace(project\u003d\u0027demo\u0027, share_group_type\u003d\u0027newgrouptype\u0027))\n  Instantiating Shared File System (share) client: \u003cclass \u0027manilaclient.v2.client.Client\u0027\u003e\n  Shared File System API version: API Version Major: 2, Minor: 63\n  Instantiating identity client: \u003cclass \u0027keystoneclient.v3.client.Client\u0027\u003e\n\n  REQ: curl -i -X GET http://openstack.com/share/v2/share-group-types?is_public\u003dall -H \"X-Auth-Token: gAAAAABhMTzdiHR2iyiiYmGM6yiN0uZsYdmJU2wolAOuZtoMgWiQIDtgT6DsY-zCNsBsCMdM3_Q6AiX-Ybpa6AKOSbggeSYFOjbwYce_Bv_1ZvYIO6K5tkzN2xuugrp96-gQd82gl0q9FfRXKwB5RHT6ybUQaGr3-sE8o0WHmh1F5Zld3qXBoDs\" -H \"X-Openstack-Manila-Api-Version: 2.63\" -H \"User-Agent: python-manilaclient\" -H \"Accept: application/json\"\n\n\n  REQ: curl -i -X GET http://openstack.com/share/v2/share-group-types?is_public\u003dall -H \"X-Auth-Token: gAAAAABhMTzdiHR2iyiiYmGM6yiN0uZsYdmJU2wolAOuZtoMgWiQIDtgT6DsY-zCNsBsCMdM3_Q6AiX-Ybpa6AKOSbggeSYFOjbwYce_Bv_1ZvYIO6K5tkzN2xuugrp96-gQd82gl0q9FfRXKwB5RHT6ybUQaGr3-sE8o0WHmh1F5Zld3qXBoDs\" -H \"X-Openstack-Manila-Api-Version: 2.63\" -H \"User-Agent: python-manilaclient\" -H \"Accept: application/json\"\n\n  Starting new HTTP connection (1): openstack.com:80\n  http://openstack.com:80 \"GET /share/v2/share-group-types?is_public\u003dall HTTP/1.1\" 200 697\n  RESP: [200] {\u0027Date\u0027: \u0027Thu, 02 Sep 2021 21:06:38 GMT\u0027, \u0027Server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Content-Length\u0027: \u0027697\u0027, \u0027x-compute-request-id\u0027: \u0027req-1e8dbb7d-4d2c-426c-af68-5bac0924e4cd\u0027, \u0027X-OpenStack-Manila-API-Version\u0027: \u00272.63\u0027, \u0027Vary\u0027: \u0027X-OpenStack-Manila-API-Version\u0027, \u0027Connection\u0027: \u0027close\u0027}\n  RESP BODY: {\"share_group_types\": [{\"id\": \"93d78c54-d25a-472d-ae81-442312ce5f4b\", \"name\": \"default\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": true}, {\"id\": \"55996fe8-1cbe-40d4-9abf-e8876a9cb2fe\", \"name\": \"ghc-share-group-type\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\", \"50df8b97-00c9-40cc-b30b-6d4cc958424f\"], \"is_default\": false}, {\"id\": \"cdada84d-a834-45de-bfc2-7e9d3d269868\", \"name\": \"newgrouptype\", \"is_public\": false, \"group_specs\": {\"foo\": \"bar2\", \"qu2\": \"baz\"}, \"share_types\": [\"50df8b97-00c9-40cc-b30b-6d4cc958424f\", \"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": false}]}\n\n  RESP: [200] {\u0027Date\u0027: \u0027Thu, 02 Sep 2021 21:06:38 GMT\u0027, \u0027Server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Content-Length\u0027: \u0027697\u0027, \u0027x-compute-request-id\u0027: \u0027req-1e8dbb7d-4d2c-426c-af68-5bac0924e4cd\u0027, \u0027X-OpenStack-Manila-API-Version\u0027: \u00272.63\u0027, \u0027Vary\u0027: \u0027X-OpenStack-Manila-API-Version\u0027, \u0027Connection\u0027: \u0027close\u0027}\n  RESP BODY: {\"share_group_types\": [{\"id\": \"93d78c54-d25a-472d-ae81-442312ce5f4b\", \"name\": \"default\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": true}, {\"id\": \"55996fe8-1cbe-40d4-9abf-e8876a9cb2fe\", \"name\": \"ghc-share-group-type\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\", \"50df8b97-00c9-40cc-b30b-6d4cc958424f\"], \"is_default\": false}, {\"id\": \"cdada84d-a834-45de-bfc2-7e9d3d269868\", \"name\": \"newgrouptype\", \"is_public\": false, \"group_specs\": {\"foo\": \"bar2\", \"qu2\": \"baz\"}, \"share_types\": [\"50df8b97-00c9-40cc-b30b-6d4cc958424f\", \"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": false}]}\n\n\n  REQ: curl -i -X GET http://openstack.com/share/v2/share-group-types?is_public\u003dall -H \"X-Auth-Token: gAAAAABhMTzdiHR2iyiiYmGM6yiN0uZsYdmJU2wolAOuZtoMgWiQIDtgT6DsY-zCNsBsCMdM3_Q6AiX-Ybpa6AKOSbggeSYFOjbwYce_Bv_1ZvYIO6K5tkzN2xuugrp96-gQd82gl0q9FfRXKwB5RHT6ybUQaGr3-sE8o0WHmh1F5Zld3qXBoDs\" -H \"X-Openstack-Manila-Api-Version: 2.63\" -H \"User-Agent: python-manilaclient\" -H \"Accept: application/json\"\n\n\n  REQ: curl -i -X GET http://openstack.com/share/v2/share-group-types?is_public\u003dall -H \"X-Auth-Token: gAAAAABhMTzdiHR2iyiiYmGM6yiN0uZsYdmJU2wolAOuZtoMgWiQIDtgT6DsY-zCNsBsCMdM3_Q6AiX-Ybpa6AKOSbggeSYFOjbwYce_Bv_1ZvYIO6K5tkzN2xuugrp96-gQd82gl0q9FfRXKwB5RHT6ybUQaGr3-sE8o0WHmh1F5Zld3qXBoDs\" -H \"X-Openstack-Manila-Api-Version: 2.63\" -H \"User-Agent: python-manilaclient\" -H \"Accept: application/json\"\n\n  Starting new HTTP connection (1): openstack.com:80\n  http://openstack.com:80 \"GET /share/v2/share-group-types?is_public\u003dall HTTP/1.1\" 200 697\n  RESP: [200] {\u0027Date\u0027: \u0027Thu, 02 Sep 2021 21:06:43 GMT\u0027, \u0027Server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Content-Length\u0027: \u0027697\u0027, \u0027x-compute-request-id\u0027: \u0027req-2a0b29bc-1673-43ac-ba08-2669fb43ac9f\u0027, \u0027X-OpenStack-Manila-API-Version\u0027: \u00272.63\u0027, \u0027Vary\u0027: \u0027X-OpenStack-Manila-API-Version\u0027, \u0027Connection\u0027: \u0027close\u0027}\n  RESP BODY: {\"share_group_types\": [{\"id\": \"93d78c54-d25a-472d-ae81-442312ce5f4b\", \"name\": \"default\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": true}, {\"id\": \"55996fe8-1cbe-40d4-9abf-e8876a9cb2fe\", \"name\": \"ghc-share-group-type\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\", \"50df8b97-00c9-40cc-b30b-6d4cc958424f\"], \"is_default\": false}, {\"id\": \"cdada84d-a834-45de-bfc2-7e9d3d269868\", \"name\": \"newgrouptype\", \"is_public\": false, \"group_specs\": {\"foo\": \"bar2\", \"qu2\": \"baz\"}, \"share_types\": [\"50df8b97-00c9-40cc-b30b-6d4cc958424f\", \"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": false}]}\n\n  RESP: [200] {\u0027Date\u0027: \u0027Thu, 02 Sep 2021 21:06:43 GMT\u0027, \u0027Server\u0027: \u0027Apache/2.4.41 (Ubuntu)\u0027, \u0027Content-Type\u0027: \u0027application/json\u0027, \u0027Content-Length\u0027: \u0027697\u0027, \u0027x-compute-request-id\u0027: \u0027req-2a0b29bc-1673-43ac-ba08-2669fb43ac9f\u0027, \u0027X-OpenStack-Manila-API-Version\u0027: \u00272.63\u0027, \u0027Vary\u0027: \u0027X-OpenStack-Manila-API-Version\u0027, \u0027Connection\u0027: \u0027close\u0027}\n  RESP BODY: {\"share_group_types\": [{\"id\": \"93d78c54-d25a-472d-ae81-442312ce5f4b\", \"name\": \"default\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": true}, {\"id\": \"55996fe8-1cbe-40d4-9abf-e8876a9cb2fe\", \"name\": \"ghc-share-group-type\", \"is_public\": true, \"group_specs\": {}, \"share_types\": [\"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\", \"50df8b97-00c9-40cc-b30b-6d4cc958424f\"], \"is_default\": false}, {\"id\": \"cdada84d-a834-45de-bfc2-7e9d3d269868\", \"name\": \"newgrouptype\", \"is_public\": false, \"group_specs\": {\"foo\": \"bar2\", \"qu2\": \"baz\"}, \"share_types\": [\"50df8b97-00c9-40cc-b30b-6d4cc958424f\", \"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": false}]}\n\n  REQ: curl -g -i -X GET http://openstack.com/identity/v3/projects/demo -H \"Accept: application/json\" -H \"User-Agent: python-keystoneclient\" -H \"X-Auth-Token: {SHA256}ce988a3dc7bbf4245666de26a37946fff976f2825dea3619f5415ded833a34bd\"\n  Resetting dropped connection: openstack.com\n  http://openstack.com:80 \"GET /identity/v3/projects/demo HTTP/1.1\" 404 85\n  RESP: [404] Connection: close Content-Length: 85 Content-Type: application/json Date: Thu, 02 Sep 2021 21:06:44 GMT Server: Apache/2.4.41 (Ubuntu) Vary: X-Auth-Token x-openstack-request-id: req-07f8ce32-1600-40f9-a17c-25a938195db1\n  RESP BODY: {\"error\":{\"code\":404,\"message\":\"Could not find project: demo.\",\"title\":\"Not Found\"}}\n\n  GET call to identity for http://openstack.com/identity/v3/projects/demo used request id req-07f8ce32-1600-40f9-a17c-25a938195db1\n  Request returned failure status: 404\n  REQ: curl -g -i -X GET http://openstack.com/identity/v3/projects?name\u003ddemo -H \"Accept: application/json\" -H \"User-Agent: python-keystoneclient\" -H \"X-Auth-Token: {SHA256}ce988a3dc7bbf4245666de26a37946fff976f2825dea3619f5415ded833a34bd\"\n  Resetting dropped connection: openstack.com\n  http://openstack.com:80 \"GET /identity/v3/projects?name\u003ddemo HTTP/1.1\" 200 407\n  RESP: [200] Connection: close Content-Length: 407 Content-Type: application/json Date: Thu, 02 Sep 2021 21:06:45 GMT Server: Apache/2.4.41 (Ubuntu) Vary: X-Auth-Token x-openstack-request-id: req-b7428b1b-16d2-4a88-9bb8-5ac976f06776\n  RESP BODY: {\"projects\": [{\"id\": \"af2838436f3f4cf6896399dd97c4c050\", \"name\": \"demo\", \"domain_id\": \"default\", \"description\": \"\", \"enabled\": true, \"parent_id\": \"default\", \"is_domain\": false, \"tags\": [], \"options\": {}, \"links\": {\"self\": \"http://openstack.com/identity/v3/projects/af2838436f3f4cf6896399dd97c4c050\"}}], \"links\": {\"next\": null, \"self\": \"http://openstack.com/identity/v3/projects?name\u003ddemo\", \"previous\": null}}\n\n  GET call to identity for http://openstack.com/identity/v3/projects?name\u003ddemo used request id req-b7428b1b-16d2-4a88-9bb8-5ac976f06776\n  /usr/local/lib/python3.8/dist-packages/oslo_serialization/jsonutils.py:180: UserWarning: Cannot convert \u003cProject description\u003d, domain_id\u003ddefault, enabled\u003dTrue, id\u003daf2838436f3f4cf6896399dd97c4c050, is_domain\u003dFalse, links\u003d{\u0027self\u0027: \u0027http://openstack.com/identity/v3/projects/af2838436f3f4cf6896399dd97c4c050\u0027}, name\u003ddemo, options\u003d{}, parent_id\u003ddefault, tags\u003d[]\u003e to primitive, will raise ValueError instead of warning in version 3.0\n    warnings.warn(\"Cannot convert %r to primitive, will raise ValueError \"\n  Failed to add access to share group type : Circular reference detected\n  Traceback (most recent call last):\n    File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_type_access.py\", line 56, in take_action\n      share_client.share_group_type_access.add_project_access(\n    File \"/opt/stack/python-manilaclient/manilaclient/api_versions.py\", line 399, in substitution\n      return method.func(obj, *args, **kwargs)\n    File \"/opt/stack/python-manilaclient/manilaclient/v2/share_group_type_access.py\", line 66, in add_project_access\n      self._action(\u0027addProjectAccess\u0027, share_group_type, info)\n    File \"/opt/stack/python-manilaclient/manilaclient/v2/share_group_type_access.py\", line 87, in _action\n      return self.api.client.post(url, body\u003dbody)\n    File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 187, in post\n      return self._cs_request(url, \u0027POST\u0027, **kwargs)\n    File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 143, in _cs_request\n      return self._cs_request_with_retries(\n    File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 160, in _cs_request_with_retries\n      resp, body \u003d self.request(url, method, **kwargs)\n    File \"/opt/stack/python-manilaclient/manilaclient/common/httpclient.py\", line 123, in request\n      options[\u0027data\u0027] \u003d jsonutils.dumps(kwargs[\u0027body\u0027])\n    File \"/usr/local/lib/python3.8/dist-packages/oslo_serialization/jsonutils.py\", line 202, in dumps\n      return json.dumps(obj, default\u003ddefault, **kwargs)\n    File \"/usr/lib/python3.8/json/__init__.py\", line 234, in dumps\n      return cls(\n    File \"/usr/lib/python3.8/json/encoder.py\", line 199, in encode\n      chunks \u003d self.iterencode(o, _one_shot\u003dTrue)\n    File \"/usr/lib/python3.8/json/encoder.py\", line 257, in iterencode\n      return _iterencode(o, 0)\n  ValueError: Circular reference detected\n\n  During handling of the above exception, another exception occurred:\n\n  Traceback (most recent call last):\n    File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 402, in run_subcommand\n      result \u003d cmd.run(parsed_args)\n    File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n      return super(Command, self).run(parsed_args)\n    File \"/usr/local/lib/python3.8/dist-packages/cliff/command.py\", line 185, in run\n      return_code \u003d self.take_action(parsed_args) or 0\n    File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_type_access.py\", line 60, in take_action\n      raise exceptions.CommandError(\n  osc_lib.exceptions.CommandError: Failed to add access to share group type : Circular reference detected\n  clean_up ShareGroupTypeAccessAllow: Failed to add access to share group type : Circular reference detected\n  END return value: 1","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"08237766faf2fa0c7e4df395e632221c03e3b767","unresolved":true,"context_lines":[{"line_number":53,"context_line":"                                                  parsed_args.project)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"        try:"},{"line_number":56,"context_line":"            share_client.share_group_type_access.add_project_access("},{"line_number":57,"context_line":"                share_group_type,"},{"line_number":58,"context_line":"                project_id)"},{"line_number":59,"context_line":"        except Exception as e:"},{"line_number":60,"context_line":"            raise exceptions.CommandError("},{"line_number":61,"context_line":"                \"Failed to add access to share group type : %s\" % e)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1b16ae0b_ac4b15ad","line":58,"range":{"start_line":56,"start_character":12,"end_line":58,"end_character":27},"in_reply_to":"07092b7c_0b77e8f8","updated":"2021-09-03 14:06:44.000000000","message":"Ouch","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"650d5148_87a5737e","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"updated":"2021-09-02 21:19:39.000000000","message":"remove underscore\n\nAlso, can we prettify this to project name and ID?","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d33c2f390edc2b03c4341c2cdf3de5e42ffc58e2","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"c455d5e9_88fc7671","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"08cacf8a_438590bc","updated":"2021-09-06 15:13:28.000000000","message":"Gotcha","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"b46cc1b6cf0e9e72c2b66e54c05f75b7bd2e6d3f","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"69bdb837_12d46c62","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"2d015a4a_9baf4da6","updated":"2021-09-20 12:33:24.000000000","message":"Very well, let\u0027s file a blueprint (in osc-lib, right?) and we can get this one in","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"08237766faf2fa0c7e4df395e632221c03e3b767","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"710c9729_389005c0","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"650d5148_87a5737e","updated":"2021-09-03 14:06:44.000000000","message":"What do you mean with prettify? Is there any example?","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"4fcbd1df56cbd87318919a487a0bad15bcda4950","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"1d7e26fc_a2177437","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"69bdb837_12d46c62","updated":"2021-09-20 12:40:40.000000000","message":"https://blueprints.launchpad.net/python-openstackclient/+spec/show-project-names-and-ids","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"25f21ab003a675bc612bc7b9ccf95d80896f4501","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"08cacf8a_438590bc","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"710c9729_389005c0","updated":"2021-09-03 17:51:28.000000000","message":"I\u0027m not sure there is, we can work on this later as well - \n\nManila just respects project_ids and not names, but thats not really end user friendly - i was thinking we can loop through the projects in the data that comes back, and resolve the names with the help of keystone, and then create a new column with project name before displaying the result.","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51acf4d15dec5b02580a9e1d179adb530a1b3b69","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"dd0b26b0_39956eb9","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"c455d5e9_88fc7671","updated":"2021-09-14 15:35:00.000000000","message":"Discussing about this a bit with gtema, we shared some interesting thoughts\n\n1. Performance will be hurt by adding the project obj search\n2. Other implementations on the openstack client are limited to return what the API returns. There are some especial cases (e.g. server info is extended with flavor details). No other service is extending project id with project name as we are intending to do.\n3. The user might not really have priviliges to list/find project. This is unlikely, but could happen.\n\nWDYT?","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8cb26c70fde5e05cad8f1614b6e11512be865aeb","unresolved":true,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        data \u003d share_client.share_group_type_access.list(share_group_type)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        columns \u003d [\u0027Project_ID\u0027]"},{"line_number":90,"context_line":"        values \u003d (oscutils.get_item_properties(s, columns) for s in data)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return (columns, values)"}],"source_content_type":"text/x-python","patch_set":16,"id":"2d015a4a_9baf4da6","line":89,"range":{"start_line":89,"start_character":20,"end_line":89,"end_character":30},"in_reply_to":"dd0b26b0_39956eb9","updated":"2021-09-14 20:02:20.000000000","message":"Hi Victoria, \n\nThanks! Yes, all good points to consider:\n\n\u003e 1. Performance will be hurt by adding the project obj search\n\nYes, it\u0027ll slow things down for sure. keystone for example has a \"--names\" option to list names of projects (and users, domains) instead of IDs in commands such as https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/role-assignment.html\n\nThe problem with displaying IDs is that its not as user-friendly in the CLI. We always accept project names as input in all the \"openstack share\" commands and we convert it into IDs before sending the request to manila - so this is in theory not slower than that. \n\n\u003e 2. Other implementations on the openstack client are limited to return what the API returns. There are some especial cases (e.g. server info is extended with flavor details). No other service is extending project id with project name as we are intending to do.\n\nI see; perhaps an improvement that we can suggest everywhere if we figure out what needs to be done 😊. I like the idea that you wanted to optimize this and add a helper within osc_lib. \n\n\n\u003e 3. The user might not really have priviliges to list/find project. This is unlikely, but could happen.\nBy default we expect cloud users with the system admin role to be able to interact with group types (and share types). Users that access this command should also have access to the projects API from Keystone.\n\n\nThat said, i don\u0027t mind us creating an RFE for this and getting this patch in without project names.","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":35,"context_line":"            metavar\u003d\"\u003cshare-group-type\u003e\","},{"line_number":36,"context_line":"            help\u003d_(\"Share group type name or ID to allow access to.\")"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        parser.add_argument("},{"line_number":39,"context_line":"            \u0027project\u0027,"},{"line_number":40,"context_line":"            metavar\u003d\"\u003cproject\u003e\","},{"line_number":41,"context_line":"            help\u003d_(\"Project Name or ID to add share group type access for.\")"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":44,"context_line":"        return parser"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"d7a3005a_f681be98","line":42,"range":{"start_line":38,"start_character":8,"end_line":42,"end_character":9},"updated":"2021-12-07 21:23:03.000000000","message":"This could be repeatable to add access at once to multiple projects","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            metavar\u003d\"\u003cshare-group-type\u003e\","},{"line_number":36,"context_line":"            help\u003d_(\"Share group type name or ID to allow access to.\")"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        parser.add_argument("},{"line_number":39,"context_line":"            \u0027project\u0027,"},{"line_number":40,"context_line":"            metavar\u003d\"\u003cproject\u003e\","},{"line_number":41,"context_line":"            help\u003d_(\"Project Name or ID to add share group type access for.\")"},{"line_number":42,"context_line":"        )"},{"line_number":43,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":44,"context_line":"        return parser"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"a36a4daa_c691ff26","line":42,"range":{"start_line":38,"start_character":8,"end_line":42,"end_character":9},"in_reply_to":"d7a3005a_f681be98","updated":"2021-12-08 11:49:43.000000000","message":"Ack","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        project_obj \u003d identity_common.find_project(identity_client,"},{"line_number":54,"context_line":"                                                   parsed_args.project)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            share_client.share_group_type_access.add_project_access("}],"source_content_type":"text/x-python","patch_set":22,"id":"3b174032_721aff5b","line":54,"range":{"start_line":54,"start_character":70,"end_line":54,"end_character":71},"updated":"2021-12-07 21:23:03.000000000","message":"The domain name must be passed here: https://opendev.org/openstack/osc-lib/src/commit/415a6c7b191ac665fb7763d12d1b427b7b630586/osc_lib/cli/identity.py#L39","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        project_obj \u003d identity_common.find_project(identity_client,"},{"line_number":54,"context_line":"                                                   parsed_args.project)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            share_client.share_group_type_access.add_project_access("}],"source_content_type":"text/x-python","patch_set":22,"id":"d5f90a19_7712fee4","line":54,"range":{"start_line":54,"start_character":70,"end_line":54,"end_character":71},"in_reply_to":"3b174032_721aff5b","updated":"2021-12-08 11:49:43.000000000","message":"We need to assume same domain for all the projects passed as param, do you agree?","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f2f2955034cd97e0db2cf277d8d58093f757464","unresolved":true,"context_lines":[{"line_number":51,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        project_obj \u003d identity_common.find_project(identity_client,"},{"line_number":54,"context_line":"                                                   parsed_args.project)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            share_client.share_group_type_access.add_project_access("}],"source_content_type":"text/x-python","patch_set":22,"id":"ef2a63f0_3af9f7c7","line":54,"range":{"start_line":54,"start_character":70,"end_line":54,"end_character":71},"in_reply_to":"d5f90a19_7712fee4","updated":"2021-12-08 20:57:14.000000000","message":"Yep :)","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":104,"context_line":"            metavar\u003d\"\u003cshare-group-type\u003e\","},{"line_number":105,"context_line":"            help\u003d_(\"Share group type name or ID to deny access from\")"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \u0027project\u0027,"},{"line_number":109,"context_line":"            metavar\u003d\"\u003cproject\u003e\","},{"line_number":110,"context_line":"            help\u003d_(\"Project Name or ID to deny share group type access for.\")"},{"line_number":111,"context_line":"        )"},{"line_number":112,"context_line":"        identity_common.add_project_domain_option_to_parser(parser)"},{"line_number":113,"context_line":"        return parser"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"2e7489b5_b60b2941","line":111,"range":{"start_line":107,"start_character":8,"end_line":111,"end_character":9},"updated":"2021-12-07 21:23:03.000000000","message":"This could be repeatable to allow denying multiple projects at once..","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        share_group_type \u003d apiutils.find_resource("},{"line_number":120,"context_line":"            share_client.share_group_types, parsed_args.share_group_type)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        project_obj \u003d identity_common.find_project(identity_client,"},{"line_number":123,"context_line":"                                                   parsed_args.project)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            share_client.share_group_type_access.remove_project_access("}],"source_content_type":"text/x-python","patch_set":22,"id":"072e0df8_50fffe9b","line":123,"range":{"start_line":122,"start_character":51,"end_line":123,"end_character":71},"updated":"2021-12-07 21:23:03.000000000","message":"pass domain name or ID","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f2f2955034cd97e0db2cf277d8d58093f757464","unresolved":true,"context_lines":[{"line_number":59,"context_line":"                share_client.share_group_type_access.add_project_access("},{"line_number":60,"context_line":"                    share_group_type, project_obj.id)"},{"line_number":61,"context_line":"            except Exception as e:"},{"line_number":62,"context_line":"                raise exceptions.CommandError("},{"line_number":63,"context_line":"                    \"Failed to add access to share group type : %s\" % e)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class ListShareGroupTypeAccess(command.Lister):"}],"source_content_type":"text/x-python","patch_set":23,"id":"3ee1fc59_91f44604","line":63,"range":{"start_line":62,"start_character":16,"end_line":63,"end_character":72},"updated":"2021-12-08 20:57:14.000000000","message":"this will bail out at the first error; without processing the rest of the loop.. we should handle this like the loop we use when deleting multiple share group types","commit_id":"9a588e71b6d41077691bbafd347539b9eb3ce732"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"a6d984394762ee5723fa3095379bbc6fa1d77ac2","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                share_client.share_group_type_access.add_project_access("},{"line_number":60,"context_line":"                    share_group_type, project_obj.id)"},{"line_number":61,"context_line":"            except Exception as e:"},{"line_number":62,"context_line":"                raise exceptions.CommandError("},{"line_number":63,"context_line":"                    \"Failed to add access to share group type : %s\" % e)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"class ListShareGroupTypeAccess(command.Lister):"}],"source_content_type":"text/x-python","patch_set":23,"id":"b5aee8c1_757a3e0f","line":63,"range":{"start_line":62,"start_character":16,"end_line":63,"end_character":72},"in_reply_to":"3ee1fc59_91f44604","updated":"2021-12-13 11:51:25.000000000","message":"Ack","commit_id":"9a588e71b6d41077691bbafd347539b9eb3ce732"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"830b5a1a9c8e5b6d858d12377e49b84ad06f10c6","unresolved":true,"context_lines":[{"line_number":66,"context_line":"                    \"to share group type with name or ID \""},{"line_number":67,"context_line":"                    \"\u0027%(share_group_type)s\u0027: %(e)s\"),"},{"line_number":68,"context_line":"                    {\u0027project\u0027: project,"},{"line_number":69,"context_line":"                     \u0027share_type\u0027: share_group_type, \u0027e\u0027: e})"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if result \u003e 0:"},{"line_number":72,"context_line":"            total \u003d len(parsed_args.projects)"}],"source_content_type":"text/x-python","patch_set":24,"id":"d34bf344_39187cc0","line":69,"range":{"start_line":69,"start_character":22,"end_line":69,"end_character":32},"updated":"2021-12-13 19:17:07.000000000","message":"Fails, this has to be: share_group_type\n\n\n$ openstack share group type access create testing2 demo testing foreign\n/usr/lib/python3/dist-packages/secretstorage/dhcrypto.py:15: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\n  from cryptography.utils import int_from_bytes\n/usr/lib/python3/dist-packages/secretstorage/util.py:19: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\n  from cryptography.utils import int_from_bytes\n--- Logging error ---\nTraceback (most recent call last):\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/utils/__init__.py\", line 241, in find_resource\n    return manager.find(**kwargs)\n  File \"/usr/local/lib/python3.8/dist-packages/keystoneclient/v3/projects.py\", line 225, in find\n    p \u003d super(ProjectManager, self).find(**kwargs)\n  File \"/usr/local/lib/python3.8/dist-packages/keystoneclient/base.py\", line 86, in func\n    return f(*args, **new_kwargs)\n  File \"/usr/local/lib/python3.8/dist-packages/keystoneclient/base.py\", line 504, in find\n    raise ksa_exceptions.NotFound(404, msg)\nkeystoneauth1.exceptions.http.NotFound: 404 (HTTP 404)\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_type_access.py\", line 57, in take_action\n    project_obj \u003d identity_common.find_project(\n  File \"/usr/local/lib/python3.8/dist-packages/openstackclient/identity/common.py\", line 161, in find_project\n    return _find_identity_resource(identity_client.projects, name_or_id,\n  File \"/usr/local/lib/python3.8/dist-packages/openstackclient/identity/common.py\", line 206, in _find_identity_resource\n    identity_resource \u003d utils.find_resource(identity_client_manager,\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/utils/__init__.py\", line 251, in find_resource\n    raise exceptions.CommandError(msg % {\nosc_lib.exceptions.CommandError: No project with a name or ID of \u0027testing\u0027 exists.\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 1085, in emit\n    msg \u003d self.format(record)\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 929, in format\n    return fmt.format(record)\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 668, in format\n    record.message \u003d record.getMessage()\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 373, in getMessage\n    msg \u003d msg % self.args\nKeyError: \u0027share_group_type\u0027\nCall stack:\n  File \"/usr/local/bin/openstack\", line 8, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/usr/local/lib/python3.8/dist-packages/openstackclient/shell.py\", line 145, in main\n    return OpenStackShell().run(argv)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/shell.py\", line 134, in run\n    ret_val \u003d super(OpenStackShell, self).run(argv)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 277, in run\n    result \u003d self.run_subcommand(remainder)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/shell.py\", line 174, in run_subcommand\n    ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 402, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/command.py\", line 185, in run\n    return_code \u003d self.take_action(parsed_args) or 0\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_type_access.py\", line 64, in take_action\n    LOG.error(_(\nMessage: \"Failed to allow access for project \u0027%(project)s\u0027 to share group type with name or ID \u0027%(share_group_type)s\u0027: %(e)s\"\nArguments: {\u0027project\u0027: \u0027testing\u0027, \u0027share_type\u0027: \u003cShare Group Type: testing2\u003e, \u0027e\u0027: CommandError(\"No project with a name or ID of \u0027testing\u0027 exists.\")}\n--- Logging error ---\nTraceback (most recent call last):\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/utils/__init__.py\", line 241, in find_resource\n    return manager.find(**kwargs)\n  File \"/usr/local/lib/python3.8/dist-packages/keystoneclient/v3/projects.py\", line 225, in find\n    p \u003d super(ProjectManager, self).find(**kwargs)\n  File \"/usr/local/lib/python3.8/dist-packages/keystoneclient/base.py\", line 86, in func\n    return f(*args, **new_kwargs)\n  File \"/usr/local/lib/python3.8/dist-packages/keystoneclient/base.py\", line 504, in find\n    raise ksa_exceptions.NotFound(404, msg)\nkeystoneauth1.exceptions.http.NotFound: 404 (HTTP 404)\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_type_access.py\", line 57, in take_action\n    project_obj \u003d identity_common.find_project(\n  File \"/usr/local/lib/python3.8/dist-packages/openstackclient/identity/common.py\", line 161, in find_project\n    return _find_identity_resource(identity_client.projects, name_or_id,\n  File \"/usr/local/lib/python3.8/dist-packages/openstackclient/identity/common.py\", line 206, in _find_identity_resource\n    identity_resource \u003d utils.find_resource(identity_client_manager,\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/utils/__init__.py\", line 251, in find_resource\n    raise exceptions.CommandError(msg % {\nosc_lib.exceptions.CommandError: No project with a name or ID of \u0027foreign\u0027 exists.\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 1085, in emit\n    msg \u003d self.format(record)\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 929, in format\n    return fmt.format(record)\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 668, in format\n    record.message \u003d record.getMessage()\n  File \"/usr/lib/python3.8/logging/__init__.py\", line 373, in getMessage\n    msg \u003d msg % self.args\nKeyError: \u0027share_group_type\u0027\nCall stack:\n  File \"/usr/local/bin/openstack\", line 8, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/usr/local/lib/python3.8/dist-packages/openstackclient/shell.py\", line 145, in main\n    return OpenStackShell().run(argv)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/shell.py\", line 134, in run\n    ret_val \u003d super(OpenStackShell, self).run(argv)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 277, in run\n    result \u003d self.run_subcommand(remainder)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/shell.py\", line 174, in run_subcommand\n    ret_value \u003d super(OpenStackShell, self).run_subcommand(argv)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 402, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/command.py\", line 185, in run\n    return_code \u003d self.take_action(parsed_args) or 0\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_type_access.py\", line 64, in take_action\n    LOG.error(_(\nMessage: \"Failed to allow access for project \u0027%(project)s\u0027 to share group type with name or ID \u0027%(share_group_type)s\u0027: %(e)s\"\nArguments: {\u0027project\u0027: \u0027foreign\u0027, \u0027share_type\u0027: \u003cShare Group Type: testing2\u003e, \u0027e\u0027: CommandError(\"No project with a name or ID of \u0027foreign\u0027 exists.\")}\n2 of 3 allow accesses failed to be applied.","commit_id":"d921472dc282c55495d516465138d1f4589b3ca1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"830b5a1a9c8e5b6d858d12377e49b84ad06f10c6","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        if result \u003e 0:"},{"line_number":72,"context_line":"            total \u003d len(parsed_args.projects)"},{"line_number":73,"context_line":"            msg \u003d (_(\"%(result)s of %(total)s allow accesses failed \""},{"line_number":74,"context_line":"                   \"to be applied.\") % {\u0027result\u0027: result, \u0027total\u0027: total})"},{"line_number":75,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"3a30bf23_f0ca13ae","line":74,"range":{"start_line":73,"start_character":21,"end_line":74,"end_character":35},"updated":"2021-12-13 19:17:07.000000000","message":"Failed to allow access to %(result)s of %(total)s projects.","commit_id":"d921472dc282c55495d516465138d1f4589b3ca1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"830b5a1a9c8e5b6d858d12377e49b84ad06f10c6","unresolved":true,"context_lines":[{"line_number":152,"context_line":"                    \"to share group type with name or ID \""},{"line_number":153,"context_line":"                    \"\u0027%(share_group_type)s\u0027: %(e)s\"),"},{"line_number":154,"context_line":"                    {\u0027project\u0027: project,"},{"line_number":155,"context_line":"                     \u0027share_type\u0027: share_group_type, \u0027e\u0027: e})"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if result \u003e 0:"},{"line_number":158,"context_line":"            total \u003d len(parsed_args.projects)"}],"source_content_type":"text/x-python","patch_set":24,"id":"2fb08ced_19eab19f","line":155,"range":{"start_line":155,"start_character":22,"end_line":155,"end_character":32},"updated":"2021-12-13 19:17:07.000000000","message":"share_group_type","commit_id":"d921472dc282c55495d516465138d1f4589b3ca1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"830b5a1a9c8e5b6d858d12377e49b84ad06f10c6","unresolved":true,"context_lines":[{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        if result \u003e 0:"},{"line_number":158,"context_line":"            total \u003d len(parsed_args.projects)"},{"line_number":159,"context_line":"            msg \u003d (_(\"%(result)s of %(total)s deny accesses failed \""},{"line_number":160,"context_line":"                   \"to be applied.\") % {\u0027result\u0027: result, \u0027total\u0027: total})"},{"line_number":161,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":24,"id":"37609ec8_0a9dffbf","line":160,"range":{"start_line":159,"start_character":21,"end_line":160,"end_character":34},"updated":"2021-12-13 19:17:07.000000000","message":"Failed to deny access to %(result)s of %(total)s projects","commit_id":"d921472dc282c55495d516465138d1f4589b3ca1"}],"manilaclient/osc/v2/share_group_types.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":71,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":72,"context_line":"            nargs\u003d\"+\","},{"line_number":73,"context_line":"            default\u003dNone,"},{"line_number":74,"context_line":"            help\u003d_(\"Comma-separated list of share types names or IDs.\"),"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \"--group-specs\","}],"source_content_type":"text/x-python","patch_set":13,"id":"f46768e7_aa3e53bf","line":74,"range":{"start_line":74,"start_character":19,"end_line":74,"end_character":70},"updated":"2021-08-26 23:29:45.000000000","message":"Perhaps this message could be changed to something like: List of share type names or IDs...\nI have performed a test considering the help and this happened:\nPlease see: https://paste.openstack.org/show/808364/\nIn the above example, I have used commas to separate the share types...\nWhen I tried specifying share types with spaces between them, and without a comma, it worked:\nhttps://paste.openstack.org/show/808365/","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf381df30739502bf35e564950837f028e797467","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":72,"context_line":"            nargs\u003d\"+\","},{"line_number":73,"context_line":"            default\u003dNone,"},{"line_number":74,"context_line":"            help\u003d_(\"Comma-separated list of share types names or IDs.\"),"},{"line_number":75,"context_line":"        )"},{"line_number":76,"context_line":"        parser.add_argument("},{"line_number":77,"context_line":"            \"--group-specs\","}],"source_content_type":"text/x-python","patch_set":13,"id":"cf201b4f_7dbb7b28","line":74,"range":{"start_line":74,"start_character":19,"end_line":74,"end_character":70},"in_reply_to":"f46768e7_aa3e53bf","updated":"2021-08-31 19:14:58.000000000","message":"Ack","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":220,"context_line":"            help\u003d_(\u0027Display all share group types whatever public or private. \u0027"},{"line_number":221,"context_line":"                   \u0027Default\u003dFalse. (Admin only)\u0027),"},{"line_number":222,"context_line":"        )"},{"line_number":223,"context_line":"        parser.add_argument("},{"line_number":224,"context_line":"            \u0027--group-specs\u0027,"},{"line_number":225,"context_line":"            type\u003dstr,"},{"line_number":226,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":227,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":228,"context_line":"            default\u003dNone,"},{"line_number":229,"context_line":"            help\u003d_(\u0027Filter share types with group specs (key\u003dvalue).\u0027),"},{"line_number":230,"context_line":"        )"},{"line_number":231,"context_line":"        return parser"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":13,"id":"796248ae_75f51a7a","line":230,"range":{"start_line":223,"start_character":8,"end_line":230,"end_character":9},"updated":"2021-08-26 23:29:45.000000000","message":"I tried to list using this group specs but it seems not to be working...\nPlease see the output: https://paste.openstack.org/show/808367/ :)","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":255,"context_line":"        return (ATTRIBUTES, values)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class ShowShareGroupType(command.ShowOne):"},{"line_number":259,"context_line":"    \"\"\"Show Share Group Types.\"\"\""},{"line_number":260,"context_line":"    _description \u003d _(\"Show share types\")"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"575c7dc2_1444fccc","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":41},"updated":"2021-08-26 23:29:45.000000000","message":"I tried to test this command and this happened:\nhttps://paste.openstack.org/show/808366/\n\nAddressed a comment about a possible issue on line 276 :)","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf381df30739502bf35e564950837f028e797467","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        return (ATTRIBUTES, values)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class ShowShareGroupType(command.ShowOne):"},{"line_number":259,"context_line":"    \"\"\"Show Share Group Types.\"\"\""},{"line_number":260,"context_line":"    _description \u003d _(\"Show share types\")"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"76099005_2a53875d","line":258,"range":{"start_line":258,"start_character":0,"end_line":258,"end_character":41},"in_reply_to":"575c7dc2_1444fccc","updated":"2021-08-31 19:14:58.000000000","message":"Ack","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class ShowShareGroupType(command.ShowOne):"},{"line_number":259,"context_line":"    \"\"\"Show Share Group Types.\"\"\""},{"line_number":260,"context_line":"    _description \u003d _(\"Show share types\")"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowShareGroupType\")"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"130b5361_f4d27468","line":260,"range":{"start_line":260,"start_character":32,"end_line":260,"end_character":33},"updated":"2021-08-26 23:29:45.000000000","message":"group","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf381df30739502bf35e564950837f028e797467","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class ShowShareGroupType(command.ShowOne):"},{"line_number":259,"context_line":"    \"\"\"Show Share Group Types.\"\"\""},{"line_number":260,"context_line":"    _description \u003d _(\"Show share types\")"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    log \u003d logging.getLogger(__name__ + \".ShowShareGroupType\")"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"25680363_2b8c30a1","line":260,"range":{"start_line":260,"start_character":32,"end_line":260,"end_character":33},"in_reply_to":"130b5361_f4d27468","updated":"2021-08-31 19:14:58.000000000","message":"Done","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4ef4ced96ac33662cdc2e44ff9a08bc28dc050bc","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    def take_action(self, parsed_args):"},{"line_number":274,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        share_group_type \u003d share_client.share_group_types.show("},{"line_number":277,"context_line":"            search_group_type\u003dparsed_args.share_group_type)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        formatted_group_type \u003d format_share_group_type(share_group_type)"}],"source_content_type":"text/x-python","patch_set":13,"id":"ce4b1784_2b21cf1a","line":276,"range":{"start_line":276,"start_character":57,"end_line":276,"end_character":62},"updated":"2021-08-26 23:29:45.000000000","message":"Shouldn\u0027t this be: share_client.share_group_types.get?\nhttps://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_group_types.py#L147","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bf381df30739502bf35e564950837f028e797467","unresolved":true,"context_lines":[{"line_number":273,"context_line":"    def take_action(self, parsed_args):"},{"line_number":274,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":"        share_group_type \u003d share_client.share_group_types.show("},{"line_number":277,"context_line":"            search_group_type\u003dparsed_args.share_group_type)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        formatted_group_type \u003d format_share_group_type(share_group_type)"}],"source_content_type":"text/x-python","patch_set":13,"id":"27300816_a42c83d0","line":276,"range":{"start_line":276,"start_character":57,"end_line":276,"end_character":62},"in_reply_to":"ce4b1784_2b21cf1a","updated":"2021-08-31 19:14:58.000000000","message":"Indeed","commit_id":"56e2e52d542c00e03d7c442d5e763eee9f68bebd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    share_group_type._info.update("},{"line_number":45,"context_line":"        {"},{"line_number":46,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":47,"context_line":"            \u0027group_specs\u0027: utils.format_properties("},{"line_number":48,"context_line":"                share_group_type.group_specs),"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    return share_group_type"}],"source_content_type":"text/x-python","patch_set":16,"id":"ddba64da_5ca1980a","line":48,"range":{"start_line":47,"start_character":12,"end_line":48,"end_character":46},"updated":"2021-09-02 21:19:39.000000000","message":"this is worth doing only if the requested format is a table.. if yaml, we should leave these as is:\n\n {\"share_group_type\": {\"id\": \"cdada84d-a834-45de-bfc2-7e9d3d269868\", \"name\": \"newgrouptype\", \"is_public\": false, \"group_specs\": {\"foo\": \"bar2\", \"quz\": \"baz\", \"qu2\": \"baz\"}, \"share_types\": [\"50df8b97-00c9-40cc-b30b-6d4cc958424f\", \"cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\"], \"is_default\": false}}\n\n\nbecomes:\n\n\n    $ openstack  share group type show newgrouptype -f yaml\n    id: cdada84d-a834-45de-bfc2-7e9d3d269868\n    name: newgrouptype\n    share_types:\n    - 50df8b97-00c9-40cc-b30b-6d4cc958424f\n    - cc41fa69-ebf2-4d25-a61b-69dcf3fa9f25\n    visibility: private\n    is_default: false\n    group_specs: \u0027foo : bar2\n\n      quz : baz\n\n      qu2 : baz\u0027","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    share_group_type._info.update("},{"line_number":45,"context_line":"        {"},{"line_number":46,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":47,"context_line":"            \u0027group_specs\u0027: utils.format_properties("},{"line_number":48,"context_line":"                share_group_type.group_specs),"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    return share_group_type"}],"source_content_type":"text/x-python","patch_set":16,"id":"91c62d4a_7ef93f9b","line":48,"range":{"start_line":47,"start_character":12,"end_line":48,"end_character":46},"in_reply_to":"ddba64da_5ca1980a","updated":"2021-09-03 15:24:30.000000000","message":"Ok, I can add the check","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            default\u003dTrue,"},{"line_number":91,"context_line":"            help\u003d_(\u0027Make type accessible to the public (default true).\u0027)"},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027--wait\u0027,"},{"line_number":95,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":96,"context_line":"            default\u003dFalse,"},{"line_number":97,"context_line":"            help\u003d_(\u0027Wait for share group type creation\u0027)"},{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        return parser"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"a8a83374_43c67c81","line":98,"range":{"start_line":93,"start_character":8,"end_line":98,"end_character":9},"updated":"2021-09-02 21:19:39.000000000","message":"This isn\u0027t needed. Share group types are created synchronously","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":true,"context_lines":[{"line_number":90,"context_line":"            default\u003dTrue,"},{"line_number":91,"context_line":"            help\u003d_(\u0027Make type accessible to the public (default true).\u0027)"},{"line_number":92,"context_line":"        )"},{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027--wait\u0027,"},{"line_number":95,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":96,"context_line":"            default\u003dFalse,"},{"line_number":97,"context_line":"            help\u003d_(\u0027Wait for share group type creation\u0027)"},{"line_number":98,"context_line":"        )"},{"line_number":99,"context_line":"        return parser"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"7b53c6d7_aaa7472b","line":98,"range":{"start_line":93,"start_character":8,"end_line":98,"end_character":9},"in_reply_to":"a8a83374_43c67c81","updated":"2021-09-03 15:24:30.000000000","message":"Great, let\u0027s drop it","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        share_group_type \u003d share_client.share_group_types.create(**kwargs)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if parsed_args.wait:"},{"line_number":138,"context_line":"            is_available \u003d oscutils.wait_for_status("},{"line_number":139,"context_line":"                status_f\u003dshare_client.share_group_types.get,"},{"line_number":140,"context_line":"                res_id\u003dshare_group_type.id,"},{"line_number":141,"context_line":"                success_status\u003d[\u0027available\u0027]"},{"line_number":142,"context_line":"            )"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            if not is_available:"},{"line_number":145,"context_line":"                LOG.error(_(\"ERROR: Share group type is in error state.\"))"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ad148bcc_3fac1fd6","line":143,"range":{"start_line":137,"start_character":8,"end_line":143,"end_character":0},"updated":"2021-09-02 21:19:39.000000000","message":"There is no \"status\" attribute on share group types","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        share_group_type \u003d share_client.share_group_types.create(**kwargs)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        if parsed_args.wait:"},{"line_number":138,"context_line":"            is_available \u003d oscutils.wait_for_status("},{"line_number":139,"context_line":"                status_f\u003dshare_client.share_group_types.get,"},{"line_number":140,"context_line":"                res_id\u003dshare_group_type.id,"},{"line_number":141,"context_line":"                success_status\u003d[\u0027available\u0027]"},{"line_number":142,"context_line":"            )"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"            if not is_available:"},{"line_number":145,"context_line":"                LOG.error(_(\"ERROR: Share group type is in error state.\"))"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"4ed129d9_4450acd9","line":143,"range":{"start_line":137,"start_character":8,"end_line":143,"end_character":0},"in_reply_to":"ad148bcc_3fac1fd6","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            nargs\u003d\"+\","},{"line_number":168,"context_line":"            help\u003d_(\"Name or ID of the share group type(s) to delete\")"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \"--wait\","},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            default\u003dFalse,"},{"line_number":174,"context_line":"            help\u003d_(\"Wait for share deletion\")"},{"line_number":175,"context_line":"        )"},{"line_number":176,"context_line":"        return parser"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"72ec0610_f4ff2ac9","line":175,"range":{"start_line":170,"start_character":8,"end_line":175,"end_character":9},"updated":"2021-09-02 21:19:39.000000000","message":"Share group types are deleted sychronously - no need for this parameter","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":true,"context_lines":[{"line_number":167,"context_line":"            nargs\u003d\"+\","},{"line_number":168,"context_line":"            help\u003d_(\"Name or ID of the share group type(s) to delete\")"},{"line_number":169,"context_line":"        )"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \"--wait\","},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            default\u003dFalse,"},{"line_number":174,"context_line":"            help\u003d_(\"Wait for share deletion\")"},{"line_number":175,"context_line":"        )"},{"line_number":176,"context_line":"        return parser"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"80569d50_ead4ddd6","line":175,"range":{"start_line":170,"start_character":8,"end_line":175,"end_character":9},"in_reply_to":"72ec0610_f4ff2ac9","updated":"2021-09-03 15:24:30.000000000","message":"Ok, let\u0027s drop it","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                share_client.share_group_types.delete(share_group_type_obj)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                if parsed_args.wait:"},{"line_number":191,"context_line":"                    deleted \u003d oscutils.wait_for_delete("},{"line_number":192,"context_line":"                        manager\u003dshare_client.share_group_types,"},{"line_number":193,"context_line":"                        res_id\u003dshare_group_type_obj.id)"},{"line_number":194,"context_line":"                    result \u003d result if deleted else result + 1"},{"line_number":195,"context_line":"            except Exception as e:"},{"line_number":196,"context_line":"                result +\u003d 1"},{"line_number":197,"context_line":"                LOG.error(_("}],"source_content_type":"text/x-python","patch_set":16,"id":"25af6edb_c80535d7","line":194,"range":{"start_line":190,"start_character":16,"end_line":194,"end_character":62},"updated":"2021-09-02 21:19:39.000000000","message":"same comment as above","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"                share_client.share_group_types.delete(share_group_type_obj)"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"                if parsed_args.wait:"},{"line_number":191,"context_line":"                    deleted \u003d oscutils.wait_for_delete("},{"line_number":192,"context_line":"                        manager\u003dshare_client.share_group_types,"},{"line_number":193,"context_line":"                        res_id\u003dshare_group_type_obj.id)"},{"line_number":194,"context_line":"                    result \u003d result if deleted else result + 1"},{"line_number":195,"context_line":"            except Exception as e:"},{"line_number":196,"context_line":"                result +\u003d 1"},{"line_number":197,"context_line":"                LOG.error(_("}],"source_content_type":"text/x-python","patch_set":16,"id":"64005fec_cc07c387","line":194,"range":{"start_line":190,"start_character":16,"end_line":194,"end_character":62},"in_reply_to":"25af6edb_c80535d7","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":218,"context_line":"            \u0027--all\u0027,"},{"line_number":219,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":220,"context_line":"            default\u003dFalse,"},{"line_number":221,"context_line":"            help\u003d_(\u0027Display all share group types whatever public or private. \u0027"},{"line_number":222,"context_line":"                   \u0027Default\u003dFalse. (Admin only)\u0027),"},{"line_number":223,"context_line":"        )"},{"line_number":224,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":16,"id":"ba4a703d_8596bcf6","line":221,"range":{"start_line":221,"start_character":50,"end_line":221,"end_character":58},"updated":"2021-09-02 21:19:39.000000000","message":"whether","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":218,"context_line":"            \u0027--all\u0027,"},{"line_number":219,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":220,"context_line":"            default\u003dFalse,"},{"line_number":221,"context_line":"            help\u003d_(\u0027Display all share group types whatever public or private. \u0027"},{"line_number":222,"context_line":"                   \u0027Default\u003dFalse. (Admin only)\u0027),"},{"line_number":223,"context_line":"        )"},{"line_number":224,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":16,"id":"5b11e9ec_3112753a","line":221,"range":{"start_line":221,"start_character":50,"end_line":221,"end_character":58},"in_reply_to":"ba4a703d_8596bcf6","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":227,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":228,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":229,"context_line":"            default\u003dNone,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Filter share types with group specs (key\u003dvalue).\u0027),"},{"line_number":231,"context_line":"        )"},{"line_number":232,"context_line":"        return parser"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"75261495_ff055182","line":230,"range":{"start_line":230,"start_character":33,"end_line":230,"end_character":38},"updated":"2021-09-02 21:19:39.000000000","message":"group types","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":227,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":228,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":229,"context_line":"            default\u003dNone,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Filter share types with group specs (key\u003dvalue).\u0027),"},{"line_number":231,"context_line":"        )"},{"line_number":232,"context_line":"        return parser"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"26481744_b1b2f5f7","line":230,"range":{"start_line":230,"start_character":33,"end_line":230,"end_character":38},"in_reply_to":"75261495_ff055182","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":309,"context_line":"                   \" used for share type creation. OPTIONAL: Default\u003dNone.\""},{"line_number":310,"context_line":"                   \" Example: --group-specs consistent-snapshot-support\u003dTrue\"),"},{"line_number":311,"context_line":"        )"},{"line_number":312,"context_line":"        parser.add_argument("},{"line_number":313,"context_line":"            \u0027--public\u0027,"},{"line_number":314,"context_line":"            metavar\u003d\"\u003cpublic\u003e\","},{"line_number":315,"context_line":"            default\u003dNone,"},{"line_number":316,"context_line":"            help\u003d_(\u0027New visibility of the share group type. If set to True, \u0027"},{"line_number":317,"context_line":"                   \u0027share group type will be available to all projects \u0027"},{"line_number":318,"context_line":"                   \u0027in the cloud. \u0027)"},{"line_number":319,"context_line":"        )"},{"line_number":320,"context_line":"        parser.add_argument("},{"line_number":321,"context_line":"            \u0027--name\u0027,"},{"line_number":322,"context_line":"            metavar\u003d\"\u003cname\u003e\","},{"line_number":323,"context_line":"            default\u003dNone,"},{"line_number":324,"context_line":"            help\u003d_(\u0027New name of share type.\u0027)"},{"line_number":325,"context_line":"        )"},{"line_number":326,"context_line":"        return parser"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"fd3bf4ec_692c25c5","line":325,"range":{"start_line":312,"start_character":8,"end_line":325,"end_character":9},"updated":"2021-09-02 21:19:39.000000000","message":"see comment below","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":339,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":340,"context_line":"        kwargs \u003d {}"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if parsed_args.name is not None:"},{"line_number":343,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if parsed_args.public is not None:"},{"line_number":346,"context_line":"            kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string("},{"line_number":347,"context_line":"                parsed_args.public, default\u003dTrue)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if kwargs:"},{"line_number":350,"context_line":"            share_group_type_obj.update(**kwargs)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if parsed_args.group_specs:"},{"line_number":353,"context_line":"            group_specs \u003d utils.extract_group_specs("},{"line_number":354,"context_line":"                extra_specs\u003d{},"}],"source_content_type":"text/x-python","patch_set":16,"id":"abbf504d_6227f605","line":351,"range":{"start_line":342,"start_character":0,"end_line":351,"end_character":0},"updated":"2021-09-02 21:19:39.000000000","message":"Currently, we don\u0027t have an API that supports updating share group types: https://docs.openstack.org/api-ref/shared-file-system/#share-group-types-since-api-v2-31\n\nSo this will fail:\n\n\n    $ openstack  share group type set --public False ghc-share-group-type\n    # output here is from adding a \"--debug\" to above command\n    update\n    Traceback (most recent call last):\n      File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 402, in run_subcommand\n        result \u003d cmd.run(parsed_args)\n      File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n        return super(Command, self).run(parsed_args)\n      File \"/usr/local/lib/python3.8/dist-packages/cliff/command.py\", line 185, in run\n        return_code \u003d self.take_action(parsed_args) or 0\n      File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_group_types.py\", line 350, in take_action\n        share_group_type_obj.update(**kwargs)\n      File \"/opt/stack/python-manilaclient/manilaclient/common/apiclient/base.py\", line 477, in __getattr__\n        raise AttributeError(k)\n    AttributeError: update\n    clean_up SetShareGroupType: update\n    END return value: 1","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":true,"context_lines":[{"line_number":339,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":340,"context_line":"        kwargs \u003d {}"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if parsed_args.name is not None:"},{"line_number":343,"context_line":"            kwargs[\u0027name\u0027] \u003d parsed_args.name"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        if parsed_args.public is not None:"},{"line_number":346,"context_line":"            kwargs[\u0027is_public\u0027] \u003d strutils.bool_from_string("},{"line_number":347,"context_line":"                parsed_args.public, default\u003dTrue)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        if kwargs:"},{"line_number":350,"context_line":"            share_group_type_obj.update(**kwargs)"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if parsed_args.group_specs:"},{"line_number":353,"context_line":"            group_specs \u003d utils.extract_group_specs("},{"line_number":354,"context_line":"                extra_specs\u003d{},"}],"source_content_type":"text/x-python","patch_set":16,"id":"a0e6e98f_67b43fa2","line":351,"range":{"start_line":342,"start_character":0,"end_line":351,"end_character":0},"in_reply_to":"abbf504d_6227f605","updated":"2021-09-03 15:24:30.000000000","message":"Ah yes, just hit this... we should drop this then","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027share_group_type\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"\u003cshare_group_type\u003e\","},{"line_number":374,"context_line":"            help\u003d_(\"Name or ID of the share grouptype to modify\")"},{"line_number":375,"context_line":"        )"},{"line_number":376,"context_line":"        parser.add_argument("},{"line_number":377,"context_line":"            \u0027group_specs\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"c2ea03fc_b9548cc2","line":374,"range":{"start_line":374,"start_character":44,"end_line":374,"end_character":53},"updated":"2021-09-02 21:19:39.000000000","message":"group type","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        parser.add_argument("},{"line_number":372,"context_line":"            \u0027share_group_type\u0027,"},{"line_number":373,"context_line":"            metavar\u003d\"\u003cshare_group_type\u003e\","},{"line_number":374,"context_line":"            help\u003d_(\"Name or ID of the share grouptype to modify\")"},{"line_number":375,"context_line":"        )"},{"line_number":376,"context_line":"        parser.add_argument("},{"line_number":377,"context_line":"            \u0027group_specs\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"7286aef1_ead43494","line":374,"range":{"start_line":374,"start_character":44,"end_line":374,"end_character":53},"in_reply_to":"c2ea03fc_b9548cc2","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":377,"context_line":"            \u0027group_specs\u0027,"},{"line_number":378,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":379,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":380,"context_line":"            help\u003d_(\u0027Remove group_specs from this share group type\u0027),"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        return parser"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"2305b1f1_7ad40ac9","line":380,"range":{"start_line":380,"start_character":27,"end_line":380,"end_character":38},"updated":"2021-09-02 21:19:39.000000000","message":"group specs","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            \u0027group_specs\u0027,"},{"line_number":378,"context_line":"            metavar\u003d\u0027\u003ckey\u003e\u0027,"},{"line_number":379,"context_line":"            nargs\u003d\u0027+\u0027,"},{"line_number":380,"context_line":"            help\u003d_(\u0027Remove group_specs from this share group type\u0027),"},{"line_number":381,"context_line":"        )"},{"line_number":382,"context_line":"        return parser"},{"line_number":383,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"386bbe56_985fe2d6","line":380,"range":{"start_line":380,"start_character":27,"end_line":380,"end_character":38},"in_reply_to":"2305b1f1_7ad40ac9","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"392c1634b15808a92a4f2359a444cecaf6ab9eee","unresolved":true,"context_lines":[{"line_number":399,"context_line":"                share_group_type_obj.unset_keys(parsed_args.group_specs)"},{"line_number":400,"context_line":"            except Exception as e:"},{"line_number":401,"context_line":"                raise exceptions.CommandError("},{"line_number":402,"context_line":"                    \"Failed to remove share type extra spec: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":16,"id":"e2a231b2_47bc66aa","line":402,"range":{"start_line":402,"start_character":38,"end_line":402,"end_character":54},"updated":"2021-09-02 21:19:39.000000000","message":"group","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"8a82dc780054f952859a210644000bad7c60e6a2","unresolved":false,"context_lines":[{"line_number":399,"context_line":"                share_group_type_obj.unset_keys(parsed_args.group_specs)"},{"line_number":400,"context_line":"            except Exception as e:"},{"line_number":401,"context_line":"                raise exceptions.CommandError("},{"line_number":402,"context_line":"                    \"Failed to remove share type extra spec: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":16,"id":"f31e8718_50287a0b","line":402,"range":{"start_line":402,"start_character":38,"end_line":402,"end_character":54},"in_reply_to":"e2a231b2_47bc66aa","updated":"2021-09-03 15:24:30.000000000","message":"Ack","commit_id":"9277f7e984d91420802e090ea3fa636951f37ea2"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0701fb16b94c1cbc7e8d7007fed78315f13c4962","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ATTRIBUTES \u003d ["},{"line_number":27,"context_line":"    \u0027id\u0027,"},{"line_number":28,"context_line":"    \u0027name\u0027,"},{"line_number":29,"context_line":"    \u0027share_types\u0027,"},{"line_number":30,"context_line":"    \u0027visibility\u0027,"},{"line_number":31,"context_line":"    \u0027is_default\u0027,"},{"line_number":32,"context_line":"    \u0027group_specs\u0027"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def format_share_group_type(share_group_type):"}],"source_content_type":"text/x-python","patch_set":18,"id":"c2b7cc22_03f7af3c","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":1},"updated":"2021-09-20 15:19:46.000000000","message":"I believe there is a pattern where we can drop the underscores, capitalize all words and for id go with ID","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aa94e03cb6e47acbcc3d96177e9e82d8502dc9f6","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ATTRIBUTES \u003d ["},{"line_number":27,"context_line":"    \u0027id\u0027,"},{"line_number":28,"context_line":"    \u0027name\u0027,"},{"line_number":29,"context_line":"    \u0027share_types\u0027,"},{"line_number":30,"context_line":"    \u0027visibility\u0027,"},{"line_number":31,"context_line":"    \u0027is_default\u0027,"},{"line_number":32,"context_line":"    \u0027group_specs\u0027"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def format_share_group_type(share_group_type):"}],"source_content_type":"text/x-python","patch_set":18,"id":"f8584416_a74d1389","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"c2b7cc22_03f7af3c","updated":"2021-09-22 08:29:45.000000000","message":"We are making a list of attributes as we get that from the database. We then process those here https://github.com/openstack/osc-lib/blob/master/osc_lib/utils/__init__.py#L440. By looking at how that function works, it should be fine if we capitalize and remove underscores. But we are passing things on lowercase and with underscores for all different resources. Maybe we could get this one in as is, and if we want to change it then propose a follow up change with it. Wdyt?","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"81c98037761ccc0b73ba52cfc2792ddff4c6308b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ATTRIBUTES \u003d ["},{"line_number":27,"context_line":"    \u0027id\u0027,"},{"line_number":28,"context_line":"    \u0027name\u0027,"},{"line_number":29,"context_line":"    \u0027share_types\u0027,"},{"line_number":30,"context_line":"    \u0027visibility\u0027,"},{"line_number":31,"context_line":"    \u0027is_default\u0027,"},{"line_number":32,"context_line":"    \u0027group_specs\u0027"},{"line_number":33,"context_line":"]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def format_share_group_type(share_group_type):"}],"source_content_type":"text/x-python","patch_set":18,"id":"1a13bbe4_4f3a0b5c","line":33,"range":{"start_line":26,"start_character":0,"end_line":33,"end_character":1},"in_reply_to":"f8584416_a74d1389","updated":"2021-09-22 19:35:40.000000000","message":"Thats nice, we stick with the consistency and later we can change it all at once in a separated patch","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0701fb16b94c1cbc7e8d7007fed78315f13c4962","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":"        parser.add_argument("},{"line_number":70,"context_line":"            \"share_types\","},{"line_number":71,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":72,"context_line":"            nargs\u003d\"+\","},{"line_number":73,"context_line":"            default\u003dNone,"},{"line_number":74,"context_line":"            help\u003d_(\"List of share type names or IDs. Example:\""}],"source_content_type":"text/x-python","patch_set":18,"id":"1f26b70e_9f9e0cca","line":71,"range":{"start_line":71,"start_character":27,"end_line":71,"end_character":28},"updated":"2021-09-20 15:19:46.000000000","message":"as pattern for metavars it would be better to use slashes instead of underscores -- most metavars are being written like this","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aa94e03cb6e47acbcc3d96177e9e82d8502dc9f6","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":"        parser.add_argument("},{"line_number":70,"context_line":"            \"share_types\","},{"line_number":71,"context_line":"            metavar\u003d\"\u003cshare_types\u003e\","},{"line_number":72,"context_line":"            nargs\u003d\"+\","},{"line_number":73,"context_line":"            default\u003dNone,"},{"line_number":74,"context_line":"            help\u003d_(\"List of share type names or IDs. Example:\""}],"source_content_type":"text/x-python","patch_set":18,"id":"78ae58d1_f72b6d77","line":71,"range":{"start_line":71,"start_character":27,"end_line":71,"end_character":28},"in_reply_to":"1f26b70e_9f9e0cca","updated":"2021-09-22 08:29:45.000000000","message":"Same, we don\u0027t have a standard it seems. I can fix it but it will require some follow up patch to fix it on other resources.","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"8980e0f8096e61b8c53a3e40443fa4a61f6a3ac0","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            \u0027group_specs\u0027: utils.format_properties("},{"line_number":48,"context_line":"                share_group_type.group_specs),"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    return share_group_type"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"01e6ba6a_7addca0d","line":50,"updated":"2021-10-02 08:52:34.000000000","message":"Would you mind adding formatting to the share_types list as well (for the table view only), see example: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share_groups.py#L144-L147","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c3a8076250488e2da900db8ff4fa44fd58bf8e77","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027group_specs\u0027: utils.format_properties("},{"line_number":48,"context_line":"                share_group_type.group_specs),"},{"line_number":49,"context_line":"        }"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    return share_group_type"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"08bb4038_1a3783c2","line":50,"in_reply_to":"01e6ba6a_7addca0d","updated":"2021-11-19 15:53:11.000000000","message":"Done","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        group_specs \u003d {}"},{"line_number":105,"context_line":"        if parsed_args.group_specs:"},{"line_number":106,"context_line":"            for item in parsed_args.group_specs:"},{"line_number":107,"context_line":"                group_specs \u003d utils.extract_group_specs(group_specs, [item])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        kwargs[\u0027group_specs\u0027] \u003d group_specs"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"6062059c_f9777118","line":107,"range":{"start_line":106,"start_character":47,"end_line":107,"end_character":16},"updated":"2021-12-07 21:23:03.000000000","message":"could enhance error handling here:\n\n\n$ openstack share group type create testing3 mountable --group-specs test\nnot enough values to unpack (expected 2, got 1)","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        group_specs \u003d {}"},{"line_number":105,"context_line":"        if parsed_args.group_specs:"},{"line_number":106,"context_line":"            for item in parsed_args.group_specs:"},{"line_number":107,"context_line":"                group_specs \u003d utils.extract_group_specs(group_specs, [item])"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        kwargs[\u0027group_specs\u0027] \u003d group_specs"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"45a3467b_6155444c","line":107,"range":{"start_line":106,"start_character":47,"end_line":107,"end_character":16},"in_reply_to":"6062059c_f9777118","updated":"2021-12-08 11:49:43.000000000","message":"Ack","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":191,"context_line":"        search_opts \u003d {}"},{"line_number":192,"context_line":"        if parsed_args.group_specs:"},{"line_number":193,"context_line":"            search_opts \u003d {"},{"line_number":194,"context_line":"                \u0027group_specs\u0027: utils.extract_group_specs("},{"line_number":195,"context_line":"                    extra_specs\u003d{},"},{"line_number":196,"context_line":"                    specs_to_add\u003dparsed_args.group_specs)"},{"line_number":197,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":22,"id":"50db7b52_b8f72bfa","line":194,"range":{"start_line":194,"start_character":37,"end_line":194,"end_character":56},"updated":"2021-12-07 21:23:03.000000000","message":"perhaps the validation should go inside this method so it\u0027s consistent: \n\n $ openstack share group type list --group-specs testing2\n not enough values to unpack (expected 2, got 1)","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        search_opts \u003d {}"},{"line_number":192,"context_line":"        if parsed_args.group_specs:"},{"line_number":193,"context_line":"            search_opts \u003d {"},{"line_number":194,"context_line":"                \u0027group_specs\u0027: utils.extract_group_specs("},{"line_number":195,"context_line":"                    extra_specs\u003d{},"},{"line_number":196,"context_line":"                    specs_to_add\u003dparsed_args.group_specs)"},{"line_number":197,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":22,"id":"a67d649f_464987d0","line":194,"range":{"start_line":194,"start_character":37,"end_line":194,"end_character":56},"in_reply_to":"50db7b52_b8f72bfa","updated":"2021-12-08 11:49:43.000000000","message":"Ack","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        formatter \u003d parsed_args.formatter"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        share_group_types \u003d share_client.share_group_types.list("},{"line_number":202,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":203,"context_line":"            show_all\u003dparsed_args.all)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        formatted_types \u003d []"}],"source_content_type":"text/x-python","patch_set":22,"id":"57411917_f0bd3187","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":36},"updated":"2021-12-07 21:23:03.000000000","message":"This never worked in the SDK by the looks of it: \n\n https://github.com/openstack/python-manilaclient/blob/a68aaab1723b209de8d314abc7192d373074825a/manilaclient/v2/share_group_types.py#L150-L157","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":true,"context_lines":[{"line_number":199,"context_line":"        formatter \u003d parsed_args.formatter"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        share_group_types \u003d share_client.share_group_types.list("},{"line_number":202,"context_line":"            search_opts\u003dsearch_opts,"},{"line_number":203,"context_line":"            show_all\u003dparsed_args.all)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        formatted_types \u003d []"}],"source_content_type":"text/x-python","patch_set":22,"id":"435888b8_2bd17c95","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":36},"in_reply_to":"57411917_f0bd3187","updated":"2021-12-08 11:49:43.000000000","message":"True that. Not only on the SDK, not even in the server side. Created a bp [0] and proposed a fix [1]\n\n[0] https://blueprints.launchpad.net/manila/+spec/support-group-spec-search-share-group-type-api\n[1] https://review.opendev.org/c/openstack/manila/+/821002","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":289,"context_line":"            share_group_type_obj.set_keys(**kwargs)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if parsed_args.group_specs:"},{"line_number":292,"context_line":"            group_specs \u003d utils.extract_group_specs("},{"line_number":293,"context_line":"                extra_specs\u003d{},"},{"line_number":294,"context_line":"                specs_to_add\u003dparsed_args.group_specs)"},{"line_number":295,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"a0e083f9_4ee358fc","line":292,"range":{"start_line":292,"start_character":32,"end_line":292,"end_character":51},"updated":"2021-12-07 21:23:03.000000000","message":"same issue as above:\n\n $ openstack share group type set testing --group-specs foo\n not enough values to unpack (expected 2, got 1)","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[{"line_number":289,"context_line":"            share_group_type_obj.set_keys(**kwargs)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        if parsed_args.group_specs:"},{"line_number":292,"context_line":"            group_specs \u003d utils.extract_group_specs("},{"line_number":293,"context_line":"                extra_specs\u003d{},"},{"line_number":294,"context_line":"                specs_to_add\u003dparsed_args.group_specs)"},{"line_number":295,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":22,"id":"6428b815_628aa530","line":292,"range":{"start_line":292,"start_character":32,"end_line":292,"end_character":51},"in_reply_to":"a0e083f9_4ee358fc","updated":"2021-12-08 11:49:43.000000000","message":"Ack","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"e878ccf46b0a0e0c5dc6e3b418c53714b14a2f39","unresolved":true,"context_lines":[{"line_number":1161,"context_line":"    \"\"\"Fake one or more share group types\"\"\""},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"    @staticmethod"},{"line_number":1164,"context_line":"    def create_one_sharegrouptype(attrs\u003dNone, methods\u003dNone):"},{"line_number":1165,"context_line":"        \"\"\"Create a fake share group type"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"        :param Dictionary attrs:"}],"source_content_type":"text/x-python","patch_set":20,"id":"53d2c25a_57e09ae6","line":1164,"range":{"start_line":1164,"start_character":19,"end_line":1164,"end_character":33},"updated":"2021-10-14 12:55:19.000000000","message":"could follow the snake case pattern","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c3a8076250488e2da900db8ff4fa44fd58bf8e77","unresolved":false,"context_lines":[{"line_number":1161,"context_line":"    \"\"\"Fake one or more share group types\"\"\""},{"line_number":1162,"context_line":""},{"line_number":1163,"context_line":"    @staticmethod"},{"line_number":1164,"context_line":"    def create_one_sharegrouptype(attrs\u003dNone, methods\u003dNone):"},{"line_number":1165,"context_line":"        \"\"\"Create a fake share group type"},{"line_number":1166,"context_line":""},{"line_number":1167,"context_line":"        :param Dictionary attrs:"}],"source_content_type":"text/x-python","patch_set":20,"id":"8431effd_c36a37fa","line":1164,"range":{"start_line":1164,"start_character":19,"end_line":1164,"end_character":33},"in_reply_to":"53d2c25a_57e09ae6","updated":"2021-11-19 15:53:11.000000000","message":"Done","commit_id":"a9d3bb55c5729c6473cae29255d7e8fa9220d5de"}],"manilaclient/tests/unit/osc/v2/test_share_group_type.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"52877a34651b77897afc4afb06fa5757fec2d78c","unresolved":true,"context_lines":[{"line_number":184,"context_line":"            self.assertCountEqual(COLUMNS, columns)"},{"line_number":185,"context_line":"            self.assertCountEqual(self.data, data)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    # def test_create_share_group_type_wait(self):"},{"line_number":188,"context_line":"    #     arglist \u003d ["},{"line_number":189,"context_line":"    #         self.share_group_type.name,"},{"line_number":190,"context_line":"    #         self.share_group_type.share_types[0].name,"}],"source_content_type":"text/x-python","patch_set":8,"id":"069755dc_e3c9a209","line":187,"updated":"2021-08-23 10:08:05.000000000","message":"Debugging this tests","commit_id":"e1648660000e9673345ec47d041b788c8c606d21"}],"manilaclient/tests/unit/osc/v2/test_share_group_type_access.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0701fb16b94c1cbc7e8d7007fed78315f13c4962","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.assertIsNone(result)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_share_group_type_access_create_throws_exception(self):"},{"line_number":80,"context_line":"        arglist \u003d ["},{"line_number":81,"context_line":"            self.share_group_type.id,"},{"line_number":82,"context_line":"            \u0027invalid_project_format\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"2af0f873_e370770b","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":60},"updated":"2021-09-20 15:19:46.000000000","message":"could be more specific with the exception thrown -- invalid_project_exception","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"aa94e03cb6e47acbcc3d96177e9e82d8502dc9f6","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        self.assertIsNone(result)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def test_share_group_type_access_create_throws_exception(self):"},{"line_number":80,"context_line":"        arglist \u003d ["},{"line_number":81,"context_line":"            self.share_group_type.id,"},{"line_number":82,"context_line":"            \u0027invalid_project_format\u0027"}],"source_content_type":"text/x-python","patch_set":18,"id":"b6d7e212_b30d144b","line":79,"range":{"start_line":79,"start_character":44,"end_line":79,"end_character":60},"in_reply_to":"2af0f873_e370770b","updated":"2021-09-22 08:29:45.000000000","message":"Ack","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"}],"manilaclient/v2/share_group_type_access.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51acf4d15dec5b02580a9e1d179adb530a1b3b69","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ShareGroupTypeAccess(common_base.Resource):"},{"line_number":28,"context_line":"    def __repr__(self):"},{"line_number":29,"context_line":"        return \"\u003cShare Group Type Access: %s\u003e\" % self.share_group_type_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class ShareGroupTypeAccessManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":18,"id":"56e3c194_b1460a1b","line":29,"updated":"2021-09-14 15:35:00.000000000","message":"This is actually unrelated to this change, but hit this bug when testing this. When hitting the API for share group type access, the attribute that identifies the share_group_type is not \"id\" but \"share_group_type_id\".\n\nCheck API ref https://docs.openstack.org/api-ref/shared-file-system/?expanded\u003dshow-share-group-type-access-details-detail","commit_id":"2e99b3fdc822135cc934b91ba2d04540721a4c44"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"feecd8e4909e686c716674464a1785a51c512690","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ShareGroupTypeAccess(common_base.Resource):"},{"line_number":28,"context_line":"    def __repr__(self):"},{"line_number":29,"context_line":"        return \"\u003cShare Group Type Access: %s\u003e\" % self.share_group_type_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class ShareGroupTypeAccessManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":22,"id":"e8e3e038_58364fae","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":73},"updated":"2021-12-07 21:23:03.000000000","message":"This seems like a bugfix that can be backported","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3f2f2955034cd97e0db2cf277d8d58093f757464","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ShareGroupTypeAccess(common_base.Resource):"},{"line_number":28,"context_line":"    def __repr__(self):"},{"line_number":29,"context_line":"        return \"\u003cShare Group Type Access: %s\u003e\" % self.share_group_type_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class ShareGroupTypeAccessManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":22,"id":"51f7aa5c_a62bbbfd","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":73},"in_reply_to":"a761b1a9_630bd2ba","updated":"2021-12-08 20:57:14.000000000","message":"Thanks!","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"51474ef4e680c446381309f11a648dd0fb1552cf","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ShareGroupTypeAccess(common_base.Resource):"},{"line_number":28,"context_line":"    def __repr__(self):"},{"line_number":29,"context_line":"        return \"\u003cShare Group Type Access: %s\u003e\" % self.share_group_type_id"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class ShareGroupTypeAccessManager(base.ManagerWithFind):"}],"source_content_type":"text/x-python","patch_set":22,"id":"a761b1a9_630bd2ba","line":29,"range":{"start_line":29,"start_character":0,"end_line":29,"end_character":73},"in_reply_to":"e8e3e038_58364fae","updated":"2021-12-08 11:49:43.000000000","message":"Sure, I can propose this as a different change and do the backport","commit_id":"557bde0e4c2062ae2a2f19a87d56850cd3ae5631"}]}