)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":15,"context_line":"- openstack share server adopt"},{"line_number":16,"context_line":"- openstack share server abandon"},{"line_number":17,"context_line":"- openstack share server set --status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I01b0ee1a8092002d2c2aa916617b2db75654e8d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"d095f9fd_d3f96d8c","line":18,"updated":"2021-09-18 12:54:19.000000000","message":"Add line:\nPartially-implements: bp openstack-client-support","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":15,"context_line":"- openstack share server adopt"},{"line_number":16,"context_line":"- openstack share server abandon"},{"line_number":17,"context_line":"- openstack share server set --status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I01b0ee1a8092002d2c2aa916617b2db75654e8d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"a05dcbc3_e5f64f32","line":18,"in_reply_to":"d095f9fd_d3f96d8c","updated":"2021-09-24 12:25:20.000000000","message":"Done","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5a319ba0c21c056367654f439735626e0f13c084","unresolved":true,"context_lines":[{"line_number":17,"context_line":"- openstack share server set --status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partially-implements: bp openstack-client-support"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I01b0ee1a8092002d2c2aa916617b2db75654e8d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"808e2f41_5a7d0b3c","line":20,"updated":"2022-07-01 08:53:36.000000000","message":"Add Co-Authored-By line :)","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"- openstack share server set --status"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Partially-implements: bp openstack-client-support"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I01b0ee1a8092002d2c2aa916617b2db75654e8d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3f75e859_63ab16d2","line":20,"in_reply_to":"808e2f41_5a7d0b3c","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e847cc90_72b0b7e5","updated":"2021-10-30 08:47:11.000000000","message":"Thanks Archana! I left some comments inline, please have a look :) ","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"6cadba73_bcfe9255","updated":"2021-12-29 12:26:53.000000000","message":"Hi, Maari and Fábio for your review. I\u0027ve left some comments that you can take a look!","commit_id":"33ac359f4933fad372c44f78eab92e22cea08604"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"fb79c7699a250f69789e24c72d73ba599e304047","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"829364fd_f07fd86c","updated":"2021-12-30 19:15:59.000000000","message":"recheck","commit_id":"01ceab4a3bce1eda47172fbe5ac9f435adc87566"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"e64823097f4ba84d585c57680c3a1dc30e0e2f94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"949be2f4_cae7220c","updated":"2022-01-09 07:16:50.000000000","message":"recheck","commit_id":"01ceab4a3bce1eda47172fbe5ac9f435adc87566"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"0bfa6061_6e5ca99d","updated":"2022-02-17 08:18:43.000000000","message":"Thanks for working on this OSC implementation, Archana! :)\nPlease see my comments inline when you have the time.\n\nI tested patchset 26 locally on a fresh DevStack with Manila, and some operations didn\u0027t work as expected. These were my results (more details inline):\n\n- openstack share server delete ❌\n- openstack share server show ✔️\n- openstack share server list ⚠️\n- openstack share server adopt ❌\n- openstack share server abandon ✔️\n- openstack share server set --status ✔️\n- Bash completion worked as expected after regenerating /etc/bash_completion.d/osc.bash_completion","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"559558315fe1a177f878a33954d9640ac6a13076","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"0f21f602_ee629959","updated":"2022-01-18 17:36:01.000000000","message":"recheck","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"400e16d2b219f65eb637996a605b5eaa573b016c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"ee7d4e5a_0b8fb050","updated":"2022-02-10 16:18:16.000000000","message":"recheck","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"5cda815e7932b995bb32d5cbb2067ed432666891","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"bc4b7f9b_3e33ee5e","updated":"2022-04-12 06:42:44.000000000","message":"Hi Archana, you asked in irc, but since you are not logged in I\u0027ll answer here\n\n\u003e [...] during testing i came across the same error you posted on launchpad here https://bugs.launchpad.net/python-manilaclient/+bug/1960490, so i wanted to know how did you resolve this error? would you mind helping me out?\n\u003e here is my terminal view https://paste.opendev.org/show/bA2s9ioy6UpTXdlAY2FW/\n\nI suggest to set the environment variable like \u0027export OS_SHARE_API_VERSION\u003d2.63\u0027 or you specify the api-version directly on each call like \u0027openstack --os-share-api-version 2.63 share list\u0027\n\n\nHaving a maximum of 2.63 available means your devstack (or whatever openstack you are calling) is on the wallaby release.\n\nHave fun on the further coding!","commit_id":"425c5f02e99bad5713a9d18008e7eb4239a46dea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"30c95684e13966749db2439a73dcb4962b4b28c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"9f58d07b_a87278d8","updated":"2022-05-10 23:12:13.000000000","message":"And thank you all for the reviews :)","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"78c97acf_3eae9953","updated":"2022-05-10 23:11:50.000000000","message":"Done a few updates, please check the latest PS","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"71a67c0df4c25dc97594ebc4ef0e05f1b5242ded","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"3d11a838_291f48e0","updated":"2022-06-30 19:30:42.000000000","message":"Late review :P But change looks good to me!","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7452068e1a15317a72d3cc7a9457e61d740ac8c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"834829d6_0ad39b6c","updated":"2022-07-01 20:28:53.000000000","message":"Thank you for the review, Maari!\nPLease check the latest PS","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5a319ba0c21c056367654f439735626e0f13c084","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"1a299c0c_14f65378","updated":"2022-07-01 08:53:36.000000000","message":"Thanks for working on this Archana and Carlos! I left some notes inline for unit tests, for the very least we should drop the commented out test, for anything else we could add TODO\u0027s so we can move things along :) ","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"24279279e27fdf17ec7cb5fb84118eeeb4c5d2bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"2b09bfbe_ffbfb331","updated":"2022-05-11 11:35:37.000000000","message":"recheck\nTests passed locally - Confirming if it was a one time issue","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":29,"id":"27a18aa0_ccdf48d8","updated":"2022-07-07 21:27:54.000000000","message":"Thanks for working on this Archana, and thanks for adding to this Carlos. Please see some comments inline. ","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c995574c230848f918abd1a1fbbf26407992c128","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"5513d9c5_12d05bc4","updated":"2022-07-11 21:19:05.000000000","message":"Thank you for the reviews, please take a look at the latest PS","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":30,"id":"27cfdee1_b924c951","updated":"2022-07-08 22:12:26.000000000","message":"Thank you for the reviews. Please check the latest changes inline","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"cd01b67371ffb206b964c237a36addd65fcfe9bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"8256228a_c365a846","updated":"2022-07-12 02:33:03.000000000","message":"It\u0027s been revised a lot, the code look good to me.","commit_id":"5c2b568794a4e431f2371d1f23d0f00fa0750dbd"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"40af351d82938364aa1704ec90bb928bc5ee0e75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":31,"id":"9f713dbe_d8b3656a","updated":"2022-07-13 13:28:18.000000000","message":"Thanks Carlos and Archana! The code looks good to me, I only left one nit inline about copyright statement, I am not sure if it should be there but I won\u0027t block merging this and add my +2. Thanks again!","commit_id":"5c2b568794a4e431f2371d1f23d0f00fa0750dbd"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"16475d5a27699cfdf23c5ea4d575ca5342f7ecf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"5de38e28_037134c4","updated":"2022-07-18 01:13:56.000000000","message":"LGTM","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"341ead792dd15bc183ee25b81e192581a4b5cff2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"0132f4b4_46092998","updated":"2022-07-15 19:31:31.000000000","message":"Maari, haixin:\nSorry for losing the vote, I needed to rebase this change, as the share groups one was merged.","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"4b5726d4_df335990","updated":"2022-07-20 22:49:37.000000000","message":"Several issues noted inline; please take a look","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb11e1f5091747625fa06c0474f65c301d38ac18","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"76c0d3db_2de30b49","updated":"2022-07-20 22:02:24.000000000","message":"Still reviewing, but LGTM so far","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"547f4698_366f44b5","updated":"2022-07-21 21:44:04.000000000","message":"Thank you for the reviews, please check the answers inline and the changes in the latest PS :)","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"21f4677876f5f5ada914f632472f8e37713837ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"ca5143df_67fe12ac","updated":"2022-07-15 21:08:16.000000000","message":"Thanks Carlos, lgtm :) ","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3823a720dfc2a198add7b47c5ddde57cc840a801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"70ed109e_0366f186","updated":"2022-07-25 16:14:40.000000000","message":"LGTM, thank you","commit_id":"dc918e56fcc9c1d5971f2efe50fd4d0bf7b15b6e"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"de1453e25e6065c504cce33f6ace5d1c082c1bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"b5d5035a_27f2cb9d","updated":"2022-07-25 19:20:39.000000000","message":"LGTM, thanks!","commit_id":"dc918e56fcc9c1d5971f2efe50fd4d0bf7b15b6e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a0db977d64be43c1eb92e06ba3c519ef9bc2a75d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"0826da06_b779c1eb","updated":"2022-07-26 08:56:58.000000000","message":"Thanks, lgtm!","commit_id":"dc918e56fcc9c1d5971f2efe50fd4d0bf7b15b6e"}],"manilaclient/osc/v2/share_servers.py":[{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9b98f4a06e1aa765a21e4c4b7fc077313af4b723","unresolved":true,"context_lines":[{"line_number":177,"context_line":"            type\u003dstr,"},{"line_number":178,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":179,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":180,"context_line":"            action\u003d\u0027single_alias\u0027,"},{"line_number":181,"context_line":"            help\u003d_(\"One or more driver-specific key\u003dvalue pairs that may be \""},{"line_number":182,"context_line":"                   \"necessary to manage the share server (Optional, \""},{"line_number":183,"context_line":"                   \"Default\u003dNone).\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"b463fc03_564e99fd","line":180,"updated":"2021-09-02 16:51:07.000000000","message":"Drop this, is breaking sphinx","commit_id":"08d6d04c784ccfa785cb160b548a250f57e3cd4e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":177,"context_line":"            type\u003dstr,"},{"line_number":178,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":179,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":180,"context_line":"            action\u003d\u0027single_alias\u0027,"},{"line_number":181,"context_line":"            help\u003d_(\"One or more driver-specific key\u003dvalue pairs that may be \""},{"line_number":182,"context_line":"                   \"necessary to manage the share server (Optional, \""},{"line_number":183,"context_line":"                   \"Default\u003dNone).\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"4c234f16_d37ffb3c","line":180,"in_reply_to":"b463fc03_564e99fd","updated":"2022-05-10 23:11:50.000000000","message":"Done","commit_id":"08d6d04c784ccfa785cb160b548a250f57e3cd4e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        parser \u003d super(DeleteShareServer, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \"share_server\","},{"line_number":34,"context_line":"            metavar\u003d\"\u003cshare_server\u003e\","},{"line_number":35,"context_line":"            nargs\u003d\"+\","},{"line_number":36,"context_line":"            help\u003d_(\"ID of the server(s) to delete\")"},{"line_number":37,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"796c5bad_a701ff15","line":34,"range":{"start_line":34,"start_character":27,"end_line":34,"end_character":28},"updated":"2021-09-18 12:54:19.000000000","message":"use hyphens not underscores in all metavars","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser \u003d super(DeleteShareServer, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \"share_server\","},{"line_number":34,"context_line":"            metavar\u003d\"\u003cshare_server\u003e\","},{"line_number":35,"context_line":"            nargs\u003d\"+\","},{"line_number":36,"context_line":"            help\u003d_(\"ID of the server(s) to delete\")"},{"line_number":37,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":12,"id":"71b512f0_73f7d34c","line":34,"range":{"start_line":34,"start_character":27,"end_line":34,"end_character":28},"in_reply_to":"796c5bad_a701ff15","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"3aa7536b20b8cc520ad77b8852b33d047b31817c","unresolved":true,"context_lines":[{"line_number":83,"context_line":"        parser \u003d super(ShowShareServer, self).get_parser(prog_name)"},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \"share_server\","},{"line_number":86,"context_line":"            metavar\u003d\"\u003cshare_server\u003e\","},{"line_number":87,"context_line":"            help\u003d_(\"ID of share server.\")"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":12,"id":"1fe66c0b_93e9758c","line":86,"range":{"start_line":86,"start_character":27,"end_line":86,"end_character":28},"updated":"2021-09-18 16:31:24.000000000","message":"same as mentioned by Maari comment on line 34.\nThere are other points with the same issue, but it wouldn\u0027t be helpful to you if I were to add only comments with \"same here\" :)","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        parser \u003d super(ShowShareServer, self).get_parser(prog_name)"},{"line_number":84,"context_line":"        parser.add_argument("},{"line_number":85,"context_line":"            \"share_server\","},{"line_number":86,"context_line":"            metavar\u003d\"\u003cshare_server\u003e\","},{"line_number":87,"context_line":"            help\u003d_(\"ID of share server.\")"},{"line_number":88,"context_line":"        )"},{"line_number":89,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":12,"id":"be1f4568_19273447","line":86,"range":{"start_line":86,"start_character":27,"end_line":86,"end_character":28},"in_reply_to":"1fe66c0b_93e9758c","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"3aa7536b20b8cc520ad77b8852b33d047b31817c","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Filter results by name of host.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--status\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":116,"context_line":"            default\u003dNone,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Filter results by status.\u0027)"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027--share-network\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"0f6b2210_fef45a28","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":9},"updated":"2021-09-18 16:31:24.000000000","message":"just thinking. Would a flag with the possible options be a good idea here?","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Filter results by name of host.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--status\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":116,"context_line":"            default\u003dNone,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Filter results by status.\u0027)"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027--share-network\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"f01201f0_4582a339","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":9},"in_reply_to":"0f6b2210_fef45a28","updated":"2021-09-24 12:25:20.000000000","message":"Hi Fábio! I can\u0027t get your point here, can you unpack it more? Thanks :)","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Filter results by name of host.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--status\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":116,"context_line":"            default\u003dNone,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Filter results by status.\u0027)"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027--share-network\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"1f233f4a_79b2eb5e","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":9},"in_reply_to":"3c8dd33c_f8cbdb3a","updated":"2021-12-29 12:26:53.000000000","message":"Done","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"9da46899a64c4984c22a677f99daec8a958e5dbb","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Filter results by name of host.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--status\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":116,"context_line":"            default\u003dNone,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Filter results by status.\u0027)"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027--share-network\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3c8dd33c_f8cbdb3a","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":9},"in_reply_to":"7dbec5e9_dad9ea09","updated":"2021-10-08 20:09:33.000000000","message":"Ack!\nThanks, Fábio for the explanation, I\u0027m looking into it!","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"cc7371e9970116ae621c159e1e39dbc41f3ef0de","unresolved":true,"context_lines":[{"line_number":110,"context_line":"            default\u003dNone,"},{"line_number":111,"context_line":"            help\u003d_(\u0027Filter results by name of host.\u0027),"},{"line_number":112,"context_line":"        )"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--status\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":116,"context_line":"            default\u003dNone,"},{"line_number":117,"context_line":"            help\u003d_(\u0027Filter results by status.\u0027)"},{"line_number":118,"context_line":"        )"},{"line_number":119,"context_line":"        parser.add_argument("},{"line_number":120,"context_line":"            \u0027--share-network\u0027,"},{"line_number":121,"context_line":"            metavar\u003d\u0027\u003cshare_network\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7dbec5e9_dad9ea09","line":118,"range":{"start_line":113,"start_character":8,"end_line":118,"end_character":9},"in_reply_to":"f01201f0_4582a339","updated":"2021-09-27 13:09:44.000000000","message":"just an idea to make users life easier when filtering list by status -- the same as on the other comment regarding the ``choices`` flag https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#options-with-choices\nWhat do you think?","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":135,"context_line":"            default\u003dNone,"},{"line_number":136,"context_line":"            help\u003d_(\"Filter results by share network subnet that the \""},{"line_number":137,"context_line":"                   \"share server\u0027s network allocation exists whithin. \""},{"line_number":138,"context_line":"                   \"Available for micro version \u003e\u003d 2.51 (Optional, \""},{"line_number":139,"context_line":"                   \"Default\u003dNone)\")"},{"line_number":140,"context_line":"        )"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"b6920713_7993b762","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":55},"updated":"2021-09-18 12:54:19.000000000","message":"If something is available only with specific version or higher, you also need to add the logic to check for it and raise an exception if a user attempts to use this parameter with a microversion that is lower than required.","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":135,"context_line":"            default\u003dNone,"},{"line_number":136,"context_line":"            help\u003d_(\"Filter results by share network subnet that the \""},{"line_number":137,"context_line":"                   \"share server\u0027s network allocation exists whithin. \""},{"line_number":138,"context_line":"                   \"Available for micro version \u003e\u003d 2.51 (Optional, \""},{"line_number":139,"context_line":"                   \"Default\u003dNone)\")"},{"line_number":140,"context_line":"        )"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"f54f69c2_7b3e4d40","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":55},"in_reply_to":"b6920713_7993b762","updated":"2021-09-24 12:25:20.000000000","message":"Done","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                   \"by the driver to manage the share server.\")"},{"line_number":217,"context_line":"        )"},{"line_number":218,"context_line":"        parser.add_argument("},{"line_number":219,"context_line":"            \u0027--driver_options\u0027, \u0027--driver-options\u0027,"},{"line_number":220,"context_line":"            type\u003dstr,"},{"line_number":221,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":222,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"a4e6dd0f_0cb205ff","line":219,"range":{"start_line":219,"start_character":13,"end_line":219,"end_character":29},"updated":"2021-09-18 12:54:19.000000000","message":"for OSC we only allow options with hyphens.","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                   \"by the driver to manage the share server.\")"},{"line_number":217,"context_line":"        )"},{"line_number":218,"context_line":"        parser.add_argument("},{"line_number":219,"context_line":"            \u0027--driver_options\u0027, \u0027--driver-options\u0027,"},{"line_number":220,"context_line":"            type\u003dstr,"},{"line_number":221,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":222,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"e3ebb168_c0e58f9e","line":219,"range":{"start_line":219,"start_character":13,"end_line":219,"end_character":29},"in_reply_to":"a4e6dd0f_0cb205ff","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                   \"Default\u003dNone).\")"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":"        parser.add_argument("},{"line_number":229,"context_line":"            \u0027--share-network-subnet\u0027, \u0027--share_network_subnet\u0027,"},{"line_number":230,"context_line":"            type\u003dstr,"},{"line_number":231,"context_line":"            metavar\u003d\u0027\u003cshare_network_subnet\u003e\u0027,"},{"line_number":232,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":12,"id":"c9cd1741_54127494","line":229,"range":{"start_line":229,"start_character":39,"end_line":229,"end_character":61},"updated":"2021-09-18 12:54:19.000000000","message":"same comment as above about hyphens","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                   \"Default\u003dNone).\")"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":"        parser.add_argument("},{"line_number":229,"context_line":"            \u0027--share-network-subnet\u0027, \u0027--share_network_subnet\u0027,"},{"line_number":230,"context_line":"            type\u003dstr,"},{"line_number":231,"context_line":"            metavar\u003d\u0027\u003cshare_network_subnet\u003e\u0027,"},{"line_number":232,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":12,"id":"0f32f001_6bef3392","line":229,"range":{"start_line":229,"start_character":39,"end_line":229,"end_character":61},"in_reply_to":"c9cd1741_54127494","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":232,"context_line":"            default\u003dNone,"},{"line_number":233,"context_line":"            help\u003d\"Share network subnet where share server has network  \""},{"line_number":234,"context_line":"                 \"allocations in.The default subnet will be used if \""},{"line_number":235,"context_line":"                 \"it\u0027s not specified. Available for microversion \""},{"line_number":236,"context_line":"                 \"\u003e\u003d 2.51 (Optional, Default\u003dNone).\""},{"line_number":237,"context_line":"        )"},{"line_number":238,"context_line":"        return parser"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"7034b540_f8b6da7c","line":236,"range":{"start_line":235,"start_character":38,"end_line":236,"end_character":25},"updated":"2021-09-18 12:54:19.000000000","message":"same comment about adding the logic to check for the version.","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":232,"context_line":"            default\u003dNone,"},{"line_number":233,"context_line":"            help\u003d\"Share network subnet where share server has network  \""},{"line_number":234,"context_line":"                 \"allocations in.The default subnet will be used if \""},{"line_number":235,"context_line":"                 \"it\u0027s not specified. Available for microversion \""},{"line_number":236,"context_line":"                 \"\u003e\u003d 2.51 (Optional, Default\u003dNone).\""},{"line_number":237,"context_line":"        )"},{"line_number":238,"context_line":"        return parser"},{"line_number":239,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"4db12501_e7218ab9","line":236,"range":{"start_line":235,"start_character":38,"end_line":236,"end_character":25},"in_reply_to":"7034b540_f8b6da7c","updated":"2021-09-24 12:25:20.000000000","message":"Done","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"3aa7536b20b8cc520ad77b8852b33d047b31817c","unresolved":true,"context_lines":[{"line_number":323,"context_line":"            \"--status\","},{"line_number":324,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"67d40021_7b9a529e","line":326,"updated":"2021-09-18 16:31:24.000000000","message":"it is possible to use the ``choices`` flag to display these options. See  https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#options-with-choices. It would allow you to make the help text shorter","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dec33be1b97a0880ca03c4c783c4806caf7f980","unresolved":true,"context_lines":[{"line_number":323,"context_line":"            \"--status\","},{"line_number":324,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"de37ba46_81a4f3db","line":326,"in_reply_to":"67d40021_7b9a529e","updated":"2021-09-21 21:07:01.000000000","message":"+1 - Also, there are few more states as well, so I think it is worth checking it in manila","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            \"--status\","},{"line_number":324,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"2ae96436_a850e0ba","line":326,"in_reply_to":"9d5db76f_94d9fb63","updated":"2021-12-29 12:26:53.000000000","message":"Done","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":true,"context_lines":[{"line_number":323,"context_line":"            \"--status\","},{"line_number":324,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"}],"source_content_type":"text/x-python","patch_set":12,"id":"9d5db76f_94d9fb63","line":326,"in_reply_to":"de37ba46_81a4f3db","updated":"2021-09-24 12:25:20.000000000","message":"ty, ack :)","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"3aa7536b20b8cc520ad77b8852b33d047b31817c","unresolved":true,"context_lines":[{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":"        return parser"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"44303d8f_f34b550b","line":329,"range":{"start_line":328,"start_character":36,"end_line":329,"end_character":28},"updated":"2021-09-18 16:31:24.000000000","message":"I can be mistaken, but adding a flag default\u003d\"active\" may be need to have this working","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dec33be1b97a0880ca03c4c783c4806caf7f980","unresolved":true,"context_lines":[{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":"        return parser"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"ae4da073_6343bb72","line":329,"range":{"start_line":328,"start_character":36,"end_line":329,"end_character":28},"in_reply_to":"44303d8f_f34b550b","updated":"2021-09-21 21:07:01.000000000","message":"+1","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            help\u003d_(\"Indicate which state to assign the share server. \""},{"line_number":326,"context_line":"                   \"Options include active, error, creating, deleting, \""},{"line_number":327,"context_line":"                   \"managing, unmanaging, manage_error and \""},{"line_number":328,"context_line":"                   \"unmanage_error. If no state is provided, active will \""},{"line_number":329,"context_line":"                   \"be used.\")"},{"line_number":330,"context_line":"        )"},{"line_number":331,"context_line":"        return parser"},{"line_number":332,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"82c5ffdd_a77c104b","line":329,"range":{"start_line":328,"start_character":36,"end_line":329,"end_character":28},"in_reply_to":"ae4da073_6343bb72","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"618584a0f455ae5d9b430595ee2c45d7f4968543","unresolved":true,"context_lines":[{"line_number":349,"context_line":"                    {\u0027status\u0027: parsed_args.status, \u0027exception\u0027: e})"},{"line_number":350,"context_line":"                raise exceptions.CommandError(_(\"Set operation failed\"))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if not share_server or not parsed_args.status:"},{"line_number":353,"context_line":"            raise exceptions.CommandError(_("},{"line_number":354,"context_line":"                \"Nothing to set. Please define a \u0027--status\u0027.\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"757231c9_60f9c778","line":352,"range":{"start_line":352,"start_character":11,"end_line":352,"end_character":30},"updated":"2021-09-18 12:54:19.000000000","message":"share_server is a positional argument so if it is not provided, the user will already get an error. So you can only check for missing status here.","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                    {\u0027status\u0027: parsed_args.status, \u0027exception\u0027: e})"},{"line_number":350,"context_line":"                raise exceptions.CommandError(_(\"Set operation failed\"))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if not share_server or not parsed_args.status:"},{"line_number":353,"context_line":"            raise exceptions.CommandError(_("},{"line_number":354,"context_line":"                \"Nothing to set. Please define a \u0027--status\u0027.\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"e2251271_13cdd82a","line":352,"range":{"start_line":352,"start_character":11,"end_line":352,"end_character":30},"in_reply_to":"757231c9_60f9c778","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"3aa7536b20b8cc520ad77b8852b33d047b31817c","unresolved":true,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if not share_server or not parsed_args.status:"},{"line_number":353,"context_line":"            raise exceptions.CommandError(_("},{"line_number":354,"context_line":"                \"Nothing to set. Please define a \u0027--status\u0027.\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"a813049c_88015014","line":354,"range":{"start_line":354,"start_character":16,"end_line":354,"end_character":63},"updated":"2021-09-18 16:31:24.000000000","message":"at line 328-329 its said that if no status is provided, active will be used, so this exception may be an over effort.\nAlso manila share-server-reset-state \u003cid\u003e doesn\u0027t need any state -- it has active as default","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        if not share_server or not parsed_args.status:"},{"line_number":353,"context_line":"            raise exceptions.CommandError(_("},{"line_number":354,"context_line":"                \"Nothing to set. Please define a \u0027--status\u0027.\"))"}],"source_content_type":"text/x-python","patch_set":12,"id":"8f06156b_a9458572","line":354,"range":{"start_line":354,"start_character":16,"end_line":354,"end_character":63},"in_reply_to":"a813049c_88015014","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        share_network_subnet \u003d None"},{"line_number":163,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":164,"context_line":"                share_client.api_version \u003c api_version.APIVersion(\"2.51\")):"},{"line_number":165,"context_line":"            raise exceptions.CommandError("},{"line_number":166,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":167,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":14,"id":"b3561041_e7b130ea","line":164,"range":{"start_line":164,"start_character":41,"end_line":164,"end_character":42},"updated":"2021-10-02 07:56:34.000000000","message":"I believe equal to 2.51 should also be acceptable here","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        share_network_subnet \u003d None"},{"line_number":163,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":164,"context_line":"                share_client.api_version \u003c api_version.APIVersion(\"2.51\")):"},{"line_number":165,"context_line":"            raise exceptions.CommandError("},{"line_number":166,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":167,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":14,"id":"8b143d05_cf868723","line":164,"range":{"start_line":164,"start_character":41,"end_line":164,"end_character":42},"in_reply_to":"b3561041_e7b130ea","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":223,"context_line":"                   \"by the driver to manage the share server.\")"},{"line_number":224,"context_line":"        )"},{"line_number":225,"context_line":"        parser.add_argument("},{"line_number":226,"context_line":"            \u0027--driver-options\u0027, \u0027--driver-options\u0027,"},{"line_number":227,"context_line":"            type\u003dstr,"},{"line_number":228,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":229,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"fbf622a3_2d2282b9","line":226,"range":{"start_line":226,"start_character":12,"end_line":226,"end_character":51},"updated":"2021-10-02 07:56:34.000000000","message":"why add same option twice here? We only need one...","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                   \"by the driver to manage the share server.\")"},{"line_number":224,"context_line":"        )"},{"line_number":225,"context_line":"        parser.add_argument("},{"line_number":226,"context_line":"            \u0027--driver-options\u0027, \u0027--driver-options\u0027,"},{"line_number":227,"context_line":"            type\u003dstr,"},{"line_number":228,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":229,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"41e01790_f7b2d4cd","line":226,"range":{"start_line":226,"start_character":12,"end_line":226,"end_character":51},"in_reply_to":"fbf622a3_2d2282b9","updated":"2021-10-08 20:04:28.000000000","message":"i believe, i\u0027ve added this by mistake so removing one. thanks!","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":233,"context_line":"                   \"Default\u003dNone).\")"},{"line_number":234,"context_line":"        )"},{"line_number":235,"context_line":"        parser.add_argument("},{"line_number":236,"context_line":"            \u0027--share-network-subnet\u0027, \u0027--share-network-subnet\u0027,"},{"line_number":237,"context_line":"            type\u003dstr,"},{"line_number":238,"context_line":"            metavar\u003d\u0027\u003cshare-network-subnet\u003e\u0027,"},{"line_number":239,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ea80e0eb_5b169bfc","line":236,"range":{"start_line":236,"start_character":12,"end_line":236,"end_character":63},"updated":"2021-10-02 07:56:34.000000000","message":"same note as above.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":233,"context_line":"                   \"Default\u003dNone).\")"},{"line_number":234,"context_line":"        )"},{"line_number":235,"context_line":"        parser.add_argument("},{"line_number":236,"context_line":"            \u0027--share-network-subnet\u0027, \u0027--share-network-subnet\u0027,"},{"line_number":237,"context_line":"            type\u003dstr,"},{"line_number":238,"context_line":"            metavar\u003d\u0027\u003cshare-network-subnet\u003e\u0027,"},{"line_number":239,"context_line":"            default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":14,"id":"6c4b78d2_63404746","line":236,"range":{"start_line":236,"start_character":12,"end_line":236,"end_character":63},"in_reply_to":"ea80e0eb_5b169bfc","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        share_network_subnet \u003d None"},{"line_number":255,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":256,"context_line":"                share_client.api_version \u003c api_version.APIVersion(\"2.51\")):"},{"line_number":257,"context_line":"            raise exceptions.CommandError("},{"line_number":258,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":259,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":14,"id":"5e95a344_eb4b6ace","line":256,"range":{"start_line":256,"start_character":41,"end_line":256,"end_character":42},"updated":"2021-10-02 07:56:34.000000000","message":"again, equal to 2.51 should also work here.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        share_network_subnet \u003d None"},{"line_number":255,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":256,"context_line":"                share_client.api_version \u003c api_version.APIVersion(\"2.51\")):"},{"line_number":257,"context_line":"            raise exceptions.CommandError("},{"line_number":258,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":259,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":14,"id":"96868b41_a1f2e73f","line":256,"range":{"start_line":256,"start_character":41,"end_line":256,"end_character":42},"in_reply_to":"5e95a344_eb4b6ace","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        if result \u003e 0:"},{"line_number":376,"context_line":"            raise exceptions.CommandError(_(\"One or more of the \""},{"line_number":377,"context_line":"                                            \"set operations failed\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"bf6e1e31_dbf66323","line":377,"updated":"2021-10-02 07:56:34.000000000","message":"We are only running one set operation for one share server here, so we don\u0027t need to add the result counter at all, we can raise the exception right away when the operation fails.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        if result \u003e 0:"},{"line_number":376,"context_line":"            raise exceptions.CommandError(_(\"One or more of the \""},{"line_number":377,"context_line":"                                            \"set operations failed\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"c5e1b71f_cd4695d1","line":377,"in_reply_to":"bf6e1e31_dbf66323","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        share_network_subnet \u003d None"},{"line_number":163,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":164,"context_line":"                share_client.api_version \u003c\u003d api_version.APIVersion(\"2.51\")):"},{"line_number":165,"context_line":"            raise exceptions.CommandError("},{"line_number":166,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":167,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":16,"id":"60ad682a_7f1bbdcc","line":164,"range":{"start_line":164,"start_character":42,"end_line":164,"end_character":43},"updated":"2021-10-30 08:47:11.000000000","message":"Hmm, looks like I read this bit wrong in my previous comment, sorry about that, just \u003c is the correct option here since you are checking for the exception case, please revert this back. Sorry for the mixup :)","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        share_network_subnet \u003d None"},{"line_number":163,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":164,"context_line":"                share_client.api_version \u003c\u003d api_version.APIVersion(\"2.51\")):"},{"line_number":165,"context_line":"            raise exceptions.CommandError("},{"line_number":166,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":167,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":16,"id":"8acef762_a5d153df","line":164,"range":{"start_line":164,"start_character":42,"end_line":164,"end_character":43},"in_reply_to":"60ad682a_7f1bbdcc","updated":"2021-12-29 12:26:53.000000000","message":"Ack","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":true,"context_lines":[{"line_number":210,"context_line":"            help\u003d_(\u0027Backend name as \"\u003cnode_hostname\u003e@\u003cbackend_name\u003e\".\u0027)"},{"line_number":211,"context_line":"        )"},{"line_number":212,"context_line":"        parser.add_argument("},{"line_number":213,"context_line":"            \"--share-network\","},{"line_number":214,"context_line":"            metavar\u003d\"\u003cshare-network\u003e\","},{"line_number":215,"context_line":"            default\u003dFalse,"},{"line_number":216,"context_line":"            help\u003d_(\"Share network where share server has network \""}],"source_content_type":"text/x-python","patch_set":16,"id":"f712fe8b_2ca733b9","line":213,"range":{"start_line":213,"start_character":13,"end_line":213,"end_character":28},"updated":"2021-10-30 08:47:11.000000000","message":"Shouldn\u0027t this be mandatory?","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            help\u003d_(\u0027Backend name as \"\u003cnode_hostname\u003e@\u003cbackend_name\u003e\".\u0027)"},{"line_number":211,"context_line":"        )"},{"line_number":212,"context_line":"        parser.add_argument("},{"line_number":213,"context_line":"            \"--share-network\","},{"line_number":214,"context_line":"            metavar\u003d\"\u003cshare-network\u003e\","},{"line_number":215,"context_line":"            default\u003dFalse,"},{"line_number":216,"context_line":"            help\u003d_(\"Share network where share server has network \""}],"source_content_type":"text/x-python","patch_set":16,"id":"b537ac94_bc7e811c","line":213,"range":{"start_line":213,"start_character":13,"end_line":213,"end_character":28},"in_reply_to":"f712fe8b_2ca733b9","updated":"2021-12-29 12:26:53.000000000","message":"Yes, this is one of the mandatory arguments. I\u0027ve made some changes.","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d3e243da98d152bada5dd29fd3b73b025d90547e","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                 \"allocations in.The default subnet will be used if \""},{"line_number":243,"context_line":"                 \"it\u0027s not specified. Available for microversion \""},{"line_number":244,"context_line":"                 \"\u003e\u003d 2.51 (Optional, Default\u003dNone).\""},{"line_number":245,"context_line":"        )"},{"line_number":246,"context_line":"        return parser"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"2c77f53e_0a926ec8","line":245,"updated":"2021-10-30 13:05:37.000000000","message":"I think this should also have the \u0027--wait\u0027 option, right?","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":true,"context_lines":[{"line_number":242,"context_line":"                 \"allocations in.The default subnet will be used if \""},{"line_number":243,"context_line":"                 \"it\u0027s not specified. Available for microversion \""},{"line_number":244,"context_line":"                 \"\u003e\u003d 2.51 (Optional, Default\u003dNone).\""},{"line_number":245,"context_line":"        )"},{"line_number":246,"context_line":"        return parser"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"a3d0c440_e0332008","line":245,"in_reply_to":"2c77f53e_0a926ec8","updated":"2021-12-29 12:26:53.000000000","message":"I\u0027ve tried to add --wait flag unit test but facing this error. If you can share you views on it, that would be helpful. I might be doing some silly mistakes here but it would be easy if second person can share thought on it. \n\nHere is the error: https://paste.opendev.org/show/811729/\nand the code: https://paste.opendev.org/show/811878/","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                 \"allocations in.The default subnet will be used if \""},{"line_number":243,"context_line":"                 \"it\u0027s not specified. Available for microversion \""},{"line_number":244,"context_line":"                 \"\u003e\u003d 2.51 (Optional, Default\u003dNone).\""},{"line_number":245,"context_line":"        )"},{"line_number":246,"context_line":"        return parser"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3ab7ca62_510d7efa","line":245,"in_reply_to":"a3d0c440_e0332008","updated":"2022-05-10 23:11:50.000000000","message":"Done","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":true,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        share_network_subnet \u003d None"},{"line_number":258,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":259,"context_line":"                share_client.api_version \u003c\u003d api_version.APIVersion(\"2.51\")):"},{"line_number":260,"context_line":"            raise exceptions.CommandError("},{"line_number":261,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":262,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":16,"id":"fdba8483_815ace39","line":259,"range":{"start_line":259,"start_character":42,"end_line":259,"end_character":43},"updated":"2021-10-30 08:47:11.000000000","message":"Same note as above, \u003c was the correct check, please revert it back.","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        share_network_subnet \u003d None"},{"line_number":258,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":259,"context_line":"                share_client.api_version \u003c\u003d api_version.APIVersion(\"2.51\")):"},{"line_number":260,"context_line":"            raise exceptions.CommandError("},{"line_number":261,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":262,"context_line":"                \"version \u003e\u003d 2.51\""}],"source_content_type":"text/x-python","patch_set":16,"id":"cc2b4704_6f2c0565","line":259,"range":{"start_line":259,"start_character":42,"end_line":259,"end_character":43},"in_reply_to":"fdba8483_815ace39","updated":"2021-12-29 12:26:53.000000000","message":"Ack","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d3e243da98d152bada5dd29fd3b73b025d90547e","unresolved":true,"context_lines":[{"line_number":297,"context_line":"            default\u003dFalse,"},{"line_number":298,"context_line":"            help\u003d_(\"Enforces the unmanage share server operation, even \""},{"line_number":299,"context_line":"                   \"if the backend driver does not support it.\")"},{"line_number":300,"context_line":"        )"},{"line_number":301,"context_line":"        return parser"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"78c35bc6_83daffbf","line":300,"updated":"2021-10-30 13:05:37.000000000","message":"This one too, should we add a \u0027--wait\u0027 option?","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":297,"context_line":"            default\u003dFalse,"},{"line_number":298,"context_line":"            help\u003d_(\"Enforces the unmanage share server operation, even \""},{"line_number":299,"context_line":"                   \"if the backend driver does not support it.\")"},{"line_number":300,"context_line":"        )"},{"line_number":301,"context_line":"        return parser"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9f8e443b_90c1241f","line":300,"in_reply_to":"78c35bc6_83daffbf","updated":"2021-12-29 12:26:53.000000000","message":"Done","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":true,"context_lines":[{"line_number":350,"context_line":"                     \u0027unmanage_error\u0027],"},{"line_number":351,"context_line":"            help\u003d_(\"Assign a status to the share server. Options include: \""},{"line_number":352,"context_line":"                   \"active, error, creating, deleting, managing, unmanaging, \""},{"line_number":353,"context_line":"                   \"manage_error and unmanage_error. If no state is \""},{"line_number":354,"context_line":"                   \"provided, active will be used.\")"},{"line_number":355,"context_line":"        )"},{"line_number":356,"context_line":"        return parser"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"64c00481_7074b2df","line":354,"range":{"start_line":353,"start_character":53,"end_line":354,"end_character":50},"updated":"2021-10-30 08:47:11.000000000","message":"I think there is no good way to actually implement this, the only thing that this command does is set the status, right. So, if no \u0027--status\u0027 option is passed we should prompt the user to do so and keep things clear. We could add required\u003dTrue to the option, see https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#required-options, what do you think? With that, we could also lose the if statement below, on line 366 :)","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                     \u0027unmanage_error\u0027],"},{"line_number":351,"context_line":"            help\u003d_(\"Assign a status to the share server. Options include: \""},{"line_number":352,"context_line":"                   \"active, error, creating, deleting, managing, unmanaging, \""},{"line_number":353,"context_line":"                   \"manage_error and unmanage_error. If no state is \""},{"line_number":354,"context_line":"                   \"provided, active will be used.\")"},{"line_number":355,"context_line":"        )"},{"line_number":356,"context_line":"        return parser"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"f9e16d7e_be3aaa0f","line":354,"range":{"start_line":353,"start_character":53,"end_line":354,"end_character":50},"in_reply_to":"64c00481_7074b2df","updated":"2021-12-29 12:26:53.000000000","message":"Yeah, I agree! It did work in that way better.","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":true,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def take_action(self, parsed_args):"},{"line_number":359,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":360,"context_line":"        result \u003d 0"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        share_server \u003d osc_utils.find_resource("},{"line_number":363,"context_line":"            share_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":16,"id":"62c9e09d_bd2cc758","line":360,"updated":"2021-10-30 08:47:11.000000000","message":"I think we don\u0027t need a counter here, we can only set one option (status) for one share server at a time.","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def take_action(self, parsed_args):"},{"line_number":359,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":360,"context_line":"        result \u003d 0"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"        share_server \u003d osc_utils.find_resource("},{"line_number":363,"context_line":"            share_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":16,"id":"e389bd5f_c09beb3e","line":360,"in_reply_to":"62c9e09d_bd2cc758","updated":"2021-12-29 12:26:53.000000000","message":"Ack","commit_id":"30dbc73afdd24c23c42b53f9944bcf2b75b6af30"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from osc_lib.command import command"},{"line_number":17,"context_line":"from osc_lib import exceptions"},{"line_number":18,"context_line":"from osc_lib import utils"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manilaclient.common._i18n import _"}],"source_content_type":"text/x-python","patch_set":26,"id":"9eee352d_9cb4228f","line":18,"updated":"2022-02-17 08:18:43.000000000","message":"I believe this is duplicated, since the line below already imports the osc_lib.utils module.","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a58faf94b47de39c960625620ac2d00c411f32e2","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from osc_lib.command import command"},{"line_number":17,"context_line":"from osc_lib import exceptions"},{"line_number":18,"context_line":"from osc_lib import utils"},{"line_number":19,"context_line":"from osc_lib import utils as osc_utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manilaclient.common._i18n import _"}],"source_content_type":"text/x-python","patch_set":26,"id":"1e2587f8_d691ab5b","line":18,"in_reply_to":"9eee352d_9cb4228f","updated":"2022-04-11 17:53:45.000000000","message":"Done","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":54,"context_line":"                    share_client.share_servers,"},{"line_number":55,"context_line":"                    parsed_args.share_server)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                share_client.share_servers.delete(server_obj)"},{"line_number":58,"context_line":"                if parsed_args.wait:"},{"line_number":59,"context_line":"                    if not utils.wait_for_delete("},{"line_number":60,"context_line":"                            manager\u003dshare_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":26,"id":"f0063466_bd4b79ea","line":57,"updated":"2022-02-17 08:18:43.000000000","message":"The share server delete operation is not working for me. When I try to delete an empty share server, I get an error message saying \"\u0027list\u0027 object has no attribute \u0027isdigit\u0027\". [1]\n\nThe same happens if I try to delete a share server holding shares in it. It should say something like \"Share server \u003cshare server ID\u003e is in use.\". Instead, as above, it says \"\u0027list\u0027 object has no attribute \u0027isdigit\u0027\" [2]. I\u0027ve included two tracebacks: one for the share server delete operation on an empty share server [3], and one for a share server with one share created in it. [4]\n\n[1] https://i.imgur.com/pj06fcu.png\n[2] https://i.imgur.com/fFWH2Es.png\n[3] https://paste.opendev.org/show/812775/\n[4] https://paste.opendev.org/show/812774/","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    share_client.share_servers,"},{"line_number":55,"context_line":"                    parsed_args.share_server)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"                share_client.share_servers.delete(server_obj)"},{"line_number":58,"context_line":"                if parsed_args.wait:"},{"line_number":59,"context_line":"                    if not utils.wait_for_delete("},{"line_number":60,"context_line":"                            manager\u003dshare_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":26,"id":"173d627c_842dbc07","line":57,"in_reply_to":"f0063466_bd4b79ea","updated":"2022-05-10 23:11:50.000000000","message":"Found the issue, line 54 - In that line we are passing a list to the find, when we should be passing the server loop variable instead","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ShowShareServer(command.ShowOne):"},{"line_number":80,"context_line":"    \"\"\"Show share server.\"\"\""},{"line_number":81,"context_line":"    _description \u003d _(\"Show details about a server\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def get_parser(self, prog_name):"},{"line_number":84,"context_line":"        parser \u003d super(ShowShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"4732967a_ca7d15c8","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":51},"updated":"2022-02-17 08:18:43.000000000","message":"The share server show operation is also admin only, as per manila help share-server-show.","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a58faf94b47de39c960625620ac2d00c411f32e2","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class ShowShareServer(command.ShowOne):"},{"line_number":80,"context_line":"    \"\"\"Show share server.\"\"\""},{"line_number":81,"context_line":"    _description \u003d _(\"Show details about a server\")"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def get_parser(self, prog_name):"},{"line_number":84,"context_line":"        parser \u003d super(ShowShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"978eedc8_3e99dd12","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":51},"in_reply_to":"4732967a_ca7d15c8","updated":"2022-04-11 17:53:45.000000000","message":"Done","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            share_client.share_servers,"},{"line_number":97,"context_line":"            parsed_args.share_server)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class ListShareServer(command.Lister):"}],"source_content_type":"text/x-python","patch_set":26,"id":"bcd6c934_bca2af05","line":99,"updated":"2022-02-17 08:18:43.000000000","message":"Very very nit: The table rows are not displayed in the same order as in manila share-server-show [1], just to point it out. This is actually pretty fine with me (maybe this already comes ordered from osc_lib.utils?), so I\u0027m already marking this comment as resolved.\n\n[1] https://i.imgur.com/QK6WlJI.png","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a58faf94b47de39c960625620ac2d00c411f32e2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            share_client.share_servers,"},{"line_number":97,"context_line":"            parsed_args.share_server)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class ListShareServer(command.Lister):"}],"source_content_type":"text/x-python","patch_set":26,"id":"0493c0ae_ebe4e877","line":99,"in_reply_to":"bcd6c934_bca2af05","updated":"2022-04-11 17:53:45.000000000","message":"ack!","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":153,"context_line":"                parsed_args.project,"},{"line_number":154,"context_line":"                parsed_args.project_domain).id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        share_network \u003d None"},{"line_number":157,"context_line":"        if parsed_args.share_network:"},{"line_number":158,"context_line":"            share_network \u003d osc_utils.find_resource("},{"line_number":159,"context_line":"                share_client.share_networks,"},{"line_number":160,"context_line":"                parsed_args.share_network).id"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        share_network_subnet \u003d None"},{"line_number":163,"context_line":"        if (parsed_args.share_network_subnet and"}],"source_content_type":"text/x-python","patch_set":26,"id":"afe0b239_10e919c7","line":160,"range":{"start_line":156,"start_character":0,"end_line":160,"end_character":45},"updated":"2022-02-17 08:18:43.000000000","message":"For some reason the share server list operation isn\u0027t displaying the share network column [1]. I tried changing osc_utils.find_resource().id to osc_utils.find_resource().name but it didn\u0027t work. I\u0027ve included a debug run. [2]\n\n[1] https://i.imgur.com/qRVZ6P2.png\n[2] https://paste.opendev.org/show/812773/","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":153,"context_line":"                parsed_args.project,"},{"line_number":154,"context_line":"                parsed_args.project_domain).id"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        share_network \u003d None"},{"line_number":157,"context_line":"        if parsed_args.share_network:"},{"line_number":158,"context_line":"            share_network \u003d osc_utils.find_resource("},{"line_number":159,"context_line":"                share_client.share_networks,"},{"line_number":160,"context_line":"                parsed_args.share_network).id"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        share_network_subnet \u003d None"},{"line_number":163,"context_line":"        if (parsed_args.share_network_subnet and"}],"source_content_type":"text/x-python","patch_set":26,"id":"87e16751_4b16d9d1","line":160,"range":{"start_line":156,"start_character":0,"end_line":160,"end_character":45},"in_reply_to":"afe0b239_10e919c7","updated":"2022-05-10 23:11:50.000000000","message":"I think we can drop this.  The API is already doing that validation... I understand we could fail earlier but doing two calls to manila just to do that doesn\u0027t sound like a good idea.","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":199,"context_line":"class AdoptShareServer(command.ShowOne):"},{"line_number":200,"context_line":"    \"\"\"Adopt share server not handled by Manila (Admin only).\"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    _description \u003d _(\"Adopt share server not handled by Manila \")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def get_parser(self, prog_name):"},{"line_number":205,"context_line":"        parser \u003d super(AdoptShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"095b7479_58d8b4b1","line":202,"range":{"start_line":202,"start_character":21,"end_line":202,"end_character":64},"updated":"2022-02-17 08:18:43.000000000","message":"The \"(Admin only)\" parenthesis is also needed here, or else it won\u0027t be displayed in the help message. [1]\n\n[1] https://i.imgur.com/qslZ9gn.png","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a58faf94b47de39c960625620ac2d00c411f32e2","unresolved":false,"context_lines":[{"line_number":199,"context_line":"class AdoptShareServer(command.ShowOne):"},{"line_number":200,"context_line":"    \"\"\"Adopt share server not handled by Manila (Admin only).\"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    _description \u003d _(\"Adopt share server not handled by Manila \")"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def get_parser(self, prog_name):"},{"line_number":205,"context_line":"        parser \u003d super(AdoptShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"8a849513_f74a35d3","line":202,"range":{"start_line":202,"start_character":21,"end_line":202,"end_character":64},"in_reply_to":"095b7479_58d8b4b1","updated":"2022-04-11 17:53:45.000000000","message":"Done","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":253,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        share_network \u003d None"},{"line_number":256,"context_line":"        if parsed_args.share_network:"},{"line_number":257,"context_line":"            share_network \u003d osc_utils.find_resource("},{"line_number":258,"context_line":"                share_client.share_networks,"},{"line_number":259,"context_line":"                parsed_args.share_network).id"}],"source_content_type":"text/x-python","patch_set":26,"id":"237ff7df_16e32db2","line":256,"updated":"2022-02-17 08:18:43.000000000","message":"The share server adopt operation didn\u0027t work for me. I got \"\u0027Namespace\u0027 object has no attribute \u0027share_network\u0027\" [1]. I\u0027ve included a traceback. [2]\n\n[1] https://i.imgur.com/sXB8QG3.png\n[2] https://paste.opendev.org/show/812771/","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        share_network \u003d None"},{"line_number":256,"context_line":"        if parsed_args.share_network:"},{"line_number":257,"context_line":"            share_network \u003d osc_utils.find_resource("},{"line_number":258,"context_line":"                share_client.share_networks,"},{"line_number":259,"context_line":"                parsed_args.share_network).id"}],"source_content_type":"text/x-python","patch_set":26,"id":"bcd6edef_a59a2b3d","line":256,"in_reply_to":"237ff7df_16e32db2","updated":"2022-05-10 23:11:50.000000000","message":"Done","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a83ddd0ff1d3fb22d5e6dcdb30518cff0a68c09","unresolved":true,"context_lines":[{"line_number":298,"context_line":"class AbandonShareServer(command.Command):"},{"line_number":299,"context_line":"    \"\"\"Abandon one or more share servers (Admin only).\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    _description \u003d _(\"Abandon share server(s)\")"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def get_parser(self, prog_name):"},{"line_number":304,"context_line":"        parser \u003d super(AbandonShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"0268a36b_3a6f7e31","line":301,"range":{"start_line":301,"start_character":21,"end_line":301,"end_character":46},"updated":"2022-02-17 08:18:43.000000000","message":"Also missing the \"(Admin only)\" parenthesis. [1]\n\n[1] https://i.imgur.com/aA5VdJd.png","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a58faf94b47de39c960625620ac2d00c411f32e2","unresolved":false,"context_lines":[{"line_number":298,"context_line":"class AbandonShareServer(command.Command):"},{"line_number":299,"context_line":"    \"\"\"Abandon one or more share servers (Admin only).\"\"\""},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"    _description \u003d _(\"Abandon share server(s)\")"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def get_parser(self, prog_name):"},{"line_number":304,"context_line":"        parser \u003d super(AbandonShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":26,"id":"05961eae_302b113a","line":301,"range":{"start_line":301,"start_character":21,"end_line":301,"end_character":46},"in_reply_to":"0268a36b_3a6f7e31","updated":"2022-04-11 17:53:45.000000000","message":"Done","commit_id":"cb3fb2524c056be6c28f3efbf9f7c9707105aea3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        for server in parsed_args.share_server:"},{"line_number":51,"context_line":"            try:"},{"line_number":52,"context_line":"                server_obj \u003d utils.find_resource("},{"line_number":53,"context_line":"                    share_client.share_servers,"},{"line_number":54,"context_line":"                    parsed_args.share_server)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"0fa69a08_0db433a8","line":52,"range":{"start_line":52,"start_character":29,"end_line":52,"end_character":35},"updated":"2022-05-10 23:11:50.000000000","message":"missing an import for utils... it\u0027s raising an exception like: \nFailed to delete a share server with ID \u0027ecd74cd3-dde2-4995-84d6-4bfd219a53ee\u0027: name \u0027utils\u0027 is not defined","commit_id":"425c5f02e99bad5713a9d18008e7eb4239a46dea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            share_client.share_servers,"},{"line_number":96,"context_line":"            parsed_args.share_server)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class ListShareServer(command.Lister):"}],"source_content_type":"text/x-python","patch_set":27,"id":"69f35d09_671bcd7b","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":52},"updated":"2022-05-10 23:11:50.000000000","message":"the formatting for this is taking the entire screen and displaying it as a dict... We could possibly do something like we do for export locations","commit_id":"425c5f02e99bad5713a9d18008e7eb4239a46dea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                share_client.share_networks,"},{"line_number":159,"context_line":"                parsed_args.share_network).id"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        share_network_subnet \u003d None"},{"line_number":162,"context_line":"        if (parsed_args.share_network_subnet and"},{"line_number":163,"context_line":"                share_client.api_version \u003c api_version.APIVersion(\"2.51\")):"},{"line_number":164,"context_line":"            raise exceptions.CommandError("},{"line_number":165,"context_line":"                \"Share network subnet can be specified only with manila API \""},{"line_number":166,"context_line":"                \"version \u003e\u003d 2.51\""},{"line_number":167,"context_line":"            )"},{"line_number":168,"context_line":"        elif parsed_args.share_network_subnet:"},{"line_number":169,"context_line":"            share_network_subnet \u003d osc_utils.find_resource("},{"line_number":170,"context_line":"                share_client.share_network_subnets,"},{"line_number":171,"context_line":"                parsed_args.share_network_subnet).id"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        columns \u003d ["},{"line_number":174,"context_line":"            \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"2efd0dfc_d67c29f6","line":171,"range":{"start_line":161,"start_character":7,"end_line":171,"end_character":52},"updated":"2022-05-10 23:11:50.000000000","message":"Filtering by share network subnets also doesn\u0027t work with native manilaclient - I think there\u0027s a bug there. I\u0027ll report it","commit_id":"425c5f02e99bad5713a9d18008e7eb4239a46dea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        data \u003d (osc_utils.get_dict_properties("},{"line_number":193,"context_line":"            share_server._info, columns) for share_server in share_servers)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        return (columns, data)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"class AdoptShareServer(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":27,"id":"99b149de_4ab078d2","line":195,"range":{"start_line":195,"start_character":8,"end_line":195,"end_character":30},"updated":"2022-05-10 23:11:50.000000000","message":"share network is not being printed out","commit_id":"425c5f02e99bad5713a9d18008e7eb4239a46dea"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f9c4c7b294ac00ee8423b19f0b6450c275c67e52","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        parser.add_argument("},{"line_number":377,"context_line":"            \"--status\","},{"line_number":378,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":379,"context_line":"            choices\u003d[\u0027active\u0027, \u0027error\u0027, \u0027creating\u0027, \u0027deleting\u0027,"},{"line_number":380,"context_line":"                     \u0027managing\u0027, \u0027manage_error\u0027, \u0027unmanaging\u0027"},{"line_number":381,"context_line":"                     \u0027unmanage_error\u0027],"},{"line_number":382,"context_line":"            required\u003dTrue,"},{"line_number":383,"context_line":"            help\u003d_(\"Assign a status to the share server. Options include: \""},{"line_number":384,"context_line":"                   \"active, error, creating, deleting, managing, unmanaging, \""}],"source_content_type":"text/x-python","patch_set":27,"id":"6f9ec86e_0c294569","line":381,"range":{"start_line":379,"start_character":20,"end_line":381,"end_character":38},"updated":"2022-05-10 23:11:50.000000000","message":"the valid states are: unmanage_starting, server_migrating_to, error, unmanage_error, manage_error, inactive, active, server_migrating, manage_starting, deleting, network_change...\nI tried setting managing but it didn\u0027t let me :)","commit_id":"425c5f02e99bad5713a9d18008e7eb4239a46dea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class DeleteShareServer(command.Command):"},{"line_number":26,"context_line":"    \"\"\"Delete one or more share servers\"\"\""},{"line_number":27,"context_line":"    _description \u003d _("},{"line_number":28,"context_line":"        \"Delete one or more share servers\")"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bd845be6_88b8a219","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":42},"updated":"2022-07-07 21:27:54.000000000","message":"(Admin only)","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class DeleteShareServer(command.Command):"},{"line_number":26,"context_line":"    \"\"\"Delete one or more share servers\"\"\""},{"line_number":27,"context_line":"    _description \u003d _("},{"line_number":28,"context_line":"        \"Delete one or more share servers\")"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"c4ecbd8e_bd7e130a","line":26,"range":{"start_line":26,"start_character":39,"end_line":26,"end_character":42},"in_reply_to":"bd845be6_88b8a219","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            \"share_servers\","},{"line_number":34,"context_line":"            metavar\u003d\"\u003cshare-server\u003e\","},{"line_number":35,"context_line":"            nargs\u003d\"+\","},{"line_number":36,"context_line":"            help\u003d_(\"ID of the server(s) to delete\")"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        parser.add_argument("},{"line_number":39,"context_line":"            \"--wait\","}],"source_content_type":"text/x-python","patch_set":29,"id":"44233cf9_66403a4d","line":36,"range":{"start_line":36,"start_character":30,"end_line":36,"end_character":36},"updated":"2022-07-07 21:27:54.000000000","message":"ID(s) of the share server(s) to delete","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \"share_servers\","},{"line_number":34,"context_line":"            metavar\u003d\"\u003cshare-server\u003e\","},{"line_number":35,"context_line":"            nargs\u003d\"+\","},{"line_number":36,"context_line":"            help\u003d_(\"ID of the server(s) to delete\")"},{"line_number":37,"context_line":"        )"},{"line_number":38,"context_line":"        parser.add_argument("},{"line_number":39,"context_line":"            \"--wait\","}],"source_content_type":"text/x-python","patch_set":29,"id":"8946902b_622265c5","line":36,"range":{"start_line":36,"start_character":30,"end_line":36,"end_character":36},"in_reply_to":"44233cf9_66403a4d","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if result \u003e 0:"},{"line_number":70,"context_line":"            total \u003d len(parsed_args.share_servers)"},{"line_number":71,"context_line":"            msg \u003d (_(\"Failed to delete a share server for \""},{"line_number":72,"context_line":"                     \"%(result)s out of %(total)s \")"},{"line_number":73,"context_line":"                   % {\u0027result\u0027: result, \u0027total\u0027: total})"},{"line_number":74,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"218f0b99_f1f6106f","line":72,"range":{"start_line":71,"start_character":21,"end_line":72,"end_character":50},"updated":"2022-07-07 21:27:54.000000000","message":"f\u0027Failed to delete {result} servers out of {total}\u0027","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if result \u003e 0:"},{"line_number":70,"context_line":"            total \u003d len(parsed_args.share_servers)"},{"line_number":71,"context_line":"            msg \u003d (_(\"Failed to delete a share server for \""},{"line_number":72,"context_line":"                     \"%(result)s out of %(total)s \")"},{"line_number":73,"context_line":"                   % {\u0027result\u0027: result, \u0027total\u0027: total})"},{"line_number":74,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"55eb5167_72972be7","line":72,"range":{"start_line":71,"start_character":21,"end_line":72,"end_character":50},"in_reply_to":"218f0b99_f1f6106f","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class ShowShareServer(command.ShowOne):"},{"line_number":78,"context_line":"    \"\"\"Show share server (Admin only).\"\"\""},{"line_number":79,"context_line":"    _description \u003d _(\"Show details about a server (Admin only).\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(ShowShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"5e273ca0_c7c569ea","line":79,"range":{"start_line":79,"start_character":43,"end_line":79,"end_character":49},"updated":"2022-07-07 21:27:54.000000000","message":"share server","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"class ShowShareServer(command.ShowOne):"},{"line_number":78,"context_line":"    \"\"\"Show share server (Admin only).\"\"\""},{"line_number":79,"context_line":"    _description \u003d _(\"Show details about a server (Admin only).\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(ShowShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"c023c332_d1f31d65","line":79,"range":{"start_line":79,"start_character":43,"end_line":79,"end_character":49},"in_reply_to":"5e273ca0_c7c569ea","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        # so remove big dict from view."},{"line_number":99,"context_line":"        if \"backend_details\" in share_server._info:"},{"line_number":100,"context_line":"            del share_server._info[\"backend_details\"]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"07489586_e455dd84","line":101,"updated":"2022-07-07 21:27:54.000000000","message":"do we have to pop \"links\"","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # so remove big dict from view."},{"line_number":99,"context_line":"        if \"backend_details\" in share_server._info:"},{"line_number":100,"context_line":"            del share_server._info[\"backend_details\"]"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"eb84314e_2f04e346","line":101,"in_reply_to":"07489586_e455dd84","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":124,"context_line":"            \u0027--share-network\u0027,"},{"line_number":125,"context_line":"            metavar\u003d\u0027\u003cshare-network\u003e\u0027,"},{"line_number":126,"context_line":"            default\u003dNone,"},{"line_number":127,"context_line":"            help\u003d_(\u0027Filter results by share network.\u0027),"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--project-id\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fdfb8c9a_f35c910d","line":127,"range":{"start_line":127,"start_character":51,"end_line":127,"end_character":53},"updated":"2022-07-07 21:27:54.000000000","message":"(name or ID)","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            \u0027--share-network\u0027,"},{"line_number":125,"context_line":"            metavar\u003d\u0027\u003cshare-network\u003e\u0027,"},{"line_number":126,"context_line":"            default\u003dNone,"},{"line_number":127,"context_line":"            help\u003d_(\u0027Filter results by share network.\u0027),"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--project-id\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"31a75777_df98346c","line":127,"range":{"start_line":127,"start_character":51,"end_line":127,"end_character":53},"in_reply_to":"fdfb8c9a_f35c910d","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":127,"context_line":"            help\u003d_(\u0027Filter results by share network.\u0027),"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--project-id\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cproject-id\u003e\u0027,"},{"line_number":132,"context_line":"            default\u003dNone,"},{"line_number":133,"context_line":"            help\u003d_(\u0027Filter results by project ID.\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"ef7d2832_2b462c0f","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":25},"updated":"2022-07-07 21:27:54.000000000","message":"no need for \"id\" in the option if both name or ID are accepted","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            help\u003d_(\u0027Filter results by share network.\u0027),"},{"line_number":128,"context_line":"        )"},{"line_number":129,"context_line":"        parser.add_argument("},{"line_number":130,"context_line":"            \u0027--project-id\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cproject-id\u003e\u0027,"},{"line_number":132,"context_line":"            default\u003dNone,"},{"line_number":133,"context_line":"            help\u003d_(\u0027Filter results by project ID.\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"625b3237_659b0c1e","line":130,"range":{"start_line":130,"start_character":13,"end_line":130,"end_character":25},"in_reply_to":"ef7d2832_2b462c0f","updated":"2022-07-08 22:12:26.000000000","message":"I would not say so... we can drop the \u0027id\u0027","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":130,"context_line":"            \u0027--project-id\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cproject-id\u003e\u0027,"},{"line_number":132,"context_line":"            default\u003dNone,"},{"line_number":133,"context_line":"            help\u003d_(\u0027Filter results by project ID.\u0027)"},{"line_number":134,"context_line":"        )"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--share-network-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"f90d5599_abcfada4","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":51},"updated":"2022-07-07 21:27:54.000000000","message":"help\u003d_(\u0027Filter results by project (name or ID)\u0027)","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            \u0027--project-id\u0027,"},{"line_number":131,"context_line":"            metavar\u003d\u0027\u003cproject-id\u003e\u0027,"},{"line_number":132,"context_line":"            default\u003dNone,"},{"line_number":133,"context_line":"            help\u003d_(\u0027Filter results by project ID.\u0027)"},{"line_number":134,"context_line":"        )"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027--share-network-subnet\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"8563028e_57d5d7aa","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":51},"in_reply_to":"f90d5599_abcfada4","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            type\u003dstr,"},{"line_number":139,"context_line":"            default\u003dNone,"},{"line_number":140,"context_line":"            help\u003d_(\"Filter results by share network subnet that the \""},{"line_number":141,"context_line":"                   \"share server\u0027s network allocation exists whithin. \""},{"line_number":142,"context_line":"                   \"Available for microversion \u003e\u003d 2.51 (Optional, \""},{"line_number":143,"context_line":"                   \"Default\u003dNone)\")"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":29,"id":"6b9f5f9f_95337f63","line":141,"range":{"start_line":141,"start_character":61,"end_line":141,"end_character":68},"updated":"2022-07-07 21:27:54.000000000","message":"within","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            type\u003dstr,"},{"line_number":139,"context_line":"            default\u003dNone,"},{"line_number":140,"context_line":"            help\u003d_(\"Filter results by share network subnet that the \""},{"line_number":141,"context_line":"                   \"share server\u0027s network allocation exists whithin. \""},{"line_number":142,"context_line":"                   \"Available for microversion \u003e\u003d 2.51 (Optional, \""},{"line_number":143,"context_line":"                   \"Default\u003dNone)\")"},{"line_number":144,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":29,"id":"13d93f2f_9ee97a10","line":141,"range":{"start_line":141,"start_character":61,"end_line":141,"end_character":68},"in_reply_to":"6b9f5f9f_95337f63","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if parsed_args.share_network:"},{"line_number":181,"context_line":"            search_opts[\u0027share_network\u0027] \u003d parsed_args.share_network"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share_network_subnet:"},{"line_number":184,"context_line":"            search_opts["}],"source_content_type":"text/x-python","patch_set":29,"id":"6911cc1d_c949da93","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":68},"updated":"2022-07-07 21:27:54.000000000","message":"This could be an ID or name, so we should resolve this via apiutils.find_resource","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        if parsed_args.share_network:"},{"line_number":181,"context_line":"            search_opts[\u0027share_network\u0027] \u003d parsed_args.share_network"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if parsed_args.share_network_subnet:"},{"line_number":184,"context_line":"            search_opts["}],"source_content_type":"text/x-python","patch_set":29,"id":"6162d813_41ee0a52","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":68},"in_reply_to":"6911cc1d_c949da93","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":222,"context_line":"        parser.add_argument("},{"line_number":223,"context_line":"            \u0027--driver-options\u0027,"},{"line_number":224,"context_line":"            type\u003dstr,"},{"line_number":225,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":226,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":227,"context_line":"            default\u003d{},"},{"line_number":228,"context_line":"            help\u003d_(\"One or more driver-specific key\u003dvalue pairs that may be \""}],"source_content_type":"text/x-python","patch_set":29,"id":"b0da53e9_6264e4c4","line":225,"range":{"start_line":225,"start_character":12,"end_line":225,"end_character":22},"updated":"2022-07-07 21:27:54.000000000","message":"instead of nargs, use a repeatable option; example: https://github.com/openstack/python-manilaclient/blob/0e7d3bfff16e6ebab8a57d68df0faf62dbac6ee8/manilaclient/osc/v2/share.py#L127-L134","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        parser.add_argument("},{"line_number":223,"context_line":"            \u0027--driver-options\u0027,"},{"line_number":224,"context_line":"            type\u003dstr,"},{"line_number":225,"context_line":"            nargs\u003d\u0027*\u0027,"},{"line_number":226,"context_line":"            metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":227,"context_line":"            default\u003d{},"},{"line_number":228,"context_line":"            help\u003d_(\"One or more driver-specific key\u003dvalue pairs that may be \""}],"source_content_type":"text/x-python","patch_set":29,"id":"d492801a_3ab53692","line":225,"range":{"start_line":225,"start_character":12,"end_line":225,"end_character":22},"in_reply_to":"b0da53e9_6264e4c4","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":287,"context_line":"                                                   share_server.id)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        share_server._info.pop(\u0027links\u0027, None)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # All \u0027backend_details\u0027 data already present as separated strings,"},{"line_number":292,"context_line":"        # so remove big dict from view."},{"line_number":293,"context_line":"        if \"backend_details\" in share_server._info:"},{"line_number":294,"context_line":"            del share_server._info[\"backend_details\"]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"af2a480d_81861805","line":294,"range":{"start_line":290,"start_character":0,"end_line":294,"end_character":53},"updated":"2022-07-07 21:27:54.000000000","message":"share_server._info.pop(\u0027backend_details\u0027, None)","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":287,"context_line":"                                                   share_server.id)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"        share_server._info.pop(\u0027links\u0027, None)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"        # All \u0027backend_details\u0027 data already present as separated strings,"},{"line_number":292,"context_line":"        # so remove big dict from view."},{"line_number":293,"context_line":"        if \"backend_details\" in share_server._info:"},{"line_number":294,"context_line":"            del share_server._info[\"backend_details\"]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":"        return self.dict2columns(share_server._info)"},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"e048b566_b363d291","line":294,"range":{"start_line":290,"start_character":0,"end_line":294,"end_character":53},"in_reply_to":"af2a480d_81861805","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":299,"context_line":"class AbandonShareServer(command.Command):"},{"line_number":300,"context_line":"    \"\"\"Abandon one or more share servers (Admin only).\"\"\""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    _description \u003d _(\"Abandon share server(s) (Admin only).\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_parser(self, prog_name):"},{"line_number":305,"context_line":"        parser \u003d super(AbandonShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"daef1a17_9398136e","line":302,"range":{"start_line":302,"start_character":22,"end_line":302,"end_character":29},"updated":"2022-07-07 21:27:54.000000000","message":"Remove one or more share servers from Manila management","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":299,"context_line":"class AbandonShareServer(command.Command):"},{"line_number":300,"context_line":"    \"\"\"Abandon one or more share servers (Admin only).\"\"\""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    _description \u003d _(\"Abandon share server(s) (Admin only).\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def get_parser(self, prog_name):"},{"line_number":305,"context_line":"        parser \u003d super(AbandonShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"70508803_e90ee18a","line":302,"range":{"start_line":302,"start_character":22,"end_line":302,"end_character":29},"in_reply_to":"daef1a17_9398136e","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if result \u003e 0:"},{"line_number":359,"context_line":"            total \u003d len(parsed_args.share_server)"},{"line_number":360,"context_line":"            msg \u003d (_(\"%(result)s of %(total)s servers failed \""},{"line_number":361,"context_line":"                   \"to abandon.\") % {\u0027result\u0027: result, \u0027total\u0027: total})"},{"line_number":362,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"f92d48e3_5ecbb2aa","line":361,"range":{"start_line":360,"start_character":21,"end_line":361,"end_character":31},"updated":"2022-07-07 21:27:54.000000000","message":"f\u0027Failed to abandon {result} of {total} share servers\u0027","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        if result \u003e 0:"},{"line_number":359,"context_line":"            total \u003d len(parsed_args.share_server)"},{"line_number":360,"context_line":"            msg \u003d (_(\"%(result)s of %(total)s servers failed \""},{"line_number":361,"context_line":"                   \"to abandon.\") % {\u0027result\u0027: result, \u0027total\u0027: total})"},{"line_number":362,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"e7a26deb_63336e96","line":361,"range":{"start_line":360,"start_character":21,"end_line":361,"end_character":31},"in_reply_to":"f92d48e3_5ecbb2aa","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":366,"context_line":"    \"\"\"Set share server\"\"\""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    _description \u003d _("},{"line_number":369,"context_line":"        \"Explicitly update the state of share server (Admin only).\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def get_parser(self, prog_name):"},{"line_number":372,"context_line":"        parser \u003d super(SetShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"b09030ed_0120963c","line":369,"range":{"start_line":369,"start_character":9,"end_line":369,"end_character":36},"updated":"2022-07-07 21:27:54.000000000","message":"Set share server properties\n\n\nFor future proofing if we allow updating anything else besides status","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":366,"context_line":"    \"\"\"Set share server\"\"\""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    _description \u003d _("},{"line_number":369,"context_line":"        \"Explicitly update the state of share server (Admin only).\")"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    def get_parser(self, prog_name):"},{"line_number":372,"context_line":"        parser \u003d super(SetShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"68d2cb93_4f2eefb6","line":369,"range":{"start_line":369,"start_character":9,"end_line":369,"end_character":36},"in_reply_to":"b09030ed_0120963c","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":384,"context_line":"        parser.add_argument("},{"line_number":385,"context_line":"            \"--status\","},{"line_number":386,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":387,"context_line":"            choices\u003dallowed_update_choices,"},{"line_number":388,"context_line":"            required\u003dTrue,"},{"line_number":389,"context_line":"            help\u003d_(\"Assign a status to the share server. Options \""},{"line_number":390,"context_line":"                   \"include: %s. If no state is \""}],"source_content_type":"text/x-python","patch_set":29,"id":"be6f4d1c_91c2532a","line":387,"range":{"start_line":387,"start_character":0,"end_line":387,"end_character":43},"updated":"2022-07-07 21:27:54.000000000","message":"The API performs this validation, so we don\u0027t need to do it here. Think of a time when a status is added or removed to manila, and the user is using an older client.\n\nYou could use this list as an example like you\u0027re doing below","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        parser.add_argument("},{"line_number":385,"context_line":"            \"--status\","},{"line_number":386,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":387,"context_line":"            choices\u003dallowed_update_choices,"},{"line_number":388,"context_line":"            required\u003dTrue,"},{"line_number":389,"context_line":"            help\u003d_(\"Assign a status to the share server. Options \""},{"line_number":390,"context_line":"                   \"include: %s. If no state is \""}],"source_content_type":"text/x-python","patch_set":29,"id":"8c1c2479_a70ce9bf","line":387,"range":{"start_line":387,"start_character":0,"end_line":387,"end_character":43},"in_reply_to":"be6f4d1c_91c2532a","updated":"2022-07-08 22:12:26.000000000","message":"Ack","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4b26240a21f728c77b2d8e6ab46179f441740d9","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if result \u003e 0:"},{"line_number":71,"context_line":"            total \u003d len(parsed_args.share_servers)"},{"line_number":72,"context_line":"            msg \u003d (_(f\u0027Failed to delete a share server for \u0027"},{"line_number":73,"context_line":"                     f\u0027{result}s out of {total}s \u0027))"},{"line_number":74,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"54d94e6d_9d8abaa8","line":73,"range":{"start_line":72,"start_character":20,"end_line":73,"end_character":52},"updated":"2022-07-11 19:41:33.000000000","message":"incorrect, grammatically.. \n\n f\u0027Failed to delete {result} servers out of {total}\u0027","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c995574c230848f918abd1a1fbbf26407992c128","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if result \u003e 0:"},{"line_number":71,"context_line":"            total \u003d len(parsed_args.share_servers)"},{"line_number":72,"context_line":"            msg \u003d (_(f\u0027Failed to delete a share server for \u0027"},{"line_number":73,"context_line":"                     f\u0027{result}s out of {total}s \u0027))"},{"line_number":74,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"70c0b8c2_01d00d95","line":73,"range":{"start_line":72,"start_character":20,"end_line":73,"end_character":52},"in_reply_to":"54d94e6d_9d8abaa8","updated":"2022-07-11 21:19:05.000000000","message":"Done","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4b26240a21f728c77b2d8e6ab46179f441740d9","unresolved":true,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"class AbandonShareServer(command.Command):"},{"line_number":303,"context_line":"    \"\"\"Remove one or more share servers (Admin only).\"\"\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    _description \u003d _(\"Abandon share server(s) (Admin only).\")"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def get_parser(self, prog_name):"},{"line_number":308,"context_line":"        parser \u003d super(AbandonShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":30,"id":"e99f217f_8862452f","line":305,"range":{"start_line":303,"start_character":3,"end_line":305,"end_character":61},"updated":"2022-07-11 19:41:33.000000000","message":"Change in line 303 should be reflected in the description..","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c995574c230848f918abd1a1fbbf26407992c128","unresolved":false,"context_lines":[{"line_number":300,"context_line":""},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"class AbandonShareServer(command.Command):"},{"line_number":303,"context_line":"    \"\"\"Remove one or more share servers (Admin only).\"\"\""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    _description \u003d _(\"Abandon share server(s) (Admin only).\")"},{"line_number":306,"context_line":""},{"line_number":307,"context_line":"    def get_parser(self, prog_name):"},{"line_number":308,"context_line":"        parser \u003d super(AbandonShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":30,"id":"9229d637_3b2930e7","line":305,"range":{"start_line":303,"start_character":3,"end_line":305,"end_character":61},"in_reply_to":"e99f217f_8862452f","updated":"2022-07-11 21:19:05.000000000","message":"Done","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4b26240a21f728c77b2d8e6ab46179f441740d9","unresolved":true,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        if result \u003e 0:"},{"line_number":362,"context_line":"            total \u003d len(parsed_args.share_server)"},{"line_number":363,"context_line":"            msg \u003d (_(f\u0027Failed to abandon {result}s of {total} servers.\u0027))"},{"line_number":364,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"bff83d9c_047b5315","line":363,"range":{"start_line":363,"start_character":49,"end_line":363,"end_character":50},"updated":"2022-07-11 19:41:33.000000000","message":"no need for the \"s\" after the {result}","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c995574c230848f918abd1a1fbbf26407992c128","unresolved":false,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        if result \u003e 0:"},{"line_number":362,"context_line":"            total \u003d len(parsed_args.share_server)"},{"line_number":363,"context_line":"            msg \u003d (_(f\u0027Failed to abandon {result}s of {total} servers.\u0027))"},{"line_number":364,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"d6be942a_ad475df8","line":363,"range":{"start_line":363,"start_character":49,"end_line":363,"end_character":50},"in_reply_to":"bff83d9c_047b5315","updated":"2022-07-11 21:19:05.000000000","message":"Done","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4b26240a21f728c77b2d8e6ab46179f441740d9","unresolved":true,"context_lines":[{"line_number":368,"context_line":"    \"\"\"Set share server properties.\"\"\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    _description \u003d _("},{"line_number":371,"context_line":"        \"Explicitly update the state of share server (Admin only).\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def get_parser(self, prog_name):"},{"line_number":374,"context_line":"        parser \u003d super(SetShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":30,"id":"8916c8d6_94581b08","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":52},"updated":"2022-07-11 19:41:33.000000000","message":"Description is printed in the help text.. so, the change in line 368 must be made here..","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c995574c230848f918abd1a1fbbf26407992c128","unresolved":false,"context_lines":[{"line_number":368,"context_line":"    \"\"\"Set share server properties.\"\"\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    _description \u003d _("},{"line_number":371,"context_line":"        \"Explicitly update the state of share server (Admin only).\")"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def get_parser(self, prog_name):"},{"line_number":374,"context_line":"        parser \u003d super(SetShareServer, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":30,"id":"d142ab0b_a55da99a","line":371,"range":{"start_line":371,"start_character":9,"end_line":371,"end_character":52},"in_reply_to":"8916c8d6_94581b08","updated":"2022-07-11 21:19:05.000000000","message":"Done","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                share_client.share_servers.delete(server_obj)"},{"line_number":57,"context_line":"                if parsed_args.wait:"},{"line_number":58,"context_line":"                    if not osc_utils.wait_for_delete("},{"line_number":59,"context_line":"                            manager\u003dshare_client.share_servers,"},{"line_number":60,"context_line":"                            res_id\u003dserver_obj.id):"},{"line_number":61,"context_line":"                        result +\u003d 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            except Exception as e:"},{"line_number":64,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":32,"id":"d53e1a35_7a982b48","line":61,"range":{"start_line":58,"start_character":20,"end_line":61,"end_character":35},"updated":"2022-07-20 22:49:37.000000000","message":"the logic here is incorrect, \"wait_for_delete\" returns the original object if the object is gone, else it\u0027ll raise a ResourceTimeout: https://opendev.org/openstack/openstacksdk/src/commit/9c623bb4c9f40d13688a0606a3e0eb1fcde87285/openstack/resource.py#L2236","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3823a720dfc2a198add7b47c5ddde57cc840a801","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                share_client.share_servers.delete(server_obj)"},{"line_number":57,"context_line":"                if parsed_args.wait:"},{"line_number":58,"context_line":"                    if not osc_utils.wait_for_delete("},{"line_number":59,"context_line":"                            manager\u003dshare_client.share_servers,"},{"line_number":60,"context_line":"                            res_id\u003dserver_obj.id):"},{"line_number":61,"context_line":"                        result +\u003d 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            except Exception as e:"},{"line_number":64,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":32,"id":"62196c40_cfb4a8fc","line":61,"range":{"start_line":58,"start_character":20,"end_line":61,"end_character":35},"in_reply_to":"1e5322be_68a43e4d","updated":"2022-07-25 16:14:40.000000000","message":"ah my bad!","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c6a65de3afb7ca59676b7efd3f27e0ee3ec7e02e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                share_client.share_servers.delete(server_obj)"},{"line_number":57,"context_line":"                if parsed_args.wait:"},{"line_number":58,"context_line":"                    if not osc_utils.wait_for_delete("},{"line_number":59,"context_line":"                            manager\u003dshare_client.share_servers,"},{"line_number":60,"context_line":"                            res_id\u003dserver_obj.id):"},{"line_number":61,"context_line":"                        result +\u003d 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            except Exception as e:"},{"line_number":64,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":32,"id":"7fcdf3b6_417a064b","line":61,"range":{"start_line":58,"start_character":20,"end_line":61,"end_character":35},"in_reply_to":"62196c40_cfb4a8fc","updated":"2022-07-25 19:17:54.000000000","message":"no problem :)","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":true,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"                share_client.share_servers.delete(server_obj)"},{"line_number":57,"context_line":"                if parsed_args.wait:"},{"line_number":58,"context_line":"                    if not osc_utils.wait_for_delete("},{"line_number":59,"context_line":"                            manager\u003dshare_client.share_servers,"},{"line_number":60,"context_line":"                            res_id\u003dserver_obj.id):"},{"line_number":61,"context_line":"                        result +\u003d 1"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"            except Exception as e:"},{"line_number":64,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":32,"id":"1e5322be_68a43e4d","line":61,"range":{"start_line":58,"start_character":20,"end_line":61,"end_character":35},"in_reply_to":"d53e1a35_7a982b48","updated":"2022-07-21 21:44:04.000000000","message":"Actually, the logic is correct... This would be incorrect if we were importing from openstacksdk, but we are actually importing from osc_lib, which means it is a different method, and that method returns True or False: https://github.com/openstack/osc-lib/blob/650795af70f8709292200f677f6ee29880aab54e/osc_lib/utils/__init__.py#L645-L646","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":true,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        project_id \u003d None"},{"line_number":153,"context_line":"        if parsed_args.project:"},{"line_number":154,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":155,"context_line":"                identity_client,"},{"line_number":156,"context_line":"                parsed_args.project,"},{"line_number":157,"context_line":"                parsed_args.project_domain).id"}],"source_content_type":"text/x-python","patch_set":32,"id":"77428d0a_f268e993","line":154,"range":{"start_line":154,"start_character":25,"end_line":154,"end_character":40},"updated":"2022-07-20 22:49:37.000000000","message":"identity_common isn\u0027t defined:\n\n\n$ openstack --debug share server list --project demo\n\u003c/snip\u003e\nShared File System API version: API Version Major: 2, Minor: 69\nInstantiating identity client: \u003cclass \u0027keystoneclient.v3.client.Client\u0027\u003e\nname \u0027identity_common\u0027 is not defined\nTraceback (most recent call last):\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 407, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/display.py\", line 115, in run\n    column_names, data \u003d self.take_action(parsed_args)\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share_servers.py\", line 154, in take_action\n    project_id \u003d identity_common.find_project(\nNameError: name \u0027identity_common\u0027 is not defined\nclean_up ListShareServer: name \u0027identity_common\u0027 is not defined\nEND return value: 1","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":151,"context_line":""},{"line_number":152,"context_line":"        project_id \u003d None"},{"line_number":153,"context_line":"        if parsed_args.project:"},{"line_number":154,"context_line":"            project_id \u003d identity_common.find_project("},{"line_number":155,"context_line":"                identity_client,"},{"line_number":156,"context_line":"                parsed_args.project,"},{"line_number":157,"context_line":"                parsed_args.project_domain).id"}],"source_content_type":"text/x-python","patch_set":32,"id":"68fd6482_c3dbbd87","line":154,"range":{"start_line":154,"start_character":25,"end_line":154,"end_character":40},"in_reply_to":"77428d0a_f268e993","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":true,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if parsed_args.share_network_subnet:"},{"line_number":187,"context_line":"            search_opts["},{"line_number":188,"context_line":"                \u0027share_network_subnet\u0027] \u003d parsed_args.share_network_subnet"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        share_servers \u003d share_client.share_servers.list("},{"line_number":191,"context_line":"            search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":32,"id":"5fec17b9_ca2b3452","line":188,"range":{"start_line":188,"start_character":17,"end_line":188,"end_character":37},"updated":"2022-07-20 22:49:37.000000000","message":"share_network_subnet_id\n\nSee fix here for manilaclient shell: \n\nhttps://review.opendev.org/c/openstack/python-manilaclient/+/838293/10/manilaclient/v2/shell.py#4404","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        if parsed_args.share_network_subnet:"},{"line_number":187,"context_line":"            search_opts["},{"line_number":188,"context_line":"                \u0027share_network_subnet\u0027] \u003d parsed_args.share_network_subnet"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        share_servers \u003d share_client.share_servers.list("},{"line_number":191,"context_line":"            search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":32,"id":"4930ac07_52b8d174","line":188,"range":{"start_line":188,"start_character":17,"end_line":188,"end_character":37},"in_reply_to":"5fec17b9_ca2b3452","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb11e1f5091747625fa06c0474f65c301d38ac18","unresolved":true,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # All \u0027backend_details\u0027 data already present as separated strings,"},{"line_number":294,"context_line":"        # so remove big dict from view."},{"line_number":295,"context_line":"        if \"backend_details\" in share_server._info:"},{"line_number":296,"context_line":"            share_server._info.pop(\"backend_details\", None)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        return self.dict2columns(share_server._info)"}],"source_content_type":"text/x-python","patch_set":32,"id":"e1da8af1_a856d183","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":51},"updated":"2022-07-20 22:02:24.000000000","message":"This condition is now redundant","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        # All \u0027backend_details\u0027 data already present as separated strings,"},{"line_number":294,"context_line":"        # so remove big dict from view."},{"line_number":295,"context_line":"        if \"backend_details\" in share_server._info:"},{"line_number":296,"context_line":"            share_server._info.pop(\"backend_details\", None)"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":"        return self.dict2columns(share_server._info)"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ac4f06f_8c00a32b","line":295,"range":{"start_line":295,"start_character":8,"end_line":295,"end_character":51},"in_reply_to":"e1da8af1_a856d183","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":true,"context_lines":[{"line_number":337,"context_line":"                    server)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"                if parsed_args.force:"},{"line_number":340,"context_line":"                    share_client.share_servers.force_unmanage("},{"line_number":341,"context_line":"                        server_obj,"},{"line_number":342,"context_line":"                        force\u003dparsed_args.force)"},{"line_number":343,"context_line":"                else:"},{"line_number":344,"context_line":"                    share_client.share_servers.unmanage("},{"line_number":345,"context_line":"                        server_obj)"}],"source_content_type":"text/x-python","patch_set":32,"id":"9257af50_352b84f8","line":342,"range":{"start_line":340,"start_character":20,"end_line":342,"end_character":48},"updated":"2022-07-20 22:49:37.000000000","message":"\u0027ShareServerManager\u0027 object has no attribute \u0027force_unmanage\u0027","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":337,"context_line":"                    server)"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"                if parsed_args.force:"},{"line_number":340,"context_line":"                    share_client.share_servers.force_unmanage("},{"line_number":341,"context_line":"                        server_obj,"},{"line_number":342,"context_line":"                        force\u003dparsed_args.force)"},{"line_number":343,"context_line":"                else:"},{"line_number":344,"context_line":"                    share_client.share_servers.unmanage("},{"line_number":345,"context_line":"                        server_obj)"}],"source_content_type":"text/x-python","patch_set":32,"id":"49605754_8c624502","line":342,"range":{"start_line":340,"start_character":20,"end_line":342,"end_character":48},"in_reply_to":"9257af50_352b84f8","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":true,"context_lines":[{"line_number":345,"context_line":"                        server_obj)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"                if parsed_args.wait:"},{"line_number":348,"context_line":"                    if not osc_utils.wait_for_delete("},{"line_number":349,"context_line":"                            manager\u003dshare_client.share_servers,"},{"line_number":350,"context_line":"                            res_id\u003dserver_obj.id):"},{"line_number":351,"context_line":"                        result +\u003d 1"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":32,"id":"3ab419c0_e4e58319","line":350,"range":{"start_line":348,"start_character":20,"end_line":350,"end_character":50},"updated":"2022-07-20 22:49:37.000000000","message":"same comment as above","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":345,"context_line":"                        server_obj)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"                if parsed_args.wait:"},{"line_number":348,"context_line":"                    if not osc_utils.wait_for_delete("},{"line_number":349,"context_line":"                            manager\u003dshare_client.share_servers,"},{"line_number":350,"context_line":"                            res_id\u003dserver_obj.id):"},{"line_number":351,"context_line":"                        result +\u003d 1"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":32,"id":"d06eecfd_6818e232","line":350,"range":{"start_line":348,"start_character":20,"end_line":350,"end_character":50},"in_reply_to":"3ab419c0_e4e58319","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"516b1410cb39c463f348d01452cac98cb9ddfd36","unresolved":true,"context_lines":[{"line_number":386,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":387,"context_line":"            required\u003dTrue,"},{"line_number":388,"context_line":"            help\u003d_(\"Assign a status to the share server. Options \""},{"line_number":389,"context_line":"                   \"include: %s. If no state is \""},{"line_number":390,"context_line":"                   \"provided, active will be \""},{"line_number":391,"context_line":"                   \"used.\" % allowed_update_choices_str)"},{"line_number":392,"context_line":"        )"},{"line_number":393,"context_line":"        return parser"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"09411c65_c9260bd6","line":391,"range":{"start_line":389,"start_character":33,"end_line":391,"end_character":25},"updated":"2022-07-20 22:49:37.000000000","message":"There\u0027s no default status assigned","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":386,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":387,"context_line":"            required\u003dTrue,"},{"line_number":388,"context_line":"            help\u003d_(\"Assign a status to the share server. Options \""},{"line_number":389,"context_line":"                   \"include: %s. If no state is \""},{"line_number":390,"context_line":"                   \"provided, active will be \""},{"line_number":391,"context_line":"                   \"used.\" % allowed_update_choices_str)"},{"line_number":392,"context_line":"        )"},{"line_number":393,"context_line":"        return parser"},{"line_number":394,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"92a68827_cd2c65d0","line":391,"range":{"start_line":389,"start_character":33,"end_line":391,"end_character":25},"in_reply_to":"09411c65_c9260bd6","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"fa11bc88ea3958ac09fa3bd868af290177bd9643"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1310,"context_line":"        methods \u003d methods or {}"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"        share_server \u003d {"},{"line_number":1313,"context_line":"            \u0027id\u0027: \u0027server-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1314,"context_line":"            \u0027project_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1315,"context_line":"            \"updated_at\": \u0027time-\u0027 + uuid.uuid4().hex,"},{"line_number":1316,"context_line":"            \u0027status\u0027: None,"}],"source_content_type":"text/x-python","patch_set":29,"id":"fab72dc9_d0104991","line":1313,"range":{"start_line":1313,"start_character":18,"end_line":1313,"end_character":49},"updated":"2022-07-07 21:27:54.000000000","message":"why not use dashed uuids to imitate the real format","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1310,"context_line":"        methods \u003d methods or {}"},{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"        share_server \u003d {"},{"line_number":1313,"context_line":"            \u0027id\u0027: \u0027server-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1314,"context_line":"            \u0027project_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1315,"context_line":"            \"updated_at\": \u0027time-\u0027 + uuid.uuid4().hex,"},{"line_number":1316,"context_line":"            \u0027status\u0027: None,"}],"source_content_type":"text/x-python","patch_set":29,"id":"9935ac1d_9593fb03","line":1313,"range":{"start_line":1313,"start_character":18,"end_line":1313,"end_character":49},"in_reply_to":"fab72dc9_d0104991","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1312,"context_line":"        share_server \u003d {"},{"line_number":1313,"context_line":"            \u0027id\u0027: \u0027server-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1314,"context_line":"            \u0027project_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1315,"context_line":"            \"updated_at\": \u0027time-\u0027 + uuid.uuid4().hex,"},{"line_number":1316,"context_line":"            \u0027status\u0027: None,"},{"line_number":1317,"context_line":"            \u0027host\u0027: None,"},{"line_number":1318,"context_line":"            \u0027share_network_name\u0027: None,"}],"source_content_type":"text/x-python","patch_set":29,"id":"2610c91a_721f6ba4","line":1315,"range":{"start_line":1315,"start_character":26,"end_line":1315,"end_character":52},"updated":"2022-07-07 21:27:54.000000000","message":"use a real-ish timestamp","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1312,"context_line":"        share_server \u003d {"},{"line_number":1313,"context_line":"            \u0027id\u0027: \u0027server-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1314,"context_line":"            \u0027project_id\u0027: \u0027project-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1315,"context_line":"            \"updated_at\": \u0027time-\u0027 + uuid.uuid4().hex,"},{"line_number":1316,"context_line":"            \u0027status\u0027: None,"},{"line_number":1317,"context_line":"            \u0027host\u0027: None,"},{"line_number":1318,"context_line":"            \u0027share_network_name\u0027: None,"}],"source_content_type":"text/x-python","patch_set":29,"id":"7ca1fb2c_892c385e","line":1315,"range":{"start_line":1315,"start_character":26,"end_line":1315,"end_character":52},"in_reply_to":"2610c91a_721f6ba4","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1316,"context_line":"            \u0027status\u0027: None,"},{"line_number":1317,"context_line":"            \u0027host\u0027: None,"},{"line_number":1318,"context_line":"            \u0027share_network_name\u0027: None,"},{"line_number":1319,"context_line":"            \u0027share_network_id\u0027: \u0027sn-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1320,"context_line":"            \u0027share_network_subnet_id\u0027: \u0027sns-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1321,"context_line":"            \u0027created_at\u0027: datetime.datetime.now().isoformat(),"},{"line_number":1322,"context_line":"            \u0027is_auto_deletable\u0027: False,"}],"source_content_type":"text/x-python","patch_set":29,"id":"ac4d7d9d_e52b2d70","line":1319,"range":{"start_line":1319,"start_character":33,"end_line":1319,"end_character":60},"updated":"2022-07-07 21:27:54.000000000","message":"same comment as above","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1316,"context_line":"            \u0027status\u0027: None,"},{"line_number":1317,"context_line":"            \u0027host\u0027: None,"},{"line_number":1318,"context_line":"            \u0027share_network_name\u0027: None,"},{"line_number":1319,"context_line":"            \u0027share_network_id\u0027: \u0027sn-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1320,"context_line":"            \u0027share_network_subnet_id\u0027: \u0027sns-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1321,"context_line":"            \u0027created_at\u0027: datetime.datetime.now().isoformat(),"},{"line_number":1322,"context_line":"            \u0027is_auto_deletable\u0027: False,"}],"source_content_type":"text/x-python","patch_set":29,"id":"82a0d7e2_14374d08","line":1319,"range":{"start_line":1319,"start_character":33,"end_line":1319,"end_character":60},"in_reply_to":"ac4d7d9d_e52b2d70","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1317,"context_line":"            \u0027host\u0027: None,"},{"line_number":1318,"context_line":"            \u0027share_network_name\u0027: None,"},{"line_number":1319,"context_line":"            \u0027share_network_id\u0027: \u0027sn-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1320,"context_line":"            \u0027share_network_subnet_id\u0027: \u0027sns-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1321,"context_line":"            \u0027created_at\u0027: datetime.datetime.now().isoformat(),"},{"line_number":1322,"context_line":"            \u0027is_auto_deletable\u0027: False,"},{"line_number":1323,"context_line":"            \u0027identifier\u0027: \u0027identifier-id-\u0027 + uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":29,"id":"674529c7_e80999bf","line":1320,"range":{"start_line":1320,"start_character":39,"end_line":1320,"end_character":67},"updated":"2022-07-07 21:27:54.000000000","message":"same comment as above","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1317,"context_line":"            \u0027host\u0027: None,"},{"line_number":1318,"context_line":"            \u0027share_network_name\u0027: None,"},{"line_number":1319,"context_line":"            \u0027share_network_id\u0027: \u0027sn-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1320,"context_line":"            \u0027share_network_subnet_id\u0027: \u0027sns-id-\u0027 + uuid.uuid4().hex,"},{"line_number":1321,"context_line":"            \u0027created_at\u0027: datetime.datetime.now().isoformat(),"},{"line_number":1322,"context_line":"            \u0027is_auto_deletable\u0027: False,"},{"line_number":1323,"context_line":"            \u0027identifier\u0027: \u0027identifier-id-\u0027 + uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":29,"id":"fe64f083_30ddf604","line":1320,"range":{"start_line":1320,"start_character":39,"end_line":1320,"end_character":67},"in_reply_to":"674529c7_e80999bf","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1334,"context_line":"    def create_share_servers(attrs\u003dNone, count\u003d2):"},{"line_number":1335,"context_line":"        \"\"\"Create multiple fake servers."},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"        :param Dictionary attrs:"},{"line_number":1338,"context_line":"            A dictionary with all attributes"},{"line_number":1339,"context_line":"        :param Integer count:"},{"line_number":1340,"context_line":"            The number of share server to be faked"}],"source_content_type":"text/x-python","patch_set":29,"id":"39dc1e34_262068e7","line":1337,"range":{"start_line":1337,"start_character":15,"end_line":1337,"end_character":25},"updated":"2022-07-07 21:27:54.000000000","message":"by convention this should just be \"dict\"","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1334,"context_line":"    def create_share_servers(attrs\u003dNone, count\u003d2):"},{"line_number":1335,"context_line":"        \"\"\"Create multiple fake servers."},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"        :param Dictionary attrs:"},{"line_number":1338,"context_line":"            A dictionary with all attributes"},{"line_number":1339,"context_line":"        :param Integer count:"},{"line_number":1340,"context_line":"            The number of share server to be faked"}],"source_content_type":"text/x-python","patch_set":29,"id":"2a00dba0_766a0aa0","line":1337,"range":{"start_line":1337,"start_character":15,"end_line":1337,"end_character":25},"in_reply_to":"39dc1e34_262068e7","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"        :param Dictionary attrs:"},{"line_number":1338,"context_line":"            A dictionary with all attributes"},{"line_number":1339,"context_line":"        :param Integer count:"},{"line_number":1340,"context_line":"            The number of share server to be faked"},{"line_number":1341,"context_line":"        :return:"},{"line_number":1342,"context_line":"            A list of FakeResource objects"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a3d1ea4_39035a50","line":1339,"range":{"start_line":1339,"start_character":15,"end_line":1339,"end_character":22},"updated":"2022-07-07 21:27:54.000000000","message":"\"int\"","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"        :param Dictionary attrs:"},{"line_number":1338,"context_line":"            A dictionary with all attributes"},{"line_number":1339,"context_line":"        :param Integer count:"},{"line_number":1340,"context_line":"            The number of share server to be faked"},{"line_number":1341,"context_line":"        :return:"},{"line_number":1342,"context_line":"            A list of FakeResource objects"}],"source_content_type":"text/x-python","patch_set":29,"id":"5bf81aca_e1ce8fce","line":1339,"range":{"start_line":1339,"start_character":15,"end_line":1339,"end_character":22},"in_reply_to":"7a3d1ea4_39035a50","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4b26240a21f728c77b2d8e6ab46179f441740d9","unresolved":true,"context_lines":[{"line_number":1331,"context_line":"        return share_server"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"    @staticmethod"},{"line_number":1334,"context_line":"    def create_share_servers(attrs\u003d{}, count\u003d2):"},{"line_number":1335,"context_line":"        \"\"\"Create multiple fake servers."},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"        :param dict attrs:"}],"source_content_type":"text/x-python","patch_set":30,"id":"e82d908e_3ee019bf","line":1334,"range":{"start_line":1334,"start_character":29,"end_line":1334,"end_character":37},"updated":"2022-07-11 19:41:33.000000000","message":"default value of None is correct.. \n\nhttps://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/\n\nin the code, you can do \n\n attrs \u003d attrs or {} \n\nfor correctness","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c995574c230848f918abd1a1fbbf26407992c128","unresolved":false,"context_lines":[{"line_number":1331,"context_line":"        return share_server"},{"line_number":1332,"context_line":""},{"line_number":1333,"context_line":"    @staticmethod"},{"line_number":1334,"context_line":"    def create_share_servers(attrs\u003d{}, count\u003d2):"},{"line_number":1335,"context_line":"        \"\"\"Create multiple fake servers."},{"line_number":1336,"context_line":""},{"line_number":1337,"context_line":"        :param dict attrs:"}],"source_content_type":"text/x-python","patch_set":30,"id":"6f977017_ccca5846","line":1334,"range":{"start_line":1334,"start_character":29,"end_line":1334,"end_character":37},"in_reply_to":"e82d908e_3ee019bf","updated":"2022-07-11 21:19:05.000000000","message":"Done","commit_id":"b73d81661f8e981d398152f5b17fc22c959c202a"}],"manilaclient/tests/unit/osc/v2/test_share_server.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dec33be1b97a0880ca03c4c783c4806caf7f980","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2019 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":12,"id":"a14e96fe_7d8b88da","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":18},"updated":"2021-09-21 21:07:01.000000000","message":"tiny nit: 2021 :)","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2019 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":12,"id":"1390cab0_5fff97d3","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":18},"in_reply_to":"a14e96fe_7d8b88da","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"}],"manilaclient/tests/unit/osc/v2/test_share_servers.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestShareServer, self).setUp()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.shares"},{"line_number":35,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.servers_mock \u003d self.app.client_manager.share.share_servers"},{"line_number":38,"context_line":"        self.servers_mock.reset_mock()"}],"source_content_type":"text/x-python","patch_set":14,"id":"70ae11c5_e379e37d","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":37},"updated":"2021-10-02 07:56:34.000000000","message":"We don\u0027t need to create fake shares here, we can drop these lines.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        super(TestShareServer, self).setUp()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        self.shares_mock \u003d self.app.client_manager.share.shares"},{"line_number":35,"context_line":"        self.shares_mock.reset_mock()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.servers_mock \u003d self.app.client_manager.share.share_servers"},{"line_number":38,"context_line":"        self.servers_mock.reset_mock()"}],"source_content_type":"text/x-python","patch_set":14,"id":"e6987533_55f298eb","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":37},"in_reply_to":"70ae11c5_e379e37d","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(TestDeleteShareServer, self).setUp()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.share \u003d manila_fakes.FakeShare.create_one_share()"},{"line_number":49,"context_line":"        self.shares_mock.create.return_value \u003d self.share"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.shares_mock.get.return_value \u003d self.share"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.share_server \u003d ("},{"line_number":54,"context_line":"            manila_fakes.FakeShareServer.create_one_server())"}],"source_content_type":"text/x-python","patch_set":14,"id":"0b8f0cd6_c7e6d503","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":54},"updated":"2021-10-02 07:56:34.000000000","message":"No need for fake shares here, we can drop these lines.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def setUp(self):"},{"line_number":46,"context_line":"        super(TestDeleteShareServer, self).setUp()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.share \u003d manila_fakes.FakeShare.create_one_share()"},{"line_number":49,"context_line":"        self.shares_mock.create.return_value \u003d self.share"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        self.shares_mock.get.return_value \u003d self.share"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.share_server \u003d ("},{"line_number":54,"context_line":"            manila_fakes.FakeShareServer.create_one_server())"}],"source_content_type":"text/x-python","patch_set":14,"id":"8d77e50c_2c168efa","line":51,"range":{"start_line":48,"start_character":0,"end_line":51,"end_character":54},"in_reply_to":"0b8f0cd6_c7e6d503","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.share_server \u003d ("},{"line_number":54,"context_line":"            manila_fakes.FakeShareServer.create_one_server())"},{"line_number":55,"context_line":"        self.servers_mock.create.return_value \u003d self.share_server"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.cmd \u003d osc_share_servers.DeleteShareServer(self.app, None)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"bc3f7edc_ccc8a6c8","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":65},"updated":"2021-10-02 07:56:34.000000000","message":"there is no create option for share servers.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self.share_server \u003d ("},{"line_number":54,"context_line":"            manila_fakes.FakeShareServer.create_one_server())"},{"line_number":55,"context_line":"        self.servers_mock.create.return_value \u003d self.share_server"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.cmd \u003d osc_share_servers.DeleteShareServer(self.app, None)"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"e8a6625c_3ad434d8","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":65},"in_reply_to":"bc3f7edc_ccc8a6c8","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.cmd \u003d osc_share_servers.DeleteShareServer(self.app, None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":60,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_share_server_delete_missing_args(self):"},{"line_number":63,"context_line":"        arglist \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"86a33f3c_042cf3db","line":60,"range":{"start_line":59,"start_character":0,"end_line":60,"end_character":60},"updated":"2021-10-02 07:56:34.000000000","message":"a delete operation does not return anything, so this is unnecessary here.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self.cmd \u003d osc_share_servers.DeleteShareServer(self.app, None)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":60,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def test_share_server_delete_missing_args(self):"},{"line_number":63,"context_line":"        arglist \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"084d60ca_1c97a25f","line":60,"range":{"start_line":59,"start_character":0,"end_line":60,"end_character":60},"in_reply_to":"86a33f3c_042cf3db","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        with mock.patch(\u0027osc_lib.utils.find_resource\u0027,"},{"line_number":80,"context_line":"                        return_value\u003dself.share_server):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            result \u003d self.cmd.take_action(parsed_args)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"04df213d_efc85f95","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":56},"updated":"2021-10-02 07:56:34.000000000","message":"I think if you set the return value for self.servers_mock.get in the setup, you can avoid this mock patch in several occasions.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        with mock.patch(\u0027osc_lib.utils.find_resource\u0027,"},{"line_number":80,"context_line":"                        return_value\u003dself.share_server):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            result \u003d self.cmd.take_action(parsed_args)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"6e159d9a_9cdf8aa4","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":56},"in_reply_to":"04df213d_efc85f95","updated":"2021-10-08 20:04:28.000000000","message":"can\u0027t get your point here, what do you mean by several occasions? can you unpack it more? :)","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        with mock.patch(\u0027osc_lib.utils.find_resource\u0027,"},{"line_number":80,"context_line":"                        return_value\u003dself.share_server):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            result \u003d self.cmd.take_action(parsed_args)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"34e5df5c_c7dbf4ef","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":56},"in_reply_to":"0f46f263_5c064384","updated":"2021-12-29 12:26:53.000000000","message":"Done","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4e4f50085e446cec918ef3fc7535556d35b3f30c","unresolved":true,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        with mock.patch(\u0027osc_lib.utils.find_resource\u0027,"},{"line_number":80,"context_line":"                        return_value\u003dself.share_server):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            result \u003d self.cmd.take_action(parsed_args)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"0f46f263_5c064384","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":56},"in_reply_to":"6e159d9a_9cdf8aa4","updated":"2021-10-30 08:47:11.000000000","message":"I guess by several I meant 2 occasions, this and the one on line 89 :) \nIf you add self.servers_mock.get.return_value \u003d self.share_server to the setup, you can lose the two.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        \u0027Project ID\u0027,"},{"line_number":179,"context_line":"    ]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    column_headers \u003d utils.format_column_headers(columns)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def setUp(self):"},{"line_number":184,"context_line":"        super(TestListShareServer, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"a3373f6a_5b4e8cbd","line":181,"updated":"2021-10-02 07:56:34.000000000","message":"the columns are already formatted, drop this line.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        \u0027Project ID\u0027,"},{"line_number":179,"context_line":"    ]"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    column_headers \u003d utils.format_column_headers(columns)"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    def setUp(self):"},{"line_number":184,"context_line":"        super(TestListShareServer, self).setUp()"}],"source_content_type":"text/x-python","patch_set":14,"id":"df04a9a0_7c9a4399","line":181,"in_reply_to":"a3373f6a_5b4e8cbd","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":"        self.servers_mock.list.return_value \u003d [self.new_share_server]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.share_server \u003d ("},{"line_number":192,"context_line":"            manila_fakes.FakeShareServer.create_one_server())"},{"line_number":193,"context_line":"        self.servers_mock.get.return_value \u003d self.share_server"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        self.servers_list \u003d ("},{"line_number":196,"context_line":"            manila_fakes.FakeShareServer.create_share_servers("}],"source_content_type":"text/x-python","patch_set":14,"id":"8f10f7b3_b57d45a5","line":193,"range":{"start_line":191,"start_character":0,"end_line":193,"end_character":62},"updated":"2021-10-02 07:56:34.000000000","message":"Looks like this is not really used anywhere.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        )"},{"line_number":189,"context_line":"        self.servers_mock.list.return_value \u003d [self.new_share_server]"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        self.share_server \u003d ("},{"line_number":192,"context_line":"            manila_fakes.FakeShareServer.create_one_server())"},{"line_number":193,"context_line":"        self.servers_mock.get.return_value \u003d self.share_server"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"        self.servers_list \u003d ("},{"line_number":196,"context_line":"            manila_fakes.FakeShareServer.create_share_servers("}],"source_content_type":"text/x-python","patch_set":14,"id":"b78ab4b1_bfbfcfb0","line":193,"range":{"start_line":191,"start_character":0,"end_line":193,"end_character":62},"in_reply_to":"8f10f7b3_b57d45a5","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":195,"context_line":"        self.servers_list \u003d ("},{"line_number":196,"context_line":"            manila_fakes.FakeShareServer.create_share_servers("},{"line_number":197,"context_line":"                count\u003d2))"},{"line_number":198,"context_line":"        self.servers_mock.list.return_value \u003d self.servers_list"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.values \u003d (oscutils.get_dict_properties("},{"line_number":201,"context_line":"            i._info, self.columns) for i in self.servers_list)"}],"source_content_type":"text/x-python","patch_set":14,"id":"50fd47ed_fe683130","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":43},"updated":"2021-10-02 07:56:34.000000000","message":"this is defined twice, so the first return value will never be used.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        self.servers_list \u003d ("},{"line_number":196,"context_line":"            manila_fakes.FakeShareServer.create_share_servers("},{"line_number":197,"context_line":"                count\u003d2))"},{"line_number":198,"context_line":"        self.servers_mock.list.return_value \u003d self.servers_list"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        self.values \u003d (oscutils.get_dict_properties("},{"line_number":201,"context_line":"            i._info, self.columns) for i in self.servers_list)"}],"source_content_type":"text/x-python","patch_set":14,"id":"76bb20a2_14f5e4de","line":198,"range":{"start_line":198,"start_character":8,"end_line":198,"end_character":43},"in_reply_to":"50fd47ed_fe683130","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        )"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertEqual(self.column_headers, columns)"},{"line_number":250,"context_line":"        self.assertEqual(list(self.values), list(data))"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":253,"context_line":"    # share_network_subnet when the options have OSC support."}],"source_content_type":"text/x-python","patch_set":14,"id":"10f9696b_6b2d6845","line":250,"updated":"2021-10-02 07:56:34.000000000","message":"So the return value here is not really affected at all by the --status filter option used, so you might as well use self.servers_list[0].status as the value for the option and drop the creation of self.new_share_server altogether.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        )"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        self.assertEqual(self.column_headers, columns)"},{"line_number":250,"context_line":"        self.assertEqual(list(self.values), list(data))"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":253,"context_line":"    # share_network_subnet when the options have OSC support."}],"source_content_type":"text/x-python","patch_set":14,"id":"3a6b0d08_d802048c","line":250,"in_reply_to":"10f9696b_6b2d6845","updated":"2021-12-29 12:26:53.000000000","message":"Done","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":278,"context_line":"    # when the options have OSC support."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"class TestAbandonShareServer(TestShareServer):"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9edf79e1_932d3119","line":279,"updated":"2021-10-02 07:56:34.000000000","message":"Share networks are supported now so we can add a test for required args and also for --driver options.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":278,"context_line":"    # when the options have OSC support."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"class TestAbandonShareServer(TestShareServer):"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"3a7903f6_14ee2e93","line":279,"in_reply_to":"75ff02ca_5acfdd6a","updated":"2021-12-29 12:26:53.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"cdf22b7ebf9c0f5f9edb04331fb788bdc7b83305","unresolved":false,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":278,"context_line":"    # when the options have OSC support."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"class TestAbandonShareServer(TestShareServer):"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7985ac54_d5be896b","line":279,"in_reply_to":"75ff02ca_5acfdd6a","updated":"2021-12-29 12:26:53.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":true,"context_lines":[{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":278,"context_line":"    # when the options have OSC support."},{"line_number":279,"context_line":""},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"class TestAbandonShareServer(TestShareServer):"},{"line_number":282,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"75ff02ca_5acfdd6a","line":279,"in_reply_to":"9edf79e1_932d3119","updated":"2021-10-08 20:04:28.000000000","message":"Yes and will add share_network tests in TestListShareServer but can you help me with some context with this or any reference.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        self.cmd \u003d osc_share_servers.AbandonShareServer(self.app, None)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":293,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_share_server_abandon_missing_args(self):"},{"line_number":296,"context_line":"        arglist \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"c5f0d73f_3469a6af","line":293,"range":{"start_line":292,"start_character":8,"end_line":293,"end_character":60},"updated":"2021-10-02 07:56:34.000000000","message":"The abandon command does not return anything so this is unnecessary.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        self.cmd \u003d osc_share_servers.AbandonShareServer(self.app, None)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":293,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_share_server_abandon_missing_args(self):"},{"line_number":296,"context_line":"        arglist \u003d []"}],"source_content_type":"text/x-python","patch_set":14,"id":"ebe5ab23_2f51d8b5","line":293,"range":{"start_line":292,"start_character":8,"end_line":293,"end_character":60},"in_reply_to":"c5f0d73f_3469a6af","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":351,"context_line":"        self.servers_mock.force_unmanage.assert_called_with("},{"line_number":352,"context_line":"            self.share_server)"},{"line_number":353,"context_line":"        self.assertIsNone(result)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"class TestSetShareServer(TestShareServer):"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"e1bd9068_bbde4df9","line":354,"updated":"2021-10-02 07:56:34.000000000","message":"Please add a test for abandon exception case too :)","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        self.servers_mock.force_unmanage.assert_called_with("},{"line_number":352,"context_line":"            self.share_server)"},{"line_number":353,"context_line":"        self.assertIsNone(result)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"class TestSetShareServer(TestShareServer):"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"036cf94e_24dc7d64","line":354,"in_reply_to":"e1bd9068_bbde4df9","updated":"2021-10-08 20:04:28.000000000","message":"added","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d465e283b1a47a8d77ee1eff240a91a86a19780c","unresolved":true,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.cmd \u003d osc_share_servers.SetShareServer(self.app, None)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":368,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_share_server_set_status(self):"},{"line_number":371,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"5856bc1f_ec7838db","line":368,"range":{"start_line":367,"start_character":8,"end_line":368,"end_character":60},"updated":"2021-10-02 07:56:34.000000000","message":"the set operation does not return a value, so this is unnecessary.","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"3e3ac92785cd36e019cdb2b6ad4e0111e5761c50","unresolved":false,"context_lines":[{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        self.cmd \u003d osc_share_servers.SetShareServer(self.app, None)"},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":368,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def test_share_server_set_status(self):"},{"line_number":371,"context_line":"        arglist \u003d ["}],"source_content_type":"text/x-python","patch_set":14,"id":"92aaefb0_07484a9a","line":368,"range":{"start_line":367,"start_character":8,"end_line":368,"end_character":60},"in_reply_to":"5856bc1f_ec7838db","updated":"2021-10-08 20:04:28.000000000","message":"Ack","commit_id":"d5576eedfef6270b780fb7e85dae51f9395d127d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5a319ba0c21c056367654f439735626e0f13c084","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":248,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_share_snapshot_adopt_missing_args(self):"},{"line_number":251,"context_line":"        arglist \u003d []"},{"line_number":252,"context_line":"        verifylist \u003d []"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"f5aff430_c61bdba8","line":250,"updated":"2022-07-01 08:53:36.000000000","message":"So this is the only test for adopt, I think we should have at least one for a positive case scenario, right?","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7452068e1a15317a72d3cc7a9457e61d740ac8c0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        self.data \u003d tuple(self.share_server._info.values())"},{"line_number":248,"context_line":"        self.columns \u003d tuple(self.share_server._info.keys())"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def test_share_snapshot_adopt_missing_args(self):"},{"line_number":251,"context_line":"        arglist \u003d []"},{"line_number":252,"context_line":"        verifylist \u003d []"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"429337ac_eee31529","line":250,"in_reply_to":"f5aff430_c61bdba8","updated":"2022-07-01 20:28:53.000000000","message":"++ :)","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5a319ba0c21c056367654f439735626e0f13c084","unresolved":true,"context_lines":[{"line_number":413,"context_line":"            parsed_args.status)"},{"line_number":414,"context_line":"        self.assertIsNone(result)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    # def test_share_server_set_status_exception(self):"},{"line_number":417,"context_line":"    #     arglist \u003d ["},{"line_number":418,"context_line":"    #         self.share_server.id,"},{"line_number":419,"context_line":"    #         \u0027--status\u0027, \u0027active\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"4317e5fc_c84a3276","line":416,"updated":"2022-07-01 08:53:36.000000000","message":"I guess this needs to be either fixed, dropped or added as a TODO for a follow up patch. :)","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7452068e1a15317a72d3cc7a9457e61d740ac8c0","unresolved":false,"context_lines":[{"line_number":413,"context_line":"            parsed_args.status)"},{"line_number":414,"context_line":"        self.assertIsNone(result)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    # def test_share_server_set_status_exception(self):"},{"line_number":417,"context_line":"    #     arglist \u003d ["},{"line_number":418,"context_line":"    #         self.share_server.id,"},{"line_number":419,"context_line":"    #         \u0027--status\u0027, \u0027active\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"46fc38b3_9deb00bb","line":416,"in_reply_to":"4317e5fc_c84a3276","updated":"2022-07-01 20:28:53.000000000","message":"Done","commit_id":"05ddbe6220f6f966a172454b4f08d249e825e168"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2021 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":29,"id":"52444e69_eb89ace2","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":18},"updated":"2022-07-07 21:27:54.000000000","message":"2022","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2021 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":29,"id":"bcbebd9e_c679b61b","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":18},"in_reply_to":"52444e69_eb89ace2","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"860903c871312b2d7f73ebf6cca2d3a79e82e849","unresolved":true,"context_lines":[{"line_number":219,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":220,"context_line":"        self.assertEqual(list(self.values), list(data))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":223,"context_line":"    # share_network_subnet when the options have OSC support."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"class TestAdoptShareServer(TestShareServer):"}],"source_content_type":"text/x-python","patch_set":29,"id":"febb6602_1f244feb","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":61},"updated":"2022-07-07 21:27:54.000000000","message":"this should be done now?","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5312bdf888a3f84cc01056669bf8d256393900e0","unresolved":false,"context_lines":[{"line_number":219,"context_line":"        self.assertEqual(self.columns, columns)"},{"line_number":220,"context_line":"        self.assertEqual(list(self.values), list(data))"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    # TODO(archanaserver): Add test cases for share-network and"},{"line_number":223,"context_line":"    # share_network_subnet when the options have OSC support."},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"class TestAdoptShareServer(TestShareServer):"}],"source_content_type":"text/x-python","patch_set":29,"id":"492a6da5_f7dead43","line":223,"range":{"start_line":222,"start_character":0,"end_line":223,"end_character":61},"in_reply_to":"febb6602_1f244feb","updated":"2022-07-08 22:12:26.000000000","message":"Done","commit_id":"fe081b031081cbc722ff4f58eaff36cb35aab99a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"40af351d82938364aa1704ec90bb928bc5ee0e75","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2022 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":31,"id":"87bfb948_2bbe56cc","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":26},"updated":"2022-07-13 13:28:18.000000000","message":"nit: not sure if this should be here since not all patch authors are working in RedHat? :)","commit_id":"5c2b568794a4e431f2371d1f23d0f00fa0750dbd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"eb11e1f5091747625fa06c0474f65c301d38ac18","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2022 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":31,"id":"dfc10fc5_53aac5d2","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":26},"in_reply_to":"87bfb948_2bbe56cc","updated":"2022-07-20 22:02:24.000000000","message":"+1; not needed at all tbh..","commit_id":"5c2b568794a4e431f2371d1f23d0f00fa0750dbd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7b4b7798dfe70a128828115ab0a03d8092718efa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2022 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":31,"id":"dd0e1455_94ea865b","line":1,"range":{"start_line":1,"start_character":4,"end_line":1,"end_character":26},"in_reply_to":"dfc10fc5_53aac5d2","updated":"2022-07-21 21:44:04.000000000","message":"Done","commit_id":"5c2b568794a4e431f2371d1f23d0f00fa0750dbd"}],"setup.cfg":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8dec33be1b97a0880ca03c4c783c4806caf7f980","unresolved":true,"context_lines":[{"line_number":125,"context_line":"    share_server_adopt \u003d manilaclient.osc.v2.share_servers:AdoptShareServer"},{"line_number":126,"context_line":"    share_server_abandon \u003d manilaclient.osc.v2.share_servers:AbandonShareServer"},{"line_number":127,"context_line":"    share_server_set \u003d manilaclient.osc.v2.share_servers:SetShareServer"},{"line_number":128,"context_line":"    "},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"[coverage:run]"},{"line_number":131,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"f6888944_105565f7","line":128,"updated":"2021-09-21 21:07:01.000000000","message":"nit: please remove this trailing white spaces","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"17e713c0ecab2d8921dc36067b39ce0febd2ed89","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    share_server_adopt \u003d manilaclient.osc.v2.share_servers:AdoptShareServer"},{"line_number":126,"context_line":"    share_server_abandon \u003d manilaclient.osc.v2.share_servers:AbandonShareServer"},{"line_number":127,"context_line":"    share_server_set \u003d manilaclient.osc.v2.share_servers:SetShareServer"},{"line_number":128,"context_line":"    "},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"[coverage:run]"},{"line_number":131,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"6e0d849a_ad529e9c","line":128,"in_reply_to":"f6888944_105565f7","updated":"2021-09-24 12:25:20.000000000","message":"Ack","commit_id":"dca9bb0606c9d413619c901bb96c6facfa0c2874"}]}