)]}'
{"manilaclient/osc/v2/share_snapshot_instance_export_locations.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ShareSnapshotInstanceExportLocationsList(command.Lister):"},{"line_number":24,"context_line":"    \"\"\"List export locations from a share snapshot instance.\"\"\""},{"line_number":25,"context_line":"    _description \u003d _(\"List export locations from a share snapshot instance.\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"806293f5_2ce82829","line":23,"range":{"start_line":23,"start_character":41,"end_line":23,"end_character":42},"updated":"2021-08-22 15:22:56.000000000","message":"nit: location","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ShareSnapshotInstanceExportLocationsList(command.Lister):"},{"line_number":24,"context_line":"    \"\"\"List export locations from a share snapshot instance.\"\"\""},{"line_number":25,"context_line":"    _description \u003d _(\"List export locations from a share snapshot instance.\")"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"c485c116_5e4d6346","line":23,"range":{"start_line":23,"start_character":41,"end_line":23,"end_character":42},"in_reply_to":"806293f5_2ce82829","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cb0e29ce49c152bc1aa783aff9f73fba34674b16","unresolved":true,"context_lines":[{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \"instance\","},{"line_number":33,"context_line":"            metavar\u003d\"\u003cinstance\u003e\","},{"line_number":34,"context_line":"            help\u003d\"Name or ID of the share instance.\""},{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":11,"id":"8b544fa0_65601317","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":52},"updated":"2021-08-21 13:47:21.000000000","message":"Add translation support to help messages.","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser.add_argument("},{"line_number":32,"context_line":"            \"instance\","},{"line_number":33,"context_line":"            metavar\u003d\"\u003cinstance\u003e\","},{"line_number":34,"context_line":"            help\u003d\"Name or ID of the share instance.\""},{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":11,"id":"7fecead3_ab3800f8","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":52},"in_reply_to":"8b544fa0_65601317","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":39,"context_line":"    def take_action(self, parsed_args):"},{"line_number":40,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        snapshot_instance \u003d share_client.share_snapshot_instances.get("},{"line_number":43,"context_line":"            parsed_args.instance)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        share_snapshot_instance_export_locations \u003d ("},{"line_number":46,"context_line":"            share_client.share_snapshot_instance_export_locations.list("}],"source_content_type":"text/x-python","patch_set":11,"id":"6c529416_e8b3c1d2","line":43,"range":{"start_line":42,"start_character":8,"end_line":43,"end_character":33},"updated":"2021-08-22 15:22:56.000000000","message":"not a must but you could use utils.find_resource...\nan example: https://opendev.org/openstack/python-manilaclient/src/branch/master/manilaclient/osc/v2/share.py#L201","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def take_action(self, parsed_args):"},{"line_number":40,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        snapshot_instance \u003d share_client.share_snapshot_instances.get("},{"line_number":43,"context_line":"            parsed_args.instance)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        share_snapshot_instance_export_locations \u003d ("},{"line_number":46,"context_line":"            share_client.share_snapshot_instance_export_locations.list("}],"source_content_type":"text/x-python","patch_set":11,"id":"7f733144_b3d33066","line":43,"range":{"start_line":42,"start_character":8,"end_line":43,"end_character":33},"in_reply_to":"6c529416_e8b3c1d2","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":54,"context_line":"             share_snapshot_instance_export_locations))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class ShareSnapshotInstanceExportLocationsShow(command.ShowOne):"},{"line_number":58,"context_line":"    \"\"\"Show export location of the share snapshot instance.\"\"\""},{"line_number":59,"context_line":"    _description \u003d _(\"Show export location of the share snapshot instance.\")"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"77cd332f_4839b85a","line":57,"range":{"start_line":57,"start_character":41,"end_line":57,"end_character":42},"updated":"2021-08-22 15:22:56.000000000","message":"nit: Location","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":54,"context_line":"             share_snapshot_instance_export_locations))"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class ShareSnapshotInstanceExportLocationsShow(command.ShowOne):"},{"line_number":58,"context_line":"    \"\"\"Show export location of the share snapshot instance.\"\"\""},{"line_number":59,"context_line":"    _description \u003d _(\"Show export location of the share snapshot instance.\")"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"36b902f0_b1259748","line":57,"range":{"start_line":57,"start_character":41,"end_line":57,"end_character":42},"in_reply_to":"77cd332f_4839b85a","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    def take_action(self, parsed_args):"},{"line_number":79,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        snapshot_instance \u003d share_client.share_snapshot_instances.get("},{"line_number":82,"context_line":"            parsed_args.snapshot_instance)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        share_snapshot_instance_export_location \u003d ("},{"line_number":85,"context_line":"            share_client.share_snapshot_instance_export_locations.get("}],"source_content_type":"text/x-python","patch_set":11,"id":"28ceba74_25431f94","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":42},"updated":"2021-08-22 15:22:56.000000000","message":"same as find_resource comment above","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def take_action(self, parsed_args):"},{"line_number":79,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        snapshot_instance \u003d share_client.share_snapshot_instances.get("},{"line_number":82,"context_line":"            parsed_args.snapshot_instance)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        share_snapshot_instance_export_location \u003d ("},{"line_number":85,"context_line":"            share_client.share_snapshot_instance_export_locations.get("}],"source_content_type":"text/x-python","patch_set":11,"id":"9d58fa43_4f141c4e","line":82,"range":{"start_line":81,"start_character":8,"end_line":82,"end_character":42},"in_reply_to":"28ceba74_25431f94","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cb0e29ce49c152bc1aa783aff9f73fba34674b16","unresolved":true,"context_lines":[{"line_number":85,"context_line":"            share_client.share_snapshot_instance_export_locations.get("},{"line_number":86,"context_line":"                parsed_args.export_location,"},{"line_number":87,"context_line":"                snapshot_instance\u003dsnapshot_instance))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        return self.dict2columns(share_snapshot_instance_export_location._info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"e6ac93c2_4d823e2b","line":88,"updated":"2021-08-21 13:47:21.000000000","message":"We can remove \u0027links\u0027 from the result here. We\u0027ve been doing that with other commands and we also have a bug report to remove those where they originally were kept: https://bugs.launchpad.net/python-manilaclient/+bug/1912704","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            share_client.share_snapshot_instance_export_locations.get("},{"line_number":86,"context_line":"                parsed_args.export_location,"},{"line_number":87,"context_line":"                snapshot_instance\u003dsnapshot_instance))"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        return self.dict2columns(share_snapshot_instance_export_location._info)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1518d8fd_30742dbb","line":88,"in_reply_to":"e6ac93c2_4d823e2b","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"}],"manilaclient/osc/v2/share_snapshot_instances.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cb0e29ce49c152bc1aa783aff9f73fba34674b16","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        )"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \"--detailed\","},{"line_number":39,"context_line":"            metavar\u003d\"\u003cdetailed\u003e\","},{"line_number":40,"context_line":"            default\u003dFalse,"},{"line_number":41,"context_line":"            type\u003dbool,"},{"line_number":42,"context_line":"            help\u003d_(\"Show detailed information about snapshot instances. \""},{"line_number":43,"context_line":"                   \"(Default\u003dFalse)\")"},{"line_number":44,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"97dd34b6_3a731cc6","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":22},"updated":"2021-08-21 13:47:21.000000000","message":"We could do action\u003d\u0027store_true\u0027 here instead? So the user doesn\u0027t need to add the true/false argument to it, just adding the \u0027--detailed\u0027 flag will do. See: https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#boolean-options","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        )"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \"--detailed\","},{"line_number":39,"context_line":"            metavar\u003d\"\u003cdetailed\u003e\","},{"line_number":40,"context_line":"            default\u003dFalse,"},{"line_number":41,"context_line":"            type\u003dbool,"},{"line_number":42,"context_line":"            help\u003d_(\"Show detailed information about snapshot instances. \""},{"line_number":43,"context_line":"                   \"(Default\u003dFalse)\")"},{"line_number":44,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":11,"id":"2808360e_be6fb725","line":41,"range":{"start_line":39,"start_character":0,"end_line":41,"end_character":22},"in_reply_to":"97dd34b6_3a731cc6","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            detailed\u003dparsed_args.detailed,"},{"line_number":55,"context_line":"            snapshot\u003dsnapshot,"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if (parsed_args.detailed):"},{"line_number":59,"context_line":"            list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":60,"context_line":"                            \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"c3a3b7e7_c18720eb","line":57,"updated":"2021-08-22 15:22:56.000000000","message":"list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027]","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            detailed\u003dparsed_args.detailed,"},{"line_number":55,"context_line":"            snapshot\u003dsnapshot,"},{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if (parsed_args.detailed):"},{"line_number":59,"context_line":"            list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":60,"context_line":"                            \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"6f63dff9_ff13fb97","line":57,"in_reply_to":"c3a3b7e7_c18720eb","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if (parsed_args.detailed):"},{"line_number":59,"context_line":"            list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":60,"context_line":"                            \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":61,"context_line":"                            \u0027Progress\u0027, \u0027Provider_location\u0027]"},{"line_number":62,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"e170bee9_134100e5","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":24},"updated":"2021-08-22 15:22:56.000000000","message":"As an alternative you could drop \u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027 from here and:\nlist_of_keys +\u003d [\u0027\u0027Created_at\u0027,....]\nIn this way, you\u0027d be avoiding the below else statement","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cb0e29ce49c152bc1aa783aff9f73fba34674b16","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if (parsed_args.detailed):"},{"line_number":59,"context_line":"            list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":60,"context_line":"                            \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":61,"context_line":"                            \u0027Progress\u0027, \u0027Provider_location\u0027]"},{"line_number":62,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"3a0e1b74_adf50b4d","line":59,"range":{"start_line":59,"start_character":67,"end_line":59,"end_character":68},"updated":"2021-08-21 13:47:21.000000000","message":"we can drop the underscores, capitalise all words and for id go with ID. We have tried to follow that pattern for all commands.","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if (parsed_args.detailed):"},{"line_number":59,"context_line":"            list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":60,"context_line":"                            \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":61,"context_line":"                            \u0027Progress\u0027, \u0027Provider_location\u0027]"},{"line_number":62,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"73f540bc_44adeb52","line":59,"range":{"start_line":59,"start_character":67,"end_line":59,"end_character":68},"in_reply_to":"3a0e1b74_adf50b4d","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        )"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        if (parsed_args.detailed):"},{"line_number":59,"context_line":"            list_of_keys \u003d [\u0027ID\u0027, \u0027Snapshot ID\u0027, \u0027Status\u0027, \u0027Created_at\u0027,"},{"line_number":60,"context_line":"                            \u0027Updated_at\u0027, \u0027Share_id\u0027, \u0027Share_instance_id\u0027,"},{"line_number":61,"context_line":"                            \u0027Progress\u0027, \u0027Provider_location\u0027]"},{"line_number":62,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"96d11ad3_50f3b4cc","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":24},"in_reply_to":"e170bee9_134100e5","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":86,"context_line":"        snapshot_instance \u003d ("},{"line_number":87,"context_line":"            share_client.share_snapshot_instances.get("},{"line_number":88,"context_line":"                parsed_args.snapshot_instance)"},{"line_number":89,"context_line":"            if parsed_args.snapshot_instance else None)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self.dict2columns(snapshot_instance._info)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"f500d3c3_ad79e038","line":89,"range":{"start_line":89,"start_character":15,"end_line":89,"end_character":44},"updated":"2021-08-22 15:22:56.000000000","message":"the snapshot_instance should be mandatory, right? Because if it isn\u0027t, we shouldn\u0027t even allow the action to be taken and an error would be raised saying that there is one argument missing, so I\u0027d say this is not necessary","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        snapshot_instance \u003d ("},{"line_number":87,"context_line":"            share_client.share_snapshot_instances.get("},{"line_number":88,"context_line":"                parsed_args.snapshot_instance)"},{"line_number":89,"context_line":"            if parsed_args.snapshot_instance else None)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self.dict2columns(snapshot_instance._info)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"39c80a45_ec8e8baf","line":89,"range":{"start_line":89,"start_character":15,"end_line":89,"end_character":44},"in_reply_to":"f500d3c3_ad79e038","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cb0e29ce49c152bc1aa783aff9f73fba34674b16","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \u0027--status\u0027,"},{"line_number":109,"context_line":"            metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":110,"context_line":"            default\u003d\u0027available\u0027,"},{"line_number":111,"context_line":"            help\u003d(\u0027Indicate state to update the snapshot instance to.\u0027"},{"line_number":112,"context_line":"                  \u0027Options: available, error, creating, deleting, \u0027"},{"line_number":113,"context_line":"                  \u0027error_deleting. Default is available.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"8649b9f9_a2171cb7","line":110,"updated":"2021-08-21 13:47:21.000000000","message":"we could add the options here as choices, see: https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#options-with-choices","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \u0027--status\u0027,"},{"line_number":109,"context_line":"            metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":110,"context_line":"            default\u003d\u0027available\u0027,"},{"line_number":111,"context_line":"            help\u003d(\u0027Indicate state to update the snapshot instance to.\u0027"},{"line_number":112,"context_line":"                  \u0027Options: available, error, creating, deleting, \u0027"},{"line_number":113,"context_line":"                  \u0027error_deleting. Default is available.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"d35239cd_1f5feed5","line":110,"in_reply_to":"8649b9f9_a2171cb7","updated":"2021-08-22 15:22:56.000000000","message":"+1\nAlso, in this way you wouldn\u0027t need to add the choices in the help and they would be already validated as soon as they\u0027re specified","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        parser.add_argument("},{"line_number":108,"context_line":"            \u0027--status\u0027,"},{"line_number":109,"context_line":"            metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":110,"context_line":"            default\u003d\u0027available\u0027,"},{"line_number":111,"context_line":"            help\u003d(\u0027Indicate state to update the snapshot instance to.\u0027"},{"line_number":112,"context_line":"                  \u0027Options: available, error, creating, deleting, \u0027"},{"line_number":113,"context_line":"                  \u0027error_deleting. Default is available.\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"e2acb888_e38979d5","line":110,"in_reply_to":"d35239cd_1f5feed5","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            (share_client"},{"line_number":123,"context_line":"                .share_snapshot_instances"},{"line_number":124,"context_line":"                .reset_state("},{"line_number":125,"context_line":"                    parsed_args.snapshot_instance,"},{"line_number":126,"context_line":"                    parsed_args.status))"},{"line_number":127,"context_line":"        except Exception as e:"},{"line_number":128,"context_line":"            msg \u003d _("},{"line_number":129,"context_line":"                \"Failed to update share snapshot instance status: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":11,"id":"33563520_522d10d7","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":40},"updated":"2021-08-22 15:22:56.000000000","message":"Might get easier to read formatting like this:\nshare_client.share_snapshot_instances.reset_state(\n            parsed_args.snapshot_instance, parsed_args.status)","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        try:"},{"line_number":122,"context_line":"            (share_client"},{"line_number":123,"context_line":"                .share_snapshot_instances"},{"line_number":124,"context_line":"                .reset_state("},{"line_number":125,"context_line":"                    parsed_args.snapshot_instance,"},{"line_number":126,"context_line":"                    parsed_args.status))"},{"line_number":127,"context_line":"        except Exception as e:"},{"line_number":128,"context_line":"            msg \u003d _("},{"line_number":129,"context_line":"                \"Failed to update share snapshot instance status: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1510439c_d6718444","line":126,"range":{"start_line":122,"start_character":0,"end_line":126,"end_character":40},"in_reply_to":"33563520_522d10d7","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2a8fd37e507fa11f9fdc9771c12a6fb00e94622a","unresolved":true,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        snapshot_instance._info.pop(\u0027links\u0027, None)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return self.dict2columns(snapshot_instance._info)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class SetShareSnapshotInstance(command.Command):"}],"source_content_type":"text/x-python","patch_set":12,"id":"de8ba9ef_8ce4f4be","line":88,"updated":"2021-08-23 21:53:40.000000000","message":"Just realized something...\nIt\u0027s missing the export location here.\nExample in our current CLI: https://paste.openstack.org/show/808262/\nSorry I didn\u0027t realize this before... I was retesting my command and came here again to get an example of something and realized this :)","commit_id":"56514180c642f11773b36cd7c0644d3365027b6d"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0ccc3a2f125d6b28d563540d135a63b7a278d38b","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        snapshot_instance._info.pop(\u0027links\u0027, None)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        return self.dict2columns(snapshot_instance._info)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class SetShareSnapshotInstance(command.Command):"}],"source_content_type":"text/x-python","patch_set":12,"id":"d7f5b7ce_3ddb1e39","line":88,"in_reply_to":"de8ba9ef_8ce4f4be","updated":"2021-08-24 14:02:53.000000000","message":"Done","commit_id":"56514180c642f11773b36cd7c0644d3365027b6d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"bac84c004338a036e53da411222ab37580097224","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            element_location._info.pop(\u0027links\u0027, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        snapshot_instance._info[\u0027export_locations\u0027] \u003d ("},{"line_number":95,"context_line":"            cliutils.transform_export_locations_to_string_view("},{"line_number":96,"context_line":"                snapshot_instance_export_locations))"},{"line_number":97,"context_line":"        snapshot_instance._info.pop(\u0027links\u0027, None)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"13c621d4_e333f15d","line":95,"updated":"2021-08-24 15:08:04.000000000","message":"We should do this only for the table format: if parsed_args.formatter \u003d\u003d \u0027table\u0027\nSo we don\u0027t create one long string for json and yaml.\n\nBut if we only do this for the table view, we will break the json and yaml, as discovered in https://review.opendev.org/c/openstack/python-manilaclient/+/805250  :) \n\nSo, I would suggest we loop over the export locations and take the ._info for each, add _those_ to the snapshot instance.\nAnd for the table view, also transform those to the string.\n\nWhat do you think?","commit_id":"08105fc017ae8e7d2f3af07bfd458f9215c56cbe"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"15716b4ad8edf2e363ba577779a4c9e9f55032c2","unresolved":true,"context_lines":[{"line_number":92,"context_line":"            element_location._info.pop(\u0027links\u0027, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        snapshot_instance._info[\u0027export_locations\u0027] \u003d ("},{"line_number":95,"context_line":"            cliutils.transform_export_locations_to_string_view("},{"line_number":96,"context_line":"                snapshot_instance_export_locations))"},{"line_number":97,"context_line":"        snapshot_instance._info.pop(\u0027links\u0027, None)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"4a2fdf8a_f8efae0e","line":95,"in_reply_to":"13c621d4_e333f15d","updated":"2021-08-24 19:58:11.000000000","message":"I don\u0027t know if I mixed up what you said. But tried the following:\nhttps://paste.opendev.org/show/808292/\n\nin this case we get the same results as before on -f json:\nhttps://paste.opendev.org/show/808293/\n\nRemoving the string parser from the export locations list will give us the correct outputs for yaml and json, but the show pure output will be broken.","commit_id":"08105fc017ae8e7d2f3af07bfd458f9215c56cbe"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cb0e29ce49c152bc1aa783aff9f73fba34674b16","unresolved":true,"context_lines":[{"line_number":426,"context_line":"        :param Dictionary attrs:"},{"line_number":427,"context_line":"            A dictionary with all attributes"},{"line_number":428,"context_line":"        :param Integer count:"},{"line_number":429,"context_line":"            The number of share types to be faked"},{"line_number":430,"context_line":"        :return:"},{"line_number":431,"context_line":"            A list of FakeResource objects"},{"line_number":432,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"b05c2839_2ce8cdfc","line":429,"range":{"start_line":429,"start_character":26,"end_line":429,"end_character":37},"updated":"2021-08-21 13:47:21.000000000","message":"share snapshot instances","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":426,"context_line":"        :param Dictionary attrs:"},{"line_number":427,"context_line":"            A dictionary with all attributes"},{"line_number":428,"context_line":"        :param Integer count:"},{"line_number":429,"context_line":"            The number of share types to be faked"},{"line_number":430,"context_line":"        :return:"},{"line_number":431,"context_line":"            A list of FakeResource objects"},{"line_number":432,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"0c285a07_1fe6cc53","line":429,"range":{"start_line":429,"start_character":26,"end_line":429,"end_character":37},"in_reply_to":"b05c2839_2ce8cdfc","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"}],"manilaclient/tests/unit/osc/v2/test_share_snapshot_instance_export_locations.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2019 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"0fe1ee6a_43be45e0","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":19},"updated":"2021-08-22 15:22:56.000000000","message":"2021","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2019 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"95f977da_fc12b478","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":19},"in_reply_to":"0fe1ee6a_43be45e0","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"}],"manilaclient/tests/unit/osc/v2/test_share_snapshot_instances.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"205d8e5d2a952b079e20db577cf4e2ed1438a051","unresolved":true,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2019 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"90d9d152_dd1133cc","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":19},"updated":"2021-08-22 15:22:56.000000000","message":"2021","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"99c2a6d625aaf61ba697004e8c5576e583634167","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#   Copyright 2019 Red Hat Inc. All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#   not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":11,"id":"98e0b282_1eaca609","line":1,"range":{"start_line":1,"start_character":14,"end_line":1,"end_character":19},"in_reply_to":"90d9d152_dd1133cc","updated":"2021-08-23 15:00:47.000000000","message":"Done","commit_id":"2f0d23aa2bb42cb69ad64e8b5b5b4fc2722c4f2c"}]}