)]}'
{"doc/source/cli/osc/v2/index.rst":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":104,"context_line":"    :command: share instance *"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":107,"context_line":"share instance export location"}],"source_content_type":"text/x-rst","patch_set":3,"id":"be0e52ab_7916d195","line":104,"range":{"start_line":104,"start_character":29,"end_line":104,"end_character":30},"updated":"2021-08-27 07:15:51.000000000","message":"I believe this will also pull in the export location commands.\nTo avoid that, we could follow what Fábio and Caique did, see: https://review.opendev.org/c/openstack/python-manilaclient/+/805259/15/doc/source/cli/osc/v2/index.rst","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":101,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":104,"context_line":"    :command: share instance *"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":107,"context_line":"share instance export location"}],"source_content_type":"text/x-rst","patch_set":3,"id":"291005cc_cff06ab6","line":104,"range":{"start_line":104,"start_character":29,"end_line":104,"end_character":30},"in_reply_to":"be0e52ab_7916d195","updated":"2021-08-31 20:20:20.000000000","message":"Done","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"}],"manilaclient/osc/v2/share_instance_export_locations.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \"instance\","},{"line_number":36,"context_line":"            metavar\u003d\"\u003cinstance\u003e\","},{"line_number":37,"context_line":"            help\u003d_(\"Name or ID of the share instance.\")"},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":"        parser.add_argument("},{"line_number":40,"context_line":"            \"--columns\","}],"source_content_type":"text/x-python","patch_set":3,"id":"dbba08c9_571b521d","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":30},"updated":"2021-08-27 07:15:51.000000000","message":"I believe share instances do not have a name attribute, so it\u0027s just the ID.","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        parser.add_argument("},{"line_number":35,"context_line":"            \"instance\","},{"line_number":36,"context_line":"            metavar\u003d\"\u003cinstance\u003e\","},{"line_number":37,"context_line":"            help\u003d_(\"Name or ID of the share instance.\")"},{"line_number":38,"context_line":"        )"},{"line_number":39,"context_line":"        parser.add_argument("},{"line_number":40,"context_line":"            \"--columns\","}],"source_content_type":"text/x-python","patch_set":3,"id":"640be537_6b0b90ac","line":37,"range":{"start_line":37,"start_character":20,"end_line":37,"end_character":30},"in_reply_to":"dbba08c9_571b521d","updated":"2021-08-31 20:20:20.000000000","message":"Done","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"9f34bbbb18f44208f5c00ab83460e55d40a3b092","unresolved":true,"context_lines":[{"line_number":40,"context_line":"            \"--columns\","},{"line_number":41,"context_line":"            metavar\u003d\"\u003ccolumns\u003e\","},{"line_number":42,"context_line":"            help\u003d_(\u0027Comma separated list of columns to be \\"},{"line_number":43,"context_line":"                    displayed example --columns \"id,host,status\".\u0027)"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        return parser"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"27768201_c9b88429","line":43,"range":{"start_line":43,"start_character":49,"end_line":43,"end_character":63},"updated":"2021-08-23 17:07:24.000000000","message":"are these the right columns? host and status are not in columns list in line 58, nor in FakeShareInstanceExportLocation","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f6565d6b86a0a8446bd0c42b532293cf3648bcf7","unresolved":true,"context_lines":[{"line_number":40,"context_line":"            \"--columns\","},{"line_number":41,"context_line":"            metavar\u003d\"\u003ccolumns\u003e\","},{"line_number":42,"context_line":"            help\u003d_(\u0027Comma separated list of columns to be \\"},{"line_number":43,"context_line":"                    displayed example --columns \"id,host,status\".\u0027)"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        return parser"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"65acae8d_ff164813","line":43,"range":{"start_line":43,"start_character":49,"end_line":43,"end_character":63},"in_reply_to":"27768201_c9b88429","updated":"2021-08-24 18:30:50.000000000","message":"+1\nI believe we do not need --columns. The Openstack client already has these options built in. So perhaps we do not need to add this argument.","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":40,"context_line":"            \"--columns\","},{"line_number":41,"context_line":"            metavar\u003d\"\u003ccolumns\u003e\","},{"line_number":42,"context_line":"            help\u003d_(\u0027Comma separated list of columns to be \\"},{"line_number":43,"context_line":"                    displayed example --columns \"id,host,status\".\u0027)"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        return parser"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"e2fc0497_cadf1681","line":43,"range":{"start_line":43,"start_character":49,"end_line":43,"end_character":63},"in_reply_to":"65acae8d_ff164813","updated":"2021-08-27 07:15:51.000000000","message":"+1 We can drop the \u0027--columns\u0027 option here.","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \"--columns\","},{"line_number":41,"context_line":"            metavar\u003d\"\u003ccolumns\u003e\","},{"line_number":42,"context_line":"            help\u003d_(\u0027Comma separated list of columns to be \\"},{"line_number":43,"context_line":"                    displayed example --columns \"id,host,status\".\u0027)"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        return parser"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"897f07dd_853a7708","line":43,"range":{"start_line":43,"start_character":49,"end_line":43,"end_character":63},"in_reply_to":"e2fc0497_cadf1681","updated":"2021-08-31 20:20:20.000000000","message":"Done","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f6565d6b86a0a8446bd0c42b532293cf3648bcf7","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            instance,"},{"line_number":56,"context_line":"            search_opts\u003dNone)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        columns \u003d ["},{"line_number":59,"context_line":"            \u0027id\u0027,"},{"line_number":60,"context_line":"            \u0027path\u0027,"},{"line_number":61,"context_line":"            \u0027is_admin_only\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"07ec20c0_51d05e76","line":58,"updated":"2021-08-24 18:30:50.000000000","message":"You can format the headers directly here.get_dict_properties() we will handle the conversion\nexample:\nhttps://review.opendev.org/c/openstack/python-manilaclient/+/805250/5/manilaclient/osc/v2/share_instances.py#125","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            instance,"},{"line_number":56,"context_line":"            search_opts\u003dNone)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        columns \u003d ["},{"line_number":59,"context_line":"            \u0027id\u0027,"},{"line_number":60,"context_line":"            \u0027path\u0027,"},{"line_number":61,"context_line":"            \u0027is_admin_only\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"2288816e_6a233cdd","line":58,"in_reply_to":"07ec20c0_51d05e76","updated":"2021-08-27 07:15:51.000000000","message":"+1","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            instance,"},{"line_number":56,"context_line":"            search_opts\u003dNone)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        columns \u003d ["},{"line_number":59,"context_line":"            \u0027id\u0027,"},{"line_number":60,"context_line":"            \u0027path\u0027,"},{"line_number":61,"context_line":"            \u0027is_admin_only\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"cd73dc0a_42a897aa","line":58,"in_reply_to":"2288816e_6a233cdd","updated":"2021-08-31 20:20:20.000000000","message":"Done","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7495e73bc23a9d772a895bd63c0049f221ada071","unresolved":true,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ShareInstanceListExportLocation(command.Lister):"},{"line_number":28,"context_line":"    \"\"\"List share instance export location.\"\"\""},{"line_number":29,"context_line":"    _description \u003d _(\"List share instance export location\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super("}],"source_content_type":"text/x-python","patch_set":5,"id":"1fafe361_62e3e048","line":29,"range":{"start_line":29,"start_character":49,"end_line":29,"end_character":57},"updated":"2021-08-31 21:43:31.000000000","message":"nit: locations","commit_id":"152680dd2548a8c5a824e2532e40793954767f79"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"46e3bc6f52225355c248d883f5dd4a32c0f730ee","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class ShareInstanceListExportLocation(command.Lister):"},{"line_number":28,"context_line":"    \"\"\"List share instance export location.\"\"\""},{"line_number":29,"context_line":"    _description \u003d _(\"List share instance export location\")"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super("}],"source_content_type":"text/x-python","patch_set":5,"id":"59408b0e_cdea6ace","line":29,"range":{"start_line":29,"start_character":49,"end_line":29,"end_character":57},"in_reply_to":"1fafe361_62e3e048","updated":"2021-09-01 12:55:55.000000000","message":"Done","commit_id":"152680dd2548a8c5a824e2532e40793954767f79"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7495e73bc23a9d772a895bd63c0049f221ada071","unresolved":true,"context_lines":[{"line_number":68,"context_line":"class ShareInstanceShowExportLocation(command.ShowOne):"},{"line_number":69,"context_line":"    \"\"\"Display the export location for the share instance.\"\"\""},{"line_number":70,"context_line":"    _description \u003d _("},{"line_number":71,"context_line":"        \"Show export location for the share instance.\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_parser(self, prog_name):"},{"line_number":74,"context_line":"        parser \u003d super("}],"source_content_type":"text/x-python","patch_set":5,"id":"2f42347a_2f13654f","line":71,"range":{"start_line":71,"start_character":34,"end_line":71,"end_character":37},"updated":"2021-08-31 21:43:31.000000000","message":"nit: a","commit_id":"152680dd2548a8c5a824e2532e40793954767f79"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"46e3bc6f52225355c248d883f5dd4a32c0f730ee","unresolved":false,"context_lines":[{"line_number":68,"context_line":"class ShareInstanceShowExportLocation(command.ShowOne):"},{"line_number":69,"context_line":"    \"\"\"Display the export location for the share instance.\"\"\""},{"line_number":70,"context_line":"    _description \u003d _("},{"line_number":71,"context_line":"        \"Show export location for the share instance.\")"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_parser(self, prog_name):"},{"line_number":74,"context_line":"        parser \u003d super("}],"source_content_type":"text/x-python","patch_set":5,"id":"ceb77e25_3f34429b","line":71,"range":{"start_line":71,"start_character":34,"end_line":71,"end_character":37},"in_reply_to":"2f42347a_2f13654f","updated":"2021-09-01 12:55:55.000000000","message":"Done","commit_id":"152680dd2548a8c5a824e2532e40793954767f79"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b28641d9673f63d38d3da91586ebb1829fe19b15","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            \u0027Preferred\u0027,"},{"line_number":57,"context_line":"        ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        column_headers \u003d utils.format_column_headers(columns)"},{"line_number":60,"context_line":"        data \u003d ("},{"line_number":61,"context_line":"            osc_utils.get_dict_properties(export_location._info, columns)"},{"line_number":62,"context_line":"            for export_location in export_locations"}],"source_content_type":"text/x-python","patch_set":6,"id":"6a2efccf_da23a4f4","line":59,"updated":"2021-09-01 13:07:44.000000000","message":"nit: we can drop this line","commit_id":"3479c1744449f5433523ac8be9562ab52ab82c37"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"f8fc8336b553d700b047e3c445903beef88857c4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            \u0027Preferred\u0027,"},{"line_number":57,"context_line":"        ]"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        column_headers \u003d utils.format_column_headers(columns)"},{"line_number":60,"context_line":"        data \u003d ("},{"line_number":61,"context_line":"            osc_utils.get_dict_properties(export_location._info, columns)"},{"line_number":62,"context_line":"            for export_location in export_locations"}],"source_content_type":"text/x-python","patch_set":6,"id":"4b4b1e19_463a29af","line":59,"in_reply_to":"6a2efccf_da23a4f4","updated":"2021-09-01 14:14:15.000000000","message":"Done","commit_id":"3479c1744449f5433523ac8be9562ab52ab82c37"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"b28641d9673f63d38d3da91586ebb1829fe19b15","unresolved":true,"context_lines":[{"line_number":62,"context_line":"            for export_location in export_locations"},{"line_number":63,"context_line":"        )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return (column_headers, data)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class ShareInstanceShowExportLocation(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d346bf32_cd6f1734","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":30},"updated":"2021-09-01 13:07:44.000000000","message":"nit: columns","commit_id":"3479c1744449f5433523ac8be9562ab52ab82c37"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"f8fc8336b553d700b047e3c445903beef88857c4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            for export_location in export_locations"},{"line_number":63,"context_line":"        )"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        return (column_headers, data)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class ShareInstanceShowExportLocation(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a058192_5e731bf8","line":65,"range":{"start_line":65,"start_character":16,"end_line":65,"end_character":30},"in_reply_to":"d346bf32_cd6f1734","updated":"2021-09-01 14:14:15.000000000","message":"Done","commit_id":"3479c1744449f5433523ac8be9562ab52ab82c37"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":654,"context_line":"        return share_replicas"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class FakeShareInstanceExportLocation(object):"},{"line_number":658,"context_line":"    \"\"\"Fake a share instance export location\"\"\""},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"092cd668_6ac12317","line":657,"updated":"2021-08-27 07:15:51.000000000","message":"Looks like we are creating multiple fake export locations in here: FakeShareExportLocation in line 290 and FakeSnapshotExportLocation in line 493 and this would be third one although the objects are quite similar. I believe we could refactor this and have one, FakeExportLocation class, and where necessary pass custom attributes to the create method.\n\nHowever, refactoring all that is not in the scope of this patch so I wouldn\u0027t ask you to do that, I can report a bug for that and create a task for the OSC board.\n\nBut, perhaps you could find a way to reuse one of the existing classes for your tests and not add this third one???","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":654,"context_line":"        return share_replicas"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class FakeShareInstanceExportLocation(object):"},{"line_number":658,"context_line":"    \"\"\"Fake a share instance export location\"\"\""},{"line_number":659,"context_line":""},{"line_number":660,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c886225_84217a57","line":657,"in_reply_to":"092cd668_6ac12317","updated":"2021-08-31 20:20:20.000000000","message":"Done. We reused the FakeShareExportLocation class to our unit tests.","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"f6565d6b86a0a8446bd0c42b532293cf3648bcf7","unresolved":true,"context_lines":[{"line_number":695,"context_line":"            A dictionary with all attributes"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        :param Integer count:"},{"line_number":698,"context_line":"            The number of share types to be faked"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"        :return:"},{"line_number":701,"context_line":"            A list of FakeResource objects"}],"source_content_type":"text/x-python","patch_set":3,"id":"861bd76e_994dd4b0","line":698,"updated":"2021-08-24 18:30:50.000000000","message":"Replace \"share type\" with \"instance export locations\"","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":695,"context_line":"            A dictionary with all attributes"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"        :param Integer count:"},{"line_number":698,"context_line":"            The number of share types to be faked"},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"        :return:"},{"line_number":701,"context_line":"            A list of FakeResource objects"}],"source_content_type":"text/x-python","patch_set":3,"id":"21e5151e_0703da97","line":698,"in_reply_to":"861bd76e_994dd4b0","updated":"2021-08-31 20:20:20.000000000","message":"Ack","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7495e73bc23a9d772a895bd63c0049f221ada071","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2c06b7d6_70b44f6d","updated":"2021-08-31 21:43:31.000000000","message":"nit: some unrelated whitespace changes in this file that can be reverted.","commit_id":"152680dd2548a8c5a824e2532e40793954767f79"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"46e3bc6f52225355c248d883f5dd4a32c0f730ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4eeb4a58_db979a94","in_reply_to":"2c06b7d6_70b44f6d","updated":"2021-09-01 12:55:55.000000000","message":"Done","commit_id":"152680dd2548a8c5a824e2532e40793954767f79"}],"manilaclient/tests/unit/osc/v2/test_share_instance_export_locations.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        \u0027preferred\u0027,"},{"line_number":49,"context_line":"    ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    column_headers \u003d utils.format_column_headers(columns)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def setUp(self):"},{"line_number":54,"context_line":"        super(TestShareInstanceExportLocationList, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"7b5c7669_845fe4e8","line":51,"updated":"2021-08-27 07:15:51.000000000","message":"same note here, we can have the columns formatted nicely right away.","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \u0027preferred\u0027,"},{"line_number":49,"context_line":"    ]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    column_headers \u003d utils.format_column_headers(columns)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def setUp(self):"},{"line_number":54,"context_line":"        super(TestShareInstanceExportLocationList, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d3bcff47_430d7efb","line":51,"in_reply_to":"7b5c7669_845fe4e8","updated":"2021-08-31 20:20:20.000000000","message":"Done","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"}],"setup.cfg":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e233dd8ca56161359263c0b707e68055430b19c7","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    share_replica_resync \u003d manilaclient.osc.v2.share_replicas:ResyncShareReplica"},{"line_number":94,"context_line":"    share_availability_zone_list \u003d manilaclient.osc.v2.availability_zones:ShareAvailabilityZoneList"},{"line_number":95,"context_line":"    share_instance_force_delete \u003d manilaclient.osc.v2.share_instances:ShareInstanceForceDelete"},{"line_number":96,"context_line":"    share_instance_list \u003d manilaclient.osc.v2.share_instances:ShareInstanceList"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"[coverage:run]"},{"line_number":99,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"b599a861_6821e33f","line":96,"updated":"2021-08-27 07:15:51.000000000","message":"Nit: I would move the definitions to follow the rest of the share instance commands.","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"65036dc8271537a4e387391210de78e69d8ccdef","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    share_replica_resync \u003d manilaclient.osc.v2.share_replicas:ResyncShareReplica"},{"line_number":94,"context_line":"    share_availability_zone_list \u003d manilaclient.osc.v2.availability_zones:ShareAvailabilityZoneList"},{"line_number":95,"context_line":"    share_instance_force_delete \u003d manilaclient.osc.v2.share_instances:ShareInstanceForceDelete"},{"line_number":96,"context_line":"    share_instance_list \u003d manilaclient.osc.v2.share_instances:ShareInstanceList"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"[coverage:run]"},{"line_number":99,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"9660e3c2_d7568c5b","line":96,"in_reply_to":"b599a861_6821e33f","updated":"2021-08-31 20:20:20.000000000","message":"Done","commit_id":"832bf702f4025834ea9d73b5a58fd960c3bdc29d"}]}