)]}'
{"manilaclient/osc/v2/share_replica_export_locations.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"59b96ba6e37550c041667d06587c7753b2ea1fe1","unresolved":true,"context_lines":[{"line_number":15,"context_line":"from manilaclient.common._i18n import _"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class ShareReplicaListExportLocation(command.Lister):"},{"line_number":19,"context_line":"    \"\"\"List export locations of a share replica.\"\"\""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    _description \u003d _(\"List export locations of a share replica.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3d8dabb_cf29376b","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":36},"updated":"2021-08-24 00:26:02.000000000","message":"nit: other commands have \"List\" at the end","commit_id":"ca0079803090d4c0ea6a492dbd076277e71134de"}],"manilaclient/osc/v2/share_replicas.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5638c760fb1b02ece48afdc3748942d2cdca2b78","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                \"Failed to resync share replica: %s\" % (e)))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class ShareReplicaListExportLocation(command.Lister):"},{"line_number":333,"context_line":"    \"\"\"List export locations of a share replica.\"\"\""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    _description \u003d _(\"List export locations of a share replica.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"5c2713f7_2728f0aa","line":332,"updated":"2021-08-22 15:35:52.000000000","message":"Just a question... Shouldn\u0027t we have another file for this?\nJust asking because we currently have share replicas and share replica export locations in different files in the structure...","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"0affa7505b67735430c11a9d618345b204b04879","unresolved":true,"context_lines":[{"line_number":329,"context_line":"                \"Failed to resync share replica: %s\" % (e)))"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class ShareReplicaListExportLocation(command.Lister):"},{"line_number":333,"context_line":"    \"\"\"List export locations of a share replica.\"\"\""},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"    _description \u003d _(\"List export locations of a share replica.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"d0ec90c8_88219d64","line":332,"in_reply_to":"5c2713f7_2728f0aa","updated":"2021-08-23 06:34:21.000000000","message":"Oh, sure, I can move this to a separate file so we keep the same structure.","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5638c760fb1b02ece48afdc3748942d2cdca2b78","unresolved":true,"context_lines":[{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \"replica\","},{"line_number":381,"context_line":"            metavar\u003d\"\u003creplica\u003e\","},{"line_number":382,"context_line":"            help\u003d_(\"Name or ID of the share replica.\")"},{"line_number":383,"context_line":"        )"},{"line_number":384,"context_line":"        parser.add_argument("},{"line_number":385,"context_line":"            \"export_location\","}],"source_content_type":"text/x-python","patch_set":1,"id":"f773058b_dc040966","line":382,"range":{"start_line":382,"start_character":20,"end_line":382,"end_character":30},"updated":"2021-08-22 15:35:52.000000000","message":"I\u0027d say \"ID of the share replica\" seems more appropriate, considering that replicas don\u0027t have a name attribute","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"0affa7505b67735430c11a9d618345b204b04879","unresolved":false,"context_lines":[{"line_number":379,"context_line":"        parser.add_argument("},{"line_number":380,"context_line":"            \"replica\","},{"line_number":381,"context_line":"            metavar\u003d\"\u003creplica\u003e\","},{"line_number":382,"context_line":"            help\u003d_(\"Name or ID of the share replica.\")"},{"line_number":383,"context_line":"        )"},{"line_number":384,"context_line":"        parser.add_argument("},{"line_number":385,"context_line":"            \"export_location\","}],"source_content_type":"text/x-python","patch_set":1,"id":"ee573800_6c65fc2a","line":382,"range":{"start_line":382,"start_character":20,"end_line":382,"end_character":30},"in_reply_to":"f773058b_dc040966","updated":"2021-08-23 06:34:21.000000000","message":"Ack","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"}],"manilaclient/tests/unit/osc/v2/fakes.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5638c760fb1b02ece48afdc3748942d2cdca2b78","unresolved":true,"context_lines":[{"line_number":306,"context_line":"            \"fake_path\": \"/foo/el/path\","},{"line_number":307,"context_line":"            \"fake_share_instance_id\": \u0027share-instance-id\u0027 + uuid.uuid4().hex,"},{"line_number":308,"context_line":"            \"fake_uuid\": \"foo_el_uuid\","},{"line_number":309,"context_line":"            \"id\": \"id-\" + uuid.uuid4().hex,"},{"line_number":310,"context_line":"            \"is_admin_only\": False,"},{"line_number":311,"context_line":"            \"preferred\": False,"},{"line_number":312,"context_line":"            \"updated_at\": \u0027time-\u0027 + uuid.uuid4().hex,"}],"source_content_type":"text/x-python","patch_set":1,"id":"806dcb92_efc14554","line":309,"range":{"start_line":309,"start_character":12,"end_line":309,"end_character":43},"updated":"2021-08-22 15:35:52.000000000","message":"good catch :)","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"}],"manilaclient/tests/unit/osc/v2/test_share_replicas.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5638c760fb1b02ece48afdc3748942d2cdca2b78","unresolved":true,"context_lines":[{"line_number":588,"context_line":"            parsed_args)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"class TestShareReplicaExportLocationList(TestShareReplica):"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    columns \u003d ["},{"line_number":594,"context_line":"        \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"56f45a32_36b082f7","line":591,"updated":"2021-08-22 15:35:52.000000000","message":"same question about the file where it should be placed...","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"0affa7505b67735430c11a9d618345b204b04879","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            parsed_args)"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"class TestShareReplicaExportLocationList(TestShareReplica):"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"    columns \u003d ["},{"line_number":594,"context_line":"        \u0027ID\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f9a56155_42e12a11","line":591,"in_reply_to":"56f45a32_36b082f7","updated":"2021-08-23 06:34:21.000000000","message":"Done","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5638c760fb1b02ece48afdc3748942d2cdca2b78","unresolved":true,"context_lines":[{"line_number":667,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        self.export_locations_mock.get.assert_called_with("},{"line_number":672,"context_line":"            self.share_replica,"},{"line_number":673,"context_line":"            self.export_location.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c3ed17a5_d79fc535","line":670,"updated":"2021-08-22 15:35:52.000000000","message":"Please add the assert to the self.share_replicas_mock.get as well :)","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"0affa7505b67735430c11a9d618345b204b04879","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":670,"context_line":""},{"line_number":671,"context_line":"        self.export_locations_mock.get.assert_called_with("},{"line_number":672,"context_line":"            self.share_replica,"},{"line_number":673,"context_line":"            self.export_location.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4681c51b_f440ecf2","line":670,"in_reply_to":"c3ed17a5_d79fc535","updated":"2021-08-23 06:34:21.000000000","message":"Ack","commit_id":"f50c153a4fb3584879d806052875d9a0e3803027"}]}