)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34489,"name":"Matheus Andrade","email":"matheus.handrade15@gmail.com","username":"matheusandrade"},"change_message_id":"387891c405cf9faf0b442545592839a399f83bfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5b7de681_0deeed80","updated":"2022-03-24 19:57:41.000000000","message":"recheck","commit_id":"4366660e537d51eee33207b38289478ab50a8a55"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"0da623d0f25f1587469c36d9f8dc2533e46d48ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fee8c2d0_22839459","updated":"2022-04-07 20:48:14.000000000","message":"Hello, thanks for the patch. I did a quick QA and found some issues: \n\n1. When listing the quotas by project, the table header from OSC and manila client are different\n2. When some quota is updated, only the last field in the list appears in the table. For example, I set \"--shares\" and \"--snapshots\", but only the last one will appear.\n3. I think the command line \"openstack share quota list by project\" is not following the pattern we have in other commands. Maybe you could use something like \"openstack share quota list\". \n4. The \"manila help\" command is not listing the help message for \"manila quota-list-by-project\"\n\nSome of the commands I tested can be found here: https://paste.opendev.org/show/bYqWRjdxutnIb89t2Y92/ \n\nIf you have any questions, feel free to contact me :)  \n","commit_id":"a43dad966351644a88f28e0fdd85e19812ebbe8b"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"9e0fcc366791834db29221acdcd0ff607bb00d21","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":6,"id":"74f1b516_5ad72786","in_reply_to":"fee8c2d0_22839459","updated":"2022-08-18 18:28:12.000000000","message":"Marking as not resolved - I believe this was not addressed yet.","commit_id":"a43dad966351644a88f28e0fdd85e19812ebbe8b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b7cc6f24cbda71ad7a9066b18a2712fa3bb748f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d83ebf82_93d5a70d","updated":"2025-06-13 20:31:45.000000000","message":"Hey, Jesse. Thank you for working on this change. Please take a look at the comments inline","commit_id":"4bec2bbd097a0ecdd347e290544953492a0293d2"}],"manilaclient/osc/v2/quotas.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b7cc6f24cbda71ad7a9066b18a2712fa3bb748f","unresolved":true,"context_lines":[{"line_number":419,"context_line":"            return new_quotas"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":422,"context_line":"        if share_client.api_version \u003c api_versions.APIVersion(\"2.71\"):"},{"line_number":423,"context_line":"            raise exceptions.CommandError(_("},{"line_number":424,"context_line":"                \"Listing quotas for a project is available only starting with \""},{"line_number":425,"context_line":"                \"\u00272.71\u0027 API microversion.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"7495a97d_48b6ded8","line":422,"range":{"start_line":422,"start_character":65,"end_line":422,"end_character":67},"updated":"2025-06-13 20:31:45.000000000","message":"2.90","commit_id":"4bec2bbd097a0ecdd347e290544953492a0293d2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b7cc6f24cbda71ad7a9066b18a2712fa3bb748f","unresolved":true,"context_lines":[{"line_number":422,"context_line":"        if share_client.api_version \u003c api_versions.APIVersion(\"2.71\"):"},{"line_number":423,"context_line":"            raise exceptions.CommandError(_("},{"line_number":424,"context_line":"                \"Listing quotas for a project is available only starting with \""},{"line_number":425,"context_line":"                \"\u00272.71\u0027 API microversion.\"))"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":428,"context_line":"        project_id \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"4040b362_283e27eb","line":425,"range":{"start_line":425,"start_character":20,"end_line":425,"end_character":22},"updated":"2025-06-13 20:31:45.000000000","message":"2.90","commit_id":"4bec2bbd097a0ecdd347e290544953492a0293d2"}],"manilaclient/tests/functional/test_quotas.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b7cc6f24cbda71ad7a9066b18a2712fa3bb748f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3069b817_5424b3ea","line":349,"range":{"start_line":332,"start_character":4,"end_line":349,"end_character":0},"updated":"2025-06-13 20:31:45.000000000","message":"please remove this","commit_id":"4bec2bbd097a0ecdd347e290544953492a0293d2"}],"manilaclient/tests/unit/v2/test_shell.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b7cc6f24cbda71ad7a9066b18a2712fa3bb748f","unresolved":true,"context_lines":[{"line_number":2754,"context_line":"        )"},{"line_number":2755,"context_line":"        cliutils.print_dict.assert_called_once_with(mock.ANY)"},{"line_number":2756,"context_line":""},{"line_number":2757,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":2758,"context_line":"    def test_quota_list_by_project(self):"},{"line_number":2759,"context_line":"        self.run_command(\u0027quota-list-by-project --project-id 1234\u0027)"},{"line_number":2760,"context_line":"        self.assert_called("},{"line_number":2761,"context_line":"            \u0027GET\u0027,"},{"line_number":2762,"context_line":"            \u0027/quota-sets/1234/list_project_quotas\u0027,"},{"line_number":2763,"context_line":"        )"},{"line_number":2764,"context_line":"        cliutils.print_dict.assert_called_once_with(mock.ANY)"},{"line_number":2765,"context_line":""},{"line_number":2766,"context_line":"    @mock.patch.object(cliutils, \u0027print_dict\u0027, mock.Mock())"},{"line_number":2767,"context_line":"    def test_quota_show_with_user_id(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"045c2316_e517c12a","line":2764,"range":{"start_line":2757,"start_character":0,"end_line":2764,"end_character":61},"updated":"2025-06-13 20:31:45.000000000","message":"please remove this","commit_id":"4bec2bbd097a0ecdd347e290544953492a0293d2"}],"manilaclient/v2/quotas.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"07757ab2cebd9e282c99c894e4899d72e5cc9181","unresolved":true,"context_lines":[{"line_number":267,"context_line":"        return self._do_delete("},{"line_number":268,"context_line":"            tenant_id, user_id, share_type, resource_path\u003dRESOURCE_PATH)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    @api_versions.wraps(\"2.71\")  # noqa"},{"line_number":271,"context_line":"    def list_project_quotas(self, project_id):"},{"line_number":272,"context_line":"        data \u003d {"},{"line_number":273,"context_line":"            \"resource_path\": RESOURCE_PATH,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ed297b39_2a5a163e","line":270,"range":{"start_line":270,"start_character":25,"end_line":270,"end_character":29},"updated":"2025-06-13 21:07:10.000000000","message":"2.90","commit_id":"4bec2bbd097a0ecdd347e290544953492a0293d2"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2b7cc6f24cbda71ad7a9066b18a2712fa3bb748f","unresolved":true,"context_lines":[{"line_number":357,"context_line":"            quota_v \u003d \u0027\\n\u0027.join("},{"line_number":358,"context_line":"                [\u0027%s \u003d %s\u0027 % (k, v) for k, v in sorted(quota_v.items())])"},{"line_number":359,"context_line":"        new_quotas[quota_k] \u003d quota_v"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    cliutils.print_dict(new_quotas)"},{"line_number":362,"context_line":""},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"05e154b7_2372af34","side":"PARENT","line":360,"updated":"2025-06-13 20:31:45.000000000","message":"please add the blank line that was removed here","commit_id":"ce60e4845a1e20316e1cb627bdc4f7cb061dee7e"}]}
