)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3dc2d54c1bf3e76956c19152fff3668ff556393","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"219d7e5e_0f343033","updated":"2022-07-06 20:14:52.000000000","message":"Maari, thank you for working on this change. Sorry for taking too long to get to it.\nI had a chance to test it and it is looking good. I\u0027m getting deeper on code reviews now.\nHere are my findings on testing:\nshare security service create\n   - ok\nshare security service delete\n   - ok\nshare security service list \n   - ok\nshare security service show - \n   - when showing with id, it does not display share network, when showing with name it displays - this is a bug related to the API. I am currently investigating and I will open a bug for this.\n   - share networks could be displayed as when we have a dict for example, one below the other. It is currently being displayed as a list. If the list of share networks gets too big, it may become illegible. Wdyt about having a different formatting for it?\nshare security service set\n   - ok\nshare security service unset\n   - ok","commit_id":"a4437a9daef65d33f421792805709813c945ade8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ae11b8b427c364f52a6236f6f3a887be03a6c771","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"98f945eb_e0068f09","updated":"2022-07-13 16:06:15.000000000","message":"Thanks Carlos! I\u0027ve added better formatting for share networks in the show command and added test cases. Please have another look whenever convenient :) ","commit_id":"b8b9feba19fbcf1455c3c6c05ac7111055c88fc7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9fe0515a6f68a491347fecd806fa841765ff51b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"7d66260f_155c9e7f","updated":"2022-07-14 13:52:20.000000000","message":"LGTM, thank you for the patience, Maari!","commit_id":"c2a323402086a652b9035907ed2e9156d3a1f517"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6a74db6a6658505bc00c3a5f0183433a358002ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"27835c5a_3cbabda0","updated":"2022-07-14 13:52:07.000000000","message":"recheck\nDidn\u0027t run in the CI","commit_id":"c2a323402086a652b9035907ed2e9156d3a1f517"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"1d9ebac2eb2f5931a975c2b629c66149d30f7a8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"38076536_b36ecab8","updated":"2022-07-28 14:30:50.000000000","message":"LGTM, thanks Maari!","commit_id":"8873dc20e909d9367498d9cbe0024b334ef00b9d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd0e524e53bbe87ab5c4c58114b00d12874d319b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"b9e887d9_dfadbf7f","updated":"2022-07-28 19:08:21.000000000","message":"Thanks Maari. A small issue with spacing in user help text inline; worth following it up in a different patch","commit_id":"8873dc20e909d9367498d9cbe0024b334ef00b9d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"298629a75b4f161a8caccf91707479c67da50927","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0e3eb389_aaa14a2d","in_reply_to":"b9e887d9_dfadbf7f","updated":"2022-08-01 15:16:15.000000000","message":"Thanks Goutham, please check https://review.opendev.org/c/openstack/python-manilaclient/+/851740","commit_id":"8873dc20e909d9367498d9cbe0024b334ef00b9d"}],"manilaclient/osc/v2/security_services.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3dc2d54c1bf3e76956c19152fff3668ff556393","unresolved":true,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            security_service.update(**kwargs)"},{"line_number":267,"context_line":"        except Exception as e:"},{"line_number":268,"context_line":"            raise exceptions.CommandError("},{"line_number":269,"context_line":"                f\"One or more set operations failed: {e}\")"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"class UnsetShareSecurityService(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3c86ea5a_5c3e2dd5","line":269,"range":{"start_line":268,"start_character":12,"end_line":269,"end_character":58},"updated":"2022-07-06 20:14:52.000000000","message":"Missing coverage for this bit. Could you please add a negative functional test for this :)","commit_id":"a4437a9daef65d33f421792805709813c945ade8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ae11b8b427c364f52a6236f6f3a887be03a6c771","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        try:"},{"line_number":266,"context_line":"            security_service.update(**kwargs)"},{"line_number":267,"context_line":"        except Exception as e:"},{"line_number":268,"context_line":"            raise exceptions.CommandError("},{"line_number":269,"context_line":"                f\"One or more set operations failed: {e}\")"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"class UnsetShareSecurityService(command.Command):"}],"source_content_type":"text/x-python","patch_set":15,"id":"c400fcef_8eef9f3a","line":269,"range":{"start_line":268,"start_character":12,"end_line":269,"end_character":58},"in_reply_to":"3c86ea5a_5c3e2dd5","updated":"2022-07-13 16:06:15.000000000","message":"Done","commit_id":"a4437a9daef65d33f421792805709813c945ade8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d3dc2d54c1bf3e76956c19152fff3668ff556393","unresolved":true,"context_lines":[{"line_number":349,"context_line":"                \"available only for microversion \u003e\u003d 2.44\"))"},{"line_number":350,"context_line":"        try:"},{"line_number":351,"context_line":"            security_service.update(**kwargs)"},{"line_number":352,"context_line":"        except Exception as e:"},{"line_number":353,"context_line":"            raise exceptions.CommandError("},{"line_number":354,"context_line":"                f\"One or more unset operations failed: {e}\")"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"class ListShareSecurityService(command.Lister):"}],"source_content_type":"text/x-python","patch_set":15,"id":"7fbaef00_212622bb","line":354,"range":{"start_line":352,"start_character":8,"end_line":354,"end_character":60},"updated":"2022-07-06 20:14:52.000000000","message":"same as above :)","commit_id":"a4437a9daef65d33f421792805709813c945ade8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ae11b8b427c364f52a6236f6f3a887be03a6c771","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                \"available only for microversion \u003e\u003d 2.44\"))"},{"line_number":350,"context_line":"        try:"},{"line_number":351,"context_line":"            security_service.update(**kwargs)"},{"line_number":352,"context_line":"        except Exception as e:"},{"line_number":353,"context_line":"            raise exceptions.CommandError("},{"line_number":354,"context_line":"                f\"One or more unset operations failed: {e}\")"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"class ListShareSecurityService(command.Lister):"}],"source_content_type":"text/x-python","patch_set":15,"id":"8cb7d344_d72f6881","line":354,"range":{"start_line":352,"start_character":8,"end_line":354,"end_character":60},"in_reply_to":"7fbaef00_212622bb","updated":"2022-07-13 16:06:15.000000000","message":"Done","commit_id":"a4437a9daef65d33f421792805709813c945ade8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7eccb30962fdff85f493a90d3ee5ca8001ed90a5","unresolved":true,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        data \u003d security_service._info"},{"line_number":177,"context_line":"        if parsed_args.formatter \u003d\u003d \u0027table\u0027:"},{"line_number":178,"context_line":"            share_networks \u003d data.get(\u0027share_networks\u0027, [])"},{"line_number":179,"context_line":"            data[\u0027share_networks\u0027] \u003d \"\\n\".join(share_networks)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return self.dict2columns(data)"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"b7465e7e_d7107573","line":179,"range":{"start_line":178,"start_character":12,"end_line":179,"end_character":62},"updated":"2022-07-13 20:53:49.000000000","message":"maybe we should add a condition to this... Only add the share networks to the data variable in case the API responded with them. I think the bug that was filed [1] may add a new microversion, and there will be some cases where the share networks are non-existent. In newer microversions we will have and we will make sure that people expect to see share networks, but in older microversions there is a chance that people might not expect these, because of the bug.\n\nI am not against your idea as well, but I was thinking of this other side of this. What do you think? \n\n[1] https://bugs.launchpad.net/manila/+bug/1981626","commit_id":"b8b9feba19fbcf1455c3c6c05ac7111055c88fc7"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"5a3412044e5280570e29bb53d169aa59a73bc04d","unresolved":false,"context_lines":[{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        data \u003d security_service._info"},{"line_number":177,"context_line":"        if parsed_args.formatter \u003d\u003d \u0027table\u0027:"},{"line_number":178,"context_line":"            share_networks \u003d data.get(\u0027share_networks\u0027, [])"},{"line_number":179,"context_line":"            data[\u0027share_networks\u0027] \u003d \"\\n\".join(share_networks)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        return self.dict2columns(data)"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"f0474a39_2ae92d4f","line":179,"range":{"start_line":178,"start_character":12,"end_line":179,"end_character":62},"in_reply_to":"b7465e7e_d7107573","updated":"2022-07-14 06:35:55.000000000","message":"Makes sense, I updated the patch, thanks!","commit_id":"b8b9feba19fbcf1455c3c6c05ac7111055c88fc7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd0e524e53bbe87ab5c4c58114b00d12874d319b","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            metavar\u003d\u0027\u003ctype\u003e\u0027,"},{"line_number":35,"context_line":"            default\u003dNone,"},{"line_number":36,"context_line":"            choices\u003d[\u0027ldap\u0027, \u0027kerberos\u0027, \u0027active_directory\u0027],"},{"line_number":37,"context_line":"            help\u003d_(\"Security service type. Possible options are:\""},{"line_number":38,"context_line":"                   \"\u0027ldap\u0027, \u0027kerberos\u0027, \u0027active_directory\u0027.\")"},{"line_number":39,"context_line":"        )"},{"line_number":40,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"cdc6d02c_9b245914","line":37,"range":{"start_line":37,"start_character":64,"end_line":37,"end_character":65},"updated":"2022-07-28 19:08:21.000000000","message":"missing trailing space","commit_id":"c2a323402086a652b9035907ed2e9156d3a1f517"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd0e524e53bbe87ab5c4c58114b00d12874d319b","unresolved":true,"context_lines":[{"line_number":41,"context_line":"            \u0027--dns-ip\u0027,"},{"line_number":42,"context_line":"            metavar\u003d\u0027\u003cdns-ip\u003e\u0027,"},{"line_number":43,"context_line":"            default\u003dNone,"},{"line_number":44,"context_line":"            help\u003d_(\"DNS IP address used inside project\u0027s network.\")"},{"line_number":45,"context_line":"        )"},{"line_number":46,"context_line":"        parser.add_argument("},{"line_number":47,"context_line":"            \u0027--ou\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"842abaab_39646c2a","line":44,"range":{"start_line":44,"start_character":34,"end_line":44,"end_character":35},"updated":"2022-07-28 19:08:21.000000000","message":"of the security service","commit_id":"c2a323402086a652b9035907ed2e9156d3a1f517"}]}