)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"6a705c02e6aa01ed4dcd20e34752308a872603c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8f1cb1b9_4f4e5db3","updated":"2021-11-10 15:34:57.000000000","message":"Thanks for working on this Besjana! Looks like in addition to adding your own tests, you also need to unbreak the current tests. Since this change is adding the \u0027~name\u0027 and \u0027~description\u0027 to the search_opts, you\u0027ll need to add it to the search_opts in the tests as well, I see a helper method you could use: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/tests/unit/osc/v2/test_share.py#L521\nHowever, looks like the tests are not really using that, but defining it again in each test.\nFeel free to take the opportunity to refactor the search_opts for all tests in the TestShareList class. Otherwise, you\u0027ll need to add the new arguments to each test. Let me know if you have any questions! :) ","commit_id":"29de17983961c08dc1931b4b5cb91014e4245751"},{"author":{"_account_id":34133,"name":"Besjana Gjika","display_name":"B Gj","email":"besa8383@gmail.com","username":"mbeas"},"change_message_id":"155e2cb45f613ad8b19f5ab62bb00d396a58b8ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"37eb0fa1_da568aca","in_reply_to":"8f1cb1b9_4f4e5db3","updated":"2021-11-11 17:35:05.000000000","message":"Hi Maari. Thank you for your review. I updated the search_opts for all test methods inside the TestShareList class with the new additions as you mentioned.","commit_id":"29de17983961c08dc1931b4b5cb91014e4245751"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"3763f440c0c441c5cba4b609049e3ad07362b541","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b6150c01_f4cf6057","updated":"2021-11-19 14:46:47.000000000","message":"LGTM, thanks Besjana!","commit_id":"b5a4f9c396fd72ece58d09974718900c3b93edd5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"cae3d09ad7f86273ad273ae523be5d9bdfc4bd9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b64b5d5e_93c556ac","updated":"2021-11-19 14:47:11.000000000","message":"Nice job on the refactor as well btw :)","commit_id":"b5a4f9c396fd72ece58d09974718900c3b93edd5"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a45bd95454dedbfeda9b7d63186e42c1715157b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03c890a5_924b2f53","updated":"2021-11-18 07:32:57.000000000","message":"Thanks for working on this Besjana, looks good to me! :) ","commit_id":"b5a4f9c396fd72ece58d09974718900c3b93edd5"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"68b141c574b346074ca548849c0f9f3e6dd7453f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1c45efaa_69484367","updated":"2021-11-25 09:35:26.000000000","message":"recheck","commit_id":"b5a4f9c396fd72ece58d09974718900c3b93edd5"}]}