)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b79bb34a_fe59d8f1","updated":"2021-11-15 02:13:08.000000000","message":"hi, Kiran Pawar.\nthanks for this change.","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e35fccde6c9b3e825f1345d25bee763fb8a6294","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8cb1dcfc_cfe1030c","updated":"2021-11-16 01:05:22.000000000","message":"thanks for this change.\nLGTM, one more comment inline.","commit_id":"5191472fe519871ffd1facd01997e432c3752901"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"63731d10f68757c60337dfd8fa6a27bc47bb4656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"222c68b9_b821179d","updated":"2021-11-25 01:49:51.000000000","message":"And by the way, after merged this, we need to update doc about this,\n1: manila/doc/source/cli/manila.rst#691\n","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdb6327b2e6a121aed5318dc1d35f5289e5684fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b1a3a7d_9792d549","updated":"2021-11-25 01:36:07.000000000","message":"LGTM,thanks.","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9018cc165953639cb2534c0923bb6c906970eb33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b8b573d6_8063062e","updated":"2021-11-25 18:27:20.000000000","message":"Thanks Kiran! It is looking good, just a few enhancements to add :)","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"0a7abd20a45dd3bfafef05e3dce0e3c6e294587f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ccf42684_c6daa5b6","updated":"2021-11-22 01:09:40.000000000","message":"recheck","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a611dedadd25501df2aca14b2840d39d33347f73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"edfac1b6_df80384b","updated":"2021-11-20 09:16:41.000000000","message":"recheck","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2d00820ba4ed1a61fa467f8caf7556c211e735aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1bb81379_5987ee94","updated":"2021-11-24 14:49:03.000000000","message":"recheck\nIssue with the default share type creation was fixed","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2a7cae61c6e9a234b69cdf1deab9c266c7770a20","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"148365b4_2f44f76e","updated":"2021-12-27 08:17:15.000000000","message":"LGTM","commit_id":"dc9a0da0c7da6550209f66b6cb5df315652b0781"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"38b375f539ce04a014b42094c8103f99fe4f62e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"1f1ef791_6bc2bf9a","updated":"2021-12-24 18:35:24.000000000","message":"recheck","commit_id":"dc9a0da0c7da6550209f66b6cb5df315652b0781"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7b6607d4_09f96690","updated":"2022-01-26 19:55:43.000000000","message":"Thanks for working on this Kiran. PTAL at the comments inline","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b17e4d1771fb5f753922a23fbf1b292d041d6769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"55967a1d_7f043ea1","updated":"2022-02-04 17:32:03.000000000","message":"Thanks Kiran, just small issue about the OSC param name.","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"bc7eb68c048cb49974792600ab23d08fafa1792c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e1af5919_16e7c652","in_reply_to":"07d1f2aa_e87131ca","updated":"2022-02-07 12:54:05.000000000","message":"Done","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b93386b545c846b8153419311bd244eae51388ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"8c56b7be_5101d81d","in_reply_to":"55967a1d_7f043ea1","updated":"2022-02-05 04:05:28.000000000","message":"The OSC param allow to repeat parameter if need to specify more than once. So I kept scheduler-hint. This is in line with scheduler-hint of OSC share create and property/metadata of OSC share create.\nBased on above explanation, if you still think, it should be modified to scheduler-hints, let me know. I will update.","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a11e3a3c875ad5a21f2ba8d7ab508902b610188b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"07d1f2aa_e87131ca","in_reply_to":"8c56b7be_5101d81d","updated":"2022-02-05 14:55:46.000000000","message":"No problem, you could keep it as \"scheduler-hint\" in the OSC, just fixing the commit message/release notes, since they just inform that a new \"scheduler-hints\" option was added. Either fix them or make as \"scheduler-hints\".","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"2cdd1b50b44ba38d5baf0dde9fb97070dd00273d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"c688628d_637594cb","updated":"2022-02-10 13:53:42.000000000","message":"LGTM","commit_id":"8c065cab89781f5d04f446ee26502c7fb8ddc5b9"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"ebc466823f0e6cc3c9ec35574dcb721b0a1118f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3d767817_3085fe1c","updated":"2022-02-11 03:02:15.000000000","message":"LGTM, thanks.","commit_id":"8c065cab89781f5d04f446ee26502c7fb8ddc5b9"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e7cfc9ea5e8f69def2b2f873f7aa9b5addea05f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"878a4407_4a4fa21e","updated":"2022-02-15 01:17:29.000000000","message":"Thanks, minor issues with the messages to fix if you make another patch... ","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e47d2afa593d5e277adbd1990613dc832013e031","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"59292187_62a9538b","updated":"2022-02-15 03:54:27.000000000","message":"LGTM, thanks for the changes","commit_id":"39ebe3307aff2ea030490b7d9cd1fb815be78dc4"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"2d399dfa634ec81ec1e4c8965e2cf6275c80ff32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b1d7b058_d6fed3e0","updated":"2022-02-24 09:35:04.000000000","message":"Looks good, thanks Kiran!","commit_id":"39ebe3307aff2ea030490b7d9cd1fb815be78dc4"}],"manilaclient/osc/v2/share_replicas.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e35fccde6c9b3e825f1345d25bee763fb8a6294","unresolved":true,"context_lines":[{"line_number":70,"context_line":"                    \"\u00272.65\u0027 API microversion.\"))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"},{"line_number":73,"context_line":"            if \u0027only_host\u0027 not in hints.keys():"},{"line_number":74,"context_line":"                raise exceptions.CommandError("},{"line_number":75,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":76,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"4d1ff434_d3ddd5f4","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":47},"updated":"2021-11-16 01:05:22.000000000","message":"if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:","commit_id":"5191472fe519871ffd1facd01997e432c3752901"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e8e02c7ed91f9bc67c9a773fb1c94f7dc911843b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                    \"\u00272.65\u0027 API microversion.\"))"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"},{"line_number":73,"context_line":"            if \u0027only_host\u0027 not in hints.keys():"},{"line_number":74,"context_line":"                raise exceptions.CommandError("},{"line_number":75,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":76,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ab6f873_c186fa02","line":73,"range":{"start_line":73,"start_character":12,"end_line":73,"end_character":47},"in_reply_to":"4d1ff434_d3ddd5f4","updated":"2021-11-18 17:34:34.000000000","message":"Done","commit_id":"5191472fe519871ffd1facd01997e432c3752901"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9018cc165953639cb2534c0923bb6c906970eb33","unresolved":true,"context_lines":[{"line_number":75,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":76,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if share_client.api_version \u003c api_versions.APIVersion(\"2.65\"):"},{"line_number":79,"context_line":"            share_replica \u003d share_client.share_replicas.create("},{"line_number":80,"context_line":"                share,"},{"line_number":81,"context_line":"                availability_zone\u003dparsed_args.availability_zone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c59c894d_2c7dd110","line":78,"updated":"2021-11-25 18:27:20.000000000","message":"Instead of repeating the call to \u0027share replicas create\u0027 we could factor out the params being passed (say, let\u0027s create a dict with availability_zone and scheduler_hints) and just pass the unpacked structure (with the ** operator). Check how we do this in https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share.py#L248-L263","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a365110dc62a2ac311510ea1a13b9ec1193bafcc","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":76,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if share_client.api_version \u003c api_versions.APIVersion(\"2.65\"):"},{"line_number":79,"context_line":"            share_replica \u003d share_client.share_replicas.create("},{"line_number":80,"context_line":"                share,"},{"line_number":81,"context_line":"                availability_zone\u003dparsed_args.availability_zone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f6c0941_7a115f6e","line":78,"in_reply_to":"c59c894d_2c7dd110","updated":"2021-11-25 21:01:03.000000000","message":"Done","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":54,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":55,"context_line":"            help\u003d_(\"Scheduler hint for the share replica as key\u003dvalue pairs, \""},{"line_number":56,"context_line":"                   \"Supported key is only_host. Available for microversion \""},{"line_number":57,"context_line":"                   \"\u003e\u003d 2.67. (repeat option to set multiple hints) \"),"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        return parser"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"54a19469_c24da443","line":57,"range":{"start_line":57,"start_character":29,"end_line":57,"end_character":66},"updated":"2022-01-26 19:55:43.000000000","message":"this doesn\u0027t apply right now and may be possible in the future... but, lets drop this to avoid confusion since the code actively dissuades multiple hints per line 74 of this file.","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":55,"context_line":"            help\u003d_(\"Scheduler hint for the share replica as key\u003dvalue pairs, \""},{"line_number":56,"context_line":"                   \"Supported key is only_host. Available for microversion \""},{"line_number":57,"context_line":"                   \"\u003e\u003d 2.67. (repeat option to set multiple hints) \"),"},{"line_number":58,"context_line":"        )"},{"line_number":59,"context_line":"        return parser"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"2ca19fce_16a1a14c","line":57,"range":{"start_line":57,"start_character":29,"end_line":57,"end_character":66},"in_reply_to":"54a19469_c24da443","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":76,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":77,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        body \u003d {"},{"line_number":80,"context_line":"            \u0027share\u0027: share,"},{"line_number":81,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":82,"context_line":"            \u0027scheduler_hints\u0027: scheduler_hints"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        share_replica \u003d share_client.share_replicas.create(**body)"},{"line_number":86,"context_line":"        if parsed_args.wait:"}],"source_content_type":"text/x-python","patch_set":9,"id":"0fbf87f2_77dfed78","line":83,"range":{"start_line":79,"start_character":8,"end_line":83,"end_character":9},"updated":"2022-01-26 19:55:43.000000000","message":"to allow the code below to hit the right method based on the API version, you need to format this body conditionally:\n\n  body \u003d {\n            \u0027share\u0027: share,\n            \u0027availability_zone\u0027: parsed_args.availability_zone,\n        }\n\n  if scheduler_hints:\n       body[\u0027scheduler_hints\u0027] \u003d scheduler_hints\n\n\nSee related comment on the SDK module: https://review.opendev.org/c/openstack/python-manilaclient/+/817739/9/manilaclient/v2/share_replicas.py","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":77,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        body \u003d {"},{"line_number":80,"context_line":"            \u0027share\u0027: share,"},{"line_number":81,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":82,"context_line":"            \u0027scheduler_hints\u0027: scheduler_hints"},{"line_number":83,"context_line":"        }"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        share_replica \u003d share_client.share_replicas.create(**body)"},{"line_number":86,"context_line":"        if parsed_args.wait:"}],"source_content_type":"text/x-python","patch_set":9,"id":"2a78b6d9_f4f44fae","line":83,"range":{"start_line":79,"start_character":8,"end_line":83,"end_character":9},"in_reply_to":"0fbf87f2_77dfed78","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b17e4d1771fb5f753922a23fbf1b292d041d6769","unresolved":true,"context_lines":[{"line_number":48,"context_line":"            help\u003d_(\u0027Wait for replica creation\u0027)"},{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":"        parser.add_argument("},{"line_number":51,"context_line":"            \"--scheduler-hint\","},{"line_number":52,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":53,"context_line":"            default\u003d{},"},{"line_number":54,"context_line":"            action\u003dparseractions.KeyValueAction,"}],"source_content_type":"text/x-python","patch_set":10,"id":"07425fd5_55ec3b09","line":51,"range":{"start_line":51,"start_character":17,"end_line":51,"end_character":30},"updated":"2022-02-04 17:32:03.000000000","message":"would it be \"scheduler_hints\" as the commit message, release notes and so on ?","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b93386b545c846b8153419311bd244eae51388ef","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            help\u003d_(\u0027Wait for replica creation\u0027)"},{"line_number":49,"context_line":"        )"},{"line_number":50,"context_line":"        parser.add_argument("},{"line_number":51,"context_line":"            \"--scheduler-hint\","},{"line_number":52,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":53,"context_line":"            default\u003d{},"},{"line_number":54,"context_line":"            action\u003dparseractions.KeyValueAction,"}],"source_content_type":"text/x-python","patch_set":10,"id":"4b6d6ee9_a8fb3f82","line":51,"range":{"start_line":51,"start_character":17,"end_line":51,"end_character":30},"in_reply_to":"07425fd5_55ec3b09","updated":"2022-02-05 04:05:28.000000000","message":"Explicitly mentioned as manila shellclient.","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b17e4d1771fb5f753922a23fbf1b292d041d6769","unresolved":true,"context_lines":[{"line_number":52,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":53,"context_line":"            default\u003d{},"},{"line_number":54,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":55,"context_line":"            help\u003d_(\"Scheduler hint for the share replica as key\u003dvalue pairs, \""},{"line_number":56,"context_line":"                   \"Supported key is only_host. Available for microversion \""},{"line_number":57,"context_line":"                   \"\u003e\u003d 2.67.\"),"},{"line_number":58,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"df1f5016_5dc834d7","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":35},"updated":"2022-02-04 17:32:03.000000000","message":"hints ?","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b93386b545c846b8153419311bd244eae51388ef","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":53,"context_line":"            default\u003d{},"},{"line_number":54,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":55,"context_line":"            help\u003d_(\"Scheduler hint for the share replica as key\u003dvalue pairs, \""},{"line_number":56,"context_line":"                   \"Supported key is only_host. Available for microversion \""},{"line_number":57,"context_line":"                   \"\u003e\u003d 2.67.\"),"},{"line_number":58,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":10,"id":"45af5a12_0a7fa0a8","line":55,"range":{"start_line":55,"start_character":30,"end_line":55,"end_character":35},"in_reply_to":"df1f5016_5dc834d7","updated":"2022-02-05 04:05:28.000000000","message":"Ack","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b17e4d1771fb5f753922a23fbf1b292d041d6769","unresolved":true,"context_lines":[{"line_number":64,"context_line":"        share \u003d osc_utils.find_resource(share_client.shares,"},{"line_number":65,"context_line":"                                        parsed_args.share)"},{"line_number":66,"context_line":"        scheduler_hints \u003d {}"},{"line_number":67,"context_line":"        if parsed_args.scheduler_hint:"},{"line_number":68,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.67\"):"},{"line_number":69,"context_line":"                raise exceptions.CommandError(_("},{"line_number":70,"context_line":"                    \"args \u0027scheduler_hints\u0027 is available only starting with \""}],"source_content_type":"text/x-python","patch_set":10,"id":"25fb4766_96c5a580","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":37},"updated":"2022-02-04 17:32:03.000000000","message":"scheduler_hints ?","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b93386b545c846b8153419311bd244eae51388ef","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        share \u003d osc_utils.find_resource(share_client.shares,"},{"line_number":65,"context_line":"                                        parsed_args.share)"},{"line_number":66,"context_line":"        scheduler_hints \u003d {}"},{"line_number":67,"context_line":"        if parsed_args.scheduler_hint:"},{"line_number":68,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.67\"):"},{"line_number":69,"context_line":"                raise exceptions.CommandError(_("},{"line_number":70,"context_line":"                    \"args \u0027scheduler_hints\u0027 is available only starting with \""}],"source_content_type":"text/x-python","patch_set":10,"id":"6f7f8cfd_05eeaf17","line":67,"range":{"start_line":67,"start_character":23,"end_line":67,"end_character":37},"in_reply_to":"25fb4766_96c5a580","updated":"2022-02-05 04:05:28.000000000","message":"Ack","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e7cfc9ea5e8f69def2b2f873f7aa9b5addea05f","unresolved":true,"context_lines":[{"line_number":67,"context_line":"        if parsed_args.scheduler_hint:"},{"line_number":68,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.67\"):"},{"line_number":69,"context_line":"                raise exceptions.CommandError(_("},{"line_number":70,"context_line":"                    \"args \u0027scheduler_hints\u0027 is available only starting with \""},{"line_number":71,"context_line":"                    \"\u00272.67\u0027 API microversion.\"))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"}],"source_content_type":"text/x-python","patch_set":13,"id":"d83aecee_90e821b9","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":43},"updated":"2022-02-15 01:17:29.000000000","message":"arg \u0027--scheduler_hint\u0027","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9c856a5c380a071e6a2b9cbdfb8865d5eed70ced","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        if parsed_args.scheduler_hint:"},{"line_number":68,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.67\"):"},{"line_number":69,"context_line":"                raise exceptions.CommandError(_("},{"line_number":70,"context_line":"                    \"args \u0027scheduler_hints\u0027 is available only starting with \""},{"line_number":71,"context_line":"                    \"\u00272.67\u0027 API microversion.\"))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"}],"source_content_type":"text/x-python","patch_set":13,"id":"cf5f06a1_63ef6cc4","line":70,"range":{"start_line":70,"start_character":21,"end_line":70,"end_character":43},"in_reply_to":"d83aecee_90e821b9","updated":"2022-02-15 03:23:47.000000000","message":"Done","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e7cfc9ea5e8f69def2b2f873f7aa9b5addea05f","unresolved":true,"context_lines":[{"line_number":68,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.67\"):"},{"line_number":69,"context_line":"                raise exceptions.CommandError(_("},{"line_number":70,"context_line":"                    \"args \u0027scheduler_hints\u0027 is available only starting with \""},{"line_number":71,"context_line":"                    \"\u00272.67\u0027 API microversion.\"))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"},{"line_number":74,"context_line":"            if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":13,"id":"a3759d9e_38b276b3","line":71,"range":{"start_line":71,"start_character":21,"end_line":71,"end_character":45},"updated":"2022-02-15 01:17:29.000000000","message":"API microversion \u00272.67\u0027","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9c856a5c380a071e6a2b9cbdfb8865d5eed70ced","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.67\"):"},{"line_number":69,"context_line":"                raise exceptions.CommandError(_("},{"line_number":70,"context_line":"                    \"args \u0027scheduler_hints\u0027 is available only starting with \""},{"line_number":71,"context_line":"                    \"\u00272.67\u0027 API microversion.\"))"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"},{"line_number":74,"context_line":"            if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:"}],"source_content_type":"text/x-python","patch_set":13,"id":"c52329d0_179e21e3","line":71,"range":{"start_line":71,"start_character":21,"end_line":71,"end_character":45},"in_reply_to":"a3759d9e_38b276b3","updated":"2022-02-15 03:23:47.000000000","message":"Done","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e7cfc9ea5e8f69def2b2f873f7aa9b5addea05f","unresolved":true,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"},{"line_number":74,"context_line":"            if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:"},{"line_number":75,"context_line":"                raise exceptions.CommandError("},{"line_number":76,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":77,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"eba8e065_95623bb5","line":76,"range":{"start_line":75,"start_character":15,"end_line":76,"end_character":74},"updated":"2022-02-15 01:17:29.000000000","message":"The only valid key supported with the --scheduler-hint argument is \"only_host\"","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9c856a5c380a071e6a2b9cbdfb8865d5eed70ced","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            hints \u003d utils.extract_key_value_options(parsed_args.scheduler_hint)"},{"line_number":74,"context_line":"            if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:"},{"line_number":75,"context_line":"                raise exceptions.CommandError("},{"line_number":76,"context_line":"                    \"args \u0027scheduler_hint\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":77,"context_line":"            scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"778cb3ad_a1b6a2e6","line":76,"range":{"start_line":75,"start_character":15,"end_line":76,"end_character":74},"in_reply_to":"eba8e065_95623bb5","updated":"2022-02-15 03:23:47.000000000","message":"Done","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"}],"manilaclient/tests/unit/osc/v2/test_share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        self.replica_el_mock.reset_mock()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class TestShareReplicaCreate(TestShareReplica):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestShareReplicaCreate, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1c6a89b5_596610c1","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":47},"updated":"2022-01-26 19:55:43.000000000","message":"There are two negative testing possibilities here:\n\n1) you supply a hint with an API version where scheduler_hints aren\u0027t supported\n2) you supply unsupported hints \n\nThere\u0027s also the happy path that you\u0027re not testing: supplying a legal \"only_host\" hint","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        self.replica_el_mock.reset_mock()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"class TestShareReplicaCreate(TestShareReplica):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def setUp(self):"},{"line_number":51,"context_line":"        super(TestShareReplicaCreate, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"94e6fbb9_73bab4ae","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":47},"in_reply_to":"1c6a89b5_596610c1","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"}],"manilaclient/v2/share_replicas.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        return self._action(\u0027promote\u0027, replica)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):"},{"line_number":116,"context_line":"        return self._create_share_replica("}],"source_content_type":"text/x-python","patch_set":2,"id":"788dff61_838838ae","line":113,"range":{"start_line":113,"start_character":3,"end_line":113,"end_character":73},"updated":"2021-11-15 02:13:08.000000000","message":"we need noe more function:\n\n@api_versions.wraps(2.65)  # noqa\ndef create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone): # noqa F811\n    return self._create_share_replica(\n        share, availability_zone\u003davailability_zone,\n        scheduler_hints\u003dscheduler_hints)","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        return self._action(\u0027promote\u0027, replica)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):"},{"line_number":116,"context_line":"        return self._create_share_replica("}],"source_content_type":"text/x-python","patch_set":2,"id":"5d742aab_c503ec95","line":113,"range":{"start_line":113,"start_character":3,"end_line":113,"end_character":73},"in_reply_to":"788dff61_838838ae","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):"},{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone,"},{"line_number":118,"context_line":"            scheduler_hints\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3523151f_cf7d9a9b","line":115,"range":{"start_line":115,"start_character":51,"end_line":115,"end_character":72},"updated":"2021-11-15 02:13:08.000000000","message":"no need to add scheduler_hints","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):"},{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone,"},{"line_number":118,"context_line":"            scheduler_hints\u003dNone)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2f937efa_2ad120ec","line":115,"range":{"start_line":115,"start_character":51,"end_line":115,"end_character":72},"in_reply_to":"3523151f_cf7d9a9b","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":118,"context_line":"            scheduler_hints\u003dNone)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION)  # noqa"},{"line_number":121,"context_line":"    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):  # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":122,"context_line":"        return self._create_share_replica("},{"line_number":123,"context_line":"            share, availability_zone\u003davailability_zone,"},{"line_number":124,"context_line":"            scheduler_hints\u003dscheduler_hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1298f9c9_ee279b5f","line":121,"range":{"start_line":121,"start_character":52,"end_line":121,"end_character":72},"updated":"2021-11-15 02:13:08.000000000","message":"no need to add scheduler_hints","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            scheduler_hints\u003dNone)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION)  # noqa"},{"line_number":121,"context_line":"    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):  # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":122,"context_line":"        return self._create_share_replica("},{"line_number":123,"context_line":"            share, availability_zone\u003davailability_zone,"},{"line_number":124,"context_line":"            scheduler_hints\u003dscheduler_hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bca2d5ce_4e0204a7","line":121,"range":{"start_line":121,"start_character":52,"end_line":121,"end_character":72},"in_reply_to":"1298f9c9_ee279b5f","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9018cc165953639cb2534c0923bb6c906970eb33","unresolved":true,"context_lines":[{"line_number":142,"context_line":"        if availability_zone:"},{"line_number":143,"context_line":"            body[\u0027availability_zone\u0027] \u003d common_base.getid(availability_zone)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        body[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":146,"context_line":"        return self._create(RESOURCES_PATH,"},{"line_number":147,"context_line":"                            {RESOURCE_NAME: body},"},{"line_number":148,"context_line":"                            RESOURCE_NAME)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e64b10cb_cea4579f","line":145,"updated":"2021-11-25 18:27:20.000000000","message":"if scheduler_hints:\n    body[\u0027scheduler_hints\u0027] \u003d scheduler_hints","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a365110dc62a2ac311510ea1a13b9ec1193bafcc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        if availability_zone:"},{"line_number":143,"context_line":"            body[\u0027availability_zone\u0027] \u003d common_base.getid(availability_zone)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"        body[\u0027scheduler_hints\u0027] \u003d scheduler_hints"},{"line_number":146,"context_line":"        return self._create(RESOURCES_PATH,"},{"line_number":147,"context_line":"                            {RESOURCE_NAME: body},"},{"line_number":148,"context_line":"                            RESOURCE_NAME)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0db436eb_59feb189","line":145,"in_reply_to":"e64b10cb_cea4579f","updated":"2021-11-25 21:01:03.000000000","message":"Done","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        return self._action(\u0027promote\u0027, replica)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def create(self, share, availability_zone\u003dNone):"},{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION)  # noqa"},{"line_number":120,"context_line":"    def create(self, share, availability_zone\u003dNone):  # noqa F811"},{"line_number":121,"context_line":"        return self._create_share_replica("},{"line_number":122,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def _create_share_replica(self, share, availability_zone\u003dNone):"},{"line_number":125,"context_line":"        \"\"\"Create a replica for a share."}],"source_content_type":"text/x-python","patch_set":9,"id":"90103d42_4bd58316","side":"PARENT","line":122,"range":{"start_line":113,"start_character":0,"end_line":122,"end_character":55},"updated":"2022-01-26 19:55:43.000000000","message":"Were these dropped by mistake? They shouldn\u0027t be modified, you\u0027ll need to add the new parameter in a separate method:\n\n    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)\n    @api_versions.experimental_api\n    def create(self, share, availability_zone\u003dNone):\n        return self._create_share_replica(\n            share, availability_zone\u003davailability_zone)\n\n    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION, \u00272.66\u0027)  # noqa\n    def create(self, share, availability_zone\u003dNone):  # noqa F811\n        return self._create_share_replica(\n            share, availability_zone\u003davailability_zone)\n\n    @api_versions.wraps(\"2.67\")  # noqa\n    def create(self, share, availability_zone\u003dNone, scheduler_hints\u003dNone):\n        return self._create_share_replica(\n            share, availability_zone\u003davailability_zone, scheduler_hints\u003dscheduler_hints)\n\n    def _create_share_replica(self, share, availability_zone\u003dNone):\n        ....","commit_id":"f9aee522ef2452f0e9d17e620b701bfc7aee6dae"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        \"\"\""},{"line_number":111,"context_line":"        return self._action(\u0027promote\u0027, replica)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @api_versions.wraps(\"2.11\", constants.REPLICA_PRE_GRADUATION_VERSION)"},{"line_number":114,"context_line":"    @api_versions.experimental_api"},{"line_number":115,"context_line":"    def create(self, share, availability_zone\u003dNone):"},{"line_number":116,"context_line":"        return self._create_share_replica("},{"line_number":117,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    @api_versions.wraps(constants.REPLICA_GRADUATION_VERSION)  # noqa"},{"line_number":120,"context_line":"    def create(self, share, availability_zone\u003dNone):  # noqa F811"},{"line_number":121,"context_line":"        return self._create_share_replica("},{"line_number":122,"context_line":"            share, availability_zone\u003davailability_zone)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def _create_share_replica(self, share, availability_zone\u003dNone):"},{"line_number":125,"context_line":"        \"\"\"Create a replica for a share."}],"source_content_type":"text/x-python","patch_set":9,"id":"1c82940d_254a5148","side":"PARENT","line":122,"range":{"start_line":113,"start_character":0,"end_line":122,"end_character":55},"in_reply_to":"90103d42_4bd58316","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"f9aee522ef2452f0e9d17e620b701bfc7aee6dae"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"b17e4d1771fb5f753922a23fbf1b292d041d6769","unresolved":true,"context_lines":[{"line_number":128,"context_line":"            scheduler_hints\u003dscheduler_hints)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _create_share_replica(self, share, availability_zone\u003dNone,"},{"line_number":131,"context_line":"                              scheduler_hints\u003dNone):"},{"line_number":132,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        :param share: The share to create the replica of. Can be the share"}],"source_content_type":"text/x-python","patch_set":10,"id":"934af479_00d9a5a9","line":131,"range":{"start_line":131,"start_character":30,"end_line":131,"end_character":45},"updated":"2022-02-04 17:32:03.000000000","message":"add :param doc","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b93386b545c846b8153419311bd244eae51388ef","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            scheduler_hints\u003dscheduler_hints)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _create_share_replica(self, share, availability_zone\u003dNone,"},{"line_number":131,"context_line":"                              scheduler_hints\u003dNone):"},{"line_number":132,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        :param share: The share to create the replica of. Can be the share"}],"source_content_type":"text/x-python","patch_set":10,"id":"77f85fd0_9b2f4ce0","line":131,"range":{"start_line":131,"start_character":30,"end_line":131,"end_character":45},"in_reply_to":"934af479_00d9a5a9","updated":"2022-02-05 04:05:28.000000000","message":"Done","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b93386b545c846b8153419311bd244eae51388ef","unresolved":false,"context_lines":[{"line_number":128,"context_line":"            scheduler_hints\u003dscheduler_hints)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def _create_share_replica(self, share, availability_zone\u003dNone,"},{"line_number":131,"context_line":"                              scheduler_hints\u003dNone):"},{"line_number":132,"context_line":"        \"\"\"Create a replica for a share."},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        :param share: The share to create the replica of. Can be the share"}],"source_content_type":"text/x-python","patch_set":10,"id":"bc4e1e5b_d499cff0","line":131,"range":{"start_line":131,"start_character":30,"end_line":131,"end_character":45},"in_reply_to":"934af479_00d9a5a9","updated":"2022-02-05 04:05:28.000000000","message":"Done","commit_id":"90103e50864121d5dcb93cde3607394aa814b9a5"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":6000,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":6001,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":6002,"context_line":"    help\u003d\u0027Scheduler hints for the share replica as key\u003dvalue pairs, \u0027"},{"line_number":6003,"context_line":"         \u0027Supported key is only_host.\u0027,"},{"line_number":6004,"context_line":"    default\u003dNone)"},{"line_number":6005,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":6006,"context_line":"def do_share_replica_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"a64da560_5405a017","line":6003,"range":{"start_line":6003,"start_character":10,"end_line":6003,"end_character":36},"updated":"2021-11-15 02:13:08.000000000","message":"if we only support only_host, not support same_host or different_host, and other keys.\nwe should check it.","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":6000,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":6001,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":6002,"context_line":"    help\u003d\u0027Scheduler hints for the share replica as key\u003dvalue pairs, \u0027"},{"line_number":6003,"context_line":"         \u0027Supported key is only_host.\u0027,"},{"line_number":6004,"context_line":"    default\u003dNone)"},{"line_number":6005,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":6006,"context_line":"def do_share_replica_create(cs, args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"31509a3a_296834d1","line":6003,"range":{"start_line":6003,"start_character":10,"end_line":6003,"end_character":36},"in_reply_to":"a64da560_5405a017","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":6008,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":"    scheduler_hints \u003d {}"},{"line_number":6011,"context_line":"    if args.scheduler_hints:"},{"line_number":6012,"context_line":"        scheduler_hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6013,"context_line":""},{"line_number":6014,"context_line":"    replica \u003d cs.share_replicas.create(share, args.availability_zone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e0ba177d_1b713a47","line":6011,"range":{"start_line":6011,"start_character":4,"end_line":6011,"end_character":28},"updated":"2021-11-15 02:13:08.000000000","message":"scheduler_hints only support after micversion 2.65. we shoud check it.\n        if cs.api_version \u003c api_versions.APIVersion(\"2.65\"):\n            raise exceptions.CommandError(\n                \"args \u0027scheduler_hints\u0027 is available only starting with \"\n                \"\u00272.65\u0027 API microversion.\")","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":6008,"context_line":"    share \u003d _find_share(cs, args.share)"},{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":"    scheduler_hints \u003d {}"},{"line_number":6011,"context_line":"    if args.scheduler_hints:"},{"line_number":6012,"context_line":"        scheduler_hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6013,"context_line":""},{"line_number":6014,"context_line":"    replica \u003d cs.share_replicas.create(share, args.availability_zone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"42f2d8f4_553c7e0c","line":6011,"range":{"start_line":6011,"start_character":4,"end_line":6011,"end_character":28},"in_reply_to":"e0ba177d_1b713a47","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":"    scheduler_hints \u003d {}"},{"line_number":6011,"context_line":"    if args.scheduler_hints:"},{"line_number":6012,"context_line":"        scheduler_hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6013,"context_line":""},{"line_number":6014,"context_line":"    replica \u003d cs.share_replicas.create(share, args.availability_zone,"},{"line_number":6015,"context_line":"                                       scheduler_hints\u003dscheduler_hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2c258285_71689251","line":6012,"range":{"start_line":6012,"start_character":8,"end_line":6012,"end_character":23},"updated":"2021-11-15 02:13:08.000000000","message":"we should add check function here. it will raise if we get other key, but not only_host.","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":6009,"context_line":""},{"line_number":6010,"context_line":"    scheduler_hints \u003d {}"},{"line_number":6011,"context_line":"    if args.scheduler_hints:"},{"line_number":6012,"context_line":"        scheduler_hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6013,"context_line":""},{"line_number":6014,"context_line":"    replica \u003d cs.share_replicas.create(share, args.availability_zone,"},{"line_number":6015,"context_line":"                                       scheduler_hints\u003dscheduler_hints)"}],"source_content_type":"text/x-python","patch_set":2,"id":"34395288_6ce694a8","line":6012,"range":{"start_line":6012,"start_character":8,"end_line":6012,"end_character":23},"in_reply_to":"2c258285_71689251","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"50518679b02b702f660c2a89ec282a2c6f90962e","unresolved":true,"context_lines":[{"line_number":6011,"context_line":"    if args.scheduler_hints:"},{"line_number":6012,"context_line":"        scheduler_hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6013,"context_line":""},{"line_number":6014,"context_line":"    replica \u003d cs.share_replicas.create(share, args.availability_zone,"},{"line_number":6015,"context_line":"                                       scheduler_hints\u003dscheduler_hints)"},{"line_number":6016,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6017,"context_line":""},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"53e58802_0a88970e","line":6015,"range":{"start_line":6014,"start_character":4,"end_line":6015,"end_character":71},"updated":"2021-11-15 02:13:08.000000000","message":"if cs.api_version \u003c api_versions.APIVersion(\"2.65\"):\n    replica \u003d cs.share_replicas.create(share, args.availability_zone)\nelse:\n    replica \u003d cs.share_replicas.create(share, args.availability_zone,\n                                       scheduler_hints\u003dscheduler_hints)","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"6c805d2d2dc1dee44e8f5ae63d9a9c4d0def8145","unresolved":false,"context_lines":[{"line_number":6011,"context_line":"    if args.scheduler_hints:"},{"line_number":6012,"context_line":"        scheduler_hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6013,"context_line":""},{"line_number":6014,"context_line":"    replica \u003d cs.share_replicas.create(share, args.availability_zone,"},{"line_number":6015,"context_line":"                                       scheduler_hints\u003dscheduler_hints)"},{"line_number":6016,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6017,"context_line":""},{"line_number":6018,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7e26c18b_78f24d9b","line":6015,"range":{"start_line":6014,"start_character":4,"end_line":6015,"end_character":71},"in_reply_to":"53e58802_0a88970e","updated":"2021-11-15 17:07:32.000000000","message":"Done","commit_id":"ebe64e1ee02b10feca70c5452951696e84776e10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"3e35fccde6c9b3e825f1345d25bee763fb8a6294","unresolved":true,"context_lines":[{"line_number":6015,"context_line":"                \"\u00272.65\u0027 API microversion.\")"},{"line_number":6016,"context_line":""},{"line_number":6017,"context_line":"        hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6018,"context_line":"        if \u0027only_host\u0027 not in hints.keys():"},{"line_number":6019,"context_line":"            raise exceptions.CommandError("},{"line_number":6020,"context_line":"                \"args \u0027scheduler_hints\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":6021,"context_line":"        scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"73b6cb9a_08d89dd4","line":6018,"range":{"start_line":6018,"start_character":8,"end_line":6018,"end_character":43},"updated":"2021-11-16 01:05:22.000000000","message":"if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:","commit_id":"5191472fe519871ffd1facd01997e432c3752901"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"e8e02c7ed91f9bc67c9a773fb1c94f7dc911843b","unresolved":false,"context_lines":[{"line_number":6015,"context_line":"                \"\u00272.65\u0027 API microversion.\")"},{"line_number":6016,"context_line":""},{"line_number":6017,"context_line":"        hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6018,"context_line":"        if \u0027only_host\u0027 not in hints.keys():"},{"line_number":6019,"context_line":"            raise exceptions.CommandError("},{"line_number":6020,"context_line":"                \"args \u0027scheduler_hints\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":6021,"context_line":"        scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ddd55f8_9bc5420e","line":6018,"range":{"start_line":6018,"start_character":8,"end_line":6018,"end_character":43},"in_reply_to":"73b6cb9a_08d89dd4","updated":"2021-11-18 17:34:34.000000000","message":"Done","commit_id":"5191472fe519871ffd1facd01997e432c3752901"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"9018cc165953639cb2534c0923bb6c906970eb33","unresolved":true,"context_lines":[{"line_number":6002,"context_line":"    help\u003d\u0027Scheduler hints for the share replica as key\u003dvalue pairs, \u0027"},{"line_number":6003,"context_line":"         \u0027Supported key is only_host.\u0027,"},{"line_number":6004,"context_line":"    default\u003dNone)"},{"line_number":6005,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":6006,"context_line":"def do_share_replica_create(cs, args):"},{"line_number":6007,"context_line":"    \"\"\"Create a share replica.\"\"\""},{"line_number":6008,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"205e9aca_5734c734","line":6005,"updated":"2021-11-25 18:27:20.000000000","message":"Since we are using the wraps annotation here, it would be better to define one for 2.65 and add the scheduler_hints param there. What do you think?","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a365110dc62a2ac311510ea1a13b9ec1193bafcc","unresolved":true,"context_lines":[{"line_number":6002,"context_line":"    help\u003d\u0027Scheduler hints for the share replica as key\u003dvalue pairs, \u0027"},{"line_number":6003,"context_line":"         \u0027Supported key is only_host.\u0027,"},{"line_number":6004,"context_line":"    default\u003dNone)"},{"line_number":6005,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":6006,"context_line":"def do_share_replica_create(cs, args):"},{"line_number":6007,"context_line":"    \"\"\"Create a share replica.\"\"\""},{"line_number":6008,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d4cbb704_93170140","line":6005,"in_reply_to":"205e9aca_5734c734","updated":"2021-11-25 21:01:03.000000000","message":"I think we should keep as it is i.e. version check in the function similar to https://github.com/openstack/python-manilaclient/blob/b5a4f9c396fd72ece58d09974718900c3b93edd5/manilaclient/osc/v2/share.py#L223\nThis will avoid defining new wrap for every new version where new parameter will be added in future.","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":6002,"context_line":"    help\u003d\u0027Scheduler hints for the share replica as key\u003dvalue pairs, \u0027"},{"line_number":6003,"context_line":"         \u0027Supported key is only_host.\u0027,"},{"line_number":6004,"context_line":"    default\u003dNone)"},{"line_number":6005,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":6006,"context_line":"def do_share_replica_create(cs, args):"},{"line_number":6007,"context_line":"    \"\"\"Create a share replica.\"\"\""},{"line_number":6008,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a460f71e_f5dbbc25","line":6005,"in_reply_to":"961e65f5_2354c128","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":6002,"context_line":"    help\u003d\u0027Scheduler hints for the share replica as key\u003dvalue pairs, \u0027"},{"line_number":6003,"context_line":"         \u0027Supported key is only_host.\u0027,"},{"line_number":6004,"context_line":"    default\u003dNone)"},{"line_number":6005,"context_line":"@api_versions.wraps(\"2.11\")"},{"line_number":6006,"context_line":"def do_share_replica_create(cs, args):"},{"line_number":6007,"context_line":"    \"\"\"Create a share replica.\"\"\""},{"line_number":6008,"context_line":"    share \u003d _find_share(cs, args.share)"}],"source_content_type":"text/x-python","patch_set":4,"id":"961e65f5_2354c128","line":6005,"in_reply_to":"d4cbb704_93170140","updated":"2022-01-26 19:55:43.000000000","message":"This method is small enough to use the wraps approach with this shell client (we took a different approach with OSC) - it may be better for readability, as opposed to having conditionals in the code. \n\nPlease be aware that we\u0027re looking to deprecate the \"manila\" shell this cycle in favor of OSC - while i won\u0027t oppose adding this minor functionality, we\u0027re actively discouraging adding new/big features in this shell client.","commit_id":"9c78d25a8511bf259d86c750fac7fbe66885ed61"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":6048,"context_line":"                \"args \u0027scheduler_hints\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":6049,"context_line":"        scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":6050,"context_line":""},{"line_number":6051,"context_line":"    body \u003d {"},{"line_number":6052,"context_line":"        \u0027share\u0027: share,"},{"line_number":6053,"context_line":"        \u0027availability_zone\u0027: args.availability_zone,"},{"line_number":6054,"context_line":"        \u0027scheduler_hints\u0027: scheduler_hints"},{"line_number":6055,"context_line":"    }"},{"line_number":6056,"context_line":"    replica \u003d cs.share_replicas.create(**body)"},{"line_number":6057,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6058,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8bff5b24_45378387","line":6055,"range":{"start_line":6051,"start_character":4,"end_line":6055,"end_character":5},"updated":"2022-01-26 19:55:43.000000000","message":"same comment as in OSC, allow \"scheduler_hints\" to be added optionally so that the version based method selection logic can work correctly:\n\n   body \u003d {\n        \u0027share\u0027: share,\n        \u0027availability_zone\u0027: args.availability_zone,\n    }\n\n   if scheduler_hints:\n      body[\u0027scheduler_hints\u0027] \u003d scheduler_hints","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":6048,"context_line":"                \"args \u0027scheduler_hints\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":6049,"context_line":"        scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":6050,"context_line":""},{"line_number":6051,"context_line":"    body \u003d {"},{"line_number":6052,"context_line":"        \u0027share\u0027: share,"},{"line_number":6053,"context_line":"        \u0027availability_zone\u0027: args.availability_zone,"},{"line_number":6054,"context_line":"        \u0027scheduler_hints\u0027: scheduler_hints"},{"line_number":6055,"context_line":"    }"},{"line_number":6056,"context_line":"    replica \u003d cs.share_replicas.create(**body)"},{"line_number":6057,"context_line":"    _print_share_replica(cs, replica)"},{"line_number":6058,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"2986157c_74ecdf69","line":6055,"range":{"start_line":6051,"start_character":4,"end_line":6055,"end_character":5},"in_reply_to":"8bff5b24_45378387","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e7cfc9ea5e8f69def2b2f873f7aa9b5addea05f","unresolved":true,"context_lines":[{"line_number":6065,"context_line":"        hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6066,"context_line":"        if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:"},{"line_number":6067,"context_line":"            raise exceptions.CommandError("},{"line_number":6068,"context_line":"                \"args \u0027scheduler_hints\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":6069,"context_line":"        scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":6070,"context_line":""},{"line_number":6071,"context_line":"    body \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"c5365c15_11076a12","line":6068,"range":{"start_line":6068,"start_character":17,"end_line":6068,"end_character":69},"updated":"2022-02-15 01:17:29.000000000","message":"The only valid key supported with the --scheduler-hints argument is \"only_host\"","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9c856a5c380a071e6a2b9cbdfb8865d5eed70ced","unresolved":false,"context_lines":[{"line_number":6065,"context_line":"        hints \u003d _extract_key_value_options(args, \u0027scheduler_hints\u0027)"},{"line_number":6066,"context_line":"        if \u0027only_host\u0027 not in hints.keys() or len(hints) \u003e 1:"},{"line_number":6067,"context_line":"            raise exceptions.CommandError("},{"line_number":6068,"context_line":"                \"args \u0027scheduler_hints\u0027 support only \u0027only_host\u0027 key.\")"},{"line_number":6069,"context_line":"        scheduler_hints[\u0027only_host\u0027] \u003d hints.get(\u0027only_host\u0027)"},{"line_number":6070,"context_line":""},{"line_number":6071,"context_line":"    body \u003d {"}],"source_content_type":"text/x-python","patch_set":13,"id":"4fb587da_42ead7fd","line":6068,"range":{"start_line":6068,"start_character":17,"end_line":6068,"end_character":69},"in_reply_to":"c5365c15_11076a12","updated":"2022-02-15 03:23:47.000000000","message":"Done","commit_id":"32071394a40982d193f388daf3a400a0e608f84f"}],"releasenotes/notes/add-scheduler-hints-to-share-replica-create-d152a3934e5ad3a7.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"147f16f5a351a093971638433c782be85eae6d0b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added --scheduler_hints to the share-replica create command"},{"line_number":4,"context_line":"upgrade:"},{"line_number":5,"context_line":"  - Scheduler hints in the share-replica create command allow scheduler to"},{"line_number":6,"context_line":"    select appropriate host using filters. For example, user needs to specify"},{"line_number":7,"context_line":"    \"only_host\u003dhost@backend#pool\" when creating a manila share-replica in case"},{"line_number":8,"context_line":"    of onlyhostFilter. Supported for microversion \u003e\u003d 2.67."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9960be4f_b9cf7b65","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":58},"updated":"2022-01-26 19:55:43.000000000","message":"This can be added to the \"features\" section since it doesn\u0027t really impact upgrades.. an example of an upgrade impacting note would be us signaling removal of something in the manilaclient SDK or requiring some changes to installation..","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"803c776d3cc86d298b5f766d5b3a43fa17e66fdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added --scheduler_hints to the share-replica create command"},{"line_number":4,"context_line":"upgrade:"},{"line_number":5,"context_line":"  - Scheduler hints in the share-replica create command allow scheduler to"},{"line_number":6,"context_line":"    select appropriate host using filters. For example, user needs to specify"},{"line_number":7,"context_line":"    \"only_host\u003dhost@backend#pool\" when creating a manila share-replica in case"},{"line_number":8,"context_line":"    of onlyhostFilter. Supported for microversion \u003e\u003d 2.67."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"789ca5be_b6e5df47","line":8,"range":{"start_line":4,"start_character":0,"end_line":8,"end_character":58},"in_reply_to":"9960be4f_b9cf7b65","updated":"2022-01-29 10:47:21.000000000","message":"Done","commit_id":"a786e710dea0fcde79b21c06c21d1e223cc77103"}]}