)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"13c3cec28f0591001362a0a2f9c14a174886e823","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5a94bba6_5d4076eb","updated":"2021-12-02 16:02:06.000000000","message":"Thank you for working on this change, Archana! This is a very valuable bugfix\nI found few issues while testing the code, and addressed those inline. Please check the comments :)","commit_id":"73db1c7fb085040b237960ea49deb1abd39d51f6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d46a61253ea45b34efab5da00a1885015dd07854","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"aca9a628_09facd5b","updated":"2021-12-03 15:27:14.000000000","message":"Code looks very good, just one minor nit. Thanks Archu!","commit_id":"27eadb56861fc3dbe58f5fe4757e657db7da71c2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"63e6f0792d7071da14649c4535083eb02306426b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a79a044b_c6bbddd9","updated":"2021-12-07 17:06:04.000000000","message":"Great job Archu, thanks!","commit_id":"31e231b7e560ec98a6d1a23e05c46ac5c204db99"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a26e4e8612bab6ce9c426c05b8e16c18312c2459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dc33fced_9752c87c","updated":"2021-12-03 15:58:45.000000000","message":"Hi, I\u0027ve addressed your comments and updated a new patchset.\nThanks for the review Carlos and Vicky :) ","commit_id":"31e231b7e560ec98a6d1a23e05c46ac5c204db99"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0e105d362d93101a191923cba0928fdf9a1d37bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1d583c2b_c3db622c","updated":"2021-12-07 14:10:59.000000000","message":"LGTM. Thank you","commit_id":"31e231b7e560ec98a6d1a23e05c46ac5c204db99"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"40dc2406690871707c2e0ead74994bb98251b5f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d29275a2_5b77b1bf","updated":"2021-12-03 21:48:28.000000000","message":"Looks good to me! Thank you very much for this fix, Archana","commit_id":"31e231b7e560ec98a6d1a23e05c46ac5c204db99"}],"manilaclient/osc/v2/share_replicas.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"13c3cec28f0591001362a0a2f9c14a174886e823","unresolved":true,"context_lines":[{"line_number":194,"context_line":"        replica \u003d share_client.share_replicas.get("},{"line_number":195,"context_line":"            parsed_args.replica)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        replica_export_locations \u003d ("},{"line_number":198,"context_line":"            share_client.share_replica_export_locations.list("},{"line_number":199,"context_line":"                replica\u003dreplica))"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"94070079_84a940f7","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":32},"updated":"2021-12-02 16:02:06.000000000","message":"This should be done only when the microversion is bigger than 2.47...\nhttps://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_replica_export_locations.py#L35","commit_id":"73db1c7fb085040b237960ea49deb1abd39d51f6"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a26e4e8612bab6ce9c426c05b8e16c18312c2459","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        replica \u003d share_client.share_replicas.get("},{"line_number":195,"context_line":"            parsed_args.replica)"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        replica_export_locations \u003d ("},{"line_number":198,"context_line":"            share_client.share_replica_export_locations.list("},{"line_number":199,"context_line":"                replica\u003dreplica))"},{"line_number":200,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"2523de46_4daf552c","line":197,"range":{"start_line":197,"start_character":8,"end_line":197,"end_character":32},"in_reply_to":"94070079_84a940f7","updated":"2021-12-03 15:58:45.000000000","message":"Ack","commit_id":"73db1c7fb085040b237960ea49deb1abd39d51f6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"13c3cec28f0591001362a0a2f9c14a174886e823","unresolved":true,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        replica_export_locations \u003d ("},{"line_number":198,"context_line":"            share_client.share_replica_export_locations.list("},{"line_number":199,"context_line":"                replica\u003dreplica))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        replica._info[\u0027export_locations\u0027] \u003d []"},{"line_number":202,"context_line":"        for element_location in replica_export_locations:"}],"source_content_type":"text/x-python","patch_set":3,"id":"97c598b6_ed3686fd","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":24},"updated":"2021-12-02 16:02:06.000000000","message":"This argument possibly shouldn\u0027t be forwarded as a kwarg, according to the method\u0027s call:\nhttps://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/share_replica_export_locations.py","commit_id":"73db1c7fb085040b237960ea49deb1abd39d51f6"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a26e4e8612bab6ce9c426c05b8e16c18312c2459","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"        replica_export_locations \u003d ("},{"line_number":198,"context_line":"            share_client.share_replica_export_locations.list("},{"line_number":199,"context_line":"                replica\u003dreplica))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        replica._info[\u0027export_locations\u0027] \u003d []"},{"line_number":202,"context_line":"        for element_location in replica_export_locations:"}],"source_content_type":"text/x-python","patch_set":3,"id":"88919932_4b3dcda2","line":199,"range":{"start_line":199,"start_character":16,"end_line":199,"end_character":24},"in_reply_to":"97c598b6_ed3686fd","updated":"2021-12-03 15:58:45.000000000","message":"Ack","commit_id":"73db1c7fb085040b237960ea49deb1abd39d51f6"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d46a61253ea45b34efab5da00a1885015dd07854","unresolved":true,"context_lines":[{"line_number":185,"context_line":"            \"replica\","},{"line_number":186,"context_line":"            metavar\u003d\"\u003creplica\u003e\","},{"line_number":187,"context_line":"            help\u003d_(\"ID of the share replica. Available only for \""},{"line_number":188,"context_line":"                   \"microversion \u003e 2.47. \")"},{"line_number":189,"context_line":"        )"},{"line_number":190,"context_line":"        return parser"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"24bf7a41_657b701b","line":188,"updated":"2021-12-03 15:27:14.000000000","message":"NIT \u003e\u003d instead of \u003e, since this was added from microversion 2.47 (https://docs.openstack.org/manila/latest/contributor/api_microversion_history.html#id41)","commit_id":"27eadb56861fc3dbe58f5fe4757e657db7da71c2"},{"author":{"_account_id":33380,"name":"Archana Kumari","display_name":"Archana Kumari","email":"ak31960466@gmail.com","username":"archanaserver"},"change_message_id":"a26e4e8612bab6ce9c426c05b8e16c18312c2459","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            \"replica\","},{"line_number":186,"context_line":"            metavar\u003d\"\u003creplica\u003e\","},{"line_number":187,"context_line":"            help\u003d_(\"ID of the share replica. Available only for \""},{"line_number":188,"context_line":"                   \"microversion \u003e 2.47. \")"},{"line_number":189,"context_line":"        )"},{"line_number":190,"context_line":"        return parser"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"f6b859d5_b843ddfc","line":188,"in_reply_to":"24bf7a41_657b701b","updated":"2021-12-03 15:58:45.000000000","message":"Done","commit_id":"27eadb56861fc3dbe58f5fe4757e657db7da71c2"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"0e105d362d93101a191923cba0928fdf9a1d37bd","unresolved":false,"context_lines":[{"line_number":205,"context_line":"            replica._info[\u0027export_locations\u0027].append("},{"line_number":206,"context_line":"                element_location._info)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        if parsed_args.formatter \u003d\u003d \u0027table\u0027:"},{"line_number":209,"context_line":"            replica._info[\u0027export_locations\u0027] \u003d ("},{"line_number":210,"context_line":"                cliutils.convert_dict_list_to_string("},{"line_number":211,"context_line":"                    replica._info[\u0027export_locations\u0027]))"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        replica._info.pop(\u0027links\u0027, None)"},{"line_number":214,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"fa48a34a_873dbccd","line":211,"range":{"start_line":208,"start_character":8,"end_line":211,"end_character":55},"updated":"2021-12-07 14:10:59.000000000","message":"This is really nice :)","commit_id":"31e231b7e560ec98a6d1a23e05c46ac5c204db99"}]}
