)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d74d5790f90af50bba0732e6cf3e4df0722f427","unresolved":true,"context_lines":[{"line_number":11,"context_line":"request is sent and no CLI error notification is received."},{"line_number":12,"context_line":"This patch prevent sending the create request and provide"},{"line_number":13,"context_line":"early feedback to CLI users."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I66a8bcebe35e744f9796e3db44d6cedf2ada983f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"48f6e85c_d2d907b4","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2022-02-11 22:57:54.000000000","message":"Could you link a bug, and write up a release note? \nI\u0027d suggest adding \"python-manilaclient\" to https://bugs.launchpad.net/manila/+bug/1870280 with the \"Also affects project\" button.. and closing that bug with this commit..","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a8138d712dc4e3a0502155a417be78b0f83ce69a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"request is sent and no CLI error notification is received."},{"line_number":12,"context_line":"This patch prevent sending the create request and provide"},{"line_number":13,"context_line":"early feedback to CLI users."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I66a8bcebe35e744f9796e3db44d6cedf2ada983f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"90cb150f_d0b9ad11","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"in_reply_to":"48f6e85c_d2d907b4","updated":"2022-02-14 13:21:07.000000000","message":"Done","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"0dd0b3a96939f4f1740dfcc3128fbb14d5b6f449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"30a6b86b_9e23addb","updated":"2022-02-10 12:23:56.000000000","message":"Change verified in local env, thanks.","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d74d5790f90af50bba0732e6cf3e4df0722f427","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0d81461_db039640","updated":"2022-02-11 22:57:54.000000000","message":"Hi Liron, \n\nThank you for this fix. Could you also address this with the OSC plugin?","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"5f450af0dba47b04ecc0eb85ec37abf947124be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff80c962_f8551123","updated":"2022-02-11 21:48:53.000000000","message":"LGTM Thanks Liron","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a8138d712dc4e3a0502155a417be78b0f83ce69a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6a0de842_641d0d4d","in_reply_to":"f0d81461_db039640","updated":"2022-02-14 13:21:07.000000000","message":"Done!","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11f082d42d3d89a1582286928fd749d3f6ad8197","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"86410b93_48f14a03","updated":"2022-02-14 20:26:02.000000000","message":"Hi Liron, \n\nThanks for adding the new message and the OSC bits; there\u0027s an issue with the OSC code though:\n\n$ openstack --os-share-api-version 2.65 share create nfs 1\nNo sharetype with a name or ID of \u0027default\u0027 exists.\n\n\n","commit_id":"664b9e6a9f2e3623c709c493f749934822897ca7"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a8138d712dc4e3a0502155a417be78b0f83ce69a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f97acb3a_1d05cae6","updated":"2022-02-14 13:21:07.000000000","message":"Thanks for the comments Goutham! ","commit_id":"664b9e6a9f2e3623c709c493f749934822897ca7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"3af72efffce445c01480c70caef721cdcb82bd7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"88626cfa_7c932d24","updated":"2022-02-17 20:35:38.000000000","message":"LGTM. Thank you, Liron!","commit_id":"ded2303da8d1580d39ad1687312313d8934a6f2f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1038ced91a751ea24567759f0e555c283ad25207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"235358ea_c0f41dc1","updated":"2022-02-15 21:39:20.000000000","message":"Thanks Liron, LGTM!","commit_id":"ded2303da8d1580d39ad1687312313d8934a6f2f"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"11f082d42d3d89a1582286928fd749d3f6ad8197","unresolved":true,"context_lines":[{"line_number":200,"context_line":"            try:"},{"line_number":201,"context_line":"                share_type \u003d apiutils.find_resource("},{"line_number":202,"context_line":"                    share_client.share_types, \u0027default\u0027).id"},{"line_number":203,"context_line":"            except exceptions.CommandError:"},{"line_number":204,"context_line":"                msg \u003d (\"There is no default share type available. You must \""},{"line_number":205,"context_line":"                       \"pick a valid share type to create a share.\")"},{"line_number":206,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"3204d86d_aa0e8638","line":203,"range":{"start_line":203,"start_character":19,"end_line":203,"end_character":43},"updated":"2022-02-14 20:26:02.000000000","message":"This isn\u0027t the exception that \"find_resource\" is raising... although they\u0027re named the same, the exception comes from elsewhere:\n\n\nTraceback (most recent call last):\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/app.py\", line 407, in run_subcommand\n    result \u003d cmd.run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/osc_lib/command/command.py\", line 39, in run\n    return super(Command, self).run(parsed_args)\n  File \"/usr/local/lib/python3.8/dist-packages/cliff/display.py\", line 115, in run\n    column_names, data \u003d self.take_action(parsed_args)\n  File \"/opt/stack/python-manilaclient/manilaclient/osc/v2/share.py\", line 201, in take_action\n    share_type \u003d apiutils.find_resource(\n  File \"/opt/stack/python-manilaclient/manilaclient/common/apiclient/utils.py\", line 73, in find_resource\n    raise exceptions.CommandError(msg)\nmanilaclient.common.apiclient.exceptions.CommandError: No sharetype with a name or ID of \u0027default\u0027 exists.\nclean_up CreateShare: No sharetype with a name or ID of \u0027default\u0027 exists.\nEND return value: 1","commit_id":"664b9e6a9f2e3623c709c493f749934822897ca7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6e25ddc532c3a43c0d1bb76eec244a92a7779a80","unresolved":true,"context_lines":[{"line_number":200,"context_line":"            try:"},{"line_number":201,"context_line":"                share_type \u003d apiutils.find_resource("},{"line_number":202,"context_line":"                    share_client.share_types, \u0027default\u0027).id"},{"line_number":203,"context_line":"            except exceptions.CommandError:"},{"line_number":204,"context_line":"                msg \u003d (\"There is no default share type available. You must \""},{"line_number":205,"context_line":"                       \"pick a valid share type to create a share.\")"},{"line_number":206,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"47fcb20c_33914758","line":203,"range":{"start_line":203,"start_character":19,"end_line":203,"end_character":43},"in_reply_to":"1a23e8d5_934dd984","updated":"2022-02-14 22:47:50.000000000","message":"find_resource is a general purpose wrapper that we created in the repo - so it makes sense that we\u0027d use a custom \"CommandError\" exception that we\u0027ve created... \n\n\n... there\u0027s a \"find_resource\" method in osc_lib - i\u0027m unsure if we ever tried using that instead of writing our own: https://opendev.org/openstack/osc-lib/src/commit/78d276e7223420212a6f63239d48cc794d2054ef/osc_lib/utils/__init__.py#L168-L283 \n\nthat\u0027s a question for Maari Tamm; or we could experiment and see if we can replace it with that one.. \n\nFor me, to keep things simple, you could:\n\n\n from manilaclient.common.apiclient import exceptions apiclient_exceptions\n\n \nso that you can:\n\n  except apiclient_exceptions.CommandError:","commit_id":"664b9e6a9f2e3623c709c493f749934822897ca7"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d2875745ed01295c180f84907cba2dac8303fe8c","unresolved":true,"context_lines":[{"line_number":200,"context_line":"            try:"},{"line_number":201,"context_line":"                share_type \u003d apiutils.find_resource("},{"line_number":202,"context_line":"                    share_client.share_types, \u0027default\u0027).id"},{"line_number":203,"context_line":"            except exceptions.CommandError:"},{"line_number":204,"context_line":"                msg \u003d (\"There is no default share type available. You must \""},{"line_number":205,"context_line":"                       \"pick a valid share type to create a share.\")"},{"line_number":206,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a23e8d5_934dd984","line":203,"range":{"start_line":203,"start_character":19,"end_line":203,"end_character":43},"in_reply_to":"3204d86d_aa0e8638","updated":"2022-02-14 21:06:47.000000000","message":"Good catch!\nWeird, I don\u0027t understand why.","commit_id":"664b9e6a9f2e3623c709c493f749934822897ca7"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a235b92313b0a903981419812d27d7efe8c06ca3","unresolved":true,"context_lines":[{"line_number":200,"context_line":"            try:"},{"line_number":201,"context_line":"                share_type \u003d apiutils.find_resource("},{"line_number":202,"context_line":"                    share_client.share_types, \u0027default\u0027).id"},{"line_number":203,"context_line":"            except exceptions.CommandError:"},{"line_number":204,"context_line":"                msg \u003d (\"There is no default share type available. You must \""},{"line_number":205,"context_line":"                       \"pick a valid share type to create a share.\")"},{"line_number":206,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"5e2a29fa_c0cc9888","line":203,"range":{"start_line":203,"start_character":19,"end_line":203,"end_character":43},"in_reply_to":"47fcb20c_33914758","updated":"2022-02-15 10:39:14.000000000","message":"Oh! it makes sense.\nLet\u0027s keep it simple.\nThanks Goutham!","commit_id":"664b9e6a9f2e3623c709c493f749934822897ca7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"985d554d0bc85b390719685730fb613ae4f89a50","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        scheduler_hints \u003d {}"},{"line_number":230,"context_line":"        if parsed_args.scheduler_hint:"},{"line_number":231,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\u00272.65\u0027):"},{"line_number":232,"context_line":"                raise apiclient_exceptions.CommandError("},{"line_number":233,"context_line":"                    \u0027Setting share scheduler hints for a share is \u0027"},{"line_number":234,"context_line":"                    \u0027available only for API microversion \u003e\u003d 2.65\u0027)"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                scheduler_hints \u003d utils.extract_key_value_options("},{"line_number":237,"context_line":"                    parsed_args.scheduler_hint)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ef9db358_86790bf8","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":66},"updated":"2022-02-15 18:04:09.000000000","message":"this fix is in the wrong place, you meant to do this on line 204?","commit_id":"45300450d2d63eace029694dc369647d3d3beb45"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"aafb5ec23a225a5ba2fb08d634c6da6e5db20c6d","unresolved":true,"context_lines":[{"line_number":229,"context_line":"        scheduler_hints \u003d {}"},{"line_number":230,"context_line":"        if parsed_args.scheduler_hint:"},{"line_number":231,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\u00272.65\u0027):"},{"line_number":232,"context_line":"                raise apiclient_exceptions.CommandError("},{"line_number":233,"context_line":"                    \u0027Setting share scheduler hints for a share is \u0027"},{"line_number":234,"context_line":"                    \u0027available only for API microversion \u003e\u003d 2.65\u0027)"},{"line_number":235,"context_line":"            else:"},{"line_number":236,"context_line":"                scheduler_hints \u003d utils.extract_key_value_options("},{"line_number":237,"context_line":"                    parsed_args.scheduler_hint)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1d4832da_95b57062","line":234,"range":{"start_line":232,"start_character":0,"end_line":234,"end_character":66},"in_reply_to":"ef9db358_86790bf8","updated":"2022-02-15 19:35:52.000000000","message":"Oh, thanks man!","commit_id":"45300450d2d63eace029694dc369647d3d3beb45"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"0aa25c19d408e62d918e576ede2c5c63231083ab","unresolved":true,"context_lines":[{"line_number":977,"context_line":"            _find_share_type(cs, \"default\")"},{"line_number":978,"context_line":"        except exceptions.CommandError:"},{"line_number":979,"context_line":"            msg \u003d _(\"No default share type has been made available. \""},{"line_number":980,"context_line":"                    \"You must specify a share type for creating shares.\")"},{"line_number":981,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    scheduler_hints \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c0f987b_27a4fc19","line":980,"updated":"2022-02-09 15:55:43.000000000","message":"Thanks, looks good. May consider a msg such as \"A default share type is required for share creation\".","commit_id":"272cd5177a492a23a35d1ab6466702996cd6629a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d74d5790f90af50bba0732e6cf3e4df0722f427","unresolved":true,"context_lines":[{"line_number":977,"context_line":"            _find_share_type(cs, \"default\")"},{"line_number":978,"context_line":"        except exceptions.CommandError:"},{"line_number":979,"context_line":"            msg \u003d _(\"No default share type has been made available. \""},{"line_number":980,"context_line":"                    \"You must specify a share type for creating shares.\")"},{"line_number":981,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    scheduler_hints \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"b5b43401_666bde00","line":980,"in_reply_to":"34ba491c_e25d5696","updated":"2022-02-11 22:57:54.000000000","message":"That might be a bit misleading.. it can be understood us as the deployment always needing a default share type to support shares...","commit_id":"272cd5177a492a23a35d1ab6466702996cd6629a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"080a68142521f3a3f68a2ab34faf41bc7cf3a46a","unresolved":true,"context_lines":[{"line_number":977,"context_line":"            _find_share_type(cs, \"default\")"},{"line_number":978,"context_line":"        except exceptions.CommandError:"},{"line_number":979,"context_line":"            msg \u003d _(\"No default share type has been made available. \""},{"line_number":980,"context_line":"                    \"You must specify a share type for creating shares.\")"},{"line_number":981,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":982,"context_line":""},{"line_number":983,"context_line":"    scheduler_hints \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"34ba491c_e25d5696","line":980,"in_reply_to":"4c0f987b_27a4fc19","updated":"2022-02-09 15:59:47.000000000","message":"Thanks Done!","commit_id":"272cd5177a492a23a35d1ab6466702996cd6629a"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"0006dfda3fdc13bfa7b47584be8cc5e1ec73ddec","unresolved":true,"context_lines":[{"line_number":977,"context_line":"            _find_share_type(cs, \"default\")"},{"line_number":978,"context_line":"        except exceptions.CommandError:"},{"line_number":979,"context_line":"            msg \u003d _(\"A default share type is required for share creation.\")"},{"line_number":980,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"    scheduler_hints \u003d {}"},{"line_number":983,"context_line":"    if args.scheduler_hints:"}],"source_content_type":"text/x-python","patch_set":2,"id":"2695f6ed_c42edfe7","line":980,"updated":"2022-02-09 18:53:34.000000000","message":"Gates failed due to leading \"_\" L:979","commit_id":"cef64e7a8ad3fa8146e85917be2b493ed0e57a89"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"5740d1a7532abdda19d12d665ceeac30b5fc0e52","unresolved":true,"context_lines":[{"line_number":977,"context_line":"            _find_share_type(cs, \"default\")"},{"line_number":978,"context_line":"        except exceptions.CommandError:"},{"line_number":979,"context_line":"            msg \u003d _(\"A default share type is required for share creation.\")"},{"line_number":980,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":981,"context_line":""},{"line_number":982,"context_line":"    scheduler_hints \u003d {}"},{"line_number":983,"context_line":"    if args.scheduler_hints:"}],"source_content_type":"text/x-python","patch_set":2,"id":"801de8ae_05f5f96f","line":980,"in_reply_to":"2695f6ed_c42edfe7","updated":"2022-02-09 20:10:26.000000000","message":"On second thought we do not have to worry about sending the error message.\nThis is already being done by \"_find_share_type\" function.","commit_id":"cef64e7a8ad3fa8146e85917be2b493ed0e57a89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d74d5790f90af50bba0732e6cf3e4df0722f427","unresolved":true,"context_lines":[{"line_number":973,"context_line":"            \"Share name cannot be with the value \u0027None\u0027\")"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    if not args.share_type:"},{"line_number":976,"context_line":"        _find_share_type(cs, \"default\")"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"    scheduler_hints \u003d {}"},{"line_number":979,"context_line":"    if args.scheduler_hints:"}],"source_content_type":"text/x-python","patch_set":4,"id":"b12ded47_ced8c7e1","line":976,"range":{"start_line":976,"start_character":0,"end_line":976,"end_character":39},"updated":"2022-02-11 22:57:54.000000000","message":"If a default share type isn\u0027t present, this raises a command error:\n\n\nERROR: No sharetype with a name or ID of \u0027default\u0027 exists.\n\n\nI would have preferred an error that clarified a bit further:\n\n\"There is no default share type available. You must pick a valid share type to create a share.\"","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"a8138d712dc4e3a0502155a417be78b0f83ce69a","unresolved":false,"context_lines":[{"line_number":973,"context_line":"            \"Share name cannot be with the value \u0027None\u0027\")"},{"line_number":974,"context_line":""},{"line_number":975,"context_line":"    if not args.share_type:"},{"line_number":976,"context_line":"        _find_share_type(cs, \"default\")"},{"line_number":977,"context_line":""},{"line_number":978,"context_line":"    scheduler_hints \u003d {}"},{"line_number":979,"context_line":"    if args.scheduler_hints:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea81e404_e1ea38fb","line":976,"range":{"start_line":976,"start_character":0,"end_line":976,"end_character":39},"in_reply_to":"b12ded47_ced8c7e1","updated":"2022-02-14 13:21:07.000000000","message":"Done","commit_id":"35210e7ffda2e6edc3f4bdd5ec7bc8c340d2c15a"}]}