)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"40c0a72109dca0fe00c5377f860fc46b95704e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"62c5da4d_3f5f9b81","updated":"2022-02-15 04:00:39.000000000","message":"Just to share some context of this change...\n\nI\u0027m currently facing some issues with implementing a resource type to manage share types to puppet-manila. The main reason is that the current shows multiple properties in separate lines(as is explained in the commit message) even for shell/CSV format we use. We might be able to extend our parser to correctly handle multi-lined files, having new lines in the field, especially in csv format, is what we don\u0027t really expect usually.","commit_id":"830ecb52caebee29cae9125b956ca67ac8702c59"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91e8b2754383915c4ffaf6617a3610592ea75d8f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2617bda1_a9ecc316","updated":"2022-02-16 21:15:07.000000000","message":"Perfect, thank you very much Takashi!","commit_id":"064dd6cbc31ab914ac6b74b98783488d2ec00776"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3d2c102f1d85f1bc45a4329835f729ae21d7993f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3280742b_04bca36c","updated":"2022-02-16 14:09:04.000000000","message":"So the example below describes how the output looks like with this patch\n\n```\n(overcloud) (.venv) [stack@undercloud-0 ~]$ openstack share type show --os-share-api-version 2.51 --format shell default\nid\u003d\"42005a59-d622-46b2-9737-a1676f8c41c4\"\nname\u003d\"default\"\nvisibility\u003d\"public\"\nis_default\u003d\"True\"\nrequired_extra_specs\u003d\"{\u0027driver_handles_share_servers\u0027: \u0027False\u0027}\"\noptional_extra_specs\u003d\"{\u0027snapshot_support\u0027: \u0027True\u0027}\"\ndescription\u003d\"None\"\n(overcloud) (.venv) [stack@undercloud-0 ~]$ openstack share type show --os-share-api-version 2.51 --format yaml default\nid: 42005a59-d622-46b2-9737-a1676f8c41c4\nname: default\nvisibility: public\nis_default: true\nrequired_extra_specs:\n  driver_handles_share_servers: \u0027False\u0027\noptional_extra_specs:\n  snapshot_support: \u0027True\u0027\ndescription: null\n(overcloud) (.venv) [stack@undercloud-0 ~]$ openstack share type show --os-share-api-version 2.51 --format json default\n{\n  \"id\": \"42005a59-d622-46b2-9737-a1676f8c41c4\",\n  \"name\": \"default\",\n  \"visibility\": \"public\",\n  \"is_default\": true,\n  \"required_extra_specs\": {\n    \"driver_handles_share_servers\": \"False\"\n  },\n  \"optional_extra_specs\": {\n    \"snapshot_support\": \"True\"\n  },\n  \"description\": null\n}\n(overcloud) (.venv) [stack@undercloud-0 ~]$ openstack share type list --os-share-api-version 2.51 --format csv\n\"ID\",\"Name\",\"Visibility\",\"Is Default\",\"Required Extra Specs\",\"Optional Extra Specs\",\"Description\"\n\"42005a59-d622-46b2-9737-a1676f8c41c4\",\"default\",\"public\",True,\"{\u0027driver_handles_share_servers\u0027: \u0027False\u0027}\",\"{\u0027snapshot_support\u0027: \u0027True\u0027}\",\"\"\n(overcloud) (.venv) [stack@undercloud-0 ~]$ openstack share type list --os-share-api-version 2.51 --format json\n[\n  {\n    \"ID\": \"42005a59-d622-46b2-9737-a1676f8c41c4\",\n    \"Name\": \"default\",\n    \"Visibility\": \"public\",\n    \"Is Default\": true,\n    \"Required Extra Specs\": {\n      \"driver_handles_share_servers\": \"False\"\n    },\n    \"Optional Extra Specs\": {\n      \"snapshot_support\": \"True\"\n    },\n    \"Description\": null\n  }\n]\n(overcloud) (.venv) [stack@undercloud-0 ~]$ openstack share type list --os-share-api-version 2.51 --format yaml\n- Description: null\n  ID: 42005a59-d622-46b2-9737-a1676f8c41c4\n  Is Default: true\n  Name: default\n  Optional Extra Specs:\n    snapshot_support: \u0027True\u0027\n  Required Extra Specs:\n    driver_handles_share_servers: \u0027False\u0027\n  Visibility: public\n```\n\n","commit_id":"064dd6cbc31ab914ac6b74b98783488d2ec00776"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"06085de6863bf16389daa4df2b5dee14c630a3b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3ca5033b_7d5309cd","updated":"2022-02-16 13:56:14.000000000","message":"Thanks for working on this Takashi, looks good to me! :) ","commit_id":"064dd6cbc31ab914ac6b74b98783488d2ec00776"}],"manilaclient/osc/v2/share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28db50132b7615a6a6c6341cbc8543e41a51b3b9","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    share_type._info.update("},{"line_number":52,"context_line":"        {"},{"line_number":53,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":54,"context_line":"            \u0027required_extra_specs\u0027: utils.format_properties("},{"line_number":55,"context_line":"                share_type.required_extra_specs, joint),"},{"line_number":56,"context_line":"            \u0027optional_extra_specs\u0027: utils.format_properties("},{"line_number":57,"context_line":"                optional_extra_specs, joint),"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"    )"},{"line_number":60,"context_line":"    return share_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9b61b80_8bf5f394","line":57,"range":{"start_line":54,"start_character":12,"end_line":57,"end_character":45},"updated":"2022-02-15 22:31:56.000000000","message":"Takashi: would it help if we skipped this formatting altogether based on the formatter used by the OSC user? That is, if it\u0027s not a \"table\", we can skip formatting and just present the data that\u0027s coming back from the server and the formatters will handle it correctly. \n\nWe did this with share group types: https://github.com/openstack/python-manilaclient/blob/6c595e0661a5073d20a63caa12f2e60d72996dc8/manilaclient/osc/utils.py#L117-L122","commit_id":"830ecb52caebee29cae9125b956ca67ac8702c59"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5d34df53c084ec04164bc42e909f1a5d6986e58a","unresolved":true,"context_lines":[{"line_number":51,"context_line":"    share_type._info.update("},{"line_number":52,"context_line":"        {"},{"line_number":53,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":54,"context_line":"            \u0027required_extra_specs\u0027: utils.format_properties("},{"line_number":55,"context_line":"                share_type.required_extra_specs, joint),"},{"line_number":56,"context_line":"            \u0027optional_extra_specs\u0027: utils.format_properties("},{"line_number":57,"context_line":"                optional_extra_specs, joint),"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"    )"},{"line_number":60,"context_line":"    return share_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"ae1c3118_78843382","line":57,"range":{"start_line":54,"start_character":12,"end_line":57,"end_character":45},"in_reply_to":"a9b61b80_8bf5f394","updated":"2022-02-16 11:54:59.000000000","message":"I think that is a better idea indeed and helps some formats like json or yaml which expect native exporession rather than formatted one.\n\nI\u0027ll update the change accordingly.","commit_id":"830ecb52caebee29cae9125b956ca67ac8702c59"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"32c586129a3c35b60bca33172684e1aafc2188f8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    share_type._info.update("},{"line_number":52,"context_line":"        {"},{"line_number":53,"context_line":"            \u0027visibility\u0027: visibility,"},{"line_number":54,"context_line":"            \u0027required_extra_specs\u0027: utils.format_properties("},{"line_number":55,"context_line":"                share_type.required_extra_specs, joint),"},{"line_number":56,"context_line":"            \u0027optional_extra_specs\u0027: utils.format_properties("},{"line_number":57,"context_line":"                optional_extra_specs, joint),"},{"line_number":58,"context_line":"        }"},{"line_number":59,"context_line":"    )"},{"line_number":60,"context_line":"    return share_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"6a58fa63_f3104bfe","line":57,"range":{"start_line":54,"start_character":12,"end_line":57,"end_character":45},"in_reply_to":"ae1c3118_78843382","updated":"2022-02-16 12:25:27.000000000","message":"Done","commit_id":"830ecb52caebee29cae9125b956ca67ac8702c59"}]}