)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"26871bbe_4ace6362","updated":"2022-04-05 10:05:44.000000000","message":"Thanks for working on this Namrata! I left some comments inline, please have a look :) ","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f0ce0062efd590a0c6d49faa7210aa4bc3f64207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7fe101f5_a75af3c8","updated":"2022-04-06 13:37:17.000000000","message":"Thanks Namrata! The code looks good to me! I added a few nits inline and a question for other reviewers, let\u0027s see what they think of that. I\u0027ll try to test it in my environment soon as well!","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"0ae069d2f7e43ef1868fe97f00a50b41314143f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8550a8f7_e02d14b0","updated":"2022-04-06 07:42:44.000000000","message":"recheck","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"d5895e5b458fc7d727d5163f9d17216a91230e5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7813876f_9e71ecae","updated":"2022-04-13 05:41:56.000000000","message":"recheck","commit_id":"05c1432b43779f3cc0d6c41766145773e4666561"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"dc6364015ee968a135e49d94ad35279d64c657f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"88e8a659_7fc5a10e","updated":"2022-04-12 14:45:34.000000000","message":"recheck","commit_id":"05c1432b43779f3cc0d6c41766145773e4666561"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"dbab893648ccf024bb3cc9300937ed1084a45fa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"eac08f31_aa383a5a","updated":"2022-04-14 07:36:27.000000000","message":"recheck","commit_id":"595f23941fc0a6831b80250db1217c5e4d5e0975"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"75b2b3af1e65fa49bdc5f016121a8a36736c695e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"556c73b9_b66237d0","updated":"2022-04-18 12:57:59.000000000","message":"Thank you for the work on this change, Namrata!\nPlease check my comment inline :)","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a952b60f5b6365e346d94246fb2b173d428044c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7a4fab9a_b21cac74","updated":"2022-06-03 19:22:42.000000000","message":"Thanks for working on this Namrata! I tested it in my environment and it worked as expected, code looks good, I just left some small suggestions inline, please have a look :) ","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"05f2762790aedb2a6c457c97c7eaa22b7da1fca7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"934a4175_fd4a88a2","updated":"2022-06-20 10:37:50.000000000","message":"How did this managed to to work, I just tested it now and i did not work for me \nhttps://paste.opendev.org/show/burZv21uII8Wx8ppZd9T/","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ece598a8a0b1bc88608bed76fb92758659840ad2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"f55b82c6_f668c33e","updated":"2022-06-09 20:06:39.000000000","message":"Looking good, Namrata! Thank you very much","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"736488d37400be7a8bef7a4e4114e3052130e87c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"8bcf383f_11cb9ee7","updated":"2022-06-27 20:10:59.000000000","message":"Thanks Namrata! I think this could use a rebase and I added one additional nit inline, other than that, LGTM! :) ","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"7fa17cdd1234c19ce5b694f29d593a7e91053aea","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fc1c9596_bb90459d","in_reply_to":"2f6f26e8_10f0383f","updated":"2022-06-25 09:46:36.000000000","message":"\u003e @Franca, the command you ran https://paste.opendev.org/show/b4HSZsCulAod1Ymw3Yd5/ and migrated to host franca-dsvm@alpha#fake_pool_for_ALPHA. Does this host exist in your environment?\n\nYes, take a look. https://paste.opendev.org/show/bJMkR47SBeQ72u3sacpv/","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"c58908c091a4a1b7d1fc4103ea2112f8366fb502","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":13,"id":"2f6f26e8_10f0383f","in_reply_to":"934a4175_fd4a88a2","updated":"2022-06-21 04:52:55.000000000","message":"@Franca, the command you ran https://paste.opendev.org/show/b4HSZsCulAod1Ymw3Yd5/ and migrated to host franca-dsvm@alpha#fake_pool_for_ALPHA. Does this host exist in your environment?","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7ce8cc45d957513a409ab59c037b2884d3328741","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"24998f9c_0b1cc6c3","in_reply_to":"f55b82c6_f668c33e","updated":"2022-06-09 20:18:07.000000000","message":"I didn\u0027t have a chance to test this yet in an environment though, I\u0027ll try to do that asap","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"736488d37400be7a8bef7a4e4114e3052130e87c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"807ff479_00e8c2b8","in_reply_to":"fc1c9596_bb90459d","updated":"2022-06-27 20:10:59.000000000","message":"Thanks for testing the patch Franca! As we discussed elsewhere the problem you were having is probably related to dhss\u003dfalse vs dhss\u003dtrue. You can try migrating to franca-dsvm@delta#fake_pool_for_DELTA because the GAMMA and DELTA are both dhss\u003dfalse: https://docs.openstack.org/python-manilaclient/latest/contributor/functional-tests.html#prerequisite  \nI was able to make this work in my devstack: https://paste.opendev.org/show/bq79TXKpIBfipGaG5r7O/","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a629f944c3d11cc7fd4401f995b4b36e4dc861e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"fda74b41_30c7b0a2","updated":"2022-06-30 11:44:38.000000000","message":"LGTM. thank you, Namrata!","commit_id":"9121a120f3efe29e5e06818960e5c42f3309abea"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f2ba156a56f364ac01116b3b005ef4b66ecda388","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4896c7a3_c2e21dec","updated":"2022-06-29 14:26:53.000000000","message":"Thanks Namrata, LGTM!","commit_id":"9121a120f3efe29e5e06818960e5c42f3309abea"}],"doc/source/cli/osc/v2/index.rst":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    :command: share export location list"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":48,"context_line":"    :command: share migration start"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":51,"context_line":"    :command: share revert"}],"source_content_type":"text/x-rst","patch_set":1,"id":"3d6f97fd_08be481f","line":48,"updated":"2022-04-05 10:05:44.000000000","message":"Perhaps we could add separate sub group for \"share migration\" and group the migration commands there as \"share migration *\" ?","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    :command: share export location list"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":48,"context_line":"    :command: share migration start"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":51,"context_line":"    :command: share revert"}],"source_content_type":"text/x-rst","patch_set":1,"id":"cb5b6993_faa19c08","line":48,"in_reply_to":"3d6f97fd_08be481f","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f0ce0062efd590a0c6d49faa7210aa4bc3f64207","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d2e8d6cb_b1405c4b","line":181,"updated":"2022-04-06 13:37:17.000000000","message":"nit: adding new line here is unrelated to your change, might want to revert this :)","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"93b9c5ee7444027ac782b55cba00be95c9ae9bf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bdebc63f_4775a58b","line":181,"in_reply_to":"d2e8d6cb_b1405c4b","updated":"2022-04-12 12:01:23.000000000","message":"Done","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"d25b65a27aa1a906088446e5fc1411d7e568af20","unresolved":true,"context_lines":[{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":180,"context_line":"    :command: share group type"}],"source_content_type":"text/x-rst","patch_set":5,"id":"d7e77a16_e421d6f9","line":180,"updated":"2022-04-13 07:02:59.000000000","message":"Undo this change, this is unrelated to your work and is breaking the docs run :)","commit_id":"05c1432b43779f3cc0d6c41766145773e4666561"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"b32531083095e60da5ea7e6676045a629dacda09","unresolved":false,"context_lines":[{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":180,"context_line":"    :command: share group type"}],"source_content_type":"text/x-rst","patch_set":5,"id":"4f054954_5f3f1a8d","line":180,"in_reply_to":"11c19dc7_d356890e","updated":"2022-04-18 13:53:03.000000000","message":"Done","commit_id":"05c1432b43779f3cc0d6c41766145773e4666561"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"9d86e32316a60881ced5d37e0c324b2c8693191e","unresolved":true,"context_lines":[{"line_number":177,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":".. autoprogram-cliff:: openstack.share.v2"},{"line_number":180,"context_line":"    :command: share group type"}],"source_content_type":"text/x-rst","patch_set":5,"id":"11c19dc7_d356890e","line":180,"in_reply_to":"d7e77a16_e421d6f9","updated":"2022-04-13 07:20:52.000000000","message":"Thanks! tox was working fine on my local setup, so I didn\u0027t checked my code.","commit_id":"05c1432b43779f3cc0d6c41766145773e4666561"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a952b60f5b6365e346d94246fb2b173d428044c3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"396e023b_531d2a45","line":181,"updated":"2022-06-03 19:22:42.000000000","message":"nit: remove the new line; unrelated to the change","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"2652abab08a5cb4c82607249d7b416a944f5bc5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d3894923_761ab221","line":181,"in_reply_to":"396e023b_531d2a45","updated":"2022-06-05 05:42:48.000000000","message":"Done","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":1184,"context_line":"                \"Failed to revert share to snapshot: %s\" % (e)))"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"class MigrationStart(command.Command):"},{"line_number":1188,"context_line":"    \"\"\"Migrates share to a new host (Admin only, Experimental).\"\"\""},{"line_number":1189,"context_line":"    _description \u003d _(\"Migrates share to a new host.\")"},{"line_number":1190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"259f70db_2de1f87e","line":1187,"range":{"start_line":1187,"start_character":6,"end_line":1187,"end_character":20},"updated":"2022-04-05 10:05:44.000000000","message":"nit: I think we could name this ShareMigrationStart to be more cohesive with the rest","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":1184,"context_line":"                \"Failed to revert share to snapshot: %s\" % (e)))"},{"line_number":1185,"context_line":""},{"line_number":1186,"context_line":""},{"line_number":1187,"context_line":"class MigrationStart(command.Command):"},{"line_number":1188,"context_line":"    \"\"\"Migrates share to a new host (Admin only, Experimental).\"\"\""},{"line_number":1189,"context_line":"    _description \u003d _(\"Migrates share to a new host.\")"},{"line_number":1190,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"287f1cee_8e09ddd0","line":1187,"range":{"start_line":1187,"start_character":6,"end_line":1187,"end_character":20},"in_reply_to":"259f70db_2de1f87e","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":1202,"context_line":"                   \"format \u0027host@backend#pool\u0027.\")"},{"line_number":1203,"context_line":"        )"},{"line_number":1204,"context_line":"        parser.add_argument("},{"line_number":1205,"context_line":"            \u0027--force_host_assisted_migration\u0027,"},{"line_number":1206,"context_line":"            \u0027--force-host-assisted-migration\u0027,"},{"line_number":1207,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":1208,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"bee7885f_e366ce8b","line":1205,"range":{"start_line":1205,"start_character":13,"end_line":1205,"end_character":44},"updated":"2022-04-05 10:05:44.000000000","message":"remove all underscore options, we only use hyphens in the OSC :)","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"                   \"format \u0027host@backend#pool\u0027.\")"},{"line_number":1203,"context_line":"        )"},{"line_number":1204,"context_line":"        parser.add_argument("},{"line_number":1205,"context_line":"            \u0027--force_host_assisted_migration\u0027,"},{"line_number":1206,"context_line":"            \u0027--force-host-assisted-migration\u0027,"},{"line_number":1207,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":1208,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"f26e233b_71c3451a","line":1205,"range":{"start_line":1205,"start_character":13,"end_line":1205,"end_character":44},"in_reply_to":"bee7885f_e366ce8b","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":1204,"context_line":"        parser.add_argument("},{"line_number":1205,"context_line":"            \u0027--force_host_assisted_migration\u0027,"},{"line_number":1206,"context_line":"            \u0027--force-host-assisted-migration\u0027,"},{"line_number":1207,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":1208,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1209,"context_line":"            required\u003dFalse,"},{"line_number":1210,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"d6bfdf4b_76762447","line":1207,"range":{"start_line":1207,"start_character":12,"end_line":1207,"end_character":34},"updated":"2022-04-05 10:05:44.000000000","message":"this (and other args as well) should follow the style: metavar\u003d\"\u003cname-of-argument\u003e\"","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":1204,"context_line":"        parser.add_argument("},{"line_number":1205,"context_line":"            \u0027--force_host_assisted_migration\u0027,"},{"line_number":1206,"context_line":"            \u0027--force-host-assisted-migration\u0027,"},{"line_number":1207,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":1208,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1209,"context_line":"            required\u003dFalse,"},{"line_number":1210,"context_line":"            default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"776aa058_e108d563","line":1207,"range":{"start_line":1207,"start_character":12,"end_line":1207,"end_character":34},"in_reply_to":"d6bfdf4b_76762447","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":1206,"context_line":"            \u0027--force-host-assisted-migration\u0027,"},{"line_number":1207,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":1208,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1209,"context_line":"            required\u003dFalse,"},{"line_number":1210,"context_line":"            default\u003dFalse,"},{"line_number":1211,"context_line":"            help\u003d_(\"Enforces the use of the host-assisted migration approach, \""},{"line_number":1212,"context_line":"                   \"which bypasses driver optimizations. Default\u003dFalse.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"83416182_afc95ba9","line":1209,"updated":"2022-04-05 10:05:44.000000000","message":"I believe `required\u003dFalse` is the default for these type of arguments, so in those cases we don\u0027t need to define it and can drop those lines of code :).","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":1206,"context_line":"            \u0027--force-host-assisted-migration\u0027,"},{"line_number":1207,"context_line":"            metavar\u003d\"\u003cTrue|False\u003e\","},{"line_number":1208,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1209,"context_line":"            required\u003dFalse,"},{"line_number":1210,"context_line":"            default\u003dFalse,"},{"line_number":1211,"context_line":"            help\u003d_(\"Enforces the use of the host-assisted migration approach, \""},{"line_number":1212,"context_line":"                   \"which bypasses driver optimizations. Default\u003dFalse.\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"e584b993_4ea5fcbc","line":1209,"in_reply_to":"83416182_afc95ba9","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":1278,"context_line":"            new_share_net \u003d apiutils.find_resource(share_client.share_networks,"},{"line_number":1279,"context_line":"                                                   parsed_args."},{"line_number":1280,"context_line":"                                                   new_share_network)"},{"line_number":1281,"context_line":"            new_share_net_id \u003d new_share_net.id if new_share_net else None"},{"line_number":1282,"context_line":"        new_share_type_id \u003d None"},{"line_number":1283,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1284,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"}],"source_content_type":"text/x-python","patch_set":1,"id":"e50ae599_451a81a4","line":1281,"range":{"start_line":1281,"start_character":48,"end_line":1281,"end_character":74},"updated":"2022-04-05 10:05:44.000000000","message":"remove this; if the share network is not found, the previous line will already throw an error. Additionally, we wouldn\u0027t want to hide that error from the user, they should know that something was not right with the option they provided.","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":1278,"context_line":"            new_share_net \u003d apiutils.find_resource(share_client.share_networks,"},{"line_number":1279,"context_line":"                                                   parsed_args."},{"line_number":1280,"context_line":"                                                   new_share_network)"},{"line_number":1281,"context_line":"            new_share_net_id \u003d new_share_net.id if new_share_net else None"},{"line_number":1282,"context_line":"        new_share_type_id \u003d None"},{"line_number":1283,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1284,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a5637bb_29a671a3","line":1281,"range":{"start_line":1281,"start_character":48,"end_line":1281,"end_character":74},"in_reply_to":"e50ae599_451a81a4","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"819ff131c9f6d0cdc9a76fbac6d150b48c09f5c1","unresolved":true,"context_lines":[{"line_number":1283,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1284,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"},{"line_number":1285,"context_line":"                                                    parsed_args.new_share_type)"},{"line_number":1286,"context_line":"            new_share_type_id \u003d new_share_type.id if new_share_type else None"},{"line_number":1287,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1288,"context_line":"                                       parsed_args.share)"},{"line_number":1289,"context_line":"        share.migration_start(parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"728b28f5_ff8b45c1","line":1286,"range":{"start_line":1286,"start_character":50,"end_line":1286,"end_character":77},"updated":"2022-04-05 10:05:44.000000000","message":"same note as above.","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"6c9177359897ef5fc2c0814a1ab5e0d3640394e1","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1284,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"},{"line_number":1285,"context_line":"                                                    parsed_args.new_share_type)"},{"line_number":1286,"context_line":"            new_share_type_id \u003d new_share_type.id if new_share_type else None"},{"line_number":1287,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1288,"context_line":"                                       parsed_args.share)"},{"line_number":1289,"context_line":"        share.migration_start(parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":1,"id":"cfef373e_ecb63468","line":1286,"range":{"start_line":1286,"start_character":50,"end_line":1286,"end_character":77},"in_reply_to":"728b28f5_ff8b45c1","updated":"2022-04-05 15:11:29.000000000","message":"Done","commit_id":"f4e10039a775ce282cd1f2ef2e60a0d32b1b48f8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f0ce0062efd590a0c6d49faa7210aa4bc3f64207","unresolved":true,"context_lines":[{"line_number":1212,"context_line":"        parser.add_argument("},{"line_number":1213,"context_line":"            \u0027--preserve-metadata\u0027,"},{"line_number":1214,"context_line":"            metavar\u003d\"\u003cpreserve-metadata\u003e\","},{"line_number":1215,"context_line":"            required\u003dTrue,"},{"line_number":1216,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1217,"context_line":"            help\u003d_(\"Enforces migration to preserve all file metadata when \""},{"line_number":1218,"context_line":"                   \"moving its contents. If set to True, host-assisted\""}],"source_content_type":"text/x-python","patch_set":2,"id":"08930a63_c4e38bee","line":1215,"updated":"2022-04-06 13:37:17.000000000","message":"I am wondering how we can best handle these required options here. True/False flags like these could be implemented with `action\u003d\u0027store_true\u0027`, see: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share.py#L310-L316\nHowever, these are usually optional and default to False so the user can run \u0027--preserve-metadata\u0027 instead of \u0027--preserve-metadata True\u0027, which is more user-friendly. But in this case I believe we need the user to explicitly choose True or False so I am wondering what other reviewers are thinking about this???","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e0b53d88f14e7d25076d4c7d18a67efb7f2907b2","unresolved":true,"context_lines":[{"line_number":1212,"context_line":"        parser.add_argument("},{"line_number":1213,"context_line":"            \u0027--preserve-metadata\u0027,"},{"line_number":1214,"context_line":"            metavar\u003d\"\u003cpreserve-metadata\u003e\","},{"line_number":1215,"context_line":"            required\u003dTrue,"},{"line_number":1216,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1217,"context_line":"            help\u003d_(\"Enforces migration to preserve all file metadata when \""},{"line_number":1218,"context_line":"                   \"moving its contents. If set to True, host-assisted\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9c071af3_6b28d193","line":1215,"in_reply_to":"08930a63_c4e38bee","updated":"2022-04-07 14:14:56.000000000","message":"great question; we have chosen the pattern used here already in the v2 shell: https://github.com/openstack/python-manilaclient/blob/08508e5c96cf7ce2892e620a08919d8fd2150a88/manilaclient/v2/shell.py#L1033-L1069","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"f437719457f66555c0d416abdf5f6d625c9a392c","unresolved":false,"context_lines":[{"line_number":1212,"context_line":"        parser.add_argument("},{"line_number":1213,"context_line":"            \u0027--preserve-metadata\u0027,"},{"line_number":1214,"context_line":"            metavar\u003d\"\u003cpreserve-metadata\u003e\","},{"line_number":1215,"context_line":"            required\u003dTrue,"},{"line_number":1216,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":1217,"context_line":"            help\u003d_(\"Enforces migration to preserve all file metadata when \""},{"line_number":1218,"context_line":"                   \"moving its contents. If set to True, host-assisted\""}],"source_content_type":"text/x-python","patch_set":2,"id":"35107a0b_346558ad","line":1215,"in_reply_to":"9c071af3_6b28d193","updated":"2022-04-12 14:39:25.000000000","message":"Done","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f0ce0062efd590a0c6d49faa7210aa4bc3f64207","unresolved":true,"context_lines":[{"line_number":1270,"context_line":"            new_share_net \u003d apiutils.find_resource(share_client.share_networks,"},{"line_number":1271,"context_line":"                                                   parsed_args."},{"line_number":1272,"context_line":"                                                   new_share_network)"},{"line_number":1273,"context_line":"            new_share_net_id \u003d new_share_net.id"},{"line_number":1274,"context_line":"        new_share_type_id \u003d None"},{"line_number":1275,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1276,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"}],"source_content_type":"text/x-python","patch_set":2,"id":"85e6523e_1156d791","line":1273,"updated":"2022-04-06 13:37:17.000000000","message":"nit: you could refactor this further and append the \".id\" to previous line and define new_share_net_id in one go","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"0cf419d6637110840b0b9c17fcc58900a7ce5268","unresolved":false,"context_lines":[{"line_number":1270,"context_line":"            new_share_net \u003d apiutils.find_resource(share_client.share_networks,"},{"line_number":1271,"context_line":"                                                   parsed_args."},{"line_number":1272,"context_line":"                                                   new_share_network)"},{"line_number":1273,"context_line":"            new_share_net_id \u003d new_share_net.id"},{"line_number":1274,"context_line":"        new_share_type_id \u003d None"},{"line_number":1275,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1276,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"}],"source_content_type":"text/x-python","patch_set":2,"id":"d6893136_50d5095d","line":1273,"in_reply_to":"85e6523e_1156d791","updated":"2022-04-12 11:59:06.000000000","message":"Done","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f0ce0062efd590a0c6d49faa7210aa4bc3f64207","unresolved":true,"context_lines":[{"line_number":1275,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1276,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"},{"line_number":1277,"context_line":"                                                    parsed_args.new_share_type)"},{"line_number":1278,"context_line":"            new_share_type_id \u003d new_share_type.id"},{"line_number":1279,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1280,"context_line":"                                       parsed_args.share)"},{"line_number":1281,"context_line":"        share.migration_start(parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"15baa56e_0189137f","line":1278,"updated":"2022-04-06 13:37:17.000000000","message":"nit: same note as above","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"0cf419d6637110840b0b9c17fcc58900a7ce5268","unresolved":false,"context_lines":[{"line_number":1275,"context_line":"        if parsed_args.new_share_type:"},{"line_number":1276,"context_line":"            new_share_type \u003d apiutils.find_resource(share_client.share_types,"},{"line_number":1277,"context_line":"                                                    parsed_args.new_share_type)"},{"line_number":1278,"context_line":"            new_share_type_id \u003d new_share_type.id"},{"line_number":1279,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1280,"context_line":"                                       parsed_args.share)"},{"line_number":1281,"context_line":"        share.migration_start(parsed_args.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7b8a0112_2a870f2d","line":1278,"in_reply_to":"15baa56e_0189137f","updated":"2022-04-12 11:59:06.000000000","message":"Done","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a952b60f5b6365e346d94246fb2b173d428044c3","unresolved":true,"context_lines":[{"line_number":1197,"context_line":"        )"},{"line_number":1198,"context_line":"        parser.add_argument("},{"line_number":1199,"context_line":"            \u0027host\u0027,"},{"line_number":1200,"context_line":"            metavar\u003d\"\u003chost@backend#pool\u003e\","},{"line_number":1201,"context_line":"            help\u003d_(\"Destination host where share will be migrated to. Use the \""},{"line_number":1202,"context_line":"                   \"format \u0027host@backend#pool\u0027.\")"},{"line_number":1203,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"cd59e261_4dbd2a43","line":1200,"range":{"start_line":1200,"start_character":22,"end_line":1200,"end_character":39},"updated":"2022-06-03 19:22:42.000000000","message":"nit: just \"\u003chost\u003e\" should be ok here.","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"2652abab08a5cb4c82607249d7b416a944f5bc5e","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"        )"},{"line_number":1198,"context_line":"        parser.add_argument("},{"line_number":1199,"context_line":"            \u0027host\u0027,"},{"line_number":1200,"context_line":"            metavar\u003d\"\u003chost@backend#pool\u003e\","},{"line_number":1201,"context_line":"            help\u003d_(\"Destination host where share will be migrated to. Use the \""},{"line_number":1202,"context_line":"                   \"format \u0027host@backend#pool\u0027.\")"},{"line_number":1203,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":9,"id":"337265a3_b3cdea40","line":1200,"range":{"start_line":1200,"start_character":22,"end_line":1200,"end_character":39},"in_reply_to":"cd59e261_4dbd2a43","updated":"2022-06-05 05:42:48.000000000","message":"Done","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"75b2b3af1e65fa49bdc5f016121a8a36736c695e","unresolved":true,"context_lines":[{"line_number":1277,"context_line":"                parsed_args.new_share_type).id"},{"line_number":1278,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1279,"context_line":"                                       parsed_args.share)"},{"line_number":1280,"context_line":"        share.migration_start(parsed_args.host,"},{"line_number":1281,"context_line":"                              parsed_args.force_host_assisted_migration,"},{"line_number":1282,"context_line":"                              parsed_args.preserve_metadata,"},{"line_number":1283,"context_line":"                              parsed_args.writable,"}],"source_content_type":"text/x-python","patch_set":9,"id":"7fce5230_486d415c","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":14},"updated":"2022-04-18 12:57:59.000000000","message":"I could be wrong, but shouldn\u0027t this be shares_client.shares.migration_start?\nI\u0027m about to test this but I\u0027m having troubles with my env","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"b32531083095e60da5ea7e6676045a629dacda09","unresolved":true,"context_lines":[{"line_number":1277,"context_line":"                parsed_args.new_share_type).id"},{"line_number":1278,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1279,"context_line":"                                       parsed_args.share)"},{"line_number":1280,"context_line":"        share.migration_start(parsed_args.host,"},{"line_number":1281,"context_line":"                              parsed_args.force_host_assisted_migration,"},{"line_number":1282,"context_line":"                              parsed_args.preserve_metadata,"},{"line_number":1283,"context_line":"                              parsed_args.writable,"}],"source_content_type":"text/x-python","patch_set":9,"id":"e0e8e13a_daaad7a0","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":14},"in_reply_to":"7fce5230_486d415c","updated":"2022-04-18 13:53:03.000000000","message":"In my environment this works `share.migration_start`, it changes the state from available to migrating.(If I understand correctly this is the expected behavior)\n\nFor information:\nshare:\u003cShare: 3063a62d-9062-47f1-a48a-0ef4b8c1a612\u003e\nshare_client.shares: \u003cmanilaclient.v2.shares.ShareManager object at 0x7f7d1b4a32b0\u003e","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"2652abab08a5cb4c82607249d7b416a944f5bc5e","unresolved":false,"context_lines":[{"line_number":1277,"context_line":"                parsed_args.new_share_type).id"},{"line_number":1278,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1279,"context_line":"                                       parsed_args.share)"},{"line_number":1280,"context_line":"        share.migration_start(parsed_args.host,"},{"line_number":1281,"context_line":"                              parsed_args.force_host_assisted_migration,"},{"line_number":1282,"context_line":"                              parsed_args.preserve_metadata,"},{"line_number":1283,"context_line":"                              parsed_args.writable,"}],"source_content_type":"text/x-python","patch_set":9,"id":"aa826bec_2bf1e47a","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":14},"in_reply_to":"882c593a_b680483d","updated":"2022-06-05 05:42:48.000000000","message":"Ack","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a952b60f5b6365e346d94246fb2b173d428044c3","unresolved":true,"context_lines":[{"line_number":1277,"context_line":"                parsed_args.new_share_type).id"},{"line_number":1278,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1279,"context_line":"                                       parsed_args.share)"},{"line_number":1280,"context_line":"        share.migration_start(parsed_args.host,"},{"line_number":1281,"context_line":"                              parsed_args.force_host_assisted_migration,"},{"line_number":1282,"context_line":"                              parsed_args.preserve_metadata,"},{"line_number":1283,"context_line":"                              parsed_args.writable,"}],"source_content_type":"text/x-python","patch_set":9,"id":"882c593a_b680483d","line":1280,"range":{"start_line":1280,"start_character":8,"end_line":1280,"end_character":14},"in_reply_to":"e0e8e13a_daaad7a0","updated":"2022-06-03 19:22:42.000000000","message":"I think Namrata is doing the right thing here, the manila command also does this: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L1121","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"736488d37400be7a8bef7a4e4114e3052130e87c","unresolved":true,"context_lines":[{"line_number":1197,"context_line":"        )"},{"line_number":1198,"context_line":"        parser.add_argument("},{"line_number":1199,"context_line":"            \u0027host\u0027,"},{"line_number":1200,"context_line":"            metavar\u003d\"\u003chost@backend#pool\u003e\","},{"line_number":1201,"context_line":"            help\u003d_(\"Destination host where share will be migrated to. Use the \""},{"line_number":1202,"context_line":"                   \"format \u0027host@backend#pool\u0027.\")"},{"line_number":1203,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"338af142_7b47c2cf","line":1200,"range":{"start_line":1200,"start_character":22,"end_line":1200,"end_character":39},"updated":"2022-06-27 20:10:59.000000000","message":"nit: I think this could be just \u0027host\u0027, the help message provides the format example.","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"7855383095a19d66bbe344c6e296c44389457a7d","unresolved":false,"context_lines":[{"line_number":1197,"context_line":"        )"},{"line_number":1198,"context_line":"        parser.add_argument("},{"line_number":1199,"context_line":"            \u0027host\u0027,"},{"line_number":1200,"context_line":"            metavar\u003d\"\u003chost@backend#pool\u003e\","},{"line_number":1201,"context_line":"            help\u003d_(\"Destination host where share will be migrated to. Use the \""},{"line_number":1202,"context_line":"                   \"format \u0027host@backend#pool\u0027.\")"},{"line_number":1203,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ee1a3fef_201f1ec0","line":1200,"range":{"start_line":1200,"start_character":22,"end_line":1200,"end_character":39},"in_reply_to":"338af142_7b47c2cf","updated":"2022-06-29 08:04:29.000000000","message":"Done","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"}],"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"f0ce0062efd590a0c6d49faa7210aa4bc3f64207","unresolved":true,"context_lines":[{"line_number":41,"context_line":"        self.export_locations_mock \u003d ("},{"line_number":42,"context_line":"            self.app.client_manager.share.share_export_locations"},{"line_number":43,"context_line":"        )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.export_locations_mock.reset_mock()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.projects_mock \u003d self.app.client_manager.identity.projects"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb16d047_e7115f63","line":44,"updated":"2022-04-06 13:37:17.000000000","message":"nit: undo the removing/adding new lines since they are unrelated to your changes :)","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"0cf419d6637110840b0b9c17fcc58900a7ce5268","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.export_locations_mock \u003d ("},{"line_number":42,"context_line":"            self.app.client_manager.share.share_export_locations"},{"line_number":43,"context_line":"        )"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        self.export_locations_mock.reset_mock()"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        self.projects_mock \u003d self.app.client_manager.identity.projects"}],"source_content_type":"text/x-python","patch_set":2,"id":"67485d90_c5715125","line":44,"in_reply_to":"eb16d047_e7115f63","updated":"2022-04-12 11:59:06.000000000","message":"Done","commit_id":"94c0f570b28dbad1b8449e31e8d2491650c59401"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a952b60f5b6365e346d94246fb2b173d428044c3","unresolved":true,"context_lines":[{"line_number":107,"context_line":"            (\u0027share_type\u0027, self.share_type.id)"},{"line_number":108,"context_line":"        ]"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":111,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        self.shares_mock.create.assert_called_with("}],"source_content_type":"text/x-python","patch_set":9,"id":"1f9c7f9e_f0ed154b","line":110,"updated":"2022-06-03 19:22:42.000000000","message":"nit: removing the empty lines is unrelated to the change, I\u0027d undo these.","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a952b60f5b6365e346d94246fb2b173d428044c3","unresolved":true,"context_lines":[{"line_number":1832,"context_line":"            osc_exceptions.CommandError, self.cmd.take_action, parsed_args)"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"class TestShareMigrationStart(TestShare):"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    def setUp(self):"},{"line_number":1838,"context_line":"        super(TestShareMigrationStart, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"d0787977_d414e160","line":1835,"updated":"2022-06-03 19:22:42.000000000","message":"Maybe add one exception case test also, missing some required arguments for example :)","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"2652abab08a5cb4c82607249d7b416a944f5bc5e","unresolved":false,"context_lines":[{"line_number":1832,"context_line":"            osc_exceptions.CommandError, self.cmd.take_action, parsed_args)"},{"line_number":1833,"context_line":""},{"line_number":1834,"context_line":""},{"line_number":1835,"context_line":"class TestShareMigrationStart(TestShare):"},{"line_number":1836,"context_line":""},{"line_number":1837,"context_line":"    def setUp(self):"},{"line_number":1838,"context_line":"        super(TestShareMigrationStart, self).setUp()"}],"source_content_type":"text/x-python","patch_set":9,"id":"77399fb6_9fc98508","line":1835,"in_reply_to":"d0787977_d414e160","updated":"2022-06-05 05:42:48.000000000","message":"Done","commit_id":"9bd0157af0fa9a373d09240adf499c8fd710b78a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"ece598a8a0b1bc88608bed76fb92758659840ad2","unresolved":true,"context_lines":[{"line_number":1855,"context_line":"        # Get the command objects to test"},{"line_number":1856,"context_line":"        self.cmd \u003d osc_shares.ShareMigrationStart(self.app, None)"},{"line_number":1857,"context_line":""},{"line_number":1858,"context_line":"    def test_migration_start_with_new_share_type(self):"},{"line_number":1859,"context_line":"        \"\"\"Test with new_share_type\"\"\""},{"line_number":1860,"context_line":"        arglist \u003d ["},{"line_number":1861,"context_line":"            self._share.id,"}],"source_content_type":"text/x-python","patch_set":13,"id":"125bb64c_54236fd8","line":1858,"range":{"start_line":1858,"start_character":4,"end_line":1858,"end_character":55},"updated":"2022-06-09 20:06:39.000000000","message":"this and the below test could be combined into a ddt, but I would not say this is a must.","commit_id":"8dbdc2a0bf5477489b3f24995c3ce8892cae945c"}]}