)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4bd17134d017851de2f1a127e15a577081e3af80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6088b6d9_3eecd6e4","updated":"2022-05-25 18:31:30.000000000","message":"Looking good and CI is happy. Thank you, Goutham","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"acf9b89bc7d05be660372f7330f9e19926dfabcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ad564ba8_2a5c734f","updated":"2022-05-18 13:08:18.000000000","message":"Thanks Goutham, that makes sense. Looks good to me!","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97dadbdb3d8c1647dabe812ba1fcb01db7cc82f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e44c2bf3_d87a434e","updated":"2022-05-18 12:49:53.000000000","message":"Thanks Maari - response inline. ","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c5077f66481f526513a58f249bb5718136567bd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9447bd3a_0379f45b","updated":"2022-05-18 09:17:13.000000000","message":"Thanks for working on this Goutham! I left a note inline, curious to get your thoughts on it :) ","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"c5077f66481f526513a58f249bb5718136567bd3","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        if detail:"},{"line_number":165,"context_line":"            cmd +\u003d \u0027--detail\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        pools \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"b234a0e4_d8a21456","line":167,"updated":"2022-05-18 09:17:13.000000000","message":"Why not just call self.listing_result() from the tests straight? I am just wondering if this will be reused for many more tests in the future? If not, do we really want/need this to be in the base class? If yes, ignore my thinkos :D","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"97dadbdb3d8c1647dabe812ba1fcb01db7cc82f4","unresolved":true,"context_lines":[{"line_number":164,"context_line":"        if detail:"},{"line_number":165,"context_line":"            cmd +\u003d \u0027--detail\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        pools \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"e9a2c916_a3d39f53","line":167,"in_reply_to":"b234a0e4_d8a21456","updated":"2022-05-18 12:49:53.000000000","message":"We absolutely could - and we sorta discussed this while live coding this patch. I wanted to show folks the base.py file and the reusability of functions here. I suspect we\u0027ll reuse a method like this to do this: \n\nhttps://github.com/openstack/manila-tempest-plugin/blob/45cd35173701c626dd35b846ae610a01924756ae/manila_tempest_tests/tests/api/base.py#L628-L646 \n\nBut that\u0027s just future proofing when we want to write share network subnet tests and share replica tests. If this is an antipattern, i can drop it...","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"acf9b89bc7d05be660372f7330f9e19926dfabcb","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        if detail:"},{"line_number":165,"context_line":"            cmd +\u003d \u0027--detail\u0027"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        pools \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        return pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"16a63111_8ad654ed","line":167,"in_reply_to":"e9a2c916_a3d39f53","updated":"2022-05-18 13:08:18.000000000","message":"Ah, I see, then it absolutely makes sense to have it here, I was honestly curious where else would we use it and didn\u0027t make the connection :)","commit_id":"cb918d3027e6c8e7ed452259f498571bc060ec0d"}]}