)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a13328be5e15df0a2f31605c53d70b253fd3c5ef","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-18 12:32:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for \"os share limits show\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifca6fb788369b7b02ffae59cedae5604ca6335af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"15909e44_55c22519","line":8,"updated":"2022-05-19 15:24:33.000000000","message":"Are you missing a \"Co-Authored-By:\"?","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"3edc512dc24155cce4a6304f09f794e6d34c7ef2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-18 12:32:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for \"os share limits show\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifca6fb788369b7b02ffae59cedae5604ca6335af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dd1afa78_eae56b5a","line":8,"in_reply_to":"15909e44_55c22519","updated":"2022-05-19 18:27:15.000000000","message":"Not really, Caique got the share limits task and I worked on the share network subnet one. :)","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"d90ffb5501298b8ae2948de461413ecca4091156","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2022-05-18 12:32:51 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add functional tests for \"os share limits show\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ifca6fb788369b7b02ffae59cedae5604ca6335af"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"15a76e6d_6f064427","line":8,"in_reply_to":"dd1afa78_eae56b5a","updated":"2022-05-19 19:28:54.000000000","message":"Thank you Eduardo for providing the env.","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3fe42afe038de242846060f9a6599861e50fb3c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0bda8a73_f45a8ca8","updated":"2022-05-19 15:22:49.000000000","message":"Thanks for working on this; i\u0027ve a comment inline.. ","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"78cca16711db453a85c74ef079ffa2b91152f45e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"affe35db_e0e29b3a","updated":"2022-05-19 19:44:05.000000000","message":"LGTM, minor comment inline.. ","commit_id":"21d35faf03f7746757e1386955766a55be42154f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8d7447f29744585eddd029c5c1ede4d83249ec0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bc375bbc_499237dd","updated":"2022-05-24 18:40:36.000000000","message":"LGTM, thanks Caique!","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34bb22da14dfa97128a05aa1e0af32bfdf1cab6a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e07b37a1_2b5f73c2","updated":"2022-05-25 18:33:59.000000000","message":"Okay, so I think we can use a follow-up patch approach here.\nLooking good, thank you very much, Caique!","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ae3c68edc08f41fea6e12713f3dbc1b7e8ee1aa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f96043a6_e39b04ad","updated":"2022-05-24 19:38:57.000000000","message":"Thanks Caique! I left one note inline, otherwise looks good to me!  ","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"43a495b26ac488f2e8394a2a152ece76e16a192a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a3ca7ade_487b7588","updated":"2022-05-25 18:20:34.000000000","message":"Validation passed, thanks.","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"40f23ad6f8938d935ecbb0132571f18c4326a199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ba043f17_cbdae145","updated":"2022-05-24 14:58:27.000000000","message":"recheck","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a808c282bf8192df921464ded710b9c5d476c67","unresolved":true,"context_lines":[{"line_number":153,"context_line":"        return share_object"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def limits_show(self, absolute\u003dFalse, rate\u003dFalse):"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        cmd \u003d \u0027limits show \u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if absolute:"},{"line_number":160,"context_line":"            cmd +\u003d \u0027--absolute\u0027"},{"line_number":161,"context_line":"        if rate:"},{"line_number":162,"context_line":"            cmd +\u003d \u0027--rate\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        limits \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return limits"}],"source_content_type":"text/x-python","patch_set":3,"id":"cd0d7be1_5857d67d","line":166,"range":{"start_line":156,"start_character":0,"end_line":166,"end_character":21},"updated":"2022-05-19 15:24:00.000000000","message":"Do we expect this method to be reused? if not, we could just invoke:\n\n self.listing_result(..) \n\nfrom the test methods..","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"1d061123426d5915fcc534da627bac0e64878b90","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        return share_object"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def limits_show(self, absolute\u003dFalse, rate\u003dFalse):"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        cmd \u003d \u0027limits show \u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if absolute:"},{"line_number":160,"context_line":"            cmd +\u003d \u0027--absolute\u0027"},{"line_number":161,"context_line":"        if rate:"},{"line_number":162,"context_line":"            cmd +\u003d \u0027--rate\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        limits \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return limits"}],"source_content_type":"text/x-python","patch_set":3,"id":"e20e38b3_3243e609","line":166,"range":{"start_line":156,"start_character":0,"end_line":166,"end_character":21},"in_reply_to":"131cc7ac_50208ed2","updated":"2022-05-20 13:28:51.000000000","message":"Now I see, thank you!","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"78cca16711db453a85c74ef079ffa2b91152f45e","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        return share_object"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def limits_show(self, absolute\u003dFalse, rate\u003dFalse):"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        cmd \u003d \u0027limits show \u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if absolute:"},{"line_number":160,"context_line":"            cmd +\u003d \u0027--absolute\u0027"},{"line_number":161,"context_line":"        if rate:"},{"line_number":162,"context_line":"            cmd +\u003d \u0027--rate\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        limits \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return limits"}],"source_content_type":"text/x-python","patch_set":3,"id":"131cc7ac_50208ed2","line":166,"range":{"start_line":156,"start_character":0,"end_line":166,"end_character":21},"in_reply_to":"8b445114_b35684bb","updated":"2022-05-19 19:44:05.000000000","message":"Hi, nope.. i meant, we could remove this method from this base class and call self.listing_result() directly from the tests. \n\nI say this because we may not need this method for other tests; methods in this class are meant to be reused by multiple tests..","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"d90ffb5501298b8ae2948de461413ecca4091156","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        return share_object"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def limits_show(self, absolute\u003dFalse, rate\u003dFalse):"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        cmd \u003d \u0027limits show \u0027"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if absolute:"},{"line_number":160,"context_line":"            cmd +\u003d \u0027--absolute\u0027"},{"line_number":161,"context_line":"        if rate:"},{"line_number":162,"context_line":"            cmd +\u003d \u0027--rate\u0027"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        limits \u003d self.listing_result(\u0027share\u0027, cmd)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return limits"}],"source_content_type":"text/x-python","patch_set":3,"id":"8b445114_b35684bb","line":166,"range":{"start_line":156,"start_character":0,"end_line":166,"end_character":21},"in_reply_to":"cd0d7be1_5857d67d","updated":"2022-05-19 19:28:54.000000000","message":"Thank you Goutham for you review. Let me know if I understood your point correctly","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"}],"manilaclient/tests/functional/osc/test_share_limits.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3fe42afe038de242846060f9a6599861e50fb3c5","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        limits \u003d self.limits_show(rate\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        if len(limits) \u003e 0:"},{"line_number":35,"context_line":"            self.assertTableStruct(limits, ["},{"line_number":36,"context_line":"                \u0027Verb\u0027,"},{"line_number":37,"context_line":"                \u0027Regex\u0027,"},{"line_number":38,"context_line":"                \u0027URI\u0027,"},{"line_number":39,"context_line":"                \u0027Value\u0027,"},{"line_number":40,"context_line":"                \u0027Remaining\u0027,"},{"line_number":41,"context_line":"                \u0027Unit\u0027,"},{"line_number":42,"context_line":"                \u0027Next Available\u0027"},{"line_number":43,"context_line":"            ])"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            self.assertEqual([], limits)"}],"source_content_type":"text/x-python","patch_set":3,"id":"94679ffb_5e2b9526","line":43,"range":{"start_line":34,"start_character":8,"end_line":43,"end_character":14},"updated":"2022-05-19 15:22:49.000000000","message":"One thing we could do is add \"--print-empty\" to the command so we could always assert the table structure.. \n\n\n$ openstack share limits show --rate --print-empty\n+------+-------+-----+-------+-----------+------+----------------+\n| Verb | Regex | URI | Value | Remaining | Unit | Next Available |\n+------+-------+-----+-------+-----------+------+----------------+\n+------+-------+-----+-------+-----------+------+----------------+","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"d90ffb5501298b8ae2948de461413ecca4091156","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        limits \u003d self.limits_show(rate\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        if len(limits) \u003e 0:"},{"line_number":35,"context_line":"            self.assertTableStruct(limits, ["},{"line_number":36,"context_line":"                \u0027Verb\u0027,"},{"line_number":37,"context_line":"                \u0027Regex\u0027,"},{"line_number":38,"context_line":"                \u0027URI\u0027,"},{"line_number":39,"context_line":"                \u0027Value\u0027,"},{"line_number":40,"context_line":"                \u0027Remaining\u0027,"},{"line_number":41,"context_line":"                \u0027Unit\u0027,"},{"line_number":42,"context_line":"                \u0027Next Available\u0027"},{"line_number":43,"context_line":"            ])"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            self.assertEqual([], limits)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e2c8d671_88caf70b","line":43,"range":{"start_line":34,"start_character":8,"end_line":43,"end_character":14},"in_reply_to":"869a0384_0c090ee6","updated":"2022-05-19 19:28:54.000000000","message":"Thank you Goutham and Eduardo. Comments addressed","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"3edc512dc24155cce4a6304f09f794e6d34c7ef2","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        limits \u003d self.limits_show(rate\u003dTrue)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        if len(limits) \u003e 0:"},{"line_number":35,"context_line":"            self.assertTableStruct(limits, ["},{"line_number":36,"context_line":"                \u0027Verb\u0027,"},{"line_number":37,"context_line":"                \u0027Regex\u0027,"},{"line_number":38,"context_line":"                \u0027URI\u0027,"},{"line_number":39,"context_line":"                \u0027Value\u0027,"},{"line_number":40,"context_line":"                \u0027Remaining\u0027,"},{"line_number":41,"context_line":"                \u0027Unit\u0027,"},{"line_number":42,"context_line":"                \u0027Next Available\u0027"},{"line_number":43,"context_line":"            ])"},{"line_number":44,"context_line":"        else:"},{"line_number":45,"context_line":"            self.assertEqual([], limits)"}],"source_content_type":"text/x-python","patch_set":3,"id":"869a0384_0c090ee6","line":43,"range":{"start_line":34,"start_character":8,"end_line":43,"end_character":14},"in_reply_to":"94679ffb_5e2b9526","updated":"2022-05-19 18:27:15.000000000","message":"Goutham +1","commit_id":"6b53a295136f0b6277e12fbaf0896133c459786e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ae3c68edc08f41fea6e12713f3dbc1b7e8ee1aa4","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from manilaclient.tests.functional.osc import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ListSharePoolsTestCase(base.OSCClientTestBase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_limits_show_absolute(self):"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8cbd50d9_bfadd049","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":20},"updated":"2022-05-24 19:38:57.000000000","message":"Limits :)","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"34bb22da14dfa97128a05aa1e0af32bfdf1cab6a","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from manilaclient.tests.functional.osc import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ListSharePoolsTestCase(base.OSCClientTestBase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_limits_show_absolute(self):"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ce023c39_b31510b0","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":20},"in_reply_to":"8cbd50d9_bfadd049","updated":"2022-05-25 18:33:59.000000000","message":"++... Could you please propose a follow-up change addressing this comment, Caique?","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"e2abc19f0d28a1c1e7ff3f82935fee8b97ca7b50","unresolved":true,"context_lines":[{"line_number":16,"context_line":"from manilaclient.tests.functional.osc import base"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ListSharePoolsTestCase(base.OSCClientTestBase):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_limits_show_absolute(self):"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"212ddddb_f08435e2","line":19,"range":{"start_line":19,"start_character":15,"end_line":19,"end_character":20},"in_reply_to":"ce023c39_b31510b0","updated":"2022-05-25 18:40:34.000000000","message":"Sure! Thank you guys for the reviews.","commit_id":"4a2857a314c26d6baa542c48b49350f4164bb8b8"}]}