)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9f78fbc5_cd09af37","updated":"2022-05-19 19:39:20.000000000","message":"Thanks Carlos/Vida, please see some comments inline","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"eabd252f796f208eb49322797cb90606d7a875f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"31256b5c_a89468d7","updated":"2022-05-27 17:37:59.000000000","message":"Thank you for reviewing, Goutham! :)\nPlease check changes inline","commit_id":"64d9c2a6d787c875fcff59f69270120c93fcdcd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b4580310d07b9d16cda77401ea1116a8ba62b892","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5828a695_cbdde4ce","updated":"2022-06-29 09:34:25.000000000","message":"can you rebase, Carlos","commit_id":"64d9c2a6d787c875fcff59f69270120c93fcdcd3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0d6baa2d30b52d49fee086b61acd53541e2462dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"729f2c90_887f6c4f","updated":"2022-06-17 22:41:59.000000000","message":"recheck\nno logs provided on the functional tests","commit_id":"64d9c2a6d787c875fcff59f69270120c93fcdcd3"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4fc43a98ec778b8d99a5efa67877b515768584f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fd143d5d_efb7c8fb","in_reply_to":"5828a695_cbdde4ce","updated":"2022-06-29 15:50:38.000000000","message":"Done. I\u0027ll just take a look at the logs again and sort out possible failures","commit_id":"64d9c2a6d787c875fcff59f69270120c93fcdcd3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6ffced2ea73815aa1ad670a8ae9c2b8bb0fe78f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"85f6d1db_79871527","updated":"2022-07-25 16:41:05.000000000","message":"thanks, LGTM","commit_id":"952071066919e1df50a06b1d56d343a1177770af"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"c9809b3b322988dc2f43affb9dc75a829949694c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"3951c59b_94f2323a","updated":"2022-07-28 18:10:02.000000000","message":"LGTM, thanks!","commit_id":"27a8a06dd9a8c7186965d6c94d0854f5096a6630"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"16bf99862ce356c9e6f7df6b71f0a42d52164deb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"49a59002_1da4a551","updated":"2022-08-08 14:10:26.000000000","message":"LGTM, thanks!","commit_id":"27a8a06dd9a8c7186965d6c94d0854f5096a6630"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"786ed12e5c86c1ac6adf69703430188da522c68f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cc6a9ce1_b06488b7","updated":"2022-07-25 21:03:36.000000000","message":"Please check the latest PS :)","commit_id":"27a8a06dd9a8c7186965d6c94d0854f5096a6630"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"faf28b89b12ca8a692a32f502cf6e936d83c3960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"890a36d0_f537c0a0","updated":"2022-07-25 21:03:25.000000000","message":"Thanks for the review\nRebased and fixed the nit","commit_id":"27a8a06dd9a8c7186965d6c94d0854f5096a6630"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3514fb20b007f3ee3263601744a412ec38c4bdfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"afd27c95_c80e09b8","updated":"2022-07-26 14:11:32.000000000","message":"Thanks, LGTM","commit_id":"27a8a06dd9a8c7186965d6c94d0854f5096a6630"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":true,"context_lines":[{"line_number":169,"context_line":"        if not public:"},{"line_number":170,"context_line":"            cmd \u003d cmd + f\u0027 --public {public} \u0027"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if add_cleanup:"},{"line_number":175,"context_line":"            self.addCleanup("}],"source_content_type":"text/x-python","patch_set":2,"id":"ffc486e9_29383b77","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":20},"updated":"2022-05-19 19:39:20.000000000","message":"share_type_obj?","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c2cbdaaabcdfd4a782b8ff100eeaa281d39c0c9","unresolved":false,"context_lines":[{"line_number":169,"context_line":"        if not public:"},{"line_number":170,"context_line":"            cmd \u003d cmd + f\u0027 --public {public} \u0027"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"        if add_cleanup:"},{"line_number":175,"context_line":"            self.addCleanup("}],"source_content_type":"text/x-python","patch_set":2,"id":"98168a7f_ca2ce523","line":172,"range":{"start_line":172,"start_character":8,"end_line":172,"end_character":20},"in_reply_to":"ffc486e9_29383b77","updated":"2022-05-27 17:37:36.000000000","message":"Makes sense... Pertains to the share group type changes though 😄\nWill modify it there","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":true,"context_lines":[{"line_number":178,"context_line":"        return share_object"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def share_group_type_access_create(self, group_type, project,"},{"line_number":181,"context_line":"                                       add_cleanup\u003dTrue):"},{"line_number":182,"context_line":"        cmd \u003d (f\u0027group type access create \u0027"},{"line_number":183,"context_line":"               f\u0027{group_type} \u0027"},{"line_number":184,"context_line":"               f\u0027{project} \u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"4c23ebc0_f59d8e25","line":181,"range":{"start_line":181,"start_character":39,"end_line":181,"end_character":55},"updated":"2022-05-19 19:39:20.000000000","message":"unused","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c2cbdaaabcdfd4a782b8ff100eeaa281d39c0c9","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        return share_object"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def share_group_type_access_create(self, group_type, project,"},{"line_number":181,"context_line":"                                       add_cleanup\u003dTrue):"},{"line_number":182,"context_line":"        cmd \u003d (f\u0027group type access create \u0027"},{"line_number":183,"context_line":"               f\u0027{group_type} \u0027"},{"line_number":184,"context_line":"               f\u0027{project} \u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d2ed67b4_d0f88ab4","line":181,"range":{"start_line":181,"start_character":39,"end_line":181,"end_character":55},"in_reply_to":"4c23ebc0_f59d8e25","updated":"2022-05-27 17:37:36.000000000","message":"Done","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a6ffced2ea73815aa1ad670a8ae9c2b8bb0fe78f","unresolved":true,"context_lines":[{"line_number":333,"context_line":"        cmd \u003d (f\u0027group type create \u0027"},{"line_number":334,"context_line":"               f\u0027{name} \u0027"},{"line_number":335,"context_line":"               f\u0027{share_types} \u0027"},{"line_number":336,"context_line":"               )"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        if group_specs:"},{"line_number":339,"context_line":"            cmd \u003d cmd + f\u0027 --group_specs {group_specs} \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"53c6fda0_daffb00c","line":336,"range":{"start_line":336,"start_character":15,"end_line":336,"end_character":16},"updated":"2022-07-25 16:41:05.000000000","message":"nit: end on previous line","commit_id":"952071066919e1df50a06b1d56d343a1177770af"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"faf28b89b12ca8a692a32f502cf6e936d83c3960","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        cmd \u003d (f\u0027group type create \u0027"},{"line_number":334,"context_line":"               f\u0027{name} \u0027"},{"line_number":335,"context_line":"               f\u0027{share_types} \u0027"},{"line_number":336,"context_line":"               )"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        if group_specs:"},{"line_number":339,"context_line":"            cmd \u003d cmd + f\u0027 --group_specs {group_specs} \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"7c5f6180_9daa123e","line":336,"range":{"start_line":336,"start_character":15,"end_line":336,"end_character":16},"in_reply_to":"53c6fda0_daffb00c","updated":"2022-07-25 21:03:25.000000000","message":"Done","commit_id":"952071066919e1df50a06b1d56d343a1177770af"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"16bf99862ce356c9e6f7df6b71f0a42d52164deb","unresolved":true,"context_lines":[{"line_number":365,"context_line":"        if not public:"},{"line_number":366,"context_line":"            cmd \u003d cmd + f\u0027 --public {public} \u0027"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        if add_cleanup:"},{"line_number":371,"context_line":"            self.addCleanup("}],"source_content_type":"text/x-python","patch_set":7,"id":"5e308872_286ba5d6","line":368,"updated":"2022-08-08 14:10:26.000000000","message":"NIT share_group_object","commit_id":"27a8a06dd9a8c7186965d6c94d0854f5096a6630"}],"manilaclient/tests/functional/osc/test_share_group_type_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def _create_group_type_and_get_name(self):"},{"line_number":22,"context_line":"        share_group_type_name \u003d data_utils.rand_name("},{"line_number":23,"context_line":"            \u0027test_share_group_type_create\u0027)"},{"line_number":24,"context_line":"        self.create_share_group_type("},{"line_number":25,"context_line":"            name\u003dshare_group_type_name, share_types\u003d\u0027dhss_false\u0027,"},{"line_number":26,"context_line":"            public\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2775b93f_d881035e","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":41},"updated":"2022-05-19 19:39:20.000000000","message":"for consistency: autotest-share-group-type\n\n\"autotest\" is a common prefix in functional tests","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c2cbdaaabcdfd4a782b8ff100eeaa281d39c0c9","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def _create_group_type_and_get_name(self):"},{"line_number":22,"context_line":"        share_group_type_name \u003d data_utils.rand_name("},{"line_number":23,"context_line":"            \u0027test_share_group_type_create\u0027)"},{"line_number":24,"context_line":"        self.create_share_group_type("},{"line_number":25,"context_line":"            name\u003dshare_group_type_name, share_types\u003d\u0027dhss_false\u0027,"},{"line_number":26,"context_line":"            public\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ac000b7d_3cca1ec4","line":23,"range":{"start_line":23,"start_character":13,"end_line":23,"end_character":41},"in_reply_to":"2775b93f_d881035e","updated":"2022-05-27 17:37:36.000000000","message":"Done","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        self.create_share_group_type("},{"line_number":25,"context_line":"            name\u003dshare_group_type_name, share_types\u003d\u0027dhss_false\u0027,"},{"line_number":26,"context_line":"            public\u003dFalse)"},{"line_number":27,"context_line":"        return share_group_type_name"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_share_group_type_access_create(self):"},{"line_number":30,"context_line":"        share_group_type_name \u003d self._create_group_type_and_get_name()"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8d0541b_766283bd","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":36},"updated":"2022-05-19 19:39:20.000000000","message":"nit: seems like this method exists to just override the group type name.. why not just call the \"create_share_group_type\" method in the tests, and grab the name from the share group type object returned?","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c2cbdaaabcdfd4a782b8ff100eeaa281d39c0c9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        self.create_share_group_type("},{"line_number":25,"context_line":"            name\u003dshare_group_type_name, share_types\u003d\u0027dhss_false\u0027,"},{"line_number":26,"context_line":"            public\u003dFalse)"},{"line_number":27,"context_line":"        return share_group_type_name"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_share_group_type_access_create(self):"},{"line_number":30,"context_line":"        share_group_type_name \u003d self._create_group_type_and_get_name()"}],"source_content_type":"text/x-python","patch_set":2,"id":"0c4b4c6e_ee8918b2","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":36},"in_reply_to":"e8d0541b_766283bd","updated":"2022-05-27 17:37:36.000000000","message":"Makes sense too. Thanks!","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":true,"context_lines":[{"line_number":33,"context_line":"            \u0027share\u0027, f\u0027group type access list {share_group_type_name}\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(0, len(access_list))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        project_name \u003d \u0027demo\u0027"},{"line_number":37,"context_line":"        self.share_group_type_access_create("},{"line_number":38,"context_line":"            share_group_type_name, project_name)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"99779ebd_84153345","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":29},"updated":"2022-05-19 19:39:20.000000000","message":"while this is technically okay for the API, the service only recognizes project IDs  while enforcing these accesses. \n\nOne way to grab your own project ID:\n\n        cmd_output \u003d json.loads(self.openstack(\u0027token issue -f json \u0027))\n        auth_project_id \u003d cmd_output[\u0027project_id\u0027]","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c2cbdaaabcdfd4a782b8ff100eeaa281d39c0c9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \u0027share\u0027, f\u0027group type access list {share_group_type_name}\u0027)"},{"line_number":34,"context_line":"        self.assertEqual(0, len(access_list))"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        project_name \u003d \u0027demo\u0027"},{"line_number":37,"context_line":"        self.share_group_type_access_create("},{"line_number":38,"context_line":"            share_group_type_name, project_name)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1d47fea4_2ecad2c7","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":29},"in_reply_to":"99779ebd_84153345","updated":"2022-05-27 17:37:36.000000000","message":"Sure, thank you :)","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e5ed1e98a821f8c2e16426ff6f3135c50b924f03","unresolved":true,"context_lines":[{"line_number":79,"context_line":"            \u0027share\u0027, f\u0027group type access list {share_group_type_name}\u0027)"},{"line_number":80,"context_line":"        self.assertEqual(0, len(access_list))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        project_name \u003d \u0027demo\u0027"},{"line_number":83,"context_line":"        self.share_group_type_access_create("},{"line_number":84,"context_line":"            share_group_type_name, project_name)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        share_group_type_access_list \u003d self.listing_result("},{"line_number":87,"context_line":"            \u0027share\u0027, f\u0027group type access list {share_group_type_name}\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.assertEqual(1, len(share_group_type_access_list))"},{"line_number":90,"context_line":"        self.assertTableStruct(access_list, [\u0027Project ID\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"5898c1bb_73081112","line":87,"range":{"start_line":82,"start_character":0,"end_line":87,"end_character":71},"updated":"2022-05-19 19:39:20.000000000","message":"maybe before doing this, check if the \"share group type list\" command hides the share group type in question..","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2c2cbdaaabcdfd4a782b8ff100eeaa281d39c0c9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            \u0027share\u0027, f\u0027group type access list {share_group_type_name}\u0027)"},{"line_number":80,"context_line":"        self.assertEqual(0, len(access_list))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        project_name \u003d \u0027demo\u0027"},{"line_number":83,"context_line":"        self.share_group_type_access_create("},{"line_number":84,"context_line":"            share_group_type_name, project_name)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        share_group_type_access_list \u003d self.listing_result("},{"line_number":87,"context_line":"            \u0027share\u0027, f\u0027group type access list {share_group_type_name}\u0027)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.assertEqual(1, len(share_group_type_access_list))"},{"line_number":90,"context_line":"        self.assertTableStruct(access_list, [\u0027Project ID\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"cae63620_54c6e680","line":87,"range":{"start_line":82,"start_character":0,"end_line":87,"end_character":71},"in_reply_to":"5898c1bb_73081112","updated":"2022-05-27 17:37:36.000000000","message":"Done","commit_id":"a694c5351217d164ed28a2863317a0017f2b9e0e"}]}