)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Ashley Rodriguez \u003cashrod98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-19 14:05:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OSC] Add OSC Functional Tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds osc functional tests for share snapshot instances"},{"line_number":10,"context_line":"show, list, and set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"802ccb7f_248e0a72","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"updated":"2022-05-19 20:09:24.000000000","message":"the title of the commit must be a bit more specific, especially because we\u0027ve so many patches adding functional tests.. perhaps:\n\n\"Functional tests for OSC snapshot instances\" ?","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ashley Rodriguez \u003cashrod98@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-05-19 14:05:50 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OSC] Add OSC Functional Tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adds osc functional tests for share snapshot instances"},{"line_number":10,"context_line":"show, list, and set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"c2936218_5bac1f1c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":30},"in_reply_to":"802ccb7f_248e0a72","updated":"2022-05-26 20:37:50.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"25ade560d23cd06f0574fd9853a2f75758d34287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ef67d1a2_47f5914b","updated":"2022-05-20 19:39:45.000000000","message":"Thanks for the patch Ashley, I left my comments inline.","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e453a08_be1f01b4","updated":"2022-05-19 20:09:24.000000000","message":"Thanks for working on this, some comments inline.. ","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"71c02e643b8e8c6b79bae253d23803bccf5fef94","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"460302db_764a2941","updated":"2022-05-31 14:35:31.000000000","message":"Hi Ashley, code looks good to me. Zuul is failing, but it does not seem to be related to the change, so I will just recheck before giving a +1.","commit_id":"0734f6e0b0195fe9d60468384e75ed985dec3869"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"2d30d8faa00ea84fe74f70f9f35f198a450c8501","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ecc6aec_64c7a72f","updated":"2022-05-31 14:41:54.000000000","message":"recheck","commit_id":"0734f6e0b0195fe9d60468384e75ed985dec3869"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10df5f3c2973d4b01c6e142922a1f4f245114eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"3f1fa57b_48d2f1b3","updated":"2022-07-18 11:38:12.000000000","message":"LGTM, lets discuss about the comment inline. Thanks Ashley!","commit_id":"5485b4039db4a346c60a2ed5fe37a60fe397502f"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"71bfc855630f87284ca209be827cb17d0c75c051","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dce40f38_b1bda696","updated":"2022-07-20 10:40:17.000000000","message":"LGTM","commit_id":"0b37c9a035fec09be2120bac8bfccbe941b39e5f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8653017803331c532cccf6ffd2d1ec3c55996ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"57a6bbe2_81a703d7","updated":"2022-07-28 18:17:05.000000000","message":"Confused by your last update; question inline","commit_id":"aa80ae2f17e4776d57f31aa9cdd56c334cba9f66"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b23c96a7c18c68583b0af721ae43f74e19e1d030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"611822da_c73b8fb6","updated":"2024-02-29 12:40:53.000000000","message":"LGTM, thank you for working on this change","commit_id":"3628f3d498576f335c0173a3d6a549942d3df9ed"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"e56d4eea89d04a3b6ef3176407d0b5059afb43f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"ff7a7ac2_164314a3","updated":"2024-02-26 17:22:36.000000000","message":"recheck outdated log","commit_id":"3628f3d498576f335c0173a3d6a549942d3df9ed"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":true,"context_lines":[{"line_number":172,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":173,"context_line":"        if share_group:"},{"line_number":174,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":175,"context_line":"        cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":178,"context_line":"        self._wait_for_object_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"5b5912db_d445fbad","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":29},"updated":"2022-05-19 20:09:24.000000000","message":"This may not be useful universally... line 178-179 does this already, and i\u0027m modifying it here: https://review.opendev.org/c/openstack/python-manilaclient/+/842430/1/manilaclient/tests/functional/osc/base.py\n\nYou may not always want to create a valid share.","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":false,"context_lines":[{"line_number":172,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":173,"context_line":"        if share_group:"},{"line_number":174,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":175,"context_line":"        cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":178,"context_line":"        self._wait_for_object_status("}],"source_content_type":"text/x-python","patch_set":4,"id":"7d03725b_8dae33d9","line":175,"range":{"start_line":175,"start_character":8,"end_line":175,"end_character":29},"in_reply_to":"5b5912db_d445fbad","updated":"2022-05-26 20:37:50.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":true,"context_lines":[{"line_number":201,"context_line":"            cmd \u003d cmd + \u0027 --force %s\u0027 % force"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        snapshot_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":204,"context_line":"        self._wait_for_object_status("},{"line_number":205,"context_line":"            \u0027share snapshot\u0027, snapshot_object[\u0027id\u0027], \u0027available\u0027)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if add_cleanup:"},{"line_number":208,"context_line":"            self.addCleanup("}],"source_content_type":"text/x-python","patch_set":4,"id":"8df98ccf_a7ef9737","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":65},"updated":"2022-05-19 20:09:24.000000000","message":"If \"--wait\" is used, this isn\u0027t necessary..","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            cmd \u003d cmd + \u0027 --force %s\u0027 % force"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        snapshot_object \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":204,"context_line":"        self._wait_for_object_status("},{"line_number":205,"context_line":"            \u0027share snapshot\u0027, snapshot_object[\u0027id\u0027], \u0027available\u0027)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        if add_cleanup:"},{"line_number":208,"context_line":"            self.addCleanup("}],"source_content_type":"text/x-python","patch_set":4,"id":"c5094b2b_faf65fea","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":65},"in_reply_to":"8df98ccf_a7ef9737","updated":"2022-05-26 20:37:50.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"10df5f3c2973d4b01c6e142922a1f4f245114eed","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":175,"context_line":"        if share_group:"},{"line_number":176,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":177,"context_line":"        if wait:"},{"line_number":178,"context_line":"            cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":181,"context_line":"        self._wait_for_object_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"be2c908f_f748e705","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":33},"updated":"2022-07-18 11:38:12.000000000","message":"In case of the tests being added, use of this does the same thing as lines 181-182.. i guess adding this here will help validate the behavior of the \"--wait\" argument; but having both is confusing;","commit_id":"5485b4039db4a346c60a2ed5fe37a60fe397502f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b8653017803331c532cccf6ffd2d1ec3c55996ec","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":175,"context_line":"        if share_group:"},{"line_number":176,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":177,"context_line":"        if wait:"},{"line_number":178,"context_line":"            cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":181,"context_line":"        self._wait_for_object_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"97b2b9e6_99f737cf","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":33},"in_reply_to":"12745e2d_98956af9","updated":"2022-07-28 18:17:05.000000000","message":"Looks like the changes below (lines 284-295) were done to prevent a merge conflict with Maari\u0027s patch? Could you just use her patch as the parent instead?\n\nMy prior comment pertains to the create_share method","commit_id":"5485b4039db4a346c60a2ed5fe37a60fe397502f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0b08a5a0403e4586261a05700f29db79c5ac7652","unresolved":true,"context_lines":[{"line_number":174,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":175,"context_line":"        if share_group:"},{"line_number":176,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":177,"context_line":"        if wait:"},{"line_number":178,"context_line":"            cmd \u003d cmd + \u0027 --wait\u0027"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":181,"context_line":"        self._wait_for_object_status("}],"source_content_type":"text/x-python","patch_set":8,"id":"12745e2d_98956af9","line":178,"range":{"start_line":177,"start_character":0,"end_line":178,"end_character":33},"in_reply_to":"be2c908f_f748e705","updated":"2022-07-18 12:44:52.000000000","message":"As an alternative, we can do what Maari\u0027s doing here: https://review.opendev.org/c/openstack/python-manilaclient/+/836834/17/manilaclient/tests/functional/osc/base.py#b296\n\nGet rid of the \"self._wait_for_object_status\" call altogether and set wait\u003dTrue, and add the \"_wait_for_object_status\" to the user messages functional test that expects the share to go to \"error\" state before performing verfications: \n\nhttps://github.com/openstack/python-manilaclient/blob/301274dbfe4466329916c589ddf671d38c4d3689/manilaclient/tests/functional/osc/test_messages.py#L24","commit_id":"5485b4039db4a346c60a2ed5fe37a60fe397502f"}],"manilaclient/tests/functional/osc/test_share_snapshot_instances.py":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"25ade560d23cd06f0574fd9853a2f75758d34287","unresolved":true,"context_lines":[{"line_number":20,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027])"},{"line_number":21,"context_line":"        share_snapshot_instances_list \u003d self.listing_result("},{"line_number":22,"context_line":"            \u0027share snapshot instance\u0027, \u0027list\u0027)"},{"line_number":23,"context_line":"        self.assertTableStruct(share_snapshot_instances_list, ["},{"line_number":24,"context_line":"            \u0027ID\u0027,"},{"line_number":25,"context_line":"            \u0027Snapshot ID\u0027,"},{"line_number":26,"context_line":"            \u0027Status\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9b00d52a_eb7b8c67","line":23,"updated":"2022-05-20 19:39:45.000000000","message":"Suggestion: you could add another test to check the table struct passing the flag \u0027--detailed\u0027 since more columns are displayed in the result","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027])"},{"line_number":21,"context_line":"        share_snapshot_instances_list \u003d self.listing_result("},{"line_number":22,"context_line":"            \u0027share snapshot instance\u0027, \u0027list\u0027)"},{"line_number":23,"context_line":"        self.assertTableStruct(share_snapshot_instances_list, ["},{"line_number":24,"context_line":"            \u0027ID\u0027,"},{"line_number":25,"context_line":"            \u0027Snapshot ID\u0027,"},{"line_number":26,"context_line":"            \u0027Status\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5ea56113_abc51a02","line":23,"in_reply_to":"9b00d52a_eb7b8c67","updated":"2022-05-26 20:37:50.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":true,"context_lines":[{"line_number":33,"context_line":"        share \u003d self.create_share()"},{"line_number":34,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        share_snapshot_instances_list \u003d self.listing_result("},{"line_number":37,"context_line":"            \u0027share snapshot instance\u0027, \u0027list\u0027)"},{"line_number":38,"context_line":"        instances \u003d {}"},{"line_number":39,"context_line":"        for item in share_snapshot_instances_list:"},{"line_number":40,"context_line":"            instances[item[\u0027Snapshot ID\u0027]] \u003d item[\u0027ID\u0027]"},{"line_number":41,"context_line":"        share_snapshot_instance \u003d instances.get(snapshot[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        result \u003d self.dict_result(\u0027share snapshot instance\u0027,"},{"line_number":44,"context_line":"                                  \u0027show %s\u0027 % share_snapshot_instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f3e1b04_22547d32","line":41,"range":{"start_line":36,"start_character":8,"end_line":41,"end_character":63},"updated":"2022-05-19 20:09:24.000000000","message":"You can filter the snapshot instance list by snapshot ID/Name with \"--snapshot\"\n\n   self.listing_result(\"share snapshot instance\",\n                        f\"list --snapshot {snapshot[\u0027id\u0027]}\")\n\n\nwill give you instances of the specific snpshot","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        share \u003d self.create_share()"},{"line_number":34,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        share_snapshot_instances_list \u003d self.listing_result("},{"line_number":37,"context_line":"            \u0027share snapshot instance\u0027, \u0027list\u0027)"},{"line_number":38,"context_line":"        instances \u003d {}"},{"line_number":39,"context_line":"        for item in share_snapshot_instances_list:"},{"line_number":40,"context_line":"            instances[item[\u0027Snapshot ID\u0027]] \u003d item[\u0027ID\u0027]"},{"line_number":41,"context_line":"        share_snapshot_instance \u003d instances.get(snapshot[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        result \u003d self.dict_result(\u0027share snapshot instance\u0027,"},{"line_number":44,"context_line":"                                  \u0027show %s\u0027 % share_snapshot_instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f646c7fe_7f6fa285","line":41,"range":{"start_line":36,"start_character":8,"end_line":41,"end_character":63},"in_reply_to":"7f3e1b04_22547d32","updated":"2022-05-26 20:37:50.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertEqual(share_snapshot_instance, result[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":49,"context_line":"            \u0027share snapshot instance\u0027, \u0027show %s\u0027 % share_snapshot_instance)"},{"line_number":50,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":51,"context_line":"            \u0027Field\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d8fb237_733fa98c","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":44},"updated":"2022-05-19 20:09:24.000000000","message":"shouldn\u0027t any \"show\" command yield a dict?","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"b38d62e0201c9171e6dea59b925f241412a7577d","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertEqual(share_snapshot_instance, result[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":49,"context_line":"            \u0027share snapshot instance\u0027, \u0027show %s\u0027 % share_snapshot_instance)"},{"line_number":50,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":51,"context_line":"            \u0027Field\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"51803c02_9e51afc2","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":44},"in_reply_to":"00c87b82_22ab756b","updated":"2022-06-29 16:02:51.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"71c02e643b8e8c6b79bae253d23803bccf5fef94","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertEqual(share_snapshot_instance, result[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":49,"context_line":"            \u0027share snapshot instance\u0027, \u0027show %s\u0027 % share_snapshot_instance)"},{"line_number":50,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":51,"context_line":"            \u0027Field\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"00c87b82_22ab756b","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":44},"in_reply_to":"3903aebe_9fd56b6e","updated":"2022-05-31 14:35:31.000000000","message":"Ok, I got it now","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"25ade560d23cd06f0574fd9853a2f75758d34287","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertEqual(share_snapshot_instance, result[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":49,"context_line":"            \u0027share snapshot instance\u0027, \u0027show %s\u0027 % share_snapshot_instance)"},{"line_number":50,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":51,"context_line":"            \u0027Field\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cf8988c0_37a5334b","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":44},"in_reply_to":"7d8fb237_733fa98c","updated":"2022-05-20 19:39:45.000000000","message":"I agree with Goutham, if you use \u0027dict_result\u0027 here, you could assert the values of the properties rather than asserting the header names.","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":true,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.assertEqual(share_snapshot_instance, result[\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":49,"context_line":"            \u0027share snapshot instance\u0027, \u0027show %s\u0027 % share_snapshot_instance)"},{"line_number":50,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":51,"context_line":"            \u0027Field\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3903aebe_9fd56b6e","line":48,"range":{"start_line":48,"start_character":30,"end_line":48,"end_character":44},"in_reply_to":"cf8988c0_37a5334b","updated":"2022-05-26 20:37:50.000000000","message":"I did check the dict_result in the above asserts for snapshot id and snapshot instance id. (see newest patch) i was following maaris example in test_shares where she does this","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45d104335a8e00ff6f6f94af6e250f11860b5029","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def test_openstack_share_snapshot_instance_set(self):"},{"line_number":56,"context_line":"        share \u003d self.create_share()"},{"line_number":57,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":58,"context_line":"        share_snapshot_instances_list \u003d self.listing_result("},{"line_number":59,"context_line":"            \u0027share snapshot instance\u0027, \u0027list\u0027)"},{"line_number":60,"context_line":"        instances \u003d {}"},{"line_number":61,"context_line":"        for item in share_snapshot_instances_list:"},{"line_number":62,"context_line":"            instances[item[\u0027Snapshot ID\u0027]] \u003d item[\u0027ID\u0027]"},{"line_number":63,"context_line":"        share_snapshot_instance \u003d instances.get(snapshot[\u0027id\u0027])"},{"line_number":64,"context_line":"        result1 \u003d self.dict_result(\u0027share snapshot instance\u0027, \u0027show %s\u0027 %"},{"line_number":65,"context_line":"                                   share_snapshot_instance)"},{"line_number":66,"context_line":"        self.assertEqual(share_snapshot_instance, result1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"619d4f34_a4254734","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":63},"updated":"2022-05-19 20:09:24.000000000","message":"use --snapshot filter instead","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"2e25e280f1f0b7305b1586aa2f76956da7215646","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def test_openstack_share_snapshot_instance_set(self):"},{"line_number":56,"context_line":"        share \u003d self.create_share()"},{"line_number":57,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":58,"context_line":"        share_snapshot_instances_list \u003d self.listing_result("},{"line_number":59,"context_line":"            \u0027share snapshot instance\u0027, \u0027list\u0027)"},{"line_number":60,"context_line":"        instances \u003d {}"},{"line_number":61,"context_line":"        for item in share_snapshot_instances_list:"},{"line_number":62,"context_line":"            instances[item[\u0027Snapshot ID\u0027]] \u003d item[\u0027ID\u0027]"},{"line_number":63,"context_line":"        share_snapshot_instance \u003d instances.get(snapshot[\u0027id\u0027])"},{"line_number":64,"context_line":"        result1 \u003d self.dict_result(\u0027share snapshot instance\u0027, \u0027show %s\u0027 %"},{"line_number":65,"context_line":"                                   share_snapshot_instance)"},{"line_number":66,"context_line":"        self.assertEqual(share_snapshot_instance, result1[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"e070c543_969e6b99","line":63,"range":{"start_line":58,"start_character":0,"end_line":63,"end_character":63},"in_reply_to":"619d4f34_a4254734","updated":"2022-05-26 20:37:50.000000000","message":"Done","commit_id":"a5065a72573e08c33f078fd879005fae8a5d67f3"}]}