)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17171cdf70a2564093b4117e160ab36e9e96b8ad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"5a4bfeaf_be0791f0","updated":"2022-06-29 09:35:21.000000000","message":"Think the test is failing because there\u0027s no wait after resize.. .","commit_id":"bfeeaa03b1a0594869f0c20b4f886c2784144ead"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8724078ded33f1ea2949892e709f846296c69e9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"d55791db_5b05d757","updated":"2022-06-29 19:58:51.000000000","message":"Thanks Ashley, LGTM","commit_id":"307a298ec03c7b578136cd88f9baa2aaff9c83e7"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"bc9344012cab2bf15f3a36707e2a333c4bb79c62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"d1723579_bc45d95f","updated":"2022-07-07 16:46:06.000000000","message":"Sweet, thanks Ashley!","commit_id":"0e7d3bfff16e6ebab8a57d68df0faf62dbac6ee8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2bf7fbd77fe0cd0af0071d1464aa8ecc4c56949f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"7a0bba07_dc533e3c","updated":"2022-07-06 14:32:16.000000000","message":"Thanks, LGTM!","commit_id":"0e7d3bfff16e6ebab8a57d68df0faf62dbac6ee8"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8724078ded33f1ea2949892e709f846296c69e9f","unresolved":true,"context_lines":[{"line_number":1180,"context_line":"            help\u003d_(\u0027Name or ID of the snapshot to restore. The snapshot \u0027"},{"line_number":1181,"context_line":"                   \u0027must be the most recent one known to manila.\u0027)"},{"line_number":1182,"context_line":"        )"},{"line_number":1183,"context_line":"        parser.add_argument("},{"line_number":1184,"context_line":"            \u0027--wait\u0027,"},{"line_number":1185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1186,"context_line":"            default\u003dFalse,"},{"line_number":1187,"context_line":"            help\u003d_(\u0027Wait for share revert\u0027)"},{"line_number":1188,"context_line":"        )"},{"line_number":1189,"context_line":"        return parser"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":15,"id":"91811bbe_4557da22","line":1188,"range":{"start_line":1183,"start_character":8,"end_line":1188,"end_character":9},"updated":"2022-06-29 19:58:51.000000000","message":"+1 this new functionality should be called out in the commit message, or come in a separate commit","commit_id":"307a298ec03c7b578136cd88f9baa2aaff9c83e7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"82608b75de7fe337a10ba7f6718a505f441ef100","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"            help\u003d_(\u0027Name or ID of the snapshot to restore. The snapshot \u0027"},{"line_number":1181,"context_line":"                   \u0027must be the most recent one known to manila.\u0027)"},{"line_number":1182,"context_line":"        )"},{"line_number":1183,"context_line":"        parser.add_argument("},{"line_number":1184,"context_line":"            \u0027--wait\u0027,"},{"line_number":1185,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":1186,"context_line":"            default\u003dFalse,"},{"line_number":1187,"context_line":"            help\u003d_(\u0027Wait for share revert\u0027)"},{"line_number":1188,"context_line":"        )"},{"line_number":1189,"context_line":"        return parser"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":15,"id":"b8dae8c2_5ddb660b","line":1188,"range":{"start_line":1183,"start_character":8,"end_line":1188,"end_character":9},"in_reply_to":"91811bbe_4557da22","updated":"2022-07-01 19:35:14.000000000","message":"Done","commit_id":"307a298ec03c7b578136cd88f9baa2aaff9c83e7"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e7bb08994908bf96688c6fe0ac4101adcd9d3f65","unresolved":true,"context_lines":[{"line_number":179,"context_line":"            \u0027share\u0027, share_object[\u0027id\u0027], \u0027available\u0027)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if add_cleanup:"},{"line_number":182,"context_line":"            self.addCleanup("},{"line_number":183,"context_line":"                self.openstack, \u0027share delete %s --wait\u0027 % share_object[\u0027id\u0027]"},{"line_number":184,"context_line":"            )"},{"line_number":185,"context_line":"        return share_object"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def list_pools(self, backend\u003dNone, host\u003dNone, pool\u003dNone, detail\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"f34b1d0e_7e3ab742","line":184,"range":{"start_line":182,"start_character":12,"end_line":184,"end_character":13},"updated":"2022-06-24 08:52:28.000000000","message":"+1","commit_id":"07f893d6bc8bed02ca2d3cf8a97acd3f36aea2e6"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"026268a2aa5634e012ece5a4922ec2ee8db1b191","unresolved":false,"context_lines":[{"line_number":179,"context_line":"            \u0027share\u0027, share_object[\u0027id\u0027], \u0027available\u0027)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        if add_cleanup:"},{"line_number":182,"context_line":"            self.addCleanup("},{"line_number":183,"context_line":"                self.openstack, \u0027share delete %s --wait\u0027 % share_object[\u0027id\u0027]"},{"line_number":184,"context_line":"            )"},{"line_number":185,"context_line":"        return share_object"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def list_pools(self, backend\u003dNone, host\u003dNone, pool\u003dNone, detail\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":8,"id":"600fb050_072f6943","line":184,"range":{"start_line":182,"start_character":12,"end_line":184,"end_character":13},"in_reply_to":"f34b1d0e_7e3ab742","updated":"2022-06-27 20:30:05.000000000","message":"Ack","commit_id":"07f893d6bc8bed02ca2d3cf8a97acd3f36aea2e6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e7bb08994908bf96688c6fe0ac4101adcd9d3f65","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":174,"context_line":"        if share_group:"},{"line_number":175,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":176,"context_line":"        cmd +\u003d \u0027 --wait\u0027"},{"line_number":177,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":178,"context_line":"        self._wait_for_object_status("},{"line_number":179,"context_line":"            \u0027share\u0027, share_object[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"a5b6c04b_33aa05be","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":24},"updated":"2022-06-24 08:52:28.000000000","message":"This would get in the way when we want a share to go to \"error\" asynchronously... we\u0027re doing the waiting another way through lines 178-179","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"026268a2aa5634e012ece5a4922ec2ee8db1b191","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            cmd \u003d cmd + \u0027 --availability-zone %s\u0027 % availability_zone"},{"line_number":174,"context_line":"        if share_group:"},{"line_number":175,"context_line":"            cmd \u003d cmd + \u0027 --share-group %s\u0027 % share_group"},{"line_number":176,"context_line":"        cmd +\u003d \u0027 --wait\u0027"},{"line_number":177,"context_line":"        share_object \u003d self.dict_result(\u0027share\u0027, cmd, client\u003dclient)"},{"line_number":178,"context_line":"        self._wait_for_object_status("},{"line_number":179,"context_line":"            \u0027share\u0027, share_object[\u0027id\u0027], \u0027available\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"cf4cb46f_c40835be","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":24},"in_reply_to":"a5b6c04b_33aa05be","updated":"2022-06-27 20:30:05.000000000","message":"Done","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"}],"manilaclient/tests/functional/osc/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e7bb08994908bf96688c6fe0ac4101adcd9d3f65","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_openstack_share_resize(self):"},{"line_number":95,"context_line":"        share \u003d self.create_share()"},{"line_number":96,"context_line":"        self.openstack(f\u0027share resize {share[\"id\"]} {10} --wait \u0027)"},{"line_number":97,"context_line":"        result \u003d self.dict_result(\u0027share\u0027, f\u0027show {share[\"id\"]}\u0027)"},{"line_number":98,"context_line":"        self.assertEqual(\u002710\u0027, result[\u0027size\u0027])"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"296d289d_94f9288d","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":56},"updated":"2022-06-24 08:52:28.000000000","message":"why in {}?","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"026268a2aa5634e012ece5a4922ec2ee8db1b191","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_openstack_share_resize(self):"},{"line_number":95,"context_line":"        share \u003d self.create_share()"},{"line_number":96,"context_line":"        self.openstack(f\u0027share resize {share[\"id\"]} {10} --wait \u0027)"},{"line_number":97,"context_line":"        result \u003d self.dict_result(\u0027share\u0027, f\u0027show {share[\"id\"]}\u0027)"},{"line_number":98,"context_line":"        self.assertEqual(\u002710\u0027, result[\u0027size\u0027])"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"91489f23_cdb44514","line":96,"range":{"start_line":96,"start_character":52,"end_line":96,"end_character":56},"in_reply_to":"296d289d_94f9288d","updated":"2022-06-27 20:30:05.000000000","message":"A remnant from an earlier attempt, removed braces in newest patch","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e7bb08994908bf96688c6fe0ac4101adcd9d3f65","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(\u002710\u0027, result[\u0027size\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_openstack_share_revert(self):"},{"line_number":101,"context_line":"        share \u003d self.create_share()"},{"line_number":102,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":103,"context_line":"        self.openstack(f\u0027share set {share[\"id\"]} --name newname \u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.openstack(f\u0027share revert {snapshot[\"id\"]} \u0027)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"30a1b27b_cc4c39bb","line":103,"range":{"start_line":101,"start_character":0,"end_line":103,"end_character":66},"updated":"2022-06-24 08:52:28.000000000","message":"for these actions, the share must be created with extra-specs: \"snapshot_support\" and \"revert_to_snapshot_support\" set to True.","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"026268a2aa5634e012ece5a4922ec2ee8db1b191","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.assertEqual(\u002710\u0027, result[\u0027size\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_openstack_share_revert(self):"},{"line_number":101,"context_line":"        share \u003d self.create_share()"},{"line_number":102,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":103,"context_line":"        self.openstack(f\u0027share set {share[\"id\"]} --name newname \u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.openstack(f\u0027share revert {snapshot[\"id\"]} \u0027)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"082de45b_79d5b804","line":103,"range":{"start_line":101,"start_character":0,"end_line":103,"end_character":66},"in_reply_to":"30a1b27b_cc4c39bb","updated":"2022-06-27 20:30:05.000000000","message":"Done","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e7bb08994908bf96688c6fe0ac4101adcd9d3f65","unresolved":true,"context_lines":[{"line_number":102,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":103,"context_line":"        self.openstack(f\u0027share set {share[\"id\"]} --name newname \u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.openstack(f\u0027share revert {snapshot[\"id\"]} \u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        result \u003d self.dict_result(\u0027share\u0027, f\u0027show {share[\"id\"]}\u0027)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5345163c_bed7f82d","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":57},"updated":"2022-06-24 08:52:28.000000000","message":"a good test for this would be to:\n\n1) Create a share of size X\n2) Take a snapshot\n3) Assert that the snapshot\u0027s size is X\n3) Resize share to size Y\n4) Assert that the share\u0027s size is Y\n5) Revert share to snapshot\n5) Assert that the share\u0027s size is X","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"026268a2aa5634e012ece5a4922ec2ee8db1b191","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":103,"context_line":"        self.openstack(f\u0027share set {share[\"id\"]} --name newname \u0027)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.openstack(f\u0027share revert {snapshot[\"id\"]} \u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        result \u003d self.dict_result(\u0027share\u0027, f\u0027show {share[\"id\"]}\u0027)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bfd8de3b_572d9244","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":57},"in_reply_to":"5345163c_bed7f82d","updated":"2022-06-27 20:30:05.000000000","message":"thanks! added this test to newest patch","commit_id":"b15ad3ba8c7c48596fe2dc60fe05721c58cc9729"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17171cdf70a2564093b4117e160ab36e9e96b8ad","unresolved":true,"context_lines":[{"line_number":107,"context_line":"        share \u003d self.create_share(share_type\u003dshare_type[\u0027id\u0027], size\u003d10)"},{"line_number":108,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":109,"context_line":"        self.assertEqual(snapshot[\u0027size\u0027], share[\u0027size\u0027])"},{"line_number":110,"context_line":"        self.openstack(f\u0027share resize {share[\"id\"]} 15 \u0027)"},{"line_number":111,"context_line":"        result1 \u003d self.dict_result(\u0027share\u0027, f\u0027show {share[\"id\"]}\u0027)"},{"line_number":112,"context_line":"        self.assertEqual(\u002715\u0027, result1[\"size\"])"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"c58b202b_6f8abaa5","line":110,"range":{"start_line":110,"start_character":55,"end_line":110,"end_character":57},"updated":"2022-06-29 09:35:21.000000000","message":"--wait","commit_id":"bfeeaa03b1a0594869f0c20b4f886c2784144ead"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"8627e4efdf41a289fdcba2a67cec1caf54254a54","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        share \u003d self.create_share(share_type\u003dshare_type[\u0027id\u0027], size\u003d10)"},{"line_number":108,"context_line":"        snapshot \u003d self.create_snapshot(share[\u0027id\u0027], wait\u003dTrue)"},{"line_number":109,"context_line":"        self.assertEqual(snapshot[\u0027size\u0027], share[\u0027size\u0027])"},{"line_number":110,"context_line":"        self.openstack(f\u0027share resize {share[\"id\"]} 15 \u0027)"},{"line_number":111,"context_line":"        result1 \u003d self.dict_result(\u0027share\u0027, f\u0027show {share[\"id\"]}\u0027)"},{"line_number":112,"context_line":"        self.assertEqual(\u002715\u0027, result1[\"size\"])"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"4af65283_43530450","line":110,"range":{"start_line":110,"start_character":55,"end_line":110,"end_character":57},"in_reply_to":"c58b202b_6f8abaa5","updated":"2022-06-29 17:12:01.000000000","message":"Done","commit_id":"bfeeaa03b1a0594869f0c20b4f886c2784144ead"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8724078ded33f1ea2949892e709f846296c69e9f","unresolved":true,"context_lines":[{"line_number":145,"context_line":"        shares_list_after_delete \u003d self.listing_result(\u0027share\u0027, \u0027list\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.assertNotIn("},{"line_number":148,"context_line":"            share[\u0027id\u0027], [item[\u0027ID\u0027] for item in shares_list_after_delete])"}],"source_content_type":"text/x-python","patch_set":15,"id":"fc786913_016eddab","line":148,"range":{"start_line":148,"start_character":74,"end_line":148,"end_character":75},"updated":"2022-06-29 19:58:51.000000000","message":"Since we\u0027re only ever testing with the dummy driver, this is fine.. but you should re-adopt the share and delete it to prevent orphaning resources.","commit_id":"307a298ec03c7b578136cd88f9baa2aaff9c83e7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"82608b75de7fe337a10ba7f6718a505f441ef100","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        shares_list_after_delete \u003d self.listing_result(\u0027share\u0027, \u0027list\u0027)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        self.assertNotIn("},{"line_number":148,"context_line":"            share[\u0027id\u0027], [item[\u0027ID\u0027] for item in shares_list_after_delete])"}],"source_content_type":"text/x-python","patch_set":15,"id":"683b3a9e_6a28aeb9","line":148,"range":{"start_line":148,"start_character":74,"end_line":148,"end_character":75},"in_reply_to":"fc786913_016eddab","updated":"2022-07-01 19:35:14.000000000","message":"Done","commit_id":"307a298ec03c7b578136cd88f9baa2aaff9c83e7"}]}