)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"02b3160e45c843b9f3995ea40cbd9e54408bdacb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ca6c452d_aec49793","updated":"2022-05-20 20:24:29.000000000","message":"LGTM. Thanks Eduardo! ","commit_id":"9a36d3a195e97fb94b970b5b4055e5f7e4097686"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"41278576c1422f84cf3e0fcf0a7f5e8ada8f787d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"032a2952_e2949934","updated":"2022-05-24 14:46:53.000000000","message":"recheck\n\nThe Python testing runtime was updated [1], so Zuul should be happy now (I think).\n\n[1] https://review.opendev.org/c/openstack/python-manilaclient/+/842722","commit_id":"9a36d3a195e97fb94b970b5b4055e5f7e4097686"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0245550e391ab4b7f82871a371ac0b72272d025b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c4dc40e4_31585933","updated":"2022-06-16 14:09:47.000000000","message":"LGTM, thanks Eduardo!","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f79815454a6c87b73badeaa5967a0db31453cfff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"be81a3df_0de038dd","updated":"2022-06-17 22:41:24.000000000","message":"Looking good, Eduardo! Thank you\nA couple of comments inline, please take a look at them :)","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"9806b7bce41e2cc742cb1269878910f2ee40234d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e51bdb70_0657482c","updated":"2022-06-03 17:55:31.000000000","message":"Validated new tests.","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"6168b09e8f9d5a251dc2d16cb3ebff719b85013f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9290cced_70386b1d","updated":"2022-07-08 18:53:55.000000000","message":"Thanks for your reviews, Ashley, Carlos, Nahim, and Vida!\n\nI updated the change to address your comments, Carlos. Please take a look at them whenever possible.","commit_id":"15af985b7cc47a0e6623c102218e5f14390e9f8e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1439c130e8363b470f526a1cb7b058fe96b04312","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"dc5eee67_2f9f00ea","updated":"2022-08-11 21:13:00.000000000","message":"Eduardo, can you rebase and refresh this patch? ","commit_id":"437e0b4b24c960153c971dfc4cabbb1cb4208092"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f79815454a6c87b73badeaa5967a0db31453cfff","unresolved":true,"context_lines":[{"line_number":119,"context_line":"            if subnet[\u0027availability_zone\u0027] is None"},{"line_number":120,"context_line":"        ] or None"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return default_share_network_subnet[0]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def check_object_deleted(self, object_name, object_id,"},{"line_number":125,"context_line":"                             timeout\u003dCONF.build_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bdaec2dc_9abf405e","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":46},"updated":"2022-06-17 22:41:24.000000000","message":"if default_share_network_subnet is none, you\u0027ll be accessing [0] of None. Instead of assigning None, on line 120 you could have:\nor default_share_network_subnet[0]\nThat would prevent this to try to access [0] of None but in case a test dropped all subnets from the share network, it would also fail :/","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"6168b09e8f9d5a251dc2d16cb3ebff719b85013f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if subnet[\u0027availability_zone\u0027] is None"},{"line_number":120,"context_line":"        ] or None"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        return default_share_network_subnet[0]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def check_object_deleted(self, object_name, object_id,"},{"line_number":125,"context_line":"                             timeout\u003dCONF.build_timeout,"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7e4c923_a0656bcd","line":122,"range":{"start_line":122,"start_character":8,"end_line":122,"end_character":46},"in_reply_to":"bdaec2dc_9abf405e","updated":"2022-07-08 18:53:55.000000000","message":"Done","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f79815454a6c87b73badeaa5967a0db31453cfff","unresolved":true,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return share_network"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def delete_share_network(self, *share_networks):"},{"line_number":251,"context_line":"        cmd \u003d \u0027share network delete\u0027"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if share_networks:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5cd8aa88_e1a4ccc7","line":250,"range":{"start_line":250,"start_character":35,"end_line":250,"end_character":50},"updated":"2022-06-17 22:41:24.000000000","message":"nit: in the delete_share_network_subnets I see you are expecting a list/tuple... I think this could change here or in the other scenario, to keep consistency.","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"6168b09e8f9d5a251dc2d16cb3ebff719b85013f","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":"        return share_network"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    def delete_share_network(self, *share_networks):"},{"line_number":251,"context_line":"        cmd \u003d \u0027share network delete\u0027"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        if share_networks:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7573bfc5_ae0a30ea","line":250,"range":{"start_line":250,"start_character":35,"end_line":250,"end_character":50},"in_reply_to":"5cd8aa88_e1a4ccc7","updated":"2022-07-08 18:53:55.000000000","message":"Done","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1d5a15e5faa37e1bf01c02ffbcf4acf44c6687fb","unresolved":true,"context_lines":[{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def show_share_network(self, share_network\u003dNone):"},{"line_number":362,"context_line":"        cmd \u003d f\u0027network show {share_network}\u0027"},{"line_number":363,"context_line":"        share_network \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"        return share_network"},{"line_number":366,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"923b5db1_b06a13de","line":363,"range":{"start_line":363,"start_character":24,"end_line":363,"end_character":54},"updated":"2022-08-11 21:19:18.000000000","message":"maybe this dict parsing is swallowing the value; \n\ncan you try replacing this call in the tests directly with:\n\n openstack share network show \u003cnetwork\u003e -c share_network_subnets -f value\n \nYou should see a list then.","commit_id":"39f162861d72631059eaed1ec6ed7dc929c74687"}],"manilaclient/tests/functional/osc/test_share_network_subnets.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f79815454a6c87b73badeaa5967a0db31453cfff","unresolved":true,"context_lines":[{"line_number":55,"context_line":"            subnet[\u0027id\u0027] for subnet"},{"line_number":56,"context_line":"            in share_network_show[\u0027share_network_subnets\u0027]"},{"line_number":57,"context_line":"        ])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.delete_share_network(share_network[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_openstack_share_network_subnet_show(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"b1b41ab5_2d2ddd73","line":58,"updated":"2022-06-17 22:41:24.000000000","message":"You could also assert that there are only two share network subnets displayed, considering that the first one will be created alongside the share network, and the second one will be created by you.","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"6168b09e8f9d5a251dc2d16cb3ebff719b85013f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            subnet[\u0027id\u0027] for subnet"},{"line_number":56,"context_line":"            in share_network_show[\u0027share_network_subnets\u0027]"},{"line_number":57,"context_line":"        ])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        self.delete_share_network(share_network[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_openstack_share_network_subnet_show(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"739179a1_7e2e9c58","line":58,"in_reply_to":"b1b41ab5_2d2ddd73","updated":"2022-07-08 18:53:55.000000000","message":"Done","commit_id":"e32ae7bf085635155647437d4a49f395bcd318d4"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"c11caf1581c124ec42288d614843281a2183ed74","unresolved":true,"context_lines":[{"line_number":34,"context_line":"            self.show_share_network(share_network[\u0027id\u0027])"},{"line_number":35,"context_line":"        )"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        self.assertEqual("},{"line_number":38,"context_line":"            len(share_network_with_subnets[\u0027share_network_subnets\u0027]), 2"},{"line_number":39,"context_line":"        )"},{"line_number":40,"context_line":"        self.assertEqual("},{"line_number":41,"context_line":"            share_network_subnet[\u0027neutron_net_id\u0027], neutron_net_id"},{"line_number":42,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":6,"id":"9943e3f7_c00b4e36","line":39,"range":{"start_line":37,"start_character":0,"end_line":39,"end_character":9},"updated":"2022-07-09 03:17:57.000000000","message":"For some reason the Tempest client always returns the share_network_subnets key as an empty string (all other keys are returned with their correct values), so this assertion always fails (the assertion in line 59 of PS 6 also becomes useless). When I check the share network using the regular OpenStack client, the share network subnets are there. I\u0027m not sure yet why that\u0027s the case. :/","commit_id":"39f162861d72631059eaed1ec6ed7dc929c74687"}]}