)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0de32bf382dee9b6a2692dc44a42ac4fa309a962","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d3714af6_549a8e81","updated":"2022-05-20 01:24:52.000000000","message":"As we\u0027ve worked on the base.py logic for splitting items together, I took the freedom to update it on this change. Needed to do a few modifications to make it work for other changes as well.\nAlso, fixed some pep8 issues :)","commit_id":"560dda5cfc8ea4eadd39ae83820a846669498068"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"ba25b17946127817d7ca63b04dbf2f3816f68bc9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bd006fe6_dbf0015d","updated":"2022-05-20 20:22:40.000000000","message":"Hi Ashley! Just a small issue, looks like your test is creating a share replica from a share using the DEFAULT share type. CI is failing due to this reason.\n\nProblem is that share replicas requires the extra-spec replication_type to be set and that is not the case for the DEFAULT type. I think the test would require creating a new share type with the appropriate extra-spec before the creation of the share and share replicas.\n\n","commit_id":"560dda5cfc8ea4eadd39ae83820a846669498068"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a8e43681dafd9f16ffc635dff93d2d11e0eb7a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"cf04a3d3_d378a09f","updated":"2022-07-01 19:03:05.000000000","message":"Looking good, just one suggestion :)","commit_id":"595131b99d1a39d163c5935fe46dae7a28653577"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"997782a65c225abb7b351655cc98d57df2553738","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"63e121ff_6b756f17","updated":"2022-07-22 13:23:50.000000000","message":"Change is looking quite good, just needs a rebase and I possibly found a rebasing issue. Could you please check the comment inline? :)","commit_id":"739fdd22fbc480d3483f8cbdc2125a2a98366c51"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"de66b7bbb059de051b47eb0c7b64ef17ae8746f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"07946886_dfb55ea3","updated":"2022-07-25 19:07:25.000000000","message":"LGTM, thank you Ashley!","commit_id":"f3eea6bbea06d2655caa0a3b507f7aaf2e7806af"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"997782a65c225abb7b351655cc98d57df2553738","unresolved":true,"context_lines":[{"line_number":299,"context_line":"            self.addCleanup("},{"line_number":300,"context_line":"                self.openstack,"},{"line_number":301,"context_line":"                f\u0027share snapshot delete {snapshot_object[\"id\"]} --wait\u0027)"},{"line_number":302,"context_line":"            return snapshot_object"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def create_share_replica(self, share, availability_zone\u003dNone,"},{"line_number":305,"context_line":"                             wait\u003dNone, add_cleanup\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":17,"id":"d5bcdb2e_51b17025","line":302,"range":{"start_line":302,"start_character":12,"end_line":302,"end_character":34},"updated":"2022-07-22 13:23:50.000000000","message":"return should be at the same identation level as the if for add_cleanup\nmay be a rebasing issue :)","commit_id":"739fdd22fbc480d3483f8cbdc2125a2a98366c51"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"d9a072e26a687b877b22b3b1544e8cabde8fb011","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            self.addCleanup("},{"line_number":300,"context_line":"                self.openstack,"},{"line_number":301,"context_line":"                f\u0027share snapshot delete {snapshot_object[\"id\"]} --wait\u0027)"},{"line_number":302,"context_line":"            return snapshot_object"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def create_share_replica(self, share, availability_zone\u003dNone,"},{"line_number":305,"context_line":"                             wait\u003dNone, add_cleanup\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":17,"id":"02053476_2d59bcb7","line":302,"range":{"start_line":302,"start_character":12,"end_line":302,"end_character":34},"in_reply_to":"d5bcdb2e_51b17025","updated":"2022-07-25 18:00:24.000000000","message":"Done","commit_id":"739fdd22fbc480d3483f8cbdc2125a2a98366c51"}],"manilaclient/tests/functional/osc/test_share_replica_export_locations.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a8e43681dafd9f16ffc635dff93d2d11e0eb7a6","unresolved":true,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(exp_loc_list[\u0027export_locations\u0027][0][\u0027id\u0027],"},{"line_number":59,"context_line":"                         result[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":62,"context_line":"            \u0027share replica export location\u0027,"},{"line_number":63,"context_line":"            f\u0027show {replica[\"id\"]} {rep_exp_loc_obj[\"ID\"]}\u0027)"},{"line_number":64,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":65,"context_line":"            \u0027Field\u0027,"},{"line_number":66,"context_line":"            \u0027Value\u0027"},{"line_number":67,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":14,"id":"5f244f75_6e0f6abe","line":67,"range":{"start_line":61,"start_character":8,"end_line":67,"end_character":10},"updated":"2022-07-01 19:03:05.000000000","message":"I think these statements could be dropped. We are doing a show operation, so the option that would fit best is a dict_result, which is what is being done above.\nSo the assert from line 58 could validate not only the ID, but all keys involved, i.e.:\n\nexport_location \u003d export_loc_list[\u0027export_locations\u0027][0]\n\nfor key in result.keys():\n    self.assertEqual(result[key], exportLocation[key])","commit_id":"595131b99d1a39d163c5935fe46dae7a28653577"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"277b5627c6980f5b02106b5117d14d62c516648f","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        self.assertEqual(exp_loc_list[\u0027export_locations\u0027][0][\u0027id\u0027],"},{"line_number":59,"context_line":"                         result[\u0027id\u0027])"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        listing_result \u003d self.listing_result("},{"line_number":62,"context_line":"            \u0027share replica export location\u0027,"},{"line_number":63,"context_line":"            f\u0027show {replica[\"id\"]} {rep_exp_loc_obj[\"ID\"]}\u0027)"},{"line_number":64,"context_line":"        self.assertTableStruct(listing_result, ["},{"line_number":65,"context_line":"            \u0027Field\u0027,"},{"line_number":66,"context_line":"            \u0027Value\u0027"},{"line_number":67,"context_line":"        ])"}],"source_content_type":"text/x-python","patch_set":14,"id":"a8c91022_8c199b94","line":67,"range":{"start_line":61,"start_character":8,"end_line":67,"end_character":10},"in_reply_to":"5f244f75_6e0f6abe","updated":"2022-07-13 16:42:00.000000000","message":"Done","commit_id":"595131b99d1a39d163c5935fe46dae7a28653577"}]}