)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"c413e35cf255bae760801d258733d6b96c7d7bfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34df3fab_ed8d2c03","updated":"2022-05-27 15:29:06.000000000","message":"Looks good, had one comment inline thanks Maari!","commit_id":"ea341069eadca143ca1a412747a46f6f1fad0e34"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3e8163b557a34954f3f8a06e935b92a6ca40c2ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7d165242_de85f7ce","updated":"2022-05-23 19:21:01.000000000","message":"Thanks Fernando! I\u0027ve finished up the patch now and would appreciate a review. :)","commit_id":"ea341069eadca143ca1a412747a46f6f1fad0e34"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7992e9f129d8af01b779be75387b983a2020aa13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"24a87dfe_8985c931","updated":"2022-05-24 19:57:41.000000000","message":"recheck","commit_id":"ea341069eadca143ca1a412747a46f6f1fad0e34"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"47f34ef51092a451f4162a3e9e5dd6c60d07fe52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"19296a4b_e3c85f10","updated":"2022-06-03 14:48:51.000000000","message":"LGTM, thanks Maari!","commit_id":"ee536bd8b5e99b885daa2eb19997add965a47f48"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"38f41c21bc5e541df0d26331decf564faaf05650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2aceffa7_c237b1bb","updated":"2022-06-23 13:38:26.000000000","message":"LGTM, thanks for working on this Maari!","commit_id":"ee536bd8b5e99b885daa2eb19997add965a47f48"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6c04b798745a4b5b4f397c7d45c27913113a2152","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4365c3f3_10518f6f","updated":"2022-06-17 22:27:08.000000000","message":"Looking good, Maari! Thank you for the changes","commit_id":"ee536bd8b5e99b885daa2eb19997add965a47f48"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"be6d937461f1f4950acde26a59ea8448b78b79c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c0cbc95c_0a064e24","updated":"2022-05-27 17:14:37.000000000","message":"Thanks Ashley! I\u0027ve updated the patch, please review at your convenience :) ","commit_id":"ee536bd8b5e99b885daa2eb19997add965a47f48"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ade660b7efc9ac7e1fecc8a7d7d5bca19453c14d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f0f8976_0608ed1e","updated":"2022-06-23 15:37:57.000000000","message":"recheck\n\nthis time out is strange: https://zuul.opendev.org/t/openstack/build/7bc8c78bf2b84d86a9b157502934ada5/log/job-output.txt#918-919","commit_id":"ee536bd8b5e99b885daa2eb19997add965a47f48"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cdf07ebfbde203e57436777204b1fc9af30ead3f","unresolved":true,"context_lines":[{"line_number":200,"context_line":"        if snapshot_support:"},{"line_number":201,"context_line":"            cmd +\u003d f\u0027 --snapshot-support {snapshot_support}\u0027"},{"line_number":202,"context_line":"        if create_share_from_snapshot_support:"},{"line_number":203,"context_line":"            cmd +\u003d f\u0027 --create-share-from-snapshot-support \\"},{"line_number":204,"context_line":"                {create_share_from_snapshot_support}\u0027"},{"line_number":205,"context_line":"        if revert_to_snapshot_support:"},{"line_number":206,"context_line":"            cmd +\u003d f\u0027 --revert-to-snapshot-support \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"2028c483_06c9e3b5","line":203,"updated":"2022-05-23 15:11:09.000000000","message":"I believe this isn\u0027t so problematic for strings but backslashes are more prone to errors. People usually recomends to make use of parentheses for statment continuation and multiline strings.","commit_id":"c76178512487c67df8f4d1ca7cdeefae9367e47a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3e8163b557a34954f3f8a06e935b92a6ca40c2ee","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        if snapshot_support:"},{"line_number":201,"context_line":"            cmd +\u003d f\u0027 --snapshot-support {snapshot_support}\u0027"},{"line_number":202,"context_line":"        if create_share_from_snapshot_support:"},{"line_number":203,"context_line":"            cmd +\u003d f\u0027 --create-share-from-snapshot-support \\"},{"line_number":204,"context_line":"                {create_share_from_snapshot_support}\u0027"},{"line_number":205,"context_line":"        if revert_to_snapshot_support:"},{"line_number":206,"context_line":"            cmd +\u003d f\u0027 --revert-to-snapshot-support \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"17223349_196a9331","line":203,"in_reply_to":"2028c483_06c9e3b5","updated":"2022-05-23 19:21:01.000000000","message":"Thanks Fernando, I dropped the backslashes.","commit_id":"c76178512487c67df8f4d1ca7cdeefae9367e47a"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"cdf07ebfbde203e57436777204b1fc9af30ead3f","unresolved":true,"context_lines":[{"line_number":203,"context_line":"            cmd +\u003d f\u0027 --create-share-from-snapshot-support \\"},{"line_number":204,"context_line":"                {create_share_from_snapshot_support}\u0027"},{"line_number":205,"context_line":"        if revert_to_snapshot_support:"},{"line_number":206,"context_line":"            cmd +\u003d f\u0027 --revert-to-snapshot-support \\"},{"line_number":207,"context_line":"                {revert_to_snapshot_support}\u0027"},{"line_number":208,"context_line":"        if mount_snapshot_support:"},{"line_number":209,"context_line":"            cmd +\u003d f\u0027 --mount-snapshot-support {mount_snapshot_support}\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"4ef86d6c_23899daa","line":206,"updated":"2022-05-23 15:11:09.000000000","message":"same","commit_id":"c76178512487c67df8f4d1ca7cdeefae9367e47a"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3e8163b557a34954f3f8a06e935b92a6ca40c2ee","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            cmd +\u003d f\u0027 --create-share-from-snapshot-support \\"},{"line_number":204,"context_line":"                {create_share_from_snapshot_support}\u0027"},{"line_number":205,"context_line":"        if revert_to_snapshot_support:"},{"line_number":206,"context_line":"            cmd +\u003d f\u0027 --revert-to-snapshot-support \\"},{"line_number":207,"context_line":"                {revert_to_snapshot_support}\u0027"},{"line_number":208,"context_line":"        if mount_snapshot_support:"},{"line_number":209,"context_line":"            cmd +\u003d f\u0027 --mount-snapshot-support {mount_snapshot_support}\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"c96e2f3e_8a23d182","line":206,"in_reply_to":"4ef86d6c_23899daa","updated":"2022-05-23 19:21:01.000000000","message":"Done","commit_id":"c76178512487c67df8f4d1ca7cdeefae9367e47a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"38f41c21bc5e541df0d26331decf564faaf05650","unresolved":true,"context_lines":[{"line_number":201,"context_line":"        return pools"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def create_share_type(self, name\u003dNone, dhss\u003dFalse, description\u003dNone,"},{"line_number":204,"context_line":"                          snapshot_support\u003dNone,"},{"line_number":205,"context_line":"                          create_share_from_snapshot_support\u003dNone,"},{"line_number":206,"context_line":"                          revert_to_snapshot_support\u003dFalse,"},{"line_number":207,"context_line":"                          mount_snapshot_support\u003dFalse, extra_specs\u003d{},"},{"line_number":208,"context_line":"                          public\u003dTrue, add_cleanup\u003dTrue, client\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7314bde6_80ab029a","line":205,"range":{"start_line":204,"start_character":26,"end_line":205,"end_character":66},"updated":"2022-06-23 13:38:26.000000000","message":"nit: these could default to False as well, since they\u0027re optional too, like the rest of them","commit_id":"ee536bd8b5e99b885daa2eb19997add965a47f48"}],"manilaclient/tests/functional/osc/test_share_types.py":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"c413e35cf255bae760801d258733d6b96c7d7bfe","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            f\u0027share type show {share_type[\"id\"]} -f json\u0027"},{"line_number":99,"context_line":"        ))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertNotIn(\u0027bar\u0027, share_type[\"optional_extra_specs\"])"},{"line_number":102,"context_line":"        self.assertNotIn("},{"line_number":103,"context_line":"            \u0027snapshot_support\u0027, share_type[\"optional_extra_specs\"])"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"78a2915f_7d4b5d42","line":101,"range":{"start_line":101,"start_character":26,"end_line":101,"end_character":29},"updated":"2022-05-27 15:29:06.000000000","message":"should this be \"foo\"?","commit_id":"ea341069eadca143ca1a412747a46f6f1fad0e34"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"be6d937461f1f4950acde26a59ea8448b78b79c8","unresolved":true,"context_lines":[{"line_number":98,"context_line":"            f\u0027share type show {share_type[\"id\"]} -f json\u0027"},{"line_number":99,"context_line":"        ))"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        self.assertNotIn(\u0027bar\u0027, share_type[\"optional_extra_specs\"])"},{"line_number":102,"context_line":"        self.assertNotIn("},{"line_number":103,"context_line":"            \u0027snapshot_support\u0027, share_type[\"optional_extra_specs\"])"},{"line_number":104,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7138cc2e_2cbc5184","line":101,"range":{"start_line":101,"start_character":26,"end_line":101,"end_character":29},"in_reply_to":"78a2915f_7d4b5d42","updated":"2022-05-27 17:14:37.000000000","message":"I guess both should get point across but I agree with you, made the change in patch set 4 :)","commit_id":"ea341069eadca143ca1a412747a46f6f1fad0e34"}]}