)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"db4a1e9c_e78628d5","updated":"2022-05-27 19:38:43.000000000","message":"Thanks for working on this Franca!\nI left some notes for you inline and also here are some steps you can use to test the functionality of the changes you are making: https://paste.opendev.org/show/bsyxzmFe5F2a0efWPI0b/\nLet me know if you have any questions :) ","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"d250e8e9b37eb3874128725a06814bbaddecbb14","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"67ffa34f_5bc1ea13","updated":"2022-06-02 14:11:44.000000000","message":"Thank you for the enhancements suggested by Maari! :)\nChange is looking in a good shape, but I see some unit and functional tests failing. Could you please take a look at those?","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"47964b29_fb914da8","updated":"2022-06-03 08:26:31.000000000","message":"Thanks Franca, looking good, let\u0027s try to fix the tests also :) ","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e49559c2d28242220c0130b9cbc1a16faa7e675b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3fa45099_32e551f4","updated":"2022-06-06 10:12:55.000000000","message":"Looks good Franca! I added just one more nit, you choose if you wish to address it or not :) \nI\u0027ll add my +2 either way after Zuul has run. Thank you!","commit_id":"bedefd0a7b1fc67e32617acacef795b7d3ec2e12"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"17e0b13b6a9eb59a907c658663f7a3c6a22bd58d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8fae1a1d_fd109fc1","updated":"2022-06-15 13:35:46.000000000","message":"Tested in my environment, it looks good.\nThank you, Franca!","commit_id":"bedefd0a7b1fc67e32617acacef795b7d3ec2e12"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    \u0027share_type\u0027,"},{"line_number":46,"context_line":"    \u0027share_group_id\u0027,"},{"line_number":47,"context_line":"    \u0027export_location_id\u0027,"},{"line_number":48,"context_line":"    \u0027export_location_path\u0027,"},{"line_number":49,"context_line":"    \u0027host\u0027,"},{"line_number":50,"context_line":"    \u0027user_id\u0027,"},{"line_number":51,"context_line":"    \u0027project_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4cce2932_90a502bb","line":48,"updated":"2022-05-27 19:38:43.000000000","message":"this is not necessary, we only need to add the option to filter list results.","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    \u0027share_type\u0027,"},{"line_number":46,"context_line":"    \u0027share_group_id\u0027,"},{"line_number":47,"context_line":"    \u0027export_location_id\u0027,"},{"line_number":48,"context_line":"    \u0027export_location_path\u0027,"},{"line_number":49,"context_line":"    \u0027host\u0027,"},{"line_number":50,"context_line":"    \u0027user_id\u0027,"},{"line_number":51,"context_line":"    \u0027project_id\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4c7b98d8_8e6563ed","line":48,"in_reply_to":"4cce2932_90a502bb","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":76,"context_line":"    \u0027Share Network ID\u0027,"},{"line_number":77,"context_line":"    \u0027Share Server ID\u0027,"},{"line_number":78,"context_line":"    \u0027Export Location ID\u0027,"},{"line_number":79,"context_line":"    \u0027Eport Location Path\u0027,"},{"line_number":80,"context_line":"    \u0027Share Type\u0027,"},{"line_number":81,"context_line":"    \u0027Share Group ID\u0027,"},{"line_number":82,"context_line":"    \u0027Host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f28b390_0053c535","line":79,"updated":"2022-05-27 19:38:43.000000000","message":"same here, no need to add these.","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    \u0027Share Network ID\u0027,"},{"line_number":77,"context_line":"    \u0027Share Server ID\u0027,"},{"line_number":78,"context_line":"    \u0027Export Location ID\u0027,"},{"line_number":79,"context_line":"    \u0027Eport Location Path\u0027,"},{"line_number":80,"context_line":"    \u0027Share Type\u0027,"},{"line_number":81,"context_line":"    \u0027Share Group ID\u0027,"},{"line_number":82,"context_line":"    \u0027Host\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"952c3820_d158fe08","line":79,"in_reply_to":"1f28b390_0053c535","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":383,"context_line":"            help\u003d_(\u0027Filter shares by snapshot name or id.\u0027),"},{"line_number":384,"context_line":"        )"},{"line_number":385,"context_line":"        parser.add_argument("},{"line_number":386,"context_line":"            \u0027--export_location\u0027,"},{"line_number":387,"context_line":"            metavar\u003d\u0027\u003cexport-location-id-or-path\u003e\u0027,"},{"line_number":388,"context_line":"            help\u003d_(\u0027Filter shares by export location id or path.\u0027),"},{"line_number":389,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"5848886d_ab0862b8","line":386,"range":{"start_line":386,"start_character":13,"end_line":386,"end_character":30},"updated":"2022-05-27 19:38:43.000000000","message":"--export-location (use hyphens not underscores)","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            help\u003d_(\u0027Filter shares by snapshot name or id.\u0027),"},{"line_number":384,"context_line":"        )"},{"line_number":385,"context_line":"        parser.add_argument("},{"line_number":386,"context_line":"            \u0027--export_location\u0027,"},{"line_number":387,"context_line":"            metavar\u003d\u0027\u003cexport-location-id-or-path\u003e\u0027,"},{"line_number":388,"context_line":"            help\u003d_(\u0027Filter shares by export location id or path.\u0027),"},{"line_number":389,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":1,"id":"f336169e_cf37f62c","line":386,"range":{"start_line":386,"start_character":13,"end_line":386,"end_character":30},"in_reply_to":"5848886d_ab0862b8","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":384,"context_line":"        )"},{"line_number":385,"context_line":"        parser.add_argument("},{"line_number":386,"context_line":"            \u0027--export_location\u0027,"},{"line_number":387,"context_line":"            metavar\u003d\u0027\u003cexport-location-id-or-path\u003e\u0027,"},{"line_number":388,"context_line":"            help\u003d_(\u0027Filter shares by export location id or path.\u0027),"},{"line_number":389,"context_line":"        )"},{"line_number":390,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"15ce2f8d_5589d41d","line":387,"range":{"start_line":387,"start_character":21,"end_line":387,"end_character":48},"updated":"2022-05-27 19:38:43.000000000","message":"\u003cexport-location\u003e","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":384,"context_line":"        )"},{"line_number":385,"context_line":"        parser.add_argument("},{"line_number":386,"context_line":"            \u0027--export_location\u0027,"},{"line_number":387,"context_line":"            metavar\u003d\u0027\u003cexport-location-id-or-path\u003e\u0027,"},{"line_number":388,"context_line":"            help\u003d_(\u0027Filter shares by export location id or path.\u0027),"},{"line_number":389,"context_line":"        )"},{"line_number":390,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"1c08ddb3_34ba39e1","line":387,"range":{"start_line":387,"start_character":21,"end_line":387,"end_character":48},"in_reply_to":"15ce2f8d_5589d41d","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":385,"context_line":"        parser.add_argument("},{"line_number":386,"context_line":"            \u0027--export_location\u0027,"},{"line_number":387,"context_line":"            metavar\u003d\u0027\u003cexport-location-id-or-path\u003e\u0027,"},{"line_number":388,"context_line":"            help\u003d_(\u0027Filter shares by export location id or path.\u0027),"},{"line_number":389,"context_line":"        )"},{"line_number":390,"context_line":"        parser.add_argument("},{"line_number":391,"context_line":"            \u0027--public\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"04a261db_7c69b57e","line":388,"range":{"start_line":388,"start_character":64,"end_line":388,"end_character":65},"updated":"2022-05-27 19:38:43.000000000","message":"Add: \"Available only for microversion \u003e\u003d 2.35\"","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":385,"context_line":"        parser.add_argument("},{"line_number":386,"context_line":"            \u0027--export_location\u0027,"},{"line_number":387,"context_line":"            metavar\u003d\u0027\u003cexport-location-id-or-path\u003e\u0027,"},{"line_number":388,"context_line":"            help\u003d_(\u0027Filter shares by export location id or path.\u0027),"},{"line_number":389,"context_line":"        )"},{"line_number":390,"context_line":"        parser.add_argument("},{"line_number":391,"context_line":"            \u0027--public\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9edc3cc5_4850d379","line":388,"range":{"start_line":388,"start_character":64,"end_line":388,"end_character":65},"in_reply_to":"04a261db_7c69b57e","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":499,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":500,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        # TODO(gouthamr): Add support for export_location filtering"},{"line_number":503,"context_line":"        if parsed_args.long:"},{"line_number":504,"context_line":"            columns \u003d SHARE_ATTRIBUTES"},{"line_number":505,"context_line":"            column_headers \u003d SHARE_ATTRIBUTES_HEADERS"}],"source_content_type":"text/x-python","patch_set":1,"id":"d11e75fd_992f0d4f","line":502,"range":{"start_line":502,"start_character":8,"end_line":502,"end_character":67},"updated":"2022-05-27 19:38:43.000000000","message":"Delete this comment, as you are taking care of this :)","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":500,"context_line":"        identity_client \u003d self.app.client_manager.identity"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"        # TODO(gouthamr): Add support for export_location filtering"},{"line_number":503,"context_line":"        if parsed_args.long:"},{"line_number":504,"context_line":"            columns \u003d SHARE_ATTRIBUTES"},{"line_number":505,"context_line":"            column_headers \u003d SHARE_ATTRIBUTES_HEADERS"}],"source_content_type":"text/x-python","patch_set":1,"id":"41b58e44_0cd8b661","line":502,"range":{"start_line":502,"start_character":8,"end_line":502,"end_character":67},"in_reply_to":"d11e75fd_992f0d4f","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":581,"context_line":"            export_location_path \u003d apiutils.find_resource("},{"line_number":582,"context_line":"                share_client.export_locations,"},{"line_number":583,"context_line":"                parsed_agrs.export_location).path"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        search_opts \u003d {"},{"line_number":586,"context_line":"            \u0027all_tenants\u0027: all_tenants,"},{"line_number":587,"context_line":"            \u0027is_public\u0027: parsed_args.public,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbbcf8e2_1a7c9034","line":584,"updated":"2022-05-27 19:38:43.000000000","message":"The argument we are adding should work with either id or path, you got the right idea. But, we don\u0027t need to really know here what was provided; we should just pass on the parsed_args.export_location value to the API and let it do it\u0027s thing :) \nWe do however need to check for the API microversion. Basically, you\u0027ll need recreate the functionality from the manila command:\nhttps://github.com/openstack/python-manilaclient/blob/master/manilaclient/v2/shell.py#L2486-L2492\n\nAnd you probably want to move the whole thing *after* the search_opts definition","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            export_location_path \u003d apiutils.find_resource("},{"line_number":582,"context_line":"                share_client.export_locations,"},{"line_number":583,"context_line":"                parsed_agrs.export_location).path"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        search_opts \u003d {"},{"line_number":586,"context_line":"            \u0027all_tenants\u0027: all_tenants,"},{"line_number":587,"context_line":"            \u0027is_public\u0027: parsed_args.public,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f91eb00f_a6ba1043","line":584,"in_reply_to":"dbbcf8e2_1a7c9034","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"df046b3c2ccd0fd993bca3e967791c531140d67a","unresolved":true,"context_lines":[{"line_number":596,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":597,"context_line":"            \u0027share_network_id\u0027: share_network_id,"},{"line_number":598,"context_line":"            \u0027export_location_id\u0027: export_location_id,"},{"line_number":599,"context_line":"            \u0027export_location_path\u0027: export_location_path,"},{"line_number":600,"context_line":"            \u0027share_type_id\u0027: share_type_id,"},{"line_number":601,"context_line":"            \u0027snapshot_id\u0027: snapshot_id,"},{"line_number":602,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7b513cac_4ad133e0","line":599,"updated":"2022-05-27 19:38:43.000000000","message":"these search options do not exists on the backend, there is only \u0027export_location\u0027 option, see the linked code in above comment.","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":false,"context_lines":[{"line_number":596,"context_line":"            \u0027share_server_id\u0027: share_server_id,"},{"line_number":597,"context_line":"            \u0027share_network_id\u0027: share_network_id,"},{"line_number":598,"context_line":"            \u0027export_location_id\u0027: export_location_id,"},{"line_number":599,"context_line":"            \u0027export_location_path\u0027: export_location_path,"},{"line_number":600,"context_line":"            \u0027share_type_id\u0027: share_type_id,"},{"line_number":601,"context_line":"            \u0027snapshot_id\u0027: snapshot_id,"},{"line_number":602,"context_line":"            \u0027share_group_id\u0027: share_group_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"6836a4e2_fb609e1c","line":599,"in_reply_to":"7b513cac_4ad133e0","updated":"2022-06-03 08:26:31.000000000","message":"Done","commit_id":"8da7a54499b588c8c60d68a7e91505c661dc280f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9a182cbe8f5735bfb4ba5e0dbc656006d5cef1c7","unresolved":true,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"},{"line_number":591,"context_line":"            search_opts[\u0027export_location\u0027] \u003d getattr(parsed_args,"},{"line_number":592,"context_line":"                                                     \u0027export-location\u0027)"},{"line_number":593,"context_line":"        elif (getattr(parsed_args, \u0027export-location\u0027)):"},{"line_number":594,"context_line":"            raise exceptions.CommandError("},{"line_number":595,"context_line":"                \"Filtering by export location is only \""}],"source_content_type":"text/x-python","patch_set":3,"id":"77ffc3f7_ee8e91f0","line":592,"range":{"start_line":592,"start_character":59,"end_line":592,"end_character":62},"updated":"2022-06-02 14:12:53.000000000","message":"The parser will convert things to use underscore\nSo this is supposed to use underscores :)","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"4bb24d2ffd0bf1f595ce78167e8dcb367f53ffe2","unresolved":true,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"},{"line_number":591,"context_line":"            search_opts[\u0027export_location\u0027] \u003d getattr(parsed_args,"},{"line_number":592,"context_line":"                                                     \u0027export-location\u0027)"},{"line_number":593,"context_line":"        elif (getattr(parsed_args, \u0027export-location\u0027)):"},{"line_number":594,"context_line":"            raise exceptions.CommandError("},{"line_number":595,"context_line":"                \"Filtering by export location is only \""}],"source_content_type":"text/x-python","patch_set":3,"id":"b0bb02cc_3979a33a","line":592,"range":{"start_line":592,"start_character":59,"end_line":592,"end_character":62},"in_reply_to":"77ffc3f7_ee8e91f0","updated":"2022-06-03 08:26:31.000000000","message":"I\u0027d suggest also:\n  search_opts[\u0027export_location\u0027] \u003d parsed_args.export_location","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"7b6b2891dc320a37a3847c6e5f2a2ee5af72914b","unresolved":false,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"},{"line_number":591,"context_line":"            search_opts[\u0027export_location\u0027] \u003d getattr(parsed_args,"},{"line_number":592,"context_line":"                                                     \u0027export-location\u0027)"},{"line_number":593,"context_line":"        elif (getattr(parsed_args, \u0027export-location\u0027)):"},{"line_number":594,"context_line":"            raise exceptions.CommandError("},{"line_number":595,"context_line":"                \"Filtering by export location is only \""}],"source_content_type":"text/x-python","patch_set":3,"id":"90863943_08d62d9c","line":592,"range":{"start_line":592,"start_character":59,"end_line":592,"end_character":62},"in_reply_to":"b0bb02cc_3979a33a","updated":"2022-06-06 13:42:42.000000000","message":"Done","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"9a182cbe8f5735bfb4ba5e0dbc656006d5cef1c7","unresolved":true,"context_lines":[{"line_number":590,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"},{"line_number":591,"context_line":"            search_opts[\u0027export_location\u0027] \u003d getattr(parsed_args,"},{"line_number":592,"context_line":"                                                     \u0027export-location\u0027)"},{"line_number":593,"context_line":"        elif (getattr(parsed_args, \u0027export-location\u0027)):"},{"line_number":594,"context_line":"            raise exceptions.CommandError("},{"line_number":595,"context_line":"                \"Filtering by export location is only \""},{"line_number":596,"context_line":"                \"available with manila API version \u003e\u003d 2.35\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"5df4d77f_3c6cef9d","line":593,"range":{"start_line":593,"start_character":42,"end_line":593,"end_character":43},"updated":"2022-06-02 14:12:53.000000000","message":"same as above","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"7b6b2891dc320a37a3847c6e5f2a2ee5af72914b","unresolved":false,"context_lines":[{"line_number":590,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"},{"line_number":591,"context_line":"            search_opts[\u0027export_location\u0027] \u003d getattr(parsed_args,"},{"line_number":592,"context_line":"                                                     \u0027export-location\u0027)"},{"line_number":593,"context_line":"        elif (getattr(parsed_args, \u0027export-location\u0027)):"},{"line_number":594,"context_line":"            raise exceptions.CommandError("},{"line_number":595,"context_line":"                \"Filtering by export location is only \""},{"line_number":596,"context_line":"                \"available with manila API version \u003e\u003d 2.35\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"dd8f8484_3814796b","line":593,"range":{"start_line":593,"start_character":42,"end_line":593,"end_character":43},"in_reply_to":"5df4d77f_3c6cef9d","updated":"2022-06-06 13:42:42.000000000","message":"Done","commit_id":"c553efa3292db225c2d6261afff8eda8ae7f2f01"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e49559c2d28242220c0130b9cbc1a16faa7e675b","unresolved":true,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"},{"line_number":591,"context_line":"            search_opts[\u0027export_location\u0027] \u003d parsed_args.export_location"},{"line_number":592,"context_line":"        elif (getattr(parsed_args, \u0027export_location\u0027)):"},{"line_number":593,"context_line":"            raise exceptions.CommandError("},{"line_number":594,"context_line":"                \"Filtering by export location is only \""},{"line_number":595,"context_line":"                \"available with manila API version \u003e\u003d 2.35\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"c3fa2f60_1394e3c7","line":592,"range":{"start_line":592,"start_character":13,"end_line":592,"end_character":54},"updated":"2022-06-06 10:12:55.000000000","message":"nit: this could also be parsed_args.export_location to simplify further :)","commit_id":"bedefd0a7b1fc67e32617acacef795b7d3ec2e12"}]}