)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"2c3cc79e9e3360c4d845155b6dff52bcba7156f4","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Maari Tamm \u003cmaari.tamm@citynetwork.eu\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-01 14:50:21 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[OSC] Implement Share Migration show and add task-state argument to Share Set Command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds \u0027openstack share migration show\u0027 and"},{"line_number":10,"context_line":"add argument \u0027--task-state\u0027 to \u0027openstack share set\u0027 command,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"c38abac5_6c859df5","line":7,"updated":"2022-07-01 15:08:49.000000000","message":"nit: reword the title to wrap it in one line.","commit_id":"24348c7ecb9157d10e6a9865a468b033078a4e7c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"029cde67eff840f6f791ddb1574e8707ee11f088","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57fbe906_5be58417","updated":"2022-06-03 19:52:09.000000000","message":"Thanks for working on this Namrata! Looks like we had some miscommunication about the task-state command, I left notes inline, let me know if you have any questions :) ","commit_id":"582ee72a4ae9cd5eba32149ea2d16fcbe6fb659e"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"67e8f87d8c68498c9334dfa43223735026bde137","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"560df1bb_6c309995","in_reply_to":"57fbe906_5be58417","updated":"2022-06-05 05:09:49.000000000","message":"Fixing in patchset3. Sorry for misunderstanding the task-state command.","commit_id":"582ee72a4ae9cd5eba32149ea2d16fcbe6fb659e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"2c3cc79e9e3360c4d845155b6dff52bcba7156f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"caba580c_97727d94","updated":"2022-07-01 15:08:49.000000000","message":"Thanks Namrata! I left notes inline on how we should handle the show command result, please have look whenever convenient :) ","commit_id":"24348c7ecb9157d10e6a9865a468b033078a4e7c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6fed98a45af02f5829514ea9a846d87d7647de4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8dc9b8e4_c3c41725","updated":"2022-08-01 17:56:14.000000000","message":"Can you check the comment inline regarding the missing space; the fix can come in a follow up change. Thanks Namrata!","commit_id":"8fedd08b278fd012c42b718a0bed502e5551dde0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"92a1f7ec5872cdf7b1f65a4a8cb0229022ebd1dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"15acf29a_e0f18ada","updated":"2022-07-28 18:39:22.000000000","message":"Thank you, Namrata!\nTested both migration show and share set commands and it is working just fine.","commit_id":"8fedd08b278fd012c42b718a0bed502e5551dde0"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"029cde67eff840f6f791ddb1574e8707ee11f088","unresolved":true,"context_lines":[{"line_number":1356,"context_line":"        cliutils.print_dict(result[1])"},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"class ShareMigrationTaskState(command.Command):"},{"line_number":1360,"context_line":"    \"\"\"Explicitly update the task state of a share"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    (Admin only, Experimental)."}],"source_content_type":"text/x-python","patch_set":2,"id":"603c61f5_2aa48b41","line":1359,"updated":"2022-06-03 19:52:09.000000000","message":"This should not be a separate command, instead it should be an additional argument to \u0027openstack share set\u0027 command, implemented in this file above.\nSo, the command should work like:\n  openstack share set \u003cshare\u003e --task-state \u003cstate\u003e\n\nApologies that the task description was not clear enough.","commit_id":"582ee72a4ae9cd5eba32149ea2d16fcbe6fb659e"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"67e8f87d8c68498c9334dfa43223735026bde137","unresolved":false,"context_lines":[{"line_number":1356,"context_line":"        cliutils.print_dict(result[1])"},{"line_number":1357,"context_line":""},{"line_number":1358,"context_line":""},{"line_number":1359,"context_line":"class ShareMigrationTaskState(command.Command):"},{"line_number":1360,"context_line":"    \"\"\"Explicitly update the task state of a share"},{"line_number":1361,"context_line":""},{"line_number":1362,"context_line":"    (Admin only, Experimental)."}],"source_content_type":"text/x-python","patch_set":2,"id":"cff9b760_06ad991d","line":1359,"in_reply_to":"603c61f5_2aa48b41","updated":"2022-06-05 05:09:49.000000000","message":"Ack","commit_id":"582ee72a4ae9cd5eba32149ea2d16fcbe6fb659e"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"2c3cc79e9e3360c4d845155b6dff52bcba7156f4","unresolved":true,"context_lines":[{"line_number":716,"context_line":"                   \"migration_driver_phase1_done, data_copying_starting, \""},{"line_number":717,"context_line":"                   \"data_copying_in_progress, data_copying_completing, \""},{"line_number":718,"context_line":"                   \"data_copying_completed, data_copying_cancelled, \""},{"line_number":719,"context_line":"                   \"data_copying_error. If no value is provided, None will \""},{"line_number":720,"context_line":"                   \"be used.\")"},{"line_number":721,"context_line":"        )"},{"line_number":722,"context_line":"        return parser"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"55d851da_1e1a7f96","line":720,"range":{"start_line":719,"start_character":40,"end_line":720,"end_character":28},"updated":"2022-07-01 15:08:49.000000000","message":"nit: this could be misleading. Since this is now an optional argument in a set command and not a command on its own, if no value is provided, state will not be affected. I\u0027d suggest to drop this line.","commit_id":"24348c7ecb9157d10e6a9865a468b033078a4e7c"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"bac5a90c2a02db86a7fe4f0c12ca49aa908b823d","unresolved":false,"context_lines":[{"line_number":716,"context_line":"                   \"migration_driver_phase1_done, data_copying_starting, \""},{"line_number":717,"context_line":"                   \"data_copying_in_progress, data_copying_completing, \""},{"line_number":718,"context_line":"                   \"data_copying_completed, data_copying_cancelled, \""},{"line_number":719,"context_line":"                   \"data_copying_error. If no value is provided, None will \""},{"line_number":720,"context_line":"                   \"be used.\")"},{"line_number":721,"context_line":"        )"},{"line_number":722,"context_line":"        return parser"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"709aceb5_041a0364","line":720,"range":{"start_line":719,"start_character":40,"end_line":720,"end_character":28},"in_reply_to":"55d851da_1e1a7f96","updated":"2022-07-28 17:23:01.000000000","message":"Done","commit_id":"24348c7ecb9157d10e6a9865a468b033078a4e7c"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"2c3cc79e9e3360c4d845155b6dff52bcba7156f4","unresolved":true,"context_lines":[{"line_number":1387,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1388,"context_line":"                                       parsed_args.share)"},{"line_number":1389,"context_line":"        result \u003d share.migration_get_progress()"},{"line_number":1390,"context_line":"        cliutils.print_dict(result[1])"}],"source_content_type":"text/x-python","patch_set":5,"id":"81a4adad_3aea8a5c","line":1390,"range":{"start_line":1390,"start_character":8,"end_line":1390,"end_character":38},"updated":"2022-07-01 15:08:49.000000000","message":"this should return self.dict2columns() as we do for other ShowOne commands.","commit_id":"24348c7ecb9157d10e6a9865a468b033078a4e7c"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"bac5a90c2a02db86a7fe4f0c12ca49aa908b823d","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"        share \u003d apiutils.find_resource(share_client.shares,"},{"line_number":1388,"context_line":"                                       parsed_args.share)"},{"line_number":1389,"context_line":"        result \u003d share.migration_get_progress()"},{"line_number":1390,"context_line":"        cliutils.print_dict(result[1])"}],"source_content_type":"text/x-python","patch_set":5,"id":"261641c2_44438142","line":1390,"range":{"start_line":1390,"start_character":8,"end_line":1390,"end_character":38},"in_reply_to":"81a4adad_3aea8a5c","updated":"2022-07-28 17:23:01.000000000","message":"Done","commit_id":"24348c7ecb9157d10e6a9865a468b033078a4e7c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b6fed98a45af02f5829514ea9a846d87d7647de4","unresolved":true,"context_lines":[{"line_number":762,"context_line":"            try:"},{"line_number":763,"context_line":"                share_obj.reset_task_state(parsed_args.task_state)"},{"line_number":764,"context_line":"            except Exception as e:"},{"line_number":765,"context_line":"                LOG.error(_(\"Failed to update share task state\""},{"line_number":766,"context_line":"                          \"%s\"), e)"},{"line_number":767,"context_line":"                result +\u003d 1"},{"line_number":768,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5ab28076_bee9625f","line":765,"range":{"start_line":765,"start_character":62,"end_line":765,"end_character":63},"updated":"2022-08-01 17:56:14.000000000","message":"missing space before end quote","commit_id":"8fedd08b278fd012c42b718a0bed502e5551dde0"}]}