)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"72386c998e6588b8c8055cd23159f01bf9fa5cec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":11,"id":"dde06db1_87f3b3f9","line":15,"updated":"2022-06-30 11:51:58.000000000","message":"In order to get the soft delete operation working, I think you have two approaches:\n1) Adding a depends on to the soft-delete change and that change would be applied here before this change is applied\n2) performing a rebase and making this change to be on top of the other\nI can help you out with that if you want... Please ping me in case :)","commit_id":"0d0e782b9f6620daa1b3c37c195c6d1a353fd657"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"e22df5e41355b3da4a98aa5db4893b666bfb529a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"49d4450b_31977d37","line":15,"in_reply_to":"dde06db1_87f3b3f9","updated":"2022-07-04 08:13:49.000000000","message":"Done","commit_id":"0d0e782b9f6620daa1b3c37c195c6d1a353fd657"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"72386c998e6588b8c8055cd23159f01bf9fa5cec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"93d57bdf_bff9b88b","updated":"2022-06-30 11:51:58.000000000","message":"Thank you for working on this change, Franca\nAdded a few comments for you. Please check them inline","commit_id":"0d0e782b9f6620daa1b3c37c195c6d1a353fd657"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3043da8ca15a6dc17903ae2300006e88c42cde12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"409dcfe7_1dc01b0f","updated":"2022-07-11 13:23:13.000000000","message":"Thanks Franca, the change is looking good! I noticed an issue with trying to restore multiple shares, left the note inline, please have a look, thanks!","commit_id":"4189ff364a52fb09e905907c6307563b1472a1c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55d795e1ba7937beaf32c82c96751017fa686f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"7414b0d8_b8cb45cf","updated":"2022-07-20 16:55:00.000000000","message":"Thank you for your work, Franca! Please check some more comments inline...","commit_id":"ee21f2ea65a809e67668aed4d63ae7714f9c8ccf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a07e1d55fe8416088f897ce154780503d2be133","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"0940d321_084e90e5","updated":"2022-07-27 20:57:46.000000000","message":"Thank you for working on the updates, I found a few things in the implementation. Please check the comments inline.","commit_id":"06018bcb40e7d918b24a830e4bda453884448217"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"69d68b7fa6c90532fb6bd6f02a30ff1419561718","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"9cf54d34_7b32ddb1","updated":"2022-08-01 20:51:17.000000000","message":"Thank you for the changes, Franca! It is looking good.\nSome other OSC changes merged in the meantime - Could you please rebase this change as it is showing a merge conflict?","commit_id":"2446747138de984afda68b27950308d707da1239"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"0e918b5e7526a82e1a546ea0e29d804e449ed21c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5debfe6a_b5dda44f","in_reply_to":"9cf54d34_7b32ddb1","updated":"2022-08-03 20:15:15.000000000","message":"\u003e Thank you for the changes, Franca! It is looking good.\n\u003e Some other OSC changes merged in the meantime - Could you please rebase this change as it is showing a merge conflict?\n\nDone","commit_id":"2446747138de984afda68b27950308d707da1239"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7c46d1fb223559ee9cb8497a3ad88a04edf00ad4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"1392f2e4_b1fb426e","updated":"2022-08-15 18:09:39.000000000","message":"LGTM. Thank you, Franca!","commit_id":"1f168eafe5c2b758b25cd9a3bab67d77ceacb0e0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"aa4345884ec4446c8db7f45218bb7d2a0f9dbc70","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"e03ea73a_00ccf737","updated":"2022-08-17 11:31:28.000000000","message":"Thanks Franca, please add a microversion check as well :) ","commit_id":"1f168eafe5c2b758b25cd9a3bab67d77ceacb0e0"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"1845263fb0c1c8ecbf83a8bfb2c3861a67053431","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":32,"id":"db93a03e_d723aa03","updated":"2022-08-15 10:00:59.000000000","message":"recheck","commit_id":"1f168eafe5c2b758b25cd9a3bab67d77ceacb0e0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"be08ed840c1dd0430f23b153739037d9a9f009d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"24099362_f9d4ec7f","updated":"2022-08-17 15:01:58.000000000","message":"Thanks Franca, almost there :) One more note inline!","commit_id":"08aa9065942d1dcdd55e5b165789e90de49ae341"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1ff9494ebadc9ca5021830a94473be9e44fe4eb4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"ac78a95c_0f8792ad","updated":"2022-08-18 14:40:54.000000000","message":"LGTM, working just fine as well! Thank you","commit_id":"8f53399e15df20f8c6b1b0cb468e4f77eda1a719"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"786d7dce77d33da9c02b79e93b457551030fe97c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":34,"id":"a77ee0ff_424ee6b8","updated":"2022-08-18 14:34:01.000000000","message":"Thanks Franca, lgtm! :) ","commit_id":"8f53399e15df20f8c6b1b0cb468e4f77eda1a719"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3043da8ca15a6dc17903ae2300006e88c42cde12","unresolved":true,"context_lines":[{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"            except Exception as e:"},{"line_number":1405,"context_line":"                failure_count +\u003d 1"},{"line_number":1406,"context_line":"                Log.error(_(\"Failed to restore share with \""},{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"            if failure_count \u003e 0:"},{"line_number":1411,"context_line":"                total \u003d len(parsed_args.share)"}],"source_content_type":"text/x-python","patch_set":20,"id":"786fbd8a_50210072","line":1408,"range":{"start_line":1406,"start_character":16,"end_line":1408,"end_character":51},"updated":"2022-07-11 13:23:13.000000000","message":"nit: we could use f-strings, see: https://docs.python.org/3/tutorial/inputoutput.html#formatted-string-literals","commit_id":"4189ff364a52fb09e905907c6307563b1472a1c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55d795e1ba7937beaf32c82c96751017fa686f56","unresolved":true,"context_lines":[{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"            except Exception as e:"},{"line_number":1405,"context_line":"                failure_count +\u003d 1"},{"line_number":1406,"context_line":"                Log.error(_(\"Failed to restore share with \""},{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"            if failure_count \u003e 0:"},{"line_number":1411,"context_line":"                total \u003d len(parsed_args.share)"}],"source_content_type":"text/x-python","patch_set":20,"id":"2e07a8f2_1fd3fce6","line":1408,"range":{"start_line":1406,"start_character":16,"end_line":1408,"end_character":51},"in_reply_to":"786fbd8a_50210072","updated":"2022-07-20 16:55:00.000000000","message":"++ - it would become something like:\nmsg \u003d (f\"Failed to restore share\n        \"with name or ID {share}: {e}\")\nmsg \u003d _(msg)","commit_id":"4189ff364a52fb09e905907c6307563b1472a1c8"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"7dcb31403048e3084e903750cb0f843eaf2b24fe","unresolved":false,"context_lines":[{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"            except Exception as e:"},{"line_number":1405,"context_line":"                failure_count +\u003d 1"},{"line_number":1406,"context_line":"                Log.error(_(\"Failed to restore share with \""},{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"            if failure_count \u003e 0:"},{"line_number":1411,"context_line":"                total \u003d len(parsed_args.share)"}],"source_content_type":"text/x-python","patch_set":20,"id":"b5b9cda8_4ace8ca2","line":1408,"range":{"start_line":1406,"start_character":16,"end_line":1408,"end_character":51},"in_reply_to":"786fbd8a_50210072","updated":"2022-08-01 15:30:56.000000000","message":"Done","commit_id":"4189ff364a52fb09e905907c6307563b1472a1c8"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3043da8ca15a6dc17903ae2300006e88c42cde12","unresolved":true,"context_lines":[{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"            if failure_count \u003e 0:"},{"line_number":1411,"context_line":"                total \u003d len(parsed_args.share)"},{"line_number":1412,"context_line":"                msg \u003d (_(\"Failed to restore %(failure_count)s out of %(total)s\""},{"line_number":1413,"context_line":"                         \" shares.\") % {\u0027failure_count\u0027: failure_count,"},{"line_number":1414,"context_line":"                                        \u0027total\u0027: total})"},{"line_number":1415,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"4d15cb03_2f953004","line":1415,"range":{"start_line":1410,"start_character":12,"end_line":1415,"end_character":50},"updated":"2022-07-11 13:23:13.000000000","message":"I believe this should be outside of the for loop :) \nOtherwise if one share restore fails, the next is not event tried because we are already throwing an error, right?","commit_id":"4189ff364a52fb09e905907c6307563b1472a1c8"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"7dcb31403048e3084e903750cb0f843eaf2b24fe","unresolved":false,"context_lines":[{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"            if failure_count \u003e 0:"},{"line_number":1411,"context_line":"                total \u003d len(parsed_args.share)"},{"line_number":1412,"context_line":"                msg \u003d (_(\"Failed to restore %(failure_count)s out of %(total)s\""},{"line_number":1413,"context_line":"                         \" shares.\") % {\u0027failure_count\u0027: failure_count,"},{"line_number":1414,"context_line":"                                        \u0027total\u0027: total})"},{"line_number":1415,"context_line":"                raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7108f5fe_401bc2ee","line":1415,"range":{"start_line":1410,"start_character":12,"end_line":1415,"end_character":50},"in_reply_to":"4d15cb03_2f953004","updated":"2022-08-01 15:30:56.000000000","message":"Done","commit_id":"4189ff364a52fb09e905907c6307563b1472a1c8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"55d795e1ba7937beaf32c82c96751017fa686f56","unresolved":true,"context_lines":[{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"        if failure_count \u003e 0:"},{"line_number":1411,"context_line":"            total \u003d len(parsed_args.share)"},{"line_number":1412,"context_line":"            msg \u003d (_(f\"Failed to restore {0}s out of {1}s shares.\","},{"line_number":1413,"context_line":"                     failure_count, total))"},{"line_number":1414,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"7d05b9fe_2473a5b8","line":1413,"range":{"start_line":1412,"start_character":18,"end_line":1413,"end_character":43},"updated":"2022-07-20 16:55:00.000000000","message":"I think this message might not work as it is, at least not looking to my local tests [1]...\nInstead, you could do:\n\nmsg \u003d f\"Failed to restore {failure_count} out of {total} shares.\"\nmsg \u003d _(msg)\n\nIn the way you are doing, you would need to add a .format(), as stated in [2].\nAlso, there is an issue with using f strings inside i18n (i.e. _()), so I think this should do the trick :)\n\n[1] https://paste.opendev.org/show/bhDeAdWpyTiOr2N7P351/\n[2] https://docs.python.org/3/tutorial/inputoutput.html#the-string-format-method","commit_id":"ee21f2ea65a809e67668aed4d63ae7714f9c8ccf"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"7dcb31403048e3084e903750cb0f843eaf2b24fe","unresolved":false,"context_lines":[{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"        if failure_count \u003e 0:"},{"line_number":1411,"context_line":"            total \u003d len(parsed_args.share)"},{"line_number":1412,"context_line":"            msg \u003d (_(f\"Failed to restore {0}s out of {1}s shares.\","},{"line_number":1413,"context_line":"                     failure_count, total))"},{"line_number":1414,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":22,"id":"63124e40_2c338d44","line":1413,"range":{"start_line":1412,"start_character":18,"end_line":1413,"end_character":43},"in_reply_to":"7d05b9fe_2473a5b8","updated":"2022-08-01 15:30:56.000000000","message":"Done","commit_id":"ee21f2ea65a809e67668aed4d63ae7714f9c8ccf"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a07e1d55fe8416088f897ce154780503d2be133","unresolved":true,"context_lines":[{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"            except Exception as e:"},{"line_number":1405,"context_line":"                failure_count +\u003d 1"},{"line_number":1406,"context_line":"                Log.error(_(\"Failed to restore share with \""},{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"d18cb614_fb056a31","line":1406,"range":{"start_line":1406,"start_character":16,"end_line":1406,"end_character":19},"updated":"2022-07-27 20:57:46.000000000","message":"LOG\nIt is raising this exception:\nname \u0027Log\u0027 is not defined","commit_id":"06018bcb40e7d918b24a830e4bda453884448217"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"7dcb31403048e3084e903750cb0f843eaf2b24fe","unresolved":false,"context_lines":[{"line_number":1403,"context_line":""},{"line_number":1404,"context_line":"            except Exception as e:"},{"line_number":1405,"context_line":"                failure_count +\u003d 1"},{"line_number":1406,"context_line":"                Log.error(_(\"Failed to restore share with \""},{"line_number":1407,"context_line":"                            \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1408,"context_line":"                          {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1409,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"27fa9202_7f60918e","line":1406,"range":{"start_line":1406,"start_character":16,"end_line":1406,"end_character":19},"in_reply_to":"d18cb614_fb056a31","updated":"2022-08-01 15:30:56.000000000","message":"Done","commit_id":"06018bcb40e7d918b24a830e4bda453884448217"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"7a07e1d55fe8416088f897ce154780503d2be133","unresolved":true,"context_lines":[{"line_number":1411,"context_line":"            total \u003d len(parsed_args.share)"},{"line_number":1412,"context_line":"            msg \u003d (f\"Failed to restore {failure_count} out of \""},{"line_number":1413,"context_line":"                   f\"{total} shares.\")"},{"line_number":1414,"context_line":"            msg \u003d _msg"},{"line_number":1415,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":26,"id":"b29d3c78_debb6fe2","line":1414,"range":{"start_line":1414,"start_character":18,"end_line":1414,"end_character":22},"updated":"2022-07-27 20:57:46.000000000","message":"_(msg)\nlike this, it is raising an exception like: name \u0027_msg\u0027 is not defined","commit_id":"06018bcb40e7d918b24a830e4bda453884448217"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"7dcb31403048e3084e903750cb0f843eaf2b24fe","unresolved":false,"context_lines":[{"line_number":1411,"context_line":"            total \u003d len(parsed_args.share)"},{"line_number":1412,"context_line":"            msg \u003d (f\"Failed to restore {failure_count} out of \""},{"line_number":1413,"context_line":"                   f\"{total} shares.\")"},{"line_number":1414,"context_line":"            msg \u003d _msg"},{"line_number":1415,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":26,"id":"74c00ca4_9c8b9f3f","line":1414,"range":{"start_line":1414,"start_character":18,"end_line":1414,"end_character":22},"in_reply_to":"b29d3c78_debb6fe2","updated":"2022-08-01 15:30:56.000000000","message":"Done","commit_id":"06018bcb40e7d918b24a830e4bda453884448217"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"aa4345884ec4446c8db7f45218bb7d2a0f9dbc70","unresolved":true,"context_lines":[{"line_number":1445,"context_line":"        )"},{"line_number":1446,"context_line":"        return parser"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"    def take_action(self, parsed_args):"},{"line_number":1449,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"        failure_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":32,"id":"bb7c0bc9_6dd779a1","line":1448,"updated":"2022-08-17 11:31:28.000000000","message":"Please add microversion check, similarly to: https://github.com/openstack/python-manilaclient/blob/master/manilaclient/osc/v2/share.py#L611","commit_id":"1f168eafe5c2b758b25cd9a3bab67d77ceacb0e0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"be08ed840c1dd0430f23b153739037d9a9f009d8","unresolved":false,"context_lines":[{"line_number":1445,"context_line":"        )"},{"line_number":1446,"context_line":"        return parser"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"    def take_action(self, parsed_args):"},{"line_number":1449,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"        failure_count \u003d 0"}],"source_content_type":"text/x-python","patch_set":32,"id":"976a29b4_e52082b3","line":1448,"in_reply_to":"bb7c0bc9_6dd779a1","updated":"2022-08-17 15:01:58.000000000","message":"Done","commit_id":"1f168eafe5c2b758b25cd9a3bab67d77ceacb0e0"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"be08ed840c1dd0430f23b153739037d9a9f009d8","unresolved":true,"context_lines":[{"line_number":1458,"context_line":"                    LOG.error(_(\"Failed to restore share with \""},{"line_number":1459,"context_line":"                                \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1460,"context_line":"                              {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1461,"context_line":"        elif (getattr(parsed_args, \u0027restore\u0027)):"},{"line_number":1462,"context_line":"            raise exceptions.CommandError("},{"line_number":1463,"context_line":"                \"Restoring a share from the recycle bin is only \""},{"line_number":1464,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"}],"source_content_type":"text/x-python","patch_set":33,"id":"1a9e8d65_d5781a15","line":1461,"range":{"start_line":1461,"start_character":8,"end_line":1461,"end_character":46},"updated":"2022-08-17 15:01:58.000000000","message":"this is unnecessary, this command only does one thing and takes only one argument, so we don\u0027t need an additional argument check. I\u0027d suggest making this an else: block and moving it to the end of file so it wraps the whole logic.","commit_id":"08aa9065942d1dcdd55e5b165789e90de49ae341"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"85df30e609c14eb1012af266331983f54e0f81a6","unresolved":true,"context_lines":[{"line_number":1458,"context_line":"                    LOG.error(_(\"Failed to restore share with \""},{"line_number":1459,"context_line":"                                \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1460,"context_line":"                              {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1461,"context_line":"        elif (getattr(parsed_args, \u0027restore\u0027)):"},{"line_number":1462,"context_line":"            raise exceptions.CommandError("},{"line_number":1463,"context_line":"                \"Restoring a share from the recycle bin is only \""},{"line_number":1464,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"}],"source_content_type":"text/x-python","patch_set":33,"id":"6faffe68_30ee59ed","line":1461,"range":{"start_line":1461,"start_character":8,"end_line":1461,"end_character":46},"in_reply_to":"1a9e8d65_d5781a15","updated":"2022-08-17 16:56:49.000000000","message":"++","commit_id":"08aa9065942d1dcdd55e5b165789e90de49ae341"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"34da99d9d06a19ad2c7d22a56766041cdabd122e","unresolved":false,"context_lines":[{"line_number":1458,"context_line":"                    LOG.error(_(\"Failed to restore share with \""},{"line_number":1459,"context_line":"                                \"name or ID \u0027%(share)s\u0027: %(e)s\"),"},{"line_number":1460,"context_line":"                              {\u0027share\u0027: share, \u0027e\u0027: e})"},{"line_number":1461,"context_line":"        elif (getattr(parsed_args, \u0027restore\u0027)):"},{"line_number":1462,"context_line":"            raise exceptions.CommandError("},{"line_number":1463,"context_line":"                \"Restoring a share from the recycle bin is only \""},{"line_number":1464,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"}],"source_content_type":"text/x-python","patch_set":33,"id":"ba32ccee_b612ad6f","line":1461,"range":{"start_line":1461,"start_character":8,"end_line":1461,"end_character":46},"in_reply_to":"6faffe68_30ee59ed","updated":"2022-08-18 11:17:55.000000000","message":"Done","commit_id":"08aa9065942d1dcdd55e5b165789e90de49ae341"}],"manilaclient/tests/functional/osc/test_shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"72386c998e6588b8c8055cd23159f01bf9fa5cec","unresolved":true,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual(share[\u0027id\u0027], result1[\u0027id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(share[\u0027name\u0027], result1[\u0027name\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        self.openstack(f\u0027share delete {share[\"id\"]} --wait\u0027)"},{"line_number":101,"context_line":"        self.check_object_deleted(\u0027share\u0027, share[\u0027id\u0027])"},{"line_number":102,"context_line":"        shares_list_after_delete \u003d self.listing_result(\u0027share\u0027, \u0027list\u0027)"},{"line_number":103,"context_line":"        self.assertNotIn("}],"source_content_type":"text/x-python","patch_set":11,"id":"b71e5dd6_84edd8b2","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":60},"updated":"2022-06-30 11:51:58.000000000","message":"I think this should not be an actual delete, considering that you will be testing the restore of the share. A share that was completely deleted cannot be restored. So you will need to do soft delete for this share in order of this test to pass :)","commit_id":"0d0e782b9f6620daa1b3c37c195c6d1a353fd657"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"e22df5e41355b3da4a98aa5db4893b666bfb529a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        self.assertEqual(share[\u0027id\u0027], result1[\u0027id\u0027])"},{"line_number":98,"context_line":"        self.assertEqual(share[\u0027name\u0027], result1[\u0027name\u0027])"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        self.openstack(f\u0027share delete {share[\"id\"]} --wait\u0027)"},{"line_number":101,"context_line":"        self.check_object_deleted(\u0027share\u0027, share[\u0027id\u0027])"},{"line_number":102,"context_line":"        shares_list_after_delete \u003d self.listing_result(\u0027share\u0027, \u0027list\u0027)"},{"line_number":103,"context_line":"        self.assertNotIn("}],"source_content_type":"text/x-python","patch_set":11,"id":"5f38f9d1_15290551","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":60},"in_reply_to":"b71e5dd6_84edd8b2","updated":"2022-07-04 08:13:49.000000000","message":"Done","commit_id":"0d0e782b9f6620daa1b3c37c195c6d1a353fd657"}]}