)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e8774c4699e00bd65e987c11aa92a2067708fbc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f3ed9ced_536ae442","updated":"2022-07-11 13:10:37.000000000","message":"Thanks Franca! Change looks good, I\u0027ll test it in my env shortly but let\u0027s add at least one unit test for soft-delete as well, thanks!","commit_id":"28c57d08d4b7277a66201d5dc7c4893a488ede54"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cef76e3fc677300954c1a2f3593cad5e5eb1a83f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3ba549cd_2ded8516","updated":"2022-07-20 19:41:45.000000000","message":"Thank you for the work on this change\nI also noticed that there isn\u0027t a negative unit test scenario for the soft delete command, and it raises an exception in case soft_deleted was defined but the version does not match. Could you please cover that statement with a unit test?","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22c315ac7b09eadd40584213a40073f98dfba2fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b699a69a_236828cf","updated":"2022-07-27 19:48:03.000000000","message":"LGTM, thank you!","commit_id":"4f7724c649279fd5edb73face466e8df4bc5bd48"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3c5ede60e96ba00ba69ef93bfe211317431d6848","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"b9666e67_9b675356","updated":"2022-07-27 08:59:05.000000000","message":"Thanks Franca! The code looks good, I tested it locally again and it worked as expected, lgtm!","commit_id":"4f7724c649279fd5edb73face466e8df4bc5bd48"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cef76e3fc677300954c1a2f3593cad5e5eb1a83f","unresolved":true,"context_lines":[{"line_number":396,"context_line":"            \u0027--soft-deleted\u0027,"},{"line_number":397,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":398,"context_line":"            help\u003d_(\u0027Get shares in recycle bin. If this parameter is set to \u0027"},{"line_number":399,"context_line":"                   \u0027True(Default\u003dFalse), will only show shares in recycle bin.\u0027"},{"line_number":400,"context_line":"                   \u0027 Available only for microversion \u003e\u003d 2.69.\u0027)"},{"line_number":401,"context_line":"        )"},{"line_number":402,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"629c7f69_117de6e3","line":399,"range":{"start_line":399,"start_character":41,"end_line":399,"end_character":77},"updated":"2022-07-20 19:41:45.000000000","message":"only shares in the recycle bin will be displayed","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cef76e3fc677300954c1a2f3593cad5e5eb1a83f","unresolved":true,"context_lines":[{"line_number":396,"context_line":"            \u0027--soft-deleted\u0027,"},{"line_number":397,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":398,"context_line":"            help\u003d_(\u0027Get shares in recycle bin. If this parameter is set to \u0027"},{"line_number":399,"context_line":"                   \u0027True(Default\u003dFalse), will only show shares in recycle bin.\u0027"},{"line_number":400,"context_line":"                   \u0027 Available only for microversion \u003e\u003d 2.69.\u0027)"},{"line_number":401,"context_line":"        )"},{"line_number":402,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"be0cf394_53723dc3","line":399,"range":{"start_line":399,"start_character":23,"end_line":399,"end_character":26},"updated":"2022-07-20 19:41:45.000000000","message":"please add a blank space between e and (","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3c5ede60e96ba00ba69ef93bfe211317431d6848","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            \u0027--soft-deleted\u0027,"},{"line_number":397,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":398,"context_line":"            help\u003d_(\u0027Get shares in recycle bin. If this parameter is set to \u0027"},{"line_number":399,"context_line":"                   \u0027True(Default\u003dFalse), will only show shares in recycle bin.\u0027"},{"line_number":400,"context_line":"                   \u0027 Available only for microversion \u003e\u003d 2.69.\u0027)"},{"line_number":401,"context_line":"        )"},{"line_number":402,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"b8106a54_895ad046","line":399,"range":{"start_line":399,"start_character":41,"end_line":399,"end_character":77},"in_reply_to":"629c7f69_117de6e3","updated":"2022-07-27 08:59:05.000000000","message":"Done","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3c5ede60e96ba00ba69ef93bfe211317431d6848","unresolved":false,"context_lines":[{"line_number":396,"context_line":"            \u0027--soft-deleted\u0027,"},{"line_number":397,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":398,"context_line":"            help\u003d_(\u0027Get shares in recycle bin. If this parameter is set to \u0027"},{"line_number":399,"context_line":"                   \u0027True(Default\u003dFalse), will only show shares in recycle bin.\u0027"},{"line_number":400,"context_line":"                   \u0027 Available only for microversion \u003e\u003d 2.69.\u0027)"},{"line_number":401,"context_line":"        )"},{"line_number":402,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"2f620bcd_24b8bb80","line":399,"range":{"start_line":399,"start_character":23,"end_line":399,"end_character":26},"in_reply_to":"be0cf394_53723dc3","updated":"2022-07-27 08:59:05.000000000","message":"Done","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"cef76e3fc677300954c1a2f3593cad5e5eb1a83f","unresolved":true,"context_lines":[{"line_number":605,"context_line":"            search_opts[\u0027is_soft_deleted\u0027] \u003d parsed_args.soft_deleted"},{"line_number":606,"context_line":"        elif (getattr(parsed_args, \u0027soft_deleted\u0027)):"},{"line_number":607,"context_line":"            raise exceptions.CommandError("},{"line_number":608,"context_line":"                \"Filtering by is_soft_deleted is only \""},{"line_number":609,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"}],"source_content_type":"text/x-python","patch_set":14,"id":"c1035c02_c4ce4437","line":608,"range":{"start_line":608,"start_character":27,"end_line":608,"end_character":45},"updated":"2022-07-20 19:41:45.000000000","message":"soft deleted shares\nis_soft_deleted is a flag we use for programming... This message will be displayed to users/administrators, so using the field name may cause confusion and give implementation details on the user message.","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3c5ede60e96ba00ba69ef93bfe211317431d6848","unresolved":false,"context_lines":[{"line_number":605,"context_line":"            search_opts[\u0027is_soft_deleted\u0027] \u003d parsed_args.soft_deleted"},{"line_number":606,"context_line":"        elif (getattr(parsed_args, \u0027soft_deleted\u0027)):"},{"line_number":607,"context_line":"            raise exceptions.CommandError("},{"line_number":608,"context_line":"                \"Filtering by is_soft_deleted is only \""},{"line_number":609,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"}],"source_content_type":"text/x-python","patch_set":14,"id":"c171e404_00d39b0b","line":608,"range":{"start_line":608,"start_character":27,"end_line":608,"end_character":45},"in_reply_to":"c1035c02_c4ce4437","updated":"2022-07-27 08:59:05.000000000","message":"Done","commit_id":"9bbb4a57e749762a2aaad35ffc7e972395cb7a8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"600e97d0d24cda18e56951be0ed2057bc9afea4d","unresolved":true,"context_lines":[{"line_number":606,"context_line":"            search_opts[\u0027is_soft_deleted\u0027] \u003d parsed_args.soft_deleted"},{"line_number":607,"context_line":"        elif (getattr(parsed_args, \u0027soft_deleted\u0027)):"},{"line_number":608,"context_line":"            raise exceptions.CommandError("},{"line_number":609,"context_line":"                \"Filtering soft deleted shares is only\""},{"line_number":610,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"}],"source_content_type":"text/x-python","patch_set":18,"id":"a77ecc36_7e17ee07","line":609,"range":{"start_line":609,"start_character":54,"end_line":609,"end_character":55},"updated":"2022-07-25 16:00:10.000000000","message":"missing trailing space before the quotes","commit_id":"a257e09b9fded8adfb1f0f9a7c517551b3e2a97b"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"3c5ede60e96ba00ba69ef93bfe211317431d6848","unresolved":false,"context_lines":[{"line_number":606,"context_line":"            search_opts[\u0027is_soft_deleted\u0027] \u003d parsed_args.soft_deleted"},{"line_number":607,"context_line":"        elif (getattr(parsed_args, \u0027soft_deleted\u0027)):"},{"line_number":608,"context_line":"            raise exceptions.CommandError("},{"line_number":609,"context_line":"                \"Filtering soft deleted shares is only\""},{"line_number":610,"context_line":"                \"available with manila API version \u003e\u003d 2.69\")"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        if share_client.api_version \u003e\u003d api_versions.APIVersion(\"2.35\"):"}],"source_content_type":"text/x-python","patch_set":18,"id":"25b11ccc_e7f446a2","line":609,"range":{"start_line":609,"start_character":54,"end_line":609,"end_character":55},"in_reply_to":"a77ecc36_7e17ee07","updated":"2022-07-27 08:59:05.000000000","message":"Done","commit_id":"a257e09b9fded8adfb1f0f9a7c517551b3e2a97b"}]}