)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd658f5d6393fdf83207f6e484680a421cfd2894","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"dfd68bfc_c0da6eed","updated":"2022-06-21 16:43:10.000000000","message":"Hi Namrata, thank you for working on this; the build\u0027s failing because the test is destructive... please see the comment inline to rectify","commit_id":"a7cb064e3426b418a9383d82a18ec985a9ee2fb6"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"e470487e49013d5ba05b2f18948282c394d80517","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"846704b4_971a27bd","updated":"2022-06-21 15:51:07.000000000","message":"I am not able to understand why my build is failing, as it runs succesfully in my local environment. Kindly help me in resolving the same. Thanks!","commit_id":"a7cb064e3426b418a9383d82a18ec985a9ee2fb6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"76cb919d829d10fbea59f9d39c9f476cd89edcb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cba07738_2ec785fb","updated":"2022-06-27 13:10:03.000000000","message":"LGTM. Thank you, Namrata","commit_id":"b41e401cc011df5a803f334299084eb433cc48cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2d386fdb9c2ce8818611ac5b76a413c77e5f28d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"75d881b4_a3bbe1f2","updated":"2022-06-27 14:28:59.000000000","message":"Thanks a lot Namrata! LGTM","commit_id":"b41e401cc011df5a803f334299084eb433cc48cb"}],"manilaclient/tests/functional/osc/test_share_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd658f5d6393fdf83207f6e484680a421cfd2894","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                         services[0][\u0027Updated At\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_services_set(self):"},{"line_number":44,"context_line":"        services \u003d self.list_services()"},{"line_number":45,"context_line":"        first_service \u003d services[0]"},{"line_number":46,"context_line":"        self.openstack(f\u0027share service set {first_service[\"Host\"]} \u0027"},{"line_number":47,"context_line":"                       f\u0027{first_service[\"Binary\"]} \u0027"},{"line_number":48,"context_line":"                       \u0027--disable\u0027)"},{"line_number":49,"context_line":"        result \u003d self.listing_result(\u0027share service\u0027,"},{"line_number":50,"context_line":"                                     \u0027list --status disabled\u0027)"},{"line_number":51,"context_line":"        self.assertEqual(first_service[\u0027ID\u0027], result[0][\u0027ID\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(\u0027disabled\u0027, result[0][\u0027Status\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # enable the share service again"},{"line_number":55,"context_line":"        self.openstack(f\u0027share service set {first_service[\"Host\"]} \u0027"},{"line_number":56,"context_line":"                       f\u0027{first_service[\"Binary\"]} \u0027"},{"line_number":57,"context_line":"                       \u0027--enable\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d348d5dc_b52b3ab3","line":57,"range":{"start_line":44,"start_character":0,"end_line":57,"end_character":34},"updated":"2022-06-21 16:43:10.000000000","message":"This test as it is written is destructive. Tests run via multiple threads in parallel; so provisioning, share management requests could be happening on the service you\u0027re temporarily disabling. Granted that the test wraps up really fast and re-enables the service, however, we could potentially see spurious test failures because some other operation was attempted within the brief window that the service was disabled. \n\n\nOne option is to target the \"manila-data\" service - we\u0027re not exercising it in any of the functional tests (we can\u0027t really). So instead of using the first service with lines 44-45, look for the service with binary \"manila-data\"","commit_id":"a7cb064e3426b418a9383d82a18ec985a9ee2fb6"},{"author":{"_account_id":21785,"name":"Namrata","email":"namrata.sitlani@citynetwork.eu","username":"namrata"},"change_message_id":"dc33c3c37013a70435057d2edf6c386f41732937","unresolved":true,"context_lines":[{"line_number":41,"context_line":"                         services[0][\u0027Updated At\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_services_set(self):"},{"line_number":44,"context_line":"        services \u003d self.list_services()"},{"line_number":45,"context_line":"        first_service \u003d services[0]"},{"line_number":46,"context_line":"        self.openstack(f\u0027share service set {first_service[\"Host\"]} \u0027"},{"line_number":47,"context_line":"                       f\u0027{first_service[\"Binary\"]} \u0027"},{"line_number":48,"context_line":"                       \u0027--disable\u0027)"},{"line_number":49,"context_line":"        result \u003d self.listing_result(\u0027share service\u0027,"},{"line_number":50,"context_line":"                                     \u0027list --status disabled\u0027)"},{"line_number":51,"context_line":"        self.assertEqual(first_service[\u0027ID\u0027], result[0][\u0027ID\u0027])"},{"line_number":52,"context_line":"        self.assertEqual(\u0027disabled\u0027, result[0][\u0027Status\u0027])"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # enable the share service again"},{"line_number":55,"context_line":"        self.openstack(f\u0027share service set {first_service[\"Host\"]} \u0027"},{"line_number":56,"context_line":"                       f\u0027{first_service[\"Binary\"]} \u0027"},{"line_number":57,"context_line":"                       \u0027--enable\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ffd1e58_d66e9778","line":57,"range":{"start_line":44,"start_character":0,"end_line":57,"end_character":34},"in_reply_to":"d348d5dc_b52b3ab3","updated":"2022-06-25 08:46:22.000000000","message":"Thanks for the review. I have applied the changes. Kindly review.","commit_id":"a7cb064e3426b418a9383d82a18ec985a9ee2fb6"}]}