)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"f0f288330c32f00b28f670502d0ee2897e5f04cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8080bce3_6cf76c26","updated":"2022-06-26 15:52:26.000000000","message":"recheck","commit_id":"ffa4c2747dfdb329270b5db93ffe9cfa2939f895"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"772c1e1a34e960f8a7cf74dfc0b799b453c56ce0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"419e7490_824fa373","updated":"2022-06-30 11:54:00.000000000","message":"Thank you for working on this... A few comments inline, please take a look at it","commit_id":"7d58cc76fcf83eaa2223acc13b51a50f60fda3a6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"72fcc0b27ca23bcfde5d4afee655e5d9055acd2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"04fa4ca1_16797102","updated":"2022-07-15 18:57:05.000000000","message":"Thank you for working on this change, please check the comment inline.\nI believe it is a rebasing issue...","commit_id":"e01e2f23d7714a989e56cf82edb0d42061ad2c6a"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"af3ad501e86c51f41266f9c71455b327dfdc2d2e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5dd287a2_1a0f0309","updated":"2022-07-25 19:26:35.000000000","message":"looks good, please take alook at my comment in line.","commit_id":"9099226dfdc87560bca30b88261494a3054561e8"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"1dc2697cf902d7f7838feb299fe557f1520d84d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"481c0d50_8d28d4f3","updated":"2022-07-26 17:40:13.000000000","message":"Looks good, tests passed in local env.","commit_id":"e42729e84475d9dec1cd76cc386c93ab5921f4f1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22d5257173bc66ac3521725d1beb5edcb806231c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"07b5768e_1eb36a63","updated":"2022-07-26 19:12:25.000000000","message":"Thank you for the updates, Franca! Found a few more things related to the tests and added a few comments inline","commit_id":"e42729e84475d9dec1cd76cc386c93ab5921f4f1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8afd177e004e4f626e509a014588d07510c24f82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7a3217ab_c77e53a2","updated":"2022-07-29 18:19:41.000000000","message":"Looking good. Thank you, Franca","commit_id":"df9af53b58b758b102766b6017aab81d8e02a977"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a46a50a755f5e38714a5ceaff34027d57a3c3983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"750a6b29_4ddead7c","updated":"2022-08-01 12:58:21.000000000","message":"Thanks Franca!","commit_id":"df9af53b58b758b102766b6017aab81d8e02a977"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"72fcc0b27ca23bcfde5d4afee655e5d9055acd2b","unresolved":true,"context_lines":[{"line_number":300,"context_line":"                self.openstack,"},{"line_number":301,"context_line":"                f\u0027share snapshot delete {snapshot_object[\"id\"]} --wait\u0027)"},{"line_number":302,"context_line":"        return snapshot_object"},{"line_number":303,"context_line":"        export_locations \u003d self.openstack(f\u0027share {cmd} -f json\u0027)"},{"line_number":304,"context_line":"        export_locations \u003d json.loads(export_locations)"},{"line_number":305,"context_line":"        return export_locations"}],"source_content_type":"text/x-python","patch_set":8,"id":"f8888834_b49a4306","line":305,"range":{"start_line":303,"start_character":0,"end_line":305,"end_character":31},"updated":"2022-07-15 18:57:05.000000000","message":"rebase issue, this code will not be reached. Must be removed from this part.","commit_id":"e01e2f23d7714a989e56cf82edb0d42061ad2c6a"}],"manilaclient/tests/functional/osc/test_shares.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"772c1e1a34e960f8a7cf74dfc0b799b453c56ce0","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_openstack_share_export_location_show(self):"},{"line_number":95,"context_line":"        share \u003d self.create_share()"},{"line_number":96,"context_line":"        share_export_locations \u003d self.get_share_export_locations(share)"},{"line_number":97,"context_line":"        export_location \u003d self.listing_result("},{"line_number":98,"context_line":"            \u0027share\u0027, f\u0027export location show{share[\"id\"]} \u0027"},{"line_number":99,"context_line":"            f\u0027share_export_locations[0]\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f01eb61e_24d80794","line":96,"range":{"start_line":96,"start_character":65,"end_line":96,"end_character":70},"updated":"2022-06-30 11:54:00.000000000","message":"share[\"id\"]","commit_id":"7d58cc76fcf83eaa2223acc13b51a50f60fda3a6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22d5257173bc66ac3521725d1beb5edcb806231c","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def test_openstack_share_export_location_show(self):"},{"line_number":95,"context_line":"        share \u003d self.create_share()"},{"line_number":96,"context_line":"        share_export_locations \u003d self.get_share_export_locations(share)"},{"line_number":97,"context_line":"        export_location \u003d self.listing_result("},{"line_number":98,"context_line":"            \u0027share\u0027, f\u0027export location show{share[\"id\"]} \u0027"},{"line_number":99,"context_line":"            f\u0027share_export_locations[0]\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"23495840_9d4fcf0f","line":96,"range":{"start_line":96,"start_character":65,"end_line":96,"end_character":70},"in_reply_to":"f01eb61e_24d80794","updated":"2022-07-26 19:12:25.000000000","message":"Done","commit_id":"7d58cc76fcf83eaa2223acc13b51a50f60fda3a6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"772c1e1a34e960f8a7cf74dfc0b799b453c56ce0","unresolved":true,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_openstack_share_export_location_list(self):"},{"line_number":103,"context_line":"        share \u003d self.create_share()"},{"line_number":104,"context_line":"        share_export_locations \u003d self.get_share_export_locations(share)"},{"line_number":105,"context_line":"        result_export_locations \u003d self.listing_result("},{"line_number":106,"context_line":"            \u0027share\u0027, f\u0027export location list {share[\"id\"]}\u0027)"},{"line_number":107,"context_line":"        share_export_locations.sort()"}],"source_content_type":"text/x-python","patch_set":5,"id":"5851573d_a3ccf9e2","line":104,"range":{"start_line":104,"start_character":65,"end_line":104,"end_character":70},"updated":"2022-06-30 11:54:00.000000000","message":"share[\"id\"]","commit_id":"7d58cc76fcf83eaa2223acc13b51a50f60fda3a6"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22d5257173bc66ac3521725d1beb5edcb806231c","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    def test_openstack_share_export_location_list(self):"},{"line_number":103,"context_line":"        share \u003d self.create_share()"},{"line_number":104,"context_line":"        share_export_locations \u003d self.get_share_export_locations(share)"},{"line_number":105,"context_line":"        result_export_locations \u003d self.listing_result("},{"line_number":106,"context_line":"            \u0027share\u0027, f\u0027export location list {share[\"id\"]}\u0027)"},{"line_number":107,"context_line":"        share_export_locations.sort()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dd05dd28_88459e92","line":104,"range":{"start_line":104,"start_character":65,"end_line":104,"end_character":70},"in_reply_to":"5851573d_a3ccf9e2","updated":"2022-07-26 19:12:25.000000000","message":"Done","commit_id":"7d58cc76fcf83eaa2223acc13b51a50f60fda3a6"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"af3ad501e86c51f41266f9c71455b327dfdc2d2e","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        result_export_locations \u003d self.listing_result("},{"line_number":151,"context_line":"            \u0027share\u0027, f\u0027export location list {share[\"id\"]}\u0027)"},{"line_number":152,"context_line":"        for share_export in share_export_locations:"},{"line_number":153,"context_line":"            export_location \u003d self.dict_result(\u0027share\u0027, f\u0027export location show\u0027"},{"line_number":154,"context_line":"                                               f\u0027 {share[\"id\"]} \u0027"},{"line_number":155,"context_line":"                                               f\u0027{share_export[\"ID\"]}\u0027)"},{"line_number":156,"context_line":"            self.assertIn(export_location[\"id\"], [item[\"ID\"] for item in"}],"source_content_type":"text/x-python","patch_set":9,"id":"057c3af6_1180fb69","line":153,"range":{"start_line":153,"start_character":56,"end_line":153,"end_character":57},"updated":"2022-07-25 19:26:35.000000000","message":"don\u0027t need the f here if theres no value within {} on the same line. it also looks a little choppy and hard to read, maybe consider a new line at the open parenthesis and a single formatted string. like this:\n\nexport_location \u003d self.dict_result(\n    \u0027share\u0027, f\u0027export location show {share[\"id\"]} {share_export[\"ID\"]}\u0027)","commit_id":"9099226dfdc87560bca30b88261494a3054561e8"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"10055a6fdee97931472db0e4c94ea2290f7f2adb","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        result_export_locations \u003d self.listing_result("},{"line_number":151,"context_line":"            \u0027share\u0027, f\u0027export location list {share[\"id\"]}\u0027)"},{"line_number":152,"context_line":"        for share_export in share_export_locations:"},{"line_number":153,"context_line":"            export_location \u003d self.dict_result(\u0027share\u0027, f\u0027export location show\u0027"},{"line_number":154,"context_line":"                                               f\u0027 {share[\"id\"]} \u0027"},{"line_number":155,"context_line":"                                               f\u0027{share_export[\"ID\"]}\u0027)"},{"line_number":156,"context_line":"            self.assertIn(export_location[\"id\"], [item[\"ID\"] for item in"}],"source_content_type":"text/x-python","patch_set":9,"id":"07452227_efbc7b2c","line":153,"range":{"start_line":153,"start_character":56,"end_line":153,"end_character":57},"in_reply_to":"057c3af6_1180fb69","updated":"2022-07-26 08:11:24.000000000","message":"Ack","commit_id":"9099226dfdc87560bca30b88261494a3054561e8"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22d5257173bc66ac3521725d1beb5edcb806231c","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        share_export_locations \u003d self.get_share_export_locations(share[\"id\"])"},{"line_number":162,"context_line":"        result_export_locations \u003d self.listing_result("},{"line_number":163,"context_line":"            \u0027share\u0027, f\u0027export location list {share[\"id\"]}\u0027)"},{"line_number":164,"context_line":"        self.assertTableStruct(share_export_locations, ["},{"line_number":165,"context_line":"            \u0027ID\u0027,"},{"line_number":166,"context_line":"            \u0027Path\u0027"},{"line_number":167,"context_line":"        ])"},{"line_number":168,"context_line":"        self.assertTableStruct(result_export_locations, ["},{"line_number":169,"context_line":"            \u0027ID\u0027,"},{"line_number":170,"context_line":"            \u0027Path\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"e7a22d7d_f0bf5ccd","line":167,"range":{"start_line":164,"start_character":8,"end_line":167,"end_character":10},"updated":"2022-07-26 19:12:25.000000000","message":"I think this may be testing more the get_share_export_locations method than the listing itself. I believe this assert could be dropped and we could keep only the assert below, that checks the result for the export location list command using the listing_result function.","commit_id":"e42729e84475d9dec1cd76cc386c93ab5921f4f1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8afd177e004e4f626e509a014588d07510c24f82","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        share_export_locations \u003d self.get_share_export_locations(share[\"id\"])"},{"line_number":162,"context_line":"        result_export_locations \u003d self.listing_result("},{"line_number":163,"context_line":"            \u0027share\u0027, f\u0027export location list {share[\"id\"]}\u0027)"},{"line_number":164,"context_line":"        self.assertTableStruct(share_export_locations, ["},{"line_number":165,"context_line":"            \u0027ID\u0027,"},{"line_number":166,"context_line":"            \u0027Path\u0027"},{"line_number":167,"context_line":"        ])"},{"line_number":168,"context_line":"        self.assertTableStruct(result_export_locations, ["},{"line_number":169,"context_line":"            \u0027ID\u0027,"},{"line_number":170,"context_line":"            \u0027Path\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"77934c79_3096e06f","line":167,"range":{"start_line":164,"start_character":8,"end_line":167,"end_character":10},"in_reply_to":"e7a22d7d_f0bf5ccd","updated":"2022-07-29 18:19:41.000000000","message":"Done","commit_id":"e42729e84475d9dec1cd76cc386c93ab5921f4f1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"22d5257173bc66ac3521725d1beb5edcb806231c","unresolved":true,"context_lines":[{"line_number":169,"context_line":"            \u0027ID\u0027,"},{"line_number":170,"context_line":"            \u0027Path\u0027"},{"line_number":171,"context_line":"        ])"},{"line_number":172,"context_line":"        for share_export in share_export_locations:"},{"line_number":173,"context_line":"            self.assertIn(share_export[\"ID\"], [item[\u0027ID\u0027] for item in"},{"line_number":174,"context_line":"                          result_export_locations])"}],"source_content_type":"text/x-python","patch_set":10,"id":"41ddf136_0e808305","line":174,"range":{"start_line":172,"start_character":8,"end_line":174,"end_character":51},"updated":"2022-07-26 19:12:25.000000000","message":"This list is going to be recalculated for every item in the share_export_locations list. I think we can optimize this and declare this list outside, making it to be declared only once. The code starting from line 172 would look like:\n\n    export_location_ids \u003d [el[\u0027ID\u0027] for el in share_export_locations]\n        for share_export in result_export_locations:\n            self.assertIn(share_export[\"ID\"], export_location_ids)","commit_id":"e42729e84475d9dec1cd76cc386c93ab5921f4f1"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"8afd177e004e4f626e509a014588d07510c24f82","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            \u0027ID\u0027,"},{"line_number":170,"context_line":"            \u0027Path\u0027"},{"line_number":171,"context_line":"        ])"},{"line_number":172,"context_line":"        for share_export in share_export_locations:"},{"line_number":173,"context_line":"            self.assertIn(share_export[\"ID\"], [item[\u0027ID\u0027] for item in"},{"line_number":174,"context_line":"                          result_export_locations])"}],"source_content_type":"text/x-python","patch_set":10,"id":"aac4d7f0_22d4c9f6","line":174,"range":{"start_line":172,"start_character":8,"end_line":174,"end_character":51},"in_reply_to":"41ddf136_0e808305","updated":"2022-07-29 18:19:41.000000000","message":"Done","commit_id":"e42729e84475d9dec1cd76cc386c93ab5921f4f1"}]}