)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76d26d6faef5c6e105ee749619c648788d6831c5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Liron Kuchlani \u003clkuchlan@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-07-18 11:49:28 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid any capitalization of the name \"None\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Forbid users to create shares with all case variations"},{"line_number":10,"context_line":"of the name \"None\"."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"afe3613c_644f9298","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":43},"updated":"2022-07-20 21:57:47.000000000","message":"Prevent naming shares with \"None\" or \"none\"","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76d26d6faef5c6e105ee749619c648788d6831c5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid any capitalization of the name \"None\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Forbid users to create shares with all case variations"},{"line_number":10,"context_line":"of the name \"None\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1909477"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"a2c4c6bf_ed9edb59","line":10,"range":{"start_line":9,"start_character":30,"end_line":10,"end_character":19},"updated":"2022-07-20 21:57:47.000000000","message":"not really all case variations - just \"None\" and \"none\"; all case variations would include \"NONE\", \"NoNe\", ..","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d96fd9bd2b86507ed14d95e82e10eaaec944f4e5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Avoid any capitalization of the name \"None\""},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Forbid users to create shares with all case variations"},{"line_number":10,"context_line":"of the name \"None\"."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1909477"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5914d11b_8788a54a","line":10,"range":{"start_line":9,"start_character":30,"end_line":10,"end_character":19},"in_reply_to":"a2c4c6bf_ed9edb59","updated":"2022-07-21 11:42:08.000000000","message":"It also covers these case variations.\nhttps://www.programiz.com/python-programming/methods/string/capitalize","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"253c54e451775ec6a5b59aa19e7ce041d492e573","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d3d2e214_8ddbeeaf","updated":"2022-07-19 12:55:31.000000000","message":"Thank you for the fix, it is looking good.\nI am just a bit confused because the other change that claimed to address. It added a release note claiming the fix but we didn\u0027t actually fix in that version. I\u0027m okay not having a release note again but we definitely need to backport this at least for Xena\n\n[1] https://bugs.launchpad.net/python-manilaclient/+bug/1909477","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"296d23215cb6baf6570697987440ed6d2f8b22e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cc984194_ebe97bc3","in_reply_to":"373d933b_c7dc0421","updated":"2022-07-20 16:43:39.000000000","message":"I would not say so, Liron... Let\u0027s see if other reviewers will agree.","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"d96fd9bd2b86507ed14d95e82e10eaaec944f4e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e80366e0_3a55fdaf","in_reply_to":"a4db7f4f_7c46c745","updated":"2022-07-21 11:42:08.000000000","message":"Thanks!\nDone!","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"76d26d6faef5c6e105ee749619c648788d6831c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a4db7f4f_7c46c745","in_reply_to":"cc984194_ebe97bc3","updated":"2022-07-20 21:57:47.000000000","message":"Since there was no release note then, maybe we can add one now. Please be advised that the manilaclient shell is going to be deprecated soon, and this behavior currently only affects that shell - shouldn\u0027t we have parity in the OSC client?","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"c426e92e1d646c9ba9d02b1ef1128b061b3a25eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"373d933b_c7dc0421","in_reply_to":"d3d2e214_8ddbeeaf","updated":"2022-07-20 08:20:49.000000000","message":"Do you prefer me to report a new bug and create a new release note ?","commit_id":"65c93fe0b95527b86a79ea15104dca0d6cee98dc"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7d2a21ac4e3198e3b2fddf923cd5098e1063cee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee62bc84_a31b756a","updated":"2022-07-21 15:13:34.000000000","message":"Looks good, thanks for the change.","commit_id":"7df3375cc22cf01f68c4229ae69f713a6bf45b0a"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f74bf3bf5b0b46ff5b125160ff3fbf4207cc2a5b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"58960882_76d15185","updated":"2022-07-28 19:02:59.000000000","message":"Looking good, thank you Liron!","commit_id":"1597bf6debda7112c09b5cf46f40b73a00d013b5"},{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"64432aea091ad066ae7dc96a108a1b4b57e42625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"194f5501_cfcc8390","updated":"2022-07-26 18:04:39.000000000","message":"Thanks! All 3 tests passed in local env as well.","commit_id":"1597bf6debda7112c09b5cf46f40b73a00d013b5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e9c8d6307453bff70c338266d5ec8d3920ee1c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2edaacbf_8c438abb","updated":"2022-07-28 17:22:09.000000000","message":"Thanks, LGTM","commit_id":"1597bf6debda7112c09b5cf46f40b73a00d013b5"}],"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":30025,"name":"Vida Haririan","display_name":"Vida Haririan","email":"vhariria@redhat.com","username":"vhari"},"change_message_id":"7d2a21ac4e3198e3b2fddf923cd5098e1063cee8","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            parsed_args)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @ddt.data(\u0027None\u0027, \u0027NONE\u0027, \u0027none\u0027)"},{"line_number":366,"context_line":"    def test_create_share_with_the_name_none_osc(self, name):"},{"line_number":367,"context_line":"        arglist \u003d ["},{"line_number":368,"context_line":"            \u0027--name\u0027, name,"},{"line_number":369,"context_line":"            self.new_share.share_proto,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ee8a261_dbc45648","line":366,"updated":"2022-07-21 15:13:34.000000000","message":"Pls consider removing \u0027_osc\u0027 to be consistent with existing OSC tests.","commit_id":"7df3375cc22cf01f68c4229ae69f713a6bf45b0a"},{"author":{"_account_id":19262,"name":"Liron Kuchlani","email":"lkuchlan@redhat.com","username":"lkuchlan"},"change_message_id":"e2795769acd51f4c78fbd19fe69ba2b50481757d","unresolved":true,"context_lines":[{"line_number":363,"context_line":"            parsed_args)"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"    @ddt.data(\u0027None\u0027, \u0027NONE\u0027, \u0027none\u0027)"},{"line_number":366,"context_line":"    def test_create_share_with_the_name_none_osc(self, name):"},{"line_number":367,"context_line":"        arglist \u003d ["},{"line_number":368,"context_line":"            \u0027--name\u0027, name,"},{"line_number":369,"context_line":"            self.new_share.share_proto,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d8685d0_a658e14f","line":366,"in_reply_to":"9ee8a261_dbc45648","updated":"2022-07-21 19:43:16.000000000","message":"Thanks Vida!\nDone!","commit_id":"7df3375cc22cf01f68c4229ae69f713a6bf45b0a"}]}