)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a98def3e902256fb941a9398947f0141389d9500","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0267024c_97694df4","updated":"2022-08-17 11:46:53.000000000","message":"Thanks Franca, code looks good!I Added some notes inline, please add a microversion check here as well :) ","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"46ef398234351eb426a438b352540594e249046c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c0667b49_3d7ee139","updated":"2022-08-11 09:14:32.000000000","message":"recheck","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ce3830e1bf0d5d79e08f10e39cdd7b6319043765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a30ee5b1_61cfa967","updated":"2022-08-18 07:14:40.000000000","message":"Thanks Franca! The code looks good now! I tested in my env and noticed that the command is returning \"1\" instead of the actual result, please have a look :) ","commit_id":"d7d843ca49cece131a3c6778b83f068a677e7e26"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e4471ad7cc671162fc849cd31921a8383f714e97","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"df656cdf_e5710221","updated":"2022-08-18 10:16:43.000000000","message":"Thanks Franca, left a note inline with some options how to fix the test :) ","commit_id":"d857129e64c90bad7e4bef4909b106a6f14c8385"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"be16649ae6e0efcb1b3109cfd7c306eed2d988c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a4f0e5c2_3752542c","updated":"2022-08-18 22:14:38.000000000","message":"Looking good - tests ran smoothly on my env but we\u0027ll need to rebase this - Could you please do that when the other two merge? :)","commit_id":"b0f66cd04cb79705d165c31fffe8071d64a50ed4"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"96f43568244c17bbd83112ce37a016e53f282e61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1cefa31b_ac3f984f","updated":"2022-08-19 08:33:32.000000000","message":"Sure I would rebase","commit_id":"b0f66cd04cb79705d165c31fffe8071d64a50ed4"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"98fddf66d539bdce295d52b08179c76c10c6288d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a076104f_03ea1b6d","updated":"2022-08-18 14:39:09.000000000","message":"Thank you Franca, I tested it again and everything works as expected now, great job!","commit_id":"b0f66cd04cb79705d165c31fffe8071d64a50ed4"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5d7d9d8e63656e6d5f434df70d500cf3eaae59e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"505af09b_1e3ab11d","updated":"2022-08-19 20:22:11.000000000","message":"Thank you Franca, LGTM","commit_id":"35be44a30c66ccb6b1044100ce6a8877bcac3878"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cef6200724bc2fc7e983b3f88419b3b6b63ebc9a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"482f6b52_fe32a978","updated":"2022-08-19 20:10:37.000000000","message":"Thanks Franca! LGTM!","commit_id":"35be44a30c66ccb6b1044100ce6a8877bcac3878"}],"manilaclient/osc/v2/share_servers.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a98def3e902256fb941a9398947f0141389d9500","unresolved":true,"context_lines":[{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027share_server\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\u0027\u003cshare_server\u003e\u0027,"},{"line_number":430,"context_line":"            help\u003d\u0027ID of share server to complete migration.\u0027"},{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fe65d3a8_0f9100e1","line":430,"range":{"start_line":430,"start_character":40,"end_line":430,"end_character":58},"updated":"2022-08-17 11:46:53.000000000","message":"nit: show migration progress for","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"29a2bc831e57f5bb02e1174bb1af15ed26f91f44","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027share_server\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\u0027\u003cshare_server\u003e\u0027,"},{"line_number":430,"context_line":"            help\u003d\u0027ID of share server to complete migration.\u0027"},{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"4a6bd90d_75163f68","line":430,"range":{"start_line":430,"start_character":40,"end_line":430,"end_character":58},"in_reply_to":"fe65d3a8_0f9100e1","updated":"2022-08-18 08:56:42.000000000","message":"Done","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ce3830e1bf0d5d79e08f10e39cdd7b6319043765","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        parser.add_argument("},{"line_number":428,"context_line":"            \u0027share_server\u0027,"},{"line_number":429,"context_line":"            metavar\u003d\u0027\u003cshare_server\u003e\u0027,"},{"line_number":430,"context_line":"            help\u003d\u0027ID of share server to complete migration.\u0027"},{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a90b4f07_16351f4d","line":430,"range":{"start_line":430,"start_character":40,"end_line":430,"end_character":58},"in_reply_to":"fe65d3a8_0f9100e1","updated":"2022-08-18 07:14:40.000000000","message":"Done","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a98def3e902256fb941a9398947f0141389d9500","unresolved":true,"context_lines":[{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def take_action(self, parsed_args):"},{"line_number":435,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":436,"context_line":"        share_server \u003d osc_utils.find_resource("},{"line_number":437,"context_line":"            share_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":3,"id":"c031c07a_cc8f8bde","line":434,"updated":"2022-08-17 11:46:53.000000000","message":"please add a microversion check, as you did for the migration start command.","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ce3830e1bf0d5d79e08f10e39cdd7b6319043765","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def take_action(self, parsed_args):"},{"line_number":435,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":436,"context_line":"        share_server \u003d osc_utils.find_resource("},{"line_number":437,"context_line":"            share_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":3,"id":"70027c73_876a105b","line":434,"in_reply_to":"c031c07a_cc8f8bde","updated":"2022-08-18 07:14:40.000000000","message":"Done","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"29a2bc831e57f5bb02e1174bb1af15ed26f91f44","unresolved":false,"context_lines":[{"line_number":431,"context_line":"        )"},{"line_number":432,"context_line":"        return parser"},{"line_number":433,"context_line":""},{"line_number":434,"context_line":"    def take_action(self, parsed_args):"},{"line_number":435,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":436,"context_line":"        share_server \u003d osc_utils.find_resource("},{"line_number":437,"context_line":"            share_client.share_servers,"}],"source_content_type":"text/x-python","patch_set":3,"id":"a62d2646_c87de6b3","line":434,"in_reply_to":"c031c07a_cc8f8bde","updated":"2022-08-18 08:56:42.000000000","message":"Done","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ce3830e1bf0d5d79e08f10e39cdd7b6319043765","unresolved":true,"context_lines":[{"line_number":438,"context_line":"                share_client.share_servers,"},{"line_number":439,"context_line":"                parsed_args.share_server)"},{"line_number":440,"context_line":"            result \u003d share_server.migration_get_progress()"},{"line_number":441,"context_line":"            return self.dict2columns(result[1])"},{"line_number":442,"context_line":"        else:"},{"line_number":443,"context_line":"            raise exceptions.CommandError("},{"line_number":444,"context_line":"                \"Share Server Migration show is only available \""}],"source_content_type":"text/x-python","patch_set":4,"id":"2598ce58_de305220","line":441,"range":{"start_line":441,"start_character":37,"end_line":441,"end_character":46},"updated":"2022-08-18 07:14:40.000000000","message":"just result\nI think we already tackled this once, maybe the fix was lost in a rebase. Right now I am getting \"1\" returned.","commit_id":"d7d843ca49cece131a3c6778b83f068a677e7e26"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"29a2bc831e57f5bb02e1174bb1af15ed26f91f44","unresolved":true,"context_lines":[{"line_number":438,"context_line":"                share_client.share_servers,"},{"line_number":439,"context_line":"                parsed_args.share_server)"},{"line_number":440,"context_line":"            result \u003d share_server.migration_get_progress()"},{"line_number":441,"context_line":"            return self.dict2columns(result[1])"},{"line_number":442,"context_line":"        else:"},{"line_number":443,"context_line":"            raise exceptions.CommandError("},{"line_number":444,"context_line":"                \"Share Server Migration show is only available \""}],"source_content_type":"text/x-python","patch_set":4,"id":"8ac78c13_e69cd2e1","line":441,"range":{"start_line":441,"start_character":37,"end_line":441,"end_character":46},"in_reply_to":"2598ce58_de305220","updated":"2022-08-18 08:56:42.000000000","message":"I think i ran the unit test and it fails with just  result, I also tested locally with result[1] and it worked. Let me confirm again maybe the rebase affected the output.","commit_id":"d7d843ca49cece131a3c6778b83f068a677e7e26"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"98fddf66d539bdce295d52b08179c76c10c6288d","unresolved":false,"context_lines":[{"line_number":438,"context_line":"                share_client.share_servers,"},{"line_number":439,"context_line":"                parsed_args.share_server)"},{"line_number":440,"context_line":"            result \u003d share_server.migration_get_progress()"},{"line_number":441,"context_line":"            return self.dict2columns(result[1])"},{"line_number":442,"context_line":"        else:"},{"line_number":443,"context_line":"            raise exceptions.CommandError("},{"line_number":444,"context_line":"                \"Share Server Migration show is only available \""}],"source_content_type":"text/x-python","patch_set":4,"id":"1ee75e1d_23e4a7e0","line":441,"range":{"start_line":441,"start_character":37,"end_line":441,"end_character":46},"in_reply_to":"8ac78c13_e69cd2e1","updated":"2022-08-18 14:39:09.000000000","message":"Done","commit_id":"d7d843ca49cece131a3c6778b83f068a677e7e26"}],"manilaclient/tests/unit/osc/v2/test_share_servers.py":[{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"a98def3e902256fb941a9398947f0141389d9500","unresolved":true,"context_lines":[{"line_number":523,"context_line":"        self.share_server \u003d ("},{"line_number":524,"context_line":"            manila_fakes.FakeShareServer.create_one_server("},{"line_number":525,"context_line":"                attrs\u003d{"},{"line_number":526,"context_line":"                    \u0027status\u0027: \u0027available\u0027,"},{"line_number":527,"context_line":"                    \u0027task_state\u0027: \u0027migration_in_progress\u0027"},{"line_number":528,"context_line":"                },"},{"line_number":529,"context_line":"                methods\u003d{\u0027migration_get_progress\u0027: (\"\u003cResponse [200]\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"9538a339_be910244","line":526,"range":{"start_line":526,"start_character":31,"end_line":526,"end_character":40},"updated":"2022-08-17 11:46:53.000000000","message":"nit: I think this would be then \"migrating\"","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"ce3830e1bf0d5d79e08f10e39cdd7b6319043765","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.share_server \u003d ("},{"line_number":524,"context_line":"            manila_fakes.FakeShareServer.create_one_server("},{"line_number":525,"context_line":"                attrs\u003d{"},{"line_number":526,"context_line":"                    \u0027status\u0027: \u0027available\u0027,"},{"line_number":527,"context_line":"                    \u0027task_state\u0027: \u0027migration_in_progress\u0027"},{"line_number":528,"context_line":"                },"},{"line_number":529,"context_line":"                methods\u003d{\u0027migration_get_progress\u0027: (\"\u003cResponse [200]\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"b00369a5_1777fb3a","line":526,"range":{"start_line":526,"start_character":31,"end_line":526,"end_character":40},"in_reply_to":"9538a339_be910244","updated":"2022-08-18 07:14:40.000000000","message":"Done","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"29a2bc831e57f5bb02e1174bb1af15ed26f91f44","unresolved":false,"context_lines":[{"line_number":523,"context_line":"        self.share_server \u003d ("},{"line_number":524,"context_line":"            manila_fakes.FakeShareServer.create_one_server("},{"line_number":525,"context_line":"                attrs\u003d{"},{"line_number":526,"context_line":"                    \u0027status\u0027: \u0027available\u0027,"},{"line_number":527,"context_line":"                    \u0027task_state\u0027: \u0027migration_in_progress\u0027"},{"line_number":528,"context_line":"                },"},{"line_number":529,"context_line":"                methods\u003d{\u0027migration_get_progress\u0027: (\"\u003cResponse [200]\u003e\","}],"source_content_type":"text/x-python","patch_set":3,"id":"c48d3fa4_7584744f","line":526,"range":{"start_line":526,"start_character":31,"end_line":526,"end_character":40},"in_reply_to":"9538a339_be910244","updated":"2022-08-18 08:56:42.000000000","message":"Done","commit_id":"b949c39e533b303719b0667f40b026891da24285"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"e4471ad7cc671162fc849cd31921a8383f714e97","unresolved":true,"context_lines":[{"line_number":526,"context_line":"                    \u0027status\u0027: \u0027migrating\u0027,"},{"line_number":527,"context_line":"                    \u0027task_state\u0027: \u0027migration_in_progress\u0027"},{"line_number":528,"context_line":"                },"},{"line_number":529,"context_line":"                methods\u003d{\u0027migration_get_progress\u0027: (\"\u003cResponse [200]\u003e\","},{"line_number":530,"context_line":"                         {\u0027total_progress\u0027: 0, \u0027task_state\u0027:"},{"line_number":531,"context_line":"                          \u0027migration_in_progress\u0027,"},{"line_number":532,"context_line":"                          \u0027details\u0027: {}})}"},{"line_number":533,"context_line":"            )"},{"line_number":534,"context_line":"        )"},{"line_number":535,"context_line":"        self.servers_mock.get.return_value \u003d self.share_server"}],"source_content_type":"text/x-python","patch_set":5,"id":"cbfc75f6_667908a7","line":532,"range":{"start_line":529,"start_character":16,"end_line":532,"end_character":42},"updated":"2022-08-18 10:16:43.000000000","message":"this should be:\n    methods\u003d{\u0027migration_get_progress\u0027: {\n                 \u0027total_progress\u0027: 0,\n                 \u0027task_state\u0027:\n                 \u0027migration_in_progress\u0027,\n                 \u0027details\u0027: {}}}\n\nOr, because we only test if it\u0027s called and we don\u0027t compare the result to anything, just:\n    methods\u003d{\u0027migration_get_progress\u0027: None}","commit_id":"d857129e64c90bad7e4bef4909b106a6f14c8385"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"eb892a008fe0b78a55d376aec5c4669344c22189","unresolved":false,"context_lines":[{"line_number":526,"context_line":"                    \u0027status\u0027: \u0027migrating\u0027,"},{"line_number":527,"context_line":"                    \u0027task_state\u0027: \u0027migration_in_progress\u0027"},{"line_number":528,"context_line":"                },"},{"line_number":529,"context_line":"                methods\u003d{\u0027migration_get_progress\u0027: (\"\u003cResponse [200]\u003e\","},{"line_number":530,"context_line":"                         {\u0027total_progress\u0027: 0, \u0027task_state\u0027:"},{"line_number":531,"context_line":"                          \u0027migration_in_progress\u0027,"},{"line_number":532,"context_line":"                          \u0027details\u0027: {}})}"},{"line_number":533,"context_line":"            )"},{"line_number":534,"context_line":"        )"},{"line_number":535,"context_line":"        self.servers_mock.get.return_value \u003d self.share_server"}],"source_content_type":"text/x-python","patch_set":5,"id":"c9a8d645_0be4588f","line":532,"range":{"start_line":529,"start_character":16,"end_line":532,"end_character":42},"in_reply_to":"cbfc75f6_667908a7","updated":"2022-08-18 11:17:27.000000000","message":"Done","commit_id":"d857129e64c90bad7e4bef4909b106a6f14c8385"}]}