)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"cfc65e4232e97fed4f2e02905d8c29e6c27e8454","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OSC] Implement Share Server  Migration check and restart-check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds \u0027openstack share server migration start\u0027"},{"line_number":10,"context_line":"with flags: \u0027--check-only\u0027 and \u0027--restart-check\u0027."},{"line_number":11,"context_line":"command, that implement the same functionality as"},{"line_number":12,"context_line":"\u0027manila share-server-migration-check\u0027 command."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1a8e00e7_ba7c5924","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":47},"updated":"2022-08-31 21:18:05.000000000","message":"where is the code for \u0027--restart-check\u0027 parameter?","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"a626dea9dfb047f1c46f58a0c3b113c6d88ff21b","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[OSC] Implement Share Server  Migration check and restart-check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds \u0027openstack share server migration start\u0027"},{"line_number":10,"context_line":"with flags: \u0027--check-only\u0027 and \u0027--restart-check\u0027."},{"line_number":11,"context_line":"command, that implement the same functionality as"},{"line_number":12,"context_line":"\u0027manila share-server-migration-check\u0027 command."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b9e6466b_938b07db","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":47},"in_reply_to":"1a8e00e7_ba7c5924","updated":"2022-08-31 22:24:07.000000000","message":"Good point - I think I saw this in another review, but I think the --restart-check should be removed from the commit message. I mean, the code was not added for it, and the --check-only option is returning a result every single time the command is invoked, so the operation is not asynchronous, then, users will  not need to restart a check.","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"e5176e3980a45fe51744ac5b285f6f9235b3a5f8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OSC] Implement Share Server  Migration check and restart-check"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds \u0027openstack share server migration start\u0027"},{"line_number":10,"context_line":"with flags: \u0027--check-only\u0027 and \u0027--restart-check\u0027."},{"line_number":11,"context_line":"command, that implement the same functionality as"},{"line_number":12,"context_line":"\u0027manila share-server-migration-check\u0027 command."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"b01f092d_203f6409","line":10,"range":{"start_line":10,"start_character":32,"end_line":10,"end_character":47},"in_reply_to":"b9e6466b_938b07db","updated":"2022-09-01 05:12:01.000000000","message":"Ack","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9f44d50839b4ff74f7ed74346b932cb86ed8358","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"4c4ebdcf_7deb36e1","updated":"2022-08-29 19:14:18.000000000","message":"Thanks Franca, some suggestions inline","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5540fdf3c30006dac1e8a2f6e1745819ae2920b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"23c921e0_19eb219c","updated":"2022-08-31 14:12:39.000000000","message":"Thank you for working on this change - Please check the comments inline :)","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"73ecfc7d_1b35485f","updated":"2022-08-31 16:54:55.000000000","message":"Thank you for working on the fix, please check the suggestions inline","commit_id":"d784e6cde75edcb94381c819028dbca92a8fc3a5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"56c73e5db020af27f6bbb533ebd9c5b141a31cf0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"507f75d3_5d7f7c2f","updated":"2022-08-31 20:20:54.000000000","message":"Circling back here again. I missed something in the tests, sorry about that :/\nIt should be simple to work around though, please take a look in the comment inline","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"45e349b02ae94b224e0e54f16b42fc9e3e51920a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"5defee23_4f418e14","updated":"2022-09-01 19:32:01.000000000","message":"Another one going to the gate queue! 😄\nThank you","commit_id":"bb1a957506ff15dabf9864a2653c3c71ed215a41"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4178fe29c42a6640d33dc46292a287b3f4f3d037","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"afa0ed36_12baa897","updated":"2022-09-01 14:02:53.000000000","message":"LGTM, work as expected. Thank you!","commit_id":"bb1a957506ff15dabf9864a2653c3c71ed215a41"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b1f6e117c2ba2411c5dde7d6993542acfaa96da2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"77da378d_2bfe3da5","updated":"2022-09-01 19:25:09.000000000","message":"Thanks, LGTM. I am ok on merge this one since carlos already tested it.","commit_id":"bb1a957506ff15dabf9864a2653c3c71ed215a41"}],"manilaclient/osc/v2/share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9f44d50839b4ff74f7ed74346b932cb86ed8358","unresolved":true,"context_lines":[{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of a security service replacement. \")"},{"line_number":567,"context_line":"        )"},{"line_number":568,"context_line":"        parser.add_argument("},{"line_number":569,"context_line":"            \u0027--restart-check\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f4124317_e6241cdb","line":566,"range":{"start_line":566,"start_character":37,"end_line":566,"end_character":67},"updated":"2022-08-29 19:14:18.000000000","message":"the share server migration.","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"919f71dadce135e3bf9796aec570003d96b7a3d4","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of a security service replacement. \")"},{"line_number":567,"context_line":"        )"},{"line_number":568,"context_line":"        parser.add_argument("},{"line_number":569,"context_line":"            \u0027--restart-check\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a72e7d4_32cb053d","line":566,"range":{"start_line":566,"start_character":37,"end_line":566,"end_character":67},"in_reply_to":"f4124317_e6241cdb","updated":"2022-08-31 18:38:43.000000000","message":"Done","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of a security service replacement. \")"},{"line_number":567,"context_line":"        )"},{"line_number":568,"context_line":"        parser.add_argument("},{"line_number":569,"context_line":"            \u0027--restart-check\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc5f7b7b_17ea4977","line":566,"range":{"start_line":566,"start_character":37,"end_line":566,"end_character":67},"in_reply_to":"f4124317_e6241cdb","updated":"2022-08-31 16:54:55.000000000","message":"Done","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9f44d50839b4ff74f7ed74346b932cb86ed8358","unresolved":true,"context_lines":[{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of a security service replacement. \")"},{"line_number":567,"context_line":"        )"},{"line_number":568,"context_line":"        parser.add_argument("},{"line_number":569,"context_line":"            \u0027--restart-check\u0027,"},{"line_number":570,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":571,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":572,"context_line":"            required\u003dFalse,"},{"line_number":573,"context_line":"            default\u003dNone,"},{"line_number":574,"context_line":"            help\u003d_(\"Restart a dry-run of a security service \")"},{"line_number":575,"context_line":"        )"},{"line_number":576,"context_line":"        return parser"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"4548e443_5e75afe6","line":575,"range":{"start_line":568,"start_character":8,"end_line":575,"end_character":9},"updated":"2022-08-29 19:14:18.000000000","message":"This parameter isn\u0027t necessary; there\u0027s no dry-run/check restart operation provided by the share server migration API.","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"919f71dadce135e3bf9796aec570003d96b7a3d4","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of a security service replacement. \")"},{"line_number":567,"context_line":"        )"},{"line_number":568,"context_line":"        parser.add_argument("},{"line_number":569,"context_line":"            \u0027--restart-check\u0027,"},{"line_number":570,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":571,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":572,"context_line":"            required\u003dFalse,"},{"line_number":573,"context_line":"            default\u003dNone,"},{"line_number":574,"context_line":"            help\u003d_(\"Restart a dry-run of a security service \")"},{"line_number":575,"context_line":"        )"},{"line_number":576,"context_line":"        return parser"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"68e986ab_7cc5f68f","line":575,"range":{"start_line":568,"start_character":8,"end_line":575,"end_character":9},"in_reply_to":"4548e443_5e75afe6","updated":"2022-08-31 18:38:43.000000000","message":"Done","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of a security service replacement. \")"},{"line_number":567,"context_line":"        )"},{"line_number":568,"context_line":"        parser.add_argument("},{"line_number":569,"context_line":"            \u0027--restart-check\u0027,"},{"line_number":570,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":571,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":572,"context_line":"            required\u003dFalse,"},{"line_number":573,"context_line":"            default\u003dNone,"},{"line_number":574,"context_line":"            help\u003d_(\"Restart a dry-run of a security service \")"},{"line_number":575,"context_line":"        )"},{"line_number":576,"context_line":"        return parser"},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"8f331c2e_2ef5a1ae","line":575,"range":{"start_line":568,"start_character":8,"end_line":575,"end_character":9},"in_reply_to":"4548e443_5e75afe6","updated":"2022-08-31 16:54:55.000000000","message":"Done","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"56c73e5db020af27f6bbb533ebd9c5b141a31cf0","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        parser.add_argument("},{"line_number":561,"context_line":"            \u0027--check-only\u0027,"},{"line_number":562,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of the share server migration. \")"}],"source_content_type":"text/x-python","patch_set":8,"id":"b038848a_db5399e5","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":38},"updated":"2022-08-31 20:20:54.000000000","message":"I think we should use:\naction\u003d\u0027store_true\u0027\nand use default\u003dFalse below\nI gave it a try as is, and when I ran --check-only False it still ran in the check-only mode, please see:\nhttps://paste.opendev.org/show/bqZ0ur6ioMw1Q8OFfuwo/\nIf we take this approach, then metavar could also be deleted. Sorry if I have not noticed this before - I noticed now after some tests. Other than that, it looks good to go!","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"},{"author":{"_account_id":31213,"name":"Maari Tamm","email":"maari.tamm@citynetwork.eu","username":"maaritamm"},"change_message_id":"cecbb9edbc362fa5e84c0825017036b50174f3f7","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        parser.add_argument("},{"line_number":561,"context_line":"            \u0027--check-only\u0027,"},{"line_number":562,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of the share server migration. \")"}],"source_content_type":"text/x-python","patch_set":8,"id":"fae39286_81e183e7","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":38},"in_reply_to":"aeeb4c20_46101186","updated":"2022-09-01 07:03:54.000000000","message":"the unrecognised arguments are the following \"False\" or \"True\", not \"check-only\", because when we use the \u0027store_true\u0027 option, it means that the user will not have to define these anymore. If the user wants to use the option, they will use it as:\n    openstack share server migration start --check-only\n    \nAnd, if the don\u0027t want to use it, they\u0027ll just drop it.\nSimilarly to how we have implemented any --force or --wait options.\n\nSo, in this case you only need to update your tests to that effect :)","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"3e5fe15acfcb0244e5dd8944b2170dbd8f6df919","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        parser.add_argument("},{"line_number":561,"context_line":"            \u0027--check-only\u0027,"},{"line_number":562,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of the share server migration. \")"}],"source_content_type":"text/x-python","patch_set":8,"id":"aeeb4c20_46101186","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":38},"in_reply_to":"b038848a_db5399e5","updated":"2022-09-01 06:03:15.000000000","message":"\u003e I think we should use:\n\u003e action\u003d\u0027store_true\u0027\n\u003e and use default\u003dFalse below\n\u003e I gave it a try as is, and when I ran --check-only False it still ran in the check-only mode, please see:\n\u003e https://paste.opendev.org/show/bqZ0ur6ioMw1Q8OFfuwo/\n\u003e If we take this approach, then metavar could also be deleted. Sorry if I have not noticed this before - I noticed now after some tests. Other than that, it looks good to go!\n\n\nI noticed, if I maintain the parser argument like thus returns unrecognized argument error. https://paste.opendev.org/show/bOFusa1IpLyiYo4kYh4H/","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"e429d45468476b94c1e83b2c9a9222c30a27e388","unresolved":true,"context_lines":[{"line_number":560,"context_line":"        parser.add_argument("},{"line_number":561,"context_line":"            \u0027--check-only\u0027,"},{"line_number":562,"context_line":"            metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":563,"context_line":"            choices\u003d[\u0027True\u0027, \u0027False\u0027],"},{"line_number":564,"context_line":"            required\u003dFalse,"},{"line_number":565,"context_line":"            default\u003dNone,"},{"line_number":566,"context_line":"            help\u003d_(\"Run a dry-run of the share server migration. \")"}],"source_content_type":"text/x-python","patch_set":8,"id":"e5506ffb_cec7e545","line":563,"range":{"start_line":563,"start_character":12,"end_line":563,"end_character":38},"in_reply_to":"fae39286_81e183e7","updated":"2022-09-01 10:58:47.000000000","message":"\u003e the unrecognised arguments are the following \"False\" or \"True\", not \"check-only\", because when we use the \u0027store_true\u0027 option, it means that the user will not have to define these anymore. If the user wants to use the option, they will use it as:\n\u003e     openstack share server migration start --check-only\n\u003e     \n\u003e And, if the don\u0027t want to use it, they\u0027ll just drop it.\n\u003e Similarly to how we have implemented any --force or --wait options.\n\u003e \n\u003e So, in this case you only need to update your tests to that effect :)\n\nThanks, this is fixed now.","commit_id":"ff933f6ed0f212824e8a0c6aafb5a90dac790d45"}],"manilaclient/tests/unit/osc/v2/test_share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f9f44d50839b4ff74f7ed74346b932cb86ed8358","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89eb7390_6dffbbfe","updated":"2022-08-29 19:14:18.000000000","message":"Could you please add a test when --check-only is provided?","commit_id":"f589fdb0294201cdf24392290f4a41f924cd0445"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5540fdf3c30006dac1e8a2f6e1745819ae2920b3","unresolved":true,"context_lines":[{"line_number":687,"context_line":"            (\u0027check_only\u0027, \u0027True\u0027)"},{"line_number":688,"context_line":"        ]"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        returned_result \u003d {"},{"line_number":691,"context_line":"            \u0027compatible\u0027: True,"},{"line_number":692,"context_line":"            \u0027requested_capabilities\u0027: {"},{"line_number":693,"context_line":"                \u0027writable\u0027: \u0027True\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2861c08b_269a0425","line":690,"range":{"start_line":690,"start_character":8,"end_line":690,"end_character":23},"updated":"2022-08-31 14:12:39.000000000","message":"expected_result","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            (\u0027check_only\u0027, \u0027True\u0027)"},{"line_number":688,"context_line":"        ]"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        returned_result \u003d {"},{"line_number":691,"context_line":"            \u0027compatible\u0027: True,"},{"line_number":692,"context_line":"            \u0027requested_capabilities\u0027: {"},{"line_number":693,"context_line":"                \u0027writable\u0027: \u0027True\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8d8a8294_cb475b70","line":690,"range":{"start_line":690,"start_character":8,"end_line":690,"end_character":23},"in_reply_to":"2861c08b_269a0425","updated":"2022-08-31 16:54:55.000000000","message":"Done","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":34123,"name":"Franca Mgbogu","email":"franciedigital@gmail.com","username":"franciedigital"},"change_message_id":"919f71dadce135e3bf9796aec570003d96b7a3d4","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            (\u0027check_only\u0027, \u0027True\u0027)"},{"line_number":688,"context_line":"        ]"},{"line_number":689,"context_line":""},{"line_number":690,"context_line":"        returned_result \u003d {"},{"line_number":691,"context_line":"            \u0027compatible\u0027: True,"},{"line_number":692,"context_line":"            \u0027requested_capabilities\u0027: {"},{"line_number":693,"context_line":"                \u0027writable\u0027: \u0027True\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"f0e455c4_44f9655d","line":690,"range":{"start_line":690,"start_character":8,"end_line":690,"end_character":23},"in_reply_to":"2861c08b_269a0425","updated":"2022-08-31 18:38:43.000000000","message":"Done","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5540fdf3c30006dac1e8a2f6e1745819ae2920b3","unresolved":true,"context_lines":[{"line_number":709,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":710,"context_line":"            \"2.57\")"},{"line_number":711,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":712,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        self.share_server.migration_check.assert_called_with("},{"line_number":715,"context_line":"            \u0027host@backend\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3b8a8f9a_b745fc86","line":712,"range":{"start_line":712,"start_character":8,"end_line":712,"end_character":14},"updated":"2022-08-31 14:12:39.000000000","message":"this will return a tuple, not a single result, so we will need to work with the given result.","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5540fdf3c30006dac1e8a2f6e1745819ae2920b3","unresolved":true,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        self.share_server.migration_check.assert_called_with("},{"line_number":715,"context_line":"            \u0027host@backend\u0027,"},{"line_number":716,"context_line":"            \u0027True\u0027,"},{"line_number":717,"context_line":"            \u0027True\u0027,"},{"line_number":718,"context_line":"            \u0027False\u0027,"},{"line_number":719,"context_line":"            self.new_share_network.id,"},{"line_number":720,"context_line":"            True"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d3a4d7f7_e5232db3","line":718,"range":{"start_line":716,"start_character":12,"end_line":718,"end_character":20},"updated":"2022-08-31 14:12:39.000000000","message":"share_server.migration_check uses the arguments in this order:\nhost, writable, nondisruptive, preserve_snapshots,new_share_net_id\n\nWritable is true, nondisruptive is false, preserve_snapshots is true.\nSo this should be:\n\u0027True\u0027,\n\u0027False\u0027,\n\u0027True\u0027,","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        self.share_server.migration_check.assert_called_with("},{"line_number":715,"context_line":"            \u0027host@backend\u0027,"},{"line_number":716,"context_line":"            \u0027True\u0027,"},{"line_number":717,"context_line":"            \u0027True\u0027,"},{"line_number":718,"context_line":"            \u0027False\u0027,"},{"line_number":719,"context_line":"            self.new_share_network.id,"},{"line_number":720,"context_line":"            True"},{"line_number":721,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a6fdb040_a7a86074","line":718,"range":{"start_line":716,"start_character":12,"end_line":718,"end_character":20},"in_reply_to":"d3a4d7f7_e5232db3","updated":"2022-08-31 16:54:55.000000000","message":"Done","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5540fdf3c30006dac1e8a2f6e1745819ae2920b3","unresolved":true,"context_lines":[{"line_number":717,"context_line":"            \u0027True\u0027,"},{"line_number":718,"context_line":"            \u0027False\u0027,"},{"line_number":719,"context_line":"            self.new_share_network.id,"},{"line_number":720,"context_line":"            True"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        )"},{"line_number":723,"context_line":"        self.assertEqual(result, returned_result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"98ccafd1_465a2759","line":720,"range":{"start_line":720,"start_character":0,"end_line":720,"end_character":16},"updated":"2022-08-31 14:12:39.000000000","message":"this is not needed - There are no arguments being forwarded after the new share network id","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[{"line_number":717,"context_line":"            \u0027True\u0027,"},{"line_number":718,"context_line":"            \u0027False\u0027,"},{"line_number":719,"context_line":"            self.new_share_network.id,"},{"line_number":720,"context_line":"            True"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        )"},{"line_number":723,"context_line":"        self.assertEqual(result, returned_result)"}],"source_content_type":"text/x-python","patch_set":6,"id":"d0e4331d_c7e62ea8","line":720,"range":{"start_line":720,"start_character":0,"end_line":720,"end_character":16},"in_reply_to":"98ccafd1_465a2759","updated":"2022-08-31 16:54:55.000000000","message":"Done","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5540fdf3c30006dac1e8a2f6e1745819ae2920b3","unresolved":true,"context_lines":[{"line_number":720,"context_line":"            True"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        )"},{"line_number":723,"context_line":"        self.assertEqual(result, returned_result)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def test_share_server_migration_start_with_api_version_exception(self):"},{"line_number":726,"context_line":"        \"\"\"Test share server migration start with API microversion exception\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"5ae3fad0_a3324731","line":723,"range":{"start_line":723,"start_character":25,"end_line":723,"end_character":48},"updated":"2022-08-31 14:12:39.000000000","message":"expected_result, result","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":false,"context_lines":[{"line_number":720,"context_line":"            True"},{"line_number":721,"context_line":""},{"line_number":722,"context_line":"        )"},{"line_number":723,"context_line":"        self.assertEqual(result, returned_result)"},{"line_number":724,"context_line":""},{"line_number":725,"context_line":"    def test_share_server_migration_start_with_api_version_exception(self):"},{"line_number":726,"context_line":"        \"\"\"Test share server migration start with API microversion exception\"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"a8178215_48f74022","line":723,"range":{"start_line":723,"start_character":25,"end_line":723,"end_character":48},"in_reply_to":"5ae3fad0_a3324731","updated":"2022-08-31 16:54:55.000000000","message":"Done","commit_id":"fbe2d3c831a4a70e64f3998bbf85c3c306211c13"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":true,"context_lines":[{"line_number":709,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":710,"context_line":"            \"2.57\")"},{"line_number":711,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":712,"context_line":"        (result) \u003d self.cmd.take_action(parsed_args)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        self.share_server.migration_check.assert_called_with("},{"line_number":715,"context_line":"            \u0027host@backend\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b62bb5f_1100e2ea","line":712,"range":{"start_line":712,"start_character":8,"end_line":712,"end_character":52},"updated":"2022-08-31 16:54:55.000000000","message":"I believe this should be:\n\ncolumns, data \u003d self.cmd.take_action(parsed_args)\nresult_dict \u003d {}\nfor count, column in enumerate(columns):\n    result_dict[column] \u003d data[count]","commit_id":"d784e6cde75edcb94381c819028dbca92a8fc3a5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"03f3bb4b2b59c225976f13398a584d8e2e69f56d","unresolved":true,"context_lines":[{"line_number":719,"context_line":"            self.new_share_network.id,"},{"line_number":720,"context_line":""},{"line_number":721,"context_line":"        )"},{"line_number":722,"context_line":"        self.assertEqual(result, expected_result)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def test_share_server_migration_start_with_api_version_exception(self):"},{"line_number":725,"context_line":"        \"\"\"Test share server migration start with API microversion exception\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"54af641e_5c8d8274","line":722,"range":{"start_line":722,"start_character":8,"end_line":722,"end_character":49},"updated":"2022-08-31 16:54:55.000000000","message":"self.assertEqual(expected_result, result_dict)","commit_id":"d784e6cde75edcb94381c819028dbca92a8fc3a5"}]}