)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c9e8de908d65260fe090429e1f4482d747e593a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e563ad84_504643e5","updated":"2022-09-01 14:58:51.000000000","message":"Thank you for working on this change. Please take a look at the comment inline :)","commit_id":"3b80916c80899ce6be768857025f256e1ece8277"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0fa5f8f3_caa70f3a","updated":"2022-09-01 18:19:38.000000000","message":"Thanks for your work on this change - I\u0027ve added a few commends inline, please take a look at them","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"10f27951233b68ea3040f8505b6189174eeaf80c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3ad8adc3_f06fa5ab","updated":"2022-09-01 19:39:56.000000000","message":"Minor updates on the patch to get this in. Thanks Franca for your work on this.","commit_id":"48b5ed2230b780dd0b1c73706d8a2d64a0871e62"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"40dd8fc81789c53bedf03cf2b09e962884750fd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1b3e6cd1_cd41ba1e","updated":"2022-09-01 20:37:42.000000000","message":"Thank you for the updates. Code LGTM and works just fine","commit_id":"09ab2c306401bae89bd20222705607d77ed603dc"}],"manilaclient/osc/v2/share_servers.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c9e8de908d65260fe090429e1f4482d747e593a8","unresolved":true,"context_lines":[{"line_number":582,"context_line":"                \"with manila API version \u003e\u003d 2.57\")"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"class ShareServerMigrationReset(command.Command):"},{"line_number":586,"context_line":"    \"\"\"Reset the task state of a given share server.\"\"\""},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    _description \u003d \"\"\"Reset the task state of a given share server.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"2928c3b5_27bdb937","line":585,"range":{"start_line":585,"start_character":6,"end_line":585,"end_character":31},"updated":"2022-09-01 14:58:51.000000000","message":"I believe this should be a new parameter in the share server set command. Will make the implementation way much simpler and will follow the behavior we have for shares :)","commit_id":"3b80916c80899ce6be768857025f256e1ece8277"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                \"with manila API version \u003e\u003d 2.57\")"},{"line_number":583,"context_line":""},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"class ShareServerMigrationReset(command.Command):"},{"line_number":586,"context_line":"    \"\"\"Reset the task state of a given share server.\"\"\""},{"line_number":587,"context_line":""},{"line_number":588,"context_line":"    _description \u003d \"\"\"Reset the task state of a given share server.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"8acf813c_4150d0be","line":585,"range":{"start_line":585,"start_character":6,"end_line":585,"end_character":31},"in_reply_to":"2928c3b5_27bdb937","updated":"2022-09-01 18:19:38.000000000","message":"Done","commit_id":"3b80916c80899ce6be768857025f256e1ece8277"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":true,"context_lines":[{"line_number":361,"context_line":"            msg \u003d f\u0027Failed to abandon {result} of {total} servers.\u0027"},{"line_number":362,"context_line":"            raise exceptions.CommandError(_(msg))"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"class SetShareServer(command.Command):"},{"line_number":366,"context_line":"    \"\"\"Set share server properties.\"\"\""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    _description \u003d _(\"Set share server properties (Admin only).\")"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"658bbab5_e70458a6","line":366,"range":{"start_line":364,"start_character":0,"end_line":366,"end_character":0},"updated":"2022-09-01 18:19:38.000000000","message":"I have rewritten a few things and could upload a .patch or send the entire class... here goes the entire class with the minor tweaks I changed:\n\nhttps://paste.opendev.org/show/bZsGM8iFRwEHfKqFcsS6/","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"74775a81a5846015e82ef8a6f498c101169c2ac2","unresolved":true,"context_lines":[{"line_number":361,"context_line":"            msg \u003d f\u0027Failed to abandon {result} of {total} servers.\u0027"},{"line_number":362,"context_line":"            raise exceptions.CommandError(_(msg))"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":""},{"line_number":365,"context_line":"class SetShareServer(command.Command):"},{"line_number":366,"context_line":"    \"\"\"Set share server properties.\"\"\""},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    _description \u003d _(\"Set share server properties (Admin only).\")"},{"line_number":369,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"b0e0d73f_5e90acdf","line":366,"range":{"start_line":364,"start_character":0,"end_line":366,"end_character":0},"in_reply_to":"658bbab5_e70458a6","updated":"2022-09-01 18:23:34.000000000","message":"Please ignore the link before and use this:\n\nhttps://paste.opendev.org/show/bMGQZnFakoVPyg13zDVP/","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":true,"context_lines":[{"line_number":383,"context_line":"        parser.add_argument("},{"line_number":384,"context_line":"            \"--status\","},{"line_number":385,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":386,"context_line":"            required\u003dTrue,"},{"line_number":387,"context_line":"            default\u003dconstants.STATUS_ACTIVE,"},{"line_number":388,"context_line":"            help\u003d_(\"Assign a status to the share server. Options \""},{"line_number":389,"context_line":"                   \"include: %s. If no state is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"6d4ac77d_6ef70518","line":386,"range":{"start_line":386,"start_character":0,"end_line":386,"end_character":26},"updated":"2022-09-01 18:19:38.000000000","message":"This should be required\u003dFalse now","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"10f27951233b68ea3040f8505b6189174eeaf80c","unresolved":false,"context_lines":[{"line_number":383,"context_line":"        parser.add_argument("},{"line_number":384,"context_line":"            \"--status\","},{"line_number":385,"context_line":"            metavar\u003d\"\u003cstatus\u003e\","},{"line_number":386,"context_line":"            required\u003dTrue,"},{"line_number":387,"context_line":"            default\u003dconstants.STATUS_ACTIVE,"},{"line_number":388,"context_line":"            help\u003d_(\"Assign a status to the share server. Options \""},{"line_number":389,"context_line":"                   \"include: %s. If no state is \""}],"source_content_type":"text/x-python","patch_set":3,"id":"4c0feb7b_605fa317","line":386,"range":{"start_line":386,"start_character":0,"end_line":386,"end_character":26},"in_reply_to":"6d4ac77d_6ef70518","updated":"2022-09-01 19:39:56.000000000","message":"Correct, this is not required. Fixed","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"}],"manilaclient/tests/unit/osc/v2/test_share_servers.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":true,"context_lines":[{"line_number":498,"context_line":"    def test_share_server_set_task_state(self):"},{"line_number":499,"context_line":"        arglist \u003d ["},{"line_number":500,"context_line":"            self.share_server.id,"},{"line_number":501,"context_line":"            \u0027--status\u0027, None,"},{"line_number":502,"context_line":"            \u0027--task-state\u0027, \u0027migration_in_progress\u0027"},{"line_number":503,"context_line":"        ]"},{"line_number":504,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"fbb9a066_322f5077","line":501,"range":{"start_line":501,"start_character":12,"end_line":501,"end_character":29},"updated":"2022-09-01 18:19:38.000000000","message":"as it won\u0027t be required anymore, it won\u0027t be needed","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"10f27951233b68ea3040f8505b6189174eeaf80c","unresolved":false,"context_lines":[{"line_number":498,"context_line":"    def test_share_server_set_task_state(self):"},{"line_number":499,"context_line":"        arglist \u003d ["},{"line_number":500,"context_line":"            self.share_server.id,"},{"line_number":501,"context_line":"            \u0027--status\u0027, None,"},{"line_number":502,"context_line":"            \u0027--task-state\u0027, \u0027migration_in_progress\u0027"},{"line_number":503,"context_line":"        ]"},{"line_number":504,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"3e0ba119_6e5fe7ab","line":501,"range":{"start_line":501,"start_character":12,"end_line":501,"end_character":29},"in_reply_to":"fbb9a066_322f5077","updated":"2022-09-01 19:39:56.000000000","message":"Done","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":true,"context_lines":[{"line_number":503,"context_line":"        ]"},{"line_number":504,"context_line":"        verifylist \u003d ["},{"line_number":505,"context_line":"            (\u0027share_server\u0027, self.share_server.id),"},{"line_number":506,"context_line":"            (\u0027status\u0027, None),"},{"line_number":507,"context_line":"            (\u0027task_state\u0027, \u0027migration_in_progress\u0027)"},{"line_number":508,"context_line":"        ]"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"292b0a9b_9b60efc0","line":506,"range":{"start_line":506,"start_character":12,"end_line":506,"end_character":29},"updated":"2022-09-01 18:19:38.000000000","message":"same as above","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"10f27951233b68ea3040f8505b6189174eeaf80c","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        ]"},{"line_number":504,"context_line":"        verifylist \u003d ["},{"line_number":505,"context_line":"            (\u0027share_server\u0027, self.share_server.id),"},{"line_number":506,"context_line":"            (\u0027status\u0027, None),"},{"line_number":507,"context_line":"            (\u0027task_state\u0027, \u0027migration_in_progress\u0027)"},{"line_number":508,"context_line":"        ]"},{"line_number":509,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"545682b3_38454264","line":506,"range":{"start_line":506,"start_character":12,"end_line":506,"end_character":29},"in_reply_to":"292b0a9b_9b60efc0","updated":"2022-09-01 19:39:56.000000000","message":"Done","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"}],"setup.cfg":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"6fba6d9d1ed979b0ecb29411438b1b04b4fa7b38","unresolved":true,"context_lines":[{"line_number":159,"context_line":"    share_server_migration_complete \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationComplete"},{"line_number":160,"context_line":"    share_server_migration_show \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationShow"},{"line_number":161,"context_line":"    share_server_migration_start \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationStart"},{"line_number":162,"context_line":"    share_server_migtration_reset \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationReset "},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"[coverage:run]"},{"line_number":165,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"680864b7_18500829","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":96},"updated":"2022-09-01 18:19:38.000000000","message":"please remove this line","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"ceefd59838684bb9d1ef8693c98964294dfff30a","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    share_server_migration_complete \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationComplete"},{"line_number":160,"context_line":"    share_server_migration_show \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationShow"},{"line_number":161,"context_line":"    share_server_migration_start \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationStart"},{"line_number":162,"context_line":"    share_server_migtration_reset \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationReset "},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"[coverage:run]"},{"line_number":165,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"ad4be6ce_cde93063","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":96},"in_reply_to":"2bfd9cb7_8348d8dc","updated":"2022-09-01 19:56:53.000000000","message":"ok, in PS5 is done 😊","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"10f27951233b68ea3040f8505b6189174eeaf80c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    share_server_migration_complete \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationComplete"},{"line_number":160,"context_line":"    share_server_migration_show \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationShow"},{"line_number":161,"context_line":"    share_server_migration_start \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationStart"},{"line_number":162,"context_line":"    share_server_migtration_reset \u003d manilaclient.osc.v2.share_servers:ShareServerMigrationReset "},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"[coverage:run]"},{"line_number":165,"context_line":"omit \u003d manilaclient/tests/*"}],"source_content_type":"text/x-ttcn-cfg","patch_set":3,"id":"2bfd9cb7_8348d8dc","line":162,"range":{"start_line":162,"start_character":0,"end_line":162,"end_character":96},"in_reply_to":"680864b7_18500829","updated":"2022-09-01 19:39:56.000000000","message":"Done","commit_id":"634ac8b5a4b020cb03d6dcab69fdfb115b66978b"}]}