)]}'
{"id":"openstack%2Fpython-manilaclient~863652","triplet_id":"openstack%2Fpython-manilaclient~master~I73cde764b0c13e924776652ce4ff3c5b14decd71","project":"openstack/python-manilaclient","branch":"master","topic":"bug/#1967312","attention_set":{},"removed_from_attention_set":{"35445":{"account":{"_account_id":35445,"name":"Hitesh Bhati","email":"hbhatiwork@gmail.com","username":"bhitesh"},"last_update":"2024-02-16 23:22:32.000000000","reason":"Change was abandoned"}},"hashtags":[],"change_id":"I73cde764b0c13e924776652ce4ff3c5b14decd71","subject":"On branch bug/#1967312  Changes to be committed: Missing param check in list command","status":"ABANDONED","created":"2022-11-04 14:14:04.000000000","updated":"2024-02-16 23:22:32.000000000","total_comment_count":2,"unresolved_comment_count":1,"has_review_started":true,"meta_rev_id":"32bc33f651f57874a9d4d9d7ffad1a72c9480f2d","_number":863652,"virtual_id_number":863652,"owner":{"_account_id":35445,"name":"Hitesh Bhati","email":"hbhatiwork@gmail.com","username":"bhitesh"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"tag":"autogenerated:zuul:check","value":1,"date":"2022-11-10 20:26:47.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"all":[{"value":-1,"date":"2022-11-10 19:47:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-11-04 15:32:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-11-10 19:47:05.000000000","updated_by":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"reviewer":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"state":"REVIEWER"}],"messages":[{"id":"a56d2e783c1e10d55a2eeaec0bd889ab86c41936","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":35445,"name":"Hitesh Bhati","email":"hbhatiwork@gmail.com","username":"bhitesh"},"date":"2022-11-04 14:14:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7370bf93fdc5ca6af65eb505fef6d5b30c323ba2","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-04 15:32:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/72911595b4664b57bfd6a2b499de43ce\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f0e2694764294b9487fbc7dbdcfb68c6 : SUCCESS in 5m 31s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a63040f931e146a9b12177672f4e1f7c : SUCCESS in 4m 29s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/78250767a496470e88dc41109fc0103a : SUCCESS in 3m 18s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/50a21c0c244b4bb68d055082a45c4b2a : SUCCESS in 3m 34s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/aa87eadacd0a4430ba8b0cc1d1818d72 : SUCCESS in 3m 55s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/c97bdfb4d01740daadb4cf1543444076 : SUCCESS in 3m 58s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/7fa67113409c48fea4a2cf1e850172c0 : SUCCESS in 52m 31s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/abe18c2f85a741319146b2c903e572e8 : SUCCESS in 33m 32s (non-voting)\n- python-manilaclient-functional-fips https://zuul.opendev.org/t/openstack/build/b149711c95e3479db3cbc18b7c3d56dc : SUCCESS in 1h 06m 34s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/d5fe46a46d4749b682d8e945b9bdb683 : SUCCESS in 38m 44s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"db6a73faeb6dbdc64b42f86255e1bb7e8c98b375","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":35445,"name":"Hitesh Bhati","email":"hbhatiwork@gmail.com","username":"bhitesh"},"date":"2022-11-10 19:14:28.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"ca9cf8a24bd07da515f7823129ac0e36c81a94bc","author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"date":"2022-11-10 19:47:05.000000000","message":"Patch Set 2: Code-Review-1\n\n(2 comments)","accounts_in_message":[],"_revision_number":2},{"id":"d09bbffddffcf64aeaa91bee668b904be177deab","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-11-10 20:26:47.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/52963271ad374f9989327e497b2ca4ab\n\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ec1e2489c65941088645dfb2367b728f : SUCCESS in 6m 11s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/9bf0d04ec4524e1498daabdbd4450a20 : SUCCESS in 4m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/53d516a22bc342db894dfc1e8f0a3804 : SUCCESS in 3m 07s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/ddad89b39df948c78ea96c44fd627f19 : SUCCESS in 3m 46s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/7559fe774482451798ab067f9da8995a : SUCCESS in 3m 53s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/8a40a85e6aed4541a2fe63fabf4cf429 : SUCCESS in 4m 10s (non-voting)\n- python-manilaclient-functional https://zuul.opendev.org/t/openstack/build/d50d2882fbf8455dbf5fd91cffbbb47b : SUCCESS in 56m 04s\n- manila-rally-ss https://zuul.opendev.org/t/openstack/build/c93cc5eff6f148e7b594aca68a1578ed : SUCCESS in 40m 30s (non-voting)\n- python-manilaclient-functional-fips https://zuul.opendev.org/t/openstack/build/d730b39ab24441dd9b9604be287ac296 : SUCCESS in 1h 07m 27s (non-voting)\n- manila-rally-no-ss https://zuul.opendev.org/t/openstack/build/1966312fe7f8409794c51f6c0eabb7f3 : SUCCESS in 37m 49s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"32bc33f651f57874a9d4d9d7ffad1a72c9480f2d","tag":"autogenerated:gerrit:abandon","author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"date":"2024-02-16 23:22:32.000000000","message":"Abandoned\n\nNo follow up; abandoning.. there\u0027s another change addressing this: https://review.opendev.org/c/openstack/python-manilaclient/+/863652/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1081e79dcf1eceb451c952d978a1b00f79745a36","revisions":{"0bc1a748dcd06c42fd3bf81940a54d718daf9570":{"kind":"REWORK","_number":1,"created":"2022-11-04 14:14:04.000000000","uploader":{"_account_id":35445,"name":"Hitesh Bhati","email":"hbhatiwork@gmail.com","username":"bhitesh"},"ref":"refs/changes/52/863652/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/52/863652/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/1"}}},"commit":{"parents":[{"commit":"f5bf36b1ec470262145a9b86b17174365a74fd41","subject":"Merge \"Respect OS_CACERT when using Manila OSC plugin\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f5bf36b1ec470262145a9b86b17174365a74fd41"}]}],"author":{"name":"bhitesh","email":"hbhatiwork@gmail.com","date":"2022-11-04 14:09:54.000000000","tz":0},"committer":{"name":"bhitesh","email":"hbhatiwork@gmail.com","date":"2022-11-04 14:09:54.000000000","tz":0},"subject":" On branch bug/#1967312  Changes to be committed: \tmodified:   manilaclient/v2/shares.py","message":" On branch bug/#1967312\n Changes to be committed:\n\tmodified:   manilaclient/v2/shares.py\n\nChange-Id: I73cde764b0c13e924776652ce4ff3c5b14decd71\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/0bc1a748dcd06c42fd3bf81940a54d718daf9570"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/0bc1a748dcd06c42fd3bf81940a54d718daf9570"}]},"branch":"refs/heads/master"},"1081e79dcf1eceb451c952d978a1b00f79745a36":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2022-11-10 19:14:28.000000000","uploader":{"_account_id":35445,"name":"Hitesh Bhati","email":"hbhatiwork@gmail.com","username":"bhitesh"},"ref":"refs/changes/52/863652/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-manilaclient","ref":"refs/changes/52/863652/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-manilaclient refs/changes/52/863652/2"}}},"commit":{"parents":[{"commit":"f5bf36b1ec470262145a9b86b17174365a74fd41","subject":"Merge \"Respect OS_CACERT when using Manila OSC plugin\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/f5bf36b1ec470262145a9b86b17174365a74fd41"}]}],"author":{"name":"bhitesh","email":"hbhatiwork@gmail.com","date":"2022-11-04 14:09:54.000000000","tz":0},"committer":{"name":"bhitesh","email":"hbhatiwork@gmail.com","date":"2022-11-08 18:43:52.000000000","tz":0},"subject":" On branch bug/#1967312  Changes to be committed: Missing param check in list command","message":" On branch bug/#1967312\n Changes to be committed:\nMissing param check in list command\n\nIn the list implementation for API version 2.35 to 2.68\nwe are not sanitizing the search_opts param.\n\nERROR: If this param is not set (which is the default value)\nthis leads to \"AttributeError: \u0027NoneType\u0027 object has no\nattribute \u0027pop\u0027\"\n\nworkaround this problem by chenging search_opts from none to\ndictionary\n\nCloses-Bug: #1967312\n\nChange-Id: I73cde764b0c13e924776652ce4ff3c5b14decd71\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/1081e79dcf1eceb451c952d978a1b00f79745a36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-manilaclient/commit/1081e79dcf1eceb451c952d978a1b00f79745a36"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{}}}]}