)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"c7f7b36250e164a8b21a635ab1af39c154564f53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"51d57030_f9d3b64f","updated":"2023-02-03 19:45:28.000000000","message":"As with my share+snapshots client patch, its not necessary to add the create subnet with meteadata capability in the shell, but its okay if its included. Otherwise, this patch looks good to me :) ","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":34489,"name":"Matheus Andrade","email":"matheus.handrade15@gmail.com","username":"matheusandrade"},"change_message_id":"eb3dbfcad21fca7e9c1a13df00b6387c5ae9f5f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"35c7c1c0_918fb945","updated":"2023-02-14 14:58:10.000000000","message":"In addition to the points raised by Carlos, please resolve the merge conflict.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c564c1feaec1b6b3a10866d9a7a335e1a96c87a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fe646659_29aa4394","updated":"2023-02-08 22:05:44.000000000","message":"Thanks for working on this change - Please take a look at the comments inline :)","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e4e4846b01548be77ceac79d501a973068b7a2d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f3007bd6_16c78379","updated":"2023-04-10 19:54:42.000000000","message":"Felipe, could you please update this change?","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4c67609_d56044f6","updated":"2023-03-08 23:04:41.000000000","message":"Thanks all for the reviews, see my comments.","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":33756,"name":"Luisa","email":"luisarfamaral@gmail.com","username":"rfluisa"},"change_message_id":"3cd59bd671fa6a2e16c0a3d0c119d134e5623230","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4d3d67b_0215a489","updated":"2023-03-09 18:40:43.000000000","message":"Thanks for addressing the comments. LGTM 😊","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":34489,"name":"Matheus Andrade","email":"matheus.handrade15@gmail.com","username":"matheusandrade"},"change_message_id":"6f18f986e23a935d3b9b76b2a274c9d0da2e6ec6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0dd6a9a_7da8a718","updated":"2023-03-09 18:49:40.000000000","message":"Thanks for solving the points raised! LGTM ","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"87b86424_764df2cb","updated":"2023-03-11 00:05:53.000000000","message":"Thanks for this change Felipe, could you please see my comments inline","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c831e2326b398602f5bf78565713d1d9c0bfddd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"08545fe1_87d0efdb","updated":"2023-07-05 21:57:08.000000000","message":"Felipe, a reminder to address comments on this patch. i\u0027m hoping we can get this shipped as part of the M-2 release: \n\nhttps://review.opendev.org/c/openstack/releases/+/887498","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"74a2f3ffef4a01b2102a1ebab3c17653b965646e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af230c35_69bb4c7b","updated":"2023-05-15 21:50:51.000000000","message":"Hey, Felipe! Just gave this change a try.\nWhile performing share network show, I found an issue [1]. I have done the DB migration and have a share network with subnets that don\u0027t have any properties. Instead of displaying the property as empty, I got a python object. Same happens after I set one property. Share network subnet show works just fine though. Could you please take a look?\n\n[1] https://paste.opendev.org/show/bgTYHmXYXG6LgovBGWv5/","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f654448e8a16988eaef6ff944347021d705e7b07","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c8d13ff4_d05cad8b","in_reply_to":"0b396146_79d5ed26","updated":"2023-07-07 20:09:11.000000000","message":"Hi Felipe, here are the steps to reproduce the issue: https://paste.opendev.org/show/bxcvCngiOOcUuXw7uIRp/\n\nIn summary:\n- Create a share network and that will give you also a subnet\n- Apply your changes in Manila and do a db sync\n- Apply your changes to manilaclient/OSC\n- Show the share network\n\nThe subnet inside the share network will show you:\n\n`properties \u003d \u003cosc_lib.cli.format_columns.DictColumn object at 0x7faba023cb20\u003e`\n\nI\u0027m asking Goutham to test this on his env too, so we can ensure this is not an issue.","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0b396146_79d5ed26","in_reply_to":"af230c35_69bb4c7b","updated":"2023-07-07 19:27:13.000000000","message":"Hi Carlos! Thank you for the review. At least with the latest patch in my env, the bug was not reproduced. See: https://paste.opendev.org/show/bSAiOP32RExdd4MARzRc/\n\nCan you provide more info ?","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"212852702e794d359835d61d4d50bc0dbc449c8a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"356754b4_8a8ec96b","in_reply_to":"c8d13ff4_d05cad8b","updated":"2023-07-07 22:48:43.000000000","message":"works fine for me.. https://paste.openstack.org/show/b1pfoKMsIUJlNnawln1C/","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"4c95e4b457f93565f55add41f075262a131e10ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"883a4175_da05ea50","updated":"2023-07-10 12:21:05.000000000","message":"LGTM, thanks Felipe","commit_id":"e3f01e5c2a134cd0b228bf35c70d6d110187ee36"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"212852702e794d359835d61d4d50bc0dbc449c8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7b35269b_e9942ec3","updated":"2023-07-07 22:48:43.000000000","message":"LGTM; thanks Felipe!","commit_id":"e3f01e5c2a134cd0b228bf35c70d6d110187ee36"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c2356075_06f8f174","updated":"2023-07-07 19:27:13.000000000","message":"Thanks Goutham and Carlos for the reviews. See new patch.","commit_id":"e3f01e5c2a134cd0b228bf35c70d6d110187ee36"}],"manilaclient/api_versions.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c564c1feaec1b6b3a10866d9a7a335e1a96c87a2","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.74\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"c9437e47_174dffa1","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":20},"updated":"2023-02-08 22:05:44.000000000","message":"please bump the microversion","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a811e6260720b80d32a88300af4160de77af74e4","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.74\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"49b7a6d9_b0fdd211","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":20},"in_reply_to":"808dc70c_183f0f26","updated":"2023-03-08 23:18:41.000000000","message":"Done","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.74\u0027"},{"line_number":31,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":32,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"},{"line_number":33,"context_line":"_VERSIONED_METHOD_MAP \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"808dc70c_183f0f26","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":20},"in_reply_to":"c9437e47_174dffa1","updated":"2023-03-08 23:04:41.000000000","message":"fixed","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"}],"manilaclient/osc/v2/share_network_subnets.py":[{"author":{"_account_id":33756,"name":"Luisa","email":"luisarfamaral@gmail.com","username":"rfluisa"},"change_message_id":"5f0efab5ba283420390c7d5a6e6939428ba65899","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":137,"context_line":"                availability_zone\u003dparsed_args.availability_zone,"},{"line_number":138,"context_line":"                share_network_id\u003dshare_network_id,"},{"line_number":139,"context_line":"                metadata\u003dparsed_args.property"},{"line_number":140,"context_line":"            )"},{"line_number":141,"context_line":"            subnet_data \u003d share_network_subnet._info"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"89bc76b6_d2a9f043","line":139,"updated":"2023-02-08 18:19:52.000000000","message":"If the user sets the check_only or restart_check flag and wants to check the subnet with properties, the properties will be ignored and the user will have no feedback about this whatsoever. Another condition evaluating properties and the mentioned flags with an exception to warn the user would be interesting.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a811e6260720b80d32a88300af4160de77af74e4","unresolved":false,"context_lines":[{"line_number":136,"context_line":"                neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":137,"context_line":"                availability_zone\u003dparsed_args.availability_zone,"},{"line_number":138,"context_line":"                share_network_id\u003dshare_network_id,"},{"line_number":139,"context_line":"                metadata\u003dparsed_args.property"},{"line_number":140,"context_line":"            )"},{"line_number":141,"context_line":"            subnet_data \u003d share_network_subnet._info"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"09a83203_97281dbc","line":139,"in_reply_to":"84aa32cb_6b050bf9","updated":"2023-03-08 23:18:41.000000000","message":"Done","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":true,"context_lines":[{"line_number":136,"context_line":"                neutron_subnet_id\u003dparsed_args.neutron_subnet_id,"},{"line_number":137,"context_line":"                availability_zone\u003dparsed_args.availability_zone,"},{"line_number":138,"context_line":"                share_network_id\u003dshare_network_id,"},{"line_number":139,"context_line":"                metadata\u003dparsed_args.property"},{"line_number":140,"context_line":"            )"},{"line_number":141,"context_line":"            subnet_data \u003d share_network_subnet._info"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"84aa32cb_6b050bf9","line":139,"in_reply_to":"89bc76b6_d2a9f043","updated":"2023-03-08 23:04:41.000000000","message":"Good point. Fixed.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c564c1feaec1b6b3a10866d9a7a335e1a96c87a2","unresolved":true,"context_lines":[{"line_number":217,"context_line":"            parsed_args.share_network_subnet)"},{"line_number":218,"context_line":"        data \u003d share_network_subnet._info"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Special mapping for columns to make the output easier to read:"},{"line_number":221,"context_line":"        # \u0027metadata\u0027 --\u003e \u0027properties\u0027"},{"line_number":222,"context_line":"        data.update("},{"line_number":223,"context_line":"            {"},{"line_number":224,"context_line":"                \u0027properties\u0027:"},{"line_number":225,"context_line":"                    format_columns.DictColumn(data.pop(\u0027metadata\u0027, {})),"},{"line_number":226,"context_line":"            },"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        return self.dict2columns(data)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ef3c156a_4bb36c81","line":227,"range":{"start_line":220,"start_character":8,"end_line":227,"end_character":9},"updated":"2023-02-08 22:05:44.000000000","message":"thanks for taking care of this formatting - We are missing the same on the share network show though, could you please take a look if possible?\nhttps://paste.opendev.org/show/bLrWf7jumBkLQfkt3j2F/","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a811e6260720b80d32a88300af4160de77af74e4","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            parsed_args.share_network_subnet)"},{"line_number":218,"context_line":"        data \u003d share_network_subnet._info"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Special mapping for columns to make the output easier to read:"},{"line_number":221,"context_line":"        # \u0027metadata\u0027 --\u003e \u0027properties\u0027"},{"line_number":222,"context_line":"        data.update("},{"line_number":223,"context_line":"            {"},{"line_number":224,"context_line":"                \u0027properties\u0027:"},{"line_number":225,"context_line":"                    format_columns.DictColumn(data.pop(\u0027metadata\u0027, {})),"},{"line_number":226,"context_line":"            },"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        return self.dict2columns(data)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8e86f725_1d127a50","line":227,"range":{"start_line":220,"start_character":8,"end_line":227,"end_character":9},"in_reply_to":"8604d1c0_38042b03","updated":"2023-03-08 23:18:41.000000000","message":"Done","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":true,"context_lines":[{"line_number":217,"context_line":"            parsed_args.share_network_subnet)"},{"line_number":218,"context_line":"        data \u003d share_network_subnet._info"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        # Special mapping for columns to make the output easier to read:"},{"line_number":221,"context_line":"        # \u0027metadata\u0027 --\u003e \u0027properties\u0027"},{"line_number":222,"context_line":"        data.update("},{"line_number":223,"context_line":"            {"},{"line_number":224,"context_line":"                \u0027properties\u0027:"},{"line_number":225,"context_line":"                    format_columns.DictColumn(data.pop(\u0027metadata\u0027, {})),"},{"line_number":226,"context_line":"            },"},{"line_number":227,"context_line":"        )"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        return self.dict2columns(data)"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"8604d1c0_38042b03","line":227,"range":{"start_line":220,"start_character":8,"end_line":227,"end_character":9},"in_reply_to":"ef3c156a_4bb36c81","updated":"2023-03-08 23:04:41.000000000","message":"good catch. Fixed.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":33756,"name":"Luisa","email":"luisarfamaral@gmail.com","username":"rfluisa"},"change_message_id":"45bf832ee5a0010add104aa37da9adb513c6a307","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    def take_action(self, parsed_args):"},{"line_number":260,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if (parsed_args.property and"},{"line_number":263,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.74\")):"},{"line_number":264,"context_line":"            raise exceptions.CommandError("},{"line_number":265,"context_line":"                \"Property can be specified only with manila API \""}],"source_content_type":"text/x-python","patch_set":1,"id":"11e6a911_3ee31987","line":262,"updated":"2023-02-08 18:54:09.000000000","message":"In parent change, the coverage for this file was 100%. After your changes, it dropped to 96%. The exception conditions inside take_action of both classes aren\u0027t currently covered, could you please cover them in the unit tests?","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    def take_action(self, parsed_args):"},{"line_number":260,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if (parsed_args.property and"},{"line_number":263,"context_line":"                share_client.api_version \u003c api_versions.APIVersion(\"2.74\")):"},{"line_number":264,"context_line":"            raise exceptions.CommandError("},{"line_number":265,"context_line":"                \"Property can be specified only with manila API \""}],"source_content_type":"text/x-python","patch_set":1,"id":"155d2a2c_72c09f3b","line":262,"in_reply_to":"11e6a911_3ee31987","updated":"2023-03-08 23:04:41.000000000","message":"fixed.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c564c1feaec1b6b3a10866d9a7a335e1a96c87a2","unresolved":true,"context_lines":[{"line_number":325,"context_line":"                    share_client.share_network_subnets.delete_metadata("},{"line_number":326,"context_line":"                        share_network_id, [key],"},{"line_number":327,"context_line":"                        subresource\u003dparsed_args.share_network_subnet)"},{"line_number":328,"context_line":"                except Exception as e:"},{"line_number":329,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":330,"context_line":"                        \"Failed to unset subnet property \""},{"line_number":331,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":332,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"02d4d838_90c8b198","line":332,"range":{"start_line":328,"start_character":16,"end_line":332,"end_character":45},"updated":"2023-02-08 22:05:44.000000000","message":"message formatting isn\u0027t working properly here. Could you please take a look?  https://paste.opendev.org/show/b06BDqvqVfJ1LZNceEEk/","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":true,"context_lines":[{"line_number":325,"context_line":"                    share_client.share_network_subnets.delete_metadata("},{"line_number":326,"context_line":"                        share_network_id, [key],"},{"line_number":327,"context_line":"                        subresource\u003dparsed_args.share_network_subnet)"},{"line_number":328,"context_line":"                except Exception as e:"},{"line_number":329,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":330,"context_line":"                        \"Failed to unset subnet property \""},{"line_number":331,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":332,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"f339a754_f495aefa","line":332,"range":{"start_line":328,"start_character":16,"end_line":332,"end_character":45},"in_reply_to":"02d4d838_90c8b198","updated":"2023-03-08 23:04:41.000000000","message":"nice, fixed.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a811e6260720b80d32a88300af4160de77af74e4","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                    share_client.share_network_subnets.delete_metadata("},{"line_number":326,"context_line":"                        share_network_id, [key],"},{"line_number":327,"context_line":"                        subresource\u003dparsed_args.share_network_subnet)"},{"line_number":328,"context_line":"                except Exception as e:"},{"line_number":329,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":330,"context_line":"                        \"Failed to unset subnet property \""},{"line_number":331,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\"),"},{"line_number":332,"context_line":"                        {\u0027key\u0027: key, \u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":1,"id":"87ebcca9_7a3a9a52","line":332,"range":{"start_line":328,"start_character":16,"end_line":332,"end_character":45},"in_reply_to":"f339a754_f495aefa","updated":"2023-03-08 23:18:41.000000000","message":"Done","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":325,"context_line":"            parsed_args.share_network).id"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        if parsed_args.property:"},{"line_number":328,"context_line":"            for key in parsed_args.property:"},{"line_number":329,"context_line":"                try:"},{"line_number":330,"context_line":"                    share_client.share_network_subnets.delete_metadata("},{"line_number":331,"context_line":"                        share_network_id, [key],"},{"line_number":332,"context_line":"                        subresource\u003dparsed_args.share_network_subnet)"},{"line_number":333,"context_line":"                except Exception as e:"},{"line_number":334,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":335,"context_line":"                        \"Failed to unset subnet property \""},{"line_number":336,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\") % {\u0027key\u0027: key, \u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba6109b0_a5343f3e","line":336,"range":{"start_line":328,"start_character":0,"end_line":336,"end_character":67},"updated":"2023-03-11 00:05:53.000000000","message":"The delete operation shouldn\u0027t try..except errors and process the complete list and not error out on the first error.. Check lines 178..192 of this file to see a pattern of how to do this","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":325,"context_line":"            parsed_args.share_network).id"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        if parsed_args.property:"},{"line_number":328,"context_line":"            for key in parsed_args.property:"},{"line_number":329,"context_line":"                try:"},{"line_number":330,"context_line":"                    share_client.share_network_subnets.delete_metadata("},{"line_number":331,"context_line":"                        share_network_id, [key],"},{"line_number":332,"context_line":"                        subresource\u003dparsed_args.share_network_subnet)"},{"line_number":333,"context_line":"                except Exception as e:"},{"line_number":334,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":335,"context_line":"                        \"Failed to unset subnet property \""},{"line_number":336,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\") % {\u0027key\u0027: key, \u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"bd14a260_bb47ea32","line":336,"range":{"start_line":328,"start_character":0,"end_line":336,"end_character":67},"in_reply_to":"1c482dfc_e386ba62","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":325,"context_line":"            parsed_args.share_network).id"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        if parsed_args.property:"},{"line_number":328,"context_line":"            for key in parsed_args.property:"},{"line_number":329,"context_line":"                try:"},{"line_number":330,"context_line":"                    share_client.share_network_subnets.delete_metadata("},{"line_number":331,"context_line":"                        share_network_id, [key],"},{"line_number":332,"context_line":"                        subresource\u003dparsed_args.share_network_subnet)"},{"line_number":333,"context_line":"                except Exception as e:"},{"line_number":334,"context_line":"                    raise exceptions.CommandError(_("},{"line_number":335,"context_line":"                        \"Failed to unset subnet property \""},{"line_number":336,"context_line":"                        \"\u0027%(key)s\u0027: %(e)s\") % {\u0027key\u0027: key, \u0027e\u0027: e})"}],"source_content_type":"text/x-python","patch_set":2,"id":"1c482dfc_e386ba62","line":336,"range":{"start_line":328,"start_character":0,"end_line":336,"end_character":67},"in_reply_to":"ba6109b0_a5343f3e","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"}],"manilaclient/tests/unit/osc/v2/test_share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            share_network_id\u003dself.share_network.id,"},{"line_number":190,"context_line":"            metadata\u003d{\u0027Manila\u0027: \u0027zorilla\u0027, \u0027Zorilla\u0027: \u0027manila\u0027},"},{"line_number":191,"context_line":"        )"},{"line_number":192,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":193,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_share_network_subnet_create_metadata_api_version_exception(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"457c8129_72f534ce","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":29},"updated":"2023-03-11 00:05:53.000000000","message":"\"assertEqual\" is a tighter assertion to make here since we\u0027re only comparing the column names.","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":189,"context_line":"            share_network_id\u003dself.share_network.id,"},{"line_number":190,"context_line":"            metadata\u003d{\u0027Manila\u0027: \u0027zorilla\u0027, \u0027Zorilla\u0027: \u0027manila\u0027},"},{"line_number":191,"context_line":"        )"},{"line_number":192,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":193,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_share_network_subnet_create_metadata_api_version_exception(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"daf39987_53255e23","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":29},"in_reply_to":"457c8129_72f534ce","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":189,"context_line":"            share_network_id\u003dself.share_network.id,"},{"line_number":190,"context_line":"            metadata\u003d{\u0027Manila\u0027: \u0027zorilla\u0027, \u0027Zorilla\u0027: \u0027manila\u0027},"},{"line_number":191,"context_line":"        )"},{"line_number":192,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":193,"context_line":"        self.assertCountEqual(self.data, data)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def test_share_network_subnet_create_metadata_api_version_exception(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"57833f6a_e5f8e026","line":192,"range":{"start_line":192,"start_character":13,"end_line":192,"end_character":29},"in_reply_to":"daf39987_53255e23","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        arglist \u003d ["},{"line_number":340,"context_line":"            self.share_network.id,"},{"line_number":341,"context_line":"            self.share_network_subnet.id,"},{"line_number":342,"context_line":"            \u0027--property\u0027, \u0027Zorilla\u003dmanila\u0027,"},{"line_number":343,"context_line":"        ]"},{"line_number":344,"context_line":"        verifylist \u003d ["},{"line_number":345,"context_line":"            (\u0027share_network\u0027, self.share_network.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"7dd7f659_d59d30de","line":342,"range":{"start_line":342,"start_character":42,"end_line":342,"end_character":43},"updated":"2023-03-11 00:05:53.000000000","message":"please try repeating the option and setting a different property","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":339,"context_line":"        arglist \u003d ["},{"line_number":340,"context_line":"            self.share_network.id,"},{"line_number":341,"context_line":"            self.share_network_subnet.id,"},{"line_number":342,"context_line":"            \u0027--property\u0027, \u0027Zorilla\u003dmanila\u0027,"},{"line_number":343,"context_line":"        ]"},{"line_number":344,"context_line":"        verifylist \u003d ["},{"line_number":345,"context_line":"            (\u0027share_network\u0027, self.share_network.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1c04c6_ac695f52","line":342,"range":{"start_line":342,"start_character":42,"end_line":342,"end_character":43},"in_reply_to":"7dd7f659_d59d30de","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":339,"context_line":"        arglist \u003d ["},{"line_number":340,"context_line":"            self.share_network.id,"},{"line_number":341,"context_line":"            self.share_network_subnet.id,"},{"line_number":342,"context_line":"            \u0027--property\u0027, \u0027Zorilla\u003dmanila\u0027,"},{"line_number":343,"context_line":"        ]"},{"line_number":344,"context_line":"        verifylist \u003d ["},{"line_number":345,"context_line":"            (\u0027share_network\u0027, self.share_network.id),"}],"source_content_type":"text/x-python","patch_set":2,"id":"624b29aa_a0acffe1","line":342,"range":{"start_line":342,"start_character":42,"end_line":342,"end_character":43},"in_reply_to":"9a1c04c6_ac695f52","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":377,"context_line":"            self.share_network.id, {\u0027key\u0027: \u00271\u0027},"},{"line_number":378,"context_line":"            subresource\u003dself.share_network_subnet.id)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # \u0027--property\u0027 takes key\u003dvalue arguments missing a value would raise"},{"line_number":381,"context_line":"        # a BadRequest."},{"line_number":382,"context_line":"        self.share_subnets_mock.set_metadata.side_effect \u003d ("},{"line_number":383,"context_line":"            exceptions.BadRequest)"},{"line_number":384,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"6206fc3a_a788e4bb","line":381,"range":{"start_line":380,"start_character":7,"end_line":381,"end_character":23},"updated":"2023-03-11 00:05:53.000000000","message":"the comment doesn\u0027t make sense here... you\u0027re expecting to see a command error if the API responds with a BadRequest","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":377,"context_line":"            self.share_network.id, {\u0027key\u0027: \u00271\u0027},"},{"line_number":378,"context_line":"            subresource\u003dself.share_network_subnet.id)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # \u0027--property\u0027 takes key\u003dvalue arguments missing a value would raise"},{"line_number":381,"context_line":"        # a BadRequest."},{"line_number":382,"context_line":"        self.share_subnets_mock.set_metadata.side_effect \u003d ("},{"line_number":383,"context_line":"            exceptions.BadRequest)"},{"line_number":384,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"085cc9e4_6fd5087f","line":381,"range":{"start_line":380,"start_character":7,"end_line":381,"end_character":23},"in_reply_to":"3781dd96_0ecc370a","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":377,"context_line":"            self.share_network.id, {\u0027key\u0027: \u00271\u0027},"},{"line_number":378,"context_line":"            subresource\u003dself.share_network_subnet.id)"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # \u0027--property\u0027 takes key\u003dvalue arguments missing a value would raise"},{"line_number":381,"context_line":"        # a BadRequest."},{"line_number":382,"context_line":"        self.share_subnets_mock.set_metadata.side_effect \u003d ("},{"line_number":383,"context_line":"            exceptions.BadRequest)"},{"line_number":384,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":2,"id":"3781dd96_0ecc370a","line":381,"range":{"start_line":380,"start_character":7,"end_line":381,"end_character":23},"in_reply_to":"6206fc3a_a788e4bb","updated":"2023-05-09 01:50:06.000000000","message":"removed the comment.","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            subresource\u003dself.share_network_subnet.id)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        # 404 Not Found would be raised, if property \u0027Manila\u0027 doesn\u0027t exist."},{"line_number":451,"context_line":"        self.share_subnets_mock.delete_metadata.side_effect \u003d ("},{"line_number":452,"context_line":"            exceptions.NotFound)"},{"line_number":453,"context_line":"        self.assertRaises("},{"line_number":454,"context_line":"            exceptions.CommandError, self.cmd.take_action, parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"122bb8b4_d04dd408","line":452,"range":{"start_line":451,"start_character":8,"end_line":452,"end_character":32},"updated":"2023-03-11 00:05:53.000000000","message":"Please test unsetting multiple properties with different side effects","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":448,"context_line":"            subresource\u003dself.share_network_subnet.id)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        # 404 Not Found would be raised, if property \u0027Manila\u0027 doesn\u0027t exist."},{"line_number":451,"context_line":"        self.share_subnets_mock.delete_metadata.side_effect \u003d ("},{"line_number":452,"context_line":"            exceptions.NotFound)"},{"line_number":453,"context_line":"        self.assertRaises("},{"line_number":454,"context_line":"            exceptions.CommandError, self.cmd.take_action, parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"e54986d2_1f5602a7","line":452,"range":{"start_line":451,"start_character":8,"end_line":452,"end_character":32},"in_reply_to":"122bb8b4_d04dd408","updated":"2023-05-09 01:50:06.000000000","message":"done.","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            subresource\u003dself.share_network_subnet.id)"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"        # 404 Not Found would be raised, if property \u0027Manila\u0027 doesn\u0027t exist."},{"line_number":451,"context_line":"        self.share_subnets_mock.delete_metadata.side_effect \u003d ("},{"line_number":452,"context_line":"            exceptions.NotFound)"},{"line_number":453,"context_line":"        self.assertRaises("},{"line_number":454,"context_line":"            exceptions.CommandError, self.cmd.take_action, parsed_args)"}],"source_content_type":"text/x-python","patch_set":2,"id":"61d38f4c_4a146568","line":452,"range":{"start_line":451,"start_character":8,"end_line":452,"end_character":32},"in_reply_to":"e54986d2_1f5602a7","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"}],"manilaclient/v2/share_network_subnets.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    resource_path \u003d \u0027/share-networks\u0027"},{"line_number":41,"context_line":"    subresource_path \u003d \u0027/subnets\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":44,"context_line":"               availability_zone\u003dNone, share_network_id\u003dNone, metadata\u003dNone):"},{"line_number":45,"context_line":"        \"\"\"Create share network subnet."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :param neutron_net_id: ID of Neutron network"},{"line_number":48,"context_line":"        :param neutron_subnet_id: ID of Neutron subnet"},{"line_number":49,"context_line":"        :param availability_zone: Name of the target availability zone"},{"line_number":50,"context_line":"        :param metadata: dict - optional metadata to set on share creation"},{"line_number":51,"context_line":"        :rtype: :class:`ShareNetworkSubnet`"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        values \u003d {}"},{"line_number":54,"context_line":"        if neutron_net_id:"},{"line_number":55,"context_line":"            values[\u0027neutron_net_id\u0027] \u003d neutron_net_id"},{"line_number":56,"context_line":"        if neutron_subnet_id:"},{"line_number":57,"context_line":"            values[\u0027neutron_subnet_id\u0027] \u003d neutron_subnet_id"},{"line_number":58,"context_line":"        if availability_zone:"},{"line_number":59,"context_line":"            values[\u0027availability_zone\u0027] \u003d availability_zone"},{"line_number":60,"context_line":"        if metadata:"},{"line_number":61,"context_line":"            values[\u0027metadata\u0027] \u003d metadata"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        body \u003d {\u0027share-network-subnet\u0027: values}"},{"line_number":64,"context_line":"        url \u003d \u0027/share-networks/%(share_network_id)s/subnets\u0027 % {"},{"line_number":65,"context_line":"            \u0027share_network_id\u0027: share_network_id"},{"line_number":66,"context_line":"        }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return self._create(url, body, RESOURCE_NAME)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get(self, share_network, share_network_subnet):"},{"line_number":71,"context_line":"        \"\"\"Get a share network subnet."}],"source_content_type":"text/x-python","patch_set":2,"id":"6b9db223_390f1611","line":68,"range":{"start_line":43,"start_character":0,"end_line":68,"end_character":53},"updated":"2023-03-11 00:05:53.000000000","message":"You must version this; take a look at an example in the snapshot resource https://github.com/openstack/python-manilaclient/blob/5abe26346340eecdf84195a4cef4f0f1f3bf9d66/manilaclient/v2/share_snapshots.py#L66-L95","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    resource_path \u003d \u0027/share-networks\u0027"},{"line_number":41,"context_line":"    subresource_path \u003d \u0027/subnets\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":44,"context_line":"               availability_zone\u003dNone, share_network_id\u003dNone, metadata\u003dNone):"},{"line_number":45,"context_line":"        \"\"\"Create share network subnet."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :param neutron_net_id: ID of Neutron network"},{"line_number":48,"context_line":"        :param neutron_subnet_id: ID of Neutron subnet"},{"line_number":49,"context_line":"        :param availability_zone: Name of the target availability zone"},{"line_number":50,"context_line":"        :param metadata: dict - optional metadata to set on share creation"},{"line_number":51,"context_line":"        :rtype: :class:`ShareNetworkSubnet`"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        values \u003d {}"},{"line_number":54,"context_line":"        if neutron_net_id:"},{"line_number":55,"context_line":"            values[\u0027neutron_net_id\u0027] \u003d neutron_net_id"},{"line_number":56,"context_line":"        if neutron_subnet_id:"},{"line_number":57,"context_line":"            values[\u0027neutron_subnet_id\u0027] \u003d neutron_subnet_id"},{"line_number":58,"context_line":"        if availability_zone:"},{"line_number":59,"context_line":"            values[\u0027availability_zone\u0027] \u003d availability_zone"},{"line_number":60,"context_line":"        if metadata:"},{"line_number":61,"context_line":"            values[\u0027metadata\u0027] \u003d metadata"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        body \u003d {\u0027share-network-subnet\u0027: values}"},{"line_number":64,"context_line":"        url \u003d \u0027/share-networks/%(share_network_id)s/subnets\u0027 % {"},{"line_number":65,"context_line":"            \u0027share_network_id\u0027: share_network_id"},{"line_number":66,"context_line":"        }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return self._create(url, body, RESOURCE_NAME)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get(self, share_network, share_network_subnet):"},{"line_number":71,"context_line":"        \"\"\"Get a share network subnet."}],"source_content_type":"text/x-python","patch_set":2,"id":"bc06bd30_94b296c6","line":68,"range":{"start_line":43,"start_character":0,"end_line":68,"end_character":53},"in_reply_to":"6b9db223_390f1611","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    resource_path \u003d \u0027/share-networks\u0027"},{"line_number":41,"context_line":"    subresource_path \u003d \u0027/subnets\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def create(self, neutron_net_id\u003dNone, neutron_subnet_id\u003dNone,"},{"line_number":44,"context_line":"               availability_zone\u003dNone, share_network_id\u003dNone, metadata\u003dNone):"},{"line_number":45,"context_line":"        \"\"\"Create share network subnet."},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        :param neutron_net_id: ID of Neutron network"},{"line_number":48,"context_line":"        :param neutron_subnet_id: ID of Neutron subnet"},{"line_number":49,"context_line":"        :param availability_zone: Name of the target availability zone"},{"line_number":50,"context_line":"        :param metadata: dict - optional metadata to set on share creation"},{"line_number":51,"context_line":"        :rtype: :class:`ShareNetworkSubnet`"},{"line_number":52,"context_line":"        \"\"\""},{"line_number":53,"context_line":"        values \u003d {}"},{"line_number":54,"context_line":"        if neutron_net_id:"},{"line_number":55,"context_line":"            values[\u0027neutron_net_id\u0027] \u003d neutron_net_id"},{"line_number":56,"context_line":"        if neutron_subnet_id:"},{"line_number":57,"context_line":"            values[\u0027neutron_subnet_id\u0027] \u003d neutron_subnet_id"},{"line_number":58,"context_line":"        if availability_zone:"},{"line_number":59,"context_line":"            values[\u0027availability_zone\u0027] \u003d availability_zone"},{"line_number":60,"context_line":"        if metadata:"},{"line_number":61,"context_line":"            values[\u0027metadata\u0027] \u003d metadata"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        body \u003d {\u0027share-network-subnet\u0027: values}"},{"line_number":64,"context_line":"        url \u003d \u0027/share-networks/%(share_network_id)s/subnets\u0027 % {"},{"line_number":65,"context_line":"            \u0027share_network_id\u0027: share_network_id"},{"line_number":66,"context_line":"        }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        return self._create(url, body, RESOURCE_NAME)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def get(self, share_network, share_network_subnet):"},{"line_number":71,"context_line":"        \"\"\"Get a share network subnet."}],"source_content_type":"text/x-python","patch_set":2,"id":"a06b779e_1ab853fa","line":68,"range":{"start_line":43,"start_character":0,"end_line":68,"end_character":53},"in_reply_to":"bc06bd30_94b296c6","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe8e9bc00075ba3b87c8c7787791e00698997cec","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f61cbb5a_55374941","line":97,"updated":"2023-03-11 00:11:05.000000000","message":"We\u0027ll need to add the version decorator on the metadata methods being implemented in the base class\n\n\n @api_versions.wraps(\u00272.78\u0027)\n def get_metadata(self, share_network, share_network_subnet):\n        return super(ShareNetworkSubnetManager, self).get_metadata(\n              share_network, subresource\u003dshare_network_subnet)\n  ...","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"84a9613c_26ff9845","line":97,"in_reply_to":"1f302042_b5c871ae","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f302042_b5c871ae","line":97,"in_reply_to":"f61cbb5a_55374941","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"44ec60c21e34a3b2a9dc9ea30899cf0d3baf191b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e8f6008b_8518c802","line":116,"updated":"2023-05-12 18:02:34.000000000","message":"You must redefine all the metadata methods.. not just \"get_metadata\"","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"212852702e794d359835d61d4d50bc0dbc449c8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"634a833a_3afe08f1","line":116,"in_reply_to":"88687e60_1e24b961","updated":"2023-07-07 22:48:43.000000000","message":".","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"88687e60_1e24b961","line":116,"in_reply_to":"e8f6008b_8518c802","updated":"2023-07-07 19:27:13.000000000","message":"done","commit_id":"afe7fa9c62bd71d7f4d87fe2961744ff53182d4c"}],"manilaclient/v2/shell.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c564c1feaec1b6b3a10866d9a7a335e1a96c87a2","unresolved":true,"context_lines":[{"line_number":4015,"context_line":"    help\u003d\u0027Optional availability zone that the subnet is available within \u0027"},{"line_number":4016,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered as being \u0027"},{"line_number":4017,"context_line":"         \u0027available across all availability zones.\u0027)"},{"line_number":4018,"context_line":"@cliutils.arg("},{"line_number":4019,"context_line":"    \u0027--metadata\u0027,"},{"line_number":4020,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":4021,"context_line":"    type\u003dstr,"},{"line_number":4022,"context_line":"    default\u003dNone,"},{"line_number":4023,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":4024,"context_line":"    help\u003d\u0027Metadata key\u003dvalue pairs (Optional, Default\u003dNone). \u0027"},{"line_number":4025,"context_line":"         \u0027Only available microversion \u003e\u003d 2.74.\u0027,)"},{"line_number":4026,"context_line":"def do_share_network_subnet_create(cs, args):"},{"line_number":4027,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":4028,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":4029,"context_line":"        raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":1,"id":"b36a597c_bb1f0fd5","line":4026,"range":{"start_line":4018,"start_character":0,"end_line":4026,"end_character":45},"updated":"2023-02-08 22:05:44.000000000","message":"Thanks for adding this. The requirement was only for OSC though - do you intend to add the set/unset of metadata as well?\n\nI think it\u0027s okay if we want to add this, but having the metadata only on create and not allowing users to set/unset metadata could cause confusion. Imagine someone is using manila CLI and realizes they can create share network subnets with metadata, and try to do the other operations? They would need to go to OSC, which can cause a bit of a confusion. I\u0027m okay not adding this to the native client, but if we are adding, I believe the best choice is to have set/unset here too.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"a811e6260720b80d32a88300af4160de77af74e4","unresolved":false,"context_lines":[{"line_number":4015,"context_line":"    help\u003d\u0027Optional availability zone that the subnet is available within \u0027"},{"line_number":4016,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered as being \u0027"},{"line_number":4017,"context_line":"         \u0027available across all availability zones.\u0027)"},{"line_number":4018,"context_line":"@cliutils.arg("},{"line_number":4019,"context_line":"    \u0027--metadata\u0027,"},{"line_number":4020,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":4021,"context_line":"    type\u003dstr,"},{"line_number":4022,"context_line":"    default\u003dNone,"},{"line_number":4023,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":4024,"context_line":"    help\u003d\u0027Metadata key\u003dvalue pairs (Optional, Default\u003dNone). \u0027"},{"line_number":4025,"context_line":"         \u0027Only available microversion \u003e\u003d 2.74.\u0027,)"},{"line_number":4026,"context_line":"def do_share_network_subnet_create(cs, args):"},{"line_number":4027,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":4028,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":4029,"context_line":"        raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":1,"id":"e3c3c758_3bb4b8ba","line":4026,"range":{"start_line":4018,"start_character":0,"end_line":4026,"end_character":45},"in_reply_to":"91596fe1_555780d3","updated":"2023-03-08 23:18:41.000000000","message":"Done","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"971fd8c477df6eb174d9fd584e348861cc2107f7","unresolved":true,"context_lines":[{"line_number":4015,"context_line":"    help\u003d\u0027Optional availability zone that the subnet is available within \u0027"},{"line_number":4016,"context_line":"         \u0027(Default\u003dNone). If None, the subnet will be considered as being \u0027"},{"line_number":4017,"context_line":"         \u0027available across all availability zones.\u0027)"},{"line_number":4018,"context_line":"@cliutils.arg("},{"line_number":4019,"context_line":"    \u0027--metadata\u0027,"},{"line_number":4020,"context_line":"    metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":4021,"context_line":"    type\u003dstr,"},{"line_number":4022,"context_line":"    default\u003dNone,"},{"line_number":4023,"context_line":"    nargs\u003d\u0027*\u0027,"},{"line_number":4024,"context_line":"    help\u003d\u0027Metadata key\u003dvalue pairs (Optional, Default\u003dNone). \u0027"},{"line_number":4025,"context_line":"         \u0027Only available microversion \u003e\u003d 2.74.\u0027,)"},{"line_number":4026,"context_line":"def do_share_network_subnet_create(cs, args):"},{"line_number":4027,"context_line":"    \"\"\"Add a new subnet into a share network.\"\"\""},{"line_number":4028,"context_line":"    if xor(bool(args.neutron_net_id), bool(args.neutron_subnet_id)):"},{"line_number":4029,"context_line":"        raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":1,"id":"91596fe1_555780d3","line":4026,"range":{"start_line":4018,"start_character":0,"end_line":4026,"end_character":45},"in_reply_to":"b36a597c_bb1f0fd5","updated":"2023-03-08 23:04:41.000000000","message":"Nice. Removing this support.","commit_id":"7be34e31a5e77a8fa4943d70ef7ad95b44c7934f"}],"releasenotes/notes/add_subnet_metadata-82426986431b0179.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b8317809_7759450a","updated":"2023-03-11 00:05:53.000000000","message":"nit: use hyphens in the file name ..","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f3fdb4e3_6246ac14","in_reply_to":"b8317809_7759450a","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e36632e2_558fddbe","in_reply_to":"f3fdb4e3_6246ac14","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"afe2f83f6fcc4b3acedd0fdc6b7e3a5196d4c057","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to create share network subnet with properties and update"},{"line_number":5,"context_line":"    the subnet properties with set and unset command (only in OSC)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"f4aa26ca_7c8060ed","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":65},"updated":"2023-03-11 00:05:53.000000000","message":"with the OpenStackClient","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"e648805da88f845fa27788a1016d01246e968f02","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to create share network subnet with properties and update"},{"line_number":5,"context_line":"    the subnet properties with set and unset command (only in OSC)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"d00ca591_a571cf25","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":65},"in_reply_to":"9722ce9f_b00914b6","updated":"2023-07-07 19:27:13.000000000","message":"Done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"5536e2078a07e5071db2a803dc89debb984e58c5","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support to create share network subnet with properties and update"},{"line_number":5,"context_line":"    the subnet properties with set and unset command (only in OSC)."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9722ce9f_b00914b6","line":5,"range":{"start_line":5,"start_character":59,"end_line":5,"end_character":65},"in_reply_to":"f4aa26ca_7c8060ed","updated":"2023-05-09 01:50:06.000000000","message":"done","commit_id":"4aa858e8bc9a66d2b94ddc681649a64b16209d0b"}]}