)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"50b330be19b9232d24c188d9b146286d8ea1a67c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"aa3d849e_ff19c0d5","updated":"2023-02-16 12:55:54.000000000","message":"LGTM, thanks for the enhancements!","commit_id":"a0f6a2e92096c4242d8737350a0824c7b1106236"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8685107320cffd707a8733d1f50c3375c6092af8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0f9c625d_a7f58368","updated":"2023-02-16 15:41:57.000000000","message":"LGTM; please address the doc string fix in a follow up patch","commit_id":"a0f6a2e92096c4242d8737350a0824c7b1106236"}],"manilaclient/api_versions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"676c739ad76271d46892bde68f6cf49e94ee550e","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.73\u0027"},{"line_number":31,"context_line":"MAX_VERSION \u003d \u00272.75\u0027"},{"line_number":32,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":33,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"549f04d5_88fd3f87","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":20},"updated":"2023-02-15 21:08:20.000000000","message":"edit this instead, don\u0027t redefine..","commit_id":"79c4034f021bf445aa9ea4867cacdbde5671581e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ed1bfa4c8f52ba42c1cf4046f2959d2ae014036b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"MAX_VERSION \u003d \u00272.73\u0027"},{"line_number":31,"context_line":"MAX_VERSION \u003d \u00272.75\u0027"},{"line_number":32,"context_line":"MIN_VERSION \u003d \u00272.0\u0027"},{"line_number":33,"context_line":"DEPRECATED_VERSION \u003d \u00271.0\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b542bf7_cfa56bf2","line":30,"range":{"start_line":30,"start_character":14,"end_line":30,"end_character":20},"in_reply_to":"549f04d5_88fd3f87","updated":"2023-02-16 08:46:24.000000000","message":"Done, silly mistake, might be during rebase","commit_id":"79c4034f021bf445aa9ea4867cacdbde5671581e"}],"manilaclient/osc/v2/share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"676c739ad76271d46892bde68f6cf49e94ee550e","unresolved":true,"context_lines":[{"line_number":365,"context_line":"            share_client.share_replicas,"},{"line_number":366,"context_line":"            parsed_args.replica)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        quiesce_wait_time \u003d None"},{"line_number":369,"context_line":"        if parsed_args.quiesce_wait_time:"},{"line_number":370,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.75\"):"},{"line_number":371,"context_line":"                raise exceptions.CommandError("},{"line_number":372,"context_line":"                    \"\u0027quiesce-wait-time\u0027 option is available only starting \""},{"line_number":373,"context_line":"                    \"with \u00272.75\u0027 API microversion.\")"},{"line_number":374,"context_line":"            quiesce_wait_time \u003d parsed_args.quiesce_wait_time"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        try:"},{"line_number":377,"context_line":"            share_client.share_replicas.promote(replica, quiesce_wait_time)"},{"line_number":378,"context_line":"        except Exception as e:"},{"line_number":379,"context_line":"            raise exceptions.CommandError(_("},{"line_number":380,"context_line":"                \"Failed to promote replica to \u0027active\u0027: %s\" % (e)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"dd03ee6f_9fbc0151","line":377,"range":{"start_line":368,"start_character":0,"end_line":377,"end_character":75},"updated":"2023-02-15 21:08:20.000000000","message":"This will break when using an older microversion: \n\n$ OS_SHARE_API_VERSION\u003d2.63 openstack share replica promote 60aef210-f810-4880-8a7d-d7896ddaa3e5\nFailed to promote replica to \u0027active\u0027: promote() takes 2 positional arguments but 3 were given\n\n\n\nYou need to send \"quiesce_wait_time\" only if necessary\n\n args \u003d [\n    replica,\n ]\n if parsed_args.quiesce_wait_time:\n    ...\n    args +\u003d [parsed_args.quiesce_wait_time]\n try:\n    share_client.share_replicas.promote(*args)\n    ...","commit_id":"79c4034f021bf445aa9ea4867cacdbde5671581e"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"ed1bfa4c8f52ba42c1cf4046f2959d2ae014036b","unresolved":false,"context_lines":[{"line_number":365,"context_line":"            share_client.share_replicas,"},{"line_number":366,"context_line":"            parsed_args.replica)"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"        quiesce_wait_time \u003d None"},{"line_number":369,"context_line":"        if parsed_args.quiesce_wait_time:"},{"line_number":370,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\"2.75\"):"},{"line_number":371,"context_line":"                raise exceptions.CommandError("},{"line_number":372,"context_line":"                    \"\u0027quiesce-wait-time\u0027 option is available only starting \""},{"line_number":373,"context_line":"                    \"with \u00272.75\u0027 API microversion.\")"},{"line_number":374,"context_line":"            quiesce_wait_time \u003d parsed_args.quiesce_wait_time"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        try:"},{"line_number":377,"context_line":"            share_client.share_replicas.promote(replica, quiesce_wait_time)"},{"line_number":378,"context_line":"        except Exception as e:"},{"line_number":379,"context_line":"            raise exceptions.CommandError(_("},{"line_number":380,"context_line":"                \"Failed to promote replica to \u0027active\u0027: %s\" % (e)))"}],"source_content_type":"text/x-python","patch_set":2,"id":"f23ea0af_0d9d9a73","line":377,"range":{"start_line":368,"start_character":0,"end_line":377,"end_character":75},"in_reply_to":"dd03ee6f_9fbc0151","updated":"2023-02-16 08:46:24.000000000","message":"Done","commit_id":"79c4034f021bf445aa9ea4867cacdbde5671581e"}],"manilaclient/v2/share_replicas.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"462662a7e1aaf477e788dacb9f7aae5f18dfd610","unresolved":true,"context_lines":[{"line_number":110,"context_line":"        return self._action(\u0027promote\u0027, replica)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @api_versions.wraps(\u00272.75\u0027)  # noqa"},{"line_number":113,"context_line":"    def promote(self, replica, quiesce_wait_time):  # noqa F811"},{"line_number":114,"context_line":"        \"\"\"Promote the provided replica."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :param replica: either replica object or its UUID."}],"source_content_type":"text/x-python","patch_set":1,"id":"29f04205_98b6af04","line":113,"range":{"start_line":113,"start_character":31,"end_line":113,"end_character":48},"updated":"2023-02-08 21:59:22.000000000","message":"make this optional please; if clients don\u0027t need to specify one, this can be ignored","commit_id":"46722f7ee4366d19b653ec9bf146355985fd3f7a"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b18891861a8d32b8b1d086c8634d179291d38e3b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        return self._action(\u0027promote\u0027, replica)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @api_versions.wraps(\u00272.75\u0027)  # noqa"},{"line_number":113,"context_line":"    def promote(self, replica, quiesce_wait_time):  # noqa F811"},{"line_number":114,"context_line":"        \"\"\"Promote the provided replica."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :param replica: either replica object or its UUID."}],"source_content_type":"text/x-python","patch_set":1,"id":"567a11bc_4ef73fa9","line":113,"range":{"start_line":113,"start_character":31,"end_line":113,"end_character":48},"in_reply_to":"29f04205_98b6af04","updated":"2023-02-09 08:59:41.000000000","message":"Done","commit_id":"46722f7ee4366d19b653ec9bf146355985fd3f7a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8685107320cffd707a8733d1f50c3375c6092af8","unresolved":true,"context_lines":[{"line_number":114,"context_line":"        \"\"\"Promote the provided replica."},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        :param replica: either replica object or its UUID."},{"line_number":117,"context_line":"        :param body: either replica object or its UUID."},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        body \u003d None"},{"line_number":120,"context_line":"        if quiesce_wait_time:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fb65d526_b866bd00","line":117,"range":{"start_line":117,"start_character":15,"end_line":117,"end_character":55},"updated":"2023-02-16 15:41:57.000000000","message":"you mean quiesce_wait_time here..","commit_id":"a0f6a2e92096c4242d8737350a0824c7b1106236"}]}