)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"66c0bdb97594895a7011b85771835152a098dd71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"15041aad_0a2e5c16","updated":"2023-07-06 14:52:34.000000000","message":"recheck old logs","commit_id":"a5ad06bdc0ccaf0c812d8629ad332d3bcb502f31"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"64bb589ce6d7e80ec903e04e91bfd731b7cc48cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75d39ef7_5664ff48","updated":"2023-07-06 16:21:55.000000000","message":"tox-docs gives this error:\n\nWarning, treated as error:\n/home/zuul/src/opendev.org/openstack/python-manilaclient/doc/source/cli/decoder.rst:13:Unexpected section title or transition.\n\nthere is no 13th line, it\u0027s throwing me for a loop :/","commit_id":"a5ad06bdc0ccaf0c812d8629ad332d3bcb502f31"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0d58f9f6c3c1d16ba173c66b34b2436b55dd5c2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2ad714a3_f787d4cb","updated":"2023-08-23 22:05:13.000000000","message":"Hi Goutham! Thank you for working on this\nPretty cool stuff and I like the command suggestion, it\u0027s a pretty clever implementation. I was running some test scenarios and found some cases where it didn\u0027t work. Could you please take a look?","commit_id":"ffe47314dfd8f8c4b803011e92aa4b0667bbf253"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bfa13da50d58abbe8e601914fe6265f75d6da087","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"301e4ed5_50e301c3","updated":"2023-08-17 19:15:31.000000000","message":"recheck\n\nCI has been fixed","commit_id":"ffe47314dfd8f8c4b803011e92aa4b0667bbf253"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"082bc372377184589f401a3badfa5c121d20cc0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6595176d_47b21ded","updated":"2023-08-31 11:05:50.000000000","message":"Hello, Haixin! Thanks for looking into this change.\nI\u0027ve looked at your comment and I agree with you, and I don\u0027t think it would be a big blocker now, but I agree with your point that it can be enhanced.\nThe client release *must* be shipped today. Goutham is on PTO, and I could submit the updates but we\u0027d lose my vote on this change. Are you okay if we merge this and fix the comment in a follow-up?","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"2978447011d80bdcc5d5e8a6cc98483058f0a305","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cb844163_1822e101","updated":"2023-08-23 22:13:00.000000000","message":"LGTM Goutham, works just fine now. Thank you for the changes!\nI\u0027ll wait for the CI before my +2 :D","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"0c65f049b11b679e8412ef25c0b534be1e81c333","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"246868e8_9234308d","updated":"2023-08-30 19:53:37.000000000","message":"LGTM, thanks for submiting this patch.","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77193daed224670e72bede1ed15c651b5576cb2a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7f521b6e_2c1baa7c","updated":"2023-09-12 00:12:22.000000000","message":"Thanks for the comments Haixin; i\u0027ve added share transfer commands in https://review.opendev.org/c/openstack/python-manilaclient/+/894606\n\nWe\u0027ve shipped the client for bobcat/2023.1 now; but, we\u0027ll backport this fix to the release once it merges and publish a minor release","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"00adcef6d72a7db855a4fa2051ac2bf268d254d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45786534_81bd6ec4","updated":"2023-08-31 15:04:32.000000000","message":"let us merge this change.","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f3eebee6961b82d207086565bedfec2b7358539d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3b093c98_7305d32e","updated":"2023-08-31 03:23:15.000000000","message":"thanks for your change, just one suggestion.","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"00adcef6d72a7db855a4fa2051ac2bf268d254d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2dd0348f_e2c6c4ab","in_reply_to":"6595176d_47b21ded","updated":"2023-08-31 15:04:32.000000000","message":"sure, let us merge this.","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"}],"manilaclient/osc/v2/data/manila.csv":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"0d58f9f6c3c1d16ba173c66b34b2436b55dd5c2c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"manila command,openstack command,command description"},{"line_number":2,"context_line":"--version,module list,List the client software version"},{"line_number":3,"context_line":"absolute-limits,share limits show --absolute,Print a list of absolute limits for a user"},{"line_number":4,"context_line":"access-allow,share access create,Allow access to a given share"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"75fafbb8_348c4cce","line":1,"updated":"2023-08-23 22:05:13.000000000","message":"this is working with share list but it\u0027s not working with some other operations\nPlease take a look: \nhttps://paste.opendev.org/show/bKdoh6nGrYlPileTI0o9/\n\nMy guess is that when commands have a hyphen, they won\u0027t work, see other commands without a hyphen:\nhttps://paste.opendev.org/show/b3k3xx75BDZhg8JZZ6pD/","commit_id":"ffe47314dfd8f8c4b803011e92aa4b0667bbf253"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77193daed224670e72bede1ed15c651b5576cb2a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"manila command,openstack command,command description"},{"line_number":2,"context_line":"--version,module list,List the client software version"},{"line_number":3,"context_line":"absolute-limits,share limits show --absolute,Print a list of absolute limits for a user"},{"line_number":4,"context_line":"access-allow,share access create,Allow access to a given share"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"4ed10485_29ce9f3d","line":1,"in_reply_to":"16879d2b_6d94ac70","updated":"2023-09-12 00:12:22.000000000","message":"Done","commit_id":"ffe47314dfd8f8c4b803011e92aa4b0667bbf253"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8d3ecdfeed1003f190128a8ddb6f013f3c73d6c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"manila command,openstack command,command description"},{"line_number":2,"context_line":"--version,module list,List the client software version"},{"line_number":3,"context_line":"absolute-limits,share limits show --absolute,Print a list of absolute limits for a user"},{"line_number":4,"context_line":"access-allow,share access create,Allow access to a given share"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"16879d2b_6d94ac70","line":1,"in_reply_to":"75fafbb8_348c4cce","updated":"2023-08-23 22:10:31.000000000","message":"ack; good find. I missed this translation. should be fixed now","commit_id":"ffe47314dfd8f8c4b803011e92aa4b0667bbf253"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6532838d3e2c2a742bd26b1cc6edfbdd129934aa","unresolved":true,"context_lines":[{"line_number":100,"context_line":"share-replica-promote,share replica promote,Promote specified replica to \u0027active\u0027 replica_state"},{"line_number":101,"context_line":"share-replica-reset-replica-state,share replica set --replica-state,Explicitly update the \u0027replica_state\u0027 of a share replica"},{"line_number":102,"context_line":"share-replica-reset-state,share replica set --status,Explicitly update the \u0027status\u0027 of a share replica"},{"line_number":103,"context_line":"share-replica-resync,share replica resync,Attempt to update the share replica with its \u0027active\u0027 mirror"},{"line_number":104,"context_line":"share-replica-show,share replica show,Show details about a replica"},{"line_number":105,"context_line":"share-server-delete,share server delete,Delete one or more share servers"},{"line_number":106,"context_line":"share-server-details,share server show,Show share server details"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"d2a18c14_d8c621fb","line":103,"updated":"2023-08-31 15:50:27.000000000","message":"maybe miss share-transfer-xxx","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77193daed224670e72bede1ed15c651b5576cb2a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"share-replica-promote,share replica promote,Promote specified replica to \u0027active\u0027 replica_state"},{"line_number":101,"context_line":"share-replica-reset-replica-state,share replica set --replica-state,Explicitly update the \u0027replica_state\u0027 of a share replica"},{"line_number":102,"context_line":"share-replica-reset-state,share replica set --status,Explicitly update the \u0027status\u0027 of a share replica"},{"line_number":103,"context_line":"share-replica-resync,share replica resync,Attempt to update the share replica with its \u0027active\u0027 mirror"},{"line_number":104,"context_line":"share-replica-show,share replica show,Show details about a replica"},{"line_number":105,"context_line":"share-server-delete,share server delete,Delete one or more share servers"},{"line_number":106,"context_line":"share-server-details,share server show,Show share server details"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"81a59d98_e972462f","line":103,"in_reply_to":"d2a18c14_d8c621fb","updated":"2023-09-12 00:12:22.000000000","message":"++\nshare transfer CLI hadn\u0027t merged when i generated this list; thank you!","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"}],"manilaclient/shell.py":[{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"f3eebee6961b82d207086565bedfec2b7358539d","unresolved":true,"context_lines":[{"line_number":610,"context_line":"            osprofiler_profiler.init(options.profile)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        try:"},{"line_number":613,"context_line":"            decoder_path \u003d os.path.abspath("},{"line_number":614,"context_line":"                \u0027manilaclient/osc/v2/data/manila.csv\u0027"},{"line_number":615,"context_line":"            )"},{"line_number":616,"context_line":"            with open(decoder_path) as f:"},{"line_number":617,"context_line":"                decoder_data \u003d {"},{"line_number":618,"context_line":"                    r[\u0027manila command\u0027]: r[\u0027openstack command\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"56951350_cc2279db","line":615,"range":{"start_line":613,"start_character":12,"end_line":615,"end_character":13},"updated":"2023-08-31 03:23:15.000000000","message":"i found if decoder_data is {}, client will not print The equivalent command is \n\"openstack share xxxxx\" to tell user how to use OSC. i think better to print this aways.\n\nwe can add new function:\n\n    @staticmethod\n    def get_package_installation_site(package_name):\n        package_path \u003d site.getsitepackages()\n        for path in package_path:\n            try:\n                if package_name in os.listdir(path):\n                    return path\n            except:\n                return \u0027\u0027\n                \n                \nthen change decoder_path here:\n\n    ins_path \u003d self.get_package_installation_site(\u0027manilaclient\u0027)\n    path \u003d ins_path + \u0027/\u0027 if ins_path else ins_path\n    manila_csv_path \u003d path + \u0027manilaclient/osc/v2/data/manila.csv\u0027\n    decoder_path \u003d os.path.abspath(manila_csv_path)","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"77193daed224670e72bede1ed15c651b5576cb2a","unresolved":true,"context_lines":[{"line_number":610,"context_line":"            osprofiler_profiler.init(options.profile)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        try:"},{"line_number":613,"context_line":"            decoder_path \u003d os.path.abspath("},{"line_number":614,"context_line":"                \u0027manilaclient/osc/v2/data/manila.csv\u0027"},{"line_number":615,"context_line":"            )"},{"line_number":616,"context_line":"            with open(decoder_path) as f:"},{"line_number":617,"context_line":"                decoder_data \u003d {"},{"line_number":618,"context_line":"                    r[\u0027manila command\u0027]: r[\u0027openstack command\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f7c4fdf_9b1ac8b1","line":615,"range":{"start_line":613,"start_character":12,"end_line":615,"end_character":13},"in_reply_to":"2eea33e9_cf93e88b","updated":"2023-09-12 00:12:22.000000000","message":"Hmmm, this worked fine for me; any reason to think this will not work on an installation? \n\nanother way to construct this patch could be:\n\n```\ndecoder_path \u003d \u0027%s/%s\u0027 % (\n     os.path.dirname(manilaclient.__file__), \n     \u0027osc/v2/data/manila.csv\u0027\n)\n```","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"082bc372377184589f401a3badfa5c121d20cc0b","unresolved":true,"context_lines":[{"line_number":610,"context_line":"            osprofiler_profiler.init(options.profile)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        try:"},{"line_number":613,"context_line":"            decoder_path \u003d os.path.abspath("},{"line_number":614,"context_line":"                \u0027manilaclient/osc/v2/data/manila.csv\u0027"},{"line_number":615,"context_line":"            )"},{"line_number":616,"context_line":"            with open(decoder_path) as f:"},{"line_number":617,"context_line":"                decoder_data \u003d {"},{"line_number":618,"context_line":"                    r[\u0027manila command\u0027]: r[\u0027openstack command\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"2eea33e9_cf93e88b","line":615,"range":{"start_line":613,"start_character":12,"end_line":615,"end_character":13},"in_reply_to":"56951350_cc2279db","updated":"2023-08-31 11:05:50.000000000","message":"Hi, haixin! Thanks for looking into this. I believe that decoder_data will only be empty in case it fails to get the absolute path and read the data from the file, which as of now in a regular installation, should work fine. I agree with you that we can enhance this though.","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"62f2182d0d3523efb2ef2bb50e726b211a15c8b3","unresolved":false,"context_lines":[{"line_number":610,"context_line":"            osprofiler_profiler.init(options.profile)"},{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        try:"},{"line_number":613,"context_line":"            decoder_path \u003d os.path.abspath("},{"line_number":614,"context_line":"                \u0027manilaclient/osc/v2/data/manila.csv\u0027"},{"line_number":615,"context_line":"            )"},{"line_number":616,"context_line":"            with open(decoder_path) as f:"},{"line_number":617,"context_line":"                decoder_data \u003d {"},{"line_number":618,"context_line":"                    r[\u0027manila command\u0027]: r[\u0027openstack command\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"4feed29e_d994e7c0","line":615,"range":{"start_line":613,"start_character":12,"end_line":615,"end_character":13},"in_reply_to":"7f7c4fdf_9b1ac8b1","updated":"2023-09-12 01:21:29.000000000","message":"yes, this also work fine, and it looks more clear.\nwe can add this to https://review.opendev.org/c/openstack/python-manilaclient/+/894606","commit_id":"ba9a3887869ecd4cbed4aeb43c11a3d9493fafa2"}]}