)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e9cdc2e8a3fed5f28a06eb8108e9de3485976886","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"0b751caa_8407b104","updated":"2023-08-04 19:34:43.000000000","message":"Hey, Goutham! Was testing this change + creating locks for access rules, and found an issue. Please take a look at the comment inline :)","commit_id":"b8740d533ce0f8d7429d9899d0a9e67a82137ff0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b4814f67c5bf68a3e565f35696ff09d9f7a78b9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6fa67b47_7c4e22b5","updated":"2023-08-21 21:17:10.000000000","message":"Gave it another try, and works like a charm. Code looks good, and great testing coverage.\nThank you!","commit_id":"187279380b719b0d99f49d02e587320a81d9d266"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8075cb10cd88f0bcea81e2ae6e07cc3ff6c5459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7e590bcb_ef8492ca","updated":"2023-08-21 15:08:59.000000000","message":"Thanks Carlos; fixed in the latest PS","commit_id":"187279380b719b0d99f49d02e587320a81d9d266"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"30f105100bba062357ee13cc82fcceb53f339900","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5531d645_548ef62a","updated":"2023-08-24 16:07:01.000000000","message":"Code looks good, just one question inline. Thanks!","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1170aab3f4f5e62a1d731a6f8dc057a9f56bfd96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2da8c490_57e07850","updated":"2023-08-24 11:11:32.000000000","message":"LGTM, thanks!","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b15738c700e89d4817f5380cd54b47aa12a3e1ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9cce9e5e_9eecc035","updated":"2023-08-24 20:00:07.000000000","message":"Thanks Goutham!","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2614e9794f3839139a0b540cd2b5ef2d4a15068e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0a20f88b_21f66135","updated":"2023-08-23 23:26:30.000000000","message":"rebased to resolve a merge conflict","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"}],"manilaclient/osc/v2/resource_locks.py":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e9cdc2e8a3fed5f28a06eb8108e9de3485976886","unresolved":true,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        resource_id \u003d parsed_args.resource"},{"line_number":281,"context_line":"        resource_type \u003d parsed_args.resource_type"},{"line_number":282,"context_line":"        if resource_type is not None:"},{"line_number":283,"context_line":"            if resource_type not in RESOURCE_TYPE_MANAGERS:"},{"line_number":284,"context_line":"                raise exceptions.CommandError(_(\"Unsupported resource type\"))"},{"line_number":285,"context_line":"            res_manager \u003d RESOURCE_TYPE_MANAGERS[resource_type]"},{"line_number":286,"context_line":"            resource_id \u003d osc_utils.find_resource("},{"line_number":287,"context_line":"                getattr(share_client, res_manager),"},{"line_number":288,"context_line":"                parsed_args.resource"},{"line_number":289,"context_line":"            ).id"},{"line_number":290,"context_line":"        elif resource_id and not uuidutils.is_uuid_like(resource_id):"},{"line_number":291,"context_line":"            raise exceptions.CommandError("},{"line_number":292,"context_line":"                _(\"Provide resource ID or specify --resource-type.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"ec151f61_7242fadd","line":289,"range":{"start_line":282,"start_character":8,"end_line":289,"end_character":16},"updated":"2023-08-04 19:34:43.000000000","message":"in the way it is currently implemented, if we specify a resource type but don\u0027t specify a resource_id, it fails, because it assumes the resource id is there, when it is not a required parameter.\n\n[1] https://paste.opendev.org/show/bmMEuzPWeRhwLSqyVvAK/\n\nWhat I did in this case:\n- Created an access rule with restrictions\n- ran the command: `openstack share lock list --resource-type access_rule`\n\nand then the exception above was raised","commit_id":"b8740d533ce0f8d7429d9899d0a9e67a82137ff0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a8075cb10cd88f0bcea81e2ae6e07cc3ff6c5459","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"        resource_id \u003d parsed_args.resource"},{"line_number":281,"context_line":"        resource_type \u003d parsed_args.resource_type"},{"line_number":282,"context_line":"        if resource_type is not None:"},{"line_number":283,"context_line":"            if resource_type not in RESOURCE_TYPE_MANAGERS:"},{"line_number":284,"context_line":"                raise exceptions.CommandError(_(\"Unsupported resource type\"))"},{"line_number":285,"context_line":"            res_manager \u003d RESOURCE_TYPE_MANAGERS[resource_type]"},{"line_number":286,"context_line":"            resource_id \u003d osc_utils.find_resource("},{"line_number":287,"context_line":"                getattr(share_client, res_manager),"},{"line_number":288,"context_line":"                parsed_args.resource"},{"line_number":289,"context_line":"            ).id"},{"line_number":290,"context_line":"        elif resource_id and not uuidutils.is_uuid_like(resource_id):"},{"line_number":291,"context_line":"            raise exceptions.CommandError("},{"line_number":292,"context_line":"                _(\"Provide resource ID or specify --resource-type.\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"d27a6257_2676a49d","line":289,"range":{"start_line":282,"start_character":8,"end_line":289,"end_character":16},"in_reply_to":"ec151f61_7242fadd","updated":"2023-08-21 15:08:59.000000000","message":"Done","commit_id":"b8740d533ce0f8d7429d9899d0a9e67a82137ff0"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"30f105100bba062357ee13cc82fcceb53f339900","unresolved":true,"context_lines":[{"line_number":374,"context_line":"            update_kwargs[\u0027resource_action\u0027] \u003d parsed_args.resource_action"},{"line_number":375,"context_line":"        if parsed_args.lock_reason is not None:"},{"line_number":376,"context_line":"            update_kwargs[\u0027lock_reason\u0027] \u003d parsed_args.lock_reason"},{"line_number":377,"context_line":"        if update_kwargs:"},{"line_number":378,"context_line":"            share_client.resource_locks.update("},{"line_number":379,"context_line":"                parsed_args.lock,"},{"line_number":380,"context_line":"                **update_kwargs"}],"source_content_type":"text/x-python","patch_set":9,"id":"bbd34c26_5bf6f51c","line":377,"range":{"start_line":377,"start_character":0,"end_line":377,"end_character":25},"updated":"2023-08-24 16:07:01.000000000","message":"if no resource_action or lock_reason is provided, is there any feedback to the user?","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"0df98e987824715268c83d90e50208669f96643a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            update_kwargs[\u0027resource_action\u0027] \u003d parsed_args.resource_action"},{"line_number":375,"context_line":"        if parsed_args.lock_reason is not None:"},{"line_number":376,"context_line":"            update_kwargs[\u0027lock_reason\u0027] \u003d parsed_args.lock_reason"},{"line_number":377,"context_line":"        if update_kwargs:"},{"line_number":378,"context_line":"            share_client.resource_locks.update("},{"line_number":379,"context_line":"                parsed_args.lock,"},{"line_number":380,"context_line":"                **update_kwargs"}],"source_content_type":"text/x-python","patch_set":9,"id":"8e81480c_d669f41a","line":377,"range":{"start_line":377,"start_character":0,"end_line":377,"end_character":25},"in_reply_to":"4d53d948_8eebc166","updated":"2023-08-24 20:33:57.000000000","message":"Great, thanks!","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":30002,"name":"Douglas Viroel","email":"viroel@gmail.com","username":"dviroel"},"change_message_id":"b15738c700e89d4817f5380cd54b47aa12a3e1ae","unresolved":true,"context_lines":[{"line_number":374,"context_line":"            update_kwargs[\u0027resource_action\u0027] \u003d parsed_args.resource_action"},{"line_number":375,"context_line":"        if parsed_args.lock_reason is not None:"},{"line_number":376,"context_line":"            update_kwargs[\u0027lock_reason\u0027] \u003d parsed_args.lock_reason"},{"line_number":377,"context_line":"        if update_kwargs:"},{"line_number":378,"context_line":"            share_client.resource_locks.update("},{"line_number":379,"context_line":"                parsed_args.lock,"},{"line_number":380,"context_line":"                **update_kwargs"}],"source_content_type":"text/x-python","patch_set":9,"id":"e0237dc4_5f6c9302","line":377,"range":{"start_line":377,"start_character":0,"end_line":377,"end_character":25},"in_reply_to":"7a463b95_979a83f9","updated":"2023-08-24 20:00:07.000000000","message":"yeah, I personally would return an error message, since the error is already known at this point and the update is not called. But if you prefer to maintain the behavior across features, it is a reasonable reason too.","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3c90d6508dcc3804187ebb1a3f76b887e8ff60e2","unresolved":true,"context_lines":[{"line_number":374,"context_line":"            update_kwargs[\u0027resource_action\u0027] \u003d parsed_args.resource_action"},{"line_number":375,"context_line":"        if parsed_args.lock_reason is not None:"},{"line_number":376,"context_line":"            update_kwargs[\u0027lock_reason\u0027] \u003d parsed_args.lock_reason"},{"line_number":377,"context_line":"        if update_kwargs:"},{"line_number":378,"context_line":"            share_client.resource_locks.update("},{"line_number":379,"context_line":"                parsed_args.lock,"},{"line_number":380,"context_line":"                **update_kwargs"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a463b95_979a83f9","line":377,"range":{"start_line":377,"start_character":0,"end_line":377,"end_character":25},"in_reply_to":"bbd34c26_5bf6f51c","updated":"2023-08-24 18:18:33.000000000","message":"nope; same behavior as the other \"set\" operations on OSC; here\u0027s one of these: https://opendev.org/openstack/python-manilaclient/src/commit/7a15a2a1ae9bde8236547b85c90a9f71c9f11073/manilaclient/osc/v2/security_services.py#L280-L323\n\nDo you prefer an error?","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cc2fc33c7a22b5ff24d978736e20a8d32307c2ad","unresolved":true,"context_lines":[{"line_number":374,"context_line":"            update_kwargs[\u0027resource_action\u0027] \u003d parsed_args.resource_action"},{"line_number":375,"context_line":"        if parsed_args.lock_reason is not None:"},{"line_number":376,"context_line":"            update_kwargs[\u0027lock_reason\u0027] \u003d parsed_args.lock_reason"},{"line_number":377,"context_line":"        if update_kwargs:"},{"line_number":378,"context_line":"            share_client.resource_locks.update("},{"line_number":379,"context_line":"                parsed_args.lock,"},{"line_number":380,"context_line":"                **update_kwargs"}],"source_content_type":"text/x-python","patch_set":9,"id":"4d53d948_8eebc166","line":377,"range":{"start_line":377,"start_character":0,"end_line":377,"end_character":25},"in_reply_to":"e0237dc4_5f6c9302","updated":"2023-08-24 20:10:37.000000000","message":"ack; we can do a follow up and fix the other instances too, we can shoot for consistency here :)\n\nhttps://bugs.launchpad.net/python-manilaclient/+bug/2032984","commit_id":"1734b45fa59ac1dcb4a38f17b0b124f0672411ac"}]}