)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"44633f00_57e22d58","updated":"2023-08-21 23:10:26.000000000","message":"Thanks Carlos; some comments inline.. please also add a release note with your next PS","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c005ad052de0ba78f861516cc53e36556dbf42f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"dc7f5f39_8614de53","updated":"2023-08-21 23:11:40.000000000","message":"I added comments to PS #8; i think most of them are still relevant","commit_id":"fd19b15783b210f20009a8684a4ef3c355f16a44"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"50f558d7_cb08be99","updated":"2023-08-23 15:13:32.000000000","message":"Thanks for the review, Goutham! Please take another look :)","commit_id":"7d41caf643be4fcfefe8bd1b42e653a30f833be1"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"b6aa9292efe53396c5035ec32a299ad5713c8ef5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"d98aa9da_15ebbd74","updated":"2023-08-25 07:37:00.000000000","message":"LGTM.","commit_id":"2aa8f0d692eed151af14dff55a2c44a47f0d40cb"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"35fd33e83c4d54cf9e0e69a0f5a2c8e634867b2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f94043c9_5b82c175","updated":"2023-08-24 20:02:14.000000000","message":"LGTM; thank you Carlos!","commit_id":"2aa8f0d692eed151af14dff55a2c44a47f0d40cb"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"41f6d8010f04b5099d56e13c7495405794f6433a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"90593c16_d861e6b3","updated":"2023-08-28 11:18:15.000000000","message":"Thanks for updating the Depends-On and for the reviews, Haixin!\nI\u0027m pulling the trigger on this change. It had Goutham\u0027s +2 (but he\u0027s afk now and will be unable to vote on the change again)","commit_id":"4eccd687941af466973d8a795ea7d7f543958f10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"007c34f58ba9911b111e405cee8d293989d55733","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fda5d399_3a84a8f5","updated":"2023-08-28 01:32:18.000000000","message":"i change Depends-On from https://review.opendev.org/c/openstack/manila/+/887725\nto Iea422c9d6bc99a81cd88c5f4b7055d6a1cf97fdc.","commit_id":"4eccd687941af466973d8a795ea7d7f543958f10"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"6d1a7936de44bbb7d40edfacb1ac8cb1a8dad2e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7fe54c74_2d331db9","updated":"2023-08-28 01:31:10.000000000","message":"recheck","commit_id":"4eccd687941af466973d8a795ea7d7f543958f10"}],"manilaclient/osc/v2/share_access_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":88,"context_line":"            \"--lock-visibility\","},{"line_number":89,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":90,"context_line":"            default\u003dFalse,"},{"line_number":91,"context_line":"            help\u003d_(\"Whether the access rule sensible fields should be \""},{"line_number":92,"context_line":"                   \"displayed to everyone or redacted. Only available with \""},{"line_number":93,"context_line":"                   \"API version \u003e\u003d 2.81.\")"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"135ced63_6bb1b8eb","line":92,"range":{"start_line":91,"start_character":20,"end_line":92,"end_character":54},"updated":"2023-08-21 23:10:26.000000000","message":"Whether the sensitive fields of the access rule redacted to other users","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \"--lock-visibility\","},{"line_number":89,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":90,"context_line":"            default\u003dFalse,"},{"line_number":91,"context_line":"            help\u003d_(\"Whether the access rule sensible fields should be \""},{"line_number":92,"context_line":"                   \"displayed to everyone or redacted. Only available with \""},{"line_number":93,"context_line":"                   \"API version \u003e\u003d 2.81.\")"},{"line_number":94,"context_line":"        )"},{"line_number":95,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"11aba1e4_77a0446c","line":92,"range":{"start_line":91,"start_character":20,"end_line":92,"end_character":54},"in_reply_to":"135ced63_6bb1b8eb","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":96,"context_line":"            \"--lock-deletion\","},{"line_number":97,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":98,"context_line":"            default\u003dFalse,"},{"line_number":99,"context_line":"            help\u003d_(\"Whether Manila should prevent the deletion of the access \""},{"line_number":100,"context_line":"                   \"by other users or not. Only available with API version \""},{"line_number":101,"context_line":"                   \"\u003e\u003d 2.81.\")"},{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"33c89fc5_652a27c6","line":100,"range":{"start_line":99,"start_character":20,"end_line":100,"end_character":43},"updated":"2023-08-21 23:10:26.000000000","message":"perhaps: \"When enabled, a \"delete\" lock will be placed against the rule and the rule cannot be deleted while the lock exists.\"\n\n\n\n\nbecause this deletion restriction applies to everyone, including the user that creates the lock... we can clarify further in the \"unrestrict\" option that the user that created the rule can remove the rule, along with its restrictions.","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \"--lock-deletion\","},{"line_number":97,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":98,"context_line":"            default\u003dFalse,"},{"line_number":99,"context_line":"            help\u003d_(\"Whether Manila should prevent the deletion of the access \""},{"line_number":100,"context_line":"                   \"by other users or not. Only available with API version \""},{"line_number":101,"context_line":"                   \"\u003e\u003d 2.81.\")"},{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":8,"id":"6fedcee3_ca4619d3","line":100,"range":{"start_line":99,"start_character":20,"end_line":100,"end_character":43},"in_reply_to":"33c89fc5_652a27c6","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":124,"context_line":"            parsed_args.lock_reason if parsed_args.lock_reason else None"},{"line_number":125,"context_line":"        )"},{"line_number":126,"context_line":"        lock_args \u003d [lock_visibility, lock_deletion, lock_reason]"},{"line_number":127,"context_line":"        for arg in lock_args:"},{"line_number":128,"context_line":"            if arg and share_client.api_version \u003c api_versions.APIVersion("},{"line_number":129,"context_line":"                    \"2.81\"):"},{"line_number":130,"context_line":"                raise exceptions.CommandError("},{"line_number":131,"context_line":"                    \u0027Restricted access rules are only available starting \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"dd2d2333_f4174b42","line":128,"range":{"start_line":127,"start_character":8,"end_line":128,"end_character":18},"updated":"2023-08-21 23:10:26.000000000","message":"```if any(lock_args) and share_client.api_version \u003c api_versions.APIVersion(...```","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            parsed_args.lock_reason if parsed_args.lock_reason else None"},{"line_number":125,"context_line":"        )"},{"line_number":126,"context_line":"        lock_args \u003d [lock_visibility, lock_deletion, lock_reason]"},{"line_number":127,"context_line":"        for arg in lock_args:"},{"line_number":128,"context_line":"            if arg and share_client.api_version \u003c api_versions.APIVersion("},{"line_number":129,"context_line":"                    \"2.81\"):"},{"line_number":130,"context_line":"                raise exceptions.CommandError("},{"line_number":131,"context_line":"                    \u0027Restricted access rules are only available starting \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"1dda6916_40b2f1fe","line":128,"range":{"start_line":127,"start_character":8,"end_line":128,"end_character":18},"in_reply_to":"dd2d2333_f4174b42","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":206,"context_line":"            \"--unrestrict\","},{"line_number":207,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":208,"context_line":"            default\u003dFalse,"},{"line_number":209,"context_line":"            help\u003d_(\"Whether Manila should attempt to unlock the access rule \""},{"line_number":210,"context_line":"                   \"before deleting or not. Only available with API version \""},{"line_number":211,"context_line":"                   \"\u003e\u003d 2.81.\")"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"8113981b_9889a333","line":210,"range":{"start_line":209,"start_character":20,"end_line":210,"end_character":43},"updated":"2023-08-21 23:10:26.000000000","message":"perhaps simply:\n\n```Seek access rule deletion despite restrictions. ```\n\n\nsince that\u0027s what\u0027s happening..","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            \"--unrestrict\","},{"line_number":207,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":208,"context_line":"            default\u003dFalse,"},{"line_number":209,"context_line":"            help\u003d_(\"Whether Manila should attempt to unlock the access rule \""},{"line_number":210,"context_line":"                   \"before deleting or not. Only available with API version \""},{"line_number":211,"context_line":"                   \"\u003e\u003d 2.81.\")"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":8,"id":"7400c58f_b50e087d","line":210,"range":{"start_line":209,"start_character":20,"end_line":210,"end_character":43},"in_reply_to":"8113981b_9889a333","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"}],"manilaclient/tests/functional/osc/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":270,"context_line":"        if properties:"},{"line_number":271,"context_line":"            cmd +\u003d f\u0027--properties {properties} \u0027"},{"line_number":272,"context_line":"        if wait:"},{"line_number":273,"context_line":"            cmd +\u003d f\u0027--wait \u0027"},{"line_number":274,"context_line":"        if lock_visibility:"},{"line_number":275,"context_line":"            cmd +\u003d f\u0027--lock-visibility \u0027"},{"line_number":276,"context_line":"        if lock_deletion:"}],"source_content_type":"text/x-python","patch_set":8,"id":"4966602f_5afcf1aa","line":273,"range":{"start_line":273,"start_character":19,"end_line":273,"end_character":20},"updated":"2023-08-21 23:10:26.000000000","message":"no need for f\u0027\u0027 here and below..","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        if properties:"},{"line_number":271,"context_line":"            cmd +\u003d f\u0027--properties {properties} \u0027"},{"line_number":272,"context_line":"        if wait:"},{"line_number":273,"context_line":"            cmd +\u003d f\u0027--wait \u0027"},{"line_number":274,"context_line":"        if lock_visibility:"},{"line_number":275,"context_line":"            cmd +\u003d f\u0027--lock-visibility \u0027"},{"line_number":276,"context_line":"        if lock_deletion:"}],"source_content_type":"text/x-python","patch_set":8,"id":"fc2ce632_d9ec4f46","line":273,"range":{"start_line":273,"start_character":19,"end_line":273,"end_character":20},"in_reply_to":"4966602f_5afcf1aa","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":275,"context_line":"            cmd +\u003d f\u0027--lock-visibility \u0027"},{"line_number":276,"context_line":"        if lock_deletion:"},{"line_number":277,"context_line":"            cmd +\u003d f\u0027--lock-deletion \u0027"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        access_rule \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        return access_rule"}],"source_content_type":"text/x-python","patch_set":8,"id":"7b2485aa_243d9a07","line":278,"updated":"2023-08-21 23:10:26.000000000","message":"add lock_reason as well..","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"            cmd +\u003d f\u0027--lock-visibility \u0027"},{"line_number":276,"context_line":"        if lock_deletion:"},{"line_number":277,"context_line":"            cmd +\u003d f\u0027--lock-deletion \u0027"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"        access_rule \u003d self.dict_result(\u0027share\u0027, cmd)"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        return access_rule"}],"source_content_type":"text/x-python","patch_set":8,"id":"cdedce64_b4992908","line":278,"in_reply_to":"7b2485aa_243d9a07","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"}],"manilaclient/tests/functional/osc/test_share_access_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from manilaclient.tests.functional.osc import base"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import exceptions as tempest_exc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"abbbf2a2_39d9a509","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":10},"updated":"2023-08-21 23:10:26.000000000","message":"group third party libs and move above the package imports","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from manilaclient.tests.functional.osc import base"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import exceptions as tempest_exc"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import ddt"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"724e5806_db3ff3d2","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"abbbf2a2_39d9a509","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":58,"context_line":"    @ddt.data("},{"line_number":59,"context_line":"        {\u0027lock_visibility\u0027: True, \u0027lock_deletion\u0027: True},"},{"line_number":60,"context_line":"        {\u0027lock_visibility\u0027: False, \u0027lock_deletion\u0027: True},"},{"line_number":61,"context_line":"        {\u0027lock_visibility\u0027: True, \u0027lock_deletion\u0027: False}"},{"line_number":62,"context_line":"    )"},{"line_number":63,"context_line":"    @ddt.unpack"},{"line_number":64,"context_line":"    def test_share_access_allow_restrict(self, lock_visibility,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7629659a_266633ca","line":61,"range":{"start_line":61,"start_character":56,"end_line":61,"end_character":57},"updated":"2023-08-21 23:10:26.000000000","message":"add a lock_reason in one or two of these..","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    @ddt.data("},{"line_number":59,"context_line":"        {\u0027lock_visibility\u0027: True, \u0027lock_deletion\u0027: True},"},{"line_number":60,"context_line":"        {\u0027lock_visibility\u0027: False, \u0027lock_deletion\u0027: True},"},{"line_number":61,"context_line":"        {\u0027lock_visibility\u0027: True, \u0027lock_deletion\u0027: False}"},{"line_number":62,"context_line":"    )"},{"line_number":63,"context_line":"    @ddt.unpack"},{"line_number":64,"context_line":"    def test_share_access_allow_restrict(self, lock_visibility,"}],"source_content_type":"text/x-python","patch_set":8,"id":"95708511_1bb5084d","line":61,"range":{"start_line":61,"start_character":56,"end_line":61,"end_character":57},"in_reply_to":"7629659a_266633ca","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":82,"context_line":"        self.openstack("},{"line_number":83,"context_line":"            \u0027share\u0027,"},{"line_number":84,"context_line":"            params\u003df\u0027access delete {share[\"id\"]} {access_rule[\"id\"]} \u0027"},{"line_number":85,"context_line":"                   f\u0027--unrestrict\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"dd71a567_63c91906","line":85,"range":{"start_line":85,"start_character":34,"end_line":85,"end_character":35},"updated":"2023-08-21 23:10:26.000000000","message":"add \n\n\u0027--wait\u0027","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self.openstack("},{"line_number":83,"context_line":"            \u0027share\u0027,"},{"line_number":84,"context_line":"            params\u003df\u0027access delete {share[\"id\"]} {access_rule[\"id\"]} \u0027"},{"line_number":85,"context_line":"                   f\u0027--unrestrict\u0027)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"cc355288_c312975b","line":85,"range":{"start_line":85,"start_character":34,"end_line":85,"end_character":35},"in_reply_to":"dd71a567_63c91906","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"}],"manilaclient/tests/unit/osc/v2/test_share_access_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":10,"context_line":"#   License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#   under the License."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from unittest import mock"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"92ce5901_6a5605e4","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"updated":"2023-08-21 23:10:26.000000000","message":"ddt belongs to the second group, with osc_lib","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#   under the License."},{"line_number":12,"context_line":"#"},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from unittest import mock"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"07de5c0a_e55e36d1","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":10},"in_reply_to":"92ce5901_6a5605e4","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":597,"context_line":"        return access"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"},{"line_number":600,"context_line":"    def allow(self, share, access_type, access, access_level, metadata\u003dNone, # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":601,"context_line":"              lock_visibility\u003dFalse, lock_deletion\u003dFalse, lock_reason\u003dNone):"},{"line_number":602,"context_line":"        self._validate_access(access_type, access)"},{"line_number":603,"context_line":"        return self._do_allow("},{"line_number":604,"context_line":"            share, access_type, access, access_level, \"os-allow_access\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"d5a9a64d_5ea017d7","line":601,"range":{"start_line":600,"start_character":3,"end_line":601,"end_character":76},"updated":"2023-08-21 23:10:26.000000000","message":"here and below; there should be no need to change the method signature.. you could add the new method for version 2.82+ with the extra kwargs","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"892bb5cedea655581ec66e4f468dd656eede80b0","unresolved":false,"context_lines":[{"line_number":597,"context_line":"        return access"},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"},{"line_number":600,"context_line":"    def allow(self, share, access_type, access, access_level, metadata\u003dNone, # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":601,"context_line":"              lock_visibility\u003dFalse, lock_deletion\u003dFalse, lock_reason\u003dNone):"},{"line_number":602,"context_line":"        self._validate_access(access_type, access)"},{"line_number":603,"context_line":"        return self._do_allow("},{"line_number":604,"context_line":"            share, access_type, access, access_level, \"os-allow_access\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"c1f95133_8abe9059","line":601,"range":{"start_line":600,"start_character":3,"end_line":601,"end_character":76},"in_reply_to":"d5a9a64d_5ea017d7","updated":"2023-08-24 16:44:37.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":627,"context_line":"        return self._do_allow("},{"line_number":628,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    @api_versions.wraps(\"2.45\", \"2.79\")  # noqa"},{"line_number":631,"context_line":"    def allow(self, share, access_type, access, access_level, metadata\u003dNone, # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":632,"context_line":"              lock_visibility\u003dFalse, lock_deletion\u003dFalse, lock_reason\u003dNone):   # noqa"},{"line_number":633,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"25ca7079_67c0b1b8","line":630,"range":{"start_line":630,"start_character":35,"end_line":630,"end_character":37},"updated":"2023-08-21 23:10:26.000000000","message":"check version; needs to be \u00272.81\u0027 here when you bump the below to \u00272.82\u0027","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c005ad052de0ba78f861516cc53e36556dbf42f1","unresolved":false,"context_lines":[{"line_number":627,"context_line":"        return self._do_allow("},{"line_number":628,"context_line":"            share, access_type, access, access_level, \"allow_access\")"},{"line_number":629,"context_line":""},{"line_number":630,"context_line":"    @api_versions.wraps(\"2.45\", \"2.79\")  # noqa"},{"line_number":631,"context_line":"    def allow(self, share, access_type, access, access_level, metadata\u003dNone, # pylint: disable\u003dfunction-redefined  # noqa F811"},{"line_number":632,"context_line":"              lock_visibility\u003dFalse, lock_deletion\u003dFalse, lock_reason\u003dNone):   # noqa"},{"line_number":633,"context_line":"        valid_access_types \u003d (\u0027ip\u0027, \u0027user\u0027, \u0027cert\u0027, \u0027cephx\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bda52fb1_56e4be47","line":630,"range":{"start_line":630,"start_character":35,"end_line":630,"end_character":37},"in_reply_to":"25ca7079_67c0b1b8","updated":"2023-08-21 23:11:40.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"33fa231f3349887e0c9467a97c994c87ff43e2e1","unresolved":true,"context_lines":[{"line_number":662,"context_line":"        return self._action(action_name, share, body)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"},{"line_number":665,"context_line":"    def deny(self, share, access_id, unrestrict\u003dFalse):"},{"line_number":666,"context_line":"        return self._do_deny(share, access_id, \"os-deny_access\")"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    @api_versions.wraps(\"2.7\")  # noqa"}],"source_content_type":"text/x-python","patch_set":8,"id":"ad8dcda3_da024fb4","line":665,"range":{"start_line":665,"start_character":36,"end_line":665,"end_character":55},"updated":"2023-08-21 23:10:26.000000000","message":"same comment as above","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"b5ca07162ce847cb9053420f78d5c31ee5ed327a","unresolved":false,"context_lines":[{"line_number":662,"context_line":"        return self._action(action_name, share, body)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    @api_versions.wraps(\"1.0\", \"2.6\")"},{"line_number":665,"context_line":"    def deny(self, share, access_id, unrestrict\u003dFalse):"},{"line_number":666,"context_line":"        return self._do_deny(share, access_id, \"os-deny_access\")"},{"line_number":667,"context_line":""},{"line_number":668,"context_line":"    @api_versions.wraps(\"2.7\")  # noqa"}],"source_content_type":"text/x-python","patch_set":8,"id":"f98634cd_80c28461","line":665,"range":{"start_line":665,"start_character":36,"end_line":665,"end_character":55},"in_reply_to":"ad8dcda3_da024fb4","updated":"2023-08-23 15:13:32.000000000","message":"Done","commit_id":"2a41712ec302831207e2c9d351fccc388a6c4bcd"}]}