)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cb59a88f4f4392e434313af9f2880ebe9a264248","unresolved":true,"context_lines":[{"line_number":10,"context_line":"for service-disable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2037700"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0b6ac3a3a16a3eaa56758bc0b7f77bfbf2eef9e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1fe5632a_1670829e","line":13,"updated":"2024-02-23 09:38:46.000000000","message":"can you add a Depends-On to the manila change?\n\nAlso, we could make a minor improvement to an existing functional test to capture this functionality: https://github.com/openstack/python-manilaclient/blob/5551c9420b7a0d0316ef0ac21013849f1efc575c/manilaclient/tests/functional/osc/test_share_services.py#L46-L52","commit_id":"15982936678af1cabda61eb896d295002953a10e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2d335ce57fc8db2529b1c846187e817ffcadcba0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for service-disable."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #2037700"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I0b6ac3a3a16a3eaa56758bc0b7f77bfbf2eef9e7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"f2c98d65_faa749e4","line":13,"in_reply_to":"1fe5632a_1670829e","updated":"2024-02-27 01:45:58.000000000","message":"Done","commit_id":"15982936678af1cabda61eb896d295002953a10e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"15671a2906970170a13394cbf6b84d6ac8324598","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fb1ad9ea_34a18f00","updated":"2024-02-22 13:49:33.000000000","message":"Looks good to me. I\u0027ll test this change today. Could you please add a release note? :)","commit_id":"601df123e489eaa0e6e3b097398677bb8d8f11b0"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"75c3faa64e5ed9cfaf3d9ff1017e6eb6cabad72f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b9f0c4ea_ec02af6a","in_reply_to":"5c7de910_7df7e3d2","updated":"2024-02-23 02:32:17.000000000","message":"thanks for your review, Carlos Eduardo.\ni have added release note.","commit_id":"601df123e489eaa0e6e3b097398677bb8d8f11b0"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"10937307a00c17ccadd77d36515703d33f25ad7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c7de910_7df7e3d2","in_reply_to":"fb1ad9ea_34a18f00","updated":"2024-02-22 21:38:57.000000000","message":".... tested and works just fine. Thank you!","commit_id":"601df123e489eaa0e6e3b097398677bb8d8f11b0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5cd673699ad41b2844ae0b697cb418abfa84c96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"29938051_65404e4f","updated":"2024-02-23 09:35:51.000000000","message":"LGTM; thanks Haixin. I\u0027ve a couple of minor comments if you wish to make an improvemnent","commit_id":"15982936678af1cabda61eb896d295002953a10e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"bc72084346d48a561195fd6373430aaae650a920","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"32a9e890_be712f87","updated":"2024-02-27 13:46:25.000000000","message":"LGTM, thank you for working on this feature :)","commit_id":"67cadf38315e5026b630a6bd08ec721af1e2df89"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"852384909e65325fad43be522e002090e04c4e56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1cd8d2da_3f3b9209","updated":"2024-02-27 21:48:25.000000000","message":"Thanks for the changes Haixin. LGTM!","commit_id":"67cadf38315e5026b630a6bd08ec721af1e2df89"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"c6121a8cdba86eb5671cc6fce8895bac35d12d41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"52686506_bf7a7fbd","updated":"2024-02-28 21:28:27.000000000","message":"recheck\nCore change has now merged","commit_id":"67cadf38315e5026b630a6bd08ec721af1e2df89"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2d335ce57fc8db2529b1c846187e817ffcadcba0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5939406f_82883dc5","updated":"2024-02-27 01:45:58.000000000","message":"thanks for your review. Goutham Pacha Ravi","commit_id":"67cadf38315e5026b630a6bd08ec721af1e2df89"}],"manilaclient/osc/v2/services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5cd673699ad41b2844ae0b697cb418abfa84c96","unresolved":true,"context_lines":[{"line_number":60,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":63,"context_line":"        if parsed_args.disable:"},{"line_number":64,"context_line":"            if parsed_args.disable_reason:"},{"line_number":65,"context_line":"                if share_client.api_version \u003c api_versions.APIVersion(\"2.83\"):"},{"line_number":66,"context_line":"                    raise exceptions.CommandError("},{"line_number":67,"context_line":"                        \"Service disable reason can be specified only with \""},{"line_number":68,"context_line":"                        \"manila API version \u003e\u003d 2.83\")"},{"line_number":69,"context_line":"        if parsed_args.enable:"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                share_client.services.enable("}],"source_content_type":"text/x-python","patch_set":5,"id":"2d28cbc3_379f1587","line":68,"range":{"start_line":63,"start_character":0,"end_line":68,"end_character":53},"updated":"2024-02-23 09:35:51.000000000","message":"Can we combine this in L80?","commit_id":"15982936678af1cabda61eb896d295002953a10e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2d335ce57fc8db2529b1c846187e817ffcadcba0","unresolved":false,"context_lines":[{"line_number":60,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"        share_client \u003d self.app.client_manager.share"},{"line_number":63,"context_line":"        if parsed_args.disable:"},{"line_number":64,"context_line":"            if parsed_args.disable_reason:"},{"line_number":65,"context_line":"                if share_client.api_version \u003c api_versions.APIVersion(\"2.83\"):"},{"line_number":66,"context_line":"                    raise exceptions.CommandError("},{"line_number":67,"context_line":"                        \"Service disable reason can be specified only with \""},{"line_number":68,"context_line":"                        \"manila API version \u003e\u003d 2.83\")"},{"line_number":69,"context_line":"        if parsed_args.enable:"},{"line_number":70,"context_line":"            try:"},{"line_number":71,"context_line":"                share_client.services.enable("}],"source_content_type":"text/x-python","patch_set":5,"id":"fe6f36db_482f9186","line":68,"range":{"start_line":63,"start_character":0,"end_line":68,"end_character":53},"in_reply_to":"2d28cbc3_379f1587","updated":"2024-02-27 01:45:58.000000000","message":"Done","commit_id":"15982936678af1cabda61eb896d295002953a10e"}],"manilaclient/tests/unit/osc/v2/test_services.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b5cd673699ad41b2844ae0b697cb418abfa84c96","unresolved":true,"context_lines":[{"line_number":157,"context_line":"        \u0027state\u0027,"},{"line_number":158,"context_line":"        \u0027updated_at\u0027"},{"line_number":159,"context_line":"    ]"},{"line_number":160,"context_line":"    columns_with_reason \u003d ["},{"line_number":161,"context_line":"        \u0027id\u0027,"},{"line_number":162,"context_line":"        \u0027binary\u0027,"},{"line_number":163,"context_line":"        \u0027host\u0027,"},{"line_number":164,"context_line":"        \u0027zone\u0027,"},{"line_number":165,"context_line":"        \u0027status\u0027,"},{"line_number":166,"context_line":"        \u0027state\u0027,"},{"line_number":167,"context_line":"        \u0027updated_at\u0027,"},{"line_number":168,"context_line":"        \u0027disabled_reason\u0027"},{"line_number":169,"context_line":"    ]"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    column_headers \u003d utils.format_column_headers(columns)"},{"line_number":172,"context_line":"    column_headers_with_reason \u003d utils.format_column_headers("}],"source_content_type":"text/x-python","patch_set":5,"id":"abfd3dc4_4b49d266","line":169,"range":{"start_line":160,"start_character":0,"end_line":169,"end_character":5},"updated":"2024-02-23 09:35:51.000000000","message":"columns_with_reason \u003d columns + [\u0027disabled_reason\u0027]","commit_id":"15982936678af1cabda61eb896d295002953a10e"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"2d335ce57fc8db2529b1c846187e817ffcadcba0","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        \u0027state\u0027,"},{"line_number":158,"context_line":"        \u0027updated_at\u0027"},{"line_number":159,"context_line":"    ]"},{"line_number":160,"context_line":"    columns_with_reason \u003d ["},{"line_number":161,"context_line":"        \u0027id\u0027,"},{"line_number":162,"context_line":"        \u0027binary\u0027,"},{"line_number":163,"context_line":"        \u0027host\u0027,"},{"line_number":164,"context_line":"        \u0027zone\u0027,"},{"line_number":165,"context_line":"        \u0027status\u0027,"},{"line_number":166,"context_line":"        \u0027state\u0027,"},{"line_number":167,"context_line":"        \u0027updated_at\u0027,"},{"line_number":168,"context_line":"        \u0027disabled_reason\u0027"},{"line_number":169,"context_line":"    ]"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    column_headers \u003d utils.format_column_headers(columns)"},{"line_number":172,"context_line":"    column_headers_with_reason \u003d utils.format_column_headers("}],"source_content_type":"text/x-python","patch_set":5,"id":"eaf98e1d_235a3774","line":169,"range":{"start_line":160,"start_character":0,"end_line":169,"end_character":5},"in_reply_to":"abfd3dc4_4b49d266","updated":"2024-02-27 01:45:58.000000000","message":"Done","commit_id":"15982936678af1cabda61eb896d295002953a10e"}]}
