)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8a53c43aa57a85ad3427e517387d02eafb61d730","unresolved":true,"context_lines":[{"line_number":10,"context_line":"force delete and then delete. Fix it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8257c04f2b5f1a02533dc0fa5d37ae6ff923a56a"},{"line_number":13,"context_line":"partially-implements: bp/deferred-deletion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"552c7ec7_c76fc667","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":42},"updated":"2024-01-30 22:20:36.000000000","message":"thanks for finding this bug and for fixing it. This bugfix isn\u0027t related to deferred deletion per-se. I\u0027d prefer if we used a separate launchpad tracker for this. Especially because I think we should backport this to older stable branches of the client.\n\nI created a bug here: https://bugs.launchpad.net/python-manilaclient/+bug/2051737\n\n\nCan you please add: \"Closes-Bug: #2051737\" to the commit message here\nand add a bug fix release note with your next patch?\n\nthis paperwork allows us to publish bugfix release notes when we backport this fix.","commit_id":"31a98108f44aa5ce33419e56215f08565e86df3b"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"43d5056a9ce0c6fb0bb787913d2d20cca4015cf7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"force delete and then delete. Fix it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I8257c04f2b5f1a02533dc0fa5d37ae6ff923a56a"},{"line_number":13,"context_line":"partially-implements: bp/deferred-deletion"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fd786531_92fe75c0","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":42},"in_reply_to":"552c7ec7_c76fc667","updated":"2024-01-31 08:24:53.000000000","message":"Done","commit_id":"31a98108f44aa5ce33419e56215f08565e86df3b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8a53c43aa57a85ad3427e517387d02eafb61d730","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d01b4877_8ff762a7","updated":"2024-01-30 22:20:36.000000000","message":"Thanks for finding this issue and fixing it up. It shows we don\u0027t have good unit tests :( I\u0027ve added a comment in the commit message regarding the bugfix reno... I\u0027d appreciate including it so we can make this fix to older stable branches after it merges in master","commit_id":"31a98108f44aa5ce33419e56215f08565e86df3b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2719ad6f526635296f240ab8a241a111a766e9ec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e4d75598_e078e546","updated":"2024-01-31 20:33:10.000000000","message":"Thanks for the changes, and the unit tests as well! couple of suggestions if you decide to make another patch","commit_id":"648c2c74f993a02095367599423e6345f27467d7"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"ccec4082e89060e79cc90157dbcaf1adb72d9000","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b3634fcb_de59d2ec","updated":"2024-02-16 21:20:15.000000000","message":"LGMT, thanks for the fix Kiran","commit_id":"99be0ce9cc78b287170a5287c7bfd59038c7ecc2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e1e3373957a3201479007bee94d860ec8f92d863","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"16486f86_bfba3384","updated":"2024-02-02 20:14:53.000000000","message":"LGTM","commit_id":"99be0ce9cc78b287170a5287c7bfd59038c7ecc2"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e96feac3f467620f7717f23ae0be25ec8f28ae0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8f83806f_04e830c1","updated":"2024-02-05 14:03:17.000000000","message":"LGTM, thank you for working on this fix","commit_id":"99be0ce9cc78b287170a5287c7bfd59038c7ecc2"}],"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2719ad6f526635296f240ab8a241a111a766e9ec","unresolved":true,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        self.shares_mock.force_delete.assert_called_once_with(shares[0])"},{"line_number":486,"context_line":"        self.shares_mock.soft_delete.assert_not_called()"},{"line_number":487,"context_line":"        self.assertIsNone(result)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def test_share_delete_with_soft(self):"},{"line_number":490,"context_line":"        shares \u003d self.setup_shares_mock(count\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2eb1754f_07f6c153","line":487,"updated":"2024-01-31 20:33:10.000000000","message":"```\nself.shares_mock.delete.assert_not_called()\n```\n\nto tighten this","commit_id":"648c2c74f993a02095367599423e6345f27467d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0bf6b5992ca7c55c72c54326d7666584276c3bb6","unresolved":false,"context_lines":[{"line_number":484,"context_line":""},{"line_number":485,"context_line":"        self.shares_mock.force_delete.assert_called_once_with(shares[0])"},{"line_number":486,"context_line":"        self.shares_mock.soft_delete.assert_not_called()"},{"line_number":487,"context_line":"        self.assertIsNone(result)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":"    def test_share_delete_with_soft(self):"},{"line_number":490,"context_line":"        shares \u003d self.setup_shares_mock(count\u003d1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2463b77c_41d62ff8","line":487,"in_reply_to":"2eb1754f_07f6c153","updated":"2024-02-01 07:39:21.000000000","message":"Done","commit_id":"648c2c74f993a02095367599423e6345f27467d7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2719ad6f526635296f240ab8a241a111a766e9ec","unresolved":true,"context_lines":[{"line_number":503,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        self.shares_mock.soft_delete.assert_called_once_with(shares[0])"},{"line_number":506,"context_line":"        self.shares_mock.force_delete.assert_not_called()"},{"line_number":507,"context_line":"        self.assertIsNone(result)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_share_delete_wrong_name(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"736baebc_61b6bcab","line":506,"updated":"2024-01-31 20:33:10.000000000","message":"```\nself.shares_mock.delete.assert_not_called()\n```\n\nto tighten this","commit_id":"648c2c74f993a02095367599423e6345f27467d7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"0bf6b5992ca7c55c72c54326d7666584276c3bb6","unresolved":false,"context_lines":[{"line_number":503,"context_line":"        result \u003d self.cmd.take_action(parsed_args)"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        self.shares_mock.soft_delete.assert_called_once_with(shares[0])"},{"line_number":506,"context_line":"        self.shares_mock.force_delete.assert_not_called()"},{"line_number":507,"context_line":"        self.assertIsNone(result)"},{"line_number":508,"context_line":""},{"line_number":509,"context_line":"    def test_share_delete_wrong_name(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"4a870b22_82567363","line":506,"in_reply_to":"736baebc_61b6bcab","updated":"2024-02-01 07:39:21.000000000","message":"Done","commit_id":"648c2c74f993a02095367599423e6345f27467d7"}]}