)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"user to add user friently export location."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"example command:"},{"line_number":13,"context_line":"$ manila create nfs 1 --name share_name --mount-point-name custom_export_path"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"},{"line_number":16,"context_line":"Change-Id: If896065a74fc4ebabd09b677e5eb0329cecfaab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ae714058_126aa10d","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":8},"updated":"2024-02-23 10:00:51.000000000","message":"s/manila/openstack share","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"user to add user friently export location."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"example command:"},{"line_number":13,"context_line":"$ manila create nfs 1 --name share_name --mount-point-name custom_export_path"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"},{"line_number":16,"context_line":"Change-Id: If896065a74fc4ebabd09b677e5eb0329cecfaab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"8eccfde7_18ed2796","line":13,"range":{"start_line":13,"start_character":2,"end_line":13,"end_character":8},"in_reply_to":"ae714058_126aa10d","updated":"2024-02-27 04:57:49.000000000","message":"updated to openstack","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"example command:"},{"line_number":13,"context_line":"$ manila create nfs 1 --name share_name --mount-point-name custom_export_path"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"},{"line_number":16,"context_line":"Change-Id: If896065a74fc4ebabd09b677e5eb0329cecfaab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9d69cf38_a7ae3817","line":14,"updated":"2024-02-23 10:00:51.000000000","message":"Can you please add:\n\n```\npartially-implements: bp human-readable-export-locations\n```","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"example command:"},{"line_number":13,"context_line":"$ manila create nfs 1 --name share_name --mount-point-name custom_export_path"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I72ac7e24ddd4330d76cafd5e7f78bac2b0174883"},{"line_number":16,"context_line":"Change-Id: If896065a74fc4ebabd09b677e5eb0329cecfaab9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"b18d801b_cfb0b49d","line":14,"in_reply_to":"9d69cf38_a7ae3817","updated":"2024-02-27 04:57:49.000000000","message":"added blue print details","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b5f1169c84d66219f6cbd243f1ad45bf99b66ece","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Human readable export location CLI changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenStack CLI option is added to support"},{"line_number":10,"context_line":"user to add user friently export location."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"example command:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5350534e_a9726536","line":9,"updated":"2024-03-11 11:13:50.000000000","message":"OpenStack CLI option is added in share create API to support user friendly export location","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5fe13130da05f84f383e5ea15c58317512c93a62","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Human readable export location CLI changes"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OpenStack CLI option is added to support"},{"line_number":10,"context_line":"user to add user friently export location."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"example command:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"c1f1eff7_bff1f6bf","line":9,"in_reply_to":"5350534e_a9726536","updated":"2024-03-11 17:52:56.000000000","message":"Update text as suggested.","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4820b1ccf5b15431853db27128273d06ae4daacc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"194e1d71_16d82fc3","updated":"2024-02-16 02:20:20.000000000","message":"(vote)","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6bc57d17cd97ec6393d246e3bc214fb1a4dea26e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fbecff0_24e1109a","updated":"2024-02-21 16:17:07.000000000","message":"Thank you! Goutham for the review. Addressed your review comments. Please review again.","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8bd9bbd84235c576ae831471e84d66e7762ba77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c86571ff_08f74972","updated":"2024-02-16 02:20:13.000000000","message":"Thanks for working on this, Jayaanand. This change also needs a release note. Can you please add one? \n\nhttps://docs.openstack.org/manila/latest/contributor/adding_release_notes.html#how-do-i-add-a-release-note","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5ab4f0b3d265b3dc6604dedb469a07d0e3498a10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"437b5def_223e9c6a","updated":"2024-02-22 21:34:08.000000000","message":"LGTM. Tested the change and it worked just fine. Thank you for working on it :)","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ee4d2576_3d248075","updated":"2024-02-23 10:00:51.000000000","message":"Thanks for the changes Jayaanand. I\u0027ve added more comments. \n\nCan you please add a release note to this change; overall, it looks pretty good..","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"5ade11186145b8141c491f21c39981705a42de05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"19c1097f_0d3f7d67","updated":"2024-02-27 13:48:44.000000000","message":"LGTM, thank you for working on this feature!","commit_id":"0f1597ac7bdbd2ef51af70632b34dfa24ff79361"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a9956510_bf5af22b","updated":"2024-02-27 04:57:49.000000000","message":"Thank you! Goutham, addressed all review comments. Can you please review again.","commit_id":"0f1597ac7bdbd2ef51af70632b34dfa24ff79361"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd75a656d5fed7adb6f1d850516195bb57983281","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"13307a07_a28c17d1","updated":"2024-02-27 21:54:35.000000000","message":"This looks good to me; please do add a release note as others noted; and you\u0027ll have my +2. \n\nGerrit thinks that this patch will have a merge conflict once we merge the \"CLI for disable service reason\" patch. You can pre-emptively rebase on top of that patch and allow this to be merged.. \n\nI\u0027m out for a few days and watching gerrit changes infrequently.. Carlos/Haixin/others on the core team: please consider this comment as an endorsement to get this without needing my +2 :)","commit_id":"0f1597ac7bdbd2ef51af70632b34dfa24ff79361"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"312157f5825785c3bea99bc55982093940ac502c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"facc8b72_89e483aa","updated":"2024-02-27 13:51:31.000000000","message":"please add releasenotes with mention of 2.84 and what is introduced in this API version.","commit_id":"0f1597ac7bdbd2ef51af70632b34dfa24ff79361"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d5583a991e950016d552f0d9fb53450cd80be777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"432e1bee_871f01b9","in_reply_to":"87a25296_c827e329","updated":"2024-03-11 03:54:43.000000000","message":"Thank you! Kiran, added version 2.84 details release notes.","commit_id":"0f1597ac7bdbd2ef51af70632b34dfa24ff79361"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"1b6d893816f15593f1a4877440f127e38a3b6ff1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"87a25296_c827e329","in_reply_to":"facc8b72_89e483aa","updated":"2024-02-27 13:58:08.000000000","message":"ah, that\u0027s a very good point! thank you for mentioning","commit_id":"0f1597ac7bdbd2ef51af70632b34dfa24ff79361"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b5f1169c84d66219f6cbd243f1ad45bf99b66ece","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9651dec_3e963ed5","updated":"2024-03-11 11:13:50.000000000","message":"is there limit on length of mount_point_name, if so you can validate it.","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d5583a991e950016d552f0d9fb53450cd80be777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0e4c743a_b9209c45","updated":"2024-03-11 03:54:43.000000000","message":"release notes are updated","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5fe13130da05f84f383e5ea15c58317512c93a62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e8e6152d_5f1e2108","in_reply_to":"c9651dec_3e963ed5","updated":"2024-03-11 17:52:56.000000000","message":"lenght limit is imposed in combination with share_type \"provisioning:mount_point_prefix\" and \"project_id\". I am not able to find a way to do it in client. Please provide example you may know, i will add.","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e2e62818ed20440b893d42dbab75b636e064b41f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"936555eb_9d50df97","updated":"2024-03-12 21:18:47.000000000","message":"LGTM, thank you for working on this change :)","commit_id":"b097cec84fa7860b8892167203ea0b7d00b38137"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5fe13130da05f84f383e5ea15c58317512c93a62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e227a842_5c6528f7","updated":"2024-03-11 17:52:56.000000000","message":"Thank you! Kiran, Updated comments as per your suggestion. Please review again.","commit_id":"b097cec84fa7860b8892167203ea0b7d00b38137"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"2de5401e4434837dbc6d9b7c86ee3f4e11aeb9f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c839ce45_0d351573","updated":"2024-03-12 05:13:14.000000000","message":"run-NetApp CI","commit_id":"b097cec84fa7860b8892167203ea0b7d00b38137"}],"manilaclient/osc/v2/share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8bd9bbd84235c576ae831471e84d66e7762ba77","unresolved":true,"context_lines":[{"line_number":243,"context_line":"        if parsed_args.mount_point_name:"},{"line_number":244,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\u00272.83\u0027):"},{"line_number":245,"context_line":"                raise exceptions.CommandError("},{"line_number":246,"context_line":"                    \u0027Setting share  mount point name is \u0027"},{"line_number":247,"context_line":"                    \u0027available only for API microversion \u003e\u003d 2.83\u0027)"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                mount_point_name \u003d parsed_args.mount_point_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"5094057d_b965a312","line":246,"range":{"start_line":246,"start_character":34,"end_line":246,"end_character":36},"updated":"2024-02-16 02:20:13.000000000","message":"nit: remove extra space","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6bc57d17cd97ec6393d246e3bc214fb1a4dea26e","unresolved":false,"context_lines":[{"line_number":243,"context_line":"        if parsed_args.mount_point_name:"},{"line_number":244,"context_line":"            if share_client.api_version \u003c api_versions.APIVersion(\u00272.83\u0027):"},{"line_number":245,"context_line":"                raise exceptions.CommandError("},{"line_number":246,"context_line":"                    \u0027Setting share  mount point name is \u0027"},{"line_number":247,"context_line":"                    \u0027available only for API microversion \u003e\u003d 2.83\u0027)"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                mount_point_name \u003d parsed_args.mount_point_name"}],"source_content_type":"text/x-python","patch_set":3,"id":"973cc077_111d86e2","line":246,"range":{"start_line":246,"start_character":34,"end_line":246,"end_character":36},"in_reply_to":"5094057d_b965a312","updated":"2024-02-21 16:17:07.000000000","message":"extra space is removed","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":193,"context_line":"            metavar\u003d\"\u003cmount_point_name\u003e\","},{"line_number":194,"context_line":"            default\u003dNone,"},{"line_number":195,"context_line":"            help\u003d_(\u0027Optional custom export location. Available for \u0027"},{"line_number":196,"context_line":"                   \u0027microversion \u003e\u003d 2.83\u0027)"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"9eb71682_2bd72f26","line":196,"range":{"start_line":196,"start_character":36,"end_line":196,"end_character":41},"updated":"2024-02-23 10:00:51.000000000","message":"The microversion here must be bumped to 2.84 if we merge haixin\u0027s patch first; please be prepared: https://review.opendev.org/c/openstack/python-manilaclient/+/898190","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":193,"context_line":"            metavar\u003d\"\u003cmount_point_name\u003e\","},{"line_number":194,"context_line":"            default\u003dNone,"},{"line_number":195,"context_line":"            help\u003d_(\u0027Optional custom export location. Available for \u0027"},{"line_number":196,"context_line":"                   \u0027microversion \u003e\u003d 2.83\u0027)"},{"line_number":197,"context_line":"        )"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":4,"id":"2f65047c_cea09f9e","line":196,"range":{"start_line":196,"start_character":36,"end_line":196,"end_character":41},"in_reply_to":"9eb71682_2bd72f26","updated":"2024-02-27 04:57:49.000000000","message":"updated microversion to 2.84.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":288,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":289,"context_line":"            \u0027share_group_id\u0027: share_group,"},{"line_number":290,"context_line":"            \u0027scheduler_hints\u0027: scheduler_hints,"},{"line_number":291,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        share \u003d share_client.shares.create(**body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"40709328_4dcec2c9","line":291,"range":{"start_line":291,"start_character":32,"end_line":291,"end_character":48},"updated":"2024-02-23 10:00:51.000000000","message":"Please add a trailing comma at the end of this item","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":288,"context_line":"            \u0027availability_zone\u0027: parsed_args.availability_zone,"},{"line_number":289,"context_line":"            \u0027share_group_id\u0027: share_group,"},{"line_number":290,"context_line":"            \u0027scheduler_hints\u0027: scheduler_hints,"},{"line_number":291,"context_line":"            \u0027mount_point_name\u0027: mount_point_name"},{"line_number":292,"context_line":"        }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"        share \u003d share_client.shares.create(**body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4265ba88_7399d464","line":291,"range":{"start_line":291,"start_character":32,"end_line":291,"end_character":48},"in_reply_to":"40709328_4dcec2c9","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b5f1169c84d66219f6cbd243f1ad45bf99b66ece","unresolved":true,"context_lines":[{"line_number":245,"context_line":"                raise exceptions.CommandError("},{"line_number":246,"context_line":"                    \u0027Setting share mount point name is \u0027"},{"line_number":247,"context_line":"                    \u0027available only for API microversion \u003e\u003d 2.84\u0027)"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                mount_point_name \u003d parsed_args.mount_point_name"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        scheduler_hints \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"4946292d_3f76da86","line":248,"updated":"2024-03-11 11:13:50.000000000","message":"no need of else, if exception is not raised we can simply assign","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5fe13130da05f84f383e5ea15c58317512c93a62","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                raise exceptions.CommandError("},{"line_number":246,"context_line":"                    \u0027Setting share mount point name is \u0027"},{"line_number":247,"context_line":"                    \u0027available only for API microversion \u003e\u003d 2.84\u0027)"},{"line_number":248,"context_line":"            else:"},{"line_number":249,"context_line":"                mount_point_name \u003d parsed_args.mount_point_name"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"        scheduler_hints \u003d {}"}],"source_content_type":"text/x-python","patch_set":9,"id":"a781234f_90f82cdb","line":248,"in_reply_to":"4946292d_3f76da86","updated":"2024-03-11 17:52:56.000000000","message":"mount_point_name is used in #291. removing else will set this value to None.","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"}],"manilaclient/tests/unit/osc/v2/test_share.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8bd9bbd84235c576ae831471e84d66e7762ba77","unresolved":true,"context_lines":[{"line_number":249,"context_line":"        verifylist \u003d ["},{"line_number":250,"context_line":"            (\u0027share_proto\u0027, self.new_share.share_proto),"},{"line_number":251,"context_line":"            (\u0027size\u0027, self.new_share.size),"},{"line_number":252,"context_line":"            (\u0027share_type\u0027, self.share_type.id),"},{"line_number":253,"context_line":"        ]"},{"line_number":254,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8fef882d_9c08ceba","line":252,"range":{"start_line":252,"start_character":46,"end_line":252,"end_character":47},"updated":"2024-02-16 02:20:13.000000000","message":"need to include mount_point_name to this list","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6bc57d17cd97ec6393d246e3bc214fb1a4dea26e","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        verifylist \u003d ["},{"line_number":250,"context_line":"            (\u0027share_proto\u0027, self.new_share.share_proto),"},{"line_number":251,"context_line":"            (\u0027size\u0027, self.new_share.size),"},{"line_number":252,"context_line":"            (\u0027share_type\u0027, self.share_type.id),"},{"line_number":253,"context_line":"        ]"},{"line_number":254,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"a1cb42c9_ed3906da","line":252,"range":{"start_line":252,"start_character":46,"end_line":252,"end_character":47},"in_reply_to":"8fef882d_9c08ceba","updated":"2024-02-21 16:17:07.000000000","message":"included mount_point_name in validation list","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":133,"context_line":"            size\u003dself.new_share.size,"},{"line_number":134,"context_line":"            snapshot_id\u003dNone,"},{"line_number":135,"context_line":"            scheduler_hints\u003d{},"},{"line_number":136,"context_line":"            mount_point_name\u003dNone"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.assertCountEqual(self.columns, columns)"}],"source_content_type":"text/x-python","patch_set":4,"id":"625f9f83_39ace6b4","line":136,"updated":"2024-02-23 10:00:51.000000000","message":"please add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            size\u003dself.new_share.size,"},{"line_number":134,"context_line":"            snapshot_id\u003dNone,"},{"line_number":135,"context_line":"            scheduler_hints\u003d{},"},{"line_number":136,"context_line":"            mount_point_name\u003dNone"},{"line_number":137,"context_line":"        )"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        self.assertCountEqual(self.columns, columns)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fd49691_c999d2af","line":136,"in_reply_to":"625f9f83_39ace6b4","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":166,"context_line":"            (\u0027property\u0027, {\u0027Manila\u0027: \u0027zorilla\u0027, \u0027Zorilla\u0027: \u0027manila\u0027}),"},{"line_number":167,"context_line":"        ]"},{"line_number":168,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":169,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":170,"context_line":"        self.shares_mock.create.assert_called_with("},{"line_number":171,"context_line":"            availability_zone\u003dNone,"},{"line_number":172,"context_line":"            description\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f2e44d4e_05bf77e2","line":169,"updated":"2024-02-23 10:00:51.000000000","message":"please don\u0027t make these unrelated whitespace adjustments. Here, the blank lines were deliberate. When writing a unit test, typically coders add a blank line between mocks and the method call, and another blank line between the method call and the asserts.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"cd75a656d5fed7adb6f1d850516195bb57983281","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            (\u0027property\u0027, {\u0027Manila\u0027: \u0027zorilla\u0027, \u0027Zorilla\u0027: \u0027manila\u0027}),"},{"line_number":167,"context_line":"        ]"},{"line_number":168,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":169,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":170,"context_line":"        self.shares_mock.create.assert_called_with("},{"line_number":171,"context_line":"            availability_zone\u003dNone,"},{"line_number":172,"context_line":"            description\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"772505cd_0a29e9e5","line":169,"in_reply_to":"e3faa231_5e2a4c42","updated":"2024-02-27 21:54:35.000000000","message":"ah; that\u0027s annoying.. hope there\u0027s a way to turn that off","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            (\u0027property\u0027, {\u0027Manila\u0027: \u0027zorilla\u0027, \u0027Zorilla\u0027: \u0027manila\u0027}),"},{"line_number":167,"context_line":"        ]"},{"line_number":168,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":169,"context_line":"        columns, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":170,"context_line":"        self.shares_mock.create.assert_called_with("},{"line_number":171,"context_line":"            availability_zone\u003dNone,"},{"line_number":172,"context_line":"            description\u003dNone,"}],"source_content_type":"text/x-python","patch_set":4,"id":"e3faa231_5e2a4c42","line":169,"in_reply_to":"f2e44d4e_05bf77e2","updated":"2024-02-27 04:57:49.000000000","message":"Pycharm auto correct is doing this changes. I will be careful next time.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":180,"context_line":"            size\u003dself.new_share.size,"},{"line_number":181,"context_line":"            snapshot_id\u003dNone,"},{"line_number":182,"context_line":"            scheduler_hints\u003d{},"},{"line_number":183,"context_line":"            mount_point_name\u003dNone"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.assertCountEqual(self.columns, columns)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1556716e_c6c44db5","line":183,"updated":"2024-02-23 10:00:51.000000000","message":"please add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"9bebbfbcd48070fa72f74629e4258cea50dd2f53","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            size\u003dself.new_share.size,"},{"line_number":181,"context_line":"            snapshot_id\u003dNone,"},{"line_number":182,"context_line":"            scheduler_hints\u003d{},"},{"line_number":183,"context_line":"            mount_point_name\u003dNone"},{"line_number":184,"context_line":"        )"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        self.assertCountEqual(self.columns, columns)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ddae0b09_086d917c","line":183,"in_reply_to":"1556716e_c6c44db5","updated":"2024-02-27 04:58:05.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":234,"context_line":"        self.assertCountEqual(self.datalist, data)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def test_share_create_mount_point_name(self):"},{"line_number":237,"context_line":"        \"\"\"Verifies scheduler hints are parsed correctly.\"\"\""},{"line_number":238,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":239,"context_line":"            \"2.83\")"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"fb861db1_ab48604f","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":60},"updated":"2024-02-23 10:00:51.000000000","message":"Verifies mount point name is parsed correctly?","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        self.assertCountEqual(self.datalist, data)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def test_share_create_mount_point_name(self):"},{"line_number":237,"context_line":"        \"\"\"Verifies scheduler hints are parsed correctly.\"\"\""},{"line_number":238,"context_line":"        self.app.client_manager.share.api_version \u003d api_versions.APIVersion("},{"line_number":239,"context_line":"            \"2.83\")"},{"line_number":240,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b97cfbbd_7b983a55","line":237,"range":{"start_line":237,"start_character":8,"end_line":237,"end_character":60},"in_reply_to":"fb861db1_ab48604f","updated":"2024-02-27 04:57:49.000000000","message":"update text to mount point name.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":313,"context_line":"            size\u003dself.new_share.size,"},{"line_number":314,"context_line":"            snapshot_id\u003dself.share_snapshot.id,"},{"line_number":315,"context_line":"            scheduler_hints\u003d{},"},{"line_number":316,"context_line":"            mount_point_name\u003dNone"},{"line_number":317,"context_line":"        )"},{"line_number":318,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":319,"context_line":"        self.assertCountEqual(self.datalist, data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"39c9e1b8_4a0412ac","line":316,"updated":"2024-02-23 10:00:51.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            size\u003dself.new_share.size,"},{"line_number":314,"context_line":"            snapshot_id\u003dself.share_snapshot.id,"},{"line_number":315,"context_line":"            scheduler_hints\u003d{},"},{"line_number":316,"context_line":"            mount_point_name\u003dNone"},{"line_number":317,"context_line":"        )"},{"line_number":318,"context_line":"        self.assertCountEqual(self.columns, columns)"},{"line_number":319,"context_line":"        self.assertCountEqual(self.datalist, data)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5d343148_56cd5677","line":316,"in_reply_to":"39c9e1b8_4a0412ac","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":350,"context_line":"            size\u003dself.new_share.size,"},{"line_number":351,"context_line":"            snapshot_id\u003dNone,"},{"line_number":352,"context_line":"            scheduler_hints\u003d{},"},{"line_number":353,"context_line":"            mount_point_name\u003dNone"},{"line_number":354,"context_line":"        )"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        self.shares_mock.get.assert_called_with(self.new_share.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9862b1a3_ab69a9ae","line":353,"updated":"2024-02-23 10:00:51.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"            size\u003dself.new_share.size,"},{"line_number":351,"context_line":"            snapshot_id\u003dNone,"},{"line_number":352,"context_line":"            scheduler_hints\u003d{},"},{"line_number":353,"context_line":"            mount_point_name\u003dNone"},{"line_number":354,"context_line":"        )"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"        self.shares_mock.get.assert_called_with(self.new_share.id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"39b28a45_ad17c2a8","line":353,"in_reply_to":"9862b1a3_ab69a9ae","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":391,"context_line":"                size\u003dself.new_share.size,"},{"line_number":392,"context_line":"                snapshot_id\u003dNone,"},{"line_number":393,"context_line":"                scheduler_hints\u003d{},"},{"line_number":394,"context_line":"                mount_point_name\u003dNone"},{"line_number":395,"context_line":"            )"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            mock_logger.error.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"8e7ab435_5f262b59","line":394,"updated":"2024-02-23 10:00:51.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                size\u003dself.new_share.size,"},{"line_number":392,"context_line":"                snapshot_id\u003dNone,"},{"line_number":393,"context_line":"                scheduler_hints\u003d{},"},{"line_number":394,"context_line":"                mount_point_name\u003dNone"},{"line_number":395,"context_line":"            )"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"            mock_logger.error.assert_called_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ed811a5_e5690196","line":394,"in_reply_to":"8e7ab435_5f262b59","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"}],"manilaclient/tests/unit/test_api_versions.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e8bd9bbd84235c576ae831471e84d66e7762ba77","unresolved":true,"context_lines":[{"line_number":122,"context_line":"    @ddt.data(\"2.0\","},{"line_number":123,"context_line":"              \"2.5\","},{"line_number":124,"context_line":"              \"2.45\","},{"line_number":125,"context_line":"              \"2.83\","},{"line_number":126,"context_line":"              \"3.3\","},{"line_number":127,"context_line":"              \"3.23\","},{"line_number":128,"context_line":"              \"2.0\","}],"source_content_type":"text/x-python","patch_set":3,"id":"8527097c_eb550b87","line":125,"updated":"2024-02-16 02:20:13.000000000","message":"no point changing these tests.. there\u0027s no functional change by bumping the version that\u0027ll need to be tested here","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"6bc57d17cd97ec6393d246e3bc214fb1a4dea26e","unresolved":false,"context_lines":[{"line_number":122,"context_line":"    @ddt.data(\"2.0\","},{"line_number":123,"context_line":"              \"2.5\","},{"line_number":124,"context_line":"              \"2.45\","},{"line_number":125,"context_line":"              \"2.83\","},{"line_number":126,"context_line":"              \"3.3\","},{"line_number":127,"context_line":"              \"3.23\","},{"line_number":128,"context_line":"              \"2.0\","}],"source_content_type":"text/x-python","patch_set":3,"id":"d34d549b_5abfc99f","line":125,"in_reply_to":"8527097c_eb550b87","updated":"2024-02-21 16:17:07.000000000","message":"removed unnecessary version","commit_id":"40ea7278d6ba1deb168b8de13421f02b651f1b72"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @mock.patch(\"manilaclient.api_versions.APIVersion\")"},{"line_number":156,"context_line":"    def test_major_and_minor_parts_is_presented(self, mock_apiversion):"},{"line_number":157,"context_line":"        version \u003d \"2.83\""},{"line_number":158,"context_line":"        self.assertEqual(mock_apiversion.return_value,"},{"line_number":159,"context_line":"                         api_versions.get_api_version(version))"},{"line_number":160,"context_line":"        mock_apiversion.assert_called_once_with(version)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a5712eb4_2c6519c4","line":157,"updated":"2024-02-23 10:00:51.000000000","message":"this change isn\u0027t necessary at all..","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @mock.patch(\"manilaclient.api_versions.APIVersion\")"},{"line_number":156,"context_line":"    def test_major_and_minor_parts_is_presented(self, mock_apiversion):"},{"line_number":157,"context_line":"        version \u003d \"2.83\""},{"line_number":158,"context_line":"        self.assertEqual(mock_apiversion.return_value,"},{"line_number":159,"context_line":"                         api_versions.get_api_version(version))"},{"line_number":160,"context_line":"        mock_apiversion.assert_called_once_with(version)"}],"source_content_type":"text/x-python","patch_set":4,"id":"559c8d2a_806e3691","line":157,"in_reply_to":"a5712eb4_2c6519c4","updated":"2024-02-27 04:57:49.000000000","message":"reverted back to old version","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"}],"manilaclient/tests/unit/v2/test_shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":112,"context_line":"            \u0027is_public\u0027: False,"},{"line_number":113,"context_line":"            \u0027availability_zone\u0027: None,"},{"line_number":114,"context_line":"            \u0027scheduler_hints\u0027: dict(),"},{"line_number":115,"context_line":"            \u0027mount_point_name\u0027: None"},{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"        cs.shares.create(\u0027nfs\u0027, 1, share_type\u003dshare_type)"},{"line_number":118,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027, {\u0027share\u0027: expected})"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8d65c27_e041f328","line":115,"updated":"2024-02-23 10:00:51.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            \u0027is_public\u0027: False,"},{"line_number":113,"context_line":"            \u0027availability_zone\u0027: None,"},{"line_number":114,"context_line":"            \u0027scheduler_hints\u0027: dict(),"},{"line_number":115,"context_line":"            \u0027mount_point_name\u0027: None"},{"line_number":116,"context_line":"        }"},{"line_number":117,"context_line":"        cs.shares.create(\u0027nfs\u0027, 1, share_type\u003dshare_type)"},{"line_number":118,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027, {\u0027share\u0027: expected})"}],"source_content_type":"text/x-python","patch_set":4,"id":"b2919378_4e2c8f70","line":115,"in_reply_to":"a8d65c27_e041f328","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                \u0027size\u0027: 1,"},{"line_number":138,"context_line":"                \u0027availability_zone\u0027: availability_zone,"},{"line_number":139,"context_line":"                \u0027scheduler_hints\u0027: {},"},{"line_number":140,"context_line":"                \u0027mount_point_name\u0027: None"},{"line_number":141,"context_line":"            }"},{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":"        cs.shares.create(\u0027nfs\u0027, 1, is_public\u003dis_public,"}],"source_content_type":"text/x-python","patch_set":4,"id":"13d083b2_bd2253d5","line":140,"updated":"2024-02-23 10:00:51.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                \u0027size\u0027: 1,"},{"line_number":138,"context_line":"                \u0027availability_zone\u0027: availability_zone,"},{"line_number":139,"context_line":"                \u0027scheduler_hints\u0027: {},"},{"line_number":140,"context_line":"                \u0027mount_point_name\u0027: None"},{"line_number":141,"context_line":"            }"},{"line_number":142,"context_line":"        }"},{"line_number":143,"context_line":"        cs.shares.create(\u0027nfs\u0027, 1, is_public\u003dis_public,"}],"source_content_type":"text/x-python","patch_set":4,"id":"37d7b934_7118c951","line":140,"in_reply_to":"13d083b2_bd2253d5","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":144,"context_line":"                         availability_zone\u003davailability_zone)"},{"line_number":145,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027, body)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @ddt.data({\u0027mount_point_name\u0027: \u0027fack_mount_pt1\u0027},"},{"line_number":148,"context_line":"              {\u0027mount_point_name\u0027: \u0027fack_mount_pt2\u0027})"},{"line_number":149,"context_line":"    @ddt.unpack"},{"line_number":150,"context_line":"    def test_create_share_with_mount_point_name(self, mount_point_name):"},{"line_number":151,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc823bd5_4693d829","line":148,"range":{"start_line":147,"start_character":3,"end_line":148,"end_character":53},"updated":"2024-02-23 10:00:51.000000000","message":"This can just be: @ddt.data(\u0027fake_mount_pt1\u0027, \u0027fake_mount_pt1\u0027)\n\n    (Also please check the spelling of \"fake\" here)","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                         availability_zone\u003davailability_zone)"},{"line_number":145,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/shares\u0027, body)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    @ddt.data({\u0027mount_point_name\u0027: \u0027fack_mount_pt1\u0027},"},{"line_number":148,"context_line":"              {\u0027mount_point_name\u0027: \u0027fack_mount_pt2\u0027})"},{"line_number":149,"context_line":"    @ddt.unpack"},{"line_number":150,"context_line":"    def test_create_share_with_mount_point_name(self, mount_point_name):"},{"line_number":151,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"79f534c8_76b2e319","line":148,"range":{"start_line":147,"start_character":3,"end_line":148,"end_character":53},"in_reply_to":"fc823bd5_4693d829","updated":"2024-02-27 04:57:49.000000000","message":"corrected typo","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                \u0027size\u0027: 1,"},{"line_number":162,"context_line":"                \u0027availability_zone\u0027: None,"},{"line_number":163,"context_line":"                \u0027scheduler_hints\u0027: {},"},{"line_number":164,"context_line":"                \u0027mount_point_name\u0027: mount_point_name"},{"line_number":165,"context_line":"            }"},{"line_number":166,"context_line":"        }"},{"line_number":167,"context_line":"        cs.shares.create(\u0027nfs\u0027, 1, mount_point_name\u003dmount_point_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"f21e0f3c_0739f230","line":164,"updated":"2024-02-23 10:00:51.000000000","message":"add a trailing comma at the end of this item/line","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                \u0027size\u0027: 1,"},{"line_number":162,"context_line":"                \u0027availability_zone\u0027: None,"},{"line_number":163,"context_line":"                \u0027scheduler_hints\u0027: {},"},{"line_number":164,"context_line":"                \u0027mount_point_name\u0027: mount_point_name"},{"line_number":165,"context_line":"            }"},{"line_number":166,"context_line":"        }"},{"line_number":167,"context_line":"        cs.shares.create(\u0027nfs\u0027, 1, mount_point_name\u003dmount_point_name)"}],"source_content_type":"text/x-python","patch_set":4,"id":"eb6b6fa1_98b4d994","line":164,"in_reply_to":"f21e0f3c_0739f230","updated":"2024-02-27 04:57:49.000000000","message":"added trailing comma in all places.","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"}],"manilaclient/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":125,"context_line":"               description\u003dNone, metadata\u003dNone, share_network\u003dNone,"},{"line_number":126,"context_line":"               share_type\u003dNone, is_public\u003dFalse, availability_zone\u003dNone,"},{"line_number":127,"context_line":"               share_group_id\u003dNone, scheduler_hints\u003dNone, return_raw\u003dFalse,"},{"line_number":128,"context_line":"               mount_point_name\u003dNone):"},{"line_number":129,"context_line":"        \"\"\"Create a share."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        :param share_proto: text - share protocol for new share available"}],"source_content_type":"text/x-python","patch_set":4,"id":"8f7a26f3_adf8812a","line":128,"range":{"start_line":128,"start_character":15,"end_line":128,"end_character":31},"updated":"2024-02-23 10:00:51.000000000","message":"can you add \"mount_point_name\" to the docstring?","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"               description\u003dNone, metadata\u003dNone, share_network\u003dNone,"},{"line_number":126,"context_line":"               share_type\u003dNone, is_public\u003dFalse, availability_zone\u003dNone,"},{"line_number":127,"context_line":"               share_group_id\u003dNone, scheduler_hints\u003dNone, return_raw\u003dFalse,"},{"line_number":128,"context_line":"               mount_point_name\u003dNone):"},{"line_number":129,"context_line":"        \"\"\"Create a share."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        :param share_proto: text - share protocol for new share available"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea497e4a_30b807ab","line":128,"range":{"start_line":128,"start_character":15,"end_line":128,"end_character":31},"in_reply_to":"8f7a26f3_adf8812a","updated":"2024-02-27 04:57:49.000000000","message":"added docs for mount_point_name","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aef75c7b77a48a92123b388027d6fcd0b2470bb8","unresolved":true,"context_lines":[{"line_number":160,"context_line":"            \u0027is_public\u0027: is_public,"},{"line_number":161,"context_line":"            \u0027availability_zone\u0027: availability_zone,"},{"line_number":162,"context_line":"            \u0027scheduler_hints\u0027: scheduler_hints,"},{"line_number":163,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":164,"context_line":"        }"},{"line_number":165,"context_line":"        if share_group_id:"},{"line_number":166,"context_line":"            body[\u0027share_group_id\u0027] \u003d share_group_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"139556f3_69b62f55","line":163,"range":{"start_line":163,"start_character":13,"end_line":163,"end_character":29},"updated":"2024-02-23 10:00:51.000000000","message":"I know other options should also have followed this format... please don\u0027t send mount_point_name unless it is specified\n\n```\n\n    if mount_point_name:\n       body[\u0027mount_point_name\u0027] \u003d mount_point_name\n       \n```","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"41a6f1bfc60ab04e23ded662efec864499cb1b1b","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            \u0027is_public\u0027: is_public,"},{"line_number":161,"context_line":"            \u0027availability_zone\u0027: availability_zone,"},{"line_number":162,"context_line":"            \u0027scheduler_hints\u0027: scheduler_hints,"},{"line_number":163,"context_line":"            \u0027mount_point_name\u0027: mount_point_name,"},{"line_number":164,"context_line":"        }"},{"line_number":165,"context_line":"        if share_group_id:"},{"line_number":166,"context_line":"            body[\u0027share_group_id\u0027] \u003d share_group_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"e4866700_60483226","line":163,"range":{"start_line":163,"start_character":13,"end_line":163,"end_character":29},"in_reply_to":"139556f3_69b62f55","updated":"2024-02-27 04:57:49.000000000","message":"added optional value format","commit_id":"e70a077a3ddac264ec7e76f161dd788bbf3848c7"}],"releasenotes/notes/human-readable-export-location-share-support-d156f23669e458fa.yaml":[{"author":{"_account_id":36178,"name":"Saravanan Manickam","display_name":"msaravan","email":"manicsaran@gmail.com","username":"msaravan"},"change_message_id":"f861a7d16db78e72436c0fb5eb6fc4c019ad9c22","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    command. This will reflect a user-friendly ``mount_point_name`` in the "},{"line_number":5,"context_line":"    share\u0027s export location. To allow users to specify a custom mount point"},{"line_number":6,"context_line":"    for their shares, administrators must enable this extra-specification in "},{"line_number":7,"context_line":"    the share type. Additionally, they must provide an extra-spec named"},{"line_number":8,"context_line":"    ``provisioning:mount_point_prefix``. The service will use this prefix along"},{"line_number":9,"context_line":"    with the mount point name provided by end users during share creation."},{"line_number":10,"context_line":"    If ``provisioning:mount_point_prefix`` is not set on a share type, but"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"effe517b_272077dc","line":7,"updated":"2024-03-09 13:21:31.000000000","message":"You didnt mention the share type property \"mount_point_name_support\" here. It should be \"To allow users to specify a custom mount point for their shares, administrators must enable the extra-specification mount_point_name_support in  the share type\"","commit_id":"8b3046518d128256af2a00934c64cc7f613ee8f7"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"d5583a991e950016d552f0d9fb53450cd80be777","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    command. This will reflect a user-friendly ``mount_point_name`` in the "},{"line_number":5,"context_line":"    share\u0027s export location. To allow users to specify a custom mount point"},{"line_number":6,"context_line":"    for their shares, administrators must enable this extra-specification in "},{"line_number":7,"context_line":"    the share type. Additionally, they must provide an extra-spec named"},{"line_number":8,"context_line":"    ``provisioning:mount_point_prefix``. The service will use this prefix along"},{"line_number":9,"context_line":"    with the mount point name provided by end users during share creation."},{"line_number":10,"context_line":"    If ``provisioning:mount_point_prefix`` is not set on a share type, but"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"a617cc33_2a7924bd","line":7,"in_reply_to":"effe517b_272077dc","updated":"2024-03-11 03:54:43.000000000","message":"Thank you! Saravanan. \"mount_point_name_support\" capability details are added now.","commit_id":"8b3046518d128256af2a00934c64cc7f613ee8f7"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"b5f1169c84d66219f6cbd243f1ad45bf99b66ece","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - In the 2.84 API version, a new option, ``mount_point_name``, has been"},{"line_number":4,"context_line":"    introduced to the share creation command. This option allows users"},{"line_number":5,"context_line":"    to specify a more intuitive ``mount_point_name`` that will be reflected"},{"line_number":6,"context_line":"    in the share\u0027s export location. However, for this feature to be available"},{"line_number":7,"context_line":"    to users, administrators must first enable an extra-spec in the"},{"line_number":8,"context_line":"    share type. In addition, administrators need to set an extra-spec named"},{"line_number":9,"context_line":"    ``provisioning:mount_point_prefix``. The service will combine this prefix"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ef2e8df_96ead955","line":6,"updated":"2024-03-11 11:13:50.000000000","message":"at line 4 --\u003e This option allow users...\nat line 9 --\u003e The Manila service..\nat line 10 --\u003e that user provides\nat line 13 --\u003e space after prefix.","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":36171,"name":"jayaanand borra","display_name":"jayaanand borra","email":"jayaanand.borra@netapp.com","username":"jayaanan","status":"netapp"},"change_message_id":"5fe13130da05f84f383e5ea15c58317512c93a62","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - In the 2.84 API version, a new option, ``mount_point_name``, has been"},{"line_number":4,"context_line":"    introduced to the share creation command. This option allows users"},{"line_number":5,"context_line":"    to specify a more intuitive ``mount_point_name`` that will be reflected"},{"line_number":6,"context_line":"    in the share\u0027s export location. However, for this feature to be available"},{"line_number":7,"context_line":"    to users, administrators must first enable an extra-spec in the"},{"line_number":8,"context_line":"    share type. In addition, administrators need to set an extra-spec named"},{"line_number":9,"context_line":"    ``provisioning:mount_point_prefix``. The service will combine this prefix"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"cd0d932a_565d3f71","line":6,"in_reply_to":"5ef2e8df_96ead955","updated":"2024-03-11 17:52:56.000000000","message":"Updated as suggested.","commit_id":"11007fb4df872bf11dc643b67f9ac1a1ebcc8881"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fe130419a1f4b835069c4eb0d3cab92b715060fd","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    Please note that shares created with a project_id prefix cannot be"},{"line_number":15,"context_line":"    transferred. To move these shares to a different project,"},{"line_number":16,"context_line":"    an admin must manually unmount them from the current project and mount"},{"line_number":17,"context_line":"    them to the target project. A new capability, ``mount_point_name_support``,"},{"line_number":18,"context_line":"    allows the driver to inform the scheduler about its support for the"},{"line_number":19,"context_line":"    mount_point_name feature."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"58500fad_d11f25bc","line":19,"range":{"start_line":17,"start_character":32,"end_line":19,"end_character":29},"updated":"2024-03-11 18:38:41.000000000","message":"Thanks for the detailed note; this portion isn\u0027t relevant to the CLI","commit_id":"b097cec84fa7860b8892167203ea0b7d00b38137"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"e2e62818ed20440b893d42dbab75b636e064b41f","unresolved":true,"context_lines":[{"line_number":14,"context_line":"    Please note that shares created with a project_id prefix cannot be"},{"line_number":15,"context_line":"    transferred. To move these shares to a different project,"},{"line_number":16,"context_line":"    an admin must manually unmount them from the current project and mount"},{"line_number":17,"context_line":"    them to the target project. A new capability, ``mount_point_name_support``,"},{"line_number":18,"context_line":"    allows the driver to inform the scheduler about its support for the"},{"line_number":19,"context_line":"    mount_point_name feature."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"bb4d6472_708440ce","line":19,"range":{"start_line":17,"start_character":32,"end_line":19,"end_character":29},"in_reply_to":"58500fad_d11f25bc","updated":"2024-03-12 21:18:47.000000000","message":"++ - please remove it in a follow-up change :)","commit_id":"b097cec84fa7860b8892167203ea0b7d00b38137"}]}